@exodus/ethereum-api 7.0.18 → 7.2.0

package/src/tx-log/ethereum-monitor.js

@@ -49,11 +49,8 @@ export class EthereumMonitor extends BaseMonitor {
   async deriveData({ assetSource, tokens }) {
     const { asset: assetName, walletAccount } = assetSource
 
-    const {
-      ourWalletAddress,
-      currentAccountState,
-      minimumConfirmations,
-    } = await this.deriveDataNeededForTick({ assetName, walletAccount })
+    const { ourWalletAddress, currentAccountState, minimumConfirmations } =
+      await this.deriveDataNeededForTick({ assetName, walletAccount })
     const transactionsToCheck = await this.deriveTransactionsToCheck({
       assetName,
       walletAccount,
@@ -71,10 +68,8 @@ export class EthereumMonitor extends BaseMonitor {
 
   // eslint-disable-next-line no-undef
   async checkPendingTransactions(params) {
-    const {
-      pendingTransactionsToCheck,
-      pendingTransactionsGroupedByAddressAndNonce,
-    } = checkPendingTransactions(params)
+    const { pendingTransactionsToCheck, pendingTransactionsGroupedByAddressAndNonce } =
+      checkPendingTransactions(params)
     const txsToRemove = []
     const {
       assetSource: { walletAccount },
@@ -220,6 +215,7 @@ export class EthereumMonitor extends BaseMonitor {
       const balance = new BN(hex, 'hex').toString()
       newAccountState.balance = asset.currency.baseUnit(balance)
     }
+
     const tokenBalancePairs = await Promise.all(
       tokens
         .filter((token) => isRpcBalanceAsset(token) && token.contract.address)
@@ -245,6 +241,7 @@ export class EthereumMonitor extends BaseMonitor {
         useCache: true,
       })
     }
+
     return addressesByAccount
   }
 
@@ -265,10 +262,10 @@ export class EthereumMonitor extends BaseMonitor {
         if (!tokensByAddress.has(addr)) {
           acc.add(addr)
         }
-      }, acc)
+      })
       return acc
     }, new Set())
-    return Array.from(set)
+    return [...set]
   }
 
   async beforeStart() {

package/src/tx-log/ethereum-no-history-monitor.js

@@ -33,6 +33,7 @@ export class EthereumNoHistoryMonitor extends BaseMonitor {
       this.server.setURI(DEFAULT_SERVER_URLS[this.asset.name])
       return
     }
+
     if (config.server === this.server.uri) return
     this.server.setURI(config.server)
   }
@@ -45,10 +46,12 @@ export class EthereumNoHistoryMonitor extends BaseMonitor {
       const request = this.server.balanceOfRequest(ourWalletAddress, token.contract.address)
       batch[token.name] = request
     }
+
     const pairs = Object.entries(batch)
-    if (!pairs.length) {
+    if (pairs.length === 0) {
       return {}
     }
+
     const requests = pairs.map((pair) => pair[1])
     const responses = await this.server.sendBatchRequest(requests)
     const entries = pairs.map((pair, idx) => {
@@ -74,7 +77,7 @@ export class EthereumNoHistoryMonitor extends BaseMonitor {
         const value = token.currency.baseUnit(pair[1] || 0)
         return [token.name, value]
       })
-      .filter((pair) => pair)
+      .filter(Boolean)
 
     const tokenBalances = excludeUnchangedTokenBalances(currentTokenBalances, tokenBalanceEntries)
     if (!isEmpty(tokenBalances)) newAccountState.tokenBalances = tokenBalances
@@ -89,15 +92,13 @@ export class EthereumNoHistoryMonitor extends BaseMonitor {
       walletAccount,
     })
 
-    const {
-      pendingTransactionsGroupedByAddressAndNonce,
-      pendingTransactionsToCheck,
-    } = await this.deriveTransactionsToCheck({
-      assetName,
-      walletAccount,
-      tokens,
-      ourWalletAddress,
-    })
+    const { pendingTransactionsGroupedByAddressAndNonce, pendingTransactionsToCheck } =
+      await this.deriveTransactionsToCheck({
+        assetName,
+        walletAccount,
+        tokens,
+        ourWalletAddress,
+      })
 
     const pendingTransactions = unionBy(
       Object.values(pendingTransactionsGroupedByAddressAndNonce),
@@ -114,6 +115,7 @@ export class EthereumNoHistoryMonitor extends BaseMonitor {
       const request = this.server.getTransactionByHashRequest(tx.txId)
       batch.push(request)
     }
+
     const responses = await this.server.sendBatchRequest(batch)
     const txIds = transactions.map(({ tx }) => tx.txId)
     return zipObject(txIds, responses)

package/src/tx-log/monitor-utils/check-pending-transactions.js

@@ -9,6 +9,7 @@ export default function checkPendingTransactions({
   asset,
 }) {
   for (const tx of txlist) {
+    // eslint-disable-next-line @exodus/mutable/no-param-reassign-prop-only
     delete pendingTransactionsToCheck[tx.txId || tx.hash] // Found this transaction, do not mark it as dropped
 
     // check if this TX replaces another pending TX
@@ -23,6 +24,7 @@ export default function checkPendingTransactions({
       ) {
         continue
       }
+
       replacedTx.replaced = true
     }
   }

package/src/tx-log/monitor-utils/exclude-unchanged-token-balances.js

@@ -1,13 +1,12 @@
 export function excludeUnchangedTokenBalances(currentTokenBalances, newTokenBalancePairs) {
   const newTokenBalances = Object.fromEntries(newTokenBalancePairs)
 
-  const tokenBalances = newTokenBalancePairs.reduce((tokenBalancesAcc, [token, balance]) => {
+  return newTokenBalancePairs.reduce((tokenBalancesAcc, [token, balance]) => {
     const currentBalance = currentTokenBalances[token]
     if (!newTokenBalances[token].isZero || (currentBalance && !currentBalance.isZero)) {
       tokenBalancesAcc[token] = balance
     }
+
     return tokenBalancesAcc
   }, {})
-
-  return tokenBalances
 }

package/src/tx-log/monitor-utils/get-derive-data-needed-for-tick.js

@@ -1,7 +1,7 @@
 // A super-selector that returns all the current data needed for a tick of the ETH monitor.
 
 export default function getDeriveDataNeededForTick(aci) {
-  return async function({ assetName, walletAccount }) {
+  return async function ({ assetName, walletAccount }) {
     const receiveAddress = await aci.getReceiveAddress({ assetName, walletAccount, useCache: true })
     const currentAccountState = await aci.getAccountState({ assetName, walletAccount })
     const minimumConfirmations = await aci.getConfirmationsNumber({ assetName })

package/src/tx-log/monitor-utils/get-derive-transactions-to-check.js

@@ -3,7 +3,7 @@ import getSenderNonceKey from './get-sender-nonce-key'
 
 export const UNCONFIRMED_TX_LIMIT = ms('5m')
 
-const mapToObject = (map) => Object.fromEntries([...map.entries()]) // only for string keys
+const mapToObject = (map) => Object.fromEntries(map.entries()) // only for string keys
 
 export default function getDeriveTransactionsToCheck({ getTxLog }) {
   return async ({ assetName: _assetName, walletAccount, tokens, ourWalletAddress }) => {
@@ -23,6 +23,7 @@ export default function getDeriveTransactionsToCheck({ getTxLog }) {
         ) {
           pendingTransactionsToCheck.set(tx.txId, { tx, assetName })
         }
+
         if (tx.meta.simulated) simulatedTransactions.set(tx.txId, tx)
 
         const senderNonceKey = getSenderNonceKey(tx, ourWalletAddress)

package/src/tx-log/monitor-utils/get-log-items-from-server-tx.js

@@ -28,7 +28,9 @@ export default function getLogItemsFromServerTx({
   const toAddress = tryFindExternalRecipient(ethereumTransfers, ourWalletAddress)
   const ourWalletWasSender = serverTx.from === ourWalletAddress
   const METHOD_ID_LENGTH = 10
-  const methodId = serverTx.data && { methodId: serverTx.data.substring(0, METHOD_ID_LENGTH) }
+  const methodId = serverTx.data && {
+    methodId: serverTx.data.slice(0, Math.max(0, METHOD_ID_LENGTH)),
+  }
   const data = serverTx.data || '0x'
   const logItemCommonProperties = {
     confirmations,
@@ -83,6 +85,7 @@ export default function getLogItemsFromServerTx({
       ])
     }
   }
+
   // handle erc20
   Object.entries(tokenTransfersByTokenName).forEach(([tokenName, tokenTransfers]) => {
     const sendingTransferPresent = tokenTransfers.some(({ from }) => from === ourWalletAddress)
@@ -154,7 +157,7 @@ function isSelfSendTx({
 }
 
 function isNftTransfer({ serverTx, ourWalletAddress }) {
-  if (!Array.isArray(serverTx.erc721) || serverTx.erc721.length < 1) return false
+  if (!Array.isArray(serverTx.erc721) || serverTx.erc721.length === 0) return false
 
   return serverTx.erc721.some(
     (transfer) => transfer.to === ourWalletAddress || transfer.from === ourWalletAddress

package/src/tx-log/ws-updates.js

@@ -11,7 +11,7 @@ export function subscribeToWSNotifications({
   beforeStart = false,
 }) {
   Object.entries(addressesByWalletAccount).forEach(([walletAccount, addresses]) => {
-    const address = String(Array.from(addresses)[0]).toLowerCase() // Only check m/0/0
+    const address = String([...addresses][0]).toLowerCase() // Only check m/0/0
     const mapKey = `${server.getURL()}:${address}` // different chains might have the same addresses
     if (subscribedToAddressNotificationsMap.has(mapKey)) return
 

package/src/websocket/index.js

@@ -11,10 +11,11 @@ if (typeof process !== 'undefined' && (process.type === 'renderer' || process.ty
   } else {
     module.exports = require('ws')
   }
-} else if (typeof WebSocket !== 'undefined') {
-  // THIS IS FOR BE
-  module.exports = globalThis.WebSocket
-} else {
+  // eslint-disable-next-line no-undef
+} else if (typeof WebSocket === 'undefined') {
   // THIS IS FOR UNIT TESTING.
   module.exports = require('ws')
+} else {
+  // THIS IS FOR BE
+  module.exports = globalThis.WebSocket
 }