@exodus/ethereum-api 7.0.18 → 7.2.0

package/src/fee-monitor/ethereumsepolia.js

@@ -0,0 +1,18 @@
+import { EthereumLikeFeeMonitor } from '@exodus/ethereum-lib'
+import { getServerByName } from '../exodus-eth-server'
+
+const assetName = 'ethereumsepolia'
+
+// @deprecated use ./server-based-fee-monitor.js
+export class EthereumSepoliaFeeMonitor extends EthereumLikeFeeMonitor {
+  constructor({ updateFee, interval }) {
+    const server = getServerByName(assetName)
+    const getGasPrice = (...args) => server.gasPrice(...args)
+    super({
+      updateFee,
+      assetName,
+      getGasPrice,
+      interval,
+    })
+  }
+}

package/src/fee-monitor/index.js

@@ -4,6 +4,7 @@ export * from './ethereum'
 export * from './ethereumclassic'
 export * from './ethereumgoerli'
 export * from './ethereumholesky'
+export * from './ethereumsepolia'
 export * from './bsc'
 export * from './polygon'
 export * from './avalanchec'

package/src/fee-monitor/optimism.js

@@ -9,7 +9,10 @@ export class OptimismFeeMonitor extends EthereumLikeFeeMonitor {
     super({
       updateFee,
       assetName,
-      getGasPrice: async () => (await getServerByName(assetName).getFee())?.gasPrice,
+      getGasPrice: async () => {
+        const fee = await getServerByName(assetName).getFee()
+        return fee?.gasPrice
+      },
       interval,
     })
   }

package/src/gas-estimation.js

@@ -51,9 +51,10 @@ export async function fetchGasLimit({
   extraPercentage,
 }) {
   if (bip70?.bitpay?.data && bip70?.bitpay?.gasPrice)
-    return asset.name === 'ethereum' ? 65000 : 130000 // from on chain stats https://dune.xyz/queries/189123
+    return asset.name === 'ethereum' ? 65_000 : 130_000 // from on chain stats https://dune.xyz/queries/189123
 
   if (!amount) amount = asset.currency.ZERO
+  // eslint-disable-next-line @exodus/mutable/no-param-reassign-prop-only
   if (!feeData.gasPrice) feeData.gasPrice = asset.baseAsset.currency.ZERO
 
   const defaultGasLimit = () =>
@@ -67,6 +68,7 @@ export async function fetchGasLimit({
         asset.contract.transfer.build(toAddress.toLowerCase(), amount.toBaseString())
       )
     }
+
     amount = asset.baseAsset.currency.ZERO
     toAddress = asset.contract.address
   } else if (!isContract && !['ethereumarbone', 'ethereumarbnova'].includes(asset.name)) {

package/src/get-balances.js

@@ -13,6 +13,7 @@ const fixBalance = ({ txLog, balance }) => {
       }
     }
   }
+
   return balance
 }
 
@@ -36,7 +37,7 @@ const getBalance = ({ asset, accountState, txLog }) => {
 
   const shouldFixBalance = isRpcBalanceAsset(asset)
 
-  if (['ethereum', 'ethereumgoerli', 'ethereumholesky'].includes(asset.name)) {
+  if (['ethereum', 'ethereumgoerli', 'ethereumholesky', 'ethereumsepolia'].includes(asset.name)) {
     const { balance: ethereumBalance } = getEthereumBalances({
       asset,
       liquidBalance: balance,

package/src/simulate-tx/simulate-eth-tx.js

@@ -141,8 +141,8 @@ async function tryToDecodeApprovalTransaction(transaction, asset) {
 
     const [grantedTo, balance] = decodedInput.values
 
-    const symbol =
-      (await getAssetSymbolFromContract(transaction.to, asset))?.toUpperCase() || 'Unknown Token'
+    const symbolFromContract = await getAssetSymbolFromContract(transaction.to, asset)
+    const symbol = symbolFromContract?.toUpperCase() || 'Unknown Token'
 
     return [{ grantedTo, balance, symbol, decimals: undefined }] // ToDo: Return 'decimals' in the future once we support changing the approval amount.
   } catch (e) {
@@ -215,12 +215,13 @@ export async function retrieveSideEffects({ transaction, asset, shouldSimulate =
               title: `${assetData.title || assetData.symbol} #${delta}`,
             }
           }
+
           willReceive.push(account)
         }
       }
     }
 
-    if (!willSend.length) {
+    if (willSend.length === 0) {
       willSend.push({
         symbol: 'ETH',
         balance: `-${ethHexToInt(transaction.value)}`,

package/src/staking/ethereum/api.js

@@ -21,6 +21,7 @@ export class EthereumStaking {
       EVERSTAKE_ADDRESS_CONTRACT_POOL: '0xAFA848357154a6a624686b348303EF9a13F63264',
     },
   }
+
   static METHODS_IDS = {
     DELEGATE: '0x3a29dbae', // stake(uint256 source)
     UNSTAKE: '0x76ec871c', // unstake(uint256 amount)
@@ -45,8 +46,7 @@ export class EthereumStaking {
   }
 
   buildTxData = (contract, method, ...args) => {
-    const txData = contract[method].build(...args)
-    return txData
+    return contract[method].build(...args)
   }
 
   callReadFunctionContract = (contract, method, ...args) => {
@@ -152,9 +152,9 @@ export class EthereumStaking {
         amount,
         data: bufferToHex(this.buildTxData(this.contractPool, 'stake', source)), // tx data field
       }
-    } else {
-      throw new Error(`Min Amount ${this.minAmount}`)
     }
+
+    throw new Error(`Min Amount ${this.minAmount}`)
   }
 
   /* Unstake funds that are staked into the validator. Once unstaked they need to be claimed (once ready to withdraw) */
@@ -170,9 +170,9 @@ export class EthereumStaking {
           this.buildTxData(this.contractPool, 'unstake', amountWei, allowedInterchangeNum, source)
         ),
       }
-    } else {
-      throw new Error(`Max Amount for unstake ${balance}`)
     }
+
+    throw new Error(`Max Amount for unstake ${balance}`)
   }
 
   /** Claim funds requested by unstake (in withdraw state) */
@@ -185,9 +185,9 @@ export class EthereumStaking {
           amount: this.asset.currency.ZERO,
           data: bufferToHex(this.buildTxData(this.contractAccounting, 'claimWithdrawRequest')),
         }
-      } else {
-        return null // no amount to withdraw
       }
+
+      return null // no amount to withdraw
     } catch (error) {
       throw new Error(error)
     }

package/src/staking/ethereum/service.js

@@ -5,28 +5,27 @@ import BN from 'bn.js'
 import { stakingProviderClientFactory } from '../staking-provider-client'
 import { EthereumStaking } from './api'
 
-const extraGasLimit = 20000 // extra gas Limit to prevent tx failing if something change on pool state (till tx is in mempool)
+const extraGasLimit = 20_000 // extra gas Limit to prevent tx failing if something change on pool state (till tx is in mempool)
 
 export function createEthereumStakingService({
   asset,
   assetClientInterface,
   createAndBroadcastTX,
-  telemetryId,
+  getTelemetryId,
 }) {
   const staking = new EthereumStaking(asset)
-  const stakingProvider = stakingProviderClientFactory({ telemetryId })
+  const stakingProvider = stakingProviderClientFactory({ getTelemetryId })
 
   function amountToCurrency({ asset, amount }) {
     return isNumberUnit(amount) ? amount : asset.currency.parse(amount)
   }
 
   async function delegate({ walletAccount, amount } = {}) {
-    const delegatorAddress = (
-      await assetClientInterface.getReceiveAddress({
-        assetName: asset.name,
-        walletAccount,
-      })
-    ).toLowerCase()
+    const address = await assetClientInterface.getReceiveAddress({
+      assetName: asset.name,
+      walletAccount,
+    })
+    const delegatorAddress = address.toLowerCase()
     amount = amountToCurrency({ asset, amount })
 
     const { to, data } = await staking.stake({
@@ -71,12 +70,11 @@ export function createEthereumStakingService({
     */
     amount = amountToCurrency({ asset, amount })
 
-    const delegatorAddress = (
-      await assetClientInterface.getReceiveAddress({
-        assetName: asset.name,
-        walletAccount,
-      })
-    ).toLowerCase()
+    const address = await assetClientInterface.getReceiveAddress({
+      assetName: asset.name,
+      walletAccount,
+    })
+    const delegatorAddress = address.toLowerCase()
 
     const pendingAmount = await staking.pendingBalanceOf(delegatorAddress)
 
@@ -102,7 +100,7 @@ export function createEthereumStakingService({
         amount: inactiveAmountToUnstake,
       })
 
-      let { gasPrice, gasLimit, fee } = await estimateTxFee(
+      const { gasPrice, gasLimit, fee } = await estimateTxFee(
         delegatorAddress.toLowerCase(),
         to,
         null,
@@ -111,7 +109,7 @@ export function createEthereumStakingService({
       txId = await prepareAndSendTx({
         asset,
         walletAccount,
-        to: to,
+        to,
         txData: data,
         gasPrice,
         gasLimit,
@@ -127,7 +125,7 @@ export function createEthereumStakingService({
         amount: activeAmountToUnstake,
       })
 
-      let { gasPrice, gasLimit, fee } = await estimateTxFee(delegatorAddress, to, null, data)
+      const { gasPrice, gasLimit, fee } = await estimateTxFee(delegatorAddress, to, null, data)
       txId = await prepareAndSendTx({
         asset,
         walletAccount,
@@ -153,39 +151,38 @@ export function createEthereumStakingService({
 
   async function claimUndelegatedBalance({ walletAccount } = {}) {
     // withdraw withdrawable balance (of a previous unstake)
-    const delegatorAddress = (
-      await assetClientInterface.getReceiveAddress({
-        assetName: asset.name,
-        walletAccount,
-      })
-    ).toLowerCase()
+    const address = await assetClientInterface.getReceiveAddress({
+      assetName: asset.name,
+      walletAccount,
+    })
+    const delegatorAddress = address.toLowerCase()
 
     const withdrawRequest = await staking.claimWithdrawRequest({
       address: delegatorAddress,
     })
     if (withdrawRequest) {
       const { to, data } = withdrawRequest
-      let { gasPrice, gasLimit, fee } = await estimateTxFee(delegatorAddress, to, null, data)
-      const txId = await prepareAndSendTx({
+      const { gasPrice, gasLimit, fee } = await estimateTxFee(delegatorAddress, to, null, data)
+      return prepareAndSendTx({
         asset,
         walletAccount,
-        to: to,
+        to,
         txData: data,
         gasPrice,
         gasLimit,
         fee,
       })
-      return txId
-    } else return null // -> no withdrawable balance
+    }
+
+    return null // -> no withdrawable balance
   }
 
   async function estimateDelegateOperation({ walletAccount, operation, args }) {
-    const delegatorAddress = (
-      await assetClientInterface.getReceiveAddress({
-        assetName: asset.name,
-        walletAccount,
-      })
-    ).toLowerCase()
+    const address = await assetClientInterface.getReceiveAddress({
+      assetName: asset.name,
+      walletAccount,
+    })
+    const delegatorAddress = address.toLowerCase()
 
     const NAMING_MAP = {
       delegate: 'stake',
@@ -198,6 +195,7 @@ export function createEthereumStakingService({
       return
     }
 
+    // eslint-disable-next-line @exodus/mutable/no-param-reassign-prop-only
     if (args.amount) args.amount = amountToCurrency({ asset, amount: args.amount })
 
     let amount, data, fee

package/src/staking/ethereum/staking-utils.js

@@ -2,18 +2,16 @@ import { EthereumStaking } from './api'
 
 const { DELEGATE, UNSTAKE, UNSTAKE_PENDING, CLAIM_UNSTAKE } = EthereumStaking.METHODS_IDS
 
-const STAKING_MANAGER_CONTRACTS = [
+const STAKING_MANAGER_CONTRACTS = new Set([
   EthereumStaking.addresses.ethereum.EVERSTAKE_ADDRESS_CONTRACT_POOL.toLowerCase(),
   EthereumStaking.addresses.ethereumgoerli.EVERSTAKE_ADDRESS_CONTRACT_POOL.toLowerCase(),
   EthereumStaking.addresses.ethereumholesky.EVERSTAKE_ADDRESS_CONTRACT_POOL.toLowerCase(),
-]
+])
 
 export const isEthereumStakingTx = ({ coinName }) =>
   ['ethereum', 'ethereumgoerli', 'ethereumholesky'].includes(coinName)
 export const isEthereumDelegate = (tx) =>
-  isEthereumStakingTx(tx) &&
-  STAKING_MANAGER_CONTRACTS.includes(tx.to) &&
-  tx.data?.methodId === DELEGATE
+  isEthereumStakingTx(tx) && STAKING_MANAGER_CONTRACTS.has(tx.to) && tx.data?.methodId === DELEGATE
 export const isEthereumUndelegatePending = (tx) =>
   isEthereumStakingTx(tx) && tx.data?.methodId === UNSTAKE_PENDING
 export const isEthereumUndelegate = (tx) =>

package/src/staking/fantom-staking.js

@@ -105,10 +105,10 @@ export class FantomStaking {
 
   #validateDuration = (duration) => {
     if (!Number.isInteger(duration)) {
-      throw new Error('The lock duration must be an integer.')
+      throw new TypeError('The lock duration must be an integer.')
     }
 
-    if (duration > 365 * 86400) {
+    if (duration > 365 * 86_400) {
       throw new Error('The lock duration must be at most 365 days.')
     }
   }

package/src/staking/matic/api.js

@@ -25,8 +25,7 @@ export class MaticStakingApi {
   }
 
   buildTxData = (contract, method, ...args) => {
-    const txData = contract[method].build(...args)
-    return txData
+    return contract[method].build(...args)
   }
 
   callReadFunctionContract = (contract, method, ...args) => {
@@ -183,7 +182,7 @@ export class MaticStakingApi {
 
 // see arguments encoding standard (padded 32 bytes)
 // https://docs.soliditylang.org/en/v0.8.15/abi-spec.html?highlight=abi.encode#function-selector-and-argument-encoding
-const splitIn32BytesArray = (output) => removeHexPrefix(output).match(/[0-9a-f]{1,64}/gi) || []
+const splitIn32BytesArray = (output) => removeHexPrefix(output).match(/[\da-f]{1,64}/gi) || []
 
 const toBN = (str) => new BN(removeLeadingZeroes(removeHexPrefix(str)), 16)
 

package/src/staking/matic/service.js

@@ -8,11 +8,11 @@ import { isNumberUnit } from '@exodus/currency'
 export function createPolygonStakingService({
   assetClientInterface,
   createAndBroadcastTX,
-  telemetryId,
+  getTelemetryId,
 }) {
   const stakingApi = new MaticStakingApi()
   const assetName = 'ethereum'
-  const stakingProvider = stakingProviderClientFactory({ telemetryId })
+  const stakingProvider = stakingProviderClientFactory({ getTelemetryId })
 
   async function getStakeAssets() {
     const { polygon: asset, ethereum: feeAsset } = await assetClientInterface.getAssetsForNetwork({
@@ -26,12 +26,11 @@ export function createPolygonStakingService({
   }
 
   async function delegate({ walletAccount, amount } = {}) {
-    const delegatorAddress = (
-      await assetClientInterface.getReceiveAddress({
-        assetName,
-        walletAccount,
-      })
-    ).toLowerCase()
+    const address = await assetClientInterface.getReceiveAddress({
+      assetName,
+      walletAccount,
+    })
+    const delegatorAddress = address.toLowerCase()
 
     const { asset } = await getStakeAssets()
     amount = amountToCurrency({ asset, amount })
@@ -79,23 +78,22 @@ export function createPolygonStakingService({
   }
 
   async function undelegate({ walletAccount, amount } = {}) {
-    const delegatorAddress = (
-      await assetClientInterface.getReceiveAddress({
-        assetName,
-        walletAccount,
-      })
-    ).toLowerCase()
+    const address = await assetClientInterface.getReceiveAddress({
+      assetName,
+      walletAccount,
+    })
+    const delegatorAddress = address.toLowerCase()
 
     const { asset } = await getStakeAssets()
     amount = amountToCurrency({ asset, amount })
 
     const txUndelegateData = await stakingApi.undelegate({ amount })
-    let { gasPrice, gasLimit, fee } = await estimateTxFee(
+    const { gasPrice, gasLimit, fee } = await estimateTxFee(
       delegatorAddress.toLowerCase(),
       stakingApi.validatorShareContract.address,
       txUndelegateData
     )
-    const txId = await prepareAndSendTx({
+    return prepareAndSendTx({
       walletAccount,
       to: stakingApi.validatorShareContract.address,
       txData: txUndelegateData,
@@ -103,25 +101,22 @@ export function createPolygonStakingService({
       gasLimit,
       fee,
     })
-
-    return txId
   }
 
   async function claimRewards({ walletAccount } = {}) {
-    const delegatorAddress = (
-      await assetClientInterface.getReceiveAddress({
-        assetName,
-        walletAccount,
-      })
-    ).toLowerCase()
+    const address = await assetClientInterface.getReceiveAddress({
+      assetName,
+      walletAccount,
+    })
+    const delegatorAddress = address.toLowerCase()
 
     const txWithdrawRewardsData = await stakingApi.withdrawRewards()
-    let { gasPrice, gasLimit, fee } = await estimateTxFee(
+    const { gasPrice, gasLimit, fee } = await estimateTxFee(
       delegatorAddress,
       stakingApi.validatorShareContract.address,
       txWithdrawRewardsData
     )
-    const txId = await prepareAndSendTx({
+    return prepareAndSendTx({
       walletAccount,
       to: stakingApi.validatorShareContract.address,
       txData: txWithdrawRewardsData,
@@ -129,17 +124,14 @@ export function createPolygonStakingService({
       gasLimit,
       fee,
     })
-
-    return txId
   }
 
   async function claimUndelegatedBalance({ walletAccount, unbondNonce } = {}) {
-    const delegatorAddress = (
-      await assetClientInterface.getReceiveAddress({
-        assetName,
-        walletAccount,
-      })
-    ).toLowerCase()
+    const address = await assetClientInterface.getReceiveAddress({
+      assetName,
+      walletAccount,
+    })
+    const delegatorAddress = address.toLowerCase()
 
     const { asset } = await getStakeAssets()
     const { currency } = asset
@@ -156,7 +148,7 @@ export function createPolygonStakingService({
     })
 
     const txClaimUndelegatedData = await stakingApi.claimUndelegatedBalance({ unbondNonce })
-    let { gasPrice, gasLimit, fee } = await estimateTxFee(
+    const { gasPrice, gasLimit, fee } = await estimateTxFee(
       delegatorAddress,
       stakingApi.validatorShareContract.address,
       txClaimUndelegatedData
@@ -186,12 +178,12 @@ export function createPolygonStakingService({
     if (!delegateOperation) {
       return
     }
-    const delegatorAddress = (
-      await assetClientInterface.getReceiveAddress({
-        assetName,
-        walletAccount,
-      })
-    ).toLowerCase()
+
+    const address = await assetClientInterface.getReceiveAddress({
+      assetName,
+      walletAccount,
+    })
+    const delegatorAddress = address.toLowerCase()
 
     const { amount } = args
     if (amount) {
@@ -225,7 +217,7 @@ export function createPolygonStakingService({
       baseAssetName: 'ethereum',
     })
     const erc20ApproveGas = 4900
-    const delegateGas = 240000
+    const delegateGas = 240_000
     const gasPrice = parseInt(await getServer(ethereum).gasPrice(), 16)
     const extraPercentage = 20
 

package/src/staking/staking-provider-client.js

@@ -7,7 +7,7 @@ const HTTP_POST_TIMEOUT = ms('30s')
 
 export const stakingProviderClientFactory = ({
   defaultStakingUrl = DEFAULT_STAKING_URL,
-  telemetryId,
+  getTelemetryId,
 } = {}) => {
   assert(defaultStakingUrl, '"defaultStakingUrl" must be provided')
 
@@ -22,9 +22,9 @@ export const stakingProviderClientFactory = ({
     stakingUrl = new URL(newStakingUrl || defaultStakingUrl)
   }
 
-  const stakingRequest = ({ asset, data }) => {
+  const stakingRequest = async ({ asset, data }) => {
     const headers = {}
-    if (telemetryId) headers.telemetryId = telemetryId
+    if (typeof getTelemetryId === 'function') headers.telemetryId = await getTelemetryId()
     return fetchival(stakingUrl, {
       timeout: HTTP_POST_TIMEOUT,
       headers,

package/src/tx-log/clarity-monitor.js

@@ -29,6 +29,7 @@ export class ClarityMonitor extends BaseMonitor {
     if (!config?.server || config.server === this.server.uri) {
       return
     }
+
     this.server.setURI(config.server)
     this.subscribeWalletAddresses()
     if (this.config.GAS_PRICE_FROM_WEBSOCKET) {
@@ -57,10 +58,8 @@ export class ClarityMonitor extends BaseMonitor {
 
   // eslint-disable-next-line no-undef
   async checkPendingTransactions(params) {
-    const {
-      pendingTransactionsToCheck,
-      pendingTransactionsGroupedByAddressAndNonce,
-    } = checkPendingTransactions(params)
+    const { pendingTransactionsToCheck, pendingTransactionsGroupedByAddressAndNonce } =
+      checkPendingTransactions(params)
     const txsToRemove = []
     const { walletAccount } = params
 
@@ -190,6 +189,7 @@ export class ClarityMonitor extends BaseMonitor {
       const balance = balances[asset.name]
       newAccountState.balance = asset.currency.baseUnit(balance)
     }
+
     const tokenBalancePairs = Object.entries(balances).filter((entry) => entry[0] !== asset.name)
     const tokenBalanceEntries = tokenBalancePairs
       .map((pair) => {
@@ -197,7 +197,7 @@ export class ClarityMonitor extends BaseMonitor {
         const value = token.currency.baseUnit(pair[1] || 0)
         return [token.name, value]
       })
-      .filter((pair) => pair)
+      .filter(Boolean)
 
     const tokenBalances = excludeUnchangedTokenBalances(currentTokenBalances, tokenBalanceEntries)
     if (!isEmpty(tokenBalances)) newAccountState.tokenBalances = tokenBalances
@@ -214,13 +214,14 @@ export class ClarityMonitor extends BaseMonitor {
         useCache: true,
       })
     }
+
     return addressesByAccount
   }
 
   async subscribeWalletAddresses() {
     const addressesByWalletAccount = await this.getReceiveAddressesByWalletAccount()
     Object.entries(addressesByWalletAccount).forEach(([walletAccount, addresses]) => {
-      const address = String(Array.from(addresses)[0]).toLowerCase() // Only check m/0/0
+      const address = String([...addresses][0]).toLowerCase() // Only check m/0/0
       this.server.connectTransactions({ walletAccount, address })
     })
   }
@@ -231,16 +232,19 @@ export class ClarityMonitor extends BaseMonitor {
       const request = this.server.getBalanceRequest(ourWalletAddress)
       batch[this.asset.name] = request
     }
+
     for (const token of tokens) {
       if (isRpcBalanceAsset(token) && token.contract.address) {
         const request = this.server.balanceOfRequest(ourWalletAddress, token.contract.address)
         batch[token.name] = request
       }
     }
+
     const pairs = Object.entries(batch)
-    if (!pairs.length) {
+    if (pairs.length === 0) {
       return {}
     }
+
     const requests = pairs.map((pair) => pair[1])
     const responses = await this.server.sendBatchRequest(requests)
     const entries = pairs.map((pair, idx) => {
@@ -261,10 +265,10 @@ export class ClarityMonitor extends BaseMonitor {
         if (!tokensByAddress.has(addr)) {
           acc.add(addr)
         }
-      }, acc)
+      })
       return acc
     }, new Set())
-    return Array.from(set)
+    return [...set]
   }
 
   async updateGasPrice({ gasPrice, baseFeePerGas }) {
@@ -300,6 +304,7 @@ export class ClarityMonitor extends BaseMonitor {
     if (this.config.GAS_PRICE_FROM_WEBSOCKET) {
       this.server.connectFee()
     }
+
     return this.subscribeWalletAddresses()
   }
 

package/src/tx-log/clarity-utils/get-derive-data-needed-for-tick.js

@@ -1,7 +1,7 @@
 // A super-selector that returns all the current data needed for a tick of the ETH monitor.
 
 export default function getDeriveDataNeededForTick(aci) {
-  return async function({ assetName, walletAccount }) {
+  return async function ({ assetName, walletAccount }) {
     const receiveAddress = await aci.getReceiveAddress({ assetName, walletAccount, useCache: true })
     const currentAccountState = await aci.getAccountState({ assetName, walletAccount })
     return {

package/src/tx-log/clarity-utils/get-log-items-from-server-tx.js

@@ -31,7 +31,9 @@ export default function getLogItemsFromServerTx({
   const toAddress = tryFindExternalRecipient(ethereumTransfers, ourWalletAddress)
   const ourWalletWasSender = serverTx.from === ourWalletAddress
   const METHOD_ID_LENGTH = 10
-  const methodId = serverTx.input && { methodId: serverTx.input.substring(0, METHOD_ID_LENGTH) }
+  const methodId = serverTx.input && {
+    methodId: serverTx.input.slice(0, Math.max(0, METHOD_ID_LENGTH)),
+  }
 
   const logItemCommonProperties = {
     confirmations,
@@ -87,6 +89,7 @@ export default function getLogItemsFromServerTx({
       ])
     }
   }
+
   // handle erc20
   Object.entries(tokenTransfersByTokenName).forEach(([tokenName, tokenTransfers]) => {
     const sendingTransferPresent = tokenTransfers.some(({ from }) => from === ourWalletAddress)