@evenicanpm/storefront-core 1.2.2 → 1.4.0

package/src/api-manager/datasources/e4/categories/e4-categories.translator.ts

@@ -1,7 +1,7 @@
 // Interfaces
-import { Category as E4Category } from "@evenicanpm/storefront-core/src/api-manager/datasources/e4/graphqlRequestSdk";
-import { Category } from "@msdyn365-commerce/retail-proxy";
-import { CategoryHierarchy } from "@evenicanpm/storefront-core/src/lib/category-helpers";
+import type { Category as E4Category } from "@evenicanpm/storefront-core/src/api-manager/datasources/e4/graphqlRequestSdk";
+import type { CategoryHierarchy } from "@evenicanpm/storefront-core/src/lib/category-helpers";
+import type { Category } from "@msdyn365-commerce/retail-proxy";
 
 interface TransformedCategoryNode extends Category {
 	Slug: string;
@@ -11,45 +11,45 @@ interface TransformedCategoryNode extends Category {
 	ParentCategory?: number;
 }
 
+function generateSlug(name: string): string {
+	if (!name) return "";
+	return name
+		.toLowerCase()
+		.replaceAll(/\s+/g, "-")
+		.replaceAll(/[^\w-]+/g, "")
+		.replaceAll(/--+/g, "-")
+		.replace(/^-+/, "")
+		.replace(/-+$/, "");
+}
+
 export const categoryTransformValidate = (
 	rawCategories: E4Category[],
 	rootParentId = 1,
 	urlPrefix = "e4",
 ): CategoryHierarchy[] => {
-	function generateSlug(name: string): string {
-		if (!name) return "";
-		return name
-			.toLowerCase()
-			.replace(/\s+/g, "-")
-			.replace(/[^\w-]+/g, "")
-			.replace(/--+/g, "-")
-			.replace(/^-+/, "")
-			.replace(/-+$/, "");
-	}
-
 	function createTransformedNode(
 		rawCategory: E4Category,
 	): TransformedCategoryNode | null {
 		let recordIdNum: number;
 		try {
-			recordIdNum = parseInt(String(rawCategory.id), 10);
-			if (isNaN(recordIdNum)) throw new Error("Invalid RecordId");
+			recordIdNum = Number.parseInt(String(rawCategory.id), 10);
+			if (Number.isNaN(recordIdNum)) throw new Error("Invalid RecordId");
 		} catch (e) {
-			console.warn(`Skipping category due to invalid id:`, rawCategory);
+			console.warn(`Skipping category due to invalid id:`, rawCategory, e);
 			return null;
 		}
 
 		const categoryName = rawCategory.name || "Unnamed Category";
 		const slug = generateSlug(categoryName);
-		let parentIdNum: number | undefined = undefined;
+		let parentIdNum: number | undefined;
 		if (rawCategory.parentId != null) {
-			const parsedParentId = parseInt(String(rawCategory.parentId), 10);
-			if (!isNaN(parsedParentId)) parentIdNum = parsedParentId;
-			else
+			const parsedParentId = Number.parseInt(String(rawCategory.parentId), 10);
+			if (Number.isNaN(parsedParentId))
 				console.warn(
 					`Invalid parentId format for id ${recordIdNum}:`,
 					rawCategory.parentId,
 				);
+			else parentIdNum = parsedParentId;
 		}
 
 		const node: TransformedCategoryNode = {
@@ -94,9 +94,9 @@ export const categoryTransformValidate = (
 		categoryNode.Url = `${currentPath}/${categoryNode.RecordId}`;
 		// Check if Children exists before iterating
 		if (categoryNode?.Children && categoryNode?.Children?.length > 0) {
-			categoryNode.Children.forEach((child: TransformedCategoryNode) =>
-				calculateUrls(child, currentPath, prefix),
-			);
+			categoryNode.Children.forEach((child: TransformedCategoryNode) => {
+				calculateUrls(child, currentPath, prefix);
+			});
 		}
 	}
 

package/src/api-manager/datasources/e4/e4.datasource.ts

@@ -1,13 +1,13 @@
-import { PrimaryDatasource } from "@evenicanpm/storefront-core/src/api-manager/types/Datasource";
-// Data source files
-import user from "@evenicanpm/storefront-core/src/api-manager/datasources/e4/user/e4-user.datasource";
-import session from "@evenicanpm/storefront-core/src/api-manager/datasources/e4/session/e4-session.datasource";
+import address from "@evenicanpm/storefront-core/src/api-manager/datasources/e4/address/e4-address.datasource";
 import cart from "@evenicanpm/storefront-core/src/api-manager/datasources/e4/cart/e4-cart.datasource";
+import categories from "@evenicanpm/storefront-core/src/api-manager/datasources/e4/categories/e4-categories.datasource";
 import order from "@evenicanpm/storefront-core/src/api-manager/datasources/e4/order/e4-order.datasource";
-import address from "@evenicanpm/storefront-core/src/api-manager/datasources/e4/address/e4-address.datasource";
-import product from "@evenicanpm/storefront-core/src/api-manager/datasources/e4/product/e4-product.datasource";
 import organization from "@evenicanpm/storefront-core/src/api-manager/datasources/e4/organization/e4-organization.datasource";
-import categories from "@evenicanpm/storefront-core/src/api-manager/datasources/e4/categories/e4-categories.datasource";
+import product from "@evenicanpm/storefront-core/src/api-manager/datasources/e4/product/e4-product.datasource";
+import session from "@evenicanpm/storefront-core/src/api-manager/datasources/e4/session/e4-session.datasource";
+// Data source files
+import user from "@evenicanpm/storefront-core/src/api-manager/datasources/e4/user/e4-user.datasource";
+import type { PrimaryDatasource } from "@evenicanpm/storefront-core/src/api-manager/types/Datasource";
 
 const E4Datasource: PrimaryDatasource = {
 	name: "e4",