@evenicanpm/storefront-core 1.2.2 → 1.4.0

package/src/api-manager/datasources/d365/d365-user.datasource.ts

@@ -1,30 +1,21 @@
 /* eslint-disable @typescript-eslint/no-explicit-any */
-import { UserApi } from "@evenicanpm/storefront-core/src/api-manager/types/Datasource";
-import {
-	CopyCartToWishlistInput,
-	ExtendedWishlist,
-	User,
-	UserCounts,
-	Wishlist,
-	WishlistCreateInput,
-	WishlistDetailInput,
-	WishlistLinesInput,
-} from "@/schemas/user.schema";
+
+import { D365DatasourceBase } from "@evenicanpm/storefront-core/src/api-manager/datasources/d365/d365-base.datasource";
+import { D365ProductDatasource } from "@evenicanpm/storefront-core/src/api-manager/datasources/d365/d365-product.datasource";
+import type { UserApi } from "@evenicanpm/storefront-core/src/api-manager/types/Datasource";
 import {
-	Customer,
-	CommerceProperty,
+	type CommerceProperty,
+	type Customer,
+	type ProductList,
+	type ProductListSearchCriteria,
 	ProductListType,
-	ProductListSearchCriteria,
-	SimpleProduct,
-	ProductList,
+	type SimpleProduct,
 } from "@msdyn365-commerce/retail-proxy";
 import {
 	createCustomerAsync,
 	readAsync,
 	updateAsync,
 } from "@msdyn365-commerce/retail-proxy/dist/DataActions/CustomersDataActions.g";
-import jwt from "jsonwebtoken";
-import { D365DatasourceBase } from "@evenicanpm/storefront-core/src/api-manager/datasources/d365/d365-base.datasource";
 import {
 	addProductListLinesAsync,
 	copyCartToProductListAsync,
@@ -33,10 +24,21 @@ import {
 	removeProductListLinesAsync,
 	searchAsync,
 	updateProductListLinesAsync,
+	readAsync as wishlistReadAsync,
 } from "@msdyn365-commerce/retail-proxy/dist/DataActions/ProductListsDataActions.g";
-import { D365ProductDatasource } from "@evenicanpm/storefront-core/src/api-manager/datasources/d365/d365-product.datasource";
+import jwt from "jsonwebtoken";
 import { uniq } from "lodash";
-import { readAsync as wishlistReadAsync } from "@msdyn365-commerce/retail-proxy/dist/DataActions/ProductListsDataActions.g";
+import type {
+	CopyCartToWishlistInput,
+	ExtendedWishlist,
+	User,
+	UserCounts,
+	Wishlist,
+	WishlistCreateInput,
+	WishlistDetailInput,
+	WishlistLinesInput,
+} from "@/schemas/user.schema";
+
 class D365UserDatasource extends D365DatasourceBase implements UserApi {
 	async updateUser(user: User): Promise<User> {
 		const context = this.context;
@@ -122,7 +124,7 @@ class D365UserDatasource extends D365DatasourceBase implements UserApi {
 			);
 			return wishlistProductData;
 		} catch (error) {
-			throw new Error("Error getting wishlists: " + error);
+			throw new Error(`Error getting wishlists: ${error}`);
 		}
 	}
 
@@ -134,7 +136,9 @@ class D365UserDatasource extends D365DatasourceBase implements UserApi {
 		try {
 			wishlist = await wishlistReadAsync(context as any, input.Id);
 		} catch (error) {
-			throw new Error("Error getting wishlist details" + JSON.stringify(error));
+			throw new Error(
+				`Error getting wishlist details: ${JSON.stringify(error)}`,
+			);
 		}
 
 		const extendedWishlist = { ...wishlist } as ExtendedWishlist;
@@ -152,7 +156,7 @@ class D365UserDatasource extends D365DatasourceBase implements UserApi {
 						id: uniq(productIds),
 					});
 				} catch (error) {
-					throw new Error("Error getting wishlist products: " + error);
+					throw new Error(`Error getting wishlist products: ${error}`);
 				}
 
 				if (products) {
@@ -179,11 +183,11 @@ class D365UserDatasource extends D365DatasourceBase implements UserApi {
 		try {
 			const wishlist = await createProductListAsync(
 				context as any,
-				productList as ProductList,
+				productList,
 			);
 			return wishlist;
 		} catch (error) {
-			throw new Error("Error creating wishlist: " + JSON.stringify(error));
+			throw new Error(`Error creating wishlist: ${JSON.stringify(error)}`);
 		}
 	}
 
@@ -195,22 +199,10 @@ class D365UserDatasource extends D365DatasourceBase implements UserApi {
 		try {
 			await deleteAsync(context as any, { Id: input.Id });
 		} catch (error) {
-			throw new Error("Error deleting wishlist: " + error);
+			throw new Error(`Error deleting wishlist: ${error}`);
 		}
 	}
 
-	// async updateWishlist(input: WishlistLinesInput): Promise<Wishlist> {
-	//   const context = await getContextFromCookie();
-
-	//   try {
-	//     const wishlist = await updateAsync(context as any, input);
-	//     return wishlist;
-	//   } catch (error) {
-	//     console.log('input', input);
-	//     throw new Error("Error updating wishlist: " + error);
-	//   }
-	// }
-
 	async updateWishlist(input: WishlistLinesInput): Promise<Wishlist> {
 		const context = this.context;
 		const id = input.Id;
@@ -225,7 +217,7 @@ class D365UserDatasource extends D365DatasourceBase implements UserApi {
 			const wishlist = { Id: id, productListLines: updatedProductListLines };
 			return wishlist;
 		} catch (error) {
-			throw new Error("Error updating wishlist: " + error);
+			throw new Error(`Error updating wishlist: ${error}`);
 		}
 	}
 
@@ -244,11 +236,10 @@ class D365UserDatasource extends D365DatasourceBase implements UserApi {
 			const wishlist = { Id: id, productListLines: updatedProductListLines };
 			return wishlist;
 		} catch (error) {
-			throw new Error("Error adding to wishlist: " + error);
+			throw new Error(`Error adding to wishlist: ${error}`);
 		}
 	}
 
-	// TODO: void return
 	async removeProductsFromWishlist(input: WishlistLinesInput): Promise<void> {
 		const context = this.context;
 		const id = input.Id;
@@ -256,7 +247,7 @@ class D365UserDatasource extends D365DatasourceBase implements UserApi {
 		try {
 			await removeProductListLinesAsync(context as any, id, productListLines);
 		} catch (error) {
-			throw new Error("Error removing from wishlist: " + error);
+			throw new Error(`Error removing from wishlist: ${error}`);
 		}
 	}
 
@@ -277,7 +268,7 @@ class D365UserDatasource extends D365DatasourceBase implements UserApi {
 			);
 			return wishlist;
 		} catch (error) {
-			throw new Error("Error copying cart to wishlist: " + error);
+			throw new Error(`Error copying cart to wishlist: ${error}`);
 		}
 	}
 }

package/src/api-manager/datasources/d365/d365.datasource.ts

@@ -1,23 +1,23 @@
-import {
-	AddressApi,
-	CategoryApi,
-	Datasource,
-	OrderApi,
-	OrganizationApi,
-	PrimaryDatasource,
-	ProductApi,
-	SessionApi,
-	UserApi,
-} from "@evenicanpm/storefront-core/src/api-manager/types/Datasource";
-import { D365ProductDatasource } from ".";
-import { D365CartDatasource } from "@evenicanpm/storefront-core/src/api-manager/datasources/d365/d365-cart.datasource";
 import D365AddressDatasource from "@evenicanpm/storefront-core/src/api-manager/datasources/d365/d365-address.datasource";
+import { D365CartDatasource } from "@evenicanpm/storefront-core/src/api-manager/datasources/d365/d365-cart.datasource";
 import D365CategoriesDatasource from "@evenicanpm/storefront-core/src/api-manager/datasources/d365/d365-categories.datasource";
-import D365OrganizationDatasource from "@evenicanpm/storefront-core/src/api-manager/datasources/d365/d365-organization.datasource";
 import D365OrderDatasource from "@evenicanpm/storefront-core/src/api-manager/datasources/d365/d365-order.datasource";
+import D365OrganizationDatasource from "@evenicanpm/storefront-core/src/api-manager/datasources/d365/d365-organization.datasource";
 import D365SessionDatasource from "@evenicanpm/storefront-core/src/api-manager/datasources/d365/d365-session.datasource";
 import D365UserDatasource from "@evenicanpm/storefront-core/src/api-manager/datasources/d365/d365-user.datasource";
-import { ICallerContext } from "@msdyn365-commerce/retail-proxy";
+import {
+	type AddressApi,
+	type CategoryApi,
+	Datasource,
+	type OrderApi,
+	type OrganizationApi,
+	type PrimaryDatasource,
+	type ProductApi,
+	type SessionApi,
+	type UserApi,
+} from "@evenicanpm/storefront-core/src/api-manager/types/Datasource";
+import type { ICallerContext } from "@msdyn365-commerce/retail-proxy";
+import { D365ProductDatasource } from ".";
 
 export class D365Datasource extends Datasource implements PrimaryDatasource {
 	user: UserApi;
@@ -41,5 +41,3 @@ export class D365Datasource extends Datasource implements PrimaryDatasource {
 	}
 	// Datasources
 }
-
-// export default d365Datasource;

package/src/api-manager/datasources/d365/index.ts

@@ -1,4 +1,2 @@
-import { D365ProductDatasource } from "@evenicanpm/storefront-core/src/api-manager/datasources/d365/d365-product.datasource";
-import { D365Datasource } from "@evenicanpm/storefront-core/src/api-manager/datasources/d365/d365.datasource";
-
-export { D365ProductDatasource, D365Datasource };
+export { D365Datasource } from "@evenicanpm/storefront-core/src/api-manager/datasources/d365/d365.datasource";
+export { D365ProductDatasource } from "@evenicanpm/storefront-core/src/api-manager/datasources/d365/d365-product.datasource";

package/src/api-manager/datasources/d365/test-context.ts

@@ -1,4 +1,4 @@
-import { IQueryResultSettings } from "@msdyn365-commerce/retail-proxy";
+import type { IQueryResultSettings } from "@msdyn365-commerce/retail-proxy";
 
 const defaultQueryResultSettings: IQueryResultSettings = {
 	Paging: {

package/src/api-manager/datasources/d365/utils/create-search-criteria.ts

@@ -1,4 +1,4 @@
-import { ProductDimensionAvailabilitySearchCriteria } from "@msdyn365-commerce/retail-proxy";
+import type { ProductDimensionAvailabilitySearchCriteria } from "@msdyn365-commerce/retail-proxy";
 /**
  * Helper: Create search criteria for product dimension availability.
  * @param dimensionTypeValue

package/src/api-manager/datasources/d365/utils/decode-jwt.ts

@@ -1,9 +1,8 @@
 "use server";
 import { decode } from "next-auth/jwt";
-import { getSecret } from "@evenicanpm/common-core/keyvault";
 
 export async function decodeToken(token: string) {
-	const secret = getSecret("NEXTAUTH_SECRET");
+	const secret = process.env.NEXTAUTH_SECRET; //this shouldn't be from key vault.
 	if (!secret) {
 		throw new Error("Environment variable NEXTAUTH_SECRET is not set.");
 	}

package/src/api-manager/datasources/d365/utils/get-context-cookie.ts

@@ -1,8 +1,8 @@
 "use server";
-import { manuallyRetrieveSessionCookie } from "@/auth/next-auth-cookie-manager";
-import { ICallerContext } from "@msdyn365-commerce/retail-proxy";
-import { getLocale } from "next-intl/server";
+import type { ICallerContext } from "@msdyn365-commerce/retail-proxy";
 import { cookies } from "next/headers";
+import { getLocale } from "next-intl/server";
+import { manuallyRetrieveSessionCookie } from "@/auth/next-auth-cookie-manager";
 
 /**
  * Retrieves the D365 context from the "D365Context" cookie, enriches it with the current session token,

package/src/api-manager/datasources/d365/utils/parse-object.ts

@@ -1,6 +1,6 @@
 const parseObject = async <TClass>(data: TClass): Promise<TClass> => {
 	try {
-		return JSON.parse(JSON.stringify(await data)) as TClass;
+		return globalThis.structuredClone(await data) as TClass;
 	} catch {
 		return {} as TClass;
 	}

package/src/api-manager/datasources/d365/utils/product-images-utils.ts

@@ -1,4 +1,4 @@
-import { SimpleProduct } from "@msdyn365-commerce/retail-proxy";
+import type { SimpleProduct } from "@msdyn365-commerce/retail-proxy";
 
 const testImageUrl = (url: string) => {
 	return new Promise<[string, boolean]>((resolve) => {
@@ -28,16 +28,35 @@ export const validateAndSetMediaUrls = async (
 	productData: SimpleProduct,
 	baseUrl: string,
 ) => {
-	const product = productData;
-	const primaryImageUrl = product?.PrimaryImageUrl;
+	const product = { ...productData };
+
+	let primaryImageUrl = product.PrimaryImageUrl;
+
 	if (!primaryImageUrl) {
-		return;
+		primaryImageUrl = `Products/${product.ItemId}_000_001.png`;
 	}
-	const urls = [];
-	for (let index = 1; index < 6; index++) {
-		const nextUrl = baseUrl + primaryImageUrl.replace("001", `00${index}`);
-		urls.push(nextUrl);
+
+	let fullPrimaryUrl = `${baseUrl}${primaryImageUrl}`;
+
+	// Validate the primary image
+	const isPrimaryValid = (await testMedia([fullPrimaryUrl])).length > 0;
+	if (!isPrimaryValid) {
+		fullPrimaryUrl = `${baseUrl}Products/${product.ItemId}_000_001.png`;
 	}
-	const validUrls = await testMedia(urls);
-	return validUrls;
+
+	product.PrimaryImageUrl = fullPrimaryUrl;
+
+	const candidateUrls: string[] = [];
+	for (let index = 2; index <= 5; index++) {
+		const candidateUrl = fullPrimaryUrl.replace(
+			/001(\.[a-z]+)$/i,
+			`${String(index).padStart(3, "0")}$1`,
+		);
+		candidateUrls.push(candidateUrl);
+	}
+
+	// Validate which URLs exist
+	const validUrls = await testMedia(candidateUrls);
+
+	return [product.PrimaryImageUrl, ...validUrls];
 };

package/src/api-manager/datasources/d365/utils/product-inventory-utils.ts

@@ -1,4 +1,4 @@
-import {
+import type {
 	InventoryAvailabilitySearchCriteria,
 	SearchArea,
 } from "@msdyn365-commerce/retail-proxy";

package/src/api-manager/datasources/e4/address/e4-address.datasource.ts

@@ -1,17 +1,17 @@
+import { addressMap } from "@evenicanpm/storefront-core/src/api-manager/datasources/e4/address/e4-address.remaps";
+import * as addressTranslator from "@evenicanpm/storefront-core/src/api-manager/datasources/e4/address/e4-address.translator";
+import type { Shipping } from "@evenicanpm/storefront-core/src/api-manager/datasources/e4/graphqlRequestSdk";
 import getGraphqlClient from "@evenicanpm/storefront-core/src/api-manager/lib/get-graphql-client";
-import {
+import type {
 	Address,
 	GetDeliveryOptionsInput,
 	GetStatesInput,
 } from "@evenicanpm/storefront-core/src/api-manager/schemas/address.schema";
-import {
+import type {
 	CountryRegionInfo,
 	DeliveryOption,
 	StateProvinceInfo,
 } from "@msdyn365-commerce/retail-proxy";
-import { Shipping } from "@evenicanpm/storefront-core/src/api-manager/datasources/e4/graphqlRequestSdk";
-import * as addressTranslator from "@evenicanpm/storefront-core/src/api-manager/datasources/e4/address/e4-address.translator";
-import { addressMap } from "@evenicanpm/storefront-core/src/api-manager/datasources/e4/address/e4-address.remaps";
 import { merge } from "object-mapper";
 
 const address = {

package/src/api-manager/datasources/e4/address/e4-address.remaps.ts

@@ -7,8 +7,8 @@
  * https://github.com/wankdanker/node-object-mapper
  *
  */
-import { Address as E4Address } from "@evenicanpm/storefront-core/src/api-manager/datasources/e4/graphqlRequestSdk";
-import { Address } from "@msdyn365-commerce/retail-proxy";
+import type { Address as E4Address } from "@evenicanpm/storefront-core/src/api-manager/datasources/e4/graphqlRequestSdk";
+import type { Address } from "@msdyn365-commerce/retail-proxy";
 
 export const addressMap = {
 	"[].id": [
@@ -16,7 +16,7 @@ export const addressMap = {
 		{
 			key: "[].RecordId",
 			transform: (id: string) => {
-				if (id !== null) return parseInt(id);
+				if (id !== null) return Number.parseInt(id);
 			},
 		},
 	],
@@ -25,7 +25,7 @@ export const addressMap = {
 	"[].addressType.id": {
 		key: "[].AddressTypeValue",
 		transform: (id: string) => {
-			if (id !== null) return parseInt(id);
+			if (id !== null) return Number.parseInt(id);
 		},
 	},
 	"[].address1": "[].Street",

package/src/api-manager/datasources/e4/address/e4-address.translator.ts

@@ -1,17 +1,17 @@
-import getGraphqlClient from "@evenicanpm/storefront-core/src/api-manager/lib/get-graphql-client";
-import {
-	AddressInput,
-	Country,
-	Shipping,
-} from "@evenicanpm/storefront-core/src/api-manager/datasources/e4/graphqlRequestSdk";
-import { Address } from "@evenicanpm/storefront-core/src/api-manager/schemas/address.schema";
-import { merge } from "object-mapper";
 import {
 	addressReverseMap,
 	countriesMap,
 	countryMap,
 	deliveryOptionsMap,
 } from "@evenicanpm/storefront-core/src/api-manager/datasources/e4/address/e4-address.remaps";
+import type {
+	AddressInput,
+	Country,
+	Shipping,
+} from "@evenicanpm/storefront-core/src/api-manager/datasources/e4/graphqlRequestSdk";
+import getGraphqlClient from "@evenicanpm/storefront-core/src/api-manager/lib/get-graphql-client";
+import type { Address } from "@evenicanpm/storefront-core/src/api-manager/schemas/address.schema";
+import { merge } from "object-mapper";
 
 /**
  * Transforms the Address schema to e4 API address
@@ -88,7 +88,7 @@ export const countriesTransformValidate = (countries: Country[]) => {
 };
 
 export const countryTransformValidate = (country: Country) => {
-	if (country?.state && country?.state.length) {
+	if (country?.state?.length) {
 		return merge(country, countryMap);
 	}
 	return [];

package/src/api-manager/datasources/e4/cart/e4-cart.datasource.ts

@@ -1,22 +1,20 @@
-import getGraphqlClient from "@evenicanpm/storefront-core/src/api-manager/lib/get-graphql-client";
-import * as cartSchema from "@evenicanpm/storefront-core/src/api-manager/schemas/cart.schema";
-import { Cart } from "@evenicanpm/storefront-core/src/api-manager/schemas/cart.schema";
-import * as cartTranslator from "@evenicanpm/storefront-core/src/api-manager/datasources/e4/cart/e4-cart.translator";
 import * as addressTranslator from "@evenicanpm/storefront-core/src/api-manager/datasources/e4/address/e4-address.translator";
-
-import {
+import * as cartTranslator from "@evenicanpm/storefront-core/src/api-manager/datasources/e4/cart/e4-cart.translator";
+import type { Cart as E4Cart } from "@evenicanpm/storefront-core/src/api-manager/datasources/e4/graphqlRequestSdk";
+import getGraphqlClient from "@evenicanpm/storefront-core/src/api-manager/lib/get-graphql-client";
+import type * as cartSchema from "@evenicanpm/storefront-core/src/api-manager/schemas/cart.schema";
+import type { SalesOrder } from "@evenicanpm/storefront-core/src/api-manager/schemas/order.schema";
+import type { CartApi } from "@evenicanpm/storefront-core/src/api-manager/types/Datasource";
+import type {
 	CardPaymentAcceptPoint,
 	CardPaymentAcceptResult,
 	LineDeliverySpecification,
 	ProductWarehouseInventoryInformation,
 } from "@msdyn365-commerce/retail-proxy";
-import { CartApi } from "@evenicanpm/storefront-core/src/api-manager/types/Datasource";
-import { Cart as E4Cart } from "@evenicanpm/storefront-core/src/api-manager/datasources/e4/graphqlRequestSdk";
-import { SalesOrder } from "@evenicanpm/storefront-core/src/api-manager/schemas/order.schema";
 
 const cart: CartApi = {
 	//For this data source, initCart does the same thing as getCart
-	async initCart(): Promise<Cart> {
+	async initCart(): Promise<cartSchema.Cart> {
 		const e4Api = await getGraphqlClient();
 
 		const { data, errors } = await e4Api.e4CartReadMD();
@@ -31,7 +29,7 @@ const cart: CartApi = {
 		return transformedData;
 	},
 
-	async addToCart(input: cartSchema.AddToCartInput): Promise<Cart> {
+	async addToCart(input: cartSchema.AddToCartInput): Promise<cartSchema.Cart> {
 		const e4Api = await getGraphqlClient();
 
 		const { cartLine } = input;
@@ -54,7 +52,9 @@ const cart: CartApi = {
 		return transformedData;
 	},
 
-	async updateCart(input: cartSchema.UpdateCartInput): Promise<Cart> {
+	async updateCart(
+		input: cartSchema.UpdateCartInput,
+	): Promise<cartSchema.Cart> {
 		const e4Api = await getGraphqlClient();
 
 		const { cart } = input;
@@ -96,7 +96,9 @@ const cart: CartApi = {
 		return transformedData;
 	},
 
-	async updateCartLines(input: cartSchema.UpdateCartLineInput): Promise<Cart> {
+	async updateCartLines(
+		input: cartSchema.UpdateCartLineInput,
+	): Promise<cartSchema.Cart> {
 		const e4Api = await getGraphqlClient();
 
 		const { cartLine } = input;
@@ -125,7 +127,9 @@ const cart: CartApi = {
 		return transformedData;
 	},
 
-	async deleteCartLine(input: cartSchema.DeleteCartLineInput): Promise<Cart> {
+	async deleteCartLine(
+		input: cartSchema.DeleteCartLineInput,
+	): Promise<cartSchema.Cart> {
 		const e4Api = await getGraphqlClient();
 
 		const { cartLine } = input;
@@ -149,7 +153,7 @@ const cart: CartApi = {
 		return transformedData;
 	},
 
-	async getCart(): Promise<Cart> {
+	async getCart(): Promise<cartSchema.Cart> {
 		const e4Api = await getGraphqlClient();
 
 		const { data, errors } = await e4Api.e4CartReadMD();
@@ -164,21 +168,17 @@ const cart: CartApi = {
 		return transformedData;
 	},
 
-	async addDiscountCode(): Promise<Cart> {
-		if (true) {
-			throw new Error("Error adding discount code");
-		}
+	async addDiscountCode(): Promise<cartSchema.Cart> {
+		throw new Error("Error adding discount code");
 	},
 
-	async removeDiscountcode(): Promise<Cart> {
-		if (true) {
-			throw new Error("Error removing discount code");
-		}
+	async removeDiscountcode(): Promise<cartSchema.Cart> {
+		throw new Error("Error removing discount code");
 	},
 
 	async updateLineDeliveryMode(
 		input: cartSchema.UpdateCartLineDeliveryModeInput,
-	): Promise<Cart> {
+	): Promise<cartSchema.Cart> {
 		const e4Api = await getGraphqlClient();
 
 		const { data, errors } = await e4Api.e4ShippingMethodUpdateMD({
@@ -198,22 +198,16 @@ const cart: CartApi = {
 		);
 	},
 
-	async removeLineDeliveryMode(): Promise<Cart> {
-		if (true) {
-			throw new Error("Error updating cart line delivery mode");
-		}
+	async removeLineDeliveryMode(): Promise<cartSchema.Cart> {
+		throw new Error("Error updating cart line delivery mode");
 	},
 
 	async getCardAcceptPoint(): Promise<CardPaymentAcceptPoint> {
-		if (true) {
-			throw new Error("Error getCardAcceptPoint");
-		}
+		throw new Error("Error getCardAcceptPoint");
 	},
 
 	async retrieveCardPaymentAcceptResult(): Promise<CardPaymentAcceptResult> {
-		if (true) {
-			throw new Error("Error retrieveCardPaymentAcceptResult");
-		}
+		throw new Error("Error retrieveCardPaymentAcceptResult");
 	},
 
 	async checkout(): Promise<SalesOrder> {
@@ -224,9 +218,14 @@ const cart: CartApi = {
 			const chars =
 				"abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789";
 			let token = "";
+
+			const randomValues = new Uint32Array(length);
+			crypto.getRandomValues(randomValues);
+
 			for (let i = 0; i < length; i++) {
-				token += chars[Math.floor(Math.random() * chars.length)];
+				token += chars[randomValues[i] % chars.length];
 			}
+
 			return token;
 		};
 
@@ -245,9 +244,10 @@ const cart: CartApi = {
 			SalesLines: [],
 		};
 	},
-	getCartLinesInventory: function (
+
+	getCartLinesInventory: (
 		_input: cartSchema.InventorySearchCartLinesCriteriaInput,
-	): Promise<ProductWarehouseInventoryInformation> {
+	): Promise<ProductWarehouseInventoryInformation> => {
 		throw new Error("Function not implemented.");
 	},
 };

package/src/api-manager/datasources/e4/cart/e4-cart.remaps.ts

@@ -7,18 +7,19 @@
  * https://github.com/wankdanker/node-object-mapper
  *
  */
-import {
-	Address,
-	Product as DynProduct,
-} from "@msdyn365-commerce/retail-proxy";
-import {
-	Product,
+
+import { addressMap } from "@evenicanpm/storefront-core/src/api-manager/datasources/e4/address/e4-address.remaps";
+import type {
 	CartLine,
 	Address as E4Address,
+	Product,
 } from "@evenicanpm/storefront-core/src/api-manager/datasources/e4/graphqlRequestSdk";
-import { merge } from "object-mapper";
 import { productMap } from "@evenicanpm/storefront-core/src/api-manager/datasources/e4/product/e4-product.remaps";
-import { addressMap } from "@evenicanpm/storefront-core/src/api-manager/datasources/e4/address/e4-address.remaps";
+import type {
+	Address,
+	Product as DynProduct,
+} from "@msdyn365-commerce/retail-proxy";
+import { merge } from "object-mapper";
 
 /* CART REMAPS */
 export const cartLineMap = {
@@ -41,7 +42,7 @@ export const cartLineMap = {
 	"[].product.id": {
 		key: "[].ProductId",
 		transform: (id: string) => {
-			if (id !== null) return parseInt(id);
+			if (id !== null) return Number.parseInt(id);
 		},
 	},
 	"[].product.code": "[].ItemId",

package/src/api-manager/datasources/e4/cart/e4-cart.translator.ts

@@ -1,9 +1,9 @@
+import { cartMap } from "@evenicanpm/storefront-core/src/api-manager/datasources/e4/cart/e4-cart.remaps";
+import type { Cart as E4Cart } from "@evenicanpm/storefront-core/src/api-manager/datasources/e4/graphqlRequestSdk";
 import {
+	type Cart,
 	extendedCartSchema,
-	Cart,
 } from "@evenicanpm/storefront-core/src/api-manager/schemas/cart.schema";
-import { Cart as E4Cart } from "@evenicanpm/storefront-core/src/api-manager/datasources/e4/graphqlRequestSdk";
-import { cartMap } from "@evenicanpm/storefront-core/src/api-manager/datasources/e4/cart/e4-cart.remaps";
 import { merge } from "object-mapper";
 
 /**
@@ -14,7 +14,7 @@ import { merge } from "object-mapper";
  * @returns the transformed cart object
  */
 export const cartTransformValidate = (cart: E4Cart): Cart => {
-	if (!(cart && cart?.id)) throw new Error("Not a valid cart");
+	if (!cart?.id) throw new Error("Not a valid cart");
 	const transformedData = merge(cart, cartMap);
 	try {
 		extendedCartSchema.parse(transformedData);

package/src/api-manager/datasources/e4/categories/e4-categories.datasource.ts

@@ -1,8 +1,8 @@
-import getGraphqlClient from "@evenicanpm/storefront-core/src/api-manager/lib/get-graphql-client";
-import { CategoryHierarchy } from "@evenicanpm/storefront-core/src/lib/category-helpers";
-import { CategoryApi } from "@evenicanpm/storefront-core/src/api-manager/types/Datasource";
-import { Category as E4Category } from "@evenicanpm/storefront-core/src/api-manager/datasources/e4/graphqlRequestSdk";
 import * as categoryTranslator from "@evenicanpm/storefront-core/src/api-manager/datasources/e4/categories/e4-categories.translator";
+import type { Category as E4Category } from "@evenicanpm/storefront-core/src/api-manager/datasources/e4/graphqlRequestSdk";
+import getGraphqlClient from "@evenicanpm/storefront-core/src/api-manager/lib/get-graphql-client";
+import type { CategoryApi } from "@evenicanpm/storefront-core/src/api-manager/types/Datasource";
+import type { CategoryHierarchy } from "@evenicanpm/storefront-core/src/lib/category-helpers";
 
 const categories: CategoryApi = {
 	async getCategories(): Promise<CategoryHierarchy[]> {