@ethlete/cli 3.0.0-next.27 → 3.0.0-next.28

package/src/lib/design/system/check-system.js

@@ -20,25 +20,32 @@ var __rest = (this && this.__rest) || function (s, e) {
     return t;
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.checkSystemRendered = exports.checkSystem = exports.staleSketchBasesOf = exports.ruleSummaryText = exports.summaryText = exports.partOfFile = exports.buildReadyInputsOf = exports.ruleProblemsOf = exports.checkRules = exports.ruleLinesOf = exports.warningProblemsOf = void 0;
+exports.checkSystemRendered = exports.checkSystem = exports.staleSketchBasesOf = exports.ruleSummaryText = exports.summaryText = exports.buildReadyInputsOf = exports.ruleProblemsOf = exports.uncomparedLinesOf = exports.checkRules = exports.ruleLinesOf = exports.warningProblemsOf = void 0;
 const path_1 = require("path");
+const base_issues_1 = require("./base-issues");
+const design_hash_1 = require("./design-hash");
+const reachable_files_1 = require("./reachable-files");
 const accepted_pictures_1 = require("./accepted-pictures");
 const imports_1 = require("./imports");
 const complete_1 = require("./complete");
 const embedded_actions_1 = require("./embedded-actions");
 const action_lost_1 = require("./action-lost");
+const harness_map_1 = require("./harness-map");
+const stale_cli_dist_1 = require("../stale-cli-dist");
 const capability_place_1 = require("./rules/capability-place");
 const action_undeclared_1 = require("./action-undeclared");
 const bespoke_controls_1 = require("./bespoke-controls");
 const dropped_props_1 = require("./dropped-props");
 const drawn_open_points_1 = require("./drawn-open-points");
 const open_points_1 = require("./open-points");
-const part_go_1 = require("./part-go");
 const part_task_1 = require("./part-task");
 const part_ready_1 = require("./part-ready");
-const part_build_ready_1 = require("./part-build-ready");
+const check_record_1 = require("./check-record");
 const actions_command_1 = require("./actions-command");
+const rule_baseline_1 = require("./rule-baseline");
+const slow_checks_1 = require("./slow-checks");
 const stale_parts_1 = require("./stale-parts");
+const rule_skips_1 = require("./rule-skips");
 const stale_dist_1 = require("./stale-dist");
 const read_open_points_1 = require("./read-open-points");
 const resolve_product_1 = require("./resolve-product");
@@ -46,6 +53,7 @@ const canonical_class_1 = require("./rules/canonical-class");
 const component_copy_1 = require("./rules/component-copy");
 const denied_class_1 = require("./rules/denied-class");
 const native_title_1 = require("./rules/native-title");
+const command_text_1 = require("./rules/command-text");
 const render_check_1 = require("./render-check");
 const flow_1 = require("./rules/flow");
 const implements_1 = require("./rules/implements");
@@ -57,12 +65,15 @@ const kit_outside_pages_1 = require("./rules/kit-outside-pages");
 const inline_ui_in_page_1 = require("./rules/inline-ui-in-page");
 const inline_svg_1 = require("./rules/inline-svg");
 const top_level_await_1 = require("./rules/top-level-await");
+const skips_1 = require("./rules/skips");
 const motion_1 = require("./rules/motion");
 const stale_comment_1 = require("./rules/stale-comment");
 const glued_interpolation_1 = require("./rules/glued-interpolation");
 const undefined_class_1 = require("./rules/undefined-class");
 const undefined_token_1 = require("./rules/undefined-token");
 const token_selectors_1 = require("./rules/token-selectors");
+const sdk_attribute_value_1 = require("./rules/sdk-attribute-value");
+const sdk_private_var_1 = require("./rules/sdk-private-var");
 const upward_dependency_1 = require("./rules/upward-dependency");
 const svg_asset_1 = require("./rules/svg-asset");
 const stale_replace_1 = require("./rules/stale-replace");
@@ -72,7 +83,9 @@ const utility_css_1 = require("./rules/utility-css");
 const orphan_endpoint_1 = require("./rules/orphan-endpoint");
 const sample_default_1 = require("./rules/sample-default");
 const unbound_input_1 = require("./rules/unbound-input");
+const pending_state_1 = require("./rules/pending-state");
 const view_coverage_1 = require("./rules/view-coverage");
+const design_coverage_1 = require("./rules/design-coverage");
 const widths_1 = require("./rules/widths");
 const check_sketches_1 = require("./sketch/check-sketches");
 const merged_parts_1 = require("./sketch/merged-parts");
@@ -80,7 +93,9 @@ const stale_base_1 = require("./sketch/stale-base");
 const sketch_1 = require("./sketch/sketch");
 const system_tsconfig_1 = require("./system-tsconfig");
 const invocation_1 = require("../../invocation");
+const leftover_gate_files_1 = require("./leftover-gate-files");
 const uncommitted_decisions_1 = require("./uncommitted-decisions");
+const phase_timing_1 = require("../phase-timing");
 const RULES = [
     imports_1.importProblemsOf,
     upward_dependency_1.upwardDependenciesOf,
@@ -90,6 +105,7 @@ const RULES = [
     motion_1.scriptedMotionOf,
     motion_1.badMotionsOf,
     motion_1.badUnreachableOf,
+    skips_1.badSkipsOf,
     motion_1.hardCodedMotionOf,
     stale_comment_1.staleCommentsOf,
     stale_comment_1.staleNotesOf,
@@ -108,11 +124,14 @@ const RULES = [
     undefined_class_1.undefinedClassesOf,
     denied_class_1.deniedClassesOf,
     native_title_1.nativeTitlesOf,
+    command_text_1.commandTextOf,
     utility_css_1.utilityCssOf,
     orphan_endpoint_1.orphanEndpointProblemsOf,
     sample_default_1.sampleDefaultProblemsOf,
     unbound_input_1.unboundInputProblemsOf,
     glued_interpolation_1.gluedInterpolationsOf,
+    sdk_attribute_value_1.sdkAttributeValuesOf,
+    sdk_private_var_1.sdkPrivateVarsOf,
 ];
 const warningProblemsOf = (product) => [
     ...(0, unused_shared_export_1.unusedSharedExportsOf)(product),
@@ -122,31 +141,83 @@ const warningProblemsOf = (product) => [
     ...(0, sample_default_1.sampleDefaultWarningsOf)(product),
     ...(0, unbound_input_1.unboundInputWarningsOf)(product),
     ...(0, inline_ui_in_page_1.inlineUiInPageWarningsOf)(product),
+    ...(0, pending_state_1.pendingStateWarningsOf)(product),
 ];
 exports.warningProblemsOf = warningProblemsOf;
 const ruleLinesOf = (target, product) => (0, exports.ruleProblemsOf)(product).map((problem) => lineOf(target, problem));
 exports.ruleLinesOf = ruleLinesOf;
-/** Runs only the static rules of `products` - no draw, no tsc - and prints each problem a product's own files hold; exits 1 on one. */
+/**
+ * Runs only the static rules of `products` - no draw, no tsc - and prints each problem a product's own files hold
+ * that its rule baseline does not list, and each baselined hit; exits 1 on a problem. With `base`, it also flags each app file changed since `base` that moved since its part's implemented record.
+ * Prints one line per rule that did not run; under `CI` a rule skipped for a missing input, such as no `base`, fails.
+ */
 const checkRules = (options) => {
-    var _a;
-    const { target, config } = options;
+    var _a, _b;
+    const { target, config, base } = options;
+    const changed = base === undefined ? [] : (0, part_task_1.gitDiffFilesOf)({ root: target, range: base });
+    const invocation = (_a = options.invocation) !== null && _a !== void 0 ? _a : (0, invocation_1.repoInvocation)({ root: target, subcommand: 'design' });
+    const ci = (0, rule_skips_1.isCiEnv)();
     let failed = 0;
+    const failing = [];
     for (const name of options.products) {
-        const entry = (_a = config.products) === null || _a === void 0 ? void 0 : _a[name];
+        const entry = (_b = config.products) === null || _b === void 0 ? void 0 : _b[name];
         if (!entry) {
             console.error(`NO PRODUCT "${name}" in config.json.`);
             failed++;
+            failing.push(name);
             continue;
         }
         const product = (0, resolve_product_1.resolveProduct)({ target, name, config: entry });
-        const problems = (0, exports.ruleProblemsOf)(product).filter((problem) => !isInBasePart(product, problem.file));
+        const isStatic = (rule) => !(0, slow_checks_1.isSlowRule)(rule) && !render_check_1.BASELINED_RENDER_RULES.has(rule) && rule !== stale_parts_1.UNCOMPARED_RULE;
+        const { result: own, skips } = (0, rule_skips_1.collectingSkips)(() => (0, exports.ruleProblemsOf)(product).filter((problem) => !isInBasePart(product, problem.file)));
+        const baselined = (0, rule_baseline_1.ruleBaselineOf)({ product, problems: own, checked: isStatic });
+        const problems = [
+            ...baselined.problems.filter((problem) => !isInBasePart(product, problem.file)),
+            ...uncomparedOf({ product, changed, invocation }),
+        ];
+        const allSkips = [
+            ...skips,
+            ...(base === undefined
+                ? [{ rule: stale_parts_1.UNCOMPARED_RULE, product: name, kind: 'missing-input', reason: 'no --base given' }]
+                : []),
+        ];
+        const failingSkips = allSkips.filter((skip) => (0, rule_skips_1.isFailingSkip)(skip, ci));
+        [...baselined.lines, ...(0, rule_baseline_1.ruleBaselineLinesOf)(product, (rule) => !isStatic(rule))].forEach((line) => console.log(line));
+        allSkips.filter((skip) => !(0, rule_skips_1.isFailingSkip)(skip, ci)).forEach((skip) => console.log((0, rule_skips_1.skipLineOf)(skip, ci)));
         problems.forEach((problem) => console.error(lineOf(target, problem)));
-        failed += problems.length;
+        failingSkips.forEach((skip) => console.error((0, rule_skips_1.skipLineOf)(skip, ci)));
+        failed += problems.length + failingSkips.length;
+        if (problems.length + failingSkips.length > 0)
+            failing.push(name);
     }
-    console.log(failed === 0 ? 'No static design rule finds a problem.' : `${failed} problem(s).`);
+    console.log(failed === 0 ? 'No static design rule finds a problem.' : `${failed} problem(s) in ${failing.join(', ')}.`);
     return failed === 0 ? 0 : 1;
 };
 exports.checkRules = checkRules;
+const uncomparedOf = (options) => (options.changed.length > 0 ? (0, stale_parts_1.uncomparedAppProblemsOf)(options) : []).filter((problem) => !isInBasePart(options.product, problem.file));
+/**
+ * The IMPLEMENTATION-UNCOMPARED lines `check --rules --base` prints for `products`, limited to the files in `changed`,
+ * without the other rules, and the uncompared parts they name.
+ */
+const uncomparedLinesOf = (options) => {
+    var _a;
+    const { target, config, changed } = options;
+    const invocation = (_a = options.invocation) !== null && _a !== void 0 ? _a : (0, invocation_1.repoInvocation)({ root: target, subcommand: 'design' });
+    const files = new Set(changed.map((file) => (0, path_1.resolve)(target, file)));
+    return options.products.flatMap((name) => {
+        var _a;
+        const entry = (_a = config.products) === null || _a === void 0 ? void 0 : _a[name];
+        if (!entry)
+            return [];
+        const product = (0, resolve_product_1.resolveProduct)({ target, name, config: entry });
+        const problems = uncomparedOf({ product, changed, invocation, onlyChanged: true }).filter((problem) => files.has((0, path_1.resolve)(target, problem.file)));
+        const parts = [...new Set(problems.flatMap((problem) => (problem.part ? [problem.part] : [])))].sort();
+        return problems.length > 0
+            ? [{ product: name, lines: problems.map((problem) => lineOf(target, problem)), parts }]
+            : [];
+    });
+};
+exports.uncomparedLinesOf = uncomparedLinesOf;
 /** Every problem the rules find in a resolved product, its resolution problems first. */
 const ruleProblemsOf = (product) => [
     ...product.problems,
@@ -158,7 +229,7 @@ const buildReadyInputsOf = (product, points = (0, read_open_points_1.readOpenPoi
     const problems = (0, exports.ruleProblemsOf)(product);
     return {
         pointsOf: (part) => (0, read_open_points_1.partPointsOf)(points, part),
-        problemsOf: (part) => problems.filter((problem) => (0, exports.partOfFile)(product, problem.file) === part),
+        problemsOf: (part) => problems.filter((problem) => (0, resolve_product_1.partOfFile)(product, problem.file) === part),
     };
 };
 exports.buildReadyInputsOf = buildReadyInputsOf;
@@ -170,21 +241,12 @@ const withTalliedProblems = (inputs, tally) => (Object.assign(Object.assign({},
         return [...own, ...tallied.map((rule) => ({ rule, file: '', message: 'found by design check' }))];
     } }));
 const lineOf = (target, problem) => `${problem.rule} ${(0, path_1.relative)(target, problem.file)}: ${problem.message}`;
-const PRODUCT_LEVEL = '(product)';
+const PRODUCT_LEVEL = resolve_product_1.PRODUCT_PART_KEY;
 const APP_CODE = 'app code:';
-/** The key of the part whose folder holds `file`, the innermost one, or `(product)` for a file outside every part. */
-const partOfFile = (product, file) => {
-    var _a, _b;
-    return (_b = (_a = product.parts
-        .map((part) => ({ key: (0, resolve_product_1.partKeyOf)(part), dir: (0, path_1.dirname)(part.file) }))
-        .filter(({ dir }) => !(0, path_1.relative)(dir, file).startsWith('..'))
-        .sort((a, b) => b.dir.length - a.dir.length)[0]) === null || _a === void 0 ? void 0 : _a.key) !== null && _b !== void 0 ? _b : PRODUCT_LEVEL;
-};
-exports.partOfFile = partOfFile;
 /** The tally key of `file`: its part, `(product)` for a design file outside every part, or `app code:<file>` for app code. */
 const tallyKeyOf = (target, { product, file }) => {
     var _a;
-    const part = (0, exports.partOfFile)(product, file);
+    const part = (0, resolve_product_1.partOfFile)(product, file);
     const inDesign = [product.dir, (_a = product.base) === null || _a === void 0 ? void 0 : _a.dir].some((dir) => dir && !(0, path_1.relative)(dir, file).startsWith('..'));
     return part !== PRODUCT_LEVEL || inDesign ? part : `${APP_CODE}${(0, path_1.relative)(target, file) || '.'}`;
 };
@@ -339,9 +401,12 @@ const reportSystem = (options) => {
         const uncommitted = options.warn ? (0, uncommitted_decisions_1.uncommittedDecisionsWarningOf)(product) : null;
         if (uncommitted)
             console.warn(uncommitted);
+        const leftover = options.warn ? (0, leftover_gate_files_1.leftoverGateFilesWarningOf)(product) : null;
+        if (leftover)
+            console.warn(leftover);
         if (!options.part)
             (0, stale_comment_1.goneSketchCommentWarningsOf)(product).forEach((warning) => console.warn(warning));
-        const isWanted = (problem) => !options.part || (0, exports.partOfFile)(product, problem.file) === options.part;
+        const isWanted = (problem) => !options.part || (0, resolve_product_1.partOfFile)(product, problem.file) === options.part;
         const isOwn = (problem) => !isInBasePart(product, problem.file) && isWanted(problem);
         const warnings = (0, exports.warningProblemsOf)(product);
         const problems = (0, exports.ruleProblemsOf)(product);
@@ -401,7 +466,7 @@ const drawnFindingsFor = (options) => __awaiter(void 0, void 0, void 0, function
     const stateful = (0, drawn_open_points_1.statefulPartsOf)(product, options.part ? [options.part] : null);
     let gaps = null;
     if (stateful.length > 0) {
-        const checked = yield (0, complete_1.partsCompletenessOf)(Object.assign(Object.assign({}, options), { parts: stateful }));
+        const checked = yield (0, complete_1.partsCompletenessOf)(Object.assign(Object.assign({}, options), { parts: stateful, cached: true }));
         if ('unavailable' in checked) {
             console.log(`COMPLETE CHECK SKIPPED - ${checked.unavailable}`);
             countCannotDraw(Object.assign(Object.assign({}, options), { why: checked.unavailable }));
@@ -422,63 +487,75 @@ const drawnFindingsFor = (options) => __awaiter(void 0, void 0, void 0, function
     return findings;
 });
 const printOpenPoints = (options) => __awaiter(void 0, void 0, void 0, function* () {
-    var _a, _b, _c, _d;
+    var _a;
     const { target, config, products, rendered } = options;
     for (const name of products) {
         const entry = (_a = config.products) === null || _a === void 0 ? void 0 : _a[name];
         if (!entry)
             continue;
         const product = (0, resolve_product_1.resolveProduct)({ target, name, config: entry });
-        const findings = rendered === null ? {} : yield drawnFindingsFor(Object.assign(Object.assign({}, options), { product, rendered }));
-        if (rendered === null && options.notDrawn)
-            countCannotDraw(Object.assign(Object.assign({}, options), { product, why: options.notDrawn }));
-        const allPoints = (0, read_open_points_1.readOpenPoints)(product, findings);
-        const points = allPoints.filter(({ part }) => !options.part || part === options.part);
-        for (const { part, points: ofPart } of points) {
-            const counted = tallyOf(options.tally, { product: name, part });
-            if (counted)
-                counted.open += ofPart.length;
-        }
-        (0, open_points_1.openPointsText)(name, points).forEach((line) => console.log(line));
-        if (!options.part)
-            (0, view_coverage_1.uncoveredViewsText)(name, (0, view_coverage_1.uncoveredViewsOf)(product)).forEach((line) => console.log(line));
-        const unlinked = (0, read_open_points_1.unlinkedPartsOf)(product).filter((part) => !options.part || part === options.part);
-        if (unlinked.length > 0)
-            console.log(`UNLINKED ${name}: ${unlinked.join(', ')}`);
-        (0, read_open_points_1.instantLinesOf)(product, options.part
-            ? [options.part]
-            : product.parts.filter((part) => part.origin !== 'base').map((part) => (0, resolve_product_1.partKeyOf)(part))).forEach((line) => console.log(line));
-        const upgraded = (0, stale_parts_1.upgradeLegacyMarksOf)({ product, only: options.part });
-        if (upgraded.length > 0)
-            console.log(`REHASHED ${name}: ${upgraded.map(({ part, marks }) => `${part} (${marks.join(', ')})`).join(', ')}`);
-        yield (0, part_build_ready_1.recordBuildReady)(Object.assign({ product, parts: options.part
-                ? [options.part]
-                : product.parts.filter((part) => part.origin !== 'base').map((part) => (0, resolve_product_1.partKeyOf)(part)), inputs: withTalliedProblems((0, exports.buildReadyInputsOf)(product, allPoints), (_b = options.tally) === null || _b === void 0 ? void 0 : _b.get(name)) }, (rendered === null
+        const findings = rendered === null
             ? {}
-            : { actionsOf: (part) => (0, actions_command_1.partActionFailuresOf)({ target, config, product, part }) })));
-        const ready = (0, part_ready_1.readyPartsOf)(product).filter((key) => !options.part || key === options.part);
-        if (ready.length > 0)
-            console.log(`READY ${name}: ${ready.join(', ')}`);
-        for (const part of ready) {
-            const embedded = (0, part_ready_1.actionsRerunOf)({ product, part });
-            if (embedded.length === 0)
-                continue;
-            console.log((0, embedded_actions_1.actionsRerunLineOf)({ product: name, part, embedded }));
-            const counted = tallyOf(options.tally, { product: name, part });
-            if (counted)
-                counted.open += 1;
-        }
-        const go = (0, part_go_1.goPartsOf)(product).filter((key) => !options.part || key === options.part);
-        if (go.length > 0)
-            console.log(`GO ${name}: ${go.join(', ')}`);
-        for (const part of go) {
-            const review = (_d = (_c = (0, part_go_1.goMarkOf)({ product, part })) === null || _c === void 0 ? void 0 : _c.review) !== null && _d !== void 0 ? _d : [];
-            if (review.length > 0)
-                console.log((0, accepted_pictures_1.newStatesLineOf)({ product: name, part, states: review }));
-        }
-        (0, stale_parts_1.stalePartsOf)({ product, only: options.part }).forEach((stale) => console.log((0, stale_parts_1.staleLineOf)(name, stale)));
+            : yield (0, phase_timing_1.timedPhase)('completeness', () => drawnFindingsFor(Object.assign(Object.assign({}, options), { product, rendered })));
+        yield (0, phase_timing_1.timedPhase)('open-points', () => printProductOpenPoints(Object.assign(Object.assign({}, options), { product, findings })));
     }
 });
+const printProductOpenPoints = (options) => __awaiter(void 0, void 0, void 0, function* () {
+    var _a;
+    const { target, config, rendered, product, findings } = options;
+    const name = product.name;
+    if (rendered === null && options.notDrawn)
+        countCannotDraw(Object.assign(Object.assign({}, options), { product, why: options.notDrawn }));
+    const allPoints = (0, read_open_points_1.readOpenPoints)(product, findings);
+    const points = allPoints.filter(({ part }) => !options.part || part === options.part);
+    for (const { part, points: ofPart } of points) {
+        const counted = tallyOf(options.tally, { product: name, part });
+        if (counted)
+            counted.open += ofPart.length;
+    }
+    (0, open_points_1.openPointsText)(name, points).forEach((line) => console.log(line));
+    if (!options.part)
+        (0, view_coverage_1.uncoveredViewsText)(name, (0, view_coverage_1.uncoveredViewsOf)(product)).forEach((line) => console.log(line));
+    const unlinked = (0, read_open_points_1.unlinkedPartsOf)(product).filter((part) => !options.part || part === options.part);
+    if (unlinked.length > 0)
+        console.log(`UNLINKED ${name}: ${unlinked.join(', ')}`);
+    (0, read_open_points_1.instantLinesOf)(product, options.part
+        ? [options.part]
+        : product.parts.filter((part) => part.origin !== 'base').map((part) => (0, resolve_product_1.partKeyOf)(part))).forEach((line) => console.log(line));
+    const upgraded = (0, stale_parts_1.upgradeLegacyMarksOf)({ product, only: options.part });
+    if (upgraded.length > 0)
+        console.log(`REHASHED ${name}: ${upgraded.map(({ part, marks }) => `${part} (${marks.join(', ')})`).join(', ')}`);
+    const recorded = yield (0, check_record_1.recordCheckedBuildReady)(Object.assign(Object.assign({ target,
+        config, settle: options.part && rendered !== null ? [options.part] : [], product, parts: options.part
+            ? [options.part]
+            : product.parts.filter((part) => part.origin !== 'base').map((part) => (0, resolve_product_1.partKeyOf)(part)), inputs: withTalliedProblems((0, exports.buildReadyInputsOf)(product, allPoints), (_a = options.tally) === null || _a === void 0 ? void 0 : _a.get(name)) }, (rendered === null
+        ? {}
+        : {
+            actionsOf: (part) => (0, actions_command_1.partActionFailuresOf)(Object.assign({ target, config, product, part }, (options.part ? { onNote: console.log } : {}))),
+            declaredActionsOf: (part) => __awaiter(void 0, void 0, void 0, function* () {
+                const declared = yield (0, action_lost_1.declaredPartActionsOf)({ target, config, product, part, warm: options.warm });
+                if (typeof declared === 'string')
+                    console.log(`ACTIONS NOT RECORDED ${name} ${part}: ${declared}`);
+                return declared;
+            }),
+        })), (options.part ? { onNoRecord: (line) => console.log(line) } : {})));
+    const waiting = [...recorded.values()].filter((result) => !result.ready && result.blockers.some((blocker) => blocker.kind === 'pending')).length;
+    if (waiting > 0)
+        console.log((0, check_record_1.slowWaitingLineOf)({ product: name, count: waiting }));
+    const ready = (0, part_ready_1.readyPartsOf)(product).filter((key) => !options.part || key === options.part);
+    if (ready.length > 0)
+        console.log(`READY ${name}: ${ready.join(', ')}`);
+    for (const part of ready) {
+        const embedded = (0, part_ready_1.actionsRerunOf)({ product, part });
+        if (embedded.length === 0)
+            continue;
+        console.log((0, embedded_actions_1.actionsRerunLineOf)({ product: name, part, embedded }));
+        const counted = tallyOf(options.tally, { product: name, part });
+        if (counted)
+            counted.open += 1;
+    }
+    (0, stale_parts_1.stalePartsOf)({ product, only: options.part }).forEach((stale) => console.log((0, stale_parts_1.staleLineOf)(name, stale)));
+});
 const notCheckedLineOf = (options) => `NOT CHECKED ${options.product} render rules on ${options.parts} - ${options.why}`;
 const printUndrawn = (issues) => {
     for (const product of new Set(issues.map((issue) => issue.product))) {
@@ -498,11 +575,41 @@ const printUndrawn = (issues) => {
         states.forEach((state) => console.log(notCheckedLineOf({ product, parts: state, why: 'it did not draw, see RENDER above' })));
     }
 };
+const RENDER_INPUTS_OUTSIDE_PARTS = ['libs/', 'package.json', 'yarn.lock'];
+const oldIssuesOfRun = (options) => {
+    try {
+        return new Set(options.resolved.flatMap((product) => {
+            const root = (0, reachable_files_1.repoRootOf)(product);
+            const parts = product.parts
+                .filter((part) => part.origin !== 'base' && (!options.part || (0, resolve_product_1.partKeyOf)(part) === options.part))
+                .filter((part) => !options.undrawn.has((0, resolve_product_1.partKeyOf)(part)))
+                .map((part) => ({
+                part: (0, resolve_product_1.partKeyOf)(part),
+                inputs: [
+                    ...Object.keys((0, design_hash_1.designHashOf)({ product, part }).files),
+                    `${(0, path_1.relative)(root, (0, path_1.dirname)(part.file)).split(path_1.sep).join('/')}/`,
+                    ...RENDER_INPUTS_OUTSIDE_PARTS,
+                ],
+            }));
+            return [
+                ...(0, base_issues_1.oldRenderIssuesOf)({
+                    root,
+                    file: (0, base_issues_1.baseIssuesFileOf)(product),
+                    parts,
+                    issues: options.issues.filter((issue) => issue.product === product.name),
+                }),
+            ];
+        }));
+    }
+    catch (_a) {
+        return new Set();
+    }
+};
 const renderSystem = (options) => __awaiter(void 0, void 0, void 0, function* () {
-    const { code, fatal } = reportSystem(Object.assign(Object.assign({}, options), { warn: true }));
+    const { code, fatal } = (0, phase_timing_1.timedPhase)('static', () => reportSystem(Object.assign(Object.assign({}, options), { warn: true })));
     if (fatal)
         return { code, rendered: null };
-    const rendered = yield (0, render_check_1.renderIssuesOf)(Object.assign(Object.assign({}, options), { onProgress: (line) => console.log(line), jobs: options.products.map((product) => ({ product, sketch: null, parts: options.part ? [options.part] : null })) }));
+    const rendered = yield (0, phase_timing_1.timedPhase)('render-inspect', () => (0, render_check_1.renderIssuesOf)(Object.assign(Object.assign({}, options), { cached: true, onProgress: (line) => console.log(line), jobs: options.products.map((product) => ({ product, sketch: null, parts: options.part ? [options.part] : null })) })));
     const resolved = options.products.flatMap((name) => {
         var _a;
         const entry = (_a = options.config.products) === null || _a === void 0 ? void 0 : _a[name];
@@ -536,7 +643,37 @@ const renderSystem = (options) => __awaiter(void 0, void 0, void 0, function* ()
             return found !== undefined && (0, part_ready_1.readyMarkOf)({ product: found, part }) !== null;
         },
     });
-    const { issues } = underGo;
+    const baselined = resolved.map((product) => {
+        const own = underGo.issues.filter((issue) => issue.product === product.name && render_check_1.BASELINED_RENDER_RULES.has(issue.rule));
+        const undrawn = new Set(underGo.issues
+            .filter((issue) => issue.product === product.name && ((0, drawn_open_points_1.isPartUndrawn)(issue) || (0, drawn_open_points_1.isStateUndrawn)(issue)))
+            .map((issue) => issue.part));
+        const problemOf = new Map(own.map((issue) => [(0, rule_baseline_1.renderProblemOf)(product, issue), issue]));
+        const result = (0, rule_baseline_1.ruleBaselineOf)({
+            product,
+            problems: [...problemOf.keys()],
+            checked: (rule, part) => render_check_1.BASELINED_RENDER_RULES.has(rule) && !undrawn.has(part) && (!options.part || part === options.part),
+        });
+        return {
+            product,
+            own,
+            lines: result.lines,
+            failing: result.problems.flatMap((problem) => { var _a; return (_a = problemOf.get(problem)) !== null && _a !== void 0 ? _a : []; }),
+            problems: result.problems.filter((problem) => !problemOf.has(problem)),
+        };
+    });
+    const passed = new Set(baselined.flatMap(({ own, failing }) => own.filter((issue) => !failing.includes(issue))));
+    const issues = underGo.issues.filter((issue) => !passed.has(issue));
+    const baselineProblems = baselined.flatMap(({ product, problems }) => problems.map((problem) => ({ product, problem })));
+    baselined.forEach(({ lines }) => lines.forEach((line) => console.log(line)));
+    baselineProblems.forEach(({ product, problem }) => {
+        var _a;
+        console.error(lineOf(options.target, problem));
+        (_a = tallyOf(options.tally, {
+            product: product.name,
+            part: tallyKeyOf(options.target, { product, file: problem.file }),
+        })) === null || _a === void 0 ? void 0 : _a.problems.push(problem.rule);
+    });
     underGo.warnings.forEach(({ product, part, line }) => {
         console.warn(line);
         const counted = tallyOf(options.tally, { product, part });
@@ -551,16 +688,62 @@ const renderSystem = (options) => __awaiter(void 0, void 0, void 0, function* ()
         if (counted)
             counted.warnings += 1;
     });
+    const old = oldIssuesOfRun({
+        resolved,
+        part: options.part,
+        issues: rendered.issues.filter((issue) => !isInBase(issue)),
+        undrawn: new Set(issues.filter(drawn_open_points_1.isPartUndrawn).map((issue) => issue.part)),
+    });
     issues.forEach((issue) => {
         var _a;
-        console.error((0, render_check_1.renderIssueLineOf)(issue));
+        console.error(old.has(issue) ? `OLD ${(0, render_check_1.renderIssueLineOf)(issue)}` : (0, render_check_1.renderIssueLineOf)(issue));
         (_a = tallyOf(options.tally, { product: issue.product, part: (0, render_check_1.ownerPartOf)(issue) })) === null || _a === void 0 ? void 0 : _a.problems.push(issue.rule);
     });
     printUndrawn(issues.filter((issue) => (0, drawn_open_points_1.isPartUndrawn)(issue) || (0, drawn_open_points_1.isStateUndrawn)(issue)));
     if (!options.part)
         for (const product of resolved)
             printBaseFindings(product, rendered.issues.filter((issue) => issue.product === product.name && isInBase(issue)).map((issue) => issue.rule));
-    return { code: code !== 0 || issues.length > 0 ? 1 : 0, rendered: issues, busy: rendered.busy };
+    return {
+        code: code !== 0 || issues.length > 0 || baselineProblems.length > 0 ? 1 : 0,
+        rendered: issues,
+        busy: rendered.busy,
+    };
+});
+const checkProductTail = (options) => __awaiter(void 0, void 0, void 0, function* () {
+    var _a, _b;
+    const { tally, name, entry } = options;
+    const resolved = (0, resolve_product_1.resolveProduct)({ target: options.target, name, config: entry });
+    const capabilities = yield (0, capability_place_1.capabilityPlaceOf)(Object.assign(Object.assign({}, options), { product: resolved }));
+    const isWanted = (problem) => !options.part || (0, resolve_product_1.partOfFile)(resolved, problem.file) === options.part;
+    const coverage = yield (0, design_coverage_1.designCoverageOf)(Object.assign(Object.assign({}, options), { product: resolved }));
+    [...capabilities.warnings, ...coverage].filter(isWanted).forEach((warning) => {
+        console.warn(`WARNING ${lineOf(options.target, warning)}`);
+        const counted = tallyOf(tally, {
+            product: name,
+            part: tallyKeyOf(options.target, { product: resolved, file: warning.file }),
+        });
+        if (counted)
+            counted.warnings += 1;
+    });
+    const drawn = (0, rule_baseline_1.ruleBaselineOf)({
+        product: resolved,
+        problems: [
+            ...(yield (0, dropped_props_1.droppedPropProblemsOf)(Object.assign(Object.assign({}, options), { product: resolved }))),
+            ...(yield (0, bespoke_controls_1.bespokeControlProblemsOf)(Object.assign(Object.assign({}, options), { product: resolved }))),
+            ...(yield (0, action_lost_1.actionLostProblemsOf)(Object.assign(Object.assign({}, options), { product: resolved, invocation: (_a = options.invocation) !== null && _a !== void 0 ? _a : (0, invocation_1.repoInvocation)({ root: options.target, subcommand: 'design' }) }))),
+        ].filter(isWanted),
+        checked: (rule, part) => (0, slow_checks_1.isDrawRule)(rule) && (!options.part || part === options.part),
+    });
+    drawn.lines.forEach((line) => console.log(line));
+    const problems = [...drawn.problems, ...capabilities.errors, ...options.problemsOfEdits].filter(isWanted);
+    for (const problem of problems) {
+        console.error(lineOf(options.target, problem));
+        (_b = tallyOf(tally, {
+            product: name,
+            part: tallyKeyOf(options.target, { product: resolved, file: problem.file }),
+        })) === null || _b === void 0 ? void 0 : _b.problems.push(problem.rule);
+    }
+    return problems.length;
 });
 /**
  * Checks as `checkSystem` does, then draws every state in a headless browser and prints one line per
@@ -571,10 +754,10 @@ const renderSystem = (options) => __awaiter(void 0, void 0, void 0, function* ()
  * the exit code.
  */
 const checkSystemRendered = (options) => __awaiter(void 0, void 0, void 0, function* () {
-    var _a, _b, _c, _d, _e, _f;
+    var _a, _b;
     const tally = new Map();
     const counted = Object.assign(Object.assign({}, options), { tally });
-    for (const line of (0, stale_dist_1.staleDistWarningsOf)(options))
+    for (const line of (0, phase_timing_1.timedPhase)('stale-dist', () => (0, stale_dist_1.staleDistWarningsOf)(options)))
         console.warn(line);
     const editProblems = new Map();
     for (const name of options.products) {
@@ -582,8 +765,13 @@ const checkSystemRendered = (options) => __awaiter(void 0, void 0, void 0, funct
         if (!entry)
             continue;
         const product = (0, resolve_product_1.resolveProduct)({ target: options.target, name, config: entry });
+        const refreshed = (0, phase_timing_1.timedPhase)('harness-map', () => (0, harness_map_1.refreshHarnessMap)({ target: options.target, product }));
+        if (typeof refreshed === 'string')
+            console.log(`HARNESS MAP STALE ${name}: ${refreshed}`);
+        if (refreshed === true)
+            console.log(`REGENERATED ${name}: the stale harness map`);
         const problems = [];
-        const lines = yield (0, accepted_pictures_1.autoAcceptOf)(Object.assign(Object.assign({}, options), { product, only: options.part, draw: options.drawPictures, problems }));
+        const lines = yield (0, phase_timing_1.timedPhase)('auto-accept', () => (0, accepted_pictures_1.autoAcceptOf)(Object.assign(Object.assign({}, options), { product, only: options.part, draw: options.drawPictures, problems })));
         editProblems.set(name, problems);
         lines.forEach((line) => console.log(line));
     }
@@ -595,49 +783,29 @@ const checkSystemRendered = (options) => __awaiter(void 0, void 0, void 0, funct
         const entry = (_b = options.config.products) === null || _b === void 0 ? void 0 : _b[name];
         if (!entry)
             continue;
-        const resolved = (0, resolve_product_1.resolveProduct)({ target: options.target, name, config: entry });
-        const capabilities = yield (0, capability_place_1.capabilityPlaceOf)(Object.assign(Object.assign({}, options), { product: resolved }));
-        const isWanted = (problem) => !options.part || (0, exports.partOfFile)(resolved, problem.file) === options.part;
-        capabilities.warnings.filter(isWanted).forEach((warning) => {
-            console.warn(`WARNING ${lineOf(options.target, warning)}`);
-            const counted = tallyOf(tally, {
-                product: name,
-                part: tallyKeyOf(options.target, { product: resolved, file: warning.file }),
-            });
-            if (counted)
-                counted.warnings += 1;
-        });
-        const problems = [
-            ...(yield (0, dropped_props_1.droppedPropProblemsOf)(Object.assign(Object.assign({}, options), { product: resolved }))),
-            ...(yield (0, bespoke_controls_1.bespokeControlProblemsOf)(Object.assign(Object.assign({}, options), { product: resolved }))),
-            ...(yield (0, action_lost_1.actionLostProblemsOf)(Object.assign(Object.assign({}, options), { product: resolved, invocation: (_c = options.invocation) !== null && _c !== void 0 ? _c : (0, invocation_1.repoInvocation)({ root: options.target, subcommand: 'design' }) }))),
-            ...capabilities.errors,
-            ...((_d = editProblems.get(name)) !== null && _d !== void 0 ? _d : []),
-        ].filter(isWanted);
-        for (const problem of problems) {
-            console.error(lineOf(options.target, problem));
-            (_e = tallyOf(tally, {
+        failed += yield (0, phase_timing_1.timedPhase)('tail', () => { var _a; return checkProductTail(Object.assign(Object.assign({}, options), { tally, name, entry, problemsOfEdits: (_a = editProblems.get(name)) !== null && _a !== void 0 ? _a : [] })); });
+    }
+    (0, phase_timing_1.timedPhase)('summary', () => {
+        var _a;
+        const staleCli = (0, stale_cli_dist_1.runningCliStaleWarning)();
+        if (staleCli)
+            console.log(staleCli);
+        for (const name of options.products) {
+            const entry = (_a = options.config.products) === null || _a === void 0 ? void 0 : _a[name];
+            if (!entry)
+                continue;
+            const resolved = (0, resolve_product_1.resolveProduct)({ target: options.target, name, config: entry });
+            const parts = resolved.parts.filter((part) => part.origin !== 'base').map(resolve_product_1.partKeyOf);
+            partsTotal += options.part ? parts.filter((key) => key === options.part).length : parts.length;
+            (0, exports.summaryText)({
                 product: name,
-                part: tallyKeyOf(options.target, { product: resolved, file: problem.file }),
-            })) === null || _e === void 0 ? void 0 : _e.problems.push(problem.rule);
+                parts,
+                tally,
+                only: options.part,
+                done: (0, part_task_1.doneParts)({ product: resolved, parts }).length,
+            }).forEach((line) => console.log(line));
         }
-        failed += problems.length;
-    }
-    for (const name of options.products) {
-        const entry = (_f = options.config.products) === null || _f === void 0 ? void 0 : _f[name];
-        if (!entry)
-            continue;
-        const resolved = (0, resolve_product_1.resolveProduct)({ target: options.target, name, config: entry });
-        const parts = resolved.parts.filter((part) => part.origin !== 'base').map(resolve_product_1.partKeyOf);
-        partsTotal += options.part ? parts.filter((key) => key === options.part).length : parts.length;
-        (0, exports.summaryText)({
-            product: name,
-            parts,
-            tally,
-            only: options.part,
-            done: (0, part_task_1.doneParts)({ product: resolved, parts }).length,
-        }).forEach((line) => console.log(line));
-    }
+    });
     const exit = code !== 0 || failed > 0 ? 1 : 0;
     if (exit === 0)
         console.log('ok');