@ethlete/cli 3.0.0-next.27 → 3.0.0-next.28

package/src/lib/design/sketch-command.js

@@ -20,39 +20,54 @@ var __rest = (this && this.__rest) || function (s, e) {
     return t;
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.designSketch = exports.verdictLinesOf = exports.beforeLinesOf = exports.sketchFlagHelpOf = exports.SKETCH_USAGE = void 0;
+exports.designSketch = exports.verdictLinesOf = exports.beforeLinesOf = exports.retriedHeldMerges = exports.sketchFlagHelpOf = exports.SKETCH_USAGE = void 0;
 const unused_closure_1 = require("./system/sketch/unused-closure");
+const crypto_1 = require("crypto");
 const fs_1 = require("fs");
+const os_1 = require("os");
 const path_1 = require("path");
+const phase_timing_1 = require("./phase-timing");
+const write_origin_1 = require("./system/write-origin");
 const assets_1 = require("./system/assets");
 const comment_1 = require("./system/comments/comment");
 const product_1 = require("./system/product");
 const resolve_product_1 = require("./system/resolve-product");
 const check_format_1 = require("./system/sketch/check-format");
 const frame_budget_1 = require("./system/sketch/frame-budget");
+const note_language_1 = require("./system/sketch/note-language");
 const check_sketches_1 = require("./system/sketch/check-sketches");
 const cli_args_1 = require("./system/sketch/cli-args");
 const ready_shots_1 = require("./ready-shots");
 const no_visible_change_1 = require("./system/sketch/no-visible-change");
+const covered_diffs_1 = require("./system/sketch/covered-diffs");
 const viewed_shots_1 = require("./system/sketch/viewed-shots");
+const complete_1 = require("./system/complete");
 const merge_1 = require("./system/sketch/merge");
 const merge_step_1 = require("./system/sketch/merge-step");
 const check_system_1 = require("./system/check-system");
+const stale_base_1 = require("./system/sketch/stale-base");
 const invocation_1 = require("../invocation");
 const merged_parts_1 = require("./system/sketch/merged-parts");
+const no_verdict_1 = require("./system/no-verdict");
 const render_check_1 = require("./system/render-check");
 const merge_preview_1 = require("./system/sketch/merge-preview");
 const open_points_1 = require("./system/open-points");
 const read_open_points_1 = require("./system/read-open-points");
 const overlay_1 = require("./system/sketch/overlay");
+const system_modules_1 = require("./system/system-modules");
+const unchanged_states_1 = require("./system/sketch/unchanged-states");
 const rebase_port_1 = require("./system/sketch/rebase-port");
 const theming_text_1 = require("./system/theming-text");
+const warm_draw_1 = require("./warm-draw");
 const sketch_1 = require("./system/sketch/sketch");
+const plain_output_1 = require("../plain-output");
+const design_lint_1 = require("./design-lint");
 exports.SKETCH_USAGE = [
-    'sketch new <layer>/<name> [<layer>/<name>…] --variants a,b --by <model id> [--like <layer>/<name>[:<variant>]] [--name <sketch name>] [--round <title>] [--note <text>] [--variant-note <variant>=<text>]… [--override | --into-base] [--product <name>]',
+    'sketch new <layer>/<name> [<layer>/<name>…] --variants a,b --by <model id> [--like <layer>/<name>[:<variant>]] [--name <sketch name>] [--round <title>] [--note <text>] [--variant-note <variant>=<text>]… [--override | --into-base] [--ready] [--product <name>]',
     'sketch variant <layer>/<name> <variant>[,<variant>…] --from <variant> --by <model id> [--round <title> --note <why the running round lost> [--round-note <what the new round shows>]] [--product <name>]',
     'sketch round <layer>/<name> <round> [--title <text>] [--note <text>] [--drops <state,state>] --by <model id> [--product <name>]',
-    'sketch note <layer>/<name> <variant> <text> --by <model id> [--product <name>]',
+    'sketch covers <layer>/<name> [[<layer>/<name>:]<state>[@<x>,<y>,<w>,<h>]…] --by <model id> [--product <name>]',
+    'sketch note <layer>/<name> [<variant>] <text> [--round <round>] --by <model id> [--product <name>]',
     'sketch target add <layer>/<name> <layer>/<name> --by <model id> [--product <name>]',
     'sketch target remove <layer>/<name> <layer>/<name> --by <model id> [--product <name>]',
     'sketch list [--product <name>] [--json]',
@@ -63,7 +78,7 @@ exports.SKETCH_USAGE = [
     'sketch check [<layer>/<name>] [--fix] [--product <name>]',
     'sketch preview <layer>/<name> <variant> [--product <name>] [--json]',
     'sketch rebase <layer>/<name> [--ported] --by <model id> [--product <name>]',
-    'sketch merge <layer>/<name> [--note <reason> [--replace-note]] [--variant <key> --allowed-by <plan ref>] --by <model id> [--product <name>]',
+    'sketch merge <layer>/<name> [--note <reason> [--replace-note]] [--variant <key> --allowed-by <plan ref>] [--decided-by <name>] --by <model id> [--product <name>]',
     'sketch discard <layer>/<name> --by <model id> [--product <name>]',
     'sketch reject <layer>/<name> --variant <key> [--reason <text>] --by <model id | designer> [--product <name>]',
     'sketch reopen <layer>/<name> --variant <key> [--reason <text>] --by <model id | designer> [--product <name>]',
@@ -77,14 +92,16 @@ const FLAG_HELP = {
     '--like': 'start each variant from another part, or from a variant of the open sketch on it',
     '--override': 'on a base part: merge into a product copy that overrides the base, not into the base; on a product override: sketch that copy',
     '--into-base': 'on a part the product overrides: start from the product copy, merge into the base and remove the copy',
+    '--ready': 'on new: run sketch ready (its gates are the check) right after opening the sketch; it fails when either refuses and the sketch stays in progress',
     '--ported': 'on rebase: the conflicting files hold the product change already, ported by hand - keep them and rebase',
-    '--round': 'the title of a new round',
+    '--round': 'the title of a new round; on note: the key of the round whose note to rewrite',
     '--round-note': 'what the new round shows',
     '--from': 'the variant to copy',
     '--title': 'the new title of the round',
     '--drops': 'the states the round drops on purpose, a comma list',
     '--variant': 'the variant the command is about; on merge, the only live variant of a sketch with no pick',
     '--allowed-by': 'the plan entry that lets the merge go without a pick in Studio; noted in merged.json, needs --variant',
+    '--decided-by': 'on merge: who picked the variant, as merged.json records it (default user); a name the designer gave you at this terminal, e.g. tom - not with --allowed-by',
     '--replace-note': "on merge: also write --note over each target part's note",
     '--reason': 'why; on reject of a variant that is rejected already it sets the reason of that rejection; stored with who wrote it',
     '--until': 'what the pending change waits on: an open decision, a helper still to land',
@@ -116,6 +133,7 @@ const WRITES = new Set([
     'variant',
     'round',
     'note',
+    'covers',
     'report',
     'ready',
     'hold',
@@ -125,6 +143,11 @@ const WRITES = new Set([
     'discard',
     ...VERDICTS,
 ]);
+const RETRIES = new Set([...WRITES, 'check']);
+const staleBasesOf = (context, options) => {
+    var _a;
+    return (0, check_system_1.staleSketchBasesOf)(Object.assign(Object.assign({}, options), { invocation: (_a = context.invocation) !== null && _a !== void 0 ? _a : (0, invocation_1.repoInvocation)({ root: context.target, subcommand: 'design' }) }));
+};
 const fail = (message) => {
     console.error(message);
     return 1;
@@ -183,7 +206,7 @@ const variantLineOf = (options) => {
     const files = sketch.targets.map((part) => partFileOf(Object.assign(Object.assign({}, options), { part }))).join(', ');
     return `  ${variant}: ${files}  assets: ${(0, path_1.relative)(root, (0, path_1.resolve)(sketch.dir, variant, assets_1.ASSETS_FOLDER))}/`;
 };
-const created = (context) => {
+const opened = (context) => {
     var _a, _b, _c, _d, _e;
     const { target, config, args } = context;
     const product = (0, cli_args_1.oneProductOf)({ target, config, asked: args.values['--product'] });
@@ -236,11 +259,35 @@ const created = (context) => {
         console.log(`  shared by every variant, imported as @shared/<path>; edit it here, not in a copy:`);
         shared.forEach((file) => console.log(`    ${(0, path_1.relative)(target, file)}`));
     }
-    nextStepsOf(sketch, product.name).forEach((line) => console.log(line));
+    nextStepsOf(sketch, product).forEach((line) => console.log(line));
     return 0;
 };
-const nextStepsOf = (sketch, product) => {
+const created = (context) => __awaiter(void 0, void 0, void 0, function* () {
+    const code = opened(context);
+    if (code !== 0 || !context.args.flags.has('--ready'))
+        return code;
+    const found = productAndSketchOf(Object.assign(Object.assign({}, context), { args: Object.assign(Object.assign({}, context.args), { positional: [openedTargetOf(context)] }) }));
+    if (typeof found === 'string')
+        return fail(found);
+    const again = Object.assign(Object.assign({}, context), { args: Object.assign(Object.assign({}, context.args), { positional: [found.sketch.target] }) });
+    const readyCode = yield readied(again);
+    return readyCode === 0
+        ? 0
+        : fail(`${found.sketch.target} is still in progress: sketch ready refused - fix it, then run sketch ready`);
+});
+const openedTargetOf = ({ args }) => {
+    const [first] = args.positional;
+    const name = args.values['--name'];
+    return name === undefined ? (first !== null && first !== void 0 ? first : '') : `${first}@${name}`;
+};
+const noteLanguageLineOf = (product) => product.config.noteLanguage === undefined
+    ? []
+    : [
+        `  write every round and variant note in ${note_language_1.NOTE_LANGUAGE_NAMES[product.config.noteLanguage]}: that is the product's UI language`,
+    ];
+const nextStepsOf = (sketch, productSource) => {
     var _a;
+    const product = productSource.name;
     const at = `${sketch.target} --product ${product}`;
     const first = (_a = sketch.variants[0]) !== null && _a !== void 0 ? _a : '<key>';
     const running = (0, sketch_1.runningRoundOf)(sketch);
@@ -253,10 +300,11 @@ const nextStepsOf = (sketch, product) => {
             ]
             : []),
         `  sketch check ${at}`,
+        ...noteLanguageLineOf(productSource),
         `  shot ${sketch.targets[0]} --states --variants --product ${product}   look at it: ready refuses a pixel diff without a viewed shot`,
         `  sketch ready ${at} --by <model id>`,
         `  sketch report ${at} --variant ${first} --by <model id> --done              after ready, once you stop drawing a variant; no report runs yet, so none is needed now`,
-        `  a shared JSON file ready wrote (merged.json, go.json): commit it with \`et design commit-hunks <file> --part ${sketch.targets[0]}\`, never as a whole file another session also edits`,
+        `  a shared JSON file ready wrote (merged.json): commit it with \`et design commit-hunks <file> --part ${sketch.targets[0]}\`, never as a whole file another session also edits`,
         theming_text_1.THEMING_TEXT,
     ];
 };
@@ -275,7 +323,7 @@ const VARIANT_USAGE = 'usage: sketch variant <layer>/<name> <variant>[,<variant>
 const varied = (context) => {
     var _a;
     return withSketch(Object.assign(Object.assign({}, context), { noSketchHint: ` - start one with: sketch new ${(_a = context.args.positional[0]) !== null && _a !== void 0 ? _a : '<layer>/<name>'} --variants a,b,c --round "<title>"` }), ({ sketch }) => {
-        var _a, _b, _c, _d, _e;
+        var _a, _b, _c, _d, _e, _f;
         const { positional, values } = context.args;
         const variant = positional[1];
         const from = values['--from'];
@@ -322,6 +370,8 @@ const varied = (context) => {
         for (const name of variants) {
             console.log(`${added.target} in progress: variant ${name} from ${from} in round ${(_c = round === null || round === void 0 ? void 0 : round.key) !== null && _c !== void 0 ? _c : ''}`);
             console.log(variantLineOf({ root: context.target, sketch: added, variant: name }));
+            if (((_d = (0, sketch_1.rejectionOf)(added, from)) === null || _d === void 0 ? void 0 : _d.status) === 'withdrawn')
+                console.log(`  ${name}: from withdrawn ${from}`);
         }
         if (title !== undefined && (round === null || round === void 0 ? void 0 : round.note) === '')
             console.log(`round ${round.key} has no note yet - sketch ready needs one: sketch round ${added.target} ${round.key} --note "<what the round shows>" --by <model id>`);
@@ -331,12 +381,12 @@ const varied = (context) => {
             sketch,
             variant: from,
             reason: 'round',
-            author: (_d = (0, cli_args_1.authorOf)(context.args)) !== null && _d !== void 0 ? _d : undefined,
+            author: (_e = (0, cli_args_1.authorOf)(context.args)) !== null && _e !== void 0 ? _e : undefined,
             note: lostNote,
             round: round === null || round === void 0 ? void 0 : round.key,
         });
         if (addressed.length > 0)
-            console.log(`addressed ${addressed.length} comment(s) on variant ${from} in round ${(_e = round === null || round === void 0 ? void 0 : round.key) !== null && _e !== void 0 ? _e : ''}: ${addressed.map(({ id }) => id).join(', ')}`);
+            console.log(`addressed ${addressed.length} comment(s) on variant ${from} in round ${(_f = round === null || round === void 0 ? void 0 : round.key) !== null && _f !== void 0 ? _f : ''}: ${addressed.map(({ id }) => id).join(', ')}`);
         return 0;
     });
 };
@@ -424,6 +474,17 @@ const roundEdited = (context) => withSketch(context, ({ sketch }) => {
     return 0;
 });
 const noteEdited = (context) => withSketch(context, ({ sketch }) => {
+    const round = context.args.values['--round'];
+    if (round !== undefined) {
+        const roundNote = context.args.positional.slice(1).join(' ').trim();
+        if (roundNote === '')
+            return fail('usage: sketch note <layer>/<name> --round <round> <text> --by <model id>');
+        const reworded = (0, sketch_1.editRound)({ sketch, round, note: roundNote });
+        if (typeof reworded === 'string')
+            return fail(reworded);
+        console.log(`${reworded.target} round ${round}: ${roundNote}`);
+        return 0;
+    }
     const [, variant, ...words] = context.args.positional;
     const note = words.join(' ').trim();
     if (!variant || note === '')
@@ -434,6 +495,22 @@ const noteEdited = (context) => withSketch(context, ({ sketch }) => {
     console.log(`${edited.target} variant ${variant}: ${note}`);
     return 0;
 });
+const coversEdited = (context) => withSketch(context, ({ sketch }) => {
+    var _a, _b;
+    const covers = context.args.positional.slice(1);
+    const partProblem = (0, covered_diffs_1.coverPartProblemOf)({ sketch, covers });
+    if (partProblem !== null) {
+        console.error(partProblem);
+        return 2;
+    }
+    const edited = (0, covered_diffs_1.editCovers)({ sketch, covers });
+    if (typeof edited === 'string')
+        return fail(edited);
+    console.log(((_a = edited.covers) !== null && _a !== void 0 ? _a : []).length === 0
+        ? `${edited.target} covers no compare DIFF`
+        : `${edited.target} covers the compare DIFFs of ${((_b = edited.covers) !== null && _b !== void 0 ? _b : []).join(', ')} while it is open (ADR 0222)`);
+    return 0;
+});
 const targetRemoved = (context) => {
     const usage = `usage: ${exports.SKETCH_USAGE.find((line) => line.startsWith('sketch target remove'))}`;
     const rest = context.args.positional.slice(1);
@@ -473,6 +550,31 @@ const targetAdded = (context) => {
         return 0;
     });
 };
+const readyLockOf = (sketch) => (0, path_1.resolve)((0, os_1.tmpdir)(), `et-sketch-ready-${(0, crypto_1.createHash)('sha256').update(sketch.dir).digest('hex').slice(0, 16)}.lock`);
+const isRunning = (pid) => {
+    try {
+        process.kill(pid, 0);
+        return true;
+    }
+    catch (_a) {
+        return false;
+    }
+};
+const lockedReady = (sketch) => {
+    const lock = readyLockOf(sketch);
+    const holder = Number(contentOf(lock));
+    if (holder > 0 && isRunning(holder))
+        return null;
+    (0, fs_1.writeFileSync)(lock, String(process.pid));
+    return () => (0, fs_1.rmSync)(lock, { force: true });
+};
+const reportedReopen = (sketch) => {
+    const reopened = (0, sketch_1.reopenChangedReady)(sketch);
+    if (!reopened)
+        return sketch;
+    console.log(`${sketch.target} was ready; ${reopened.changed.join(', ')} changed since - back to in progress`);
+    return reopened.sketch;
+};
 const readied = (context) => {
     const found = productAndSketchOf(context);
     if (typeof found === 'string')
@@ -480,21 +582,44 @@ const readied = (context) => {
     const hold = (0, sketch_1.heldProblemOf)(found.sketch);
     if (hold !== null)
         return fail(hold);
-    const refused = readyRefusalOf(context, found);
+    const reopened = reportedReopen(found.sketch);
+    const current = { product: found.product, sketch: reopened };
+    const refused = (0, phase_timing_1.timedPhase)('gates', () => readyRefusalOf(context, current));
     if (refused !== null)
         return refused;
-    return renderedAndReady(context, found);
+    const unlinted = (0, phase_timing_1.timedPhase)('lint', () => (0, design_lint_1.lintGateLinesOf)({
+        target: context.target,
+        productDir: current.product.dir,
+        files: (0, design_lint_1.variantLintFilesOf)(reopened, reopened.variants.filter((variant) => !(0, sketch_1.rejectionOf)(reopened, variant))),
+    }));
+    if (unlinted.length > 0)
+        return fail(`${unlinted.join('\n')}\n${reopened.target} adds lint warnings - fix them before ready`);
+    const unlock = lockedReady(reopened);
+    if (!unlock)
+        return fail(`another sketch ready run on ${reopened.target} is going - wait for it`);
+    const run = context.warm
+        ? { warm: Object.assign(Object.assign({}, context.warm), { perRun: true }), close: () => __awaiter(void 0, void 0, void 0, function* () { return undefined; }) }
+        : (0, warm_draw_1.createRunDraw)(context.target);
+    return renderedAndReady(Object.assign(Object.assign({}, context), { warm: run.warm }), current).finally(() => __awaiter(void 0, void 0, void 0, function* () {
+        unlock();
+        yield run.close();
+    }));
 };
 const renderedAndReady = (context, found) => __awaiter(void 0, void 0, void 0, function* () {
     var _a;
     const { product, sketch } = found;
-    const rendered = yield renderedVariantsOf({
+    const rendered = yield (0, phase_timing_1.timedPhase)('render-check', () => renderedVariantsOf({
         target: context.target,
         config: context.config,
         product,
-        entries: sketch.variants.filter((variant) => !(0, sketch_1.rejectionOf)(sketch, variant)).map((variant) => ({ sketch, variant })),
+        entries: sketch.variants
+            .filter((variant) => !(0, sketch_1.rejectionOf)(sketch, variant))
+            .map((variant) => ({ sketch, variant })),
         drawn: false,
-    });
+        warm: context.warm,
+    }));
+    if ('issues' in rendered && rendered.noVerdict)
+        return 1;
     if ('issues' in rendered && rendered.issues.length > 0)
         return fail(`${sketch.target} has problems - fix them before ready`);
     const busyAdded = 'issues' in rendered ? openPointLinesOf({ product, sketch, busy: (_a = rendered.busy) !== null && _a !== void 0 ? _a : [] }).added : [];
@@ -504,17 +629,22 @@ const renderedAndReady = (context, found) => __awaiter(void 0, void 0, void 0, f
 });
 const loadedAndReady = (context_1, _a) => __awaiter(void 0, [context_1, _a], void 0, function* (context, { product, sketch }) {
     var _b, _c;
-    const unloaded = yield unloadedLinesOf({ target: context.target, config: context.config, product, sketch });
+    const unloaded = yield (0, phase_timing_1.timedPhase)('load', () => unloadedLinesOf({ target: context.target, config: context.config, product, sketch, warm: context.warm }));
     if (unloaded.length > 0)
         return fail(`${unloaded.join('\n')}\n${sketch.target} does not load - fix it before ready`);
-    const drifts = yield (0, ready_shots_1.sampleMarkDriftLines)({ target: context.target, config: context.config, product, sketch });
+    const drifts = yield (0, phase_timing_1.timedPhase)('mark-drift', () => (0, ready_shots_1.sampleMarkDriftLines)({ target: context.target, config: context.config, product, sketch, warm: context.warm }));
     if (drifts.length > 0)
         return fail(`${drifts.join('\n')}\n${sketch.target} draws one sample with different marks - align them before ready`);
-    const identical = yield (0, ready_shots_1.identicalRenderLines)({ target: context.target, config: context.config, product, sketch });
+    const identical = yield (0, phase_timing_1.timedPhase)('identical', () => (0, ready_shots_1.identicalRenderLines)({ target: context.target, config: context.config, product, sketch, warm: context.warm }));
     if (identical.length > 0)
         return fail(`${identical.join('\n')}\n${sketch.target} draws variants alike - fix them before ready`);
+    const undeclared = yield (0, phase_timing_1.timedPhase)('undeclared', () => undeclaredLinesOf({ target: context.target, config: context.config, product, sketch, warm: context.warm }));
+    if (typeof undeclared === 'string')
+        return fail(undeclared);
+    if (undeclared.length > 0)
+        return fail(`${undeclared.join('\n')}\n${sketch.target} draws controls no controls entry declares - declare them before ready`);
     const changes = sketch.targets.every((key) => product.parts.some((part) => (0, resolve_product_1.partKeyOf)(part) === key))
-        ? yield (0, ready_shots_1.variantChangesShown)({ target: context.target, config: context.config, product, sketch })
+        ? yield (0, phase_timing_1.timedPhase)('changes-shot', () => (0, ready_shots_1.variantChangesShown)({ target: context.target, config: context.config, product, sketch, warm: context.warm }))
         : null;
     const unviewed = Array.isArray(changes)
         ? (0, viewed_shots_1.unviewedShotLinesOf)({
@@ -526,20 +656,47 @@ const loadedAndReady = (context_1, _a) => __awaiter(void 0, [context_1, _a], voi
         : [];
     if (unviewed.length > 0)
         return fail(`${unviewed.join('\n')}\n${sketch.target} draws a pixel diff - view its shot before ready`);
+    if (!(0, fs_1.existsSync)((0, path_1.resolve)(sketch.dir, sketch_1.SKETCH_FILE)))
+        return fail(`${sketch.target} is gone: another run merged or discarded it while this one checked it`);
     const ready = sketch.status === 'ready'
         ? sketch
         : (0, sketch_1.markSketchReady)({ checkout: context.target, sketch, author: (_c = (0, cli_args_1.authorOf)(context.args)) !== null && _c !== void 0 ? _c : undefined });
     if (typeof ready === 'string')
         return fail(ready);
-    return autoMerged({ context, product, sketch: ready, again: sketch.status === 'ready', changes });
+    return (0, phase_timing_1.timedPhase)('auto-merge', () => autoMerged({ context, product, sketch: ready, again: sketch.status === 'ready', changes }));
 });
 const stillReady = (options) => {
+    (0, sketch_1.writeSketchFile)(Object.assign(Object.assign({}, options.sketch), { mergeHold: { reason: options.reason, at: new Date().toISOString() } }));
     if (options.again)
         console.log(`${options.sketch.target} is still ready`);
     return 0;
 };
+const gitIn = (target, ...args) => (0, plain_output_1.spawnPlain)(['git', ...args], { cwd: target });
+const mergeDirsOf = (product) => [product.dir, ...(product.base ? [product.base.dir] : [])];
+const cleanBesideSketch = (options) => {
+    const status = gitIn(options.target, 'status', '--porcelain', '-z', '--untracked-files=all', '--', ...mergeDirsOf(options.product));
+    const root = gitIn(options.target, 'rev-parse', '--show-toplevel');
+    if (status.status !== 0 || root.status !== 0)
+        return false;
+    const top = root.stdout.trim();
+    const sketchDir = (0, fs_1.realpathSync)(options.sketch.dir);
+    return status.stdout
+        .split('\0')
+        .filter((entry) => /^.. /.test(entry))
+        .every((entry) => (0, path_1.resolve)(top, entry.slice(3)).startsWith(`${sketchDir}/`));
+};
+const committedMerge = (options) => {
+    const dirs = mergeDirsOf(options.product);
+    const added = gitIn(options.target, 'add', '--all', '--', ...dirs);
+    const committed = added.status === 0
+        ? gitIn(options.target, 'commit', '-m', `feat(repo): Merge ${options.sketch.target}, no visible change`, '--', ...dirs)
+        : added;
+    if (committed.status !== 0)
+        console.warn(`Could not commit the merge: ${(committed.stderr || committed.stdout).trim()}`);
+    return committed.status === 0;
+};
 const autoMerged = (options) => {
-    var _a, _b;
+    var _a;
     const { context, product, sketch, again, changes } = options;
     if (!again)
         console.log(`${sketch.target} is ready`);
@@ -548,45 +705,87 @@ const autoMerged = (options) => {
         if (shared.length > 0)
             console.log(`variant ${variant}: a shared/ edit reaches ${shared.join(', ')}`);
     }
-    if (changes === null) {
-        console.log('auto-merge skipped: new part, the user merges');
-        return stillReady({ sketch, again });
-    }
-    const noChange = typeof changes === 'string' ? changes : (0, no_visible_change_1.noChangeOf)(changes);
+    const noChange = changes === null ? 'new part, the user merges' : typeof changes === 'string' ? changes : (0, no_visible_change_1.noChangeOf)(changes);
     if (noChange !== true) {
         console.log(`auto-merge skipped: ${noChange}`);
-        return stillReady({ sketch, again });
+        return stillReady({ sketch, again, reason: noChange });
     }
-    const author = (_a = (0, cli_args_1.authorOf)(context.args)) !== null && _a !== void 0 ? _a : undefined;
-    const variant = (_b = sketch.variants.find((candidate) => !(0, sketch_1.rejectionOf)(sketch, candidate))) !== null && _b !== void 0 ? _b : '';
-    const sketchFile = (0, path_1.resolve)(sketch.dir, sketch_1.SKETCH_FILE);
-    const undecided = (0, fs_1.readFileSync)(sketchFile, 'utf8');
-    const decided = (0, sketch_1.decideSketch)({ sketch, decision: { kind: 'pick', variant } });
+    return mergedUnchanged({
+        target: context.target,
+        config: context.config,
+        author: (_a = (0, cli_args_1.authorOf)(context.args)) !== null && _a !== void 0 ? _a : undefined,
+        product,
+        sketch,
+    });
+};
+const mergedUnchanged = (options) => {
+    var _a;
+    const { target, config, author, product, sketch } = options;
+    const variant = (_a = sketch.variants.find((candidate) => !(0, sketch_1.rejectionOf)(sketch, candidate))) !== null && _a !== void 0 ? _a : '';
+    const commit = cleanBesideSketch({ target, product, sketch });
+    const decided = (0, sketch_1.decideSketch)({ sketch, decision: Object.assign({ kind: 'pick', variant }, (0, write_origin_1.originOf)(author !== null && author !== void 0 ? author : '')) });
     if (typeof decided === 'string')
         return fail(decided);
     const written = sharedFilesOf(product);
     const before = written.map((file) => contentOf(file));
     const result = (0, merge_1.mergeSketch)({
-        target: context.target,
-        config: context.config,
+        target,
+        config,
         product,
         sketch: decided,
         author,
         decidedBy: 'auto: no visible change',
     });
     if (!Array.isArray(result)) {
-        (0, fs_1.writeFileSync)(sketchFile, undecided);
+        (0, sketch_1.writeSketchFile)(Object.assign(Object.assign({}, sketch), { mergeHold: Object.assign({ reason: result.reason, at: new Date().toISOString() }, (result.dirty ? { dirty: result.dirty } : {})) }));
         console.warn(`${sketch.target} shows no visible change but did not merge: ${result.reason}`);
         return 0;
     }
     console.log(`No visible change in any state: merged ${sketch.targets.join(', ')} automatically.`);
+    if (commit && committedMerge({ target, product, sketch })) {
+        console.log(`Committed: feat(repo): Merge ${sketch.target}, no visible change`);
+        return 0;
+    }
     commitHunksLines({
-        target: context.target,
+        target,
         files: written.filter((file, index) => contentOf(file) !== before[index]),
         parts: sketch.targets,
     }).forEach((line) => console.log(line));
     return 0;
 };
+const stillDirtyOf = (options) => {
+    const status = gitIn(options.target, 'status', '--porcelain', '--untracked-files=all', '--', ...options.dirty);
+    return status.status !== 0 || status.stdout.trim() !== '';
+};
+/**
+ * Merges every ready sketch whose automatic merge uncommitted files refused, once those files are committed or
+ * reverted; `except` is a sketch target to leave alone.
+ */
+const retriedHeldMerges = (options) => {
+    var _a;
+    const { target, config, author, except } = options;
+    for (const name of Object.keys((_a = config.products) !== null && _a !== void 0 ? _a : {})) {
+        const productDir = (0, product_1.productDirOf)({ target, product: name });
+        const held = (0, sketch_1.listSketches)({ productDir, product: name }).filter((sketch) => {
+            var _a;
+            return typeof sketch !== 'string' &&
+                sketch.status === 'ready' &&
+                !!((_a = sketch.mergeHold) === null || _a === void 0 ? void 0 : _a.dirty) &&
+                sketch.target !== except &&
+                !stillDirtyOf({ target, dirty: sketch.mergeHold.dirty });
+        });
+        if (held.length === 0)
+            continue;
+        const product = (0, cli_args_1.oneProductOf)({ target, config, asked: name });
+        if (typeof product === 'string')
+            continue;
+        for (const sketch of held) {
+            console.log(`${sketch.target}: the uncommitted edits that held its automatic merge are gone - merging it now`);
+            mergedUnchanged({ target, config, author, product, sketch });
+        }
+    }
+};
+exports.retriedHeldMerges = retriedHeldMerges;
 const contentOf = (file) => ((0, fs_1.existsSync)(file) ? (0, fs_1.readFileSync)(file, 'utf8') : null);
 const sharedFilesOf = (product) => [
     (0, path_1.resolve)(product.dir, merged_parts_1.MERGED_FILE),
@@ -630,8 +829,37 @@ const roundNotReadyProblemOf = (sketch) => sketch.status === 'ready' || sketch.h
     ? null
     : `ROUND-NOT-READY ${sketch.target}: round ${(0, sketch_1.runningRoundOf)(sketch).key} is drawn but still in progress - run \`design sketch ready ${sketch.target}\``;
 const unloadedLinesOf = (options) => __awaiter(void 0, void 0, void 0, function* () { return (yield (0, ready_shots_1.variantsThatDoNotLoad)(options)).map((line) => `${options.sketch.target} ${line}`); });
+const undeclaredLinesOf = (options) => __awaiter(void 0, void 0, void 0, function* () {
+    const { sketch } = options;
+    const lines = [];
+    for (const variant of sketch.variants.filter((name) => !(0, sketch_1.rejectionOf)(sketch, name))) {
+        const { changed } = (0, merge_preview_1.mergePreviewOf)({ product: options.product, sketch, variant });
+        const added = yield (0, complete_1.addedUndeclaredControlsOf)(Object.assign(Object.assign({}, options), { sketch: { target: sketch.target, variant }, parts: changed }));
+        if ('unavailable' in added)
+            return added.unavailable;
+        lines.push(...added.lines);
+    }
+    return lines;
+});
+const baseCommitOf = (options) => {
+    var _a;
+    const { context, product, sketch } = options;
+    const dirs = ((_a = (0, stale_base_1.staleBaseOf)({ product, sketch })) !== null && _a !== void 0 ? _a : []).flatMap((key) => {
+        const part = product.parts.find((candidate) => (0, resolve_product_1.partKeyOf)(candidate) === key);
+        return part ? [(0, path_1.dirname)(part.file)] : [];
+    });
+    if (dirs.length === 0)
+        return null;
+    const log = (0, plain_output_1.spawnPlain)(['git', 'log', '-1', '--format=%h', '--', ...dirs], { cwd: context.target });
+    return log.status === 0 && log.stdout.trim() ? log.stdout.trim() : null;
+};
 const readyRefusalOf = (context, { product, sketch }) => {
     const lineOf = (variant, problem) => `${sketch.target} ${variant}: ${problem.rule} ${(0, path_1.relative)(context.target, problem.file)}: ${problem.message}`;
+    const stale = staleBasesOf(context, { product, targets: new Set([sketch.target]) });
+    if (stale.length > 0) {
+        const commit = baseCommitOf({ context, product, sketch });
+        return fail(`${stale.map((problem) => problem.line).join('\n')}\n${sketch.target} is stale${commit ? ` (base changed in ${commit})` : ''} - rebase it before ready`);
+    }
     const found = (0, check_sketches_1.variantProblemsOf)({ product, sketch });
     found.forEach((entry) => noteProblemsBefore(Object.assign({ target: context.target }, entry)));
     const problems = found
@@ -687,19 +915,36 @@ const beforeLinesOf = ({ sketches, before }) => [...new Set(sketches)].flatMap((
     .filter((issue) => sketch.targets.includes(issue.part))
     .map((issue) => (Object.assign(Object.assign({}, issue), { sketch: { target: sketch.target, variant: 'before' } })))));
 exports.beforeLinesOf = beforeLinesOf;
-const renderedVariantsOf = (_a) => __awaiter(void 0, [_a], void 0, function* ({ target, config, product, entries, drawn, }) {
+const unchangedAffectedOf = (options) => (0, warm_draw_1.loadingOn)(options, (server) => __awaiter(void 0, void 0, void 0, function* () {
+    return Object.fromEntries(yield Promise.all(options.affected.map((part) => __awaiter(void 0, void 0, void 0, function* () {
+        return [
+            part,
+            yield (0, unchanged_states_1.unchangedStatesOf)(Object.assign(Object.assign({}, options), { part, load: ({ file, product, sketch }) => server.ssrLoadModule((0, system_modules_1.productModuleIdOf)({ file, product, sketch })) })),
+        ];
+    }))));
+}));
+const renderedVariantsOf = (_a) => __awaiter(void 0, [_a], void 0, function* ({ target, config, product, entries, drawn, warm, }) {
     var _b, _c, _d;
+    const jobs = yield Promise.all(entries.map((_a) => __awaiter(void 0, [_a], void 0, function* ({ sketch, variant }) {
+        const preview = (0, merge_preview_1.mergePreviewOf)({ product, sketch, variant });
+        return {
+            product: product.name,
+            sketch: { target: sketch.target, variant },
+            parts: [...preview.changed, ...preview.affected],
+            unchanged: warm
+                ? yield unchangedAffectedOf({ target, config, warm, product, sketch, variant, affected: preview.affected })
+                : {},
+        };
+    })));
+    for (const { sketch, unchanged } of jobs)
+        for (const [part, states] of Object.entries(unchanged).filter(([, states]) => states.length > 0))
+            console.log(`NOTE ${sketch.target} ${sketch.variant}: ${part} draws ${states.length} state${states.length === 1 ? '' : 's'} as merged, not inspected`);
     const rendered = yield (0, render_check_1.renderIssuesOf)({
         target,
         config,
-        jobs: entries.map(({ sketch, variant }) => {
-            const preview = (0, merge_preview_1.mergePreviewOf)({ product, sketch, variant });
-            return {
-                product: product.name,
-                sketch: { target: sketch.target, variant },
-                parts: [...preview.changed, ...preview.affected],
-            };
-        }),
+        warm,
+        jobs,
+        onProgress: (line) => console.error(line),
         before: [...new Set(entries.flatMap(({ sketch }) => sketch.targets))].map((part) => ({
             product: product.name,
             part,
@@ -726,19 +971,23 @@ const renderedVariantsOf = (_a) => __awaiter(void 0, [_a], void 0, function* ({
         if (drawn)
             rendered.grids.forEach(({ sketch, part, line }) => { var _a, _b; return console.log(`${(_a = sketch === null || sketch === void 0 ? void 0 : sketch.target) !== null && _a !== void 0 ? _a : ''} ${(_b = sketch === null || sketch === void 0 ? void 0 : sketch.variant) !== null && _b !== void 0 ? _b : ''}: ${part} ${line}`); });
         rendered.warnings.forEach((issue) => { var _a, _b, _c, _d; return console.warn(`${(_b = (_a = issue.sketch) === null || _a === void 0 ? void 0 : _a.target) !== null && _b !== void 0 ? _b : ''} ${(_d = (_c = issue.sketch) === null || _c === void 0 ? void 0 : _c.variant) !== null && _d !== void 0 ? _d : ''}: WARNING ${(0, render_check_1.renderIssueLineOf)(issue)}`); });
-        (0, render_check_1.groupedIssueLinesOf)(rendered.issues).forEach((line) => console.error(line));
+        const { noVerdict } = rendered;
+        if (noVerdict)
+            [...new Set(entries.map((entry) => entry.sketch.target))].forEach((sketchTarget) => console.error((0, no_verdict_1.noVerdictLineOf)(sketchTarget, noVerdict)));
+        else
+            (0, render_check_1.groupedIssueLinesOf)(rendered.issues).forEach((line) => console.error(line));
         (0, exports.beforeLinesOf)({ sketches: entries.map((entry) => entry.sketch), before: (_d = rendered.before) !== null && _d !== void 0 ? _d : [] }).forEach((line) => console.log(line));
     }
     return rendered;
 });
 const checked = (context) => __awaiter(void 0, void 0, void 0, function* () {
-    var _a, _b, _c;
+    var _a, _b;
     const { target, config, args } = context;
     const product = sketchProductOf(context);
     if (typeof product === 'string')
         return fail(product);
     const asked = args.positional[0];
-    const { unreadable, variants } = (0, check_sketches_1.openSketchProblemsOf)(product);
+    const { unreadable, variants } = (0, phase_timing_1.timedPhase)('gates', () => (0, check_sketches_1.openSketchProblemsOf)(product));
     const named = asked === undefined ? variants : variants.filter((entry) => entry.sketch.target === asked);
     if (asked !== undefined && named.length === 0)
         return fail(`NO SKETCH on ${asked} in ${product.name}`);
@@ -756,18 +1005,17 @@ const checked = (context) => __awaiter(void 0, void 0, void 0, function* () {
     if (asked === undefined)
         unreadable.forEach((problem) => console.error(`${problem.rule} ${(0, path_1.relative)(target, problem.file)}: ${problem.message}`));
     new Set(chosen.map((entry) => entry.sketch)).forEach((sketch) => {
+        reportedReopen(sketch);
+        if (product.config.noteLanguage)
+            (0, note_language_1.noteLanguageWarningsOf)(sketch, product.config.noteLanguage).forEach((warning) => console.warn(warning));
         if (sketch.hold)
             console.warn(`HELD ${sketch.target}: until ${sketch.hold.until}`);
     });
-    const stale = (0, check_system_1.staleSketchBasesOf)({
-        product,
-        invocation: (_a = context.invocation) !== null && _a !== void 0 ? _a : (0, invocation_1.repoInvocation)({ root: target, subcommand: 'design' }),
-        targets: new Set(chosen.map((entry) => entry.sketch.target)),
-    });
+    const stale = staleBasesOf(context, { product, targets: new Set(chosen.map((entry) => entry.sketch.target)) });
     stale.forEach((problem) => console.error(problem.line));
     failed || (failed = stale.length > 0);
     for (const { sketch, variant, problems, before } of chosen) {
-        const typed = (0, check_sketches_1.typecheckVariant)({ target, product, sketch, variant });
+        const typed = (0, phase_timing_1.timedPhase)(`tsc ${variant}`, () => (0, check_sketches_1.typecheckVariant)({ target, product, sketch, variant }));
         noteProblemsBefore({ target, sketch, variant, before });
         (0, check_sketches_1.variantWarningsOf)({ target, product, sketch, variant }).forEach((warning) => console.warn(`${sketch.target} ${variant}: ${warning}`));
         const all = [
@@ -782,17 +1030,18 @@ const checked = (context) => __awaiter(void 0, void 0, void 0, function* () {
     }
     if (!failed)
         for (const sketch of new Set(chosen.map((entry) => entry.sketch)))
-            (yield (0, ready_shots_1.aktuellPlaceholderWarnings)({ target, config, product, sketch })).forEach((warning) => console.warn(warning));
+            (yield (0, phase_timing_1.timedPhase)('aktuell', () => (0, ready_shots_1.aktuellPlaceholderWarnings)({ target, config, product, sketch, warm: context.warm }))).forEach((warning) => console.warn(warning));
     const rendered = failed
         ? null
-        : yield renderedVariantsOf({
+        : yield (0, phase_timing_1.timedPhase)('render-check', () => renderedVariantsOf({
             target,
             config,
             product,
             entries: chosen,
             drawn: true,
-        });
-    const busy = rendered !== null && 'issues' in rendered ? ((_b = rendered.busy) !== null && _b !== void 0 ? _b : []) : [];
+            warm: context.warm,
+        }));
+    const busy = rendered !== null && 'issues' in rendered ? ((_a = rendered.busy) !== null && _a !== void 0 ? _a : []) : [];
     if (rendered !== null && 'issues' in rendered)
         (0, frame_budget_1.frameBudgetWarningsOf)({
             drawn: rendered.drawn,
@@ -811,16 +1060,16 @@ const checked = (context) => __awaiter(void 0, void 0, void 0, function* () {
         refused += lines.length;
     };
     for (const sketch of new Set(chosen.map((entry) => entry.sketch))) {
-        const unloaded = yield unloadedLinesOf({ target, config, product, sketch });
+        const unloaded = yield (0, phase_timing_1.timedPhase)('load', () => unloadedLinesOf({ target, config, product, sketch, warm: context.warm }));
         const before = refused;
         refuse([
             ...unloaded,
             ...openPointLinesOf({ product, sketch, busy }).added,
-            ...[(_c = roundNoteRefusalOf(sketch)) !== null && _c !== void 0 ? _c : []].flat(),
+            ...[(_b = roundNoteRefusalOf(sketch)) !== null && _b !== void 0 ? _b : []].flat(),
         ]);
         if (!failed && unloaded.length === 0) {
-            refuse(yield (0, ready_shots_1.sampleMarkDriftLines)({ target, config, product, sketch }));
-            refuse(yield (0, ready_shots_1.identicalRenderLines)({ target, config, product, sketch }));
+            refuse(yield (0, phase_timing_1.timedPhase)('mark-drift', () => (0, ready_shots_1.sampleMarkDriftLines)({ target, config, product, sketch, warm: context.warm })));
+            refuse(yield (0, phase_timing_1.timedPhase)('identical', () => (0, ready_shots_1.identicalRenderLines)({ target, config, product, sketch, warm: context.warm })));
         }
         if (!failed && refused === before) {
             const problem = roundNotReadyProblemOf(sketch);
@@ -830,9 +1079,13 @@ const checked = (context) => __awaiter(void 0, void 0, void 0, function* () {
             }
         }
     }
-    if (failed)
+    const staleSince = rendered === null
+        ? []
+        : staleBasesOf(context, { product, targets: new Set(chosen.map((entry) => entry.sketch.target)) }).filter((problem) => !stale.some((before) => before.line === problem.line));
+    staleSince.forEach((problem) => console.error(problem.line));
+    if (failed || staleSince.length > 0)
         return 1;
-    if (rendered !== null && 'issues' in rendered && rendered.issues.length > 0)
+    if (rendered !== null && 'issues' in rendered && (rendered.noVerdict || rendered.issues.length > 0))
         return 1;
     if (notReady)
         return 1;
@@ -857,7 +1110,7 @@ const previewed = (context) => withSketch(context, ({ product, sketch }) => {
 });
 const merged = (context) => withSketch(context, ({ product, sketch }) => {
     var _a, _b;
-    const { '--note': note, '--variant': flagVariant, '--allowed-by': planRef } = context.args.values;
+    const { '--note': note, '--variant': flagVariant, '--allowed-by': planRef, '--decided-by': decidedBy, } = context.args.values;
     const replaceNote = context.args.flags.has('--replace-note');
     if (context.args.positional.length > 1)
         return fail(`usage: sketch merge <layer>/<name> [--note <reason>] - it merges the variant the user picked`);
@@ -865,11 +1118,13 @@ const merged = (context) => withSketch(context, ({ product, sketch }) => {
         return fail('--replace-note needs --note <the new part note>');
     if ((flagVariant === undefined) !== (planRef === undefined))
         return fail('--variant and --allowed-by go together: name the only live variant and the plan that allows the merge');
+    if (decidedBy !== undefined && (decidedBy.trim() === '' || planRef !== undefined))
+        return fail('--decided-by needs a name and does not go with --allowed-by, which records the plan');
     const by = (_a = (0, cli_args_1.authorOf)(context.args)) !== null && _a !== void 0 ? _a : undefined;
     const allowed = flagVariant !== undefined && planRef !== undefined && ((_b = sketch.decision) === null || _b === void 0 ? void 0 : _b.kind) !== 'pick'
-        ? { variant: flagVariant, planRef }
+        ? { variant: flagVariant, planRef, editRef: (0, merge_step_1.editRefOf)({ target: context.target, sketch, planRef }) }
         : undefined;
-    const result = (0, merge_step_1.mergeAndRecord)({
+    const result = (0, phase_timing_1.timedPhase)('merge', () => (0, merge_step_1.mergeAndRecord)({
         target: context.target,
         config: context.config,
         product,
@@ -877,8 +1132,9 @@ const merged = (context) => withSketch(context, ({ product, sketch }) => {
         note,
         replaceNote,
         by,
+        decidedBy: decidedBy === null || decidedBy === void 0 ? void 0 : decidedBy.trim(),
         allowed,
-    });
+    }));
     if (typeof result === 'string')
         return fail(result);
     console.log(`merged ${sketch.target} variant ${result.variant} into ${product.name}: ${result.parts.join(', ')}`);
@@ -957,7 +1213,13 @@ const withdrawnVariant = (context_1, _a) => __awaiter(void 0, [context_1, _a], v
         return fail(`${sketch.target} has no variant "${variant}" - it has ${sketch.variants.join(', ')}`);
     if (!(0, sketch_1.authorsOf)(sketch, variant).includes(by))
         return fail(`${sketch.target} variant ${variant} was not drawn by ${by} - only the agent that drew it withdraws it`);
-    const identical = yield (0, ready_shots_1.identicalRenders)({ target: context.target, config: context.config, product, sketch });
+    const identical = yield (0, ready_shots_1.identicalRenders)({
+        target: context.target,
+        config: context.config,
+        product,
+        sketch,
+        warm: context.warm,
+    });
     const twin = identical.find((render) => render.variant === variant && render.sibling !== null);
     if (!twin)
         return fail(`${sketch.target} variant ${variant} does not draw the same pixels as a sibling variant in its first changed state - redraw it or ask for a reject`);
@@ -972,6 +1234,7 @@ const COMMANDS = {
     variant: varied,
     round: roundEdited,
     note: noteEdited,
+    covers: coversEdited,
     list: listed,
     report: reported,
     ready: readied,
@@ -1003,7 +1266,8 @@ const flagsOf = (command) => {
  * discards sketches, and rejects, reopens and withdraws their variants.
  */
 const designSketch = (options) => {
-    const { target, argv, invocation } = options;
+    var _a, _b;
+    const { target, argv, invocation, warm } = options;
     const [command = '', ...rest] = argv;
     const run = COMMANDS[command];
     const args = (0, cli_args_1.argsOf)(rest, flagsOf(command));
@@ -1021,7 +1285,16 @@ const designSketch = (options) => {
     const config = (0, cli_args_1.configOf)(target);
     if (typeof config === 'string')
         return fail(config);
-    return run({ target, config, args, invocation });
+    if (RETRIES.has(command)) {
+        const named = (0, sketch_1.parseTarget)((_a = args.positional[0]) !== null && _a !== void 0 ? _a : '');
+        (0, exports.retriedHeldMerges)({
+            target,
+            config,
+            author: (_b = (0, cli_args_1.authorOf)(args)) !== null && _b !== void 0 ? _b : undefined,
+            except: typeof named === 'string' ? undefined : (0, resolve_product_1.partKeyOf)(named),
+        });
+    }
+    return run({ target, config, args, invocation, warm });
 };
 exports.designSketch = designSketch;
 //# sourceMappingURL=sketch-command.js.map