@etherisc/gif-next 0.0.2-a6f9f86-582 → 0.0.2-a6faeb6-912

package/contracts/registry/Registry.sol

@@ -2,13 +2,12 @@
 pragma solidity ^0.8.20;
 
 import {IRegisterable} from "../shared/IRegisterable.sol";
-import {IService} from "../instance/base/IService.sol";
+import {IService} from "../shared/IService.sol";
 
-import {IChainNft} from "./IChainNft.sol";
 import {ChainNft} from "./ChainNft.sol";
 import {IRegistry} from "./IRegistry.sol";
 import {NftId, toNftId, zeroNftId, NftIdLib} from "../types/NftId.sol";
-import {Version, VersionPart, VersionLib} from "../types/Version.sol";
+import {Version, VersionPart, VersionLib, VersionPartLib} from "../types/Version.sol";
 import {ObjectType, PROTOCOL, REGISTRY, TOKEN, SERVICE, INSTANCE, STAKE, PRODUCT, DISTRIBUTION, ORACLE, POOL, POLICY, BUNDLE} from "../types/ObjectType.sol";
 import {ITransferInterceptor} from "./ITransferInterceptor.sol";
 
@@ -29,63 +28,40 @@ contract Registry is
     ERC165,
     IRegistry
 {
-    // register
-    error NotRegistryService();
-    error ZeroParentAddress();
-    error ContractAlreadyRegistered(address objectAddress);
-    error InvalidServiceVersion(VersionPart majorVersion);
-    error ServiceNameAlreadyRegistered(string name, VersionPart majorVersion);
-            
-    // approve
-    error NotOwner();
-    error NotRegisteredContract(NftId registrarNftId);
-    error NotService(NftId registrarNftId);
-    error InvalidTypesCombination(ObjectType objectType, ObjectType parentType);
-
-    uint256 public constant MAJOR_VERSION_MIN = 3;
+    uint256 public constant GIF_MAJOR_VERSION_AT_DEPLOYMENT = 3;
     address public constant NFT_LOCK_ADDRESS = address(0x1);
+    uint256 public constant REGISTRY_TOKEN_SEQUENCE_ID = 2;
     uint256 public constant REGISTRY_SERVICE_TOKEN_SEQUENCE_ID = 3;
     string public constant EMPTY_URI = "";
 
-    mapping(NftId nftId => ObjectInfo info) _info;
-    mapping(address object => NftId nftId) _nftIdByAddress;
+    VersionPart internal _majorVersion;
 
-    mapping(NftId registrator => mapping(
-            ObjectType objectType => bool)) _isApproved;
+    mapping(NftId nftId => ObjectInfo info) internal _info;
+    mapping(address object => NftId nftId) internal _nftIdByAddress;
 
     mapping(ObjectType objectType => mapping(
-            ObjectType parentType => bool)) _isValidContractCombination;
+            ObjectType parentType => bool)) internal _isValidContractCombination;
 
     mapping(ObjectType objectType => mapping(
-            ObjectType parentType => bool)) _isValidObjectCombination;
+            ObjectType parentType => bool)) internal _isValidObjectCombination;
 
-    mapping(NftId nftId => string name) _string;
+    mapping(NftId nftId => string name) internal _string;
     mapping(bytes32 serviceNameHash => mapping(
-            VersionPart majorVersion => address service)) _service;
-
-    NftId _registryNftId;
-    NftId _serviceNftId; // set in stone upon registry creation
-    IChainNft _chainNft;
-    ChainNft _chainNftInternal;
-
-    /*
-    modifier onlyInitialOwner() {
-        if(
-            msg.sender != getOwner() ||
-            msg.sender != _info[_registryNftId].initialOwner) {
-            revert NotInitialOwner();
-        }
-    }*/
+            VersionPart majorVersion => address service)) internal _service;
+
+    NftId internal _registryNftId;
+    NftId internal _serviceNftId; // set in stone upon registry creation
+    ChainNft internal _chainNft;
+
 
     modifier onlyOwner() {
         if(msg.sender != getOwner()) {
-            revert NotOwner();
+            revert NotOwner(msg.sender);
         }
         _;
     }
 
     modifier onlyRegistryService() {
-        
         if(msg.sender != _info[_serviceNftId].objectAddress) {
             revert NotRegistryService();
         }
@@ -95,11 +71,13 @@ contract Registry is
     constructor(address registryOwner, VersionPart majorVersion)
     {
         require(registryOwner > address(0), "Registry: registry owner is 0");
-        require(majorVersion.toInt() == MAJOR_VERSION_MIN, "Registry: initial major version of registry service is not MAJOR_VERSION_MIN");
+
+        // major version at constructor time
+        _majorVersion = VersionLib.toVersionPart(GIF_MAJOR_VERSION_AT_DEPLOYMENT);
+        emit LogInitialMajorVersionSet(_majorVersion);
 
         // deploy NFT 
-        _chainNftInternal = new ChainNft(address(this));// adds 10kb to deployment size
-        _chainNft = IChainNft(_chainNftInternal);
+        _chainNft = new ChainNft(address(this));// adds 10kb to deployment size
 
         // initial registry setup
         _registerProtocol();
@@ -112,9 +90,25 @@ contract Registry is
         _registerInterface(type(IRegistry).interfaceId);
     }
 
+    // from IRegistry
+
+    /// @dev latest GIF release version 
+    function setMajorVersion(VersionPart newMajorVersion)
+        external
+        onlyOwner
+    {
+        // ensure major version increments is one
+        uint256 oldMax = _majorVersion.toInt();
+        uint256 newMax = newMajorVersion.toInt();
+        if (newMax <= oldMax || newMax - oldMax != 1) {
+            revert MajorVersionMaxIncreaseInvalid(newMajorVersion, _majorVersion);
+        }
+
+        _majorVersion = newMajorVersion;
+        emit LogMajorVersionSet(_majorVersion);
+    }
+
     /// @dev registry protects only against tampering existing records, registering with invalid types pairs and 0 parent address
-    // IMPORTANT: rare case when parentNftId is not registered and == next nftId -> technincally this is ZeroParentAddress error
-    // to catch this check parent address before minting !!!!
     // TODO service registration means its approval for some type?
     // TODO registration of precompile addresses
     function register(ObjectInfo memory info)
@@ -139,8 +133,6 @@ contract Registry is
         address interceptor = _getInterceptor(info.isInterceptor, info.objectAddress, parentInfo.isInterceptor, parentAddress);
 
         // TODO does external call
-        // check for receiver in registry service?
-        // use unsafe transfer?
         uint256 mintedTokenId = _chainNft.mint(
             info.initialOwner,
             interceptor,
@@ -170,33 +162,8 @@ contract Registry is
             _nftIdByAddress[contractAddress] = nftId;
 
             // special case
-            if(objectType == SERVICE())
-            {
-                (
-                    string memory serviceName,
-                    VersionPart majorVersion
-                ) = abi.decode(info.data, (string, VersionPart));
-                bytes32 serviceNameHash = keccak256(abi.encode(serviceName));
-
-                // TODO MUST guarantee consistency of service.getVersion() and majorVersion here
-                // TODO update _serviceNftId when registryService with new major version is registered? -> it is fixed in current setup
-                // TODO do not use names -> each object type is registered by corresponding service -> conflicting with approve()
-                if(
-                    majorVersion.toInt() < MAJOR_VERSION_MIN ||
-                    (majorVersion.toInt() > MAJOR_VERSION_MIN &&
-                    _service[serviceNameHash][VersionLib.toVersionPart(majorVersion.toInt() - 1)] == address(0) )
-                ) {
-                    revert InvalidServiceVersion(majorVersion);
-                }
-                
-                if(_service[serviceNameHash][majorVersion] != address(0)) {
-                    revert ServiceNameAlreadyRegistered(serviceName, majorVersion);
-                }
-
-                _string[nftId] = serviceName;
-                _service[serviceNameHash][majorVersion] = contractAddress;
-
-                emit LogServiceNameRegistration(serviceName, majorVersion); 
+            if(objectType == SERVICE()) {
+                _registerService(info);
             }
         }
         else
@@ -206,75 +173,37 @@ contract Registry is
             }
         }
 
-        emit LogRegistration(nftId, info.parentNftId, info.objectType, info.isInterceptor, info.objectAddress, info.initialOwner);
+        emit LogRegistration(info);
     }
-
-    function registerFrom(
-        address from, 
-        ObjectInfo memory info
-    ) external returns (NftId nftId) 
-    {
-        revert();
+    /// @dev earliest GIF major version 
+    function getMajorVersionMin() external view returns (VersionPart) {
+        return VersionLib.toVersionPart(GIF_MAJOR_VERSION_AT_DEPLOYMENT);
     }
-    
-
-    /// @dev 
-    // msg.sender - registry owner 
-    //     CAN approve only registered service contract
-    //     CAN approve any combination specified in _isValidCombination
-    //     CAN NOT approve itself
-    // TODO in case where exists exactly one registered service per objectType (and major version):
-    // - registration and approve is a single operation, no need for separate approve() function
-    // - then approve can be used to adding new valid object-parent combinations???
-    function approve(
-        NftId serviceNftId,
-        ObjectType objectType,
-        ObjectType parentType 
-    ) 
-        public
-        onlyOwner()
-    {
-        address serviceAddress = _info[serviceNftId].objectAddress;
-            
-        if(_nftIdByAddress[serviceAddress].eqz()) {
-            revert NotRegisteredContract(serviceNftId);
-        }
-
-        if(_info[serviceNftId].objectType != SERVICE()) {
-            revert NotService(serviceNftId);
-        }
-
-        if(
-            _isValidContractCombination[objectType][parentType] == false &&
-            _isValidObjectCombination[objectType][parentType] == false) {
-            revert InvalidTypesCombination(objectType, parentType);
-        }
 
-        _isApproved[serviceNftId][objectType] = true;
-
-        emit LogApproval(serviceNftId, objectType);
+    // TODO make distinction between active an not yet active version
+    // need to be thought trough, not yet clear if necessary
+    // need to answer question: what is the latest version during the upgrade process?
+    // likely setting up a new gif version does not fit into a single tx
+    // in this case we might want to have a period where the latest version is
+    // in the process of being set up while the latest active version is 1 major release smaller
+    /// @dev latest GIF major version (might not yet be active)
+    function getMajorVersionMax() external view returns (VersionPart) {
+        return _majorVersion;
     }
 
-    /// @dev returns false for registry owner nft
-    // TODO allowance by address?
-    // TODO checked by registry service -> but registry owner can upgrade registry service not to check allowance....
-    function allowance(
-        NftId nftId,
-        ObjectType object
-    ) 
-        public
-        view 
-        returns (bool)
-    {
-        return _isApproved[nftId][object];
+    /// @dev latest active GIF release version 
+    function getMajorVersion() external view returns (VersionPart) { 
+        return _majorVersion;
     }
 
-    // from IRegistry
     function getObjectCount() external view override returns (uint256) {
-        
         return _chainNft.totalSupply();
     }
 
+    function getNftId() external view returns (NftId nftId) {
+        return _registryNftId;
+    }
+
     function getNftId(address object) external view override returns (NftId id) {
         return _nftIdByAddress[object];
     }
@@ -284,7 +213,6 @@ contract Registry is
     }
 
     function ownerOf(address contractAddress) public view returns (address) {
-        
         return _chainNft.ownerOf(_nftIdByAddress[contractAddress].toInt());
     }
 
@@ -293,7 +221,6 @@ contract Registry is
     }
 
     function getObjectInfo(address object) external view override returns (ObjectInfo memory) {
-        
         return _info[_nftIdByAddress[object]];
     }
 
@@ -305,6 +232,10 @@ contract Registry is
         return _nftIdByAddress[object].gtz();
     }
 
+    function isRegisteredService(address object) external view override returns (bool) {
+        return _nftIdByAddress[object].gtz() && _info[_nftIdByAddress[object]].objectType == SERVICE();
+    }
+
     function getServiceName(NftId nftId) external view returns (string memory) {
         return _string[nftId];
     }
@@ -319,7 +250,7 @@ contract Registry is
         return _service[serviceNameHash][majorVersion];
     }
 
-    function getChainNft() external view override returns (IChainNft) {
+    function getChainNft() external view override returns (ChainNft) {
         return _chainNft;
     }
 
@@ -327,16 +258,68 @@ contract Registry is
         return ownerOf(address(this));
     }
 
-    // Internals, called only in constructor
+    // Internals
+
+    function _registerService(ObjectInfo memory info)
+        internal
+    {
+        (
+            string memory serviceName,
+            VersionPart majorVersion
+        ) = abi.decode(info.data, (string, VersionPart));
+        bytes32 serviceNameHash = keccak256(abi.encode(serviceName));
+
+        // ensures consistency of service.getVersion() and majorVersion here
+        if(majorVersion != _majorVersion) {
+            revert InvalidServiceVersion(majorVersion);
+        }
+        
+        if(_service[serviceNameHash][majorVersion] != address(0)) {
+            revert ServiceNameAlreadyRegistered(serviceName, majorVersion);
+        }
+
+        _string[info.nftId] = serviceName;
+        _service[serviceNameHash][majorVersion] = info.objectAddress;
+
+        emit LogServiceNameRegistration(serviceName, majorVersion); 
+    }
+
+    /// @dev obtain interceptor address for this nft if applicable, address(0) otherwise
+    function _getInterceptor(
+        bool isInterceptor, 
+        address objectAddress,
+        bool parentIsInterceptor,
+        address parentObjectAddress
+    )
+        internal 
+        view 
+        returns (address interceptor) 
+    {
+        if (objectAddress == address(0)) {
+            if (parentIsInterceptor) {
+                return parentObjectAddress;
+            } else {
+                return address(0);
+            }
+        }
+
+        if (isInterceptor) {
+            return objectAddress;
+        }
+
+        return address(0);
+    }
+
+    // Internals called only in constructor
 
     /// @dev protocol registration used to anchor the dip ecosystem relations
     function _registerProtocol() 
         internal
     {
-        uint256 protocolId = _chainNftInternal.PROTOCOL_NFT_ID();
+        uint256 protocolId = _chainNft.PROTOCOL_NFT_ID();
         NftId protocolNftId = toNftId(protocolId);
 
-        _chainNftInternal.mint(NFT_LOCK_ADDRESS, protocolId);
+        _chainNft.mint(NFT_LOCK_ADDRESS, protocolId);
 
         _info[protocolNftId] = ObjectInfo(
             protocolNftId,
@@ -354,22 +337,22 @@ contract Registry is
     function _registerRegistry(address registryOwner) 
         internal
     {
-        uint256 registryId = _chainNftInternal.calculateTokenId(2);
+        uint256 registryId = _chainNft.calculateTokenId(REGISTRY_TOKEN_SEQUENCE_ID);
         NftId registryNftId = toNftId(registryId);
 
         NftId parentNftId;
 
-        if(registryId != _chainNftInternal.GLOBAL_REGISTRY_ID()) 
+        if(registryId != _chainNft.GLOBAL_REGISTRY_ID()) 
         {// we're not the global registry
             _registerGlobalRegistry();
-            parentNftId = toNftId(_chainNftInternal.GLOBAL_REGISTRY_ID());
+            parentNftId = toNftId(_chainNft.GLOBAL_REGISTRY_ID());
         }
         else 
         {// we are global registry
-            parentNftId = toNftId(_chainNftInternal.PROTOCOL_NFT_ID());
+            parentNftId = toNftId(_chainNft.PROTOCOL_NFT_ID());
         }
 
-        _chainNftInternal.mint(registryOwner, registryId);
+        _chainNft.mint(registryOwner, registryId);
 
         _info[registryNftId] = ObjectInfo(
             registryNftId,
@@ -389,15 +372,15 @@ contract Registry is
     function _registerGlobalRegistry() 
         internal
     {
-        uint256 globalRegistryId = _chainNftInternal.GLOBAL_REGISTRY_ID();
+        uint256 globalRegistryId = _chainNft.GLOBAL_REGISTRY_ID();
 
-        _chainNftInternal.mint(NFT_LOCK_ADDRESS, globalRegistryId);
+        _chainNft.mint(NFT_LOCK_ADDRESS, globalRegistryId);
 
         NftId globalRegistryNftId = toNftId(globalRegistryId);
 
         _info[globalRegistryNftId] = ObjectInfo(
             globalRegistryNftId,
-            toNftId(_chainNftInternal.PROTOCOL_NFT_ID()), // parent
+            toNftId(_chainNft.PROTOCOL_NFT_ID()), // parent
             REGISTRY(),
             false, // isInterceptor
             address(0), // objectAddress
@@ -409,10 +392,10 @@ contract Registry is
     function _registerRegistryService(address registryOwner)
         internal
     {
-        uint256 serviceId = _chainNftInternal.calculateTokenId(REGISTRY_SERVICE_TOKEN_SEQUENCE_ID);
+        uint256 serviceId = _chainNft.calculateTokenId(REGISTRY_SERVICE_TOKEN_SEQUENCE_ID);
         NftId serviceNftId = toNftId(serviceId);        
 
-        _chainNftInternal.mint(registryOwner, serviceId);
+        _chainNft.mint(registryOwner, serviceId);
 
         _info[serviceNftId] = ObjectInfo(
             serviceNftId,
@@ -428,37 +411,11 @@ contract Registry is
 
         string memory serviceName = "RegistryService";
         bytes32 serviceNameHash = keccak256(abi.encode(serviceName));
-        _service[serviceNameHash][VersionLib.toVersionPart(MAJOR_VERSION_MIN)] = msg.sender;
+        _service[serviceNameHash][VersionLib.toVersionPart(GIF_MAJOR_VERSION_AT_DEPLOYMENT)] = msg.sender;
         _string[serviceNftId] = serviceName;
         _serviceNftId = serviceNftId;
     }
 
-    /// @dev obtain interceptor address for this nft if applicable, address(0) otherwise
-    function _getInterceptor(
-        bool isInterceptor, 
-        address objectAddress,
-        bool parentIsInterceptor,
-        address parentObjectAddress
-    )
-        internal 
-        view 
-        returns (address interceptor) 
-    {
-        if (objectAddress == address(0)) {
-            if (parentIsInterceptor) {
-                return parentObjectAddress;
-            } else {
-                return address(0);
-            }
-        }
-
-        if (isInterceptor) {
-            return objectAddress;
-        }
-
-        return address(0);
-    }
-
     /// @dev defines which object - parent types relations are allowed to register
     // IMPORTANT: 
     // 1) EACH object type MUST have only one parent type across ALL mappings