@elliemae/pui-cli 9.0.0-alpha.4 → 9.0.0-alpha.6

package/lib/lint-config/eslint/flat/common.mjs

@@ -1,7 +1,6 @@
 import eslint from '@eslint/js';
 import { defineConfig } from 'eslint/config';
 import eslintConfigPrettier from 'eslint-config-prettier';
-import eslintComments from 'eslint-plugin-eslint-comments';
 import importX from 'eslint-plugin-import-x';
 import jest from 'eslint-plugin-jest';
 import testingLibrary from 'eslint-plugin-testing-library';
@@ -51,7 +50,6 @@ export function createBaseFlatConfigs(tsRules) {
     eslintConfigPrettier,
     {
       plugins: {
-        'eslint-comments': eslintComments,
         'import-x': importX,
       },
       languageOptions: {

package/lib/lint-config/eslint/flat/compat.mjs

@@ -0,0 +1,20 @@
+/**
+ * ESLint 10 removed deprecated context APIs (e.g. getSourceCode).
+ * Wrap legacy plugins until their maintainers publish compatible releases.
+ */
+import { fixupConfigRules, fixupPluginRules } from '@eslint/compat';
+import reduxSaga from 'eslint-plugin-redux-saga';
+import storybook from 'eslint-plugin-storybook';
+
+const storybookFlat =
+  storybook.configs['flat/recommended'] ??
+  storybook.configs.recommended ??
+  [];
+
+/** @type {import('eslint').ESLint.Plugin} */
+export const reduxSagaPlugin = fixupPluginRules(reduxSaga);
+
+/** Storybook flat presets with ESLint 10 compatibility shims applied. */
+export const storybookFlatConfigs = fixupConfigRules(
+  Array.isArray(storybookFlat) ? storybookFlat : [storybookFlat],
+);

package/lib/lint-config/eslint/flat/presets.mjs

@@ -1,16 +1,15 @@
 /**
  * Preset rule bundles and file globs computed once at module load (not per config factory call).
  */
-import eslintComments from 'eslint-plugin-eslint-comments';
 import importX from 'eslint-plugin-import-x';
 import jest from 'eslint-plugin-jest';
 import jsxA11y from 'eslint-plugin-jsx-a11y';
 import react from 'eslint-plugin-react';
 import reactHooks from 'eslint-plugin-react-hooks';
 import reduxSaga from 'eslint-plugin-redux-saga';
-import storybook from 'eslint-plugin-storybook';
 import testingLibrary from 'eslint-plugin-testing-library';
 import wdio from 'eslint-plugin-wdio';
+import { storybookFlatConfigs } from './compat.mjs';
 
 /** Application and integration tests (Jest + relaxed type-checked rules). */
 export const testFiles = [
@@ -50,7 +49,6 @@ export const storybookFiles = [
 
 /** @type {import('eslint').Linter.RulesRecord} */
 export const sharedCoreRules = {
-  ...eslintComments.configs.recommended.rules,
   ...importX.configs.recommended.rules,
   'import-x/named': 'off',
 };
@@ -83,12 +81,4 @@ export const wdioRecommendedRules = wdio.configs.recommended.rules ?? {};
 /** @type {Record<string, boolean>} */
 export const wdioGlobals = wdio.configs.recommended.globals ?? {};
 
-const storybookFlat =
-  storybook.configs['flat/recommended'] ??
-  storybook.configs.recommended ??
-  [];
-
-/** Normalized once — Storybook flat config may be array or single object. */
-export const storybookFlatConfigs = Array.isArray(storybookFlat)
-  ? storybookFlat
-  : [storybookFlat];
+export { storybookFlatConfigs };

package/lib/lint-config/eslint/flat/react.mjs

@@ -2,8 +2,8 @@ import { defineConfig } from 'eslint/config';
 import jsxA11y from 'eslint-plugin-jsx-a11y';
 import react from 'eslint-plugin-react';
 import reactHooks from 'eslint-plugin-react-hooks';
-import reduxSaga from 'eslint-plugin-redux-saga';
 import { baseFlatConfigs, baseFlatConfigsStrict } from './common.mjs';
+import { reduxSagaPlugin } from './compat.mjs';
 import {
   reactPresetRules,
   storybookFiles,
@@ -16,7 +16,7 @@ const reactPluginBlock = {
     react,
     'react-hooks': reactHooks,
     'jsx-a11y': jsxA11y,
-    'redux-saga': reduxSaga,
+    'redux-saga': reduxSagaPlugin,
   },
   settings: {
     react: { version: 'detect' },

package/lib/lint-config/eslint/flat/rules.mjs

@@ -38,7 +38,6 @@ export const baseRules = {
   'no-param-reassign': ['error', { props: false }],
   'prefer-template': 'error',
   'require-yield': 'off',
-  'eslint-comments/disable-enable-pair': 'off',
 };
 
 /** Relaxed type-checked rules for test files (shared by default and strict configs). */

package/lib/skills/migrate-to-pui-cli-9/SKILL.md

@@ -0,0 +1,140 @@
+---
+name: migrate-to-pui-cli-9
+description: >-
+  Migrate a PUI app or library to pui-cli 9 (Node 24, pnpm 11, ESLint 9 flat config).
+  Use when upgrading @elliemae/pui-cli, migrating from .eslintrc.cjs to eslint.config.mjs,
+  fixing ESLint 9 lint failures, or adopting the shared flat config from pui-cli.
+---
+
+# Migrate to pui-cli 9
+
+Upgrades a PUI repo from pui-cli 8 (ESLint 8 + `.eslintrc.cjs`) to pui-cli 9
+(ESLint 9 + `eslint.config.mjs` + Node 24 + pnpm 11).
+
+## Pre-flight: Toolchain
+
+| Requirement         | Version                           |
+| ------------------- | --------------------------------- |
+| Node.js             | **24** (see repo `.node-version`) |
+| pnpm                | **11**                            |
+| `@elliemae/pui-cli` | **9.x** (alpha/beta until GA)     |
+
+```bash
+fnm use 24   # or nvm/volta equivalent
+corepack enable
+pnpm install
+```
+
+## Migration steps (phased PRs recommended)
+
+### Phase 1 — Toolchain only
+
+1. Update `.node-version` to `24` if needed.
+2. Ensure CI Jenkins/docker images use Node 24.
+3. Upgrade pnpm to 11 (`packageManager` field in root `package.json`).
+4. Run `pnpm install`, `pnpm test`, `pnpm run build` — fix any Node/pnpm breakages only.
+
+### Phase 2 — Bump pui-cli
+
+```bash
+pnpm add -D @elliemae/pui-cli@9
+```
+
+Re-run install and smoke-test build/test without ESLint changes yet if the bump is large.
+
+### Phase 3 — ESLint 9 flat config
+
+**React apps and libraries:**
+
+```js
+// eslint.config.mjs
+import { eslintFlatConfig } from '@elliemae/pui-cli/eslint';
+
+export default eslintFlatConfig;
+```
+
+**Node / TS services (non-React):**
+
+```js
+// eslint.config.mjs
+import { eslintFlatBaseConfig } from '@elliemae/pui-cli/eslint';
+
+export default eslintFlatBaseConfig;
+```
+
+Then:
+
+1. Delete `.eslintrc.cjs` and `.eslintignore` (ignores are in the shared config).
+2. Run `pnpm exec pui-cli lint --fix`.
+3. Run `pnpm exec pui-cli lint` until **zero errors** (warnings may remain).
+
+**Strict mode** (only after default config is clean):
+
+```js
+import { eslintFlatConfigStrict } from '@elliemae/pui-cli/eslint';
+export default eslintFlatConfigStrict;
+```
+
+### Phase 4 — Repo-specific overrides (if needed)
+
+Add overrides **after** importing the shared config only when lint debt blocks the migration:
+
+```js
+import { eslintFlatConfig } from '@elliemae/pui-cli/eslint';
+
+export default [
+  ...eslintFlatConfig,
+  {
+    rules: {
+      // Temporary: legacy had ~100 no-explicit-any warnings via @typescript-eslint v5
+      '@typescript-eslint/no-explicit-any': 'warn',
+    },
+  },
+];
+```
+
+Remove overrides in a follow-up debt PR. Do not copy Airbnb or legacy `.eslintrc` rules.
+
+### Phase 5 — Verify
+
+- [ ] `pnpm exec pui-cli lint` — 0 errors
+- [ ] `pnpm exec pui-cli tscheck --files`
+- [ ] `pnpm test`
+- [ ] `pnpm run build` (or `pui-cli build`)
+- [ ] Pre-commit / lint-staged passes
+- [ ] CI green on the target branch
+
+## Common lint fixes after upgrade
+
+| Symptom                              | Fix                                                                    |
+| ------------------------------------ | ---------------------------------------------------------------------- |
+| `import-x/no-unresolved`             | Use `import type` for type-only imports                                |
+| `@typescript-eslint/no-explicit-any` | Type the value or add targeted override (warn) during transition       |
+| `@typescript-eslint/no-unused-vars`  | Remove or prefix with `_`                                              |
+| Stale `eslint-disable` comments      | Remove disables for rules no longer in config                          |
+| Test/fixture files flagged           | Shared config includes `lib/**/tests/**` globs — ensure pui-cli 9.0.0+ |
+| `.d.ts` files                        | pui-cli turns off `no-explicit-any` for `**/*.d.ts`                    |
+
+Full rule comparison: [eslint-rules-migration.md](https://docs.pui.mortgagetech.q1.ice.com/cli/eslint-rules-migration) (also at `docs/eslint-rules-migration.md` in pui-cli).
+
+## Install this skill in Cursor
+
+From the consumer repo (after `@elliemae/pui-cli` is installed):
+
+```bash
+pnpm exec pui-cli skills install migrate-to-pui-cli-9 --target all
+```
+
+Skills are copied to `.cursor/skills/`, `.claude/skills/`, and `.github/skills/` for Cursor, Claude Code, and GitHub Copilot.
+
+## What NOT to change
+
+- Application business logic — migration is tooling/config only
+- Webpack/babel config unless pui-cli 9 release notes require it
+- Prettier / Stylelint / commitlint configs unless pui-cli 9 bumps those presets
+
+## Additional resources
+
+- [pui-cli 9 migration guide](https://docs.pui.mortgagetech.q1.ice.com/cli/pui-cli-9-migration)
+- [ESLint rules migration guide](https://docs.pui.mortgagetech.q1.ice.com/cli/eslint-rules-migration)
+- Reference one-liner: `pui-react-boilerplate/eslint.config.mjs`

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@elliemae/pui-cli",
-  "version": "9.0.0-alpha.4",
+  "version": "9.0.0-alpha.6",
   "description": "ICE MT UI Platform CLI",
   "sideEffects": false,
   "main": "./dist/cjs/index.cjs",
@@ -37,6 +37,7 @@
     "dist",
     "build",
     "lib/lint-config",
+    "lib/skills",
     "./app.tsconfig.json",
     "./library.tsconfig.json"
   ],
@@ -77,10 +78,11 @@
     "@babel/preset-react": "~7.28.5",
     "@babel/preset-typescript": "~7.28.5",
     "@babel/runtime": "~7.29.2",
-    "@commitlint/cli": "~17.8.1",
-    "@commitlint/config-conventional": "~17.8.1",
+    "@commitlint/cli": "~21.0.1",
+    "@commitlint/config-conventional": "~21.0.1",
     "@elliemae/browserslist-config-elliemae-latest-browsers": "~1.14.4",
-    "@eslint/js": "~9.39.1",
+    "@eslint/compat": "~1.4.1",
+    "@eslint/js": "~10.0.1",
     "@faker-js/faker": "~7.6.0",
     "@nrwl/cli": "~15.9.7",
     "@nrwl/tao": "~15.9.7",
@@ -170,21 +172,19 @@
     "esbuild": "~0.28.0",
     "esbuild-loader": "~3.2.0",
     "esbuild-plugin-svgr": "~1.1.0",
-    "eslint": "~9.39.1",
+    "eslint": "~10.4.0",
     "eslint-config-prettier": "~10.1.8",
     "eslint-import-resolver-typescript": "~4.4.4",
-    "eslint-plugin-eslint-comments": "~3.2.0",
     "eslint-plugin-import-x": "~4.16.1",
-    "eslint-plugin-jest": "~29.0.1",
-    "eslint-plugin-jsdoc": "~50.8.0",
+    "eslint-plugin-jest": "~29.15.2",
     "eslint-plugin-jsx-a11y": "~6.10.2",
-    "eslint-plugin-mdx": "~3.6.2",
+    "eslint-plugin-mdx": "~3.7.0",
     "eslint-plugin-react": "~7.37.5",
-    "eslint-plugin-react-hooks": "~5.2.0",
+    "eslint-plugin-react-hooks": "~7.1.1",
     "eslint-plugin-redux-saga": "~1.3.2",
     "eslint-plugin-storybook": "~0.12.0",
-    "eslint-plugin-testing-library": "~7.4.0",
-    "eslint-plugin-wdio": "~8.37.0",
+    "eslint-plugin-testing-library": "~7.16.2",
+    "eslint-plugin-wdio": "~9.27.1",
     "execa": "~7.2.0",
     "express": "~4.22.1",
     "express-static-gzip": "~2.2.0",
@@ -194,7 +194,7 @@
     "find-up": "~6.3.0",
     "find-up-cli": "~5.0.0",
     "glob": "~11.1.0",
-    "globals": "~16.5.0",
+    "globals": "~17.6.0",
     "happy-dom": "~12.10.3",
     "helmet": "~8.1.0",
     "html-loader": "~4.2.0",
@@ -213,7 +213,7 @@
     "jscodeshift": "~0.16.1",
     "jsdoc": "~4.0.5",
     "lerna": "~6.6.2",
-    "lint-staged": "~13.3.0",
+    "lint-staged": "~17.0.5",
     "lodash": "~4.18.1",
     "mini-css-extract-plugin": "~2.10.2",
     "minimist": "~1.2.8",
@@ -235,7 +235,7 @@
     "postcss-loader": "~7.3.4",
     "postcss-preset-env": "9.6.0",
     "postcss-styled-syntax": "~0.7.1",
-    "prettier": "~2.8.8",
+    "prettier": "~3.8.3",
     "prisma": "~4.16.2",
     "pug": "~3.0.4",
     "pug-loader": "~2.4.0",
@@ -253,8 +253,8 @@
     "storybook-addon-turbo-build": "~1.1.0",
     "storybook-react-router": "~1.0.8",
     "style-loader": "~3.3.4",
-    "stylelint": "~15.11.0",
-    "stylelint-config-recommended": "~12.0.0",
+    "stylelint": "~17.12.0",
+    "stylelint-config-recommended": "~18.0.0",
     "stylelint-config-styled-components": "~0.1.1",
     "supertest": "~6.3.4",
     "swc-loader": "~0.2.7",
@@ -264,7 +264,7 @@
     "tsx": "~4.21.0",
     "typedoc": "~0.28.19",
     "typescript": "5.9.3",
-    "typescript-eslint": "~8.46.2",
+    "typescript-eslint": "~8.59.4",
     "update-notifier": "~6.0.2",
     "url-loader": "~4.1.1",
     "uuid": "~9.0.1",