@elliemae/pui-cli 9.0.0-alpha.4 → 9.0.0-alpha.6

package/dist/esm/lint-config/eslint/flat/common.mjs

@@ -1,7 +1,6 @@
 import eslint from '@eslint/js';
 import { defineConfig } from 'eslint/config';
 import eslintConfigPrettier from 'eslint-config-prettier';
-import eslintComments from 'eslint-plugin-eslint-comments';
 import importX from 'eslint-plugin-import-x';
 import jest from 'eslint-plugin-jest';
 import testingLibrary from 'eslint-plugin-testing-library';
@@ -51,7 +50,6 @@ export function createBaseFlatConfigs(tsRules) {
     eslintConfigPrettier,
     {
       plugins: {
-        'eslint-comments': eslintComments,
         'import-x': importX,
       },
       languageOptions: {

package/dist/esm/lint-config/eslint/flat/compat.mjs

@@ -0,0 +1,20 @@
+/**
+ * ESLint 10 removed deprecated context APIs (e.g. getSourceCode).
+ * Wrap legacy plugins until their maintainers publish compatible releases.
+ */
+import { fixupConfigRules, fixupPluginRules } from '@eslint/compat';
+import reduxSaga from 'eslint-plugin-redux-saga';
+import storybook from 'eslint-plugin-storybook';
+
+const storybookFlat =
+  storybook.configs['flat/recommended'] ??
+  storybook.configs.recommended ??
+  [];
+
+/** @type {import('eslint').ESLint.Plugin} */
+export const reduxSagaPlugin = fixupPluginRules(reduxSaga);
+
+/** Storybook flat presets with ESLint 10 compatibility shims applied. */
+export const storybookFlatConfigs = fixupConfigRules(
+  Array.isArray(storybookFlat) ? storybookFlat : [storybookFlat],
+);

package/dist/esm/lint-config/eslint/flat/presets.mjs

@@ -1,16 +1,15 @@
 /**
  * Preset rule bundles and file globs computed once at module load (not per config factory call).
  */
-import eslintComments from 'eslint-plugin-eslint-comments';
 import importX from 'eslint-plugin-import-x';
 import jest from 'eslint-plugin-jest';
 import jsxA11y from 'eslint-plugin-jsx-a11y';
 import react from 'eslint-plugin-react';
 import reactHooks from 'eslint-plugin-react-hooks';
 import reduxSaga from 'eslint-plugin-redux-saga';
-import storybook from 'eslint-plugin-storybook';
 import testingLibrary from 'eslint-plugin-testing-library';
 import wdio from 'eslint-plugin-wdio';
+import { storybookFlatConfigs } from './compat.mjs';
 
 /** Application and integration tests (Jest + relaxed type-checked rules). */
 export const testFiles = [
@@ -50,7 +49,6 @@ export const storybookFiles = [
 
 /** @type {import('eslint').Linter.RulesRecord} */
 export const sharedCoreRules = {
-  ...eslintComments.configs.recommended.rules,
   ...importX.configs.recommended.rules,
   'import-x/named': 'off',
 };
@@ -83,12 +81,4 @@ export const wdioRecommendedRules = wdio.configs.recommended.rules ?? {};
 /** @type {Record<string, boolean>} */
 export const wdioGlobals = wdio.configs.recommended.globals ?? {};
 
-const storybookFlat =
-  storybook.configs['flat/recommended'] ??
-  storybook.configs.recommended ??
-  [];
-
-/** Normalized once — Storybook flat config may be array or single object. */
-export const storybookFlatConfigs = Array.isArray(storybookFlat)
-  ? storybookFlat
-  : [storybookFlat];
+export { storybookFlatConfigs };

package/dist/esm/lint-config/eslint/flat/react.mjs

@@ -2,8 +2,8 @@ import { defineConfig } from 'eslint/config';
 import jsxA11y from 'eslint-plugin-jsx-a11y';
 import react from 'eslint-plugin-react';
 import reactHooks from 'eslint-plugin-react-hooks';
-import reduxSaga from 'eslint-plugin-redux-saga';
 import { baseFlatConfigs, baseFlatConfigsStrict } from './common.mjs';
+import { reduxSagaPlugin } from './compat.mjs';
 import {
   reactPresetRules,
   storybookFiles,
@@ -16,7 +16,7 @@ const reactPluginBlock = {
     react,
     'react-hooks': reactHooks,
     'jsx-a11y': jsxA11y,
-    'redux-saga': reduxSaga,
+    'redux-saga': reduxSagaPlugin,
   },
   settings: {
     react: { version: 'detect' },

package/dist/esm/lint-config/eslint/flat/rules.mjs

@@ -38,7 +38,6 @@ export const baseRules = {
   'no-param-reassign': ['error', { props: false }],
   'prefer-template': 'error',
   'require-yield': 'off',
-  'eslint-comments/disable-enable-pair': 'off',
 };
 
 /** Relaxed type-checked rules for test files (shared by default and strict configs). */

package/dist/esm/skills/migrate-to-pui-cli-9/SKILL.md

@@ -0,0 +1,140 @@
+---
+name: migrate-to-pui-cli-9
+description: >-
+  Migrate a PUI app or library to pui-cli 9 (Node 24, pnpm 11, ESLint 9 flat config).
+  Use when upgrading @elliemae/pui-cli, migrating from .eslintrc.cjs to eslint.config.mjs,
+  fixing ESLint 9 lint failures, or adopting the shared flat config from pui-cli.
+---
+
+# Migrate to pui-cli 9
+
+Upgrades a PUI repo from pui-cli 8 (ESLint 8 + `.eslintrc.cjs`) to pui-cli 9
+(ESLint 9 + `eslint.config.mjs` + Node 24 + pnpm 11).
+
+## Pre-flight: Toolchain
+
+| Requirement         | Version                           |
+| ------------------- | --------------------------------- |
+| Node.js             | **24** (see repo `.node-version`) |
+| pnpm                | **11**                            |
+| `@elliemae/pui-cli` | **9.x** (alpha/beta until GA)     |
+
+```bash
+fnm use 24   # or nvm/volta equivalent
+corepack enable
+pnpm install
+```
+
+## Migration steps (phased PRs recommended)
+
+### Phase 1 — Toolchain only
+
+1. Update `.node-version` to `24` if needed.
+2. Ensure CI Jenkins/docker images use Node 24.
+3. Upgrade pnpm to 11 (`packageManager` field in root `package.json`).
+4. Run `pnpm install`, `pnpm test`, `pnpm run build` — fix any Node/pnpm breakages only.
+
+### Phase 2 — Bump pui-cli
+
+```bash
+pnpm add -D @elliemae/pui-cli@9
+```
+
+Re-run install and smoke-test build/test without ESLint changes yet if the bump is large.
+
+### Phase 3 — ESLint 9 flat config
+
+**React apps and libraries:**
+
+```js
+// eslint.config.mjs
+import { eslintFlatConfig } from '@elliemae/pui-cli/eslint';
+
+export default eslintFlatConfig;
+```
+
+**Node / TS services (non-React):**
+
+```js
+// eslint.config.mjs
+import { eslintFlatBaseConfig } from '@elliemae/pui-cli/eslint';
+
+export default eslintFlatBaseConfig;
+```
+
+Then:
+
+1. Delete `.eslintrc.cjs` and `.eslintignore` (ignores are in the shared config).
+2. Run `pnpm exec pui-cli lint --fix`.
+3. Run `pnpm exec pui-cli lint` until **zero errors** (warnings may remain).
+
+**Strict mode** (only after default config is clean):
+
+```js
+import { eslintFlatConfigStrict } from '@elliemae/pui-cli/eslint';
+export default eslintFlatConfigStrict;
+```
+
+### Phase 4 — Repo-specific overrides (if needed)
+
+Add overrides **after** importing the shared config only when lint debt blocks the migration:
+
+```js
+import { eslintFlatConfig } from '@elliemae/pui-cli/eslint';
+
+export default [
+  ...eslintFlatConfig,
+  {
+    rules: {
+      // Temporary: legacy had ~100 no-explicit-any warnings via @typescript-eslint v5
+      '@typescript-eslint/no-explicit-any': 'warn',
+    },
+  },
+];
+```
+
+Remove overrides in a follow-up debt PR. Do not copy Airbnb or legacy `.eslintrc` rules.
+
+### Phase 5 — Verify
+
+- [ ] `pnpm exec pui-cli lint` — 0 errors
+- [ ] `pnpm exec pui-cli tscheck --files`
+- [ ] `pnpm test`
+- [ ] `pnpm run build` (or `pui-cli build`)
+- [ ] Pre-commit / lint-staged passes
+- [ ] CI green on the target branch
+
+## Common lint fixes after upgrade
+
+| Symptom                              | Fix                                                                    |
+| ------------------------------------ | ---------------------------------------------------------------------- |
+| `import-x/no-unresolved`             | Use `import type` for type-only imports                                |
+| `@typescript-eslint/no-explicit-any` | Type the value or add targeted override (warn) during transition       |
+| `@typescript-eslint/no-unused-vars`  | Remove or prefix with `_`                                              |
+| Stale `eslint-disable` comments      | Remove disables for rules no longer in config                          |
+| Test/fixture files flagged           | Shared config includes `lib/**/tests/**` globs — ensure pui-cli 9.0.0+ |
+| `.d.ts` files                        | pui-cli turns off `no-explicit-any` for `**/*.d.ts`                    |
+
+Full rule comparison: [eslint-rules-migration.md](https://docs.pui.mortgagetech.q1.ice.com/cli/eslint-rules-migration) (also at `docs/eslint-rules-migration.md` in pui-cli).
+
+## Install this skill in Cursor
+
+From the consumer repo (after `@elliemae/pui-cli` is installed):
+
+```bash
+pnpm exec pui-cli skills install migrate-to-pui-cli-9 --target all
+```
+
+Skills are copied to `.cursor/skills/`, `.claude/skills/`, and `.github/skills/` for Cursor, Claude Code, and GitHub Copilot.
+
+## What NOT to change
+
+- Application business logic — migration is tooling/config only
+- Webpack/babel config unless pui-cli 9 release notes require it
+- Prettier / Stylelint / commitlint configs unless pui-cli 9 bumps those presets
+
+## Additional resources
+
+- [pui-cli 9 migration guide](https://docs.pui.mortgagetech.q1.ice.com/cli/pui-cli-9-migration)
+- [ESLint rules migration guide](https://docs.pui.mortgagetech.q1.ice.com/cli/eslint-rules-migration)
+- Reference one-liner: `pui-react-boilerplate/eslint.config.mjs`

package/dist/types/lib/commands/skills.d.ts

@@ -0,0 +1,11 @@
+import { type CommandModule } from 'yargs';
+type SkillTarget = 'cursor' | 'claude' | 'copilot';
+type TargetOption = SkillTarget | 'all';
+type Arguments = {
+    action: 'install' | 'list';
+    name?: string;
+    force?: boolean;
+    target?: TargetOption | TargetOption[];
+};
+export declare const skillsCmd: CommandModule<Record<string, never>, Arguments>;
+export {};

package/dist/types/lib/lint-config/eslint/flat/compat.d.mts

@@ -0,0 +1,4 @@
+/** @type {import('eslint').ESLint.Plugin} */
+export const reduxSagaPlugin: import("eslint").ESLint.Plugin;
+/** Storybook flat presets with ESLint 10 compatibility shims applied. */
+export const storybookFlatConfigs: import("@eslint/compat").FixupConfigArray;

package/dist/types/lib/lint-config/eslint/flat/presets.d.mts

@@ -22,48 +22,5 @@ export const reactPresetRules: import("eslint").Linter.RulesRecord;
 export const wdioRecommendedRules: import("eslint").Linter.RulesRecord;
 /** @type {Record<string, boolean>} */
 export const wdioGlobals: Record<string, boolean>;
-/** Normalized once — Storybook flat config may be array or single object. */
-export const storybookFlatConfigs: ({
-    name: string;
-    plugins: {
-        readonly storybook: any;
-    };
-    files?: undefined;
-    rules?: undefined;
-} | {
-    name: string;
-    files: string[];
-    rules: {
-        readonly "react-hooks/rules-of-hooks": "off";
-        readonly "import/no-anonymous-default-export": "off";
-        readonly "storybook/await-interactions": "error";
-        readonly "storybook/context-in-play-function": "error";
-        readonly "storybook/default-exports": "error";
-        readonly "storybook/hierarchy-separator": "warn";
-        readonly "storybook/no-redundant-story-name": "warn";
-        readonly "storybook/prefer-pascal-case": "warn";
-        readonly "storybook/story-exports": "error";
-        readonly "storybook/use-storybook-expect": "error";
-        readonly "storybook/use-storybook-testing-library": "error";
-        readonly "storybook/no-uninstalled-addons"?: undefined;
-    };
-    plugins?: undefined;
-} | {
-    name: string;
-    files: string[];
-    rules: {
-        readonly "storybook/no-uninstalled-addons": "error";
-        readonly "react-hooks/rules-of-hooks"?: undefined;
-        readonly "import/no-anonymous-default-export"?: undefined;
-        readonly "storybook/await-interactions"?: undefined;
-        readonly "storybook/context-in-play-function"?: undefined;
-        readonly "storybook/default-exports"?: undefined;
-        readonly "storybook/hierarchy-separator"?: undefined;
-        readonly "storybook/no-redundant-story-name"?: undefined;
-        readonly "storybook/prefer-pascal-case"?: undefined;
-        readonly "storybook/story-exports"?: undefined;
-        readonly "storybook/use-storybook-expect"?: undefined;
-        readonly "storybook/use-storybook-testing-library"?: undefined;
-    };
-    plugins?: undefined;
-})[];
+export { storybookFlatConfigs };
+import { storybookFlatConfigs } from './compat.mjs';

package/dist/types/lib/lint-config/eslint/flat/rules.d.mts

@@ -44,7 +44,6 @@ export const baseRules: {
     })[];
     'prefer-template': string;
     'require-yield': string;
-    'eslint-comments/disable-enable-pair': string;
 };
 /** Relaxed type-checked rules for test files (shared by default and strict configs). */
 export const typescriptTestRelaxedRules: {
@@ -120,7 +119,6 @@ export const jsRules: {
     })[];
     'prefer-template': string;
     'require-yield': string;
-    'eslint-comments/disable-enable-pair': string;
 };
 export const typescriptRules: {
     'max-lines': (string | {
@@ -205,7 +203,6 @@ export const typescriptRules: {
     })[];
     'prefer-template': string;
     'require-yield': string;
-    'eslint-comments/disable-enable-pair': string;
 };
 /** Stricter TypeScript rules (error on unsafe any usage). */
 export const typescriptStrictRules: {
@@ -291,7 +288,6 @@ export const typescriptStrictRules: {
     })[];
     'prefer-template': string;
     'require-yield': string;
-    'eslint-comments/disable-enable-pair': string;
 };
 export const reactRules: {
     'jsx-a11y/aria-props': string;