@elevasis/core 0.23.0 → 0.24.0

package/src/business/acquisition/deal-ownership.ts

@@ -1,120 +1,120 @@
-// ---------------------------------------------------------------------------
-// Deal ownership axis — derived from activity_log (Pattern A, approved).
-//
-// Ownership reflects who owes the next move, not a stored column.
-// Closed deals always return null — ownership is meaningless once won/lost.
-// ---------------------------------------------------------------------------
-
-export type DealOwnership = 'us' | 'them' | null
-
-// Inbound events: lead acted, ball is in our court.
-const INBOUND_EVENT_TYPES = ['reply_received'] as const
-
-// Outbound events: we acted, ball is in their court.
-const OUTBOUND_EVENT_TYPES = [
-  'reply_sent_to_lead',
-  'booking_nudge_sent',
-  'reminder_sent',
-  'rebook_sent',
-  'followup_email_sent',
-  'reply_followup_sent',
-  'lead_deferred_next_step'
-] as const
-
-type InboundEventType = (typeof INBOUND_EVENT_TYPES)[number]
-type OutboundEventType = (typeof OUTBOUND_EVENT_TYPES)[number]
-
-const INBOUND_SET = new Set<string>(INBOUND_EVENT_TYPES)
-const OUTBOUND_SET = new Set<string>(OUTBOUND_EVENT_TYPES)
-
-interface DealOwnershipInput {
-  state_key: string | null
-  activity_log: unknown
-}
-
-/**
- * Derives who owes the next move from the activity log.
- *
- * - `'us'`   — the lead replied last; we owe a response.
- * - `'them'` — we sent something last; waiting on their reply.
- * - `null`   — closed deal, or no inbound/outbound events present.
- *
- * Timestamp resolution matches the canonical pattern in crm-priority.ts:
- * COALESCE across `timestamp ?? occurredAt ?? createdAt ?? updatedAt ?? sentAt`.
- */
-export function getDealOwnership(deal: DealOwnershipInput): DealOwnership {
-  if (deal.state_key === 'closed_won' || deal.state_key === 'closed_lost') {
-    return null
-  }
-
-  if (!Array.isArray(deal.activity_log)) return null
-
-  let latestInboundMs: number | null = null
-  let latestOutboundMs: number | null = null
-
-  for (const entry of deal.activity_log) {
-    if (!entry || typeof entry !== 'object' || Array.isArray(entry)) continue
-
-    const record = entry as Record<string, unknown>
-    const type = typeof record.type === 'string' ? record.type : null
-    if (!type) continue
-
-    const isInbound = INBOUND_SET.has(type)
-    const isOutbound = OUTBOUND_SET.has(type)
-    if (!isInbound && !isOutbound) continue
-
-    const occurredAt = resolveTimestamp(record)
-    if (occurredAt === null) continue
-
-    if (isInbound && (latestInboundMs === null || occurredAt > latestInboundMs)) {
-      latestInboundMs = occurredAt
-    }
-
-    if (isOutbound && (latestOutboundMs === null || occurredAt > latestOutboundMs)) {
-      latestOutboundMs = occurredAt
-    }
-  }
-
-  if (latestInboundMs === null && latestOutboundMs === null) return null
-
-  // Tie-break: outbound wins ("after we send, ball is in their court")
-  if (latestOutboundMs !== null && (latestInboundMs === null || latestOutboundMs >= latestInboundMs)) {
-    return 'them'
-  }
-
-  return 'us'
-}
-
-// ---------------------------------------------------------------------------
-// Internal helpers
-// ---------------------------------------------------------------------------
-
-/**
- * COALESCE timestamp fields in the same order as getParsedActivities in
- * crm-priority.ts: timestamp → occurredAt → createdAt → updatedAt → sentAt.
- * Returns milliseconds since epoch, or null if no valid date found.
- */
-function resolveTimestamp(record: Record<string, unknown>): number | null {
-  return (
-    parseMs(record.timestamp) ??
-    parseMs(record.occurredAt) ??
-    parseMs(record.createdAt) ??
-    parseMs(record.updatedAt) ??
-    parseMs(record.sentAt) ??
-    null
-  )
-}
-
-function parseMs(value: unknown): number | null {
-  if (value instanceof Date) {
-    const ms = value.getTime()
-    return Number.isNaN(ms) ? null : ms
-  }
-  if (typeof value !== 'string') return null
-  const ms = new Date(value).getTime()
-  return Number.isNaN(ms) ? null : ms
-}
-
-// Re-export event type lists for consumers that want to introspect classification.
-export { INBOUND_EVENT_TYPES, OUTBOUND_EVENT_TYPES }
-export type { InboundEventType, OutboundEventType }
+// ---------------------------------------------------------------------------
+// Deal ownership axis — derived from activity_log (Pattern A, approved).
+//
+// Ownership reflects who owes the next move, not a stored column.
+// Closed deals always return null — ownership is meaningless once won/lost.
+// ---------------------------------------------------------------------------
+
+export type DealOwnership = 'us' | 'them' | null
+
+// Inbound events: lead acted, ball is in our court.
+const INBOUND_EVENT_TYPES = ['reply_received'] as const
+
+// Outbound events: we acted, ball is in their court.
+const OUTBOUND_EVENT_TYPES = [
+  'reply_sent_to_lead',
+  'booking_nudge_sent',
+  'reminder_sent',
+  'rebook_sent',
+  'followup_email_sent',
+  'reply_followup_sent',
+  'lead_deferred_next_step'
+] as const
+
+type InboundEventType = (typeof INBOUND_EVENT_TYPES)[number]
+type OutboundEventType = (typeof OUTBOUND_EVENT_TYPES)[number]
+
+const INBOUND_SET = new Set<string>(INBOUND_EVENT_TYPES)
+const OUTBOUND_SET = new Set<string>(OUTBOUND_EVENT_TYPES)
+
+interface DealOwnershipInput {
+  state_key: string | null
+  activity_log: unknown
+}
+
+/**
+ * Derives who owes the next move from the activity log.
+ *
+ * - `'us'`   — the lead replied last; we owe a response.
+ * - `'them'` — we sent something last; waiting on their reply.
+ * - `null`   — closed deal, or no inbound/outbound events present.
+ *
+ * Timestamp resolution matches the canonical pattern in crm-priority.ts:
+ * COALESCE across `timestamp ?? occurredAt ?? createdAt ?? updatedAt ?? sentAt`.
+ */
+export function getDealOwnership(deal: DealOwnershipInput): DealOwnership {
+  if (deal.state_key === 'closed_won' || deal.state_key === 'closed_lost') {
+    return null
+  }
+
+  if (!Array.isArray(deal.activity_log)) return null
+
+  let latestInboundMs: number | null = null
+  let latestOutboundMs: number | null = null
+
+  for (const entry of deal.activity_log) {
+    if (!entry || typeof entry !== 'object' || Array.isArray(entry)) continue
+
+    const record = entry as Record<string, unknown>
+    const type = typeof record.type === 'string' ? record.type : null
+    if (!type) continue
+
+    const isInbound = INBOUND_SET.has(type)
+    const isOutbound = OUTBOUND_SET.has(type)
+    if (!isInbound && !isOutbound) continue
+
+    const occurredAt = resolveTimestamp(record)
+    if (occurredAt === null) continue
+
+    if (isInbound && (latestInboundMs === null || occurredAt > latestInboundMs)) {
+      latestInboundMs = occurredAt
+    }
+
+    if (isOutbound && (latestOutboundMs === null || occurredAt > latestOutboundMs)) {
+      latestOutboundMs = occurredAt
+    }
+  }
+
+  if (latestInboundMs === null && latestOutboundMs === null) return null
+
+  // Tie-break: outbound wins ("after we send, ball is in their court")
+  if (latestOutboundMs !== null && (latestInboundMs === null || latestOutboundMs >= latestInboundMs)) {
+    return 'them'
+  }
+
+  return 'us'
+}
+
+// ---------------------------------------------------------------------------
+// Internal helpers
+// ---------------------------------------------------------------------------
+
+/**
+ * COALESCE timestamp fields in the same order as getParsedActivities in
+ * crm-priority.ts: timestamp → occurredAt → createdAt → updatedAt → sentAt.
+ * Returns milliseconds since epoch, or null if no valid date found.
+ */
+function resolveTimestamp(record: Record<string, unknown>): number | null {
+  return (
+    parseMs(record.timestamp) ??
+    parseMs(record.occurredAt) ??
+    parseMs(record.createdAt) ??
+    parseMs(record.updatedAt) ??
+    parseMs(record.sentAt) ??
+    null
+  )
+}
+
+function parseMs(value: unknown): number | null {
+  if (value instanceof Date) {
+    const ms = value.getTime()
+    return Number.isNaN(ms) ? null : ms
+  }
+  if (typeof value !== 'string') return null
+  const ms = new Date(value).getTime()
+  return Number.isNaN(ms) ? null : ms
+}
+
+// Re-export event type lists for consumers that want to introspect classification.
+export { INBOUND_EVENT_TYPES, OUTBOUND_EVENT_TYPES }
+export type { InboundEventType, OutboundEventType }

package/src/business/acquisition/derive-actions.test.ts

@@ -1,7 +1,9 @@
 import { describe, expect, it } from 'vitest'
-import type { AcqDealRow } from './types'
-import type { Action, ActionDef } from './derive-actions'
-import { DEFAULT_CRM_ACTIONS, SendReplyActionPayloadSchema, deriveActions } from './derive-actions'
+import { CRM_ACTION_ENTRIES } from '@repo/core/organization-model'
+import type { AcqDealRow } from './types'
+import type { Action, ActionDef } from './derive-actions'
+import { DEFAULT_CRM_ACTIONS, SendReplyActionPayloadSchema, deriveActions } from './derive-actions'
+import { getCrmActionMetadata } from './ontology-validation'
 
 // ---------------------------------------------------------------------------
 // Fixture builder
@@ -12,15 +14,15 @@ import { DEFAULT_CRM_ACTIONS, SendReplyActionPayloadSchema, deriveActions } from
  * Only stage_key and state_key affect availability logic; all other required
  * columns are filled with safe, inert defaults.
  */
-function makeDeal(
-  overrides: Partial<AcqDealRow> & { ownership?: 'us' | 'them' | null; nextAction?: string | null } = {}
-): AcqDealRow & { ownership?: 'us' | 'them' | null; nextAction?: string | null } {
+function makeDeal(
+  overrides: Partial<AcqDealRow> & { ownership?: 'us' | 'them' | null; nextAction?: string | null } = {}
+): AcqDealRow & { ownership?: 'us' | 'them' | null; nextAction?: string | null } {
   return {
     id: 'deal-fixture-id',
     organization_id: 'org-fixture-id',
     contact_id: null,
     contact_email: 'fixture@example.com',
-    pipeline_key: 'crm',
+    pipeline_key: 'crm',
     stage_key: null,
     state_key: null,
     activity_log: [],
@@ -93,6 +95,29 @@ describe('DEFAULT_CRM_ACTIONS static contract', () => {
     const unique = new Set(keys)
     expect(unique.size).toBe(keys.length)
   })
+
+  it('derives promoted CRM runtime metadata from CRM_ACTION_ENTRIES', () => {
+    const sendReply = DEFAULT_CRM_ACTIONS.find((a) => a.key === 'send_reply')
+    const metadata = CRM_ACTION_ENTRIES['send_reply']
+    const ontologyMetadata = getCrmActionMetadata('send_reply')
+
+    expect(sendReply).toBeDefined()
+    expect(sendReply?.key).toBe(metadata.id)
+    expect(sendReply?.label).toBe(metadata.label)
+    expect(sendReply?.workflowId).toBe(metadata.resourceId)
+    expect(ontologyMetadata).toMatchObject({
+      id: metadata.id,
+      label: metadata.label,
+      resourceId: metadata.resourceId
+    })
+  })
+
+  it('keeps mark_no_show as a runtime-only CRM action', () => {
+    const markNoShow = DEFAULT_CRM_ACTIONS.find((a) => a.key === 'mark_no_show')
+
+    expect(markNoShow).toBeDefined()
+    expect(CRM_ACTION_ENTRIES['mark_no_show']).toBeUndefined()
+  })
 })
 
 // ---------------------------------------------------------------------------
@@ -394,10 +419,10 @@ describe('deriveActions() — custom action set isolation', () => {
 // ---------------------------------------------------------------------------
 
 describe('deriveActions() — action metadata preservation', () => {
-  it('send_reply action includes payloadSchema in output', () => {
-    const actions = deriveActions(
-      makeDeal({ stage_key: 'interested', state_key: 'discovery_replied', nextAction: 'send_reply' })
-    )
+  it('send_reply action includes payloadSchema in output', () => {
+    const actions = deriveActions(
+      makeDeal({ stage_key: 'interested', state_key: 'discovery_replied', nextAction: 'send_reply' })
+    )
     const sendReply = actions.find((a) => a.key === 'send_reply')
     expect(sendReply).toBeDefined()
     expect(sendReply?.payloadSchema).toBeDefined()
@@ -463,100 +488,100 @@ describe('deriveActions() — multi-state discovery path coverage', () => {
     ])
   })
 
-  it('interested + discovery_replied: base actions plus send_link when no next move signal is available', () => {
-    expect(deriveActions(makeDeal({ stage_key: 'interested', state_key: 'discovery_replied' }))).toEqual([
-      { key: 'move_to_proposal', label: 'Move to Proposal' },
-      { key: 'move_to_closed_lost', label: 'Close Lost' },
-      { key: 'move_to_nurturing', label: 'Move to Nurturing' },
-      { key: 'send_link', label: 'Send Booking Link' }
-    ])
-  })
-
-  it('interested + discovery_link_sent: base actions plus send_nudge', () => {
-    expect(deriveActions(makeDeal({ stage_key: 'interested', state_key: 'discovery_link_sent' }))).toEqual([
-      { key: 'move_to_proposal', label: 'Move to Proposal' },
-      { key: 'move_to_closed_lost', label: 'Close Lost' },
-      { key: 'move_to_nurturing', label: 'Move to Nurturing' },
-      { key: 'send_nudge', label: 'Send Nudge' }
-    ])
-  })
-
-  it('interested + discovery_nudging: base actions plus send_nudge and mark_no_show', () => {
-    expect(deriveActions(makeDeal({ stage_key: 'interested', state_key: 'discovery_nudging' }))).toEqual([
-      { key: 'move_to_proposal', label: 'Move to Proposal' },
-      { key: 'move_to_closed_lost', label: 'Close Lost' },
-      { key: 'move_to_nurturing', label: 'Move to Nurturing' },
-      { key: 'send_nudge', label: 'Send Nudge' },
-      { key: 'mark_no_show', label: 'Mark No-Show' }
-    ])
-  })
-})
+  it('interested + discovery_replied: base actions plus send_link when no next move signal is available', () => {
+    expect(deriveActions(makeDeal({ stage_key: 'interested', state_key: 'discovery_replied' }))).toEqual([
+      { key: 'move_to_proposal', label: 'Move to Proposal' },
+      { key: 'move_to_closed_lost', label: 'Close Lost' },
+      { key: 'move_to_nurturing', label: 'Move to Nurturing' },
+      { key: 'send_link', label: 'Send Booking Link' }
+    ])
+  })
 
-// ---------------------------------------------------------------------------
-// deriveActions() - ownership-gated reply action
-// ---------------------------------------------------------------------------
-
-describe('deriveActions() - ownership-gated reply action', () => {
-  it('lead asks us to respond: send_reply is available and ownership is our move', () => {
-    const actions = deriveActions(
-      makeDeal({
-        stage_key: 'interested',
-        state_key: 'discovery_replied',
-        activity_log: [{ type: 'reply_received', timestamp: '2026-01-10T10:00:00Z' }]
-      })
-    )
-
-    expect(actions).toContainEqual({ key: 'send_reply', label: 'Send Reply', payloadSchema: SendReplyActionPayloadSchema })
-  })
-
-  it('lead deferred next step: send_reply is not available while it is their move', () => {
-    const actions = deriveActions(
-      makeDeal({
-        stage_key: 'interested',
-        state_key: 'discovery_replied',
-        activity_log: [
-          { type: 'reply_received', timestamp: '2026-01-10T10:00:00Z' },
-          { type: 'lead_deferred_next_step', timestamp: '2026-01-10T10:05:00Z' }
-        ]
-      })
-    )
-
-    expect(actions.map((action) => action.key)).not.toContain('send_reply')
-    expect(actions).toContainEqual({ key: 'send_link', label: 'Send Booking Link' })
-  })
-
-  it('outbound after lead response: send_reply is not available while it is their move', () => {
-    const actions = deriveActions(
-      makeDeal({
-        stage_key: 'interested',
-        state_key: 'discovery_replied',
-        activity_log: [
-          { type: 'reply_received', timestamp: '2026-01-10T10:00:00Z' },
-          { type: 'reply_sent_to_lead', timestamp: '2026-01-10T10:05:00Z' }
-        ]
-      })
-    )
-
-    expect(actions.map((action) => action.key)).not.toContain('send_reply')
-    expect(actions).toContainEqual({ key: 'send_link', label: 'Send Booking Link' })
-  })
-
-  it('uses projected nextAction before deriving from activity_log', () => {
-    const actions = deriveActions(
-      makeDeal({
-        stage_key: 'interested',
-        state_key: 'discovery_replied',
-        nextAction: null,
-        activity_log: [{ type: 'reply_received', timestamp: '2026-01-10T10:00:00Z' }]
-      })
-    )
-
-    expect(actions.map((action) => action.key)).not.toContain('send_reply')
-  })
-})
-
-// ---------------------------------------------------------------------------
-// Type-level smoke tests (compile-time only, no runtime assertions)
+  it('interested + discovery_link_sent: base actions plus send_nudge', () => {
+    expect(deriveActions(makeDeal({ stage_key: 'interested', state_key: 'discovery_link_sent' }))).toEqual([
+      { key: 'move_to_proposal', label: 'Move to Proposal' },
+      { key: 'move_to_closed_lost', label: 'Close Lost' },
+      { key: 'move_to_nurturing', label: 'Move to Nurturing' },
+      { key: 'send_nudge', label: 'Send Nudge' }
+    ])
+  })
+
+  it('interested + discovery_nudging: base actions plus send_nudge and mark_no_show', () => {
+    expect(deriveActions(makeDeal({ stage_key: 'interested', state_key: 'discovery_nudging' }))).toEqual([
+      { key: 'move_to_proposal', label: 'Move to Proposal' },
+      { key: 'move_to_closed_lost', label: 'Close Lost' },
+      { key: 'move_to_nurturing', label: 'Move to Nurturing' },
+      { key: 'send_nudge', label: 'Send Nudge' },
+      { key: 'mark_no_show', label: 'Mark No-Show' }
+    ])
+  })
+})
+
+// ---------------------------------------------------------------------------
+// deriveActions() - ownership-gated reply action
+// ---------------------------------------------------------------------------
+
+describe('deriveActions() - ownership-gated reply action', () => {
+  it('lead asks us to respond: send_reply is available and ownership is our move', () => {
+    const actions = deriveActions(
+      makeDeal({
+        stage_key: 'interested',
+        state_key: 'discovery_replied',
+        activity_log: [{ type: 'reply_received', timestamp: '2026-01-10T10:00:00Z' }]
+      })
+    )
+
+    expect(actions).toContainEqual({ key: 'send_reply', label: 'Send Reply', payloadSchema: SendReplyActionPayloadSchema })
+  })
+
+  it('lead deferred next step: send_reply is not available while it is their move', () => {
+    const actions = deriveActions(
+      makeDeal({
+        stage_key: 'interested',
+        state_key: 'discovery_replied',
+        activity_log: [
+          { type: 'reply_received', timestamp: '2026-01-10T10:00:00Z' },
+          { type: 'lead_deferred_next_step', timestamp: '2026-01-10T10:05:00Z' }
+        ]
+      })
+    )
+
+    expect(actions.map((action) => action.key)).not.toContain('send_reply')
+    expect(actions).toContainEqual({ key: 'send_link', label: 'Send Booking Link' })
+  })
+
+  it('outbound after lead response: send_reply is not available while it is their move', () => {
+    const actions = deriveActions(
+      makeDeal({
+        stage_key: 'interested',
+        state_key: 'discovery_replied',
+        activity_log: [
+          { type: 'reply_received', timestamp: '2026-01-10T10:00:00Z' },
+          { type: 'reply_sent_to_lead', timestamp: '2026-01-10T10:05:00Z' }
+        ]
+      })
+    )
+
+    expect(actions.map((action) => action.key)).not.toContain('send_reply')
+    expect(actions).toContainEqual({ key: 'send_link', label: 'Send Booking Link' })
+  })
+
+  it('uses projected nextAction before deriving from activity_log', () => {
+    const actions = deriveActions(
+      makeDeal({
+        stage_key: 'interested',
+        state_key: 'discovery_replied',
+        nextAction: null,
+        activity_log: [{ type: 'reply_received', timestamp: '2026-01-10T10:00:00Z' }]
+      })
+    )
+
+    expect(actions.map((action) => action.key)).not.toContain('send_reply')
+  })
+})
+
+// ---------------------------------------------------------------------------
+// Type-level smoke tests (compile-time only, no runtime assertions)
 // ---------------------------------------------------------------------------
 
 describe('type-level smoke', () => {