@eifi1/ui-kit 0.51.7 → 0.53.0

package/src/shell/account-menu-language.tsx

@@ -44,8 +44,10 @@ export interface AccountMenuLanguageProps {
   /** The active language's code. */
   value: string | undefined;
   /** A pick: the app sets the device's language and, signed in, the account's
-   *  (settings §6.2). */
-  onPick: (code: string) => void;
+   *  (settings §6.2). `value` + `onChange`, as every kit control pairs them
+   *  (CONTRIBUTING §4; refactor audit 2026-10-30, API-5). Required: 0.53 removed the
+   *  deprecated `onPick`. */
+  onChange: (code: string) => void;
   /** The account menu's `close` (from `TopBarActionMenu`'s `children`): a pick shuts it. */
   close?: () => void;
   /** The row's name. Default: `topBar.language` ("Language"). */
@@ -68,7 +70,7 @@ export interface AccountMenuLanguageProps {
 export function AccountMenuLanguage({
   languages,
   value,
-  onPick,
+  onChange,
   close,
   label,
   defaultOpen = false,
@@ -109,7 +111,7 @@ export function AccountMenuLanguage({
               <MenuItem
                 checked={lang.code === value}
                 onClick={() => {
-                  onPick(lang.code);
+                  onChange(lang.code);
                   setOpen(false);
                   close?.();
                 }}

package/src/shell/account-menu-text-size.tsx

@@ -9,12 +9,15 @@ export interface AccountMenuTextSizeProps {
    *  size whoever applied it put there. */
   value?: TextSize;
   /**
-   * A step: the next size down or up. The app applies it and keeps it as its Settings ▸
-   * Appearance does — `useAccountAppearance`'s `pickTextSize` (this device, and the
-   * account when signed in), with `appearance.saveFailed` as the toast when the account
-   * refused. The kit does not apply it itself, so the two places can never disagree.
+   * A step: the next size down or up. The app applies it and keeps it as its
+   * Settings ▸ Appearance does — `useAccountAppearance`'s `pickTextSize` (this
+   * device, and the account when signed in), with `appearance.saveFailed` as the
+   * toast when the account refused. The kit does not apply it itself, so the two
+   * places can never disagree. `value` + `onChange`, as every kit control pairs them
+   * (CONTRIBUTING §4; refactor audit 2026-10-30, API-5). Required: 0.53 removed the
+   * deprecated `onPick`.
    */
-  onPick: (size: TextSize) => void;
+  onChange: (size: TextSize) => void;
   /** The row's name. Default: `appearance.textSize` ("Text size"). */
   label?: string;
   /** The `appearance` words (`textSize`, `textSizes`, `textSmaller`, `textLarger`). */
@@ -34,14 +37,14 @@ export interface AccountMenuTextSizeProps {
  * behind it and can step again. The size's name is a polite live region, so a step is
  * announced.
  */
-export function AccountMenuTextSize({ value, onPick, label, labels: labelsProp }: AccountMenuTextSizeProps) {
+export function AccountMenuTextSize({ value, onChange, label, labels: labelsProp }: AccountMenuTextSizeProps) {
   const labels = useAppearanceLabels(labelsProp);
   const onHtml = useTextSize().size;
   const size = value ?? onHtml;
   const index = TEXT_SIZES.indexOf(size);
   const step = (by: -1 | 1) => {
     const next = TEXT_SIZES[index + by];
-    if (next) onPick(next);
+    if (next) onChange(next);
   };
   return (
     <li data-account-menu-text-size="" className="flex items-center gap-2 px-3 py-1.5 text-sm">

package/src/shell/app-shell.tsx

@@ -201,19 +201,6 @@ export function pickMobileBar<T>(
   };
 }
 
-/**
- * Split the bar's entries into the cells shown and the ones under "More", in the app's
- * order (§10.7: the app puts its four most used first, or orders by role). One hidden
- * entry is no saving — the More cell would take its place — so the bar then shows them
- * all: the cell count is the same either way, and a real entry beats a detour.
- */
-export function splitMobileBar<T>(entries: readonly T[], max: number): { shown: T[]; hidden: T[] } {
-  // Entries before More, as 0.32 counted them; {@link pickMobileBar} counts cells.
-  const limit = Math.max(1, Math.floor(max));
-  if (entries.length <= limit + 1) return { shown: [...entries], hidden: [] };
-  return { shown: entries.slice(0, limit), hidden: entries.slice(limit) };
-}
-
 /** The bar's cell count at `size`: `mobileMaxItems`, else the default. */
 function mobileCells(maxItems: AppShellProps["mobileMaxItems"], size: TextSize): number {
   if (maxItems === undefined) return DEFAULT_MOBILE_MAX_ITEMS[size];

package/src/shell/company-switcher.tsx

@@ -56,7 +56,7 @@ export interface CompanySwitcherProps<Id extends string | number> {
  * The company switcher in the top bar (docs/auth-harmonization.md §5.3, §8): a kastlan
  * user may belong to several companies, and the access token carries the current one,
  * so switching is a request for new tokens — `onSwitch`, the app's. Built on
- * {@link OptionSwitcherMenu}, like `RoleSwitcher`: the icon trigger, the current company
+ * {@link OptionSwitcherMenu}: the icon trigger, the current company
  * in its tooltip, the list with a check on the current one.
  *
  * **Only for more than one company** — a user in one company has nothing to switch, and

package/src/shell/dev-menu.tsx

@@ -4,27 +4,13 @@ import { FlaskConical, Undo2 } from "lucide-react";
 import { DEFAULT_TOP_BAR_LABELS, useKitLabels, type LabelOverride } from "../i18n/kit-labels";
 import { TopBarActionMenu, type TopBarMenuEntry } from "./topbar-action-menu";
 import { useTopBarPartsLabels, type DevSwitchersLabels } from "./top-bar-parts-labels";
+// The kit's one storage guard, which 0.51 wrote here again by hand (DUP-8, refactor audit
+// 2026-10-30). Storage blocked, "Back to" lasts as long as this page.
+import { readSessionStored, writeSessionStored } from "../lib/safe-storage";
 
 /** Where the role the session started with is kept, unless the app names its own key. */
 export const DEV_ORIGINAL_ROLE_KEY = "ui-kit:dev-original-role";
 
-function readKey(key: string): string | null {
-  try {
-    return sessionStorage.getItem(key);
-  } catch {
-    return null;
-  }
-}
-
-function writeKey(key: string, value: string | null): void {
-  try {
-    if (value === null) sessionStorage.removeItem(key);
-    else sessionStorage.setItem(key, value);
-  } catch {
-    /* storage blocked: "Back to" lasts as long as this page */
-  }
-}
-
 /**
  * One of the app's own groups in the {@link DevMenu} (docs/top-bar-harmonization.md
  * §2.7.1): keksdose's budget role, its "today" override, its resets.
@@ -109,7 +95,7 @@ const isRow = (entry: TopBarMenuEntry) => entry.kind !== "heading" && entry.kind
 
 /**
  * The top bar's local-dev menu (docs/top-bar-harmonization.md §2.7, §2.7.1, §6.2, §6.3):
- * ONE amber flask, `RoleSwitcher`'s, over the kit's Account section and the app's own.
+ * ONE amber flask over the kit's Account section and the app's own.
  *
  * 0.42's `DevSwitchers` drew a flask per switcher and had no place for anything else,
  * and an app has more dev controls than a role and a plan — keksdose's budget role, a
@@ -151,14 +137,14 @@ export function DevMenu<R extends string, P extends string>({
 }: DevMenuProps<R, P>) {
   const bar = useKitLabels("topBar", DEFAULT_TOP_BAR_LABELS);
   const words = useTopBarPartsLabels(labelsProp ? { dev: labelsProp } : undefined).dev;
-  const [kept, setKept] = useState<string | null>(() => (enabled ? readKey(storageKey) : null));
+  const [kept, setKept] = useState<string | null>(() => (enabled ? readSessionStored(storageKey) : null));
   // 0.43 (keksdose): `enabled` may start false and turn true — an app's GET probe of the
   // dev route — so the kept role is read again then, or "Back to {role}" is lost after a
   // reload. Adjusted during render, React's pattern for state that follows a prop.
   const [wasEnabled, setWasEnabled] = useState(enabled);
   if (wasEnabled !== enabled) {
     setWasEnabled(enabled);
-    if (enabled) setKept(readKey(storageKey));
+    if (enabled) setKept(readSessionStored(storageKey));
   }
   if (!enabled) return null;
 
@@ -168,10 +154,10 @@ export function DevMenu<R extends string, P extends string>({
     if (originalRole === undefined) {
       if (next === original) {
         // Back where the session began: nothing left to go back to.
-        writeKey(storageKey, null);
+        writeSessionStored(storageKey, null);
         setKept(null);
       } else if (kept === null && role !== undefined && next !== role) {
-        writeKey(storageKey, role);
+        writeSessionStored(storageKey, role);
         setKept(role);
       }
     }

package/src/shell/top-bar-actions.tsx

@@ -23,7 +23,7 @@ export interface TopBarActionsProps {
   /** `DevMenu` (0.51, docs/top-bar-harmonization.md §2.7.1): the one flask — the role,
    *  the plan, then the app's own dev sections. Fill it only behind
    *  `import.meta.env.DEV`, so a production build drops the branch. (0.42's
-   *  `DevSwitchers`, deprecated, is a DevMenu with no sections.) */
+   *  `DevSwitchers` was a DevMenu with no sections; removed in 0.52.) */
   dev?: ReactNode;
   /** kastlan's platform button. */
   platform?: ReactNode;

package/src/shell/top-bar-parts-labels.ts

@@ -6,7 +6,7 @@ import { useKitLabels, type LabelOverride } from "../i18n/kit-labels";
  * `DevSwitchers`, whose words these still are, §2.7.1). A module
  * of words with no component code, like every `*-labels.ts` (0.34, KS U8). The language
  * sub-list (`AccountMenuLanguage`) names itself with `topBar.language`, and the role in the
- * dev flask's name is `topBar.role`, as `RoleSwitcher`'s tooltip.
+ * dev flask's name is `topBar.role`.
  */
 
 /** `TourMenu`'s words (§2.4). */
@@ -82,8 +82,6 @@ export interface DevSwitchersLabels {
   overridesOn: string;
   /** The heading of the role group. */
   roleHeading: string;
-  /** @deprecated 0.51 — DevMenu's one flask is named by `menu`; removed in 0.52. */
-  switchPlan: string;
   /** The plan in the flask's name, given the active plan. */
   plan: (value: string) => string;
   /** The heading of the plan group. */
@@ -137,7 +135,6 @@ export const DEFAULT_TOP_BAR_PARTS_LABELS: TopBarPartsLabels = {
     menu: "Dev tools",
     overridesOn: "Overrides on",
     roleHeading: "Dev · role",
-    switchPlan: "Switch plan",
     plan: (value) => `Plan: ${value}`,
     planHeading: "Dev · plan",
     backTo: (role) => `Back to ${role}`,

package/src/shell.ts

@@ -4,9 +4,20 @@
 // `react-router`: AppShell renders NavLink and TopBarActionMenu renders Link.
 export * from "./shell/topbar-controls";
 export * from "./shell/top-bar";
-export * from "./shell/app-shell";
+// Named, not `*`: 0.53 took `pickMobileBar` off the surface (deprecated in 0.52, refactor
+// audit 2026-10-30, API-4) — AppShell's own — and removed `splitMobileBar`, which nothing
+// called any more.
+export {
+  DEFAULT_APP_SHELL_MORE_LABELS,
+  DEFAULT_MOBILE_MAX_ITEMS,
+  AppShell,
+  type AppShellSubItem,
+  type AppShellNavItem,
+  type AppShellSidebarFooterItem,
+  type AppShellMoreLabels,
+  type AppShellProps,
+} from "./shell/app-shell";
 export * from "./shell/option-switcher-menu";
-export * from "./shell/role-switcher";
 export * from "./shell/topbar-action-menu";
 export * from "./shell/top-bar-brand";
 export * from "./shell/auth-layout";
@@ -25,14 +36,9 @@ export type { UseAdminMenuEntryOptions } from "./shell/admin-menu";
 export { AdminWaitingBadge } from "./shell/admin-menu";
 export type { AdminWaitingBadgeProps } from "./shell/admin-menu";
 // 0.31.0: the settings and admin pages' shell (docs/settings-harmonization.md §3, §5).
-export { SettingsLayout, SETTINGS_SEARCH_THRESHOLD } from "./settings/settings-layout";
+export { SettingsLayout } from "./settings/settings-layout";
 export type { SettingsLayoutProps, SettingsLayoutWidth, SettingsDocumentTitleParts } from "./settings/settings-layout";
-export {
-  useSettingsRoute,
-  resolveSettingsLocation,
-  settingsFromListState,
-  SETTINGS_FROM_LIST_STATE,
-} from "./settings/use-settings-route";
+export { useSettingsRoute, settingsFromListState } from "./settings/use-settings-route";
 export type {
   UseSettingsRouteOptions,
   SettingsRoute,
@@ -41,7 +47,7 @@ export type {
   SettingsLocationRules,
   SettingsLocationResult,
 } from "./settings/use-settings-route";
-export { useSettingsFocus, useFocusParam, SETTINGS_FOCUS_RING, SETTINGS_FOCUS_MS } from "./settings/use-settings-focus";
+export { useSettingsFocus, useFocusParam } from "./settings/use-settings-focus";
 export { SettingsSection } from "./settings/settings-section";
 export type { SettingsSectionProps } from "./settings/settings-section";
 export { useSettingsLayout } from "./settings/settings-context";
@@ -77,8 +83,8 @@ export { PublicHeader } from "./landing/public-header";
 export type { PublicHeaderProps, PublicHeaderBrand } from "./landing/public-header";
 // 0.42.0: the top bar's shared parts (docs/top-bar-harmonization.md §3.1) — the slots in
 // §2.1's order, the account menu's language sub-list, the tours menu, the sync status, the
-// local-dev switchers, and their words.
-export { TopBarActions, TOP_BAR_ACTION_ORDER } from "./shell/top-bar-actions";
+// local-dev menu, and their words.
+export { TopBarActions } from "./shell/top-bar-actions";
 export type { TopBarActionsProps } from "./shell/top-bar-actions";
 export { AccountMenuLanguage } from "./shell/account-menu-language";
 export type { AccountMenuLanguageProps, AccountMenuLanguageOption } from "./shell/account-menu-language";
@@ -87,14 +93,12 @@ export { AccountMenuTextSize } from "./shell/account-menu-text-size";
 export type { AccountMenuTextSizeProps } from "./shell/account-menu-text-size";
 export { TourMenu } from "./shell/tour-menu";
 export type { TourMenuProps, TourMenuTour } from "./shell/tour-menu";
-export { SyncStatusIndicator, syncState } from "./shell/sync-status-indicator";
+export { SyncStatusIndicator } from "./shell/sync-status-indicator";
 export type { SyncStatus, SyncState, SyncStatusScope, SyncStatusIndicatorProps } from "./shell/sync-status-indicator";
 // 0.51 (§2.7.1, keksdose): one flask, the kit's Account section and the app's own dev
-// sections; `DevSwitchers` is a deprecated wrapper over it until 0.52.
-export { DevMenu, DEV_ORIGINAL_ROLE_KEY } from "./shell/dev-menu";
+// sections. 0.42's `DevSwitchers`, a DevMenu with no sections since 0.51, went in 0.52.
+export { DevMenu } from "./shell/dev-menu";
 export type { DevMenuProps, DevMenuSection } from "./shell/dev-menu";
-export { DevSwitchers } from "./shell/dev-switchers";
-export type { DevSwitchersProps } from "./shell/dev-switchers";
 export { DEFAULT_TOP_BAR_PARTS_LABELS, useTopBarPartsLabels } from "./shell/top-bar-parts-labels";
 export type {
   TopBarPartsLabels,