@eifi1/ui-kit 0.51.7 → 0.52.0

package/src/feedback/feedback-table.tsx

@@ -1,12 +1,14 @@
-import { useMemo } from "react";
+import { useCallback, useMemo } from "react";
 import type { MouseEvent, ReactElement, ReactNode } from "react";
 import { ExternalLink, ThumbsUp } from "lucide-react";
 import { cn } from "../lib/cn";
-import { toLocalIso } from "../lib/dates";
-import { EMPTY_FORMATTED_VALUE, formatDate, toDate } from "../lib/format";
-import { useKitDateFormatter, useKitLabels, useKitLink, useKitLocale, type LabelOverride } from "../i18n/kit-labels";
+import { useDayFormatter } from "../lib/day-format";
+import { EMPTY_FORMATTED_VALUE } from "../lib/format";
+import { useKitLabels, useKitLink, type LabelOverride } from "../i18n/kit-labels";
 import type { KitLinkProps } from "../i18n/kit-labels";
+import type { PathPattern } from "../landing/routing";
 import { Chip } from "../components/chip";
+import { CopyButton } from "../components/copy-button";
 import { Tooltip } from "../components/tooltip";
 import { FloatingAction, FloatingActionGroup } from "../components/floating-panel";
 import type { FloatingCorner } from "../components/floating-panel";
@@ -36,7 +38,8 @@ import {
   type FeedbackRecord,
 } from "./feedback-record";
 import type { FeedbackStatusChange } from "./feedback-status-undo";
-import { feedbackPageHref, feedbackPagePath } from "./feedback-row-detail";
+import { feedbackPagePath, useFeedbackDetailLabels } from "./feedback-row-detail";
+import { feedbackPage, feedbackPageLinkTarget } from "./feedback-page-link";
 import type { CommitScope } from "../components/write-lock";
 import { DEFAULT_FEEDBACK_PAGE_LABELS } from "./feedback-table-labels";
 import { DEFAULT_FEEDBACK_PUBLIC_LABELS } from "./feedback-public-labels";
@@ -235,25 +238,16 @@ const FEEDBACK_DATE_STYLE: Intl.DateTimeFormatOptions = {
 };
 
 /**
- * `renderDate` when the app gave one, else the kit's: the `<UiKitProvider formatDate>`
- * when the app set one (called with the LOCAL calendar day and `weekday: true`, as
- * `DateMark` calls it), else `Intl` in the provider's locale with the weekday. An
- * unparseable value is passed through rather than hidden.
+ * `renderDate` when the app gave one (and it answers), else the kit's: the
+ * `<UiKitProvider formatDate>` when the app set one (called with the calendar day and
+ * `weekday: true`, as `DateMark` calls it), else `Intl` in the provider's locale and
+ * (0.52) time zone, with the weekday. An unparseable value is passed through rather than
+ * hidden. The kit's one day ladder since 0.52 (refactor audit 2026-10-30, DUP-2), which
+ * every date a kit component prints goes down.
  */
 export function useFeedbackRenderDate(renderDate?: FeedbackRenderDate, locale?: string): FeedbackRenderDate {
-  const kitLocale = useKitLocale(locale);
-  const fromProvider = useKitDateFormatter();
-  return useMemo<FeedbackRenderDate>(() => {
-    if (renderDate) return renderDate;
-    return (iso) => {
-      const date = toDate(iso);
-      if (!date) return iso || EMPTY_FORMATTED_VALUE;
-      const own = fromProvider
-        ? fromProvider(toLocalIso(date), { unit: "day", source: "dateMark", locale: kitLocale, weekday: true })
-        : "";
-      return own || formatDate(date, FEEDBACK_DATE_STYLE, { locale: kitLocale });
-    };
-  }, [renderDate, fromProvider, kitLocale]);
+  const day = useDayFormatter<string>(renderDate, locale);
+  return useCallback<FeedbackRenderDate>((iso) => day(iso, { weekday: true, style: FEEDBACK_DATE_STYLE }), [day]);
 }
 
 /** A date in a cell: `<time>`, nowrap, tabular figures; "—" when there is none. */
@@ -339,29 +333,44 @@ export function FeedbackSubject({ row, wrap = false, labels: labelsProp, classNa
 
 /**
  * The page a report was filed from, as a link — the cell keksdose's column 7 draws
- * (:850): the path as text, path + query + hash as the `href`, read from `context.url`
- * else `context.route` by the row detail's own readers (`feedbackPagePath` /
- * `feedbackPageHref`, feedback-row-detail.tsx), so the column and the detail link the
- * same page the same way. A real link through the `<UiKitProvider linkComponent>` (the app's router, so it
- * does not reload the app; keksdose's plain `<a>` did), and its click stops at the cell so
- * the row does not open as well.
+ * (:850): the path as text and as the `href`, read from `context.url` else
+ * `context.route` by the row detail's own reader (`feedbackPage`, feedback-page-link.ts),
+ * so the column and the detail link the same page the same way. A real link through the
+ * `<UiKitProvider linkComponent>` (the app's router, so it does not reload the app;
+ * keksdose's plain `<a>` did), and its click stops at the cell so the row does not open
+ * as well.
  *
  * Its name is the path, as on screen, with "Open page" said before it — keksdose's
  * `aria-label="Open page"` replaced the path, so a screen reader heard forty identical
  * links down the column.
+ *
+ * The PATH alone (0.52 code review, feedback-page-link.ts): the query is the reporter's to
+ * write, and `/login?next=%2Fjoin%3Ftoken%3D…` forwarded the admin's click to an
+ * invitation. A one-shot route — `/join`, `/register`, `/verify-email`, `/reset-password`
+ * and the app's `pageLinkExclude` — is the path as text with Copy, never a link (0.52,
+ * refactor audit 2026-10-30, FLW-7): those routes act on load.
  */
-function FeedbackPageLinkCell({ context, openPage }: { context: FeedbackContext | null; openPage: string }) {
+function FeedbackPageLinkCell({
+  context,
+  openPage,
+  exclude,
+}: {
+  context: FeedbackContext | null;
+  openPage: string;
+  exclude: readonly PathPattern[] | undefined;
+}) {
   const kitLink = useKitLink();
-  const href = feedbackPageHref(context);
-  const path = feedbackPagePath(context);
-  if (!href || !path) return <span className="text-placeholder">{EMPTY_FORMATTED_VALUE}</span>;
+  const page = feedbackPage(context);
+  if (!page) return <span className="text-placeholder">{EMPTY_FORMATTED_VALUE}</span>;
+  const href = feedbackPageLinkTarget(page, exclude);
+  if (!href) return <FeedbackPageText path={page.path} url={page.url} />;
   const className =
     "inline-flex min-w-0 max-w-full items-center gap-1 text-secondary hover:text-primary hover:underline";
   const children = (
     <>
       {/* The space outside the hidden span: a flex container drops it from the layout,
           and the accessible name keeps it ("Open page /accounts"). */}
-      <span className="sr-only">{openPage}</span> <code className="min-w-0 truncate text-xs">{path}</code>
+      <span className="sr-only">{openPage}</span> <code className="min-w-0 truncate text-xs">{page.path}</code>
       <ExternalLink className="size-3 shrink-0" aria-hidden />
     </>
   );
@@ -378,6 +387,19 @@ function FeedbackPageLinkCell({ context, openPage }: { context: FeedbackContext
   );
 }
 
+/** A one-shot page in the URL column: its path to read, and Copy. A component of its own
+ *  so only such a row resolves the `feedbackDetail` words — every cell of a 270-row inbox
+ *  did, for a button only a one-shot row shows (0.52 code review, efficiency). */
+function FeedbackPageText({ path, url }: { path: string; url: string }) {
+  const { copyUrl } = useFeedbackDetailLabels();
+  return (
+    <span className="inline-flex min-w-0 max-w-full items-center gap-1 text-secondary" data-feedback-page-unlinked="">
+      <code className="min-w-0 truncate text-xs">{path}</code>
+      <CopyButton size="xs" className="shrink-0" text={url} label={copyUrl} stopPropagation />
+    </span>
+  );
+}
+
 /** The provider's link, drawn by a component declared once (as FloatingAction's). */
 function RenderedLink({ render, ...props }: KitLinkProps & { render: (props: KitLinkProps) => ReactElement }) {
   return render(props);
@@ -395,8 +417,8 @@ export interface FeedbackColumnsOptions {
   /** The admin on `/feedback` — the status cell offers its steps. Otherwise it shows them
    *  read-only. */
   canEdit: boolean;
-  /** The undoable status change, `useFeedbackStatusUndo(update.mutate)` (§4.5) — the
-   *  same one the row detail and the swipes use. */
+  /** The undoable status change, `useFeedbackStatusUndo(update.mutateAsync)` (§4.5) —
+   *  the same one the row detail and the swipes use. */
   onStatus: FeedbackStatusChange;
   /** See {@link FeedbackRenderDate}. */
   renderDate: FeedbackRenderDate;
@@ -414,6 +436,15 @@ export interface FeedbackColumnsOptions {
   /** The Votes header — `feedbackPublic.columnVotes`, so the inbox and the public list
    *  say the same ({@link useFeedbackColumns} reads it). Default "Votes". */
   votesHeader?: string;
+  /**
+   * 0.52 (FLW-7): the app's one-shot routes, ON TOP of the kit's — `/join`, `/register`,
+   * `/verify-email`, `/reset-password` (a string is that path and everything under it, a
+   * RegExp is tested on the path, as `useLastVisitedPage`'s `exclude`). The URL cell
+   * shows such a page as text with Copy, never as a link; any other page links its path
+   * alone. Keep it stable (module scope): it is a dependency of {@link useFeedbackColumns}'
+   * memo.
+   */
+  pageLinkExclude?: readonly PathPattern[];
 }
 
 /** The vote count, a quiet chip with the thumb (§9.6) — the Votes cell and the card's. */
@@ -479,6 +510,7 @@ export function feedbackColumns<T extends FeedbackTableRow>({
   categoryLabels,
   votes = false,
   votesHeader = DEFAULT_FEEDBACK_PUBLIC_LABELS.columnVotes,
+  pageLinkExclude,
 }: FeedbackColumnsOptions): DataTableColumn<T>[] {
   const editable = canEdit && !mine;
   const votesColumn: DataTableColumn<T>[] = votes
@@ -608,7 +640,9 @@ export function feedbackColumns<T extends FeedbackTableRow>({
       // The cell IS a link, so the row's own permalink must never wrap it (keksdose
       // feedback #451: <a> in <a>, and "open the page" silently did nothing).
       noRowLink: true,
-      cell: (row) => <FeedbackPageLinkCell context={row.context} openPage={labels.openPage} />,
+      cell: (row) => (
+        <FeedbackPageLinkCell context={row.context} openPage={labels.openPage} exclude={pageLinkExclude} />
+      ),
       sortBy: (row) => feedbackPagePath(row.context) ?? "",
       filterBy: (row) => feedbackPagePath(row.context) ?? "",
       mobileHidden: true,
@@ -670,7 +704,7 @@ export interface UseFeedbackColumnsOptions extends Omit<
 /**
  * {@link feedbackColumns} with the `feedbackPage`, `feedbackStatus` and
  * `feedbackCategory` words from the provider, memoised on what it reads — pass
- * `update.mutate` through `useFeedbackStatusUndo` (stable) rather than a fresh function
+ * `update.mutateAsync` through `useFeedbackStatusUndo` (stable) rather than a fresh function
  * per render, or every row's columns are rebuilt on each render (keksdose :667).
  */
 export function useFeedbackColumns<T extends FeedbackTableRow>({
@@ -680,6 +714,7 @@ export function useFeedbackColumns<T extends FeedbackTableRow>({
   renderDate: renderDateProp,
   commit,
   votes,
+  pageLinkExclude,
   labels: labelsProp,
 }: UseFeedbackColumnsOptions): DataTableColumn<T>[] {
   const labels = useFeedbackPageLabels(labelsProp);
@@ -700,8 +735,21 @@ export function useFeedbackColumns<T extends FeedbackTableRow>({
         categoryLabels,
         votes,
         votesHeader,
+        pageLinkExclude,
       }),
-    [mine, canEdit, onStatus, renderDate, commit, labels, statusLabels, categoryLabels, votes, votesHeader],
+    [
+      mine,
+      canEdit,
+      onStatus,
+      renderDate,
+      commit,
+      labels,
+      statusLabels,
+      categoryLabels,
+      votes,
+      votesHeader,
+      pageLinkExclude,
+    ],
   );
 }
 

package/src/feedback/feedback-thread-labels.ts

@@ -2,7 +2,7 @@
 // catalogue (src/i18n/defaults.ts) imports them without the component, so `en` loads as one
 // chunk like the other languages (0.34, KS U8). ./feedback-thread re-exports them.
 
-import type { FeedbackComposerLabels, FeedbackThreadLabels } from "./feedback-thread";
+import type { ChatComposerLabels, FeedbackThreadLabels } from "./feedback-thread";
 
 export const DEFAULT_FEEDBACK_THREAD_LABELS: FeedbackThreadLabels = {
   thread: "Comments",
@@ -13,7 +13,7 @@ export const DEFAULT_FEEDBACK_THREAD_LABELS: FeedbackThreadLabels = {
   attachments: "Attachments",
 };
 
-export const DEFAULT_FEEDBACK_COMPOSER_LABELS: FeedbackComposerLabels = {
+export const DEFAULT_FEEDBACK_COMPOSER_LABELS: ChatComposerLabels = {
   field: "Write a comment",
   placeholder: "Write a comment…",
   send: "Send",

package/src/feedback/feedback-thread.tsx

@@ -3,6 +3,7 @@ import type { ReactNode, Ref, RefObject } from "react";
 import { ImageIcon, ImageOff, Paperclip, Send } from "lucide-react";
 import { cn } from "../lib/cn";
 import { formatDate, formatRelativeTime } from "../lib/format";
+import { upperFirst } from "../lib/text-case";
 import { hasContent } from "../lib/presence";
 import { Button } from "../components/button";
 import { EmptyState } from "../components/empty-state";
@@ -74,7 +75,7 @@ export { DEFAULT_FEEDBACK_THREAD_LABELS };
 
 /** The `feedbackComposer` namespace of `<UiKitProvider labels>`. The attach buttons'
  *  words are `feedbackAttachment`'s, shared with the dialog and the note editor. */
-export interface FeedbackComposerLabels {
+export interface ChatComposerLabels {
   /** Accessible name of the text box. */
   field: string;
   placeholder: string;
@@ -436,7 +437,7 @@ function DaySeparator({ date, now, locale }: { date: Date; now: number; locale:
   let label: string;
   if (days === 0 || days === -1) {
     const word = new Intl.RelativeTimeFormat(locale, { numeric: "auto" }).format(days + 0, "day");
-    label = word.charAt(0).toLocaleUpperCase(locale) + word.slice(1);
+    label = upperFirst(word, locale);
   } else {
     label = formatDate(
       date,
@@ -482,7 +483,7 @@ export type FeedbackComposerAttachment = Omit<FeedbackNoteAttachment, "labels" |
 } & Pick<FeedbackAttachmentFieldSingleProps, "buttonVariant" | "buttonSize">;
 
 /**
- * What a render-prop {@link FeedbackComposerProps.attachmentSlot} is handed (0.24.0,
+ * What a render-prop {@link ChatComposerProps.attachmentSlot} is handed (0.24.0,
  * keksdose).
  *
  * keksdose's support chat put `<FeedbackAttachmentField refs>` in the slot and a
@@ -492,7 +493,7 @@ export type FeedbackComposerAttachment = Omit<FeedbackNoteAttachment, "labels" |
  * to itself, so keksdose wrapped the whole composer in a ref'd `<div>` of its own just
  * to have an element to hand over.
  */
-export interface FeedbackComposerSlotContext {
+export interface ChatComposerSlotContext {
   /**
    * The composer's root, round the text box and this slot — the field's `pasteFrom`,
    * as it is: `pasteFrom={slot.root}`.
@@ -514,7 +515,7 @@ export interface FeedbackComposerSlotContext {
   pending: boolean;
 }
 
-export interface FeedbackComposerProps {
+export interface ChatComposerProps {
   /**
    * Send the comment. Return the promise: the box clears when it RESOLVES, and only of
    * what was sent — text typed while it was in flight stays. A rejection keeps
@@ -538,7 +539,7 @@ export interface FeedbackComposerProps {
    * refs and clearing them once `onSend` resolves stay with the host. Pair it with
    * `canSend`.
    *
-   * A node, or (0.24.0) a function of {@link FeedbackComposerSlotContext} that returns
+   * A node, or (0.24.0) a function of {@link ChatComposerSlotContext} that returns
    * one — for a field that wants the composer's root as its `pasteFrom`, so a
    * screenshot pasted into the box reaches it, and `pending` for its `disabled`:
    *
@@ -551,7 +552,7 @@ export interface FeedbackComposerProps {
    * Called once per render of the composer, and not at all while `disabledReason`
    * stands in for it.
    */
-  attachmentSlot?: ReactNode | ((slot: FeedbackComposerSlotContext) => ReactNode);
+  attachmentSlot?: ReactNode | ((slot: ChatComposerSlotContext) => ReactNode);
   /**
    * Whether Send is enabled, over the composer's own rule (some text in the box) —
    * for state the composer cannot see, i.e. `attachmentSlot`'s (keksdose G5): `true`
@@ -592,7 +593,7 @@ export interface FeedbackComposerProps {
    * Textarea's `maxLength` + `showCount` since 0.22; the reply box, a composer, could
    * not). The box's own `maxLength`, so typing and pasting stop at it.
    *
-   * {@link FeedbackComposerHandle.insertText} is not stopped by it — the browser limits
+   * {@link ChatComposerHandle.insertText} is not stopped by it — the browser limits
    * typing, not a script — and a canned reply is not cut mid-sentence to fit. A draft
    * past the limit therefore holds Send back (whatever `canSend` says, as `pending`
    * does) until it is trimmed; with `showCount` the counter, red at the limit, says by
@@ -623,13 +624,13 @@ export interface FeedbackComposerProps {
    * is still the one that went out.
    */
   value?: string;
-  /** Every change to the draft — typing, {@link FeedbackComposerHandle.insertText}, the
+  /** Every change to the draft — typing, {@link ChatComposerHandle.insertText}, the
    *  clear after a send. Required to change a controlled `value`. */
   onValueChange?: (value: string) => void;
-  /** {@link FeedbackComposerHandle}: put text into the draft from outside (canned-reply
+  /** {@link ChatComposerHandle}: put text into the draft from outside (canned-reply
    *  chips) or focus the box. */
-  ref?: Ref<FeedbackComposerHandle>;
-  labels?: LabelOverride<FeedbackComposerLabels>;
+  ref?: Ref<ChatComposerHandle>;
+  labels?: LabelOverride<ChatComposerLabels>;
   className?: string;
   /**
    * `"sm"` for a narrow host — keksdose's assistant launcher, a small floating panel
@@ -659,7 +660,7 @@ export interface FeedbackComposerProps {
  * the string, not the caret, so it could only append — so the composer, which owns
  * the textarea, does the splice.
  */
-export interface FeedbackComposerHandle {
+export interface ChatComposerHandle {
   /**
    * Insert `text` at the caret, replacing any selection (the caret the box last had:
    * a click on a chip blurs it, and the selection survives the blur), then focus the
@@ -685,7 +686,8 @@ const isApple = () =>
  * feedback-specific — a textarea, an optional picture or a host's upload slot, Send,
  * `sendOn="enter"` for the chat way — and keksdose's assistant and support chat are
  * chats, not reports. `FeedbackComposer`, its old name, was removed in 0.35 (refactor
- * audit 2026-10, API-6d; deprecated in 0.34); its types keep theirs.
+ * audit 2026-10, API-6d; deprecated in 0.34); its types are `ChatComposer*` too since 0.52
+ * (refactor audit 2026-10-30, API-6), the `FeedbackComposer*` names deprecated aliases.
  */
 export function ChatComposer({
   onSend,
@@ -709,7 +711,7 @@ export function ChatComposer({
   id,
   size = "md",
   ...rest
-}: FeedbackComposerProps) {
+}: ChatComposerProps) {
   const labels = useKitLabels("feedbackComposer", DEFAULT_FEEDBACK_COMPOSER_LABELS, labelsProp);
   // The lock as Send sees it, with its scope (§12.36). Send's Button reads the same
   // through its own `commit`; this holds the keyboard's send back with it.
@@ -797,7 +799,7 @@ export function ChatComposer({
   const config = attachment === true ? {} : attachment || null;
   // The slot is handed the ref OBJECT, for a field's `pasteFrom`, which reads `.current`
   // in an effect once the root is attached — nothing reads it during this render (see
-  // FeedbackComposerSlotContext.root).
+  // ChatComposerSlotContext.root).
   const slot =
     typeof attachmentSlot === "function"
       ? // eslint-disable-next-line react-hooks/refs -- handed on for an effect, not read here
@@ -902,12 +904,12 @@ function dataAttributes(props: object): Record<string, unknown> {
   return out;
 }
 
-/** {@link FeedbackComposerProps}, for {@link ChatComposer}. */
-export type ChatComposerProps = FeedbackComposerProps;
-/** {@link FeedbackComposerHandle}, for {@link ChatComposer}. */
-export type ChatComposerHandle = FeedbackComposerHandle;
-/** {@link FeedbackComposerLabels}, for {@link ChatComposer} — still the `feedbackComposer`
- *  namespace of the provider. */
-export type ChatComposerLabels = FeedbackComposerLabels;
-/** {@link FeedbackComposerSlotContext}, for {@link ChatComposer}'s `attachmentSlot`. */
-export type ChatComposerSlotContext = FeedbackComposerSlotContext;
+/** @deprecated 0.52 — {@link ChatComposerProps}, the same type; removed in 0.53 */
+export type FeedbackComposerProps = ChatComposerProps;
+/** @deprecated 0.52 — {@link ChatComposerHandle}, the same type; removed in 0.53 */
+export type FeedbackComposerHandle = ChatComposerHandle;
+/** @deprecated 0.52 — {@link ChatComposerLabels}, the same type (still the provider's
+ *  `feedbackComposer` namespace); removed in 0.53 */
+export type FeedbackComposerLabels = ChatComposerLabels;
+/** @deprecated 0.52 — {@link ChatComposerSlotContext}, the same type; removed in 0.53 */
+export type FeedbackComposerSlotContext = ChatComposerSlotContext;

package/src/feedback.ts

@@ -31,3 +31,45 @@ export * from "./feedback/feedback-vote-button";
 export * from "./feedback/feedback-comment-thread";
 export * from "./feedback/feedback-replies";
 export * from "./feedback/feedback-entry-file";
+// 0.52: the slice's share of the 55 names no app reads (refactor audit 2026-10-30, API-4,
+// decision 4), tagged on their specifiers as the barrel's are — the modules keep them.
+export {
+  /** @deprecated 0.52 — `appendRework`, which writes the line (API-4); removed in 0.53 */
+  feedbackAttachmentLine,
+} from "./feedback/feedback-record";
+export {
+  /** @deprecated 0.52 — `useFeedbackStatusUndo`, which keeps its Undo that long (API-4); removed in 0.53 */
+  FEEDBACK_UNDO_DURATION,
+} from "./feedback/feedback-status-undo";
+export {
+  /** @deprecated 0.52 — `DEFAULT_FEEDBACK_SWIPE` and `feedbackSwipePlan`, which name the actions (API-4); removed in 0.53 */
+  FEEDBACK_SWIPE_ACTIONS,
+} from "./feedback/feedback-swipe";
+export {
+  /** @deprecated 0.52 — `useFeedbackColumns`, the same columns in the provider's words (API-4); removed in 0.53 */
+  feedbackColumns,
+  /** @deprecated 0.52 — `useFeedbackColumns`, whose submitter cell reads it (API-4); removed in 0.53 */
+  feedbackSubmitter,
+  /** @deprecated 0.52 — `useFeedbackColumns`, whose submitter cell reads it (API-4); removed in 0.53 */
+  feedbackSubmitterEmail,
+  /** @deprecated 0.52 — `useFeedbackColumns`, whose environment cell reads it (API-4); removed in 0.53 */
+  feedbackEnvironment,
+} from "./feedback/feedback-table";
+export {
+  /** @deprecated 0.52 — `FeedbackRowDetail`, which links the page itself (API-4); removed in 0.53 */
+  feedbackPageUrl,
+  /** @deprecated 0.52 — `FeedbackRowDetail` and the table's URL cell, which link only a page's path and keep one-shot pages as text (the 0.52 code review's guard, which an app has no helper for); removed in 0.53 */
+  feedbackPageHref,
+  /** @deprecated 0.52 — `FeedbackRowDetail` and the table's URL cell, which show the page themselves; removed in 0.53 */
+  feedbackPagePath,
+  /** @deprecated 0.52 — `FeedbackRowDetail`, which lists the attachments itself (API-4); removed in 0.53 */
+  feedbackAttachmentUrls,
+  /** @deprecated 0.52 — `FeedbackRowDetail`, which decides who may edit what (API-4); removed in 0.53 */
+  feedbackRowAccess,
+  /** @deprecated 0.52 — `FeedbackRowDetail`, which resolves its words itself (API-4); removed in 0.53 */
+  useFeedbackDetailLabels,
+} from "./feedback/feedback-row-detail";
+export {
+  /** @deprecated 0.52 — `FeedbackPublicSwitch`, which asks it (API-4); removed in 0.53 */
+  feedbackPublicSwitchAllowed,
+} from "./feedback/feedback-public-switch";

package/src/hooks/use-focus-trap.ts

@@ -1,4 +1,5 @@
 import { useEffect, useLayoutEffect, useRef, useState } from "react";
+import { tabStops } from "../lib/focus-left";
 
 /**
  * Keep keyboard focus inside an open overlay, and give it back when it closes.
@@ -35,28 +36,11 @@ import { useEffect, useLayoutEffect, useRef, useState } from "react";
  *     button; this is the focus half of it.
  */
 
-/**
- * Candidate tab stops, in DOM order — narrowed by {@link isTabStop} to the ones a Tab
- * really reaches.
- *
- * The selector is the one `Modal` used. On its own it was not enough (round 0.34
- * BUG-4): only the bare `[tabindex]` clause excluded `-1`, so a `button`, an `input` or
- * a link taken out of the tab order still counted. A panel that ends in a roving grid —
- * the calendar's days, the month grid, the picker sheet's rows, every one of them `-1`
- * but the active cell — then had a "last" stop no Tab ever reaches: Tab from the real
- * last stop was not wrapped and walked out of the open panel, and Shift+Tab from the
- * first landed on a cell that is not a stop at all.
- */
-const FOCUSABLE =
-  'a[href],button:not([disabled]),textarea:not([disabled]),input:not([disabled]),select:not([disabled]),[tabindex]:not([tabindex="-1"])';
-
-/**
- * A stop the browser's own Tab would land on: in the tab order (`tabIndex` ≥ 0) and not
- * inside something `hidden` or `inert`. Removes only elements a native Tab never
- * reaches, so no correct order changes. `visibility: hidden` and closed `<details>` are
- * still not walked — they need layout, which this list has never read.
- */
-const isTabStop = (el: HTMLElement): boolean => el.tabIndex >= 0 && !el.closest("[hidden],[inert]");
+// The trap's reading of "a Tab lands here" is lib/focus-left's `tabStops` — the kit's one
+// copy of the rule since the 0.52 code review (round 0.34 BUG-4's history is there).
+// Re-exported where refactor audit 2026-10-30, DUP-9 put them, for a part that walks Tab
+// over something that is not a trap (the tour's field + card ring).
+export { firstTabStop, tabStops } from "../lib/focus-left";
 
 /**
  * Marks a container whose trap is currently active.
@@ -146,11 +130,11 @@ export function useFocusTrap(
     };
 
     const tabbables = () =>
-      Array.from(container.querySelectorAll<HTMLElement>(FOCUSABLE)).filter(
+      tabStops(container, { includeSelf: false }).filter(
         // A tabbable inside a NESTED open overlay belongs to that overlay's trap, not
         // to this one — otherwise the outer list spans both panels and Tab from the
         // inner panel's last control wraps to the OUTER panel's first.
-        (el) => isTabStop(el) && !inNestedTrap(el),
+        (el) => !inNestedTrap(el),
       );
 
     const { initialFocus: how } = optsRef.current;

package/src/hooks/use-hotkey.ts

@@ -94,18 +94,28 @@ const KEY_ALIASES: Record<string, string> = {
   right: "arrowright",
 };
 
+/** One letter of a script other than Latin: what a Russian, Greek or Hebrew layout's letter keys type. */
+const NON_LATIN_LETTER = /^(?!\p{Script=Latin})\p{L}$/u;
+
 /** Whether `e` is `combo` — every modifier as named (no more, no fewer), and the key. */
 export function matchesHotkey(e: KeyboardEvent, combo: ParsedHotkey): boolean {
   if (e.ctrlKey !== combo.ctrl || e.metaKey !== combo.meta || e.altKey !== combo.alt) return false;
   const want = KEY_ALIASES[combo.key.toLowerCase()] ?? combo.key.toLowerCase();
   const key = (e.key ?? "").toLowerCase();
   const code = (e.code ?? "").toLowerCase();
-  const keyMatches = key === want || code === want;
-  if (!keyMatches) return false;
+  // On a non-Latin layout `key` is the local letter — Ctrl+K types "л" on a Russian one —
+  // so a letter chord never fired there, ⌘K included (0.52 code review, use-hotkey.ts; the
+  // hand-written ⌘K listener before 0.52 compared `key` alone and missed it too). The
+  // physical key stands in for the letter there, and only there: a Latin layout's letter
+  // is wherever it types (Dvorak's K is on QWERTY's V).
+  const physical = /^[a-z]$/.test(want) && NON_LATIN_LETTER.test(e.key ?? "") && code === `key${want}`;
+  if (key !== want && code !== want && !physical) return false;
   // Shift must match exactly for a letter or a named key; for a symbol it is how the
   // symbol is typed ("?" is Shift+/ on a US layout, a plain key on others), so an
-  // unnamed Shift is not held against it.
-  const symbol = want.length === 1 && !/[a-z0-9]/.test(want);
+  // unnamed Shift is not held against it. Space is a named key, not a symbol, though its
+  // alias is one character: "Space" fired on Shift+Space, the browser's page-up, and
+  // cancelled it (0.52 code review, use-hotkey.ts).
+  const symbol = want.length === 1 && !/[a-z0-9 ]/.test(want);
   return symbol && !combo.shift ? true : e.shiftKey === combo.shift;
 }
 
@@ -128,10 +138,13 @@ function isTypingTarget(target: EventTarget | null): boolean {
  * - Modifiers match EXACTLY: `"Ctrl+K"` does not fire on Ctrl+Shift+K.
  * - Typing in a field is left alone unless `allowInInputs`, except for a combo with
  *   Ctrl / Meta / Alt, which no one types as text.
- * - A key held down fires once, not on every repeat.
+ * - A key held down fires once, not on every repeat — and its repeats are cancelled as
+ *   the first press was, or the browser acts on them.
  * - The newest `handler` is always called; changing it does not re-attach the listener.
  *
- * `useCommandKey` (the ⌘K palette hook) is unchanged; this is its general form.
+ * `useCommandKey` (the ⌘K palette hook) is this with `"Mod+K"` and `allowInInputs`
+ * since 0.52, and FormActions' Ctrl/Cmd+Enter is {@link matchesHotkey} (refactor audit
+ * 2026-10-30, DUP-12): one reading of a chord.
  */
 export function useHotkey(
   combo: Hotkey | ReadonlyArray<Hotkey>,
@@ -156,7 +169,6 @@ export function useHotkey(
     const parsed = key.split("\u0000").map((c) => parseHotkey(c, apple));
     const listener = (raw: Event) => {
       const e = raw as KeyboardEvent;
-      if (e.repeat) return;
       const hit = parsed.find((p) => matchesHotkey(e, p));
       if (!hit) return;
       if (allowInInputs !== true && isTypingTarget(e.target)) {
@@ -164,6 +176,11 @@ export function useHotkey(
         if (allowInInputs === "never" || !chorded) return;
       }
       if (preventDefault) e.preventDefault();
+      // A held key's repeats are cancelled like its first press, and call nothing. They
+      // returned before the `preventDefault` once, so a held Ctrl+K's repeats reached the
+      // browser's own Ctrl+K and took the focus out of the palette ⌘K had just opened
+      // (0.52 code review, use-hotkey.ts; the hand-written ⌘K listener cancelled them).
+      if (e.repeat) return;
       handlerRef.current(e);
     };
     node.addEventListener(event, listener);

package/src/hooks/use-long-press.ts

@@ -4,7 +4,8 @@ import { useCallback, useEffect, useRef, type PointerEvent as ReactPointerEvent
 // keksdose live #421). Taken over from keksdose's register list
 // (frontend/src/shared/hooks/use-long-press.ts, its feedback #153) so the kit's cards
 // and kk's register answer the same gesture the same way: 500 ms, an 8 px dead zone,
-// cancelled by a scroll, the trailing click swallowed.
+// cancelled by a scroll, the trailing click swallowed. Public since 0.52 (DUP-8, refactor
+// audit 2026-10-30): private, it left keksdose keeping the original beside the copy.
 
 const LONG_PRESS_MS = 500;
 /** The same 8 px dead zone `useRowSwipe` locks its axis at: the press is dead by the
@@ -14,6 +15,13 @@ const SLOP_PX = 8;
 const movedBeyondSlop = (from: { x: number; y: number }, x: number, y: number) =>
   Math.hypot(x - from.x, y - from.y) > SLOP_PX;
 
+export interface LongPressOptions {
+  /** Default `true`. Off, a press does nothing and the context menu is the browser's. */
+  enabled?: boolean;
+  /** How long a press is held, in ms. Default 500. */
+  delay?: number;
+}
+
 export interface LongPressResult {
   handlers: {
     onPointerDown: (e: ReactPointerEvent) => void;
@@ -40,7 +48,7 @@ export interface LongPressResult {
  */
 export function useLongPress(
   onLongPress: () => void,
-  { enabled = true, delay = LONG_PRESS_MS }: { enabled?: boolean; delay?: number } = {},
+  { enabled = true, delay = LONG_PRESS_MS }: LongPressOptions = {},
 ): LongPressResult {
   const timer = useRef<number | null>(null);
   const start = useRef({ x: 0, y: 0 });
@@ -120,6 +128,12 @@ export function useLongPress(
     return true;
   }, []);
 
+  // Turned off mid-press: the armed timer still fired, entering selection mode against the
+  // caller's wish and arming `consumeClick` for the next click (0.52 code review).
+  useEffect(() => {
+    if (!enabled) cancel();
+  }, [enabled, cancel]);
+
   useEffect(() => cancel, [cancel]);
 
   return { handlers: { onPointerDown, onPointerMove, onContextMenu }, consumeClick };

package/src/hooks/use-media-query.ts

@@ -1,4 +1,4 @@
-import { useEffect, useState } from "react";
+import { useEffect, useEffectEvent, useState } from "react";
 
 /**
  * Subscribe to a CSS media query, returning whether it currently matches and
@@ -10,12 +10,28 @@ export function useMediaQuery(query: string, fallback: boolean): boolean {
     typeof window !== "undefined" && typeof window.matchMedia === "function"
       ? window.matchMedia(query).matches
       : fallback;
-  const [matches, setMatches] = useState<boolean>(get);
+  // The answer is kept with the query it answers, and a new query is asked during the
+  // render that brings it. Read at mount only, the first commit after a new query still
+  // answered the OLD one, until the effect corrected it: `useBreakpoint` asks a new query
+  // when the text size changes, and at Large in a 700 px window the tour card was drawn
+  // un-docked for a frame before it docked (0.52 code review, use-breakpoint.ts).
+  const [state, setState] = useState(() => ({ query, matches: get() }));
+  let matches = state.matches;
+  if (state.query !== query) {
+    matches = get();
+    setState({ query, matches });
+  }
+  const answered = useEffectEvent(() => matches);
   useEffect(() => {
     if (typeof window === "undefined" || typeof window.matchMedia !== "function") return;
     const mql = window.matchMedia(query);
-    const update = () => setMatches(mql.matches);
-    update();
+    const update = () =>
+      setState((prev) =>
+        prev.query === query && prev.matches === mql.matches ? prev : { query, matches: mql.matches },
+      );
+    // A change between the render and this subscription. Only then: an update that
+    // changes nothing still costs a render (and a commit) right after a new query.
+    if (mql.matches !== answered()) update();
     mql.addEventListener("change", update);
     return () => mql.removeEventListener("change", update);
   }, [query]);