@eifi1/ui-kit 0.51.7 → 0.52.0

package/src/feedback/feedback-row-detail.tsx

@@ -7,8 +7,9 @@ import { TextLink } from "../components/text-link";
 import { toast } from "../components/toast";
 import { Button } from "../components/button";
 import type { AuthedFetcher } from "../hooks/use-authed-src";
-import { useKitLabels, useKitLocale, type LabelOverride } from "../i18n/kit-labels";
-import { formatDate } from "../lib/format";
+import type { PathPattern } from "../landing/routing";
+import { useKitLabels, type LabelOverride } from "../i18n/kit-labels";
+import { useDayFormatter } from "../lib/day-format";
 import { DEFAULT_MAX_ATTACHMENT_BYTES } from "./feedback-attachment";
 import { DEFAULT_FEEDBACK_DIALOG_LABELS } from "./feedback-dialog";
 import {
@@ -34,6 +35,8 @@ import {
   splitDescription,
 } from "./feedback-record";
 import type { FeedbackContext, FeedbackRecord } from "./feedback-record";
+import { runMutation, type FeedbackMutationCall } from "./feedback-mutation";
+import { feedbackPage, feedbackPageLinkTarget } from "./feedback-page-link";
 import { useFeedbackStatusUndo } from "./feedback-status-undo";
 import type { FeedbackStatusChange } from "./feedback-status-undo";
 import type { CommitScope } from "../components/write-lock";
@@ -130,15 +133,21 @@ export interface FeedbackDetailLabels {
   /** On section 4's heading line once the row is settled, given the formatted
    *  `resolved_at` date. de-CH: "Erledigt am: {{date}}" */
   resolvedAt: (date: string) => string;
-  /** The admin's button while there is no outcome. **Unused since 0.38** (the outcome is
-   *  frozen, §9.7; a reply is written instead); kept for one release.
-   *  de-CH: "Ergebnis hinzufügen" */
+  // Deprecated on these members, the ones an app's code reads and overrides through: the
+  // tags sat on the English default's keys, and reached nothing — the default is typed by
+  // this interface (0.52 code review, feedback-row-detail-labels.ts; refactor audit
+  // 2026-10-30, DOC-9).
+  /** The admin's button while there is no outcome — read by nothing since 0.38 (the
+   *  outcome is frozen, §9.7; a reply is written instead). de-CH: "Ergebnis hinzufügen"
+   *  @deprecated 0.52 — a reply: the outcome is frozen since 0.38 (§9.7); removed in 0.53. */
   outcomeAdd: string;
   /** The same button once there is one. Unused since 0.38, as `outcomeAdd`.
-   *  de-CH: "Aktualisieren" */
+   *  de-CH: "Aktualisieren"
+   *  @deprecated 0.52 — a reply: the outcome is frozen since 0.38 (§9.7); removed in 0.53. */
   outcomeUpdate: string;
-  /** The line above the outcome editor. Unused since 0.38, as `outcomeAdd`. de-CH: "Was wurde umgesetzt, entschieden oder
-   *  warum nicht." */
+  /** The line above the outcome editor. Unused since 0.38, as `outcomeAdd`.
+   *  de-CH: "Was wurde umgesetzt, entschieden oder warum nicht."
+   *  @deprecated 0.52 — a reply: the outcome is frozen since 0.38 (§9.7); removed in 0.53. */
   outcomePlaceholder: string;
   /** The button that opens section 5 on an answered row. de-CH: "Nacharbeit" */
   rework: string;
@@ -172,42 +181,28 @@ export function useFeedbackDetailLabels(labels?: LabelOverride<FeedbackDetailLab
 
 /* ── The page a report was filed on (§3.2, §4.4.2) ────────────────────────── */
 
-/** `context.url`, else `context.route` — a parsed URL, or null when neither is set or
- *  the value is no http(s) address or path (a `javascript:` value is not a page). */
-function parsePage(context: FeedbackContext | null | undefined): URL | null {
-  const raw = (context?.url || context?.route || "").trim();
-  if (!raw) return null;
-  try {
-    // A base, so a PATH-ONLY value parses too: Kurvenschmiede backfills its old rows
-    // with `url = page_path + search` (§3.2), and keksdose's `new URL(raw)` threw on
-    // those and dropped the section.
-    const url = new URL(raw, "http://localhost");
-    return url.protocol === "http:" || url.protocol === "https:" ? url : null;
-  } catch {
-    return null;
-  }
-}
-
-/** Collapses a leading `//` run: `/\/\/evil.example/` as a path would be a
- *  protocol-relative link off the app. */
-const localPath = (pathname: string) => pathname.replace(/^\/{2,}/, "/");
-
 /**
- * The in-app link to the page a report was filed on — path + query + hash (keksdose
- * `localHref`: the query and hash carry the state worth restoring, `?tab=import`, a
- * drill-down). Read from `context.url`, else `context.route`; a path-only `url` works.
- * Always a path on THIS app, never another origin's address, so it is safe as an
- * `href` whatever the row says. `null` when there is nothing to link.
+ * The page a report was filed on as the reporter had it — path + query + hash (keksdose
+ * `localHref`: the query and hash carry the state, `?tab=import`, a drill-down). Read from
+ * `context.url`, else `context.route`; a path-only `url` works. `null` when there is no
+ * page.
+ *
+ * Always a path on THIS app, never another origin's address — but the path and query
+ * are the reporter's to write, so it is TEXT, not a link target: `/join?token=…` acts on
+ * load, and `/login?next=…` forwards a signed-in admin to whatever its query names
+ * (refactor audit 2026-10-30, FLW-7; 0.52 code review). The kit's URL cell and section
+ * link {@link feedbackPagePath} alone, and not even that for a one-shot route
+ * (`pageLinkExclude`) — `FeedbackRowDetail` and `useFeedbackColumns` draw the page that
+ * way; an app's own cell should not link this.
  */
 export function feedbackPageHref(context: FeedbackContext | null | undefined): string | null {
-  const url = parsePage(context);
-  return url ? `${localPath(url.pathname)}${url.search}${url.hash}` : null;
+  return feedbackPage(context)?.href ?? null;
 }
 
-/** The page's path alone — the compact text a URL column shows (§4.3). */
+/** The page's path alone — the compact text a URL column shows (§4.3), and the only part
+ *  of the page the kit links. */
 export function feedbackPagePath(context: FeedbackContext | null | undefined): string | null {
-  const url = parsePage(context);
-  return url ? localPath(url.pathname) : null;
+  return feedbackPage(context)?.path ?? null;
 }
 
 /**
@@ -216,8 +211,7 @@ export function feedbackPagePath(context: FeedbackContext | null | undefined): s
  * (feedback #278) — else `context.route`. `null` when there is no page.
  */
 export function feedbackPageUrl(context: FeedbackContext | null | undefined): string | null {
-  if (!parsePage(context)) return null;
-  return (context?.url || context?.route || "").trim();
+  return feedbackPage(context)?.url ?? null;
 }
 
 /* ── Attachments (§3.5, §4.4.3) ───────────────────────────────────────────── */
@@ -315,13 +309,25 @@ export interface FeedbackDetailPatch {
 }
 
 /**
- * The page's update mutation. **TanStack Query's `mutate` fits as it stands** — pass
- * `update.mutate` (and `pending={update.isPending}`), the same function
- * `useFeedbackStatusUndo` takes. A hand-written one sends the PATCH and calls
- * `onSuccess` once it has landed, and only then: that is when an editor closes. A
- * failure is the mutation's own to toast — the server's `detail`, else
+ * The page's update mutation (0.52): **TanStack Query's `mutateAsync`** — pass
+ * `update.mutateAsync` (and `pending={update.isPending}`), the same function
+ * `useFeedbackStatusUndo` takes. An editor closes when the promise resolves, which it does
+ * for every call — also when a status pill was pressed while the save was in flight
+ * (refactor audit 2026-10-30, FLW-3). A hand-written one resolves once the PATCH has
+ * landed. A failure is the mutation's own to toast — the server's `detail`, else
  * `feedbackToast.updateFailed` (§4.4) — and leaves the editor open with its draft.
  */
+export type FeedbackDetailUpdateAsync = (patch: FeedbackDetailPatch) => Promise<unknown>;
+
+/**
+ * The callback form: TanStack Query's `mutate`, or a function that calls `onSuccess` once
+ * the PATCH has landed. TanStack calls a per-call `onSuccess` for the LATEST `mutate()`
+ * only, so an editor whose save was followed by another PATCH before it answered stayed
+ * open, and the earlier status change lost its Undo.
+ *
+ * @deprecated 0.52 — pass `update.mutateAsync` ({@link FeedbackDetailUpdateAsync}); removed
+ * in 0.53
+ */
 export type FeedbackDetailUpdate = (patch: FeedbackDetailPatch, callbacks: { onSuccess: () => void }) => void;
 
 /** `POST /feedback/attachments` (§3.3): one file up, its URL
@@ -342,10 +348,10 @@ export interface FeedbackReworkSectionProps {
   /** 0.40: the rework as an entry of its own — see {@link FeedbackReworkSend}. With it,
    *  `onUpdate` is not called. */
   onRework?: FeedbackReworkSend;
-  /** The PATCH — see {@link FeedbackDetailUpdate}. Called with `{ id, body }` only, and
-   *  only without `onRework`: the legacy append (§3.4), which server-kit 0.13 still
+  /** The PATCH — see {@link FeedbackDetailUpdateAsync}. Called with `{ id, body }` only,
+   *  and only without `onRework`: the legacy append (§3.4), which server-kit 0.13 still
    *  turns into an entry for one release. Optional since 0.40; pass one of the two. */
-  onUpdate?: FeedbackDetailUpdate;
+  onUpdate?: FeedbackMutationCall<FeedbackDetailPatch>;
   /** The PATCH is in flight (`update.isPending`). The upload adds its own. */
   pending?: boolean;
   /** The upload. Left out, the note goes without a file field. */
@@ -466,7 +472,7 @@ export function FeedbackReworkSection({
       return;
     }
     if (body === null) return;
-    onUpdate({ id: row.id, body }, { onSuccess: () => onSent?.() });
+    runMutation(onUpdate, { id: row.id, body }, () => onSent?.());
   };
 
   return (
@@ -510,8 +516,10 @@ export interface FeedbackRowDetailProps {
   canEdit: boolean;
   /** The signed-in user's id — who the AUTHOR is: the description editor and rework. */
   viewerId?: number | null;
-  /** The page's PATCH — `update.mutate` (see {@link FeedbackDetailUpdate}). */
-  onUpdate: FeedbackDetailUpdate;
+  /** The page's PATCH — `update.mutateAsync` (see {@link FeedbackDetailUpdateAsync}). The
+   *  callback form ({@link FeedbackDetailUpdate}, `update.mutate`) still fits, deprecated
+   *  since 0.52; the prop's one signature takes both. */
+  onUpdate: FeedbackMutationCall<FeedbackDetailPatch>;
   /** `update.isPending`: the editors' save buttons wait for it. */
   pending?: boolean;
   /** `POST /feedback/attachments` for the rework's one file and, since 0.47 (§12) with
@@ -522,7 +530,7 @@ export interface FeedbackRowDetailProps {
    *  the browser's own fetch with same-origin cookies. */
   fetcher?: AuthedFetcher | null;
   /**
-   * The undoable status change — what `useFeedbackStatusUndo(update.mutate)` returns,
+   * The undoable status change — what `useFeedbackStatusUndo(update.mutateAsync)` returns,
    * the SAME one the table's status cell and the swipes use (§4.5). Left out, the
    * detail builds one from `onUpdate`, which is equivalent as long as `onUpdate` is the
    * page's mutation (its observer outlives the row a status filter removes).
@@ -534,9 +542,20 @@ export interface FeedbackRowDetailProps {
   /** The rework's and (0.47, with `replyAttachments`) the reply composer's file field,
    *  over the contract's defaults. */
   reworkAttachment?: Partial<FeedbackNoteAttachment>;
-  /** How the `resolved_at` date reads — the app's date cell, as a string. Default: the
-   *  kit's `formatDate` in the provider's locale, `medium` style. */
+  /** How the `resolved_at` date reads — the app's date cell, as a string. Default
+   *  (0.52): the `<UiKitProvider formatDate>` when the app set one, else the kit's
+   *  `formatDate` in the provider's locale and time zone, `medium` style. */
   renderDate?: (iso: string) => string;
+  /**
+   * 0.52 (FLW-7): the app's one-shot routes, ON TOP of the kit's — `/join`,
+   * `/register`, `/verify-email`, `/reset-password` (a string is that path and everything
+   * under it, a RegExp is tested on the path, as `useLastVisitedPage`'s `exclude`). The
+   * URL section shows such a page as text with Copy, never as a link: it acts on load,
+   * and a report's page is the reporter's to write. Any other page links its PATH alone;
+   * the query, where tokens and `?next=` targets travel, is text. keksdose:
+   * `["/banks/callback", "/share-target"]`. Keep it stable (module scope).
+   */
+  pageLinkExclude?: readonly PathPattern[];
   /**
    * The detail's saves COMMIT (description, outcome, rework, status): under a locked
    * `WriteLockProvider` each is `aria-disabled` with the lock's reason, and nothing
@@ -607,12 +626,12 @@ export interface FeedbackRowDetailProps {
  * ```tsx
  * const update = useMutation({ mutationFn: ({ id, ...patch }) => api.updateFeedback(id, patch),
  *   onSuccess: invalidate, onError: (e) => toast.error(detailOf(e) ?? toastLabels.updateFailed) });
- * const changeStatus = useFeedbackStatusUndo(update.mutate);
+ * const changeStatus = useFeedbackStatusUndo(update.mutateAsync);
  * <DataTable
  *   isExpanded={(row) => expandedId === row.id}
  *   expandedRow={(row) => (
  *     <FeedbackRowDetail row={row} canEdit={isAdmin && !mine} viewerId={user?.id}
- *       onUpdate={update.mutate} pending={update.isPending} statusChange={changeStatus}
+ *       onUpdate={update.mutateAsync} pending={update.isPending} statusChange={changeStatus}
  *       onUpload={api.uploadFeedbackAttachment} fetcher={authedImageFetcher}
  *       onCaptureScreenshot={captureAppScreenshot} />
  *   )} … />
@@ -634,6 +653,7 @@ export function FeedbackRowDetail({
   onCaptureScreenshot,
   reworkAttachment,
   renderDate,
+  pageLinkExclude,
   commit,
   showSubject = true,
   onReply,
@@ -649,7 +669,6 @@ export function FeedbackRowDetail({
   // "placeholder = the dialog's body label" (§4.4.1): read from the dialog's own
   // namespace, so the two can never say different things.
   const dialogText = useKitLabels("feedbackDialog", DEFAULT_FEEDBACK_DIALOG_LABELS);
-  const locale = useKitLocale();
   const ownStatusChange = useFeedbackStatusUndo(onUpdate);
   const changeStatus = statusChange ?? ownStatusChange;
   const [editingBody, setEditingBody] = useState(false);
@@ -660,13 +679,17 @@ export function FeedbackRowDetail({
   // rework rounds stay in the prose: they are what was said after the answer.
   const bodyText = splitBodyAttachments(row.body).text;
   const { description } = splitDescription(row.body);
-  const pageHref = feedbackPageHref(row.context);
-  const pageUrl = feedbackPageUrl(row.context);
+  const page = feedbackPage(row.context);
+  const pageLink = page && feedbackPageLinkTarget(page, pageLinkExclude);
   // 0.47 (§12): with the entries, each entry's file is drawn inline in the Replies
   // timeline, so the Attachment section holds the report's own files.
   const files = feedbackAttachmentUrls(row.replies ? { ...row, replies: undefined } : row);
   const fetchFile = fetcher ?? plainFeedbackFetch;
-  const dateText = (iso: string) => (renderDate ? renderDate(iso) : formatDate(iso, "medium", { locale }));
+  // A date in a sentence ("Resolved: …"), so no weekday — through the kit's one day
+  // ladder, which reaches the provider's `formatDate` (0.52, refactor audit 2026-10-30,
+  // DUP-2).
+  const day = useDayFormatter<string>(renderDate);
+  const dateText = (iso: string) => day(iso);
 
   const saveDescription = (value: string) => {
     // Only a real change makes a round trip; clearing it is one ("" — the description
@@ -675,7 +698,7 @@ export function FeedbackRowDetail({
       setEditingBody(false);
       return;
     }
-    onUpdate({ id: row.id, body: replaceDescription(row.body, value) }, { onSuccess: () => setEditingBody(false) });
+    runMutation(onUpdate, { id: row.id, body: replaceDescription(row.body, value) }, () => setEditingBody(false));
   };
 
   // 0.38 (§9.7): the replies replace the outcome; a row without them is a server before
@@ -735,14 +758,27 @@ export function FeedbackRowDetail({
         )}
       </FeedbackDetailSection>
 
-      {pageHref && pageUrl && (
-        // The page it was filed on, with the full URL a click away (keksdose #278).
+      {page && (
+        // The page it was filed on, with the full URL a click away (keksdose #278). Only
+        // the path is a link; the query and hash, the reporter's to write, are text — and
+        // a one-shot path is text too (FLW-7, 0.52 code review: see feedback-page-link).
         <FeedbackDetailSection title={labels.url}>
           <div className="flex min-w-0 items-center gap-1.5">
-            <TextLink href={pageHref} tone="secondary" underline="hover" stopPropagation className="min-w-0">
-              <code className="break-all text-xs">{pageHref}</code>
-            </TextLink>
-            <CopyButton size="xs" className="shrink-0" text={pageUrl} label={labels.copyUrl} stopPropagation />
+            <code
+              className="min-w-0 break-all text-xs text-secondary"
+              data-feedback-page=""
+              data-feedback-page-unlinked={pageLink ? undefined : ""}
+            >
+              {pageLink ? (
+                <TextLink href={pageLink} tone="secondary" underline="hover" stopPropagation>
+                  {page.path}
+                </TextLink>
+              ) : (
+                page.path
+              )}
+              {page.href.slice(page.path.length)}
+            </code>
+            <CopyButton size="xs" className="shrink-0" text={page.url} label={labels.copyUrl} stopPropagation />
           </div>
         </FeedbackDetailSection>
       )}

package/src/feedback/feedback-status-undo.ts

@@ -9,6 +9,7 @@ import {
 } from "./feedback-labels";
 import type { FeedbackRecord } from "./feedback-record";
 import type { LabelOverride } from "../i18n/kit-labels";
+import { runMutation, type FeedbackMutationCall } from "./feedback-mutation";
 
 /**
  * A status change that can be taken back — §4.5 of the feedback contract, lifted from
@@ -30,12 +31,25 @@ export interface FeedbackStatusPatch {
 }
 
 /**
- * The page's status mutation. **TanStack Query's `mutate` fits as it stands** — pass
- * `updateMutation.mutate` (stable across renders), not `mutateAsync`. A hand-written
- * one sends the PATCH and calls `onSuccess` once it has landed, and only then.
+ * The page's status mutation (0.52): **TanStack Query's `mutateAsync`** — pass
+ * `update.mutateAsync`. The toast comes when the promise resolves, which it does for every
+ * call (refactor audit 2026-10-30, FLW-3). A hand-written one returns a promise that
+ * resolves once the PATCH has landed and rejects when it failed.
  *
  * Failure is the mutation's own business: its `onError` toasts the server's `detail`,
- * else `feedbackToast.updateFailed` (§4.4) — this hook adds no second error toast.
+ * else `feedbackToast.updateFailed` (§4.4) — this hook adds no second error toast, and
+ * catches the rejection.
+ */
+export type FeedbackStatusMutateAsync = (patch: FeedbackStatusPatch) => Promise<unknown>;
+
+/**
+ * The callback form: TanStack Query's `mutate`, or a function that calls `onSuccess` once
+ * the PATCH has landed. TanStack calls a per-call `onSuccess` for the LATEST `mutate()` on
+ * its observer only, so a second change sent before the first answered — another swipe,
+ * another pill, the Undo itself — lost the first change's Undo toast.
+ *
+ * @deprecated 0.52 — pass `update.mutateAsync` ({@link FeedbackStatusMutateAsync}), whose
+ * promise settles for every call; removed in 0.53
  */
 export type FeedbackStatusMutate = (patch: FeedbackStatusPatch, callbacks: { onSuccess: () => void }) => void;
 
@@ -64,20 +78,26 @@ export const FEEDBACK_UNDO_DURATION = 8000;
  *
  * ```tsx
  * const update = useMutation({ mutationFn: api.updateFeedback, onError: … });
- * const changeStatus = useFeedbackStatusUndo(update.mutate);
+ * const changeStatus = useFeedbackStatusUndo(update.mutateAsync);
  * <FeedbackStatusTransitions … onPick={(status) => changeStatus(row, status)} />
  * ```
  *
- * Give it the PAGE's mutation, not one a row owns: TanStack only calls per-call
- * callbacks while the observer that started the mutation is mounted, and a row the new
- * status filters out unmounts before the PATCH answers — the toast would never come.
+ * Give it the PAGE's mutation, not one a row owns: a row the new status filters out
+ * unmounts before the PATCH answers.
  *
- * The flow: PATCH `{ id, status }` → on success a success toast
+ * The flow: PATCH `{ id, status }` → once it has landed a success toast
  * `statusChanged(newName, title)` with the action `statusUndo`, 8 s → Undo PATCHes
- * `{ id, status: previous }` → on success `statusRestored(previousName, title)`.
+ * `{ id, status: previous }` → once that has landed `statusRestored(previousName, title)`.
+ * Each change waits for its OWN answer, so two changes in flight each get their toast.
+ *
+ * `update.mutate` ({@link FeedbackStatusMutate}) still fits, deprecated since 0.52: with it
+ * a second change before the first answered loses the first one's Undo. One signature
+ * takes both rather than two overloads: TypeScript types an inline callback's parameters
+ * from the FIRST overload, so a hand-written `(patch, { onSuccess }) => …` — the form this
+ * hook documented until 0.52 — would no longer compile.
  */
 export function useFeedbackStatusUndo(
-  mutate: FeedbackStatusMutate,
+  mutate: FeedbackMutationCall<FeedbackStatusPatch>,
   { labels, statusLabels }: FeedbackStatusUndoOptions = {},
 ): FeedbackStatusChange {
   const words = useFeedbackToastLabels(labels);
@@ -87,22 +107,16 @@ export function useFeedbackStatusUndo(
       const { id, title, status: previous } = row;
       if (status === previous) return;
       const nameOf = (value: FeedbackStatus) => names[value] ?? value;
-      mutate(
-        { id, status },
-        {
-          onSuccess: () => {
-            toast.undo(words.statusChanged(nameOf(status), title), {
-              label: words.statusUndo,
-              duration: FEEDBACK_UNDO_DURATION,
-              onUndo: () =>
-                mutate(
-                  { id, status: previous },
-                  { onSuccess: () => void toast.success(words.statusRestored(nameOf(previous), title)) },
-                ),
-            });
-          },
-        },
-      );
+      runMutation(mutate, { id, status }, () => {
+        toast.undo(words.statusChanged(nameOf(status), title), {
+          label: words.statusUndo,
+          duration: FEEDBACK_UNDO_DURATION,
+          onUndo: () =>
+            runMutation(mutate, { id, status: previous }, () => {
+              toast.success(words.statusRestored(nameOf(previous), title));
+            }),
+        });
+      });
     },
     [mutate, words, names],
   );

package/src/feedback/feedback-submit-dialog.tsx

@@ -37,7 +37,7 @@ export interface FeedbackSubmitDialogProps {
   onCategoryChange: (category: FeedbackCategory) => void;
   submitting: boolean;
   /** The form, and the `context` built from the same values the box showed. */
-  onSubmit: (data: FeedbackMultipleSubmission, context: FeedbackContext) => void | Promise<void>;
+  onSubmit: (data: FeedbackMultipleSubmission<FeedbackCategory>, context: FeedbackContext) => void | Promise<void>;
   user?: FeedbackSubmitter | null;
   /** `location.href` when the dialog opened. */
   url: string;
@@ -89,7 +89,7 @@ export function FeedbackSubmitDialog({
       onClose={onClose}
       categories={FEEDBACK_PICKABLE_CATEGORIES.map((value) => ({ value, label: categoryLabels[value] }))}
       category={category}
-      onCategoryChange={(value) => onCategoryChange(value as FeedbackCategory)}
+      onCategoryChange={onCategoryChange}
       submitting={submitting}
       attachments="multiple"
       maxAttachments={DEFAULT_MAX_ATTACHMENTS}

package/src/feedback/feedback-submit.tsx

@@ -1,8 +1,10 @@
-import { lazy, Suspense, useRef, useState } from "react";
+import { Suspense, useLayoutEffect, useRef, useState } from "react";
 import type { ReactNode } from "react";
 import { toast } from "../components/toast";
+import { lazyWithFallback } from "../lib/lazy-with-fallback";
 // Types only, gone from the built module: the dialog's modules load with the dialog.
 import type { FeedbackSubmitter } from "./feedback-context";
+import type { FeedbackSubmitDialogProps } from "./feedback-submit-dialog";
 import type { FeedbackMultipleSubmission } from "./feedback-dialog";
 import { useFeedbackToastLabels } from "./feedback-labels";
 import { FEEDBACK_PICKABLE_CATEGORIES, type FeedbackContext, type FeedbackEnvironment } from "./feedback-record";
@@ -14,11 +16,22 @@ import type { FeedbackCategory } from "./feedback-vocabulary";
  * LITERAL relative `import()`, as the catalogue loaders are (i18n/languages.ts): the
  * library build keeps the module its own (`bundle: false`), and a path an app's bundler
  * can read is a chunk it can split off.
+ *
+ * A fetch that fails — a tab left open across a deploy, offline — closes the dialog
+ * rather than throwing (0.52 code review, tour.tsx): the hook lives in the top bar, above
+ * the routes' error boundaries, so the rejected import took the whole shell down. The
+ * next open fetches again.
  */
-const LazySubmitDialog = lazy(() =>
-  import("./feedback-submit-dialog").then((module) => ({ default: module.FeedbackSubmitDialog })),
+const LazySubmitDialog = lazyWithFallback(
+  () => import("./feedback-submit-dialog").then((module) => module.FeedbackSubmitDialog),
+  SubmitDialogUnavailable,
 );
 
+function SubmitDialogUnavailable({ onClose }: FeedbackSubmitDialogProps) {
+  useLayoutEffect(onClose, [onClose]);
+  return null;
+}
+
 /**
  * `FeedbackCreate` — the body of `POST /feedback` (keksdose `schemas/feedback.py:25`, §3.4
  * of docs/feedback-harmonization.md), as {@link useFeedbackSubmit} hands it to the app's
@@ -165,7 +178,7 @@ export function useFeedbackSubmit<R = unknown>(options: UseFeedbackSubmitOptions
   const close = () => setIsOpen(false);
 
   // `context` comes from the dialog, built off the values its context box shows.
-  const submit = async (data: FeedbackMultipleSubmission, context: FeedbackContext) => {
+  const submit = async (data: FeedbackMultipleSubmission<FeedbackCategory>, context: FeedbackContext) => {
     if (inFlight.current) return;
     inFlight.current = true;
     setSubmitting(true);
@@ -179,7 +192,7 @@ export function useFeedbackSubmit<R = unknown>(options: UseFeedbackSubmitOptions
       result = await create({
         title: data.title.trim(),
         body: data.body.trim() ? data.body : "",
-        category: data.category as FeedbackCategory,
+        category: data.category,
         context,
         screenshot_url,
         attachment_urls,
@@ -197,8 +210,9 @@ export function useFeedbackSubmit<R = unknown>(options: UseFeedbackSubmitOptions
   };
 
   // Nothing is drawn while the dialog's module is on its way — a few milliseconds, once per
-  // page load; a spinner would only flash. A load that fails (a deploy replaced the chunk)
-  // throws a chunk-load error to the app's error boundary, as a lazy route's does.
+  // page load; a spinner would only flash. A load that fails (a deploy replaced the chunk,
+  // offline) closes the dialog (`SubmitDialogUnavailable`): the hook sits in the top bar,
+  // above the routes' error boundaries, where a thrown chunk error took the shell down.
   const dialog = isOpen ? (
     <Suspense fallback={null}>
       <LazySubmitDialog

package/src/feedback/feedback-swipe.tsx

@@ -124,7 +124,7 @@ function panel(
  * for it, or `null` when the row offers no swipe at all:
  *
  * ```tsx
- * const changeStatus = useFeedbackStatusUndo(update.mutate);
+ * const changeStatus = useFeedbackStatusUndo(update.mutateAsync);
  * const statusLabels = useFeedbackStatusLabels();
  * <DataTable
  *   mobileSwipeActions={isAdmin && !mine