@effect/language-service 0.31.1 → 0.32.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@effect/language-service",
-  "version": "0.31.1",
+  "version": "0.32.0",
   "description": "A Language-Service Plugin to Refactor and Diagnostic effect-ts projects",
   "main": "index.cjs",
   "bin": {

package/transform.js

@@ -1125,7 +1125,8 @@ function parse(config) {
     goto: isObject(config) && hasProperty(config, "goto") && isBoolean(config.goto) ? config.goto : true,
     allowedDuplicatedPackages: isObject(config) && hasProperty(config, "allowedDuplicatedPackages") && isArray(config.allowedDuplicatedPackages) && config.allowedDuplicatedPackages.every(isString) ? config.allowedDuplicatedPackages.map((_) => _.toLowerCase()) : [],
     namespaceImportPackages: isObject(config) && hasProperty(config, "namespaceImportPackages") && isArray(config.namespaceImportPackages) && config.namespaceImportPackages.every(isString) ? config.namespaceImportPackages.map((_) => _.toLowerCase()) : [],
-    barrelImportPackages: isObject(config) && hasProperty(config, "barrelImportPackages") && isArray(config.barrelImportPackages) && config.barrelImportPackages.every(isString) ? config.barrelImportPackages.map((_) => _.toLowerCase()) : []
+    barrelImportPackages: isObject(config) && hasProperty(config, "barrelImportPackages") && isArray(config.barrelImportPackages) && config.barrelImportPackages.every(isString) ? config.barrelImportPackages.map((_) => _.toLowerCase()) : [],
+    topLevelNamedReexports: isObject(config) && hasProperty(config, "topLevelNamedReexports") && isString(config.topLevelNamedReexports) && (config.topLevelNamedReexports.toLowerCase() === "ignore" || config.topLevelNamedReexports.toLowerCase() === "follow") ? config.topLevelNamedReexports.toLowerCase() : "ignore"
   };
 }
 
@@ -2920,6 +2921,7 @@ function make2(ts, tsUtils, typeChecker) {
                       className: atLocation.name,
                       selfTypeNode,
                       args: wholeCall.arguments,
+                      options: wholeCall.arguments[1],
                       accessors: accessors2,
                       dependencies
                     };
@@ -3155,9 +3157,11 @@ var floatingEffect = createDiagnostic({
           option
         );
         if (isNone2(allowedFloatingEffects)) {
+          const isStrictEffect = yield* option(typeParser.strictEffectType(type, node.expression));
+          const name = isSome2(isStrictEffect) ? "Effect" : "Effect-able " + typeChecker.typeToString(type);
           report({
             location: node,
-            messageText: `Effect must be yielded or assigned to a variable.`,
+            messageText: `${name} must be yielded or assigned to a variable.`,
             fixes: []
           });
         }
@@ -3666,7 +3670,7 @@ var missingEffectServiceDependency = createDiagnostic({
           orElse2(() => void_)
         );
         if (serviceResult) {
-          const { className, dependencies } = serviceResult;
+          const { className, options } = serviceResult;
           const classSymbol = typeChecker.getSymbolAtLocation(className);
           if (classSymbol) {
             const classType = typeChecker.getTypeOfSymbol(classSymbol);
@@ -3687,11 +3691,17 @@ var missingEffectServiceDependency = createDiagnostic({
                   excludeNever
                 );
                 const providedIndexes = /* @__PURE__ */ new Set();
-                const dependenciesToProcess = dependencies || [];
-                for (const depExpression of dependenciesToProcess) {
-                  const depType = typeChecker.getTypeAtLocation(depExpression);
+                const optionsType = typeChecker.getTypeAtLocation(options);
+                const dependenciesProperty = typeChecker.getPropertyOfType(optionsType, "dependencies");
+                let types = [];
+                if (dependenciesProperty) {
+                  const dependenciesTypes = typeChecker.getTypeOfSymbolAtLocation(dependenciesProperty, options);
+                  const numberIndexType = dependenciesTypes.getNumberIndexType();
+                  types = numberIndexType ? unrollUnionMembers(numberIndexType) : [];
+                }
+                for (const depType of types) {
                   const depLayerResult = yield* pipe(
-                    typeParser.layerType(depType, depExpression),
+                    typeParser.layerType(depType, options),
                     orElse2(() => void_)
                   );
                   if (depLayerResult) {
@@ -3778,7 +3788,7 @@ var missingReturnYieldStar = createDiagnostic({
                 }] : [];
                 report({
                   location: node,
-                  messageText: `Yielded Effect never succeeds, so it is best to use a 'return yield*' instead.`,
+                  messageText: `It is recommended to use return yield* for Effects that never succeed to signal a definitive exit point for type narrowing and tooling support.`,
                   fixes: fix
                 });
               }