@effect/language-service 0.31.1 → 0.32.0

package/README.md

@@ -99,7 +99,8 @@ Few options can be provided alongside the initialization of the Language Service
         "goto": true, // controls Effect goto references (default: true)
         "allowedDuplicatedPackages": [], // list of package names that have effect in peer dependencies and are allowed to be duplicated (default: [])
         "barrelImportPackages": [], // package names that should be preferred as imported from the top level barrel file (default: [])
-        "namespaceImportPackages": [] // package names that should be preferred as imported with namespace imports e.g. ["effect", "@effect/*"] (default: [])
+        "namespaceImportPackages": [], // package names that should be preferred as imported with namespace imports e.g. ["effect", "@effect/*"] (default: [])
+        "topLevelNamedReexports": "ignore" // for namespaceImportPackages, how should top level named re-exports (e.g. {pipe} from "effect") be treated? "ignore" will leave them as is, "follow" will rewrite them to the re-exported module (e.g. {pipe} from "effect/Function")
       }
     ]
   }

package/cli.js

@@ -28786,7 +28786,8 @@ function parse4(config2) {
     goto: isObject(config2) && hasProperty(config2, "goto") && isBoolean(config2.goto) ? config2.goto : true,
     allowedDuplicatedPackages: isObject(config2) && hasProperty(config2, "allowedDuplicatedPackages") && isArray(config2.allowedDuplicatedPackages) && config2.allowedDuplicatedPackages.every(isString) ? config2.allowedDuplicatedPackages.map((_) => _.toLowerCase()) : [],
     namespaceImportPackages: isObject(config2) && hasProperty(config2, "namespaceImportPackages") && isArray(config2.namespaceImportPackages) && config2.namespaceImportPackages.every(isString) ? config2.namespaceImportPackages.map((_) => _.toLowerCase()) : [],
-    barrelImportPackages: isObject(config2) && hasProperty(config2, "barrelImportPackages") && isArray(config2.barrelImportPackages) && config2.barrelImportPackages.every(isString) ? config2.barrelImportPackages.map((_) => _.toLowerCase()) : []
+    barrelImportPackages: isObject(config2) && hasProperty(config2, "barrelImportPackages") && isArray(config2.barrelImportPackages) && config2.barrelImportPackages.every(isString) ? config2.barrelImportPackages.map((_) => _.toLowerCase()) : [],
+    topLevelNamedReexports: isObject(config2) && hasProperty(config2, "topLevelNamedReexports") && isString(config2.topLevelNamedReexports) && (config2.topLevelNamedReexports.toLowerCase() === "ignore" || config2.topLevelNamedReexports.toLowerCase() === "follow") ? config2.topLevelNamedReexports.toLowerCase() : "ignore"
   };
 }
 
@@ -30581,6 +30582,7 @@ function make64(ts2, tsUtils, typeChecker) {
                       className: atLocation.name,
                       selfTypeNode,
                       args: wholeCall.arguments,
+                      options: wholeCall.arguments[1],
                       accessors: accessors2,
                       dependencies
                     };
@@ -30816,9 +30818,11 @@ var floatingEffect = createDiagnostic({
           option4
         );
         if (isNone2(allowedFloatingEffects)) {
+          const isStrictEffect = yield* option4(typeParser.strictEffectType(type2, node.expression));
+          const name = isSome2(isStrictEffect) ? "Effect" : "Effect-able " + typeChecker.typeToString(type2);
           report({
             location: node,
-            messageText: `Effect must be yielded or assigned to a variable.`,
+            messageText: `${name} must be yielded or assigned to a variable.`,
             fixes: []
           });
         }
@@ -31327,7 +31331,7 @@ var missingEffectServiceDependency = createDiagnostic({
           orElse14(() => void_8)
         );
         if (serviceResult) {
-          const { className, dependencies } = serviceResult;
+          const { className, options: options3 } = serviceResult;
           const classSymbol = typeChecker.getSymbolAtLocation(className);
           if (classSymbol) {
             const classType = typeChecker.getTypeOfSymbol(classSymbol);
@@ -31348,11 +31352,17 @@ var missingEffectServiceDependency = createDiagnostic({
                   excludeNever
                 );
                 const providedIndexes = /* @__PURE__ */ new Set();
-                const dependenciesToProcess = dependencies || [];
-                for (const depExpression of dependenciesToProcess) {
-                  const depType = typeChecker.getTypeAtLocation(depExpression);
+                const optionsType = typeChecker.getTypeAtLocation(options3);
+                const dependenciesProperty = typeChecker.getPropertyOfType(optionsType, "dependencies");
+                let types = [];
+                if (dependenciesProperty) {
+                  const dependenciesTypes = typeChecker.getTypeOfSymbolAtLocation(dependenciesProperty, options3);
+                  const numberIndexType = dependenciesTypes.getNumberIndexType();
+                  types = numberIndexType ? unrollUnionMembers(numberIndexType) : [];
+                }
+                for (const depType of types) {
                   const depLayerResult = yield* pipe(
-                    typeParser.layerType(depType, depExpression),
+                    typeParser.layerType(depType, options3),
                     orElse14(() => void_8)
                   );
                   if (depLayerResult) {
@@ -31439,7 +31449,7 @@ var missingReturnYieldStar = createDiagnostic({
                 }] : [];
                 report({
                   location: node,
-                  messageText: `Yielded Effect never succeeds, so it is best to use a 'return yield*' instead.`,
+                  messageText: `It is recommended to use return yield* for Effects that never succeed to signal a definitive exit point for type narrowing and tooling support.`,
                   fixes: fix
                 });
               }