@effect-agent/pr-review 0.1.0-beta.28 → 0.1.0-beta.30

package/src/internal/ignore.ts

@@ -1,88 +0,0 @@
-import { Effect, Layer } from "effect";
-
-import { PullRequestMetadata, PullRequestSource, ReviewInputViolation } from "./source.ts";
-
-// ---------------------------------------------------------------------------
-// Configured ignore globs, applied at the source port. Ignored files are
-// removed from the reviewer's entire observation surface — the changeset
-// list, diffs, and head reads — so the model never spends budget on them and
-// can never anchor a finding to them. Filtering fails closed: reading an
-// ignored path is a ReviewInputViolation, exactly like a path outside the
-// changeset.
-// ---------------------------------------------------------------------------
-
-const REGEX_SPECIALS = /[.+^${}()|[\]\\]/g;
-
-// Placeholders for the directory-crossing wildcard while single-segment
-// wildcards are rewritten; NUL/SOH cannot appear in a valid repository path.
-const CROSSING_SLASH = "\u0000";
-const CROSSING = "\u0001";
-
-/**
- * The supported glob vocabulary is deliberately minimal: `**` crosses
- * directory separators, `*` and `?` stay within one path segment, everything
- * else is literal. Every string compiles — there is no invalid pattern.
- */
-const globToRegExpSource = (pattern: string): string =>
-  pattern
-    .replace(REGEX_SPECIALS, String.raw`\$&`)
-    .replaceAll("**/", CROSSING_SLASH)
-    .replaceAll("**", CROSSING)
-    .replaceAll("*", "[^/]*")
-    .replaceAll("?", "[^/]")
-    .replaceAll(CROSSING_SLASH, "(?:.*/)?")
-    .replaceAll(CROSSING, ".*");
-
-/** Compile ignore globs into one predicate over repository-relative paths. */
-export const compileIgnoreGlobs = (
-  patterns: ReadonlyArray<string>,
-): ((path: string) => boolean) => {
-  if (patterns.length === 0) return () => false;
-  const expressions = patterns.map((pattern) => new RegExp(`^(?:${globToRegExpSource(pattern)})$`));
-  return (path) => expressions.some((expression) => expression.test(path));
-};
-
-/**
- * Decorate the ambient PullRequestSource with configured ignore globs. The
- * resulting Layer requires the undecorated source, so callers provide their
- * real adapter beneath it. Metadata's changed-file total is reduced by the
- * ignored count: from the reviewer's perspective the ignored files do not
- * exist, and truncation reporting stays about the reviewer's own bound.
- */
-export const ignoringPullRequestSourceLayer = (
-  patterns: ReadonlyArray<string>,
-): Layer.Layer<PullRequestSource, never, PullRequestSource> =>
-  Layer.effect(PullRequestSource)(
-    Effect.gen(function* () {
-      const source = yield* PullRequestSource;
-      const ignored = compileIgnoreGlobs(patterns);
-      const changedFiles = source.changedFiles.pipe(
-        Effect.map((files) => files.filter((file) => !ignored(file.path))),
-      );
-      const anchorFiles = source.anchorFiles.pipe(
-        Effect.map((files) => files.filter((file) => !ignored(file.path))),
-      );
-      const metadata = Effect.gen(function* () {
-        const [meta, files] = yield* Effect.all([source.metadata, source.anchorFiles]);
-        const ignoredCount = files.filter((file) => ignored(file.path)).length;
-        return PullRequestMetadata.make({
-          ...meta,
-          totalChangedFiles: Math.max(0, meta.totalChangedFiles - ignoredCount),
-        });
-      });
-      return PullRequestSource.of({
-        metadata,
-        changedFiles,
-        anchorFiles,
-        readFile: (path) =>
-          ignored(path)
-            ? Effect.fail(
-                ReviewInputViolation.make({
-                  input: path,
-                  reason: "Path is excluded from this review by configuration.",
-                }),
-              )
-            : source.readFile(path),
-      });
-    }),
-  );

package/src/internal/logging.ts

@@ -1,124 +0,0 @@
-import type { LogLevel } from "effect";
-import { Cause, Config, Effect, Layer, Logger, Predicate, References } from "effect";
-
-// ---------------------------------------------------------------------------
-// Compact host logging for CI runs. The engine's telemetry logs carry full
-// OTel-style annotation sets — correct for an exporter, unreadable as an
-// Actions console. This logger renders each record as ONE line: known engine
-// telemetry messages become short progress lines, and everything else keeps
-// its message with annotations compacted (warnings and errors only). It is
-// presentation only — record filtering stays with MinimumLogLevel, and
-// nothing here feeds back into the run.
-// ---------------------------------------------------------------------------
-
-/** Everything one compact line is rendered from; pure and directly testable. */
-export interface CompactLogRecord {
-  readonly date: Date;
-  readonly logLevel: LogLevel.LogLevel;
-  readonly message: unknown;
-  readonly annotations: Readonly<Record<string, unknown>>;
-  /** Pretty-rendered Cause, present only when the record carries one. */
-  readonly cause?: string | undefined;
-}
-
-const levelTag: Partial<Record<LogLevel.LogLevel, string>> = {
-  Trace: "trace",
-  Debug: "debug",
-  Warn: "WARN",
-  Error: "ERROR",
-  Fatal: "FATAL",
-};
-
-const asText = (value: unknown): string => {
-  if (Predicate.isString(value)) return value;
-  try {
-    return JSON.stringify(value) ?? String(value);
-  } catch {
-    return String(value);
-  }
-};
-
-const annotationText = (annotations: Readonly<Record<string, unknown>>): string =>
-  Object.entries(annotations)
-    // Dotted keys are the OTel-convention duplicates of the camelCase
-    // annotations; one copy per line is enough for a human console.
-    .filter(([key]) => !key.includes("."))
-    .map(([key, value]) => `${key}=${asText(value).slice(0, 120)}`)
-    .join(" ");
-
-/** Known engine telemetry messages, rendered as short progress lines. */
-const telemetryLine = (
-  message: string,
-  annotations: Readonly<Record<string, unknown>>,
-): string | undefined => {
-  const toolName = asText(annotations["toolName"] ?? "tool");
-  switch (message) {
-    case "agent tool execution completed":
-      return `✓ tool ${toolName}`;
-    case "agent tool execution failed":
-      return `✗ tool ${toolName} failed`;
-    case "agent tool handler started":
-    case "agent programmatic tool handler started":
-      return `→ tool ${toolName}`;
-    case "agent model call started":
-      return `→ model call`;
-    case "agent run started":
-      return `→ agent ${asText(annotations["agentId"] ?? "run")} started`;
-    default:
-      return undefined;
-  }
-};
-
-/** Render one log record as a single compact console line. */
-export const formatCompactLogLine = (record: CompactLogRecord): string => {
-  const time = record.date.toISOString().slice(11, 19);
-  const messages = Array.isArray(record.message) ? record.message : [record.message];
-  const messageText = messages.map(asText).join(" ");
-  const mapped =
-    messages.length === 1 && Predicate.isString(messages[0])
-      ? telemetryLine(messages[0], record.annotations)
-      : undefined;
-  const tag = levelTag[record.logLevel];
-  let line: string;
-  if (mapped !== undefined) {
-    line = `[${time}] ${tag === undefined ? "" : `${tag} `}${mapped}`;
-  } else {
-    const isSevere =
-      record.logLevel === "Warn" || record.logLevel === "Error" || record.logLevel === "Fatal";
-    const annotations = isSevere ? annotationText(record.annotations) : "";
-    line = `[${time}] ${tag === undefined ? "" : `${tag} `}${messageText}${
-      annotations === "" ? "" : ` · ${annotations}`
-    }`;
-  }
-  return record.cause === undefined ? line : `${line}\n${record.cause}`;
-};
-
-/** The compact Logger; annotations come from the emitting fiber. */
-export const compactReviewLogger: Logger.Logger<unknown, string> = Logger.make((options) =>
-  formatCompactLogLine({
-    date: options.date,
-    logLevel: options.logLevel,
-    message: options.message,
-    annotations: options.fiber.getRef(References.CurrentLogAnnotations),
-    cause: options.cause.reasons.length > 0 ? Cause.pretty(options.cause) : undefined,
-  }),
-);
-
-/**
- * Install the compact console logger and the minimum level for one host run.
- * PR_REVIEW_LOG_LEVEL widens visibility (e.g. "Debug" shows the engine's
- * per-turn and per-handler telemetry); an unknown value fails loudly like
- * every other configuration fault.
- */
-export const compactReviewLoggingLayer: Layer.Layer<never, Config.ConfigError> = Layer.unwrap(
-  Effect.gen(function* () {
-    const level = yield* Config.literals(
-      ["All", "Trace", "Debug", "Info", "Warn", "Error"],
-      "PR_REVIEW_LOG_LEVEL",
-    ).pipe(Config.withDefault<LogLevel.LogLevel>("Info"));
-    return Layer.merge(
-      Logger.layer([Logger.withLeveledConsole(compactReviewLogger)]),
-      Layer.succeed(References.MinimumLogLevel, level),
-    );
-  }),
-);

package/src/internal/profiles.ts

@@ -1,91 +0,0 @@
-import { Schema } from "effect";
-
-// ---------------------------------------------------------------------------
-// Committed capability claims, schema-first: what this package's reviewers
-// promise and — just as deliberately — what they never claim. Deployment
-// class E (ephemeral): one bounded AgentRuntime.run per invocation, no
-// durability, no exactly-once external effects (DUR-003).
-// ---------------------------------------------------------------------------
-
-/** The flat reviewer's committed capability claim. */
-export class PullRequestReviewerProfile extends Schema.Class<PullRequestReviewerProfile>(
-  "@effect-agent/pr-review/PullRequestReviewerProfile",
-)({
-  /** Ephemeral runtime: one bounded AgentRuntime.run per invocation. */
-  deploymentClass: Schema.Literal("E"),
-  /** Every model-callable tool is a read of the pull request; none mutate. */
-  readOnlyToolSurface: Schema.Literal(true),
-  /** The review is posted by the host AFTER the run settles, never by a tool. */
-  publicationOutsideAgentLoop: Schema.Literal(true),
-  /** Finding anchors are validated against the parsed diff before posting. */
-  anchorsValidatedBeforePublication: Schema.Literal(true),
-  /** The live profile is env-gated out of every ordinary test gate. */
-  liveProfileOptIn: Schema.Literal(true),
-  /** Never claimed at any phase (DUR-003). */
-  exactlyOnceExternalEffects: Schema.Literal(false),
-}) {}
-
-export const pullRequestReviewerProfile = PullRequestReviewerProfile.make({
-  deploymentClass: "E",
-  readOnlyToolSurface: true,
-  publicationOutsideAgentLoop: true,
-  anchorsValidatedBeforePublication: true,
-  liveProfileOptIn: true,
-  exactlyOnceExternalEffects: false,
-});
-
-/** The fan-out reviewer's committed capability claim, schema-first. */
-export class FanOutReviewerProfile extends Schema.Class<FanOutReviewerProfile>(
-  "@effect-agent/pr-review/FanOutReviewerProfile",
-)({
-  /** Ephemeral runtime: bounded host-scheduled child runs per invocation. */
-  deploymentClass: Schema.Literal("E"),
-  /** Every model-callable surface is evidence-only; children expose no tools. */
-  readOnlyToolSurface: Schema.Literal(true),
-  /** The review is posted by the host AFTER the run settles, never by a tool. */
-  publicationOutsideAgentLoop: Schema.Literal(true),
-  /** Child findings are untrusted; anchors are validated against the parsed diff. */
-  anchorsValidatedBeforePublication: Schema.Literal(true),
-  /** Host code schedules every pass from the deterministic plan; no coordinator model. */
-  hostScheduledPasses: Schema.Literal(true),
-  /** A failed pass is retried once, then reported and carried as unreviewed scope. */
-  failedPassesRetriedOnceThenCarried: Schema.Literal(true),
-  /** Risk categories and required specialist passes are pure host policy. */
-  hostOwnedRiskClassification: Schema.Literal(true),
-  /** Every host-classified high-risk unit receives a fresh specialist pass. */
-  redundantHighRiskDiscovery: Schema.Literal(true),
-  /** Only exact candidates confirmed by a fresh verifier child may publish. */
-  independentCandidateVerification: Schema.Literal(true),
-  /** No bounded model pipeline proves that a pull request is defect-free. */
-  defectAbsenceProven: Schema.Literal(false),
-  /** The live profile is env-gated out of every ordinary test gate. */
-  liveProfileOptIn: Schema.Literal(true),
-  /** Never claimed at any phase (DUR-003). */
-  exactlyOnceExternalEffects: Schema.Literal(false),
-}) {}
-
-export const fanOutReviewerProfile = FanOutReviewerProfile.make({
-  deploymentClass: "E",
-  readOnlyToolSurface: true,
-  publicationOutsideAgentLoop: true,
-  anchorsValidatedBeforePublication: true,
-  hostScheduledPasses: true,
-  failedPassesRetriedOnceThenCarried: true,
-  hostOwnedRiskClassification: true,
-  redundantHighRiskDiscovery: true,
-  independentCandidateVerification: true,
-  defectAbsenceProven: false,
-  liveProfileOptIn: true,
-  exactlyOnceExternalEffects: false,
-});
-
-export const LIVE_GATE_ENV = "EFFECT_AGENT_LIVE";
-
-/**
- * `EFFECT_AGENT_LIVE=1` plus the named credential is the only enabling
- * combination for live (network, billed) profiles.
- */
-export const liveProfileEnabled = (
-  env: Record<string, string | undefined>,
-  credentialEnv: string,
-): boolean => env[LIVE_GATE_ENV] === "1" && (env[credentialEnv] ?? "") !== "";