@effect-agent/pr-review 0.1.0-beta.28 → 0.1.0-beta.30

package/src/internal/fingerprint.ts

@@ -1,89 +0,0 @@
-import { Crypto, Effect, Encoding } from "effect";
-
-import type { ChangedFile } from "./diff.ts";
-
-// ---------------------------------------------------------------------------
-// Changeset fingerprinting: dedupe re-reviews of an UNCHANGED effective diff.
-// Repositories that auto-merge the base branch into open pull requests fire
-// `synchronize` on every base update; the head SHA moves but the three-dot
-// changeset the reviewer reads is byte-identical. The fingerprint hashes the
-// (ignore-filtered) changeset together with a prompt signature — everything
-// that shapes the review — so a rebase with no content change skips, while a
-// real change, a conflict resolution, or a guidance change reviews again.
-//
-// The reviewer is deployment class E and owns no storage: the fingerprint is
-// embedded in the posted review body as an invisible HTML comment, so the
-// published review itself is the deduplication state.
-// ---------------------------------------------------------------------------
-
-const MARKER_PREFIX = "<!-- effect-agent-pr-review fingerprint=sha256:";
-const MARKER_SUFFIX = " -->";
-const MARKER_PATTERN = /<!-- effect-agent-pr-review fingerprint=sha256:([0-9a-f]{64}) -->/g;
-
-/** Render the invisible review-body marker for one fingerprint. */
-export const renderFingerprintMarker = (fingerprint: string): string =>
-  `${MARKER_PREFIX}${fingerprint}${MARKER_SUFFIX}`;
-
-/** The rendered marker length is fixed; publication reserves room for it. */
-export const FINGERPRINT_MARKER_LENGTH = renderFingerprintMarker("0".repeat(64)).length;
-
-/** Extract the last fingerprint marker in one review body, if any. */
-export const extractFingerprint = (body: string): string | undefined => {
-  let last: string | undefined;
-  for (const match of body.matchAll(MARKER_PATTERN)) {
-    last = match[1];
-  }
-  return last;
-};
-
-/** SHA-256 via `Crypto.Crypto`; unavailable crypto is a defect, not an expected failure. */
-const sha256Hex = Effect.fn("sha256Hex")(function* (
-  text: string,
-): Effect.fn.Return<string, never, Crypto.Crypto> {
-  const crypto = yield* Crypto.Crypto;
-  const digest = yield* crypto.digest("SHA-256", new TextEncoder().encode(text)).pipe(Effect.orDie);
-  return Encoding.encodeHex(digest);
-});
-
-const FIELD = "\u0000";
-const RECORD = "\u0001";
-const SECTION = "\u0002";
-
-/**
- * Unified-diff hunk coordinates describe where a patch applies, not what it
- * changes. A content-equivalent rebase can shift both coordinates while
- * leaving every context/addition/deletion line unchanged, so exclude only
- * those coordinates from the canonical patch representation.
- */
-const canonicalPatch = (patch: string): string =>
-  patch.replace(/^@@ -\d+(?:,\d+)? \+\d+(?:,\d+)? @@/gm, "@@ -_ +_ @@");
-
-/**
- * Canonical changeset encoding: sorted by path so provider ordering never
- * matters, with every review-relevant field of every file.
- */
-const canonicalChangeset = (files: ReadonlyArray<ChangedFile>): string =>
-  files
-    .map(
-      (file) =>
-        `${file.path}${FIELD}${file.status}${FIELD}${String(file.additions)}${FIELD}${String(file.deletions)}${FIELD}${file.patch === undefined ? "" : canonicalPatch(file.patch)}${FIELD}${file.reviewBaseContent ?? ""}${FIELD}${file.reviewHeadContent ?? ""}`,
-    )
-    .sort()
-    .join(RECORD);
-
-/**
- * Fingerprint one review's complete input surface: the (already
- * ignore-filtered) changeset plus the caller's prompt signature — the
- * rendered instructions and any review-shaping options the instructions do
- * not carry.
- */
-export const computeChangesetFingerprint = (
-  files: ReadonlyArray<ChangedFile>,
-  signature: string,
-): Effect.Effect<string, never, Crypto.Crypto> =>
-  sha256Hex(`${canonicalChangeset(files)}${SECTION}${signature}`);
-
-/** Profile fingerprints are SHA-256 over configuration-only signatures. */
-export const computeProfileFingerprint = (
-  signature: string,
-): Effect.Effect<string, never, Crypto.Crypto> => sha256Hex(signature);

package/src/internal/fixtures.ts

@@ -1,148 +0,0 @@
-import { DateTime, Effect, Layer, Option, Ref, Schema } from "effect";
-
-import { ChangedFile } from "./diff.ts";
-import {
-  PriorReviewLookupFailure,
-  PriorReviews,
-  PublishedReview,
-  ReviewPublisher,
-} from "./github.ts";
-import type { ReviewPublicationPlan } from "./render.ts";
-import type { ReviewHeadComparison, ReviewState, ReviewTreeComparison } from "./review-state.ts";
-import {
-  MAX_CHANGED_FILES,
-  MAX_FILE_CHARS,
-  normalizeRepoRelativePath,
-  PullRequestMetadata,
-  PullRequestSource,
-  ReviewInputViolation,
-} from "./source.ts";
-
-// ---------------------------------------------------------------------------
-// Deterministic in-memory adapters for both ports: a fixture pull request
-// serving the PullRequestSource, and a collecting ReviewPublisher recording
-// every plan. Tests, dry runs, and live smokes run against these with no
-// network and no credentials.
-// ---------------------------------------------------------------------------
-
-/** One fixture file: its changeset entry plus optional head content. */
-export class FixtureFile extends Schema.Class<FixtureFile>("@effect-agent/pr-review/FixtureFile")({
-  file: ChangedFile,
-  baseContent: Schema.optionalKey(Schema.String.check(Schema.isMaxLength(MAX_FILE_CHARS))),
-  headContent: Schema.optionalKey(Schema.String.check(Schema.isMaxLength(MAX_FILE_CHARS))),
-}) {}
-
-/** A complete in-memory pull request for tests, dry runs, and live smokes. */
-export class FixturePullRequest extends Schema.Class<FixturePullRequest>(
-  "@effect-agent/pr-review/FixturePullRequest",
-)({
-  metadata: PullRequestMetadata,
-  files: Schema.Array(FixtureFile).check(Schema.isMaxLength(MAX_CHANGED_FILES)),
-}) {}
-
-const requireChanged = (
-  fixture: FixturePullRequest,
-  path: string,
-): Effect.Effect<FixtureFile, ReviewInputViolation> => {
-  const entry = fixture.files.find((candidate) => candidate.file.path === path);
-  return entry === undefined
-    ? Effect.fail(
-        ReviewInputViolation.make({
-          input: path,
-          reason: "Path is not part of this pull request's changeset.",
-        }),
-      )
-    : Effect.succeed(entry);
-};
-
-/** Deterministic `PullRequestSource` over one fixture pull request. */
-export const fixturePullRequestSourceLayer = (
-  fixture: FixturePullRequest,
-): Layer.Layer<PullRequestSource> => {
-  const files = fixture.files.map((entry) =>
-    entry.file.patch !== undefined
-      ? entry.file
-      : ChangedFile.make({
-          ...entry.file,
-          ...(entry.baseContent === undefined ? {} : { reviewBaseContent: entry.baseContent }),
-          ...(entry.headContent === undefined ? {} : { reviewHeadContent: entry.headContent }),
-        }),
-  );
-  return Layer.succeed(PullRequestSource)(
-    PullRequestSource.of({
-      metadata: Effect.succeed(fixture.metadata),
-      changedFiles: Effect.succeed(files),
-      anchorFiles: Effect.succeed(files),
-      readFile: (path) =>
-        Effect.gen(function* () {
-          const relative = yield* normalizeRepoRelativePath(path);
-          const entry = yield* requireChanged(fixture, relative);
-          if (entry.headContent === undefined) {
-            return yield* ReviewInputViolation.make({
-              input: relative,
-              reason: "No head content is available for this file.",
-            });
-          }
-          return entry.headContent;
-        }),
-    }),
-  );
-};
-
-/** In-memory publisher: records every plan and mints a deterministic receipt. */
-export const collectingReviewPublisherLayer = (
-  published: Ref.Ref<ReadonlyArray<ReviewPublicationPlan>>,
-): Layer.Layer<ReviewPublisher> =>
-  Layer.succeed(ReviewPublisher)(
-    ReviewPublisher.of({
-      publish: (plan) =>
-        Ref.update(published, (plans) => [...plans, plan]).pipe(
-          Effect.flatMap(() => Ref.get(published)),
-          Effect.map((plans) =>
-            PublishedReview.make({
-              reviewId: plans.length,
-              url: `memory://review/${plans.length}`,
-              event: plan.event,
-              inlineComments: plan.comments.length,
-              authorNodeId: "BOT_memory-reviewer",
-              submittedAt: DateTime.makeUnsafe(
-                `2026-01-01T00:00:${String(plans.length).padStart(2, "0")}Z`,
-              ),
-            }),
-          ),
-        ),
-    }),
-  );
-
-/** Static `PriorReviews` service for tests: fixed history and comparisons. */
-export const staticPriorReviews = (
-  fingerprint: Option.Option<string>,
-  options: {
-    readonly state?: Option.Option<ReviewState> | undefined;
-    readonly comparison?: ReviewHeadComparison | undefined;
-    readonly treeComparison?: ReviewTreeComparison | undefined;
-  } = {},
-): PriorReviews["Service"] =>
-  PriorReviews.of({
-    latestFingerprint: Effect.succeed(fingerprint),
-    latestState: Effect.succeed(options.state ?? Option.none()),
-    compareHeads: () =>
-      options.comparison === undefined
-        ? Effect.fail(PriorReviewLookupFailure.make({ reason: "no fixture comparison" }))
-        : Effect.succeed(options.comparison),
-    compareTrees: () =>
-      options.treeComparison === undefined
-        ? Effect.fail(PriorReviewLookupFailure.make({ reason: "no fixture tree comparison" }))
-        : Effect.succeed(options.treeComparison),
-  });
-
-/** Layer form for consumers whose Effect explicitly requires `PriorReviews`. */
-export const staticPriorReviewsLayer = (
-  fingerprint: Option.Option<string>,
-  options: {
-    readonly state?: Option.Option<ReviewState> | undefined;
-    readonly comparison?: ReviewHeadComparison | undefined;
-    readonly treeComparison?: ReviewTreeComparison | undefined;
-  } = {},
-): Layer.Layer<PriorReviews> =>
-  Layer.succeed(PriorReviews)(staticPriorReviews(fingerprint, options));

package/src/internal/github-env.ts

@@ -1,164 +0,0 @@
-import { Config, Effect, FileSystem, Layer, Option, Schema } from "effect";
-import type { HttpClient } from "effect/unstable/http";
-
-import type { ReviewAdjudicationHost } from "./adjudication.ts";
-import type { PriorReviews, ReviewPublisher } from "./github.ts";
-import {
-  DEFAULT_GITHUB_REVIEW_AUTHOR_LOGIN,
-  GitHubReviewTarget,
-  gitHubPriorReviewsLayer,
-  gitHubPullRequestSourceLayer,
-  gitHubReviewAdjudicationHostLayer,
-  gitHubReviewPublisherLayer,
-  gitHubReviewRetirementHostLayer,
-} from "./github.ts";
-import type { ReviewProgressReporter } from "./progress.ts";
-import { gitHubReviewProgressLayer } from "./progress.ts";
-import type { ReviewRetirementHost } from "./retirement.ts";
-import type { PullRequestSource } from "./source.ts";
-
-// ---------------------------------------------------------------------------
-// GitHub Actions environment resolution: which pull request to review, from
-// explicit values first and the standard Actions environment second
-// (GITHUB_REPOSITORY, GITHUB_EVENT_PATH, GITHUB_API_URL, GITHUB_TOKEN).
-// Platform-free: FileSystem and Config are Effect services supplied by the
-// host entrypoint.
-// ---------------------------------------------------------------------------
-
-/** The pull request could not be resolved from options or the environment. */
-export class ReviewTargetUnresolved extends Schema.TaggedError<ReviewTargetUnresolved>()(
-  "ReviewTargetUnresolved",
-  {
-    reason: Schema.String,
-  },
-) {
-  override get message() {
-    return this.reason;
-  }
-}
-
-/** The slice of a GitHub Actions event payload this package understands. */
-export const GitHubEventWire = Schema.Struct({
-  pull_request: Schema.optionalKey(
-    Schema.Struct({
-      number: Schema.Int,
-      draft: Schema.optionalKey(Schema.Boolean),
-    }),
-  ),
-  repository: Schema.optionalKey(Schema.Struct({ full_name: Schema.String })),
-});
-export type GitHubEventWire = typeof GitHubEventWire.Type;
-
-const decodeEvent = Schema.decodeUnknownEffect(Schema.fromJsonString(GitHubEventWire));
-
-/** Read and decode the GITHUB_EVENT_PATH payload, or none outside Actions. */
-export const readGitHubEvent = Effect.fn("readGitHubEvent")(function* () {
-  const eventPath = yield* Config.string("GITHUB_EVENT_PATH").pipe(Config.withDefault(""));
-  if (eventPath === "") return Option.none<GitHubEventWire>();
-  const fs = yield* FileSystem.FileSystem;
-  const raw = yield* fs
-    .readFileString(eventPath)
-    .pipe(
-      Effect.mapError((error) =>
-        ReviewTargetUnresolved.make({ reason: `Cannot read event payload: ${error.message}` }),
-      ),
-    );
-  const event = yield* decodeEvent(raw).pipe(
-    Effect.mapError((error) =>
-      ReviewTargetUnresolved.make({ reason: `Cannot decode event payload: ${error.message}` }),
-    ),
-  );
-  return Option.some(event);
-});
-
-export interface ResolvedReviewTarget {
-  readonly repository: string;
-  readonly number: number;
-}
-
-/**
- * Resolve the review target: explicit values win, then GITHUB_REPOSITORY and
- * the pull_request event payload. Fails typed when no target can be named.
- */
-export const resolveReviewTarget = Effect.fn("resolveReviewTarget")(function* (options: {
-  readonly repository?: string | undefined;
-  readonly number?: number | undefined;
-}) {
-  let repository = options.repository ?? "";
-  if (repository === "") {
-    repository = yield* Config.string("GITHUB_REPOSITORY").pipe(Config.withDefault(""));
-  }
-  let number = options.number;
-  if (number === undefined || repository === "") {
-    const event = yield* readGitHubEvent();
-    if (Option.isSome(event)) {
-      number ??= event.value.pull_request?.number;
-      if (repository === "") repository = event.value.repository?.full_name ?? "";
-    }
-  }
-  if (repository === "" || number === undefined) {
-    return yield* ReviewTargetUnresolved.make({
-      reason:
-        "No pull request to review: pass an explicit repository and number, or run inside a GitHub Actions pull_request event.",
-    });
-  }
-  return { repository, number } satisfies ResolvedReviewTarget;
-});
-
-/**
- * Build the GitHub source and publisher Layers for one resolved target,
- * reading GITHUB_API_URL, GITHUB_TOKEN, and PR_REVIEW_AUTHOR_LOGIN from
- * configuration. The returned Layer is the complete GitHub side of a review
- * run.
- */
-export const gitHubReviewLayers = (
-  target: ResolvedReviewTarget,
-): Layer.Layer<
-  | PullRequestSource
-  | ReviewPublisher
-  | PriorReviews
-  | ReviewRetirementHost
-  | ReviewAdjudicationHost
-  | ReviewProgressReporter,
-  Config.ConfigError,
-  HttpClient.HttpClient
-> =>
-  Layer.unwrap(
-    Effect.gen(function* () {
-      const apiUrl = yield* Config.string("GITHUB_API_URL").pipe(
-        Config.withDefault("https://api.github.com"),
-      );
-      const graphqlUrl = yield* Config.string("GITHUB_GRAPHQL_URL").pipe(
-        Config.withDefault(
-          apiUrl === "https://api.github.com"
-            ? "https://api.github.com/graphql"
-            : apiUrl.replace(/\/api\/v3$/, "/api/graphql"),
-        ),
-      );
-      const token = yield* Config.option(Config.redacted("GITHUB_TOKEN"));
-      const reviewAuthorLogin = yield* Config.nonEmptyString("PR_REVIEW_AUTHOR_LOGIN").pipe(
-        Config.withDefault(DEFAULT_GITHUB_REVIEW_AUTHOR_LOGIN),
-      );
-      const targetLayer = GitHubReviewTarget.layer({
-        apiUrl,
-        graphqlUrl,
-        repository: target.repository,
-        number: target.number,
-        token,
-        reviewAuthorLogin,
-      });
-      const adjudicationHostLayer = gitHubReviewAdjudicationHostLayer.pipe(
-        Layer.provide(targetLayer),
-      );
-      return Layer.mergeAll(
-        gitHubPullRequestSourceLayer.pipe(Layer.provide(targetLayer)),
-        gitHubReviewPublisherLayer.pipe(Layer.provide(targetLayer)),
-        gitHubPriorReviewsLayer.pipe(Layer.provide(targetLayer)),
-        gitHubReviewRetirementHostLayer.pipe(Layer.provide(targetLayer)),
-        // Adjudication is an unconditional run dependency, so the public
-        // GitHub bundle owns its target-bound live host explicitly.
-        adjudicationHostLayer,
-        gitHubReviewProgressLayer.pipe(Layer.provide(targetLayer)),
-      );
-    }),
-  );