@dommaker/harness 0.16.6 → 0.16.8

package/src/cli/commands/check.ts

@@ -1,19 +1,20 @@
 /**
  * harness check 命令
- * 
+ *
  * 检查约束是否满足（三层：Iron Laws / Guidelines / Tips）
+ * 工单 23：触发条件与证据检测迁至 core/constraints/context-builder；--preset 接入 applyPreset
  */
 
 import chalk from 'chalk';
 import * as fs from 'fs';
 import * as path from 'path';
-import { exec, execSync } from 'child_process';
-import { execAsync } from '../../utils/exec';
 import { constraintChecker } from '../../core/constraints/checker';
-import { getAllConstraints, IRON_LAWS, GUIDELINES, TIPS } from '../../core/constraints/definitions';
+import { getTraceCollector } from '../../monitoring/traces';
+import { IRON_LAWS, GUIDELINES, TIPS } from '../../core/constraints/definitions';
 import { ProjectConfigLoader } from '../../core/project-config-loader';
-import { detectSourceRoots } from '../../utils/detect-source-roots';
-import type { ConstraintTrigger, ConstraintContext, ConstraintResult } from '../../types/constraint';
+import { buildConstraintContext } from '../../core/constraints/context-builder';
+import { applyPreset } from '../../presets';
+import type { ConstraintTrigger } from '../../types/constraint';
 
 export interface CheckOptions {
   /** 预设名称 */
@@ -26,61 +27,6 @@ export interface CheckOptions {
   projectPath?: string;
 }
 
-/**
- * 从 git diff 获取变更的文件
- */
-async function getChangedFiles(staged: boolean): Promise<string[]> {
-  try {
-    const command = staged ? 'git diff --cached --name-only' : 'git diff --name-only';
-    const { stdout } = await execAsync(command);
-    return stdout.trim().split('\n').filter(Boolean);
-  } catch {
-    return [];
-  }
-}
-
-/**
- * 检查文件所在目录是否在 git HEAD 中不存在（即新目录）
- */
-function isNewDirectory(projectPath: string, filePath: string): boolean {
-  const dir = path.dirname(filePath);
-  try {
-    const output = execSync(`git ls-tree HEAD -- "${dir}"`, { cwd: projectPath, stdio: 'pipe', encoding: 'utf-8' });
-    return String(output).trim().length === 0; // empty output = directory doesn't exist in HEAD
-  } catch {
-    return true; // command failed = assume new
-  }
-}
-
-/**
- * 检测触发条件
- */
-function detectTrigger(changedFiles: string[], options: CheckOptions): ConstraintTrigger {
-  if (options.trigger) return options.trigger;
-
-  // 根据变更文件推断触发条件
-  // 注意：不自动推断 code_implementation——那是 caller 的语义判断。
-  // pre-commit 无法区分"模板编辑"和"逻辑实现"，保守使用 file_modification。
-  const hasTestChange = changedFiles.some(f =>
-    f.includes('.test.') || f.includes('.spec.') || f.includes('__tests__')
-  );
-  const sourceRoots = detectSourceRoots(options.projectPath || process.cwd());
-  const hasModuleChange = changedFiles.some(f =>
-    sourceRoots.some(root => f.startsWith(root + '/') || f.startsWith(root + '\\')) && !f.includes('__tests__')
-  );
-  const projectPath = options.projectPath || process.cwd();
-  const hasModuleCreation = changedFiles.some(f =>
-    sourceRoots.some(root => f.startsWith(root + '/') || f.startsWith(root + '\\')) &&
-    isNewDirectory(projectPath, f)
-  );
-
-  if (hasTestChange && !hasModuleChange) return 'test_creation';
-  if (hasModuleCreation) return 'module_creation';
-  if (hasModuleChange) return 'module_modification';
-
-  return 'file_modification';
-}
-
 /**
  * 执行约束检查
  */
@@ -93,6 +39,7 @@ export async function check(options: CheckOptions): Promise<void> {
     const projectPath = options.projectPath || process.cwd();
     const configLoader = new ProjectConfigLoader(projectPath);
     configLoader.load();
+    constraintChecker.setTraceRecorder(getTraceCollector());
 
     if (configLoader.hasCustomConfig()) {
       const merged = configLoader.mergeConstraints();
@@ -103,32 +50,30 @@ export async function check(options: CheckOptions): Promise<void> {
       }
     }
 
-    // 获取变更文件
-    const changedFiles = await getChangedFiles(options.staged);
+    // 构建上下文（工单 23：触发条件与证据检测收敛至 core/constraints/context-builder）
+    const context = await buildConstraintContext({
+      projectPath: options.projectPath,
+      staged: options.staged,
+      trigger: options.trigger,
+    });
+    const changedFiles = context.changedFiles ?? [];
     if (changedFiles.length > 0) {
       console.log(chalk.gray(`变更文件: ${changedFiles.length} 个`));
     }
+    console.log(chalk.gray(`触发条件: ${context.operation}`));
 
-    // 检测触发条件
-    const trigger = detectTrigger(changedFiles, options);
-    console.log(chalk.gray(`触发条件: ${trigger}`));
-
-    // 构建上下文
-    const context: ConstraintContext = {
-      operation: trigger,
-      projectPath: options.projectPath || process.cwd(),
-      changedFiles,
-      hasTest: changedFiles.some(f => f.includes('.test.') || f.includes('.spec.')),
-      hasFailingTest: await detectFailingTest(projectPath),
-      hasRootCauseInvestigation: detectRootCauseInvestigation(projectPath),
-      hasVerificationEvidence: await detectVerificationEvidence(projectPath),
-      hasReuseCheck: detectReuseCheck(projectPath),
-      hasRequirement: detectRequirement(projectPath),
-      hasWorktree: detectWorktree(projectPath),
-    };
+    // 预设（工单 23：--preset 真正生效；项目自定义配置优先于预设）
+    let presetConfig;
+    if (!configLoader.hasCustomConfig()) {
+      try {
+        presetConfig = applyPreset(options.preset || 'standard');
+      } catch {
+        presetConfig = undefined; // 未知预设名回退内置全集
+      }
+    }
 
     // 执行三层检查
-    const result = await constraintChecker.checkConstraints(context);
+    const result = await constraintChecker.checkConstraints(context, presetConfig);
 
     // 输出结果
     console.log();
@@ -191,150 +136,6 @@ export async function check(options: CheckOptions): Promise<void> {
   }
 }
 
-/**
- * 检测是否有失败的测试记录
- * 扫描 .harness/traces/ 中最近的 trace 记录
- */
-async function detectFailingTest(projectPath: string): Promise<boolean> {
-  try {
-    const tracesDir = path.join(projectPath, '.harness', 'traces');
-    if (!fs.existsSync(tracesDir)) return false;
-
-    const traceFile = path.join(tracesDir, 'execution.log');
-    if (!fs.existsSync(traceFile)) return false;
-
-    const content = fs.readFileSync(traceFile, 'utf-8');
-    const lines = content.trim().split('\n').filter(Boolean);
-    if (lines.length === 0) return false;
-
-    // 检查最近 20 条记录是否有 fail
-    const recent = lines.slice(-20);
-    return recent.some(line => {
-      try {
-        const trace = JSON.parse(line);
-        return trace.result === 'fail';
-      } catch {
-        return false;
-      }
-    });
-  } catch {
-    return false;
-  }
-}
-
-/**
- * 检测是否有根因分析文档
- * 检查 ROOT_CAUSE.md、.harness/diagnoses/、或 git commit 消息
- */
-function detectRootCauseInvestigation(projectPath: string): boolean {
-  // 检查 ROOT_CAUSE.md
-  if (fs.existsSync(path.join(projectPath, 'ROOT_CAUSE.md'))) return true;
-
-  // 检查 .harness/diagnoses/ 目录
-  const diagnosesDir = path.join(projectPath, '.harness', 'diagnoses');
-  if (fs.existsSync(diagnosesDir)) {
-    try {
-      const files = fs.readdirSync(diagnosesDir);
-      if (files.length > 0) return true;
-    } catch {
-      // ignore
-    }
-  }
-
-  return false;
-}
-
-/**
- * 检测是否有验证证据
- * 检查 .harness/traces/ 中最近的成功验证记录
- */
-async function detectVerificationEvidence(projectPath: string): Promise<boolean> {
-  try {
-    const tracesDir = path.join(projectPath, '.harness', 'traces');
-    if (!fs.existsSync(tracesDir)) return false;
-
-    const traceFile = path.join(tracesDir, 'execution.log');
-    if (!fs.existsSync(traceFile)) return false;
-
-    const content = fs.readFileSync(traceFile, 'utf-8');
-    const lines = content.trim().split('\n').filter(Boolean);
-    if (lines.length === 0) return false;
-
-    // 检查最近 10 条记录是否有 pass
-    const recent = lines.slice(-10);
-    return recent.some(line => {
-      try {
-        const trace = JSON.parse(line);
-        return trace.result === 'pass';
-      } catch {
-        return false;
-      }
-    });
-  } catch {
-    return false;
-  }
-}
-
-/**
- * 检测是否有复用检查
- * 检查 .harness/reuse/ 目录或相关文档
- */
-/**
- * 检测是否有需求来源
- * 检查 CLAUDE.md、README.md、specs/、docs/specs/ 等
- */
-function detectRequirement(projectPath: string): boolean {
-  // Check for CLAUDE.md with HARNESS_CONSTRAINTS section
-  const claudeMdPath = path.join(projectPath, 'CLAUDE.md');
-  if (fs.existsSync(claudeMdPath)) {
-    try {
-      const content = fs.readFileSync(claudeMdPath, 'utf-8');
-      if (content.includes('HARNESS_CONSTRAINTS')) {
-        return true;
-      }
-    } catch {
-      // ignore
-    }
-  }
-
-  const indicators = [
-    'README.md',
-    'specs',
-    'docs/specs',
-    '.specs',
-  ];
-  return indicators.some(f => fs.existsSync(path.join(projectPath, f)));
-}
-
-/**
- * 检测是否在 git worktree 中
- */
-function detectWorktree(projectPath: string): boolean {
-  try {
-    const gitDir = path.join(projectPath, '.git');
-    if (fs.existsSync(gitDir)) {
-      const content = fs.readFileSync(gitDir, 'utf-8');
-      // 实际 worktree 的 .git 是文件（指向主 repo），不是目录
-      return content.startsWith('gitdir:');
-    }
-  } catch { /* ignore */ }
-  return false;
-}
-
-function detectReuseCheck(projectPath: string): boolean {
-  const reuseDir = path.join(projectPath, '.harness', 'reuse');
-  if (fs.existsSync(reuseDir)) {
-    try {
-      const files = fs.readdirSync(reuseDir);
-      if (files.length > 0) return true;
-    } catch {
-      // ignore
-    }
-  }
-
-  return false;
-}
-
 /**
  * 智能提示：检查是否需要提示用户下一步操作
  */

package/src/cli/commands/doc-freshness-check.ts

@@ -8,6 +8,7 @@
 import chalk from 'chalk';
 import * as fs from 'fs';
 import * as path from 'path';
+import { walkFiles } from '../../utils/file-walk';
 
 export interface DocFreshnessCheckOptions {
   /** 输出 JSON 格式 */
@@ -149,36 +150,24 @@ export function extractClaims(content: string, filePath: string): ClaimResult[]
 function countGrepMatches(pattern: string, projectPath: string, fileGlob?: string): number {
   const searchDir = projectPath || process.cwd();
   let count = 0;
+  const regex = new RegExp(pattern, 'gi');
 
-  function walkDir(dir: string) {
-    let entries: fs.Dirent[];
+  const files = walkFiles(searchDir, {
+    skipDirs: ['node_modules', 'dist'],
+    skipHidden: true,
+    filter: (name) => !fileGlob || matchGlob(name, fileGlob),
+  });
+
+  for (const fullPath of files) {
     try {
-      entries = fs.readdirSync(dir, { withFileTypes: true });
+      const content = fs.readFileSync(fullPath, 'utf-8');
+      const matches = content.match(regex);
+      if (matches) count += matches.length;
     } catch {
-      return;
-    }
-
-    for (const entry of entries) {
-      if (entry.name.startsWith('.') || entry.name === 'node_modules' || entry.name === 'dist') continue;
-
-      const fullPath = path.join(dir, entry.name);
-      if (entry.isDirectory()) {
-        walkDir(fullPath);
-      } else if (entry.isFile()) {
-        if (fileGlob && !matchGlob(entry.name, fileGlob)) continue;
-        try {
-          const content = fs.readFileSync(fullPath, 'utf-8');
-          const regex = new RegExp(pattern, 'gi');
-          const matches = content.match(regex);
-          if (matches) count += matches.length;
-        } catch {
-          // skip unreadable files
-        }
-      }
+      // skip unreadable files
     }
   }
 
-  walkDir(searchDir);
   return count;
 }
 
@@ -261,7 +250,7 @@ function verifyListClaim(claim: ClaimResult, projectPath: string): ClaimResult {
 /**
  * 验证状态声明：检查标记是否与代码/文件一致
  */
-function verifyStatusClaim(claim: ClaimResult, projectPath: string): ClaimResult {
+function verifyStatusClaim(claim: ClaimResult, _projectPath: string): ClaimResult {
   // 状态声明的验证较复杂，标记为需要人工确认
   return {
     ...claim,

package/src/cli/commands/flow.ts

@@ -10,8 +10,10 @@ import * as path from 'path';
 import * as readline from 'readline';
 import { TraceCollector } from '../../monitoring/traces';
 import { TraceAnalyzer } from '../../monitoring/trace-analyzer';
-import { ConstraintDoctor, Diagnosis } from '../../monitoring/constraint-doctor';
-import { ConstraintEvolver, ConstraintProposal } from '../../monitoring/constraint-evolver';
+import { ConstraintDoctor } from '../../monitoring/constraint-doctor';
+import { ConstraintEvolver } from '../../monitoring/constraint-evolver';
+import { getConstraint } from '../../core/constraints/definitions';
+import type { Diagnosis, ConstraintProposal } from '../../types/monitoring-types';
 import { ConstraintLifecycleRunner, type ExecutionResult } from '../../constraints/lifecycle-runner';
 import type { TraceAnomaly } from '../../types/trace';
 
@@ -168,7 +170,7 @@ export async function flow(options: FlowOptions): Promise<void> {
     console.log(chalk.blue('💡 步骤 3/4: 生成提案'));
     console.log(chalk.gray('────────────────────────────'));
 
-    const evolver = new ConstraintEvolver();
+    const evolver = new ConstraintEvolver(undefined, getConstraint);
     const proposals: ConstraintProposal[] = [];
 
     for (const diagnosis of diagnoses) {

package/src/cli/commands/init.ts

@@ -11,7 +11,7 @@ import * as path from 'path';
 import * as yaml from 'js-yaml';
 import { createExampleCheckpoint, createExampleResolutions } from './validate';
 import { detectSourceRoots } from '../../utils/detect-source-roots';
-import { IRON_LAWS, GUIDELINES, TIPS, getAllConstraints } from '../../core/constraints/definitions';
+import { IRON_LAWS, GUIDELINES, TIPS } from '../../core/constraints/definitions';
 
 export interface InitOptions {
   /** 项目路径 */
@@ -202,7 +202,7 @@ export async function init(options: InitOptions): Promise<void> {
 
   // 创建 GitHub Actions
   if (options.githubActions !== false) {
-    await setupGitHubActions(projectPath, options.preset);
+    await setupGitHubActions(projectPath);
   }
 
   // 治理相关文件生成
@@ -363,7 +363,7 @@ echo "✅ All checks passed"
 /**
  * 设置 GitHub Actions
  */
-async function setupGitHubActions(projectPath: string, preset: string): Promise<void> {
+async function setupGitHubActions(projectPath: string): Promise<void> {
   const workflowsDir = path.join(projectPath, '.github', 'workflows');
   const workflowPath = path.join(workflowsDir, 'harness-check.yml');
 

package/src/cli/commands/posteval-plan.ts

@@ -13,7 +13,6 @@ export interface PostEvalPlanOptions {
 
 const MAX_RETRIES = 3;
 const RETRY_DELAY_MS = 2000;
-const GRACE_PERIOD_MS = parseInt(process.env.POSTEVAL_GRACE_MS || '30000', 10); // 30s total before fallback
 
 async function fetchWithRetry(url: string, body: string, retries: number): Promise<Response> {
   let lastError: any;

package/src/cli/commands/release.ts

@@ -201,7 +201,7 @@ export async function release(options: ReleaseOptions): Promise<void> {
   const origRegistry = await run('npm config get registry', pkgPath);
   await run('npm config set registry https://registry.npmjs.org/', pkgPath);
   console.log(chalk.cyan('📤 Publishing to npm...'));
-  const pub = await run('npm publish --registry https://registry.npmjs.org/', pkgPath, 180_000);
+  await run('npm publish --registry https://registry.npmjs.org/', pkgPath, 180_000);
   await run(`npm config set registry ${origRegistry.stdout}`, pkgPath);
   const verify = await run(`npm view ${pkgName} version --registry https://registry.npmjs.org/`, pkgPath);
   if (verify.stdout.trim() === newVersion) {

package/src/cli/commands/report.ts

@@ -7,6 +7,7 @@
 import chalk from 'chalk';
 import * as fs from 'fs/promises';
 import { ConstraintChecker } from '../../core/constraints/checker';
+import { getTraceCollector } from '../../monitoring/traces';
 import { IRON_LAWS, GUIDELINES, TIPS } from '../../core/constraints/definitions';
 import { executeWithCollect } from '../../failure/constraint-handler';
 import type { ConstraintContext } from '../../types/constraint';
@@ -47,6 +48,7 @@ export async function report(options: ReportOptions): Promise<void> {
 
   const projectPath = options.projectPath || process.cwd();
   const checker = ConstraintChecker.getInstance();
+  checker.setTraceRecorder(getTraceCollector());
 
   const allConstraints = { ...IRON_LAWS, ...GUIDELINES, ...TIPS };
   const totalConstraints = Object.keys(allConstraints).length;

package/src/cli/commands/spec-baseline-check.ts

@@ -8,6 +8,7 @@
 import chalk from 'chalk';
 import * as fs from 'fs';
 import * as path from 'path';
+import { walkFiles } from '../../utils/file-walk';
 
 export interface SpecBaselineCheckOptions {
   /** 项目路径 */
@@ -160,29 +161,21 @@ function checkCodePattern(pattern: string, projectPath: string): { exists: boole
   const found: string[] = [];
   const notFound: string[] = [];
 
+  // 遍历一次，供所有关键词复用（工单 19：walkFiles 收敛）
+  const sourceFiles = walkFiles(projectPath, {
+    skipDirs: ['node_modules', 'dist'],
+    skipHidden: true,
+    filter: (_name, fullPath) => fullPath.endsWith('.ts') || fullPath.endsWith('.js'),
+  });
+
   for (const kw of keywords) {
     let count = 0;
-    function walkDir(dir: string) {
-      let entries: fs.Dirent[];
+    for (const fullPath of sourceFiles) {
       try {
-        entries = fs.readdirSync(dir, { withFileTypes: true });
-      } catch {
-        return;
-      }
-      for (const entry of entries) {
-        if (entry.name.startsWith('.') || entry.name === 'node_modules' || entry.name === 'dist') continue;
-        const fullPath = path.join(dir, entry.name);
-        if (entry.isDirectory()) {
-          walkDir(fullPath);
-        } else if (entry.isFile() && (fullPath.endsWith('.ts') || fullPath.endsWith('.js'))) {
-          try {
-            const content = fs.readFileSync(fullPath, 'utf-8');
-            if (content.includes(kw)) count++;
-          } catch { /* skip */ }
-        }
-      }
+        const content = fs.readFileSync(fullPath, 'utf-8');
+        if (content.includes(kw)) count++;
+      } catch { /* skip */ }
     }
-    walkDir(projectPath);
     if (count > 0) {
       found.push(`${kw} (${count} files)`);
     } else {