@documentation-robotics/cli 0.1.12 → 0.2.0

package/dist/schemas/bundled/testing.json

@@ -1,5 +1,5 @@
 {
-  "specVersion": "0.9.0",
+  "specVersion": "0.10.0",
   "layer": {
     "id": "testing",
     "number": 13,

package/dist/schemas/bundled/ux.json

@@ -1,5 +1,5 @@
 {
-  "specVersion": "0.9.0",
+  "specVersion": "0.10.0",
   "layer": {
     "id": "ux",
     "number": 10,

package/dist/server/server.js

@@ -17,6 +17,7 @@ import { telemetryMiddleware } from "./telemetry-middleware.js";
 import { ClaudeCodeClient } from "../coding-agents/claude-code-client.js";
 import { CopilotClient } from "../coding-agents/copilot-client.js";
 import { detectAvailableClients, selectChatClient } from "../coding-agents/chat-utils.js";
+import { formatForClaudeCode, applyCopilotPermissions } from "../coding-agents/default-permissions.js";
 import { getErrorMessage } from "../utils/errors.js";
 import { AnnotationCreateSchema, AnnotationUpdateSchema, AnnotationReplyCreateSchema, LayerNameSchema, IdSchema, AnnotationFilterSchema, ErrorResponseSchema, HealthResponseSchema, AnnotationSchema, AnnotationReplySchema, AnnotationsListSchema, ChangesetsListSchema, ChangesetDetailSchema, ModelResponseSchema, LayerResponseSchema, SpecResponseSchema, AnnotationRepliesSchema, WSMessageSchema } from "./schemas.js";
 const JSONRPC_ERRORS = {
@@ -62,6 +63,8 @@ class VisualizationServer {
   // Selected chat client for server
   chatInitializationError;
   // Store initialization error for status endpoint
+  _testClaudeCmdOverride;
+  _testCopilotCmdOverride;
   /**
    * Valid spec node IDs per layer
    * Dynamically loaded from compiled spec (spec/dist/{layer}.json at module load time)
@@ -1263,13 +1266,31 @@ class VisualizationServer {
       id: requestId
     }));
   }
+  /**
+   * Build command arguments for Claude Code launch
+   */
+  buildClaudeChatArgs() {
+    const cmd = ["claude", "--agent", "dr-architect", "--print"];
+    return this.withDanger ? cmd.push("--dangerously-skip-permissions") : cmd.push("--allowedTools", formatForClaudeCode()), cmd.push("--verbose", "--output-format", "stream-json"), cmd;
+  }
+  /**
+   * Add permission flags to Copilot command based on withDanger setting
+   * Applies read-safe permissions when withDanger is false, with graceful degradation
+   * if the installed Copilot CLI doesn't support granular permission flags.
+   * @param cmd The command array to modify (will be mutated)
+   * @param variant The Copilot variant for error messages (e.g., "gh copilot" or "copilot")
+   */
+  addCopilotPermissionFlags(cmd, variant) {
+    const copilotCommand = cmd[0] === "gh" ? "gh" : "copilot";
+    applyCopilotPermissions(cmd, variant, copilotCommand, this.withDanger);
+  }
   /**
    * Launch Claude Code CLI with dr-architect agent and stream responses
    */
   async launchClaudeCodeChat(ws, conversationId, message, requestId) {
     try {
-      const cmd = ["claude", "--agent", "dr-architect", "--print"];
-      this.withDanger && cmd.push("--dangerously-skip-permissions"), cmd.push("--verbose", "--output-format", "stream-json");
+      const cmd = this.buildClaudeChatArgs();
+      this._testClaudeCmdOverride && cmd.splice(0, cmd.length, ...this._testClaudeCmdOverride);
       const proc = spawn(cmd[0], cmd.slice(1), {
         cwd: this.model.rootPath,
         stdio: ["pipe", "pipe", "pipe"]
@@ -1424,10 +1445,14 @@ class VisualizationServer {
   async launchCopilotChat(ws, conversationId, message, requestId) {
     try {
       let cmd;
-      const ghResult = spawnSync("gh", ["copilot", "--version"], {
-        stdio: ["ignore", "pipe", "pipe"]
-      });
-      ghResult.error ? console.warn(`[Copilot] 'gh copilot --version' probe failed to spawn: ${getErrorMessage(ghResult.error)}`) : ghResult.status !== 0 && process.env.VERBOSE && console.log(`[Copilot] 'gh copilot' unavailable (exit ${ghResult.status}), falling back to standalone 'copilot'`), ghResult.status === 0 ? (cmd = ["gh", "copilot", "explain"], this.withDanger && cmd.push("--allow-all-tools"), cmd.push(message)) : (cmd = ["copilot", "explain"], this.withDanger && cmd.push("--allow-all-tools"), cmd.push(message));
+      if (this._testCopilotCmdOverride)
+        cmd = [...this._testCopilotCmdOverride];
+      else {
+        const ghResult = spawnSync("gh", ["copilot", "--version"], {
+          stdio: ["ignore", "pipe", "pipe"]
+        });
+        ghResult.error ? console.warn(`[Copilot] 'gh copilot --version' probe failed to spawn: ${getErrorMessage(ghResult.error)}`) : ghResult.status !== 0 && process.env.VERBOSE && console.log(`[Copilot] 'gh copilot' unavailable (exit ${ghResult.status}), falling back to standalone 'copilot'`), ghResult.status === 0 ? (cmd = ["gh", "copilot", "explain"], this.addCopilotPermissionFlags(cmd, "gh copilot"), cmd.push(message)) : (cmd = ["copilot", "explain"], this.addCopilotPermissionFlags(cmd, "copilot"), cmd.push(message));
+      }
       const proc = spawn(cmd[0], cmd.slice(1), {
         cwd: this.model.rootPath,
         stdio: ["pipe", "pipe", "pipe"]
@@ -1497,7 +1522,20 @@ class VisualizationServer {
           }
         }
       })().catch((err) => {
-        console.error(`[Copilot] Stream error: ${getErrorMessage(err)}`);
+        const errorMsg = getErrorMessage(err);
+        console.error(`[Copilot] Stream error: ${errorMsg}`);
+        try {
+          ws.send(JSON.stringify({
+            jsonrpc: "2.0",
+            error: {
+              code: JSONRPC_ERRORS.INTERNAL_ERROR,
+              message: `Stream error: ${errorMsg}`
+            },
+            id: requestId
+          }));
+        } catch (sendError) {
+          console.error(`[Copilot] Failed to send stream error notification: ${getErrorMessage(sendError)}`);
+        }
       });
     } catch (error) {
       const errorMsg = getErrorMessage(error);