@dizzlkheinz/ynab-mcpb 0.17.0 → 0.17.1

package/src/tools/__tests__/transactionTools.integration.test.ts

@@ -9,6 +9,7 @@ import {
   handleUpdateTransactions,
   CreateTransactionsSchema,
 } from '../transactionTools.js';
+import { waitFor } from '../../__tests__/testUtils.js';
 
 const isSkip = ['true', '1', 'yes', 'y', 'on'].includes(
   (process.env['SKIP_E2E_TESTS'] || '').toLowerCase().trim(),
@@ -325,9 +326,22 @@ describeIntegration('Transaction Tools Integration', () => {
           ],
         });
 
-        const afterList = await fetchBudgetTransactions();
-        const transactions =
-          afterList.transactions || afterList.preview_transactions || afterList.transaction_preview;
+        let transactions: any[] | undefined;
+        await waitFor(
+          async () => {
+            const afterList = await fetchBudgetTransactions();
+            transactions =
+              afterList.transactions ||
+              afterList.preview_transactions ||
+              afterList.transaction_preview;
+            return (
+              (transactions as any[])?.some((transaction) => transaction.memo === memo) ?? false
+            );
+          },
+          10000,
+          500,
+        );
+
         expect(transactions).toBeDefined();
         expect((transactions as any[]).some((transaction) => transaction.memo === memo)).toBe(true);
       },
@@ -576,6 +590,19 @@ describeIntegration('Transaction Tools Integration', () => {
         expect(updateResponse.results[1].correlation_key).toBe(transactionIds[1]);
 
         // Verify changes persisted
+        await waitFor(
+          async () => {
+            const getResult1 = await handleGetTransaction(ynabAPI, {
+              budget_id: testBudgetId,
+              transaction_id: transactionIds[0],
+            });
+            const transaction1 = parseToolResult(getResult1).transaction;
+            return transaction1.amount === -7.5 && transaction1.memo === 'Updated memo 1';
+          },
+          10000,
+          500,
+        );
+
         const getResult1 = await handleGetTransaction(ynabAPI, {
           budget_id: testBudgetId,
           transaction_id: transactionIds[0],
@@ -584,6 +611,19 @@ describeIntegration('Transaction Tools Integration', () => {
         expect(transaction1.amount).toBe(-7.5);
         expect(transaction1.memo).toBe('Updated memo 1');
 
+        await waitFor(
+          async () => {
+            const getResult2 = await handleGetTransaction(ynabAPI, {
+              budget_id: testBudgetId,
+              transaction_id: transactionIds[1],
+            });
+            const transaction2 = parseToolResult(getResult2).transaction;
+            return transaction2.memo === 'Updated memo 2' && transaction2.cleared === 'cleared';
+          },
+          10000,
+          500,
+        );
+
         const getResult2 = await handleGetTransaction(ynabAPI, {
           budget_id: testBudgetId,
           transaction_id: transactionIds[1],
@@ -635,6 +675,19 @@ describeIntegration('Transaction Tools Integration', () => {
         expect(updateResponse.summary.updated).toBe(1);
 
         // Verify change
+        await waitFor(
+          async () => {
+            const getResult = await handleGetTransaction(ynabAPI, {
+              budget_id: testBudgetId,
+              transaction_id: transactionId,
+            });
+            const transaction = parseToolResult(getResult).transaction;
+            return transaction.memo === 'Updated without metadata';
+          },
+          10000,
+          500,
+        );
+
         const getResult = await handleGetTransaction(ynabAPI, {
           budget_id: testBudgetId,
           transaction_id: transactionId,
@@ -749,6 +802,13 @@ describeIntegration('Transaction Tools Integration', () => {
         });
 
         const updateResponse = parseToolResult(updateResult);
+
+        if (updateResponse.error) {
+          throw new Error(
+            `Tool execution failed unexpectedly: ${JSON.stringify(updateResponse.error)}`,
+          );
+        }
+
         expect(updateResponse.summary.total_requested).toBe(2);
         expect(updateResponse.summary.updated).toBe(1);
         expect(updateResponse.summary.failed).toBeGreaterThan(0);

package/src/tools/__tests__/utilityTools.integration.test.ts

@@ -1,6 +1,6 @@
 import { describe, it, expect, beforeAll } from 'vitest';
 import * as ynab from 'ynab';
-import { handleGetUser, handleConvertAmount } from '../utilityTools.js';
+import { handleGetUser } from '../utilityTools.js';
 import { skipOnRateLimit } from '../../__tests__/testUtils.js';
 
 /**
@@ -41,88 +41,4 @@ describeIntegration('Utility Tools Integration Tests', () => {
       },
     );
   });
-
-  describe('handleConvertAmount', () => {
-    it(
-      'should convert various dollar amounts to milliunits',
-      { meta: { tier: 'domain', domain: 'utility' } },
-      async () => {
-        const testCases = [
-          { dollars: 1.0, expectedMilliunits: 1000 },
-          { dollars: 0.01, expectedMilliunits: 10 },
-          { dollars: 10.5, expectedMilliunits: 10500 },
-          { dollars: 999.99, expectedMilliunits: 999990 },
-          { dollars: 0, expectedMilliunits: 0 },
-          { dollars: -5.25, expectedMilliunits: -5250 },
-        ];
-
-        for (const testCase of testCases) {
-          const result = await handleConvertAmount({
-            amount: testCase.dollars,
-            to_milliunits: true,
-          });
-          const response = JSON.parse(result.content[0].text);
-
-          expect(response.conversion.converted_amount).toBe(testCase.expectedMilliunits);
-          expect(response.conversion.to_milliunits).toBe(true);
-          expect(response.conversion.description).toContain(`$${testCase.dollars.toFixed(2)}`);
-          expect(response.conversion.description).toContain(
-            `${testCase.expectedMilliunits} milliunits`,
-          );
-        }
-      },
-    );
-
-    it(
-      'should convert various milliunit amounts to dollars',
-      { meta: { tier: 'domain', domain: 'utility' } },
-      async () => {
-        const testCases = [
-          { milliunits: 1000, expectedDollars: 1.0 },
-          { milliunits: 10, expectedDollars: 0.01 },
-          { milliunits: 10500, expectedDollars: 10.5 },
-          { milliunits: 999990, expectedDollars: 999.99 },
-          { milliunits: 0, expectedDollars: 0 },
-          { milliunits: -5250, expectedDollars: -5.25 },
-        ];
-
-        for (const testCase of testCases) {
-          const result = await handleConvertAmount({
-            amount: testCase.milliunits,
-            to_milliunits: false,
-          });
-          const response = JSON.parse(result.content[0].text);
-
-          expect(response.conversion.converted_amount).toBe(testCase.expectedDollars);
-          expect(response.conversion.to_milliunits).toBe(false);
-          expect(response.conversion.description).toContain(`${testCase.milliunits} milliunits`);
-          expect(response.conversion.description).toContain(
-            `$${testCase.expectedDollars.toFixed(2)}`,
-          );
-        }
-      },
-    );
-
-    it(
-      'should handle precision edge cases',
-      { meta: { tier: 'domain', domain: 'utility' } },
-      async () => {
-        // Test floating-point precision issues
-        const precisionTests = [
-          { amount: 0.1 + 0.2, to_milliunits: true }, // Should handle 0.30000000000000004
-          { amount: 1.005, to_milliunits: true }, // Should round correctly
-          { amount: 999.999, to_milliunits: true }, // Should handle near-integer values
-        ];
-
-        for (const test of precisionTests) {
-          const result = await handleConvertAmount(test);
-          const response = JSON.parse(result.content[0].text);
-
-          expect(response.conversion).toHaveProperty('converted_amount');
-          expect(typeof response.conversion.converted_amount).toBe('number');
-          expect(Number.isInteger(response.conversion.converted_amount)).toBe(true);
-        }
-      },
-    );
-  });
 });

package/src/tools/__tests__/utilityTools.test.ts

@@ -1,6 +1,6 @@
 import { describe, it, expect, vi, beforeEach } from 'vitest';
 import * as ynab from 'ynab';
-import { handleGetUser, handleConvertAmount, ConvertAmountSchema } from '../utilityTools.js';
+import { handleGetUser } from '../utilityTools.js';
 
 // Mock the YNAB API
 const mockYnabAPI = {
@@ -80,126 +80,4 @@ describe('Utility Tools', () => {
       expect(result.content[0].text).toContain('Failed to get user information');
     });
   });
-
-  describe('handleConvertAmount', () => {
-    it('should convert dollars to milliunits correctly', async () => {
-      const params = { amount: 10.5, to_milliunits: true };
-
-      const result = await handleConvertAmount(mockYnabAPI, params);
-      const response = JSON.parse(result.content[0].text);
-
-      expect(response.conversion.original_amount).toBe(10.5);
-      expect(response.conversion.converted_amount).toBe(10500);
-      expect(response.conversion.to_milliunits).toBe(true);
-      expect(response.conversion.description).toBe('$10.50 = 10500 milliunits');
-    });
-
-    it('should convert milliunits to dollars correctly', async () => {
-      const params = { amount: 10500, to_milliunits: false };
-
-      const result = await handleConvertAmount(mockYnabAPI, params);
-      const response = JSON.parse(result.content[0].text);
-
-      expect(response.conversion.original_amount).toBe(10500);
-      expect(response.conversion.converted_amount).toBe(10.5);
-      expect(response.conversion.to_milliunits).toBe(false);
-      expect(response.conversion.description).toBe('10500 milliunits = $10.50');
-    });
-
-    it('should handle zero amounts', async () => {
-      const params = { amount: 0, to_milliunits: true };
-
-      const result = await handleConvertAmount(mockYnabAPI, params);
-      const response = JSON.parse(result.content[0].text);
-
-      expect(response.conversion.original_amount).toBe(0);
-      expect(response.conversion.converted_amount).toBe(0);
-      expect(response.conversion.description).toBe('$0.00 = 0 milliunits');
-    });
-
-    it('should handle negative amounts', async () => {
-      const params = { amount: -5.25, to_milliunits: true };
-
-      const result = await handleConvertAmount(mockYnabAPI, params);
-      const response = JSON.parse(result.content[0].text);
-
-      expect(response.conversion.original_amount).toBe(-5.25);
-      expect(response.conversion.converted_amount).toBe(-5250);
-      expect(response.conversion.description).toBe('$-5.25 = -5250 milliunits');
-    });
-
-    it('should handle floating-point precision correctly', async () => {
-      const params = { amount: 0.01, to_milliunits: true };
-
-      const result = await handleConvertAmount(mockYnabAPI, params);
-      const response = JSON.parse(result.content[0].text);
-
-      expect(response.conversion.converted_amount).toBe(10);
-    });
-
-    it('should handle large amounts', async () => {
-      const params = { amount: 999999.99, to_milliunits: true };
-
-      const result = await handleConvertAmount(mockYnabAPI, params);
-      const response = JSON.parse(result.content[0].text);
-
-      expect(response.conversion.converted_amount).toBe(999999990);
-    });
-
-    it('should round to nearest milliunit when converting from dollars', async () => {
-      const params = { amount: 10.5555, to_milliunits: true };
-
-      const result = await handleConvertAmount(mockYnabAPI, params);
-      const response = JSON.parse(result.content[0].text);
-
-      expect(response.conversion.converted_amount).toBe(10556); // Rounded from 10555.5
-    });
-  });
-
-  describe('ConvertAmountSchema validation', () => {
-    it('should validate correct parameters', () => {
-      const validParams = { amount: 10.5, to_milliunits: true };
-      const result = ConvertAmountSchema.safeParse(validParams);
-
-      expect(result.success).toBe(true);
-      if (result.success) {
-        expect(result.data).toEqual(validParams);
-      }
-    });
-
-    it('should reject non-finite numbers', () => {
-      const invalidParams = { amount: Infinity, to_milliunits: true };
-      const result = ConvertAmountSchema.safeParse(invalidParams);
-
-      expect(result.success).toBe(false);
-    });
-
-    it('should reject NaN values', () => {
-      const invalidParams = { amount: NaN, to_milliunits: true };
-      const result = ConvertAmountSchema.safeParse(invalidParams);
-
-      expect(result.success).toBe(false);
-    });
-
-    it('should reject missing amount parameter', () => {
-      const invalidParams = { to_milliunits: true };
-      const result = ConvertAmountSchema.safeParse(invalidParams);
-
-      expect(result.success).toBe(false);
-    });
-
-    it('should reject missing to_milliunits parameter', () => {
-      const invalidParams = { amount: 10.5 };
-      const result = ConvertAmountSchema.safeParse(invalidParams);
-
-      expect(result.success).toBe(false);
-    });
-
-    it('should reject non-boolean to_milliunits parameter', () => {
-      const invalidParams = { amount: 10.5, to_milliunits: 'true' };
-      const result = ConvertAmountSchema.safeParse(invalidParams);
-
-      expect(result.success).toBe(false);
-    });
-  });
 });

package/src/tools/schemas/outputs/index.ts

@@ -25,8 +25,6 @@
 export {
   GetUserOutputSchema,
   type GetUserOutput,
-  ConvertAmountOutputSchema,
-  type ConvertAmountOutput,
   GetDefaultBudgetOutputSchema,
   type GetDefaultBudgetOutput,
   SetDefaultBudgetOutputSchema,
@@ -44,7 +42,6 @@ export {
 // Nested schemas that may be useful independently
 export {
   UserSchema,
-  ConversionSchema,
   DateFormatSchema,
   CurrencyFormatSchema,
   BudgetDetailSchema,

package/src/tools/schemas/outputs/utilityOutputs.ts

@@ -2,8 +2,8 @@
  * @fileoverview Output schemas for utility tools
  *
  * This file contains comprehensive Zod schemas for validating the output
- * of utility tools including user info, amount conversion, budget defaults,
- * cache management, output formatting, and diagnostic information.
+ * of utility tools including user info, budget defaults, cache management,
+ * output formatting, and diagnostic information.
  *
  * All schemas include TypeScript type inference for type-safe usage throughout
  * the codebase. Reference the corresponding handler implementations for
@@ -46,47 +46,6 @@ export const GetUserOutputSchema = z.object({
 
 export type GetUserOutput = z.infer<typeof GetUserOutputSchema>;
 
-// ============================================================================
-// CONVERT AMOUNT OUTPUT
-// ============================================================================
-
-/**
- * Schema for amount conversion details
- *
- * Contains the conversion result between dollars and YNAB milliunits.
- */
-export const ConversionSchema = z.object({
-  original_amount: z.number(),
-  converted_amount: z.number(),
-  to_milliunits: z.boolean(),
-  description: z.string(),
-});
-
-/**
- * Output schema for convert_amount tool
- *
- * Converts between dollars and YNAB milliunits (1 dollar = 1000 milliunits).
- *
- * @see src/tools/utilityTools.ts:51-90 - Handler implementation
- *
- * @example
- * ```typescript
- * const output: ConvertAmountOutput = {
- *   conversion: {
- *     original_amount: 25.50,
- *     converted_amount: 25500,
- *     to_milliunits: true,
- *     description: "$25.50 converted to 25500 milliunits"
- *   }
- * };
- * ```
- */
-export const ConvertAmountOutputSchema = z.object({
-  conversion: ConversionSchema,
-});
-
-export type ConvertAmountOutput = z.infer<typeof ConvertAmountOutputSchema>;
-
 // ============================================================================
 // GET DEFAULT BUDGET OUTPUT
 // ============================================================================

package/src/tools/toolCategories.ts

@@ -120,7 +120,6 @@ export const ToolAnnotationPresets = {
    * interacting with the YNAB API.
    *
    * Examples:
-   * - convert_amount: Converts between dollars and milliunits
    * - set_output_format: Configures local output formatting
    * - diagnostic_info: Returns local server diagnostic information
    * - clear_cache: Clears local in-memory cache

package/src/tools/utilityTools.ts

@@ -1,6 +1,5 @@
 import { CallToolResult } from '@modelcontextprotocol/sdk/types.js';
 import * as ynab from 'ynab';
-import { z } from 'zod/v4';
 import { responseFormatter } from '../server/responseFormatter.js';
 import { withToolErrorHandling } from '../types/index.js';
 import { createAdapters } from './adapters.js';
@@ -8,18 +7,6 @@ import { emptyObjectSchema } from './schemas/common.js';
 import { ToolAnnotationPresets } from './toolCategories.js';
 import type { ToolFactory } from '../types/toolRegistration.js';
 
-/**
- * Schema for ynab:convert_amount tool parameters
- */
-export const ConvertAmountSchema = z
-  .object({
-    amount: z.number().finite(),
-    to_milliunits: z.boolean(),
-  })
-  .strict();
-
-export type ConvertAmountParams = z.infer<typeof ConvertAmountSchema>;
-
 /**
  * Handles the ynab:get_user tool call
  * Gets information about the authenticated user
@@ -49,58 +36,13 @@ export async function handleGetUser(ynabAPI: ynab.API): Promise<CallToolResult>
 }
 
 /**
- * Handles the ynab:convert_amount tool call
- * Converts between dollars and milliunits with integer arithmetic for precision
- */
-export async function handleConvertAmount(
-  _ynabAPI: ynab.API,
-  params: ConvertAmountParams,
-): Promise<CallToolResult> {
-  return await withToolErrorHandling(
-    async () => {
-      const { amount, to_milliunits } = params;
-
-      let result: number;
-      let description: string;
-
-      if (to_milliunits) {
-        // Convert from dollars to milliunits
-        // Use integer arithmetic to avoid floating-point precision issues
-        result = Math.round(amount * 1000);
-        description = `$${amount.toFixed(2)} = ${result} milliunits`;
-      } else {
-        // Convert from milliunits to dollars
-        // Assume input amount is in milliunits
-        result = amount / 1000;
-        description = `${amount} milliunits = $${result.toFixed(2)}`;
-      }
-
-      return {
-        content: [
-          {
-            type: 'text',
-            text: responseFormatter.format({
-              conversion: {
-                original_amount: amount,
-                converted_amount: result,
-                to_milliunits,
-                description,
-              },
-            }),
-          },
-        ],
-      };
-    },
-    'ynab:convert_amount',
-    'converting amount',
-  );
-}
-
-/**
- * Registers utility tools (get_user, convert_amount) using the shared factory pattern.
+ * Registers utility tools (get_user) using the shared factory pattern.
+ *
+ * Note: convert_amount was removed because all tool responses already return
+ * amounts in dollars (converted from YNAB milliunits internally).
  */
 export const registerUtilityTools: ToolFactory = (registry, context) => {
-  const { adapt, adaptNoInput } = createAdapters(context);
+  const { adaptNoInput } = createAdapters(context);
 
   registry.register({
     name: 'get_user',
@@ -114,17 +56,4 @@ export const registerUtilityTools: ToolFactory = (registry, context) => {
       },
     },
   });
-
-  registry.register({
-    name: 'convert_amount',
-    description: 'Convert between dollars and milliunits with integer arithmetic for precision',
-    inputSchema: ConvertAmountSchema,
-    handler: adapt(handleConvertAmount),
-    metadata: {
-      annotations: {
-        ...ToolAnnotationPresets.UTILITY_LOCAL,
-        title: 'YNAB: Convert Amount',
-      },
-    },
-  });
 };

package/vitest.config.ts

@@ -1,6 +1,7 @@
 import { defineConfig } from 'vitest/config';
 
 const integrationFiles = ['src/**/*.integration.test.ts'];
+const isVerbose = !!process.env['VERBOSE_TESTS'];
 
 export default defineConfig({
   test: {
@@ -83,7 +84,7 @@ export default defineConfig({
         },
       },
     },
-    reporters: ['verbose', 'html', './vitest-reporters/split-json-reporter.ts'],
+    reporters: [isVerbose ? 'verbose' : 'dot', 'html', './vitest-reporters/split-json-reporter.ts'],
     outputFile: {
       html: './test-results/index.html',
     },

package/.chunkhound.json

@@ -1,11 +0,0 @@
-{
-  "embedding": {
-    "provider": "voyageai",
-    "model": "voyage-3.5",
-    "api_key": "pa-Q1WewxKAEUA6QeYTmreQmY11ufEk9mKIK0DfoqqZhV6",
-    "rerank_model": "rerank-2.5"
-  },
-  "llm": {
-    "provider": "claude-code-cli"
-  }
-}

package/.code/agents/0098661e-0fa3-4990-beb9-c0cbf3f123aa/status.txt

@@ -1 +0,0 @@
-Agent cancelled

package/.code/agents/01a13ef4-3f23-4f52-b33b-3585b73cfa60/error.txt

@@ -1,3 +0,0 @@
-Command failed: Error loading configuration: config profile `From the repo root, list top-level files and directories using ls or dir, then exit. No file writes or edits.
-
-[Running in read-only mode - no modifications allowed]` not found

package/.code/agents/084fd32f-e298-4728-9103-a78d7dc39613/error.txt

@@ -1,3 +0,0 @@
-Command failed: Error loading configuration: config profile `From the repo root, just run `pwd` and then exit. Do not modify any files.
-
-[Running in read-only mode - no modifications allowed]` not found

package/.code/agents/0fed51e1-a943-4b97-a2a8-a6f0f27c844d/status.txt

@@ -1 +0,0 @@
-Agent cancelled

package/.code/agents/1059b6bd-5ccd-4d83-a12c-7c9d89137399/error.txt

@@ -1,5 +0,0 @@
-Command failed: ParserError: 
-Line |
-   5 |  [Running in read-only mode - no modifications allowed]
-     |          ~
-     | Missing ] at end of attribute or type literal.