@dizzlkheinz/ynab-mcpb 0.17.0 → 0.17.1

package/.code/agents/292aa3ff-dbab-470f-97c9-e7e8fd65e0db/result.txt

@@ -1,144 +0,0 @@
-Note: I’m running in a read‑only sandbox with no escalation, so I can’t execute `node "$HOME/.codex/superpowers/.codex/superpowers-codex" bootstrap` here; you’ll need to run that manually outside this environment.
-
-Below is a concrete implementation plan for the next iteration, focused on tightening type safety for mutation dry‑run outputs and exercising them via tests. Tasks are sized to ~2–5 minutes each and follow a TDD flow.
-
-**Iteration Theme**
-
-- Strengthen type safety for transaction mutation dry‑run responses by replacing `z.record(z.string(), z.unknown())` with strongly‑typed request schemas, and ensure handlers + tests are aligned.
-
----
-
-**Phase 0 – Context & Scoping**
-
-- Skim `SCHEMA_IMPROVEMENT_SUMMARY.md` again to align with the existing discriminated‑union pattern used for reconciliation outputs.
-- Review current output schemas in `src/tools/schemas/outputs/transactionMutationOutputs.ts` (dry‑run branches for `CreateTransactionOutputSchema`, `UpdateTransactionOutputSchema`, `DeleteTransactionOutputSchema`).
-- Review corresponding handlers in `src/tools/transactionTools.ts` (dry‑run branches in `handleCreateTransaction`, `handleUpdateTransaction`, `handleDeleteTransaction`).
-- Review existing tests touching these areas:
-  - Schema tests: `src/tools/schemas/outputs/__tests__/transactionMutationSchemas.test.ts`
-  - Tool unit tests: `src/tools/__tests__/transactionTools.test.ts`
-  - E2E transaction workflow: `src/__tests__/workflows.e2e.test.ts`
-
----
-
-**Phase 1 – TDD for New Dry‑Run Request Schemas (Schemas Layer)**
-
-1. In `src/tools/schemas/outputs/transactionMutationOutputs.ts`, identify the three dry‑run `request` fields that still use `z.record(z.string(), z.unknown())`.
-2. Design target request shapes:
-   - `CreateTransactionDryRunRequestSchema`: mirror `CreateTransactionSchema` from `src/tools/transactionTools.ts` but omit `budget_id` and `dry_run`, and keep only fields that actually affect the YNAB API call (`account_id`, `amount`, `date`, `payee_*`, `category_id`, `memo`, `cleared`, `approved`, `flag_color`, `import_id`, `subtransactions`).
-   - `UpdateTransactionDryRunRequestSchema`: mirror `UpdateTransactionSchema` but omit `budget_id`, `dry_run`; keep `transaction_id` plus the updatable fields (`account_id`, `amount`, `date`, `payee_*`, `category_id`, `memo`, `cleared`, `approved`, `flag_color`).
-   - `DeleteTransactionDryRunRequestSchema`: mirror `DeleteTransactionSchema` but omit `budget_id`, `dry_run`; keep `transaction_id`.
-3. In `src/tools/schemas/outputs/__tests__/transactionMutationSchemas.test.ts`, add new `describe` blocks (or extend existing ones) for:
-   - `CreateTransactionOutputSchema` dry‑run branch:
-     - Accepts a `request` object matching `CreateTransactionDryRunRequestSchema` (no `budget_id`, no `dry_run`).
-     - Rejects payloads where `request` is missing required fields (e.g., no `account_id`, no `date`, or missing `amount`).
-     - Rejects payloads where `request` includes obviously wrong shapes (e.g., non‑ISO `date`), using schema’s existing validation.
-   - `UpdateTransactionOutputSchema` dry‑run branch:
-     - Accepts minimal valid request (`transaction_id` only) and one with optional fields.
-     - Rejects requests missing `transaction_id`.
-   - `DeleteTransactionOutputSchema` dry‑run branch:
-     - Accepts `{ transaction_id: '...' }` and no extra required fields.
-     - Rejects requests missing `transaction_id`.
-4. Add negative tests in the same file asserting that generic `z.record`‑style payloads (e.g., arbitrary key/value maps or requests including `budget_id`, `dry_run`) are rejected by the new schemas.
-5. Run only the schema tests to see them fail initially:
-   - `npm run test:unit -- src/tools/schemas/outputs/__tests__/transactionMutationSchemas.test.ts`
-
----
-
-**Phase 2 – Implement Strongly‑Typed Dry‑Run Request Schemas**
-
-6. In `src/tools/schemas/outputs/transactionMutationOutputs.ts`, define:
-   - `CreateTransactionDryRunRequestSchema` using `z.object({ ... })` or `CreateTransactionSchema.omit({ budget_id: true, dry_run: true })` (import `CreateTransactionSchema` if you prefer reuse).
-   - `UpdateTransactionDryRunRequestSchema` similarly from `UpdateTransactionSchema` or a dedicated `z.object`.
-   - `DeleteTransactionDryRunRequestSchema` similarly from `DeleteTransactionSchema`.
-   - Export TypeScript types using `z.infer<...>` for each new schema.
-7. Replace the dry‑run `request` fields:
-   - `CreateTransactionOutputSchema` dry‑run branch: `request: CreateTransactionDryRunRequestSchema`.
-   - `UpdateTransactionOutputSchema` dry‑run branch: `request: UpdateTransactionDryRunRequestSchema`.
-   - `DeleteTransactionOutputSchema` dry‑run branch: `request: DeleteTransactionDryRunRequestSchema`.
-8. Ensure unions remain backward compatible:
-   - Keep the non‑dry‑run branches unchanged.
-   - Preserve `.passthrough()` where it’s used for forward‑compatible metadata.
-9. Re‑run the schema tests:
-   - `npm run test:unit -- src/tools/schemas/outputs/__tests__/transactionMutationSchemas.test.ts`
-   - Fix any mismatches between tests and actual schema shapes until green.
-
----
-
-**Phase 3 – TDD for Handler Output Shape Changes (Tools Layer)**
-
-10. In `src/tools/__tests__/transactionTools.test.ts`, locate the `handleCreateTransaction` dry‑run test (`should not invalidate cache on dry_run transaction creation`).
-11. Update that test so it asserts:
-    - `parsedContent.dry_run === true` and `parsedContent.action === 'create_transaction'`.
-    - `parsedContent.request`:
-      - Does not include `budget_id` or `dry_run`.
-      - Contains only the transaction fields expected by `CreateTransactionDryRunRequestSchema`.
-12. Add a new unit test for `handleUpdateTransaction` dry‑run behavior:
-    - Call `handleUpdateTransaction(mockYnabAPI, { budget_id, transaction_id, amount, dry_run: true })`.
-    - Assert:
-      - No API calls are made.
-      - Parsed JSON has `dry_run: true`, `action: 'update_transaction'`.
-      - `request` includes `transaction_id` and any optional fields you passed, but not `budget_id` or `dry_run`.
-13. Add a complementary unit test for `handleDeleteTransaction` dry‑run behavior:
-    - Call `handleDeleteTransaction(mockYnabAPI, { budget_id, transaction_id, dry_run: true })`.
-    - Assert:
-      - No API calls are made.
-      - Parsed JSON has `dry_run: true`, `action: 'delete_transaction'`.
-      - `request` is `{ transaction_id: '...' }` only.
-14. Run only the transaction tool unit tests to see failures before implementation:
-    - `npm run test:unit -- src/tools/__tests__/transactionTools.test.ts`
-
----
-
-**Phase 4 – Implement Handler Changes to Match New Schemas**
-
-15. In `src/tools/transactionTools.ts`, update the dry‑run branch of `handleCreateTransaction`:
-    - Instead of `request: params`, construct a new object that:
-      - Copies only transaction‑related fields: `account_id`, `amount`, `date`, `payee_*`, `category_id`, `memo`, `cleared`, `approved`, `flag_color`, `import_id`, `subtransactions`.
-      - Excludes `budget_id` and `dry_run`.
-    - Ensure this object’s shape matches `CreateTransactionDryRunRequestSchema`.
-16. Update the dry‑run branch of `handleUpdateTransaction`:
-    - Build `request` containing `transaction_id` plus any provided update fields (`account_id`, `amount`, `date`, etc.).
-    - Exclude `budget_id` and `dry_run` from the `request` object.
-17. Update the dry‑run branch of `handleDeleteTransaction`:
-    - Set `request: { transaction_id: params.transaction_id }` (and nothing else).
-18. Re‑run the relevant unit tests:
-    - `npm run test:unit -- src/tools/__tests__/transactionTools.test.ts`
-    - Iterate until the dry‑run shape tests pass.
-
----
-
-**Phase 5 – Integration & E2E Validation**
-
-19. In `src/tools/__tests__/transactionTools.integration.test.ts`, optionally add a focused integration test (if not already covered) that:
-    - Calls each of the three handlers in dry‑run mode with realistic params.
-    - Parses the output and asserts it validates against `CreateTransactionOutputSchema`, `UpdateTransactionOutputSchema`, `DeleteTransactionOutputSchema` using the shared validation helper (if available).
-20. In `src/__tests__/workflows.e2e.test.ts`, add a small E2E segment under “Complete Transaction Management Workflow” that:
-    - Calls `ynab:create_transaction` with `dry_run: true`.
-    - Uses `validateOutputSchema(server, 'create_transaction', result)` and asserts `valid === true`.
-    - Asserts the `data` payload contains the new, typed `request` shape (no `budget_id` / `dry_run` in `request`).
-21. Run narrower test suites first:
-    - `npm run test:unit`
-    - `npm run test:integration`
-22. When green, run the full test suite + build to ensure no regressions:
-    - `npm test`
-    - `npm run lint`
-    - `npm run build`
-    - Optionally: `npm run build:prod` and `npm run package:mcpb` if this will cut a new release.
-
----
-
-**Phase 6 – Documentation & Release Hygiene**
-
-23. Update any internal docs referencing dry‑run shapes:
-    - Check `docs/reference/API.md` and any tool‑specific docs for transaction mutation tools; adjust examples so `request` shows the new, typed payloads.
-24. In `CHANGELOG.md`, add an entry for the next patch version (e.g., `0.13.5`) summarizing:
-    - “Improve transaction mutation dry‑run output typing for create/update/delete_transaction tools; no breaking changes to success payloads.”
-25. Run quick formatting checks:
-    - `npm run format:check`
-    - `npm run lint` (again if needed).
-26. If everything is green, prepare the PR:
-    - Ensure `TESTING_NOTES.md` / `.pr-description.md` mention:
-      - Tests run (`npm run test:unit`, `npm run test:integration`, `npm test`, `npm run build`).
-      - That changes are backward‑compatible for non‑dry‑run responses and tool contracts.
-
-If you’d like, I can next draft the actual Zod schema snippets and handler code for these changes so you can drop them into the repo.

package/.code/agents/2e905864-aa07-4314-bcf9-c5b32277e4ac/result.txt

@@ -1,36 +0,0 @@
-**Tool Catalogue (src/server/YNABMCPServer.ts)**
-- list_budgets — budgets; delta adapter; input inline `emptyObjectSchema`; output `ListBudgetsOutputSchema` (`src/tools/schemas/outputs/budgetOutputs.ts` via index).
-- get_budget — budgets; read adapter; input `GetBudgetSchema` (`src/tools/budgetTools.ts`); output `GetBudgetOutputSchema` (`src/tools/schemas/outputs/utilityOutputs.ts` via index).
-- set_default_budget — budgets/local; custom inline write; input inline `setDefaultBudgetSchema`; output `SetDefaultBudgetOutputSchema` (`src/tools/schemas/outputs/utilityOutputs.ts` via index).
-- get_default_budget — budgets/local; inline no-input; input inline `emptyObjectSchema`; output `GetDefaultBudgetOutputSchema` (`src/tools/schemas/outputs/utilityOutputs.ts` via index).
-- list_accounts — accounts; delta adapter; input `ListAccountsSchema` (`src/tools/accountTools.ts`); output `ListAccountsOutputSchema` (`src/tools/schemas/outputs/accountOutputs.ts` via index).
-- get_account — accounts; read adapter; input `GetAccountSchema` (`src/tools/accountTools.ts`); output `GetAccountOutputSchema` (`src/tools/schemas/outputs/accountOutputs.ts` via index).
-- create_account — accounts; write adapter; input `CreateAccountSchema` (`src/tools/accountTools.ts`); output inline `LooseObjectSchema` (catch-all, typed `CreateAccountOutputSchema` exists in `src/tools/schemas/outputs/transactionMutationOutputs.ts`).
-- list_transactions — transactions; delta adapter; input `ListTransactionsSchema` (`src/tools/transactionTools.ts`); output inline `LooseObjectSchema` (typed `ListTransactionsOutputSchema` exists in `src/tools/schemas/outputs/transactionOutputs.ts`).
-- export_transactions — transactions/export; read adapter; input `ExportTransactionsSchema` (`src/tools/exportTransactions.ts`); output `ExportTransactionsOutputSchema` (`src/tools/schemas/outputs/comparisonOutputs.ts` via index).
-- compare_transactions — transactions/compare; read adapter; input `CompareTransactionsSchema` (`src/tools/compareTransactions/index.ts`); output `CompareTransactionsOutputSchema` (`src/tools/schemas/outputs/comparisonOutputs.ts` via index).
-- reconcile_account — reconciliation; delta adapter; input `ReconcileAccountSchema` (`src/tools/reconciliation/index.ts`); output inline `LooseObjectSchema` (typed `ReconcileAccountOutputSchema` exists in `src/tools/schemas/outputs/reconciliationOutputs.ts`).
-- get_transaction — transactions; read adapter; input `GetTransactionSchema` (`src/tools/transactionTools.ts`); output `GetTransactionOutputSchema` (`src/tools/schemas/outputs/transactionOutputs.ts` via index).
-- create_transaction — transactions; write adapter; input `CreateTransactionSchema` (`src/tools/transactionTools.ts`); output inline `LooseObjectSchema` (typed `CreateTransactionOutputSchema` exists in `src/tools/schemas/outputs/transactionMutationOutputs.ts`).
-- create_transactions — transactions; write adapter; input `CreateTransactionsSchema` (`src/tools/transactionTools.ts`); output inline `LooseObjectSchema` (typed `CreateTransactionsOutputSchema` exists in `src/tools/schemas/outputs/transactionMutationOutputs.ts`).
-- update_transactions — transactions; write adapter; input `UpdateTransactionsSchema` (`src/tools/transactionTools.ts`); output inline `LooseObjectSchema` (typed `UpdateTransactionsOutputSchema` exists in `src/tools/schemas/outputs/transactionMutationOutputs.ts`).
-- create_receipt_split_transaction — transactions; write adapter; input `CreateReceiptSplitTransactionSchema` (`src/tools/transactionTools.ts`); output inline `LooseObjectSchema` (typed `CreateReceiptSplitTransactionOutputSchema` exists in `src/tools/schemas/outputs/transactionMutationOutputs.ts`).
-- update_transaction — transactions; write adapter; input `UpdateTransactionSchema` (`src/tools/transactionTools.ts`); output inline `LooseObjectSchema` (typed `UpdateTransactionOutputSchema` exists in `src/tools/schemas/outputs/transactionMutationOutputs.ts`).
-- delete_transaction — transactions; write adapter; input `DeleteTransactionSchema` (`src/tools/transactionTools.ts`); output inline `LooseObjectSchema` (typed `DeleteTransactionOutputSchema` exists in `src/tools/schemas/outputs/transactionMutationOutputs.ts`).
-- list_categories — categories; delta adapter; input `ListCategoriesSchema` (`src/tools/categoryTools.ts`); output `ListCategoriesOutputSchema` (`src/tools/schemas/outputs/categoryOutputs.ts` via index).
-- get_category — categories; read adapter; input `GetCategorySchema` (`src/tools/categoryTools.ts`); output `GetCategoryOutputSchema` (`src/tools/schemas/outputs/categoryOutputs.ts` via index).
-- update_category — categories; write adapter; input `UpdateCategorySchema` (`src/tools/categoryTools.ts`); output inline `LooseObjectSchema` (typed `UpdateCategoryOutputSchema` exists in `src/tools/schemas/outputs/transactionMutationOutputs.ts`).
-- list_payees — payees; delta adapter; input `ListPayeesSchema` (`src/tools/payeeTools.ts`); output `ListPayeesOutputSchema` (`src/tools/schemas/outputs/payeeOutputs.ts` via index).
-- get_payee — payees; read adapter; input `GetPayeeSchema` (`src/tools/payeeTools.ts`); output `GetPayeeOutputSchema` (`src/tools/schemas/outputs/payeeOutputs.ts` via index).
-- get_month — months; read adapter; input `GetMonthSchema` (`src/tools/monthTools.ts`); output `GetMonthOutputSchema` (`src/tools/schemas/outputs/monthOutputs.ts` via index).
-- list_months — months; delta adapter; input `ListMonthsSchema` (`src/tools/monthTools.ts`); output `ListMonthsOutputSchema` (`src/tools/schemas/outputs/monthOutputs.ts` via index).
-- get_user — utility; no-input adapter; input inline `emptyObjectSchema`; output `GetUserOutputSchema` (`src/tools/schemas/outputs/utilityOutputs.ts` via index).
-- convert_amount — utility; inline local (no YNAB); input `ConvertAmountSchema` (`src/tools/utilityTools.ts`); output `ConvertAmountOutputSchema` (`src/tools/schemas/outputs/utilityOutputs.ts` via index).
-- diagnostic_info — utility/diagnostics; inline local; input inline `diagnosticInfoSchema`; output `DiagnosticInfoOutputSchema` (`src/tools/schemas/outputs/utilityOutputs.ts` via index).
-- clear_cache — utility/cache; inline local; input inline `emptyObjectSchema`; output `ClearCacheOutputSchema` (`src/tools/schemas/outputs/utilityOutputs.ts` via index).
-- set_output_format — utility/output; inline local; input inline `setOutputFormatSchema`; output `SetOutputFormatOutputSchema` (`src/tools/schemas/outputs/utilityOutputs.ts` via index).
-
-**Schema Notes**
-- Inline inputs in `src/server/YNABMCPServer.ts` that could move to a shared module: `emptyObjectSchema`, `LooseObjectSchema`, `setDefaultBudgetSchema`, `diagnosticInfoSchema`, `setOutputFormatSchema`. A small `src/tools/schemas/shared/baseInputs.ts` would centralize these.
-- Several tools use inline `LooseObjectSchema` despite typed outputs existing in `src/tools/schemas/outputs/transactionOutputs.ts` and `transactionMutationOutputs.ts`; swapping to the typed schemas would reduce lax validation for transactions, account creation, reconciliation, and category updates.
-- Server-owned/stateful tools that likely stay inline even after schema extraction: `set_default_budget` (default state + cache warm), `get_default_budget` (local state), `diagnostic_info` (uses `DiagnosticManager`), `clear_cache` (cacheManager), `set_output_format` (responseFormatter).