@diagrammo/dgmo 0.47.0 → 0.48.0

package/src/raci/diagnostics.ts

@@ -1,213 +0,0 @@
-// ============================================================
-// RACI / RASCI / DACI Diagnostic Catalog
-// ============================================================
-//
-// Declarative `DiagnosticSpec` entries for every coded diagnostic the
-// RACI parser can emit. This is the single source of truth for wording:
-// the parser (`src/raci/parser.ts`) and rule set (`src/raci/variants.ts`)
-// emit through `emit(RACI_DX.<KEY>, line, params)` so catalog consumers
-// (CLI `diagnostics`, console error-review, MCP `validate_diagram`, spec
-// docs) can enumerate RACI diagnostics without re-typing wording at each
-// call site.
-//
-// Codes are also mirrored in `variants.ts` (`RACI_ERROR_CODES`,
-// `RACI_WARNING_CODES`) for downstream consumers/tests that key off the
-// code tables. Every message builder tolerates being called with `{}` so
-// the catalog can render a representative message without live params.
-
-import type { DiagnosticSpec } from '../diagnostics';
-
-/** Keyed specs — referenced by the parser's / rules' `emit()` call sites. */
-export const RACI_DX = {
-  // ── Errors ──────────────────────────────────────────────────
-
-  MULTI_ACCOUNTABLE: {
-    code: 'E_RACI_MULTI_ACCOUNTABLE',
-    severity: 'error',
-    chartType: 'raci',
-    title: 'Multiple Accountable',
-    // variants.ts › multiAccountableRule
-    message: (p) =>
-      `Task '${(p.task as string) ?? 'Task'}' has more than one Accountable — RACI requires exactly one.`,
-    hint: 'Assign the A marker to exactly one role per task; make the others Responsible or Consulted.',
-    example: `raci\n\nTask\n  Cap: A\n  QM: A`,
-  },
-  DACI_MULTI_DRIVER: {
-    code: 'E_DACI_MULTI_DRIVER',
-    severity: 'error',
-    chartType: 'raci',
-    title: 'Multiple Driver (DACI)',
-    // variants.ts › daciMultiDriverRule
-    message: (p) =>
-      `Task '${(p.task as string) ?? 'Task'}' has more than one Driver — DACI requires exactly one.`,
-    hint: 'A DACI decision has a single Driver; give the extra D roles another marker.',
-    example: `raci\n\nDecision\n  PM: D\n  Cap: D`,
-  },
-  DACI_MULTI_ACCOUNTABLE: {
-    code: 'E_DACI_MULTI_ACCOUNTABLE',
-    severity: 'error',
-    chartType: 'raci',
-    title: 'Multiple Approver (DACI)',
-    // variants.ts › daciMultiAccountableRule
-    message: (p) =>
-      `Task '${(p.task as string) ?? 'Task'}' has more than one Approver — DACI requires exactly one.`,
-    hint: 'A DACI decision has a single Approver (A); reduce to one.',
-    example: `raci\n\nDecision\n  Lead: D\n  PM: A\n  Cap: A`,
-  },
-  INVALID_MARKER: {
-    code: 'E_RACI_INVALID_MARKER',
-    severity: 'error',
-    chartType: 'raci',
-    // Two emit sites share this code: parser.ts first-pass (default form,
-    // rejects letters outside the union alphabet) and parser.ts post-pass
-    // (variant-aware form, passed `variant`+`alphabet`, rejects union
-    // letters outside the resolved variant). The `{}` default renders the
-    // first-pass wording.
-    title: 'Invalid marker',
-    // parser.ts first-pass tokenizer
-    message: (p) =>
-      p.variant !== undefined && p.variant !== null
-        ? `Marker '${(p.marker as string) ?? 'X'}' is not in the ${p.variant} alphabet (${p.alphabet}).`
-        : `Marker '${(p.marker as string) ?? 'X'}' is not a recognized RACI marker (R A S C I D).`,
-    hint: 'Use only R, A, S, C, I (or D for DACI). Wrong-variant letters (e.g. S in a DACI chart) trigger the variant-alphabet form of this diagnostic.',
-    example: `raci\n\nTask\n  Cap: X`,
-  },
-  UNEXPECTED_LINE: {
-    code: 'E_RACI_UNEXPECTED_LINE',
-    severity: 'error',
-    chartType: 'raci',
-    title: 'Unexpected line under task',
-    // parser.ts — free-text after first role assignment
-    message: (p) =>
-      `Unexpected line after role assignments under task '${(p.task as string) ?? 'Task'}'. Lines under a task must be either a description (before the first 'Role: markers' line) or another role assignment.`,
-    hint: 'Put all description text before the first role assignment; nothing but assignments may follow.',
-    example: `raci\n\nTask\n  Cap: A\n  This is an unexpected description.`,
-  },
-  MIXED_VARIANTS: {
-    code: 'E_RACI_MIXED_VARIANTS',
-    severity: 'error',
-    chartType: 'raci',
-    title: 'Mixed RASCI/DACI markers',
-    // parser.ts — variant resolution, inferVariant() returned null
-    message:
-      "Chart uses both 'D' and 'S' markers but neither RASCI nor DACI covers both. Use only RACI/RASCI markers (R, A, S, C, I) or only DACI markers (D, A, C, I).",
-    hint: 'Pick one convention: R/A/S/C/I (RACI/RASCI) or D/A/C/I (DACI). Do not mix D and S in one chart.',
-    example: `raci\n\nTask\n  Cap: D\n  Crew: S`,
-  },
-
-  // ── Warnings ────────────────────────────────────────────────
-
-  MISSING_ACCOUNTABLE: {
-    code: 'W_RACI_MISSING_ACCOUNTABLE',
-    severity: 'warning',
-    chartType: 'raci',
-    title: 'Missing Accountable',
-    // variants.ts › missingAccountableRule
-    message: (p) =>
-      `Task '${(p.task as string) ?? 'Task'}' has no Accountable assigned.`,
-    hint: 'Every RACI task should have exactly one Accountable (A).',
-    example: `raci\n\nTask\n  Cap: R`,
-  },
-  MISSING_RESPONSIBLE: {
-    code: 'W_RACI_MISSING_RESPONSIBLE',
-    severity: 'warning',
-    chartType: 'raci',
-    title: 'Missing Responsible',
-    // variants.ts › missingResponsibleRule
-    message: (p) =>
-      `Task '${(p.task as string) ?? 'Task'}' has no Responsible assigned.`,
-    hint: 'Assign at least one Responsible (R) — someone has to do the work.',
-    example: `raci\n\nTask\n  Cap: A`,
-  },
-  DACI_MISSING_DRIVER: {
-    code: 'W_DACI_MISSING_DRIVER',
-    severity: 'warning',
-    chartType: 'raci',
-    title: 'Missing Driver (DACI)',
-    // variants.ts › daciMissingDriverRule
-    message: (p) =>
-      `Task '${(p.task as string) ?? 'Task'}' has no Driver assigned.`,
-    hint: 'A DACI decision needs a Driver (D) to move it forward.',
-    example: `raci\n\nPick Vendor\n  Lead: D\n  PM: A\nSign Off\n  Cap: C`,
-  },
-  DACI_MISSING_ACCOUNTABLE: {
-    code: 'W_DACI_MISSING_ACCOUNTABLE',
-    severity: 'warning',
-    chartType: 'raci',
-    title: 'Missing Approver (DACI)',
-    // variants.ts › daciMissingAccountableRule
-    message: (p) =>
-      `Task '${(p.task as string) ?? 'Task'}' has no Approver assigned.`,
-    hint: 'A DACI decision needs an Approver (A) to sign off.',
-    example: `raci\n\nPick Vendor\n  Lead: D\n  PM: A\nSign Off\n  Cap: C`,
-  },
-  UNKNOWN_ROLE: {
-    code: 'W_RACI_UNKNOWN_ROLE',
-    severity: 'warning',
-    chartType: 'raci',
-    title: 'Undeclared role',
-    // parser.ts — only when `roles:` is declared. Live message appends a
-    // ` Did you mean 'X'?` suggestion when a near match exists.
-    message: (p) => {
-      const role = (p.role as string) ?? 'Role';
-      const hint = (p.hint as string) ?? '';
-      return `Role '${role}' is not declared in the 'roles:' directive.${hint ? ' ' + hint : ''}`;
-    },
-    hint: 'Add the role to the `roles` directive, or fix the typo to match a declared role.',
-    example: `raci\nroles Cap, QM\n\nTask\n  Cap: A\n  Stranger: R`,
-  },
-  EMPTY_TASK: {
-    code: 'W_RACI_EMPTY_TASK',
-    severity: 'warning',
-    chartType: 'raci',
-    title: 'Empty task',
-    // variants.ts › emptyTaskRule
-    message: (p) =>
-      `Task '${(p.task as string) ?? 'Task'}' has no role assignments.`,
-    hint: 'Add at least one `Role: markers` line, or remove the empty task.',
-    example: `raci\n\nTask\n  Just a description with no assignments`,
-  },
-  CONFLICTING_MARKERS: {
-    code: 'W_RACI_CONFLICTING_MARKERS',
-    severity: 'warning',
-    chartType: 'raci',
-    title: 'Conflicting markers',
-    // variants.ts › conflictingMarkersRule
-    message: (p) => {
-      const role = (p.role as string) ?? 'Role';
-      const task = (p.task as string) ?? 'Task';
-      const markers = (p.markers as string) ?? 'A C';
-      return `Role '${role}' on task '${task}' has conflicting markers (${markers}). A role can be either active (R/A/D) or passive (C/I), not both.`;
-    },
-    hint: 'Give the role either an active marker (R/A/D) or a passive one (C/I), not both.',
-    example: `raci\n\nTask\n  Cap: A C`,
-  },
-  TOO_MANY_RESPONSIBLE: {
-    code: 'W_RACI_TOO_MANY_RESPONSIBLE',
-    severity: 'warning',
-    chartType: 'raci',
-    title: 'Too many Responsible',
-    // variants.ts › tooManyResponsibleRule (threshold = 3)
-    message: (p) => {
-      const task = (p.task as string) ?? 'Task';
-      const count = (p.count as number) ?? 4;
-      const threshold = (p.threshold as number) ?? 3;
-      return `Task '${task}' has ${count} Responsibles — more than ${threshold} dilutes ownership. Consider splitting the task or marking some as Consulted.`;
-    },
-    hint: 'Keep Responsibles at or below 3 — split the task or downgrade some roles to Consulted.',
-    example: `raci\n\nTask\n  W: R\n  X: R\n  Y: R\n  Z: R\n  Lead: A`,
-  },
-  ORPHAN_ROLE: {
-    code: 'W_RACI_ORPHAN_ROLE',
-    severity: 'warning',
-    chartType: 'raci',
-    title: 'Orphan role',
-    // parser.ts — role declared/seen but never assigned any marker
-    message: (p) =>
-      `Role '${(p.role as string) ?? 'Role'}' is declared but never assigned to any task.`,
-    hint: 'Assign the role a marker somewhere, or remove it from the `roles` directive.',
-    example: `raci\nroles Cap, Ghost\n\nTask\n  Cap: A R`,
-  },
-} satisfies Record<string, DiagnosticSpec>;
-
-export const RACI_DIAGNOSTICS: DiagnosticSpec[] = Object.values(RACI_DX);

package/src/raci/index.ts

@@ -1,23 +0,0 @@
-// ============================================================
-// RACI / RASCI / DACI — public exports
-// ============================================================
-
-export { parseRaci, allTasks } from './parser';
-export { renderRaci, renderRaciForExport } from './renderer';
-export type { RaciDragSource, RaciInteractionHandlers } from './renderer';
-export {
-  cellReplace,
-  cellAppendMarker,
-  cellRemove,
-  cellCycle,
-} from './mutations';
-export { VARIANTS, RACI_ERROR_CODES, RACI_WARNING_CODES } from './variants';
-export type { ConstraintRule, VariantRuleSet } from './variants';
-export type {
-  ParsedRaci,
-  RaciMarker,
-  RaciVariant,
-  RaciTask,
-  RaciPhase,
-  RaciRoleAssignment,
-} from './types';

package/src/raci/mutations.ts

@@ -1,321 +0,0 @@
-// ============================================================
-// RACI mutation engine
-// ============================================================
-//
-// Greenfield, peer to `kanban/mutations.ts` (NOT extracted shared
-// utility — see Technical Decision #15 in the tech spec). All
-// mutations are pure functions that return a new DGMO source string,
-// or `null` for no-ops.
-//
-// Mutation flow (do not deviate):
-//
-//   click / drop in RACIPreview
-//     ─→ pure mutation here returns new content
-//     ─→ Zustand stores updated (`useFileStore.setFileContent`,
-//        `useEditorStore.setContent`)
-//     ─→ `useCodeMirror` watcher dispatches a CM transaction
-//
-// Preview NEVER calls `view.dispatch()` directly. Same contract as
-// kanban — see `KanbanPreview.tsx:476-477` + `useCodeMirror.ts:269-283`.
-//
-// Indent preservation comes from operating on whole lines + matching
-// the indent of the task's existing role-assignment block. The parser
-// owns identity (taskId / roleId are normalized keys); mutations look
-// up by id pair.
-
-import { measureIndent } from '../utils/parsing';
-import type {
-  ParsedRaci,
-  RaciMarker,
-  RaciRoleAssignment,
-  RaciTask,
-} from './types';
-import { allTasks } from './parser';
-
-// ── Public surface ───────────────────────────────────────────
-
-/**
- * Set the markers on a cell to exactly `[marker]`, replacing whatever
- * was there. If `marker` is `null`, the cell is cleared (the role
- * assignment line is removed if it was the only marker; otherwise the
- * line stays with its other markers untouched — see `cellRemove` for
- * specific-marker removal semantics).
- *
- * Insertion point when the role assignment doesn't exist:
- *   - After the last existing role assignment under the task, OR
- *   - After the task's description block, OR
- *   - Immediately after the task line.
- *
- * Returns `null` for no-ops (the cell already contains `[marker]`).
- */
-export function cellReplace(
-  content: string,
-  parsed: ParsedRaci,
-  taskId: string,
-  roleId: string,
-  marker: RaciMarker | null
-): string | null {
-  const task = findTask(parsed, taskId);
-  if (!task) return null;
-
-  const lines = content.split('\n');
-  const existing = task.roleAssignments.find((a) => a.id === roleId);
-
-  if (existing) {
-    // No-op short-circuit: cell already holds exactly one marker.
-    if (
-      marker !== null &&
-      existing.markers.length === 1 &&
-      existing.markers[0] === marker
-    ) {
-      return null;
-    }
-    // No-op short-circuit: clearing an already-empty cell.
-    if (marker === null && existing.markers.length === 0) {
-      return null;
-    }
-
-    if (marker === null) {
-      // Drop the line entirely.
-      lines.splice(existing.lineNumber - 1, 1);
-      return lines.join('\n');
-    }
-
-    // In-bounds: existing.lineNumber refers to a valid line in lines.
-    lines[existing.lineNumber - 1] = rewriteAssignmentLine(
-      lines[existing.lineNumber - 1]!,
-      existing.displayName,
-      [marker]
-    );
-    return lines.join('\n');
-  }
-
-  // No existing role assignment for this role; insert one (unless null).
-  if (marker === null) return null;
-
-  const roleDisplay = lookupRoleDisplay(parsed, roleId);
-  if (!roleDisplay) return null;
-
-  const indent = inferAssignmentIndent(task, lines);
-  const insertAt = insertionLineFor(task, roleId, parsed);
-  const newLine = `${' '.repeat(indent)}${roleDisplay}: ${marker}`;
-  lines.splice(insertAt, 0, newLine);
-  return lines.join('\n');
-}
-
-/**
- * Append `marker` to the cell, producing a combined-marker string
- * like `A R`. Idempotent — if `marker` is already present, returns
- * `null`. If the cell is empty (no existing role assignment line),
- * behaves like `cellReplace(content, ..., marker)`.
- */
-export function cellAppendMarker(
-  content: string,
-  parsed: ParsedRaci,
-  taskId: string,
-  roleId: string,
-  marker: RaciMarker
-): string | null {
-  const task = findTask(parsed, taskId);
-  if (!task) return null;
-
-  const existing = task.roleAssignments.find((a) => a.id === roleId);
-  if (!existing) {
-    return cellReplace(content, parsed, taskId, roleId, marker);
-  }
-  if (existing.markers.includes(marker)) return null;
-
-  const lines = content.split('\n');
-  // In-bounds: existing.lineNumber refers to a valid line in lines.
-  lines[existing.lineNumber - 1] = rewriteAssignmentLine(
-    lines[existing.lineNumber - 1]!,
-    existing.displayName,
-    [...existing.markers, marker]
-  );
-  return lines.join('\n');
-}
-
-/**
- * Remove a single `marker` from the cell, OR all markers when
- * `marker` is `undefined`. If the cell becomes empty as a result,
- * the entire role-assignment line is dropped.
- *
- * Returns `null` for no-ops (e.g. removing a marker that wasn't
- * there).
- */
-export function cellRemove(
-  content: string,
-  parsed: ParsedRaci,
-  taskId: string,
-  roleId: string,
-  marker?: RaciMarker
-): string | null {
-  const task = findTask(parsed, taskId);
-  if (!task) return null;
-
-  const existing = task.roleAssignments.find((a) => a.id === roleId);
-  if (!existing) return null;
-
-  const lines = content.split('\n');
-
-  let nextMarkers: RaciMarker[];
-  if (marker === undefined) {
-    nextMarkers = [];
-  } else {
-    if (!existing.markers.includes(marker)) return null;
-    nextMarkers = existing.markers.filter((m) => m !== marker);
-  }
-
-  if (nextMarkers.length === 0) {
-    lines.splice(existing.lineNumber - 1, 1);
-    return lines.join('\n');
-  }
-
-  // In-bounds: existing.lineNumber refers to a valid line in lines.
-  lines[existing.lineNumber - 1] = rewriteAssignmentLine(
-    lines[existing.lineNumber - 1]!,
-    existing.displayName,
-    nextMarkers
-  );
-  return lines.join('\n');
-}
-
-/**
- * Cycle the cell's marker through the variant alphabet. Used by the
- * click-to-cycle interaction in `RACIPreview`. Cycle order:
- *
- *   blank → alphabet[0] → alphabet[1] → … → alphabet[n-1] → blank → …
- *
- * If the cell currently has multiple markers (e.g. `A R`), cycling
- * collapses to a single marker chosen as the *next* one after the
- * first existing marker — interpretation: "cycle from the dominant
- * marker." This keeps the affordance simple; combined-markers stay
- * the territory of drag-from-palette (per TD #10).
- */
-export function cellCycle(
-  content: string,
-  parsed: ParsedRaci,
-  taskId: string,
-  roleId: string,
-  alphabet: ReadonlyArray<RaciMarker>
-): string | null {
-  if (alphabet.length === 0) return null;
-  const task = findTask(parsed, taskId);
-  if (!task) return null;
-
-  const existing = task.roleAssignments.find((a) => a.id === roleId);
-  const current = existing?.markers ?? [];
-
-  let next: RaciMarker | null;
-  if (current.length === 0) {
-    // In-bounds: alphabet.length > 0 guard at top of function.
-    next = alphabet[0]!;
-  } else {
-    // In-bounds: current.length > 0 from condition above.
-    const dominant = current[0]!;
-    const idx = alphabet.indexOf(dominant);
-    if (idx < 0) {
-      // First marker is not in alphabet (shouldn't normally happen —
-      // parser would have flagged it). Restart the cycle.
-      // In-bounds: alphabet.length > 0 guard at top of function.
-      next = alphabet[0]!;
-    } else if (idx === alphabet.length - 1) {
-      // Wrap → blank
-      next = null;
-    } else {
-      // In-bounds: idx < alphabet.length - 1, so idx + 1 < alphabet.length.
-      next = alphabet[idx + 1]!;
-    }
-  }
-
-  return cellReplace(content, parsed, taskId, roleId, next);
-}
-
-// ── Internals ────────────────────────────────────────────────
-
-function findTask(parsed: ParsedRaci, taskId: string): RaciTask | null {
-  for (const t of allTasks(parsed)) {
-    if (t.id === taskId) return t;
-  }
-  return null;
-}
-
-function lookupRoleDisplay(parsed: ParsedRaci, roleId: string): string | null {
-  const idx = parsed.roles.indexOf(roleId);
-  if (idx < 0) return null;
-  return parsed.roleDisplayNames[idx] ?? null;
-}
-
-/**
- * Build a fresh role-assignment line at `existing`'s indent and role
- * display, with the given markers. Preserves trailing whitespace /
- * comments after the markers? — no: we treat the value segment after
- * the colon as wholly owned by the markers. RACI does not currently
- * support trailing pipe metadata on role-assignment lines (per
- * Out-of-Scope), so this is safe.
- */
-function rewriteAssignmentLine(
-  originalLine: string,
-  displayName: string,
-  markers: ReadonlyArray<RaciMarker>
-): string {
-  const indent = measureIndent(originalLine);
-  return `${' '.repeat(indent)}${displayName}: ${markers.join(' ')}`;
-}
-
-/**
- * Indent for a NEW role-assignment line under `task`. Use the indent
- * of the first existing role assignment if any; otherwise infer from
- * a sibling task's role assignment; otherwise default to the task's
- * own indent + 2.
- */
-function inferAssignmentIndent(task: RaciTask, lines: string[]): number {
-  if (task.roleAssignments.length > 0) {
-    // In-bounds: roleAssignments[0] exists from length>0; lineNumber references a valid line.
-    return measureIndent(lines[task.roleAssignments[0]!.lineNumber - 1]!);
-  }
-  // In-bounds: task.lineNumber references a valid line in the source.
-  const taskIndent = measureIndent(lines[task.lineNumber - 1]!);
-  return taskIndent + 2;
-}
-
-/**
- * 1-based line *index for splice*: the index BEFORE which the new
- * line is inserted. Returns the position immediately after the
- * task's last contentful line (description or role assignment) — or
- * directly after the task line when neither exists.
- */
-function insertionLineFor(
-  task: RaciTask,
-  roleId: string,
-  parsed: ParsedRaci
-): number {
-  // No existing role assignments — insert directly after the task block
-  // (after the task line and any description lines).
-  if (task.roleAssignments.length === 0) {
-    return task.endLineNumber;
-  }
-
-  // Match role-declaration order: insert before the first existing
-  // role assignment whose role-index is greater than this role's. If
-  // none has a higher index (i.e. this role belongs at the bottom of
-  // the declared order), append after the last existing assignment.
-  const targetIdx = parsed.roles.indexOf(roleId);
-  const lastAssignmentLine = Math.max(
-    ...task.roleAssignments.map((a: RaciRoleAssignment) => a.endLineNumber)
-  );
-  if (targetIdx < 0) {
-    // Role not registered (shouldn't normally happen since callers
-    // look up by parsed.roles index) — fall back to end-of-block.
-    return lastAssignmentLine;
-  }
-  for (const a of task.roleAssignments) {
-    const aIdx = parsed.roles.indexOf(a.id);
-    if (aIdx > targetIdx) {
-      // splice index = (1-based line) - 1 places the new line BEFORE
-      // the existing line at `a.lineNumber`.
-      return a.lineNumber - 1;
-    }
-  }
-  return lastAssignmentLine;
-}