@dev-loops/core 1.0.1 → 1.0.2-pre.0

package/src/loop/pr-gate-coordination.mjs

@@ -4,8 +4,8 @@ import { evaluateUiE2eScoping } from "./ui-e2e-scoping.mjs";
 import { evaluateUiDesignerReviewScoping } from "./ui-designer-review-scoping.mjs";
 import { trimmedOrNull } from "./normalize.mjs";
 import {
-  MISSING_AC_CHECKLIST_FINDING,
-  MISSING_DOD_CHECKLIST_FINDING,
+  MALFORMED_AC_DOD_MATRIX_FINDING,
+  MISSING_AC_DOD_MATRIX_FINDING,
   MISSING_EXPLICIT_NON_GOALS_FINDING,
 } from "./issue-refinement-artifact.mjs";
 
@@ -246,16 +246,16 @@ function normalizeRefinementArtifactStatus(value) {
 // their own validation-failure reason from the detector; that reason must
 // replace the "linked issue" wording, which does not apply when the PR is the
 // spec-of-record and no linked issue was ever expected.
-// #1877 full-matrix vocabulary for the draft-gate blocked reason: which
-// matrix arm is missing per finding — the SAME finding taxonomy the enqueue
-// gate's guidance (decideEnqueueRefinementGate) and the detector
+// #1951 matrix-floor vocabulary for the draft-gate blocked reason: which piece
+// of the refinement floor is missing per finding — the SAME finding taxonomy
+// the enqueue gate's guidance (decideEnqueueRefinementGate) and the detector
 // (detectIssueRefinementArtifact) use, so the draft gate (the unconditional
-// backstop for that floor) cannot drift from it. An AC-only or DoD-only
-// linked issue is a matrix miss, not "no artifact" — the guidance must name
-// the actually-missing arm so the fix is not misdirected.
+// backstop for that floor) cannot drift from it. A checklist-only or
+// matrix-malformed linked issue names the actually-missing/invalid artifact so
+// the fix is not misdirected.
 const REFINEMENT_MISSING_ARM_BY_FINDING = Object.freeze({
-  [MISSING_DOD_CHECKLIST_FINDING]: "a Definition of done checklist (mapped to the acceptance criteria)",
-  [MISSING_AC_CHECKLIST_FINDING]: "an Acceptance criteria checklist (for the DoD items to map to)",
+  [MISSING_AC_DOD_MATRIX_FINDING]: "an AC→DoD mapping matrix (a two-column table mapping each acceptance-criterion outcome to its required completion evidence)",
+  [MALFORMED_AC_DOD_MATRIX_FINDING]: "a valid AC→DoD mapping matrix (the existing table is empty or identifier-only/tautological)",
   [MISSING_EXPLICIT_NON_GOALS_FINDING]: "an explicit Non-goals section",
 });
 
@@ -269,12 +269,12 @@ function formatRefinementBlockedReason(linkedIssue, status, refinementArtifact)
     : REFINEMENT_ARTIFACT_FINDING;
   const missingArm = REFINEMENT_MISSING_ARM_BY_FINDING[finding];
   if (missingArm !== undefined) {
-    return `Linked issue #${linkedIssue} has an incomplete refinement matrix — it is missing ${missingArm}. Add it to the issue body to complete the full AC/DoD/Non-goals matrix, then re-open the draft PR. finding=${finding}`;
+    return `Linked issue #${linkedIssue} has an incomplete refinement matrix — it is missing ${missingArm}. Add it to the issue body to complete the AC→DoD mapping matrix + Non-goals refinement floor, then re-open the draft PR. finding=${finding}`;
   }
   if (linkedIssue !== null && Number.isInteger(linkedIssue)) {
-    return `Linked issue #${linkedIssue} has no refinement artifact (no Acceptance criteria checklist, DoD checklist, or resolvable linked refinement doc). Refine the issue to the full AC/DoD/Non-goals matrix — or link a refinement doc (tmp/refinement/*.md), a complete artifact on its own — then re-open the draft PR. finding=${REFINEMENT_ARTIFACT_FINDING}`;
+    return `Linked issue #${linkedIssue} has no refinement artifact (no AC→DoD mapping matrix, or a resolvable linked refinement doc). Refine the issue to the authoritative AC→DoD mapping matrix plus an explicit Non-goals section — or link a refinement doc (tmp/refinement/*.md), a complete artifact on its own — then re-open the draft PR. finding=${REFINEMENT_ARTIFACT_FINDING}`;
   }
-  return `The draft gate cannot complete: the linked issue has no detectable refinement artifact (no Acceptance criteria checklist, DoD checklist, or resolvable linked refinement doc). finding=${REFINEMENT_ARTIFACT_FINDING}`;
+  return `The draft gate cannot complete: the linked issue has no detectable refinement artifact (no AC→DoD mapping matrix, or a resolvable linked refinement doc). finding=${REFINEMENT_ARTIFACT_FINDING}`;
 }
 
 // #1472: describes the CI state a round-cap-reached fallback branch actually

package/src/loop/queue-board-sync.mjs

@@ -2,7 +2,7 @@ import { readFileSync } from "node:fs";
 import path from "node:path";
 import { parse as parseYaml } from "yaml";
 import { main as moveQueueItemMain } from "../projects/move-queue-item.mjs";
-import { ghGraphql } from "../github/gh.mjs";
+import { ghGraphql, resolveOwner } from "../github/gh.mjs";
 
 const DEFAULT_NON_SUCCESS_COLUMN = "Backlog";
 
@@ -277,18 +277,6 @@ export function loadStateColumnMap(repoRoot) {
 
 // ── Minimal project lookup (read-only, no create/repair) ────────────────
 
-const GET_USER_ID = [
-  "query($login:String!) {",
-  "  user(login:$login) { id }",
-  "}"
-].join("\n");
-
-const GET_ORG_ID = [
-  "query($login:String!) {",
-  "  organization(login:$login) { id }",
-  "}"
-].join("\n");
-
 const LIST_USER_PROJECTS = [
   "query($login:String!, $after:String) {",
   "  user(login:$login) {",
@@ -311,21 +299,6 @@ const LIST_ORG_PROJECTS = [
   "}"
 ].join("\n");
 
-async function resolveOwner(login, env, runChild) {
-  const userPayload = await ghGraphql(GET_USER_ID, { login }, env, runChild);
-  if (userPayload?.data?.user?.id) {
-    return { id: userPayload.data.user.id, kind: "user" };
-  }
-  const orgPayload = await ghGraphql(GET_ORG_ID, { login }, env, runChild);
-  if (orgPayload?.data?.organization?.id) {
-    return { id: orgPayload.data.organization.id, kind: "org" };
-  }
-  throw Object.assign(
-    new Error(`Could not resolve owner ID for "${login}"`),
-    { code: "NO_USER_ID" },
-  );
-}
-
 async function listAllProjects(login, kind, env, runChild) {
   const query = kind === "org" ? LIST_ORG_PROJECTS : LIST_USER_PROJECTS;
   const projects = [];

package/src/loop/review-dispatch-plan.mjs

@@ -869,6 +869,7 @@ export function verifyPromptLeadingAlignment({ promptLeading, prefixBytes, prefi
  */
 export const DEFAULT_DIFF_EXCLUDE_GLOBS = Object.freeze([
   // Lockfiles.
+  "bun.lock", "**/bun.lock",
   "package-lock.json", "**/package-lock.json",
   "npm-shrinkwrap.json", "**/npm-shrinkwrap.json",
   "yarn.lock", "**/yarn.lock",