@dev-loops/core 1.0.1 → 1.0.2-pre.0

package/src/loop/gate-fanin.mjs

@@ -287,8 +287,8 @@ export function severityRank(severity) {
 /**
  * A zero-initialized severity→count map, one key per SEVERITY_ORDER entry, in
  * SEVERITY_ORDER's order. The shared starting point every severity tally in
- * this codebase (consolidateFanin's own `bySeverity`, consolidate-fanin.mjs's
- * `buildAngleMarker`, reconcile-draft-gate.mjs's no-findings placeholder) used
+ * this codebase (consolidateFanin's own `bySeverity`,
+ * reconcile-draft-gate.mjs's no-findings placeholder) used
  * to hand-roll separately via `Object.fromEntries(SEVERITY_ORDER.map((s) =>
  * [s, 0]))` — one copy here means a severity added to SEVERITY_ORDER is
  * zero-initialized everywhere at once.
@@ -305,10 +305,9 @@ export function zeroSeverityCounts() {
  * finding whose normalized severity is not a recognized SEVERITY_ORDER member
  * is silently excluded from the tally rather than inflating an unknown key —
  * every routed call site here counts already-validated findings in practice
- * (consolidateFanin validates every result's severity before this runs;
- * buildAngleMarker tallies consolidateFanin's own output), so this guard is a
- * defensive floor against future drift, not an escape hatch for accepting
- * unvalidated severities. `findings` and its entries are NOT nullish-tolerant:
+ * (consolidateFanin validates every result's severity before this runs), so
+ * this guard is a defensive floor against future drift, not an escape hatch
+ * for accepting unvalidated severities. `findings` and its entries are NOT nullish-tolerant:
  * a nullish `findings` argument throws (not iterable), and a nullish
  * individual entry throws reading `.severity` — no routed caller passes
  * either shape, so a caller that does gets a loud failure instead of a
@@ -342,6 +341,30 @@ export function normalizeSeverityCounts(counts) {
   return normalized;
 }
 
+/**
+ * Resolve a finding's effective file path from EITHER shape the shared floor
+ * accepts: `file` (singular string, hand-authored / future-producer ledgers) or
+ * `files[0]` (the array shape consolidate-fanin / write-gate-findings-log emit).
+ * The ONE resolver `hasLocatableShape` and every downstream consumer keys on,
+ * so a consumer reading `finding.files[0]` directly can never crash on a
+ * singular-`file` finding that already passed the floor. The value is TRIMMED
+ * and a whitespace-only `file` is treated as ABSENT (it falls back to
+ * `files[0]`, not shadows it), so the resolved path both matches the trimmed
+ * commentable-line-set keys and is a valid GitHub review-comment `path` even
+ * for an untrimmed hand-authored ledger entry (`readGateFindingsLedger` trims
+ * `files[]` but not a singular `file`). Returns `undefined` when neither shape
+ * names a non-blank string path.
+ * @param {{ file?: unknown, files?: unknown }} finding
+ * @returns {string|undefined}
+ */
+export function resolveFindingFile(finding) {
+  if (typeof finding?.file === "string" && finding.file.trim().length > 0) return finding.file.trim();
+  if (Array.isArray(finding?.files) && typeof finding.files[0] === "string" && finding.files[0].trim().length > 0) {
+    return finding.files[0].trim();
+  }
+  return undefined;
+}
+
 /**
  * A finding is LOCATABLE-SHAPED when it names a real file (via `file` or
  * `files[0]`) and a positive-integer `line` — the ONE shared shape check
@@ -358,9 +381,7 @@ export function normalizeSeverityCounts(counts) {
  * @returns {boolean}
  */
 export function hasLocatableShape(finding) {
-  const file = typeof finding?.file === "string"
-    ? finding.file
-    : (Array.isArray(finding?.files) ? finding.files[0] : undefined);
+  const file = resolveFindingFile(finding);
   return typeof file === "string" && file.trim().length > 0
     && Number.isInteger(finding?.line) && /** @type {number} */ (finding.line) >= 1;
 }
@@ -696,7 +717,7 @@ export function fanoutReviewerPairingError(perAngle, resolvedGroups = null) {
 
 /**
  * Base angle name for a delta-suffixed re-review entry (`<angle>-delta-at-...`,
- * e.g. `pr-checklist-matrix-delta-at-current-head`): a re-review scoped to only
+ * e.g. `pr-checklist-delta-at-current-head`): a re-review scoped to only
  * the current head's delta still counts toward its base angle for both
  * mandatory-angle coverage and pool-membership checks.
  *
@@ -742,12 +763,12 @@ export function checkFanoutAngleCoverage(recordedAngles, { mandatoryAngles = [],
 
 /**
  * Angles the fan-in itself mandates and may synthesize (consolidate-fanin's
- * `--pr-checklist-matrix clean` upsert) without them appearing in any gate's
+ * `--pr-checklist clean` upsert) without them appearing in any gate's
  * configured `angles` pool. Always legal in the foreign-angle check above —
  * requiring every consumer repo to also list them per-gate would make the two
  * tools contradict the shared contract they implement.
  */
-export const FANIN_SYNTHETIC_ANGLES = Object.freeze(["pr-checklist-matrix"]);
+export const FANIN_SYNTHETIC_ANGLES = Object.freeze(["pr-checklist"]);
 
 /**
  * Validate a round's RESOLVED angle set — the full angle list the round
@@ -813,7 +834,7 @@ export function checkResolvedAngleEvidence(resolvedAngles, { recordedAngles, car
 export const DEFAULT_MAX_FANOUT_REVIEWERS = 8;
 
 // Every sanctioned angle name is a short, hand-authored slug (e.g.
-// "contradiction-lens", "pr-checklist-matrix"); nothing legitimate ever
+// "contradiction-lens", "pr-checklist"); nothing legitimate ever
 // approaches this length. Bounding it here, at the trust boundary this
 // function already owns, fails a pathological artifact closed as malformed —
 // the same place every other angle-result defect is caught — instead of

package/src/loop/handoff-envelope.mjs

@@ -123,7 +123,7 @@ register(INTERNAL_DEV_LOOP_STRATEGY.FINAL_APPROVAL, "default", {
 register(INTERNAL_DEV_LOOP_STRATEGY.LOCAL_IMPLEMENTATION, "default", {
   criteria: [
     { id: "phase-ac", must: "All phase acceptance criteria from the active phase doc are satisfied.", severity: "required" },
-    { id: "verify-green", must: "`npm run verify` passes with no failures.", severity: "required" },
+    { id: "verify-green", must: "`bun run verify` passes with no failures.", severity: "required" },
   ],
   evidence: ["commands-run", "validation-output", "changed-files"],
   maxFinalizationTurns: 6,
@@ -138,7 +138,7 @@ register(INTERNAL_DEV_LOOP_STRATEGY.LOCAL_IMPLEMENTATION, "default", {
 register(INTERNAL_DEV_LOOP_STRATEGY.LOCAL_IMPLEMENTATION, "spike", {
   criteria: [
     { id: "spike-recorded", must: "The spike exploration and its recommendation are recorded (spike file + summary).", severity: "required" },
-    { id: "verify-green", must: "`npm run verify` passes with no failures.", severity: "required" },
+    { id: "verify-green", must: "`bun run verify` passes with no failures.", severity: "required" },
   ],
   evidence: ["commands-run", "validation-output", "changed-files"],
   maxFinalizationTurns: 6,