@ddtcorex/dsh-maestro-review 0.12.0 → 0.14.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/README.md +31 -58
- package/cordis.patch.yml +23 -18
- package/lib/config-store.d.ts +9 -1
- package/lib/config-store.d.ts.map +1 -1
- package/lib/config-store.js +1 -1
- package/lib/config-store.js.map +1 -1
- package/lib/events.d.ts +5 -45
- package/lib/events.d.ts.map +1 -1
- package/lib/host-orchestrator.d.ts +128 -0
- package/lib/host-orchestrator.d.ts.map +1 -0
- package/lib/host-orchestrator.js +408 -0
- package/lib/host-orchestrator.js.map +1 -0
- package/lib/index.d.ts +7 -2
- package/lib/index.d.ts.map +1 -1
- package/lib/index.js +7 -43
- package/lib/index.js.map +1 -1
- package/lib/review-intake.d.ts +1 -1
- package/lib/review-intake.d.ts.map +1 -1
- package/lib/settings-rpc.js +1 -1
- package/lib/settings-rpc.js.map +1 -1
- package/package.json +19 -36
- package/src/client/index.tsx +1 -1
- package/src/host/augment.d.ts +3 -1
- package/src/host/config-store.ts +2 -2
- package/src/host/events.ts +5 -45
- package/src/host/host-orchestrator.ts +461 -0
- package/src/host/index.ts +7 -35
- package/src/host/providers/gitlab.ts +1 -1
- package/src/host/review-intake.ts +1 -1
- package/src/host/settings-rpc.ts +1 -1
- package/lib/ci-clone.d.ts +0 -21
- package/lib/ci-clone.d.ts.map +0 -1
- package/lib/ci-clone.js +0 -35
- package/lib/ci-clone.js.map +0 -1
- package/lib/ci-coexist.d.ts +0 -11
- package/lib/ci-coexist.d.ts.map +0 -1
- package/lib/ci-coexist.js +0 -38
- package/lib/ci-coexist.js.map +0 -1
- package/lib/gitlab-auth.d.ts +0 -11
- package/lib/gitlab-auth.d.ts.map +0 -1
- package/lib/gitlab-auth.js +0 -15
- package/lib/gitlab-auth.js.map +0 -1
- package/lib/gitlab-client.d.ts +0 -78
- package/lib/gitlab-client.d.ts.map +0 -1
- package/lib/gitlab-client.js +0 -270
- package/lib/gitlab-client.js.map +0 -1
- package/lib/govard-lint-detection.d.ts +0 -20
- package/lib/govard-lint-detection.d.ts.map +0 -1
- package/lib/govard-lint-detection.js +0 -48
- package/lib/govard-lint-detection.js.map +0 -1
- package/lib/hyva-csp-scan-tool.d.ts +0 -11
- package/lib/hyva-csp-scan-tool.d.ts.map +0 -1
- package/lib/hyva-csp-scan-tool.js +0 -193
- package/lib/hyva-csp-scan-tool.js.map +0 -1
- package/lib/hyva-theme-inspect-tool.d.ts +0 -10
- package/lib/hyva-theme-inspect-tool.d.ts.map +0 -1
- package/lib/hyva-theme-inspect-tool.js +0 -299
- package/lib/hyva-theme-inspect-tool.js.map +0 -1
- package/lib/incremental.d.ts +0 -28
- package/lib/incremental.d.ts.map +0 -1
- package/lib/incremental.js +0 -62
- package/lib/incremental.js.map +0 -1
- package/lib/layout-xml-tool.d.ts +0 -11
- package/lib/layout-xml-tool.d.ts.map +0 -1
- package/lib/layout-xml-tool.js +0 -239
- package/lib/layout-xml-tool.js.map +0 -1
- package/lib/module-check-tool.d.ts +0 -11
- package/lib/module-check-tool.d.ts.map +0 -1
- package/lib/module-check-tool.js +0 -303
- package/lib/module-check-tool.js.map +0 -1
- package/lib/orchestrator.d.ts +0 -357
- package/lib/orchestrator.d.ts.map +0 -1
- package/lib/orchestrator.js +0 -1497
- package/lib/orchestrator.js.map +0 -1
- package/lib/perf-log-stats-tool.d.ts +0 -13
- package/lib/perf-log-stats-tool.d.ts.map +0 -1
- package/lib/perf-log-stats-tool.js +0 -245
- package/lib/perf-log-stats-tool.js.map +0 -1
- package/lib/phtml-escape-scan-tool.d.ts +0 -11
- package/lib/phtml-escape-scan-tool.d.ts.map +0 -1
- package/lib/phtml-escape-scan-tool.js +0 -166
- package/lib/phtml-escape-scan-tool.js.map +0 -1
- package/lib/providers/ci-trigger.d.ts +0 -44
- package/lib/providers/ci-trigger.d.ts.map +0 -1
- package/lib/providers/ci-trigger.js +0 -150
- package/lib/providers/ci-trigger.js.map +0 -1
- package/lib/review-findings-tool.d.ts +0 -20
- package/lib/review-findings-tool.d.ts.map +0 -1
- package/lib/review-findings-tool.js +0 -39
- package/lib/review-findings-tool.js.map +0 -1
- package/lib/review-history.d.ts +0 -40
- package/lib/review-history.d.ts.map +0 -1
- package/lib/review-history.js +0 -136
- package/lib/review-history.js.map +0 -1
- package/lib/review-marker.d.ts +0 -17
- package/lib/review-marker.d.ts.map +0 -1
- package/lib/review-marker.js +0 -23
- package/lib/review-marker.js.map +0 -1
- package/lib/review-signals.d.ts +0 -17
- package/lib/review-signals.d.ts.map +0 -1
- package/lib/review-signals.js +0 -79
- package/lib/review-signals.js.map +0 -1
- package/lib/scope-split-tool.d.ts +0 -42
- package/lib/scope-split-tool.d.ts.map +0 -1
- package/lib/scope-split-tool.js +0 -108
- package/lib/scope-split-tool.js.map +0 -1
- package/lib/search-tool.d.ts +0 -15
- package/lib/search-tool.d.ts.map +0 -1
- package/lib/search-tool.js +0 -144
- package/lib/search-tool.js.map +0 -1
- package/lib/skill-provider.d.ts +0 -19
- package/lib/skill-provider.d.ts.map +0 -1
- package/lib/skill-provider.js +0 -101
- package/lib/skill-provider.js.map +0 -1
- package/lib/skills-tool.d.ts +0 -29
- package/lib/skills-tool.d.ts.map +0 -1
- package/lib/skills-tool.js +0 -185
- package/lib/skills-tool.js.map +0 -1
- package/lib/source.d.ts +0 -23
- package/lib/source.d.ts.map +0 -1
- package/lib/source.js +0 -16
- package/lib/source.js.map +0 -1
- package/lib/tool-policy.d.ts +0 -20
- package/lib/tool-policy.d.ts.map +0 -1
- package/lib/tool-policy.js +0 -42
- package/lib/tool-policy.js.map +0 -1
- package/presets/maestro-auditor.patch.yml +0 -54
- package/presets/maestro-coder/agent.cordis.yml +0 -223
- package/presets/maestro-coder/preset.yml +0 -2
- package/presets/maestro-reviewer.patch.yml +0 -55
- package/profiles/reviewer-ci/cordis.patch.yml +0 -78
- package/profiles/reviewer-ci/package.json +0 -19
- package/profiles/reviewer-ci/pnpm-lock.yaml +0 -8207
- package/profiles/reviewer-ci/pnpm-workspace.yaml +0 -36
- package/skills/dsh-native-tools/SKILL.md +0 -80
- package/src/host/ci-clone.ts +0 -54
- package/src/host/ci-coexist.ts +0 -45
- package/src/host/dsh-skill.d.ts +0 -72
- package/src/host/gitlab-auth.ts +0 -13
- package/src/host/gitlab-client.ts +0 -332
- package/src/host/govard-lint-detection.ts +0 -47
- package/src/host/hyva-csp-scan-tool.ts +0 -165
- package/src/host/hyva-theme-inspect-tool.ts +0 -258
- package/src/host/incremental.ts +0 -86
- package/src/host/layout-xml-tool.ts +0 -190
- package/src/host/module-check-tool.ts +0 -187
- package/src/host/orchestrator.ts +0 -1641
- package/src/host/perf-log-stats-tool.ts +0 -224
- package/src/host/phtml-escape-scan-tool.ts +0 -112
- package/src/host/providers/ci-trigger.ts +0 -168
- package/src/host/review-findings-tool.ts +0 -59
- package/src/host/review-history.ts +0 -168
- package/src/host/review-marker.ts +0 -25
- package/src/host/review-signals.ts +0 -83
- package/src/host/scope-split-tool.ts +0 -109
- package/src/host/search-tool.ts +0 -152
- package/src/host/skill-provider.ts +0 -94
- package/src/host/skills-tool.ts +0 -218
- package/src/host/source.ts +0 -26
- package/src/host/tool-policy.ts +0 -49
- package/templates/reviewer-project.gitlab-ci.yml +0 -93
- package/templates/source-project.gitlab-ci.yml +0 -48
|
@@ -1,55 +0,0 @@
|
|
|
1
|
-
# Agent preset Maestro Reviewer: declared as a bundle patch row so that every
|
|
2
|
-
# profile composing @ddtcorex/dsh-maestro-review gets it. DSH 0.1.7 collects
|
|
3
|
-
# preset definitions from loader rows naming @deepseek-ai/dsh-agent-preset; the
|
|
4
|
-
# retired plural @deepseek-ai/dsh-agent-presets instead scanned
|
|
5
|
-
# $DSH_HOME/.agent-presets, which is why the reviewer image used to COPY the
|
|
6
|
-
# preset directories in. A profile that wants a different composition overrides
|
|
7
|
-
# this row by bare id (no `insert:` wrapper) rather than inserting a second one.
|
|
8
|
-
- insert:
|
|
9
|
-
- id: preset-dsh-maestro-reviewer
|
|
10
|
-
name: '@deepseek-ai/dsh-agent-preset'
|
|
11
|
-
config:
|
|
12
|
-
id: dsh-maestro-reviewer
|
|
13
|
-
name: Maestro Reviewer
|
|
14
|
-
description: >-
|
|
15
|
-
Automated AI Tech Lead that reviews a GitLab merge request's diff against project coding standards. Invoked programmatically by dsh-maestro-review's orchestrator — not meant for manual selection.
|
|
16
|
-
plugins:
|
|
17
|
-
- id: persona
|
|
18
|
-
name: '@deepseek-ai/dsh-persona'
|
|
19
|
-
config:
|
|
20
|
-
# The prefix is the model-stable part of the prompt that stays
|
|
21
|
-
# cacheable. DSH 0.2.1-alpha.x removed the loop's built-in cwd
|
|
22
|
-
# prompt variable (an unresolved reference fails before a model
|
|
23
|
-
# request); the working-directory service supplies the execution
|
|
24
|
-
# directory as required user context instead, so no directory
|
|
25
|
-
# clause is stated here.
|
|
26
|
-
prefix: |
|
|
27
|
-
You are Maestro Reviewer, an AI Tech Lead. Workflow:
|
|
28
|
-
1. If the review request names a profile, call maestro_load_review_profile with that profile before inspecting code — it fails closed if the required skill set is incomplete. For a diff-only review with no local checkout or Magento environment, skip this step: there is no profile to load, and the diff is all the context you need.
|
|
29
|
-
2. Call gitlab_list_own_review_threads to see which findings you already raised on this merge request.
|
|
30
|
-
3. Call gitlab_get_mr_diff to read the current diff.
|
|
31
|
-
4. For each existing thread whose file/line was touched by the new commits, decide whether it still applies, looks fixed, or needs a different comment — reply to it (status: "reply"). Never resolve a thread yourself.
|
|
32
|
-
5. For genuinely new issues with no existing thread, prepare a new inline comment (status: "new").
|
|
33
|
-
6. Call report_review_findings exactly once with your complete list of findings, then stop. Do not call gitlab_post_mr_comment, gitlab_post_inline_comment, or gitlab_reply_to_thread yourself — the orchestrator posts them from your report_review_findings call.
|
|
34
|
-
|
|
35
|
-
- id: skills-tool
|
|
36
|
-
name: '@ddtcorex/dsh-maestro-review/lib/skills-tool.js'
|
|
37
|
-
|
|
38
|
-
# Delegation tools: the providers live in the Profile
|
|
39
|
-
# (`subagent-codex` + `subagent-claude-code` rows), so a deployment without
|
|
40
|
-
# those bundles gets inert rows — `tool-subagent` registers no tool until its
|
|
41
|
-
# provider appears — rather than a failed mount. One-shot rows: a review
|
|
42
|
-
# delegates a bounded task and collects the result.
|
|
43
|
-
- id: tool-subagent-codex
|
|
44
|
-
name: '@deepseek-ai/dsh-tool-subagent'
|
|
45
|
-
config:
|
|
46
|
-
provider: codex
|
|
47
|
-
toolName: subagent_codex
|
|
48
|
-
maxDepth: provider-managed
|
|
49
|
-
|
|
50
|
-
- id: tool-subagent-claude-code
|
|
51
|
-
name: '@deepseek-ai/dsh-tool-subagent'
|
|
52
|
-
config:
|
|
53
|
-
provider: claude-code
|
|
54
|
-
toolName: subagent_claude_code
|
|
55
|
-
maxDepth: provider-managed
|
|
@@ -1,78 +0,0 @@
|
|
|
1
|
-
# profiles/reviewer-ci/cordis.patch.yml — CI-only profile: no webhook, no HTTP server.
|
|
2
|
-
#
|
|
3
|
-
# `dsh-base` (see dsh.profile.bundles in package.json) already self-composes its
|
|
4
|
-
# own ~80-row cordis.patch.yml (it ships a dsh.bundle.patch field). So does
|
|
5
|
-
# @ddtcorex/dsh-maestro-review itself, self-composing 4 rows: maestro-review-host,
|
|
6
|
-
# maestro-review-webhook, maestro-review-orchestrator, maestro-review-settings-rpc
|
|
7
|
-
# (verified 2026-09-03: using `insert:` for a row id the bundle already provides throws
|
|
8
|
-
# "duplicate loader entry id" at boot). This file overrides three of those rows (webhook,
|
|
9
|
-
# settings-rpc, orchestrator; bare `- id: X` entries, no
|
|
10
|
-
# `insert:` wrapper — the same pattern deepseek-harness's own headless bundle uses to
|
|
11
|
-
# override `system-prompt`/`tools`) instead of re-inserting them.
|
|
12
|
-
|
|
13
|
-
# maestro-review-webhook needs `webServer`, which this profile never provides (no dsh
|
|
14
|
-
# web/web-app bundle) — disable it explicitly rather than leaving it waiting forever
|
|
15
|
-
# on a service that will never arrive.
|
|
16
|
-
- id: maestro-review-webhook
|
|
17
|
-
disabled: true
|
|
18
|
-
|
|
19
|
-
# maestro-review-settings-rpc serves the Settings UI over the web `connection`
|
|
20
|
-
# (via `maestroTunnel`) — meaningless in a CI container where neither service
|
|
21
|
-
# exists. Verified 2026-09-04: leaving it enabled fails boot with
|
|
22
|
-
# "1 entry did not activate .../settings-rpc.js: pending (waiting for
|
|
23
|
-
# services: connection, maestroTunnel)".
|
|
24
|
-
- id: maestro-review-settings-rpc
|
|
25
|
-
disabled: true
|
|
26
|
-
|
|
27
|
-
# Override the auto-composed row's placeholder config. projectMappings is
|
|
28
|
-
# deliberately empty — this profile only serves the diff-only review path
|
|
29
|
-
# (phase 1, quick mode), matching the non-goal "no full-stack govard env up
|
|
30
|
-
# in CI in phase 1". gitlabBaseUrl must read GITLAB_HOST at runtime (not a
|
|
31
|
-
# static placeholder) since a source project can point ci-trigger.ts at any
|
|
32
|
-
# GitLab host via its own CI variables.
|
|
33
|
-
- id: maestro-review-orchestrator
|
|
34
|
-
config:
|
|
35
|
-
# Ternary must be quoted — an unquoted !!js scalar containing a bare `:`
|
|
36
|
-
# (the ternary's false-branch separator) gets misparsed as a YAML mapping
|
|
37
|
-
# key instead of passed through whole to the JS evaluator (verified
|
|
38
|
-
# 2026-09-03: without quotes, cordis reported gitlabBaseUrl as
|
|
39
|
-
# "[object Object]" instead of a string).
|
|
40
|
-
gitlabBaseUrl: !!js "process.env.GITLAB_HOST ? 'https://' + process.env.GITLAB_HOST : ''"
|
|
41
|
-
gitlabToken: !!js process.env.MAESTRO_GITLAB_TOKEN
|
|
42
|
-
# botUsername drives more than mention text: review-signals.ts's
|
|
43
|
-
# unawardOwn() (clearing the running "eyes" marker) and gitlab-client.ts's
|
|
44
|
-
# selectOwnThreads() (re-review dedup/reply) both filter GitLab objects by
|
|
45
|
-
# `author.username === botUsername`. The hardcoded "maestro-bot" default
|
|
46
|
-
# only matches if MAESTRO_GITLAB_TOKEN really belongs to a "maestro-bot"
|
|
47
|
-
# account; a personal PAT posts as its owner's real username instead, so
|
|
48
|
-
# neither check ever recognized its own objects (found live 2026-09-05:
|
|
49
|
-
# every award_emoji in E2E testing was posted as the token owner, never
|
|
50
|
-
# "maestro-bot" — stale eyes markers never cleared). Set
|
|
51
|
-
# REVIEW_BOT_USERNAME to the token's real GitLab username when it isn't
|
|
52
|
-
# a literal "maestro-bot" account.
|
|
53
|
-
botUsername: !!js "process.env.REVIEW_BOT_USERNAME || 'maestro-bot'"
|
|
54
|
-
projectMappings: []
|
|
55
|
-
agentTimeoutMs: 1200000
|
|
56
|
-
# Pinned review model (no Settings UI in CI). Optional as a pair: both unset
|
|
57
|
-
# → host default; ID without provider → the review fails with a provider
|
|
58
|
-
# error instead of silently calling the wrong model.
|
|
59
|
-
reviewModel: !!js "process.env.REVIEW_MODEL ? { provider: process.env.REVIEW_MODEL_PROVIDER, model: process.env.REVIEW_MODEL } : undefined"
|
|
60
|
-
|
|
61
|
-
# New rows this profile needs that dsh-base/dsh-maestro-review don't already provide.
|
|
62
|
-
- insert:
|
|
63
|
-
# The agent-preset registry is the 0.1.7 provider: it collects preset
|
|
64
|
-
# definitions from loader rows, and this bundle now ships the reviewer and
|
|
65
|
-
# auditor declarations as patch rows of its own
|
|
66
|
-
# (./presets/maestro-{reviewer,auditor}.patch.yml), so no directory has to be
|
|
67
|
-
# copied anywhere. The retired plural @deepseek-ai/dsh-agent-presets is gone
|
|
68
|
-
# from this profile on purpose: it was only ever needed to read
|
|
69
|
-
# $DSH_HOME/.agent-presets. (dsh-base does not provide this row — the
|
|
70
|
-
# web-app bundle is what inserts it there — so a headless profile inserts it
|
|
71
|
-
# itself, copied from deepseek-harness/packages/bundle/web-app/cordis.patch.yml.)
|
|
72
|
-
- id: agent-preset-registry
|
|
73
|
-
name: '@deepseek-ai/dsh-agent-preset-registry'
|
|
74
|
-
config:
|
|
75
|
-
default: standard
|
|
76
|
-
|
|
77
|
-
- id: maestro-review-ci-trigger
|
|
78
|
-
name: '@ddtcorex/dsh-maestro-review/lib/providers/ci-trigger.js'
|
|
@@ -1,19 +0,0 @@
|
|
|
1
|
-
{
|
|
2
|
-
"name": "reviewer-ci-profile",
|
|
3
|
-
"private": true,
|
|
4
|
-
"dsh": {
|
|
5
|
-
"profile": {
|
|
6
|
-
"bundles": [
|
|
7
|
-
"@deepseek-ai/dsh-base",
|
|
8
|
-
"@ddtcorex/dsh-maestro-review",
|
|
9
|
-
"@ddtcorex/maestro-skills"
|
|
10
|
-
]
|
|
11
|
-
}
|
|
12
|
-
},
|
|
13
|
-
"dependencies": {
|
|
14
|
-
"@ddtcorex/dsh-maestro-review": "0.10.0",
|
|
15
|
-
"@ddtcorex/maestro-skills": "^2.13.0",
|
|
16
|
-
"@deepseek-ai/dsh": "0.2.0-rc.2",
|
|
17
|
-
"@deepseek-ai/dsh-agent-preset-registry": "0.2.0-rc.2"
|
|
18
|
-
}
|
|
19
|
-
}
|