@ddtcorex/dsh-maestro-review 0.12.0 → 0.14.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/README.md +31 -58
- package/cordis.patch.yml +23 -18
- package/lib/config-store.d.ts +9 -1
- package/lib/config-store.d.ts.map +1 -1
- package/lib/config-store.js +1 -1
- package/lib/config-store.js.map +1 -1
- package/lib/events.d.ts +5 -45
- package/lib/events.d.ts.map +1 -1
- package/lib/host-orchestrator.d.ts +128 -0
- package/lib/host-orchestrator.d.ts.map +1 -0
- package/lib/host-orchestrator.js +408 -0
- package/lib/host-orchestrator.js.map +1 -0
- package/lib/index.d.ts +7 -2
- package/lib/index.d.ts.map +1 -1
- package/lib/index.js +7 -43
- package/lib/index.js.map +1 -1
- package/lib/review-intake.d.ts +1 -1
- package/lib/review-intake.d.ts.map +1 -1
- package/lib/settings-rpc.js +1 -1
- package/lib/settings-rpc.js.map +1 -1
- package/package.json +19 -36
- package/src/client/index.tsx +1 -1
- package/src/host/augment.d.ts +3 -1
- package/src/host/config-store.ts +2 -2
- package/src/host/events.ts +5 -45
- package/src/host/host-orchestrator.ts +461 -0
- package/src/host/index.ts +7 -35
- package/src/host/providers/gitlab.ts +1 -1
- package/src/host/review-intake.ts +1 -1
- package/src/host/settings-rpc.ts +1 -1
- package/lib/ci-clone.d.ts +0 -21
- package/lib/ci-clone.d.ts.map +0 -1
- package/lib/ci-clone.js +0 -35
- package/lib/ci-clone.js.map +0 -1
- package/lib/ci-coexist.d.ts +0 -11
- package/lib/ci-coexist.d.ts.map +0 -1
- package/lib/ci-coexist.js +0 -38
- package/lib/ci-coexist.js.map +0 -1
- package/lib/gitlab-auth.d.ts +0 -11
- package/lib/gitlab-auth.d.ts.map +0 -1
- package/lib/gitlab-auth.js +0 -15
- package/lib/gitlab-auth.js.map +0 -1
- package/lib/gitlab-client.d.ts +0 -78
- package/lib/gitlab-client.d.ts.map +0 -1
- package/lib/gitlab-client.js +0 -270
- package/lib/gitlab-client.js.map +0 -1
- package/lib/govard-lint-detection.d.ts +0 -20
- package/lib/govard-lint-detection.d.ts.map +0 -1
- package/lib/govard-lint-detection.js +0 -48
- package/lib/govard-lint-detection.js.map +0 -1
- package/lib/hyva-csp-scan-tool.d.ts +0 -11
- package/lib/hyva-csp-scan-tool.d.ts.map +0 -1
- package/lib/hyva-csp-scan-tool.js +0 -193
- package/lib/hyva-csp-scan-tool.js.map +0 -1
- package/lib/hyva-theme-inspect-tool.d.ts +0 -10
- package/lib/hyva-theme-inspect-tool.d.ts.map +0 -1
- package/lib/hyva-theme-inspect-tool.js +0 -299
- package/lib/hyva-theme-inspect-tool.js.map +0 -1
- package/lib/incremental.d.ts +0 -28
- package/lib/incremental.d.ts.map +0 -1
- package/lib/incremental.js +0 -62
- package/lib/incremental.js.map +0 -1
- package/lib/layout-xml-tool.d.ts +0 -11
- package/lib/layout-xml-tool.d.ts.map +0 -1
- package/lib/layout-xml-tool.js +0 -239
- package/lib/layout-xml-tool.js.map +0 -1
- package/lib/module-check-tool.d.ts +0 -11
- package/lib/module-check-tool.d.ts.map +0 -1
- package/lib/module-check-tool.js +0 -303
- package/lib/module-check-tool.js.map +0 -1
- package/lib/orchestrator.d.ts +0 -357
- package/lib/orchestrator.d.ts.map +0 -1
- package/lib/orchestrator.js +0 -1497
- package/lib/orchestrator.js.map +0 -1
- package/lib/perf-log-stats-tool.d.ts +0 -13
- package/lib/perf-log-stats-tool.d.ts.map +0 -1
- package/lib/perf-log-stats-tool.js +0 -245
- package/lib/perf-log-stats-tool.js.map +0 -1
- package/lib/phtml-escape-scan-tool.d.ts +0 -11
- package/lib/phtml-escape-scan-tool.d.ts.map +0 -1
- package/lib/phtml-escape-scan-tool.js +0 -166
- package/lib/phtml-escape-scan-tool.js.map +0 -1
- package/lib/providers/ci-trigger.d.ts +0 -44
- package/lib/providers/ci-trigger.d.ts.map +0 -1
- package/lib/providers/ci-trigger.js +0 -150
- package/lib/providers/ci-trigger.js.map +0 -1
- package/lib/review-findings-tool.d.ts +0 -20
- package/lib/review-findings-tool.d.ts.map +0 -1
- package/lib/review-findings-tool.js +0 -39
- package/lib/review-findings-tool.js.map +0 -1
- package/lib/review-history.d.ts +0 -40
- package/lib/review-history.d.ts.map +0 -1
- package/lib/review-history.js +0 -136
- package/lib/review-history.js.map +0 -1
- package/lib/review-marker.d.ts +0 -17
- package/lib/review-marker.d.ts.map +0 -1
- package/lib/review-marker.js +0 -23
- package/lib/review-marker.js.map +0 -1
- package/lib/review-signals.d.ts +0 -17
- package/lib/review-signals.d.ts.map +0 -1
- package/lib/review-signals.js +0 -79
- package/lib/review-signals.js.map +0 -1
- package/lib/scope-split-tool.d.ts +0 -42
- package/lib/scope-split-tool.d.ts.map +0 -1
- package/lib/scope-split-tool.js +0 -108
- package/lib/scope-split-tool.js.map +0 -1
- package/lib/search-tool.d.ts +0 -15
- package/lib/search-tool.d.ts.map +0 -1
- package/lib/search-tool.js +0 -144
- package/lib/search-tool.js.map +0 -1
- package/lib/skill-provider.d.ts +0 -19
- package/lib/skill-provider.d.ts.map +0 -1
- package/lib/skill-provider.js +0 -101
- package/lib/skill-provider.js.map +0 -1
- package/lib/skills-tool.d.ts +0 -29
- package/lib/skills-tool.d.ts.map +0 -1
- package/lib/skills-tool.js +0 -185
- package/lib/skills-tool.js.map +0 -1
- package/lib/source.d.ts +0 -23
- package/lib/source.d.ts.map +0 -1
- package/lib/source.js +0 -16
- package/lib/source.js.map +0 -1
- package/lib/tool-policy.d.ts +0 -20
- package/lib/tool-policy.d.ts.map +0 -1
- package/lib/tool-policy.js +0 -42
- package/lib/tool-policy.js.map +0 -1
- package/presets/maestro-auditor.patch.yml +0 -54
- package/presets/maestro-coder/agent.cordis.yml +0 -223
- package/presets/maestro-coder/preset.yml +0 -2
- package/presets/maestro-reviewer.patch.yml +0 -55
- package/profiles/reviewer-ci/cordis.patch.yml +0 -78
- package/profiles/reviewer-ci/package.json +0 -19
- package/profiles/reviewer-ci/pnpm-lock.yaml +0 -8207
- package/profiles/reviewer-ci/pnpm-workspace.yaml +0 -36
- package/skills/dsh-native-tools/SKILL.md +0 -80
- package/src/host/ci-clone.ts +0 -54
- package/src/host/ci-coexist.ts +0 -45
- package/src/host/dsh-skill.d.ts +0 -72
- package/src/host/gitlab-auth.ts +0 -13
- package/src/host/gitlab-client.ts +0 -332
- package/src/host/govard-lint-detection.ts +0 -47
- package/src/host/hyva-csp-scan-tool.ts +0 -165
- package/src/host/hyva-theme-inspect-tool.ts +0 -258
- package/src/host/incremental.ts +0 -86
- package/src/host/layout-xml-tool.ts +0 -190
- package/src/host/module-check-tool.ts +0 -187
- package/src/host/orchestrator.ts +0 -1641
- package/src/host/perf-log-stats-tool.ts +0 -224
- package/src/host/phtml-escape-scan-tool.ts +0 -112
- package/src/host/providers/ci-trigger.ts +0 -168
- package/src/host/review-findings-tool.ts +0 -59
- package/src/host/review-history.ts +0 -168
- package/src/host/review-marker.ts +0 -25
- package/src/host/review-signals.ts +0 -83
- package/src/host/scope-split-tool.ts +0 -109
- package/src/host/search-tool.ts +0 -152
- package/src/host/skill-provider.ts +0 -94
- package/src/host/skills-tool.ts +0 -218
- package/src/host/source.ts +0 -26
- package/src/host/tool-policy.ts +0 -49
- package/templates/reviewer-project.gitlab-ci.yml +0 -93
- package/templates/source-project.gitlab-ci.yml +0 -48
|
@@ -1,44 +0,0 @@
|
|
|
1
|
-
import type { Context } from '@deepseek-ai/cordis';
|
|
2
|
-
import z from '@deepseek-ai/schemastery';
|
|
3
|
-
import type { ReviewResult } from '../events.js';
|
|
4
|
-
import type { ReviewSkillProfile } from '../skills-tool.js';
|
|
5
|
-
export declare const name = "maestro-review-ci-trigger";
|
|
6
|
-
export declare const inject: readonly ["reviewRunner"];
|
|
7
|
-
export interface CiEnvConfig {
|
|
8
|
-
gitlabBaseUrl: string;
|
|
9
|
-
gitlabToken: string;
|
|
10
|
-
sourceProjectId: number;
|
|
11
|
-
mrIid: number;
|
|
12
|
-
mode: 'quick' | 'deep';
|
|
13
|
-
dryRun: boolean;
|
|
14
|
-
reviewProfile?: ReviewSkillProfile;
|
|
15
|
-
/** Mirror of Settings UI autoRereviewOnPush (default off): re-review new pushes. */
|
|
16
|
-
rereviewOnPush: boolean;
|
|
17
|
-
}
|
|
18
|
-
export declare const CiEnvConfig: z<CiEnvConfig>;
|
|
19
|
-
/**
|
|
20
|
-
* Reads the CI contract env vars (spec §5.2) — not Cordis-supplied config, since these are
|
|
21
|
-
* per-run values a static profile config cannot hold. schemastery's `.required()` only rejects
|
|
22
|
-
* `undefined`, not an empty string, so GITLAB_HOST/MAESTRO_GITLAB_TOKEN presence is checked here
|
|
23
|
-
* before defaulting to `''` — otherwise a missing env var would silently pass validation.
|
|
24
|
-
*/
|
|
25
|
-
export declare function parseCiEnvConfig(env: Record<string, string | undefined>): CiEnvConfig;
|
|
26
|
-
/** The one field a webhook payload carries that env vars don't — orchestrator fetches the diff itself. */
|
|
27
|
-
export declare function fetchMrSourceBranch(config: CiEnvConfig, fetcher?: typeof fetch): Promise<string>;
|
|
28
|
-
/** MR detail pieces CI needs in one call: source branch (worktree) + head SHA (push-gate) + project path (comment header/link). */
|
|
29
|
-
export declare function fetchMrDetail(config: CiEnvConfig, fetcher?: typeof fetch): Promise<{
|
|
30
|
-
sourceBranch: string;
|
|
31
|
-
headSha: string;
|
|
32
|
-
projectPath: string;
|
|
33
|
-
}>;
|
|
34
|
-
export declare function runCiTrigger(ctx: Context, config: CiEnvConfig, deps?: {
|
|
35
|
-
fetcher?: typeof fetch;
|
|
36
|
-
writeFile?: typeof import('node:fs/promises').writeFile;
|
|
37
|
-
history?: {
|
|
38
|
-
lastCompletedReview(projectId: number, mrIid: number): Promise<{
|
|
39
|
-
headSha?: string;
|
|
40
|
-
} | undefined>;
|
|
41
|
-
};
|
|
42
|
-
}): Promise<ReviewResult>;
|
|
43
|
-
export declare function apply(ctx: Context): void;
|
|
44
|
-
//# sourceMappingURL=ci-trigger.d.ts.map
|
|
@@ -1 +0,0 @@
|
|
|
1
|
-
{"version":3,"file":"ci-trigger.d.ts","sourceRoot":"","sources":["../../src/host/providers/ci-trigger.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,OAAO,EAAE,MAAM,qBAAqB,CAAA;AAClD,OAAO,CAAC,MAAM,0BAA0B,CAAA;AAExC,OAAO,KAAK,EAAiB,YAAY,EAAE,MAAM,cAAc,CAAA;AAE/D,OAAO,KAAK,EAAE,kBAAkB,EAAE,MAAM,mBAAmB,CAAA;AAI3D,eAAO,MAAM,IAAI,8BAA8B,CAAA;AAC/C,eAAO,MAAM,MAAM,2BAA4B,CAAA;AAI/C,MAAM,WAAW,WAAW;IAC1B,aAAa,EAAE,MAAM,CAAA;IACrB,WAAW,EAAE,MAAM,CAAA;IACnB,eAAe,EAAE,MAAM,CAAA;IACvB,KAAK,EAAE,MAAM,CAAA;IACb,IAAI,EAAE,OAAO,GAAG,MAAM,CAAA;IACtB,MAAM,EAAE,OAAO,CAAA;IACf,aAAa,CAAC,EAAE,kBAAkB,CAAA;IAClC,oFAAoF;IACpF,cAAc,EAAE,OAAO,CAAA;CACxB;AAED,eAAO,MAAM,WAAW,EAAE,CAAC,CAAC,WAAW,CASrC,CAAA;AAEF;;;;;GAKG;AACH,wBAAgB,gBAAgB,CAAC,GAAG,EAAE,MAAM,CAAC,MAAM,EAAE,MAAM,GAAG,SAAS,CAAC,GAAG,WAAW,CAgBrF;AAED,0GAA0G;AAC1G,wBAAsB,mBAAmB,CAAC,MAAM,EAAE,WAAW,EAAE,OAAO,GAAE,OAAO,KAAa,GAAG,OAAO,CAAC,MAAM,CAAC,CAE7G;AAED,mIAAmI;AACnI,wBAAsB,aAAa,CAAC,MAAM,EAAE,WAAW,EAAE,OAAO,GAAE,OAAO,KAAa,GAAG,OAAO,CAAC;IAAE,YAAY,EAAE,MAAM,CAAC;IAAC,OAAO,EAAE,MAAM,CAAC;IAAC,WAAW,EAAE,MAAM,CAAA;CAAE,CAAC,CAY/J;AAED,wBAAsB,YAAY,CAChC,GAAG,EAAE,OAAO,EACZ,MAAM,EAAE,WAAW,EACnB,IAAI,GAAE;IACJ,OAAO,CAAC,EAAE,OAAO,KAAK,CAAA;IACtB,SAAS,CAAC,EAAE,cAAc,kBAAkB,EAAE,SAAS,CAAA;IACvD,OAAO,CAAC,EAAE;QAAE,mBAAmB,CAAC,SAAS,EAAE,MAAM,EAAE,KAAK,EAAE,MAAM,GAAG,OAAO,CAAC;YAAE,OAAO,CAAC,EAAE,MAAM,CAAA;SAAE,GAAG,SAAS,CAAC,CAAA;KAAE,CAAA;CAC1G,GACL,OAAO,CAAC,YAAY,CAAC,CAoDvB;AAED,wBAAgB,KAAK,CAAC,GAAG,EAAE,OAAO,GAAG,IAAI,CAwBxC"}
|
|
@@ -1,150 +0,0 @@
|
|
|
1
|
-
import z from '@deepseek-ai/schemastery';
|
|
2
|
-
import { join } from 'node:path';
|
|
3
|
-
import { lastCompletedReview } from '../review-history.js';
|
|
4
|
-
import { gitlabAuthHeaders } from '../gitlab-auth.js';
|
|
5
|
-
import { hasCompletedReviewForSha, hasRunningEyes } from '../ci-coexist.js';
|
|
6
|
-
export const name = 'maestro-review-ci-trigger';
|
|
7
|
-
export const inject = ['reviewRunner'];
|
|
8
|
-
const REVIEW_PROFILES = ['magento2', 'laravel', 'symfony', 'wordpress', 'generic'];
|
|
9
|
-
export const CiEnvConfig = z.object({
|
|
10
|
-
gitlabBaseUrl: z.string().required(),
|
|
11
|
-
gitlabToken: z.string().role('secret').required(),
|
|
12
|
-
sourceProjectId: z.number().required(),
|
|
13
|
-
mrIid: z.number().required(),
|
|
14
|
-
mode: z.union([z.const('quick'), z.const('deep')]).default('quick'),
|
|
15
|
-
dryRun: z.boolean().default(false),
|
|
16
|
-
reviewProfile: z.union([z.const('magento2'), z.const('laravel'), z.const('symfony'), z.const('wordpress'), z.const('generic')]),
|
|
17
|
-
rereviewOnPush: z.boolean().default(false),
|
|
18
|
-
});
|
|
19
|
-
/**
|
|
20
|
-
* Reads the CI contract env vars (spec §5.2) — not Cordis-supplied config, since these are
|
|
21
|
-
* per-run values a static profile config cannot hold. schemastery's `.required()` only rejects
|
|
22
|
-
* `undefined`, not an empty string, so GITLAB_HOST/MAESTRO_GITLAB_TOKEN presence is checked here
|
|
23
|
-
* before defaulting to `''` — otherwise a missing env var would silently pass validation.
|
|
24
|
-
*/
|
|
25
|
-
export function parseCiEnvConfig(env) {
|
|
26
|
-
if (env.GITLAB_HOST === undefined)
|
|
27
|
-
throw new Error('missing GITLAB_HOST');
|
|
28
|
-
if (env.MAESTRO_GITLAB_TOKEN === undefined)
|
|
29
|
-
throw new Error('missing MAESTRO_GITLAB_TOKEN');
|
|
30
|
-
if (env.REVIEW_PROFILE !== undefined && !REVIEW_PROFILES.includes(env.REVIEW_PROFILE)) {
|
|
31
|
-
throw new Error(`unsupported REVIEW_PROFILE "${env.REVIEW_PROFILE}" (supported: ${REVIEW_PROFILES.join(', ')})`);
|
|
32
|
-
}
|
|
33
|
-
return CiEnvConfig({
|
|
34
|
-
gitlabBaseUrl: `https://${env.GITLAB_HOST}`,
|
|
35
|
-
gitlabToken: env.MAESTRO_GITLAB_TOKEN,
|
|
36
|
-
sourceProjectId: Number(env.SOURCE_PROJECT_ID),
|
|
37
|
-
mrIid: Number(env.MR_IID),
|
|
38
|
-
mode: env.REVIEW_MODE === 'deep' ? 'deep' : 'quick',
|
|
39
|
-
dryRun: env.REVIEW_DRY_RUN === '1',
|
|
40
|
-
reviewProfile: env.REVIEW_PROFILE,
|
|
41
|
-
rereviewOnPush: env.REVIEW_ON_PUSH === '1',
|
|
42
|
-
});
|
|
43
|
-
}
|
|
44
|
-
/** The one field a webhook payload carries that env vars don't — orchestrator fetches the diff itself. */
|
|
45
|
-
export async function fetchMrSourceBranch(config, fetcher = fetch) {
|
|
46
|
-
return (await fetchMrDetail(config, fetcher)).sourceBranch;
|
|
47
|
-
}
|
|
48
|
-
/** MR detail pieces CI needs in one call: source branch (worktree) + head SHA (push-gate) + project path (comment header/link). */
|
|
49
|
-
export async function fetchMrDetail(config, fetcher = fetch) {
|
|
50
|
-
const url = `${config.gitlabBaseUrl}/api/v4/projects/${config.sourceProjectId}/merge_requests/${config.mrIid}`;
|
|
51
|
-
const res = await fetcher(url, { headers: gitlabAuthHeaders(config.gitlabToken) });
|
|
52
|
-
if (!res.ok)
|
|
53
|
-
throw new Error(`GitLab API error ${res.status}: ${await res.text()}`);
|
|
54
|
-
const body = await res.json();
|
|
55
|
-
if (typeof body.source_branch !== 'string')
|
|
56
|
-
throw new Error('GitLab merge request response is missing source_branch');
|
|
57
|
-
if (typeof body.sha !== 'string')
|
|
58
|
-
throw new Error('GitLab merge request response is missing sha');
|
|
59
|
-
// references.full looks like "group/sub/project!123" — the real path feeds the
|
|
60
|
-
// comment header and View-MR link. Absent on old servers: fall back to project/<id>.
|
|
61
|
-
const full = body.references?.full;
|
|
62
|
-
const projectPath = typeof full === 'string' && full.includes('!') ? full.slice(0, full.indexOf('!')) : `project/${config.sourceProjectId}`;
|
|
63
|
-
return { sourceBranch: body.source_branch, headSha: body.sha, projectPath };
|
|
64
|
-
}
|
|
65
|
-
export async function runCiTrigger(ctx, config, deps = {}) {
|
|
66
|
-
const { sourceBranch, headSha, projectPath } = await fetchMrDetail(config, deps.fetcher);
|
|
67
|
-
// Push-gate (mirror of the webhook autoRereviewOnPush semantics): the bridge fires
|
|
68
|
-
// on every MR pipeline, so skip when this exact head SHA already completed — and
|
|
69
|
-
// skip new pushes too unless REVIEW_ON_PUSH=1. A re-run then gets the H6 incremental
|
|
70
|
-
// block from history for free. Cache miss (no history) fails open toward running.
|
|
71
|
-
const history = deps.history ?? { lastCompletedReview };
|
|
72
|
-
const prior = await history.lastCompletedReview(config.sourceProjectId, config.mrIid);
|
|
73
|
-
let result;
|
|
74
|
-
if (prior?.headSha === headSha) {
|
|
75
|
-
result = { ok: true, summary: `already reviewed at ${headSha}, skipping`, failures: [], durationMs: 0 };
|
|
76
|
-
}
|
|
77
|
-
else if (prior !== undefined && !config.rereviewOnPush) {
|
|
78
|
-
result = { ok: true, summary: `new commits since ${prior.headSha} but REVIEW_ON_PUSH is not set, skipping`, failures: [], durationMs: 0 };
|
|
79
|
-
}
|
|
80
|
-
else {
|
|
81
|
-
// Coexistence (CI yields to webhook): the CI history store is invisible to
|
|
82
|
-
// the webhook flow and vice versa, so check the MR itself for a completed
|
|
83
|
-
// review marker of this SHA or an in-flight eyes marker before booting.
|
|
84
|
-
const coFetcher = deps.fetcher ?? fetch;
|
|
85
|
-
if (await hasCompletedReviewForSha(coFetcher, config.gitlabBaseUrl, config.gitlabToken, config.sourceProjectId, config.mrIid, headSha)) {
|
|
86
|
-
result = { ok: true, summary: `webhook already reviewed ${headSha} — skipping`, failures: [], durationMs: 0 };
|
|
87
|
-
}
|
|
88
|
-
else if (await hasRunningEyes(coFetcher, config.gitlabBaseUrl, config.gitlabToken, config.sourceProjectId, config.mrIid)) {
|
|
89
|
-
result = { ok: true, summary: 'another review is running — skipping', failures: [], durationMs: 0 };
|
|
90
|
-
}
|
|
91
|
-
else {
|
|
92
|
-
// The reviewer-ci profile's own projectMappings is always [], so the
|
|
93
|
-
// orchestrator's mapping lookup on projectPath never matches regardless
|
|
94
|
-
// of its exact value — but the real path feeds the comment header and
|
|
95
|
-
// View-MR link, so prefer it over the synthetic project/<id> fallback.
|
|
96
|
-
const request = {
|
|
97
|
-
projectPath,
|
|
98
|
-
projectId: config.sourceProjectId,
|
|
99
|
-
mrIid: config.mrIid,
|
|
100
|
-
sourceBranch,
|
|
101
|
-
headSha,
|
|
102
|
-
trigger: 'mention',
|
|
103
|
-
mode: config.mode,
|
|
104
|
-
scope: { kind: 'mr' },
|
|
105
|
-
reviewProfile: config.reviewProfile,
|
|
106
|
-
};
|
|
107
|
-
result = await ctx.reviewRunner(request);
|
|
108
|
-
}
|
|
109
|
-
}
|
|
110
|
-
const { writeFile } = deps.writeFile !== undefined ? { writeFile: deps.writeFile } : await import('node:fs/promises');
|
|
111
|
-
// entrypoint.sh cds into deepseek-harness before execing dsh, so a bare relative
|
|
112
|
-
// path would land inside the harness checkout (lost with the container). The
|
|
113
|
-
// entrypoint exports REVIEW_REPORT_DIR=$PWD captured before the cd, so reports land
|
|
114
|
-
// in the CI job's working directory where `artifacts:` picks them up.
|
|
115
|
-
const reportDir = process.env.REVIEW_REPORT_DIR?.trim() || '.';
|
|
116
|
-
const report = { ...result, projectId: config.sourceProjectId, mrIid: config.mrIid, mode: config.mode, generatedAt: new Date().toISOString() };
|
|
117
|
-
await writeFile(join(reportDir, 'review-report.json'), JSON.stringify(report, null, 2), 'utf-8');
|
|
118
|
-
const md = `# Review Report\n\n**Project:** ${config.sourceProjectId} !${config.mrIid}\n**Mode:** ${config.mode}\n**Duration:** ${result.durationMs}ms\n\n${result.summary ?? '(no summary)'}\n${result.failures.length > 0 ? `\nFailures:\n${result.failures.map(f => `- ${f}`).join('\n')}\n` : ''}`;
|
|
119
|
-
await writeFile(join(reportDir, 'review-report.md'), md, 'utf-8');
|
|
120
|
-
return result;
|
|
121
|
-
}
|
|
122
|
-
export function apply(ctx) {
|
|
123
|
-
ctx.effect(() => {
|
|
124
|
-
void (async () => {
|
|
125
|
-
try {
|
|
126
|
-
const config = parseCiEnvConfig(process.env);
|
|
127
|
-
console.log(`[review] ci-trigger starting: project ${config.sourceProjectId} !${config.mrIid} mode=${config.mode} dryRun=${config.dryRun}`);
|
|
128
|
-
const result = config.dryRun
|
|
129
|
-
? { ok: true, summary: '[dry-run] config valid, skipping review', failures: [], durationMs: 0 }
|
|
130
|
-
: await runCiTrigger(ctx, config);
|
|
131
|
-
console.log(`[review] ci-trigger finished: ok=${result.ok} summary=${JSON.stringify(result.summary)} failures=${result.failures.length}`);
|
|
132
|
-
for (const failure of result.failures)
|
|
133
|
-
console.error(`[review] ci-trigger failure: ${failure}`);
|
|
134
|
-
const exit = ctx.get('appExit');
|
|
135
|
-
if (exit === undefined) {
|
|
136
|
-
console.error('[review] ctx.get(\'appExit\') is undefined — the launcher did not provide it, process cannot signal its real exit code');
|
|
137
|
-
}
|
|
138
|
-
else {
|
|
139
|
-
exit(result.ok ? 0 : 1);
|
|
140
|
-
}
|
|
141
|
-
}
|
|
142
|
-
catch (err) {
|
|
143
|
-
console.error('maestro-review-ci-trigger:', err instanceof Error ? err.message : String(err));
|
|
144
|
-
ctx.get('appExit')?.(1);
|
|
145
|
-
}
|
|
146
|
-
})();
|
|
147
|
-
return () => { };
|
|
148
|
-
}, 'maestro-review-ci-trigger run');
|
|
149
|
-
}
|
|
150
|
-
//# sourceMappingURL=ci-trigger.js.map
|
|
@@ -1 +0,0 @@
|
|
|
1
|
-
{"version":3,"file":"ci-trigger.js","sourceRoot":"","sources":["../../src/host/providers/ci-trigger.ts"],"names":[],"mappings":"AACA,OAAO,CAAC,MAAM,0BAA0B,CAAA;AACxC,OAAO,EAAE,IAAI,EAAE,MAAM,WAAW,CAAA;AAEhC,OAAO,EAAE,mBAAmB,EAAE,MAAM,sBAAsB,CAAA;AAE1D,OAAO,EAAE,iBAAiB,EAAE,MAAM,mBAAmB,CAAA;AACrD,OAAO,EAAE,wBAAwB,EAAE,cAAc,EAAE,MAAM,kBAAkB,CAAA;AAE3E,MAAM,CAAC,MAAM,IAAI,GAAG,2BAA2B,CAAA;AAC/C,MAAM,CAAC,MAAM,MAAM,GAAG,CAAC,cAAc,CAAU,CAAA;AAE/C,MAAM,eAAe,GAAG,CAAC,UAAU,EAAE,SAAS,EAAE,SAAS,EAAE,WAAW,EAAE,SAAS,CAAU,CAAA;AAc3F,MAAM,CAAC,MAAM,WAAW,GAAmB,CAAC,CAAC,MAAM,CAAC;IAClD,aAAa,EAAE,CAAC,CAAC,MAAM,EAAE,CAAC,QAAQ,EAAE;IACpC,WAAW,EAAE,CAAC,CAAC,MAAM,EAAE,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC,QAAQ,EAAE;IACjD,eAAe,EAAE,CAAC,CAAC,MAAM,EAAE,CAAC,QAAQ,EAAE;IACtC,KAAK,EAAE,CAAC,CAAC,MAAM,EAAE,CAAC,QAAQ,EAAE;IAC5B,IAAI,EAAE,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,KAAK,CAAC,OAAO,CAAC,EAAE,CAAC,CAAC,KAAK,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,OAAO,CAAC;IACnE,MAAM,EAAE,CAAC,CAAC,OAAO,EAAE,CAAC,OAAO,CAAC,KAAK,CAAC;IAClC,aAAa,EAAE,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,KAAK,CAAC,UAAU,CAAC,EAAE,CAAC,CAAC,KAAK,CAAC,SAAS,CAAC,EAAE,CAAC,CAAC,KAAK,CAAC,SAAS,CAAC,EAAE,CAAC,CAAC,KAAK,CAAC,WAAW,CAAC,EAAE,CAAC,CAAC,KAAK,CAAC,SAAS,CAAC,CAAC,CAAC;IAC/H,cAAc,EAAE,CAAC,CAAC,OAAO,EAAE,CAAC,OAAO,CAAC,KAAK,CAAC;CAC3C,CAAC,CAAA;AAEF;;;;;GAKG;AACH,MAAM,UAAU,gBAAgB,CAAC,GAAuC;IACtE,IAAI,GAAG,CAAC,WAAW,KAAK,SAAS;QAAE,MAAM,IAAI,KAAK,CAAC,qBAAqB,CAAC,CAAA;IACzE,IAAI,GAAG,CAAC,oBAAoB,KAAK,SAAS;QAAE,MAAM,IAAI,KAAK,CAAC,8BAA8B,CAAC,CAAA;IAC3F,IAAI,GAAG,CAAC,cAAc,KAAK,SAAS,IAAI,CAAE,eAAqC,CAAC,QAAQ,CAAC,GAAG,CAAC,cAAc,CAAC,EAAE,CAAC;QAC7G,MAAM,IAAI,KAAK,CAAC,+BAA+B,GAAG,CAAC,cAAc,iBAAiB,eAAe,CAAC,IAAI,CAAC,IAAI,CAAC,GAAG,CAAC,CAAA;IAClH,CAAC;IACD,OAAO,WAAW,CAAC;QACjB,aAAa,EAAE,WAAW,GAAG,CAAC,WAAW,EAAE;QAC3C,WAAW,EAAE,GAAG,CAAC,oBAAoB;QACrC,eAAe,EAAE,MAAM,CAAC,GAAG,CAAC,iBAAiB,CAAC;QAC9C,KAAK,EAAE,MAAM,CAAC,GAAG,CAAC,MAAM,CAAC;QACzB,IAAI,EAAE,GAAG,CAAC,WAAW,KAAK,MAAM,CAAC,CAAC,CAAC,MAAM,CAAC,CAAC,CAAC,OAAO;QACnD,MAAM,EAAE,GAAG,CAAC,cAAc,KAAK,GAAG;QAClC,aAAa,EAAE,GAAG,CAAC,cAAgD;QACnE,cAAc,EAAE,GAAG,CAAC,cAAc,KAAK,GAAG;KAC3C,CAAC,CAAA;AACJ,CAAC;AAED,0GAA0G;AAC1G,MAAM,CAAC,KAAK,UAAU,mBAAmB,CAAC,MAAmB,EAAE,UAAwB,KAAK;IAC1F,OAAO,CAAC,MAAM,aAAa,CAAC,MAAM,EAAE,OAAO,CAAC,CAAC,CAAC,YAAY,CAAA;AAC5D,CAAC;AAED,mIAAmI;AACnI,MAAM,CAAC,KAAK,UAAU,aAAa,CAAC,MAAmB,EAAE,UAAwB,KAAK;IACpF,MAAM,GAAG,GAAG,GAAG,MAAM,CAAC,aAAa,oBAAoB,MAAM,CAAC,eAAe,mBAAmB,MAAM,CAAC,KAAK,EAAE,CAAA;IAC9G,MAAM,GAAG,GAAG,MAAM,OAAO,CAAC,GAAG,EAAE,EAAE,OAAO,EAAE,iBAAiB,CAAC,MAAM,CAAC,WAAW,CAAC,EAAE,CAAC,CAAA;IAClF,IAAI,CAAC,GAAG,CAAC,EAAE;QAAE,MAAM,IAAI,KAAK,CAAC,oBAAoB,GAAG,CAAC,MAAM,KAAK,MAAM,GAAG,CAAC,IAAI,EAAE,EAAE,CAAC,CAAA;IACnF,MAAM,IAAI,GAAG,MAAM,GAAG,CAAC,IAAI,EAA8E,CAAA;IACzG,IAAI,OAAO,IAAI,CAAC,aAAa,KAAK,QAAQ;QAAE,MAAM,IAAI,KAAK,CAAC,wDAAwD,CAAC,CAAA;IACrH,IAAI,OAAO,IAAI,CAAC,GAAG,KAAK,QAAQ;QAAE,MAAM,IAAI,KAAK,CAAC,8CAA8C,CAAC,CAAA;IACjG,+EAA+E;IAC/E,qFAAqF;IACrF,MAAM,IAAI,GAAG,IAAI,CAAC,UAAU,EAAE,IAAI,CAAA;IAClC,MAAM,WAAW,GAAG,OAAO,IAAI,KAAK,QAAQ,IAAI,IAAI,CAAC,QAAQ,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,EAAE,IAAI,CAAC,OAAO,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,CAAC,WAAW,MAAM,CAAC,eAAe,EAAE,CAAA;IAC3I,OAAO,EAAE,YAAY,EAAE,IAAI,CAAC,aAAa,EAAE,OAAO,EAAE,IAAI,CAAC,GAAG,EAAE,WAAW,EAAE,CAAA;AAC7E,CAAC;AAED,MAAM,CAAC,KAAK,UAAU,YAAY,CAChC,GAAY,EACZ,MAAmB,EACnB,OAII,EAAE;IAEN,MAAM,EAAE,YAAY,EAAE,OAAO,EAAE,WAAW,EAAE,GAAG,MAAM,aAAa,CAAC,MAAM,EAAE,IAAI,CAAC,OAAO,CAAC,CAAA;IACxF,mFAAmF;IACnF,iFAAiF;IACjF,qFAAqF;IACrF,kFAAkF;IAClF,MAAM,OAAO,GAAG,IAAI,CAAC,OAAO,IAAI,EAAE,mBAAmB,EAAE,CAAA;IACvD,MAAM,KAAK,GAAG,MAAM,OAAO,CAAC,mBAAmB,CAAC,MAAM,CAAC,eAAe,EAAE,MAAM,CAAC,KAAK,CAAC,CAAA;IACrF,IAAI,MAAoB,CAAA;IACxB,IAAI,KAAK,EAAE,OAAO,KAAK,OAAO,EAAE,CAAC;QAC/B,MAAM,GAAG,EAAE,EAAE,EAAE,IAAI,EAAE,OAAO,EAAE,uBAAuB,OAAO,YAAY,EAAE,QAAQ,EAAE,EAAE,EAAE,UAAU,EAAE,CAAC,EAAE,CAAA;IACzG,CAAC;SAAM,IAAI,KAAK,KAAK,SAAS,IAAI,CAAC,MAAM,CAAC,cAAc,EAAE,CAAC;QACzD,MAAM,GAAG,EAAE,EAAE,EAAE,IAAI,EAAE,OAAO,EAAE,qBAAqB,KAAK,CAAC,OAAO,0CAA0C,EAAE,QAAQ,EAAE,EAAE,EAAE,UAAU,EAAE,CAAC,EAAE,CAAA;IAC3I,CAAC;SAAM,CAAC;QACN,2EAA2E;QAC3E,0EAA0E;QAC1E,wEAAwE;QACxE,MAAM,SAAS,GAAG,IAAI,CAAC,OAAO,IAAI,KAAK,CAAA;QACvC,IAAI,MAAM,wBAAwB,CAAC,SAAS,EAAE,MAAM,CAAC,aAAa,EAAE,MAAM,CAAC,WAAW,EAAE,MAAM,CAAC,eAAe,EAAE,MAAM,CAAC,KAAK,EAAE,OAAO,CAAC,EAAE,CAAC;YACvI,MAAM,GAAG,EAAE,EAAE,EAAE,IAAI,EAAE,OAAO,EAAE,4BAA4B,OAAO,aAAa,EAAE,QAAQ,EAAE,EAAE,EAAE,UAAU,EAAE,CAAC,EAAE,CAAA;QAC/G,CAAC;aAAM,IAAI,MAAM,cAAc,CAAC,SAAS,EAAE,MAAM,CAAC,aAAa,EAAE,MAAM,CAAC,WAAW,EAAE,MAAM,CAAC,eAAe,EAAE,MAAM,CAAC,KAAK,CAAC,EAAE,CAAC;YAC3H,MAAM,GAAG,EAAE,EAAE,EAAE,IAAI,EAAE,OAAO,EAAE,sCAAsC,EAAE,QAAQ,EAAE,EAAE,EAAE,UAAU,EAAE,CAAC,EAAE,CAAA;QACrG,CAAC;aAAM,CAAC;YACR,qEAAqE;YACrE,wEAAwE;YACxE,sEAAsE;YACtE,uEAAuE;YACvE,MAAM,OAAO,GAAkB;gBAC7B,WAAW;gBACX,SAAS,EAAE,MAAM,CAAC,eAAe;gBACjC,KAAK,EAAE,MAAM,CAAC,KAAK;gBACnB,YAAY;gBACZ,OAAO;gBACP,OAAO,EAAE,SAAS;gBAClB,IAAI,EAAE,MAAM,CAAC,IAAI;gBACjB,KAAK,EAAE,EAAE,IAAI,EAAE,IAAI,EAAE;gBACrB,aAAa,EAAE,MAAM,CAAC,aAAa;aACpC,CAAA;YACD,MAAM,GAAG,MAAM,GAAG,CAAC,YAAY,CAAC,OAAO,CAAC,CAAA;QACxC,CAAC;IACH,CAAC;IACD,MAAM,EAAE,SAAS,EAAE,GAAG,IAAI,CAAC,SAAS,KAAK,SAAS,CAAC,CAAC,CAAC,EAAE,SAAS,EAAE,IAAI,CAAC,SAAS,EAAE,CAAC,CAAC,CAAC,MAAM,MAAM,CAAC,kBAAkB,CAAC,CAAA;IACrH,iFAAiF;IACjF,6EAA6E;IAC7E,oFAAoF;IACpF,sEAAsE;IACtE,MAAM,SAAS,GAAG,OAAO,CAAC,GAAG,CAAC,iBAAiB,EAAE,IAAI,EAAE,IAAI,GAAG,CAAA;IAC9D,MAAM,MAAM,GAAG,EAAE,GAAG,MAAM,EAAE,SAAS,EAAE,MAAM,CAAC,eAAe,EAAE,KAAK,EAAE,MAAM,CAAC,KAAK,EAAE,IAAI,EAAE,MAAM,CAAC,IAAI,EAAE,WAAW,EAAE,IAAI,IAAI,EAAE,CAAC,WAAW,EAAE,EAAE,CAAA;IAC9I,MAAM,SAAS,CAAC,IAAI,CAAC,SAAS,EAAE,oBAAoB,CAAC,EAAE,IAAI,CAAC,SAAS,CAAC,MAAM,EAAE,IAAI,EAAE,CAAC,CAAC,EAAE,OAAO,CAAC,CAAA;IAChG,MAAM,EAAE,GAAG,mCAAmC,MAAM,CAAC,eAAe,KAAK,MAAM,CAAC,KAAK,eAAe,MAAM,CAAC,IAAI,mBAAmB,MAAM,CAAC,UAAU,SAAS,MAAM,CAAC,OAAO,IAAI,cAAc,KAAK,MAAM,CAAC,QAAQ,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC,CAAC,gBAAgB,MAAM,CAAC,QAAQ,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,CAAC,KAAK,CAAC,EAAE,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAA;IACtS,MAAM,SAAS,CAAC,IAAI,CAAC,SAAS,EAAE,kBAAkB,CAAC,EAAE,EAAE,EAAE,OAAO,CAAC,CAAA;IACjE,OAAO,MAAM,CAAA;AACf,CAAC;AAED,MAAM,UAAU,KAAK,CAAC,GAAY;IAChC,GAAG,CAAC,MAAM,CAAC,GAAG,EAAE;QACd,KAAK,CAAC,KAAK,IAAI,EAAE;YACf,IAAI,CAAC;gBACH,MAAM,MAAM,GAAG,gBAAgB,CAAC,OAAO,CAAC,GAAG,CAAC,CAAA;gBAC5C,OAAO,CAAC,GAAG,CAAC,yCAAyC,MAAM,CAAC,eAAe,KAAK,MAAM,CAAC,KAAK,SAAS,MAAM,CAAC,IAAI,WAAW,MAAM,CAAC,MAAM,EAAE,CAAC,CAAA;gBAC3I,MAAM,MAAM,GAAG,MAAM,CAAC,MAAM;oBAC1B,CAAC,CAAC,EAAE,EAAE,EAAE,IAAI,EAAE,OAAO,EAAE,yCAAyC,EAAE,QAAQ,EAAE,EAAE,EAAE,UAAU,EAAE,CAAC,EAAE;oBAC/F,CAAC,CAAC,MAAM,YAAY,CAAC,GAAG,EAAE,MAAM,CAAC,CAAA;gBACnC,OAAO,CAAC,GAAG,CAAC,oCAAoC,MAAM,CAAC,EAAE,YAAY,IAAI,CAAC,SAAS,CAAC,MAAM,CAAC,OAAO,CAAC,aAAa,MAAM,CAAC,QAAQ,CAAC,MAAM,EAAE,CAAC,CAAA;gBACzI,KAAK,MAAM,OAAO,IAAI,MAAM,CAAC,QAAQ;oBAAE,OAAO,CAAC,KAAK,CAAC,gCAAgC,OAAO,EAAE,CAAC,CAAA;gBAC/F,MAAM,IAAI,GAAG,GAAG,CAAC,GAAG,CAAC,SAAS,CAAC,CAAA;gBAC/B,IAAI,IAAI,KAAK,SAAS,EAAE,CAAC;oBACvB,OAAO,CAAC,KAAK,CAAC,wHAAwH,CAAC,CAAA;gBACzI,CAAC;qBAAM,CAAC;oBACN,IAAI,CAAC,MAAM,CAAC,EAAE,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAA;gBACzB,CAAC;YACH,CAAC;YAAC,OAAO,GAAG,EAAE,CAAC;gBACb,OAAO,CAAC,KAAK,CAAC,4BAA4B,EAAE,GAAG,YAAY,KAAK,CAAC,CAAC,CAAC,GAAG,CAAC,OAAO,CAAC,CAAC,CAAC,MAAM,CAAC,GAAG,CAAC,CAAC,CAAA;gBAC7F,GAAG,CAAC,GAAG,CAAC,SAAS,CAAC,EAAE,CAAC,CAAC,CAAC,CAAA;YACzB,CAAC;QACH,CAAC,CAAC,EAAE,CAAA;QACJ,OAAO,GAAG,EAAE,GAAE,CAAC,CAAA;IACjB,CAAC,EAAE,+BAA+B,CAAC,CAAA;AACrC,CAAC"}
|
|
@@ -1,20 +0,0 @@
|
|
|
1
|
-
import type { Context } from '@deepseek-ai/cordis';
|
|
2
|
-
export declare const name = "maestro-review-findings-tool";
|
|
3
|
-
export declare const inject: string[];
|
|
4
|
-
export type FindingSeverity = 'blocking' | 'major' | 'minor' | 'nit';
|
|
5
|
-
export interface ReviewFinding {
|
|
6
|
-
status: 'new' | 'reply';
|
|
7
|
-
body: string;
|
|
8
|
-
path?: string;
|
|
9
|
-
line?: number;
|
|
10
|
-
discussionId?: string;
|
|
11
|
-
/** Assigned by the reviewer; missing values are treated as `minor`. */
|
|
12
|
-
severity?: FindingSeverity;
|
|
13
|
-
/** Optional area tag, e.g. security, correctness, perf, style. */
|
|
14
|
-
category?: string;
|
|
15
|
-
}
|
|
16
|
-
export interface Config {
|
|
17
|
-
onReport: (findings: ReviewFinding[]) => void;
|
|
18
|
-
}
|
|
19
|
-
export declare function apply(ctx: Context, config: Config): void;
|
|
20
|
-
//# sourceMappingURL=review-findings-tool.d.ts.map
|
|
@@ -1 +0,0 @@
|
|
|
1
|
-
{"version":3,"file":"review-findings-tool.d.ts","sourceRoot":"","sources":["../src/host/review-findings-tool.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,OAAO,EAAE,MAAM,qBAAqB,CAAA;AAGlD,eAAO,MAAM,IAAI,iCAAiC,CAAA;AAClD,eAAO,MAAM,MAAM,UAAY,CAAA;AAE/B,MAAM,MAAM,eAAe,GAAG,UAAU,GAAG,OAAO,GAAG,OAAO,GAAG,KAAK,CAAA;AAEpE,MAAM,WAAW,aAAa;IAC5B,MAAM,EAAE,KAAK,GAAG,OAAO,CAAA;IACvB,IAAI,EAAE,MAAM,CAAA;IACZ,IAAI,CAAC,EAAE,MAAM,CAAA;IACb,IAAI,CAAC,EAAE,MAAM,CAAA;IACb,YAAY,CAAC,EAAE,MAAM,CAAA;IACrB,uEAAuE;IACvE,QAAQ,CAAC,EAAE,eAAe,CAAA;IAC1B,kEAAkE;IAClE,QAAQ,CAAC,EAAE,MAAM,CAAA;CAClB;AAED,MAAM,WAAW,MAAM;IACrB,QAAQ,EAAE,CAAC,QAAQ,EAAE,aAAa,EAAE,KAAK,IAAI,CAAA;CAC9C;AAED,wBAAgB,KAAK,CAAC,GAAG,EAAE,OAAO,EAAE,MAAM,EAAE,MAAM,GAAG,IAAI,CAkCxD"}
|
|
@@ -1,39 +0,0 @@
|
|
|
1
|
-
import { defineTool } from '@deepseek-ai/dsh-tools';
|
|
2
|
-
export const name = 'maestro-review-findings-tool';
|
|
3
|
-
export const inject = ['tools'];
|
|
4
|
-
export function apply(ctx, config) {
|
|
5
|
-
ctx.tools.register(defineTool({
|
|
6
|
-
name: 'report_review_findings',
|
|
7
|
-
description: 'Submit your complete list of review findings exactly once, when done analyzing. Each finding is {status: "new", path, line, body, severity, category?} for a location with no existing thread, or {status: "reply", discussionId, body, severity, category?} to update an existing thread returned by gitlab_list_own_review_threads (reply to a resolved thread reopens it — prefer reply over new when the substance matches). Severity (required in spirit, defaults to minor): blocking = must fix before merge (regression, data loss, real XSS/RCE); major = should fix (correctness bug, security hardening with a realistic path); minor = nice to fix (perf nit with impact, stale docs, fragile coupling); nit = style/micro with no behavior impact.',
|
|
8
|
-
parameters: {
|
|
9
|
-
findings: {
|
|
10
|
-
type: 'array',
|
|
11
|
-
required: true,
|
|
12
|
-
description: 'The complete list of findings for this review.',
|
|
13
|
-
items: {
|
|
14
|
-
type: 'object',
|
|
15
|
-
additionalProperties: false,
|
|
16
|
-
properties: {
|
|
17
|
-
status: { type: 'string', enum: ['new', 'reply'], required: true },
|
|
18
|
-
body: { type: 'string', required: true },
|
|
19
|
-
path: { type: 'string' },
|
|
20
|
-
line: { type: 'number' },
|
|
21
|
-
discussionId: { type: 'string' },
|
|
22
|
-
severity: { type: 'string', enum: ['blocking', 'major', 'minor', 'nit'] },
|
|
23
|
-
category: { type: 'string' },
|
|
24
|
-
},
|
|
25
|
-
},
|
|
26
|
-
},
|
|
27
|
-
},
|
|
28
|
-
output: {
|
|
29
|
-
schema: { type: 'object', additionalProperties: false, properties: { received: { type: 'number', required: true } } },
|
|
30
|
-
render: (_args, value) => [{ type: 'text', text: `Recorded ${value.received} finding(s).` }],
|
|
31
|
-
},
|
|
32
|
-
async execute(args) {
|
|
33
|
-
const findings = args.findings;
|
|
34
|
-
config.onReport(findings);
|
|
35
|
-
return { received: findings.length };
|
|
36
|
-
},
|
|
37
|
-
}));
|
|
38
|
-
}
|
|
39
|
-
//# sourceMappingURL=review-findings-tool.js.map
|
|
@@ -1 +0,0 @@
|
|
|
1
|
-
{"version":3,"file":"review-findings-tool.js","sourceRoot":"","sources":["../src/host/review-findings-tool.ts"],"names":[],"mappings":"AACA,OAAO,EAAE,UAAU,EAAE,MAAM,wBAAwB,CAAA;AAEnD,MAAM,CAAC,MAAM,IAAI,GAAG,8BAA8B,CAAA;AAClD,MAAM,CAAC,MAAM,MAAM,GAAG,CAAC,OAAO,CAAC,CAAA;AAoB/B,MAAM,UAAU,KAAK,CAAC,GAAY,EAAE,MAAc;IAChD,GAAG,CAAC,KAAK,CAAC,QAAQ,CAAC,UAAU,CAAC;QAC5B,IAAI,EAAE,wBAAwB;QAC9B,WAAW,EAAE,iuBAAiuB;QAC9uB,UAAU,EAAE;YACV,QAAQ,EAAE;gBACR,IAAI,EAAE,OAAO;gBACb,QAAQ,EAAE,IAAI;gBACd,WAAW,EAAE,gDAAgD;gBAC7D,KAAK,EAAE;oBACL,IAAI,EAAE,QAAQ;oBACd,oBAAoB,EAAE,KAAK;oBAC3B,UAAU,EAAE;wBACV,MAAM,EAAE,EAAE,IAAI,EAAE,QAAQ,EAAE,IAAI,EAAE,CAAC,KAAK,EAAE,OAAO,CAAC,EAAE,QAAQ,EAAE,IAAI,EAAE;wBAClE,IAAI,EAAE,EAAE,IAAI,EAAE,QAAQ,EAAE,QAAQ,EAAE,IAAI,EAAE;wBACxC,IAAI,EAAE,EAAE,IAAI,EAAE,QAAQ,EAAE;wBACxB,IAAI,EAAE,EAAE,IAAI,EAAE,QAAQ,EAAE;wBACxB,YAAY,EAAE,EAAE,IAAI,EAAE,QAAQ,EAAE;wBAChC,QAAQ,EAAE,EAAE,IAAI,EAAE,QAAQ,EAAE,IAAI,EAAE,CAAC,UAAU,EAAE,OAAO,EAAE,OAAO,EAAE,KAAK,CAAC,EAAE;wBACzE,QAAQ,EAAE,EAAE,IAAI,EAAE,QAAQ,EAAE;qBAC7B;iBACF;aACF;SACF;QACD,MAAM,EAAE;YACN,MAAM,EAAE,EAAE,IAAI,EAAE,QAAQ,EAAE,oBAAoB,EAAE,KAAK,EAAE,UAAU,EAAE,EAAE,QAAQ,EAAE,EAAE,IAAI,EAAE,QAAQ,EAAE,QAAQ,EAAE,IAAI,EAAE,EAAE,EAAE;YACrH,MAAM,EAAE,CAAC,KAAK,EAAE,KAAK,EAAE,EAAE,CAAC,CAAC,EAAE,IAAI,EAAE,MAAM,EAAE,IAAI,EAAE,YAAY,KAAK,CAAC,QAAQ,cAAc,EAAE,CAAC;SAC7F;QACD,KAAK,CAAC,OAAO,CAAC,IAAI;YAChB,MAAM,QAAQ,GAAG,IAAI,CAAC,QAA2B,CAAA;YACjD,MAAM,CAAC,QAAQ,CAAC,QAAQ,CAAC,CAAA;YACzB,OAAO,EAAE,QAAQ,EAAE,QAAQ,CAAC,MAAM,EAAE,CAAA;QACtC,CAAC;KACF,CAAC,CAAC,CAAA;AACL,CAAC"}
|
package/lib/review-history.d.ts
DELETED
|
@@ -1,40 +0,0 @@
|
|
|
1
|
-
import type { ReviewMode, ReviewRequest } from './events.js';
|
|
2
|
-
export interface ReviewHistoryEntry {
|
|
3
|
-
id: string;
|
|
4
|
-
projectId: number;
|
|
5
|
-
projectPath: string;
|
|
6
|
-
mrIid: number;
|
|
7
|
-
mode: ReviewMode;
|
|
8
|
-
scope: 'mr' | 'discussion';
|
|
9
|
-
trigger: ReviewRequest['trigger'];
|
|
10
|
-
status: 'running' | 'completed' | 'failed';
|
|
11
|
-
startedAt: number;
|
|
12
|
-
finishedAt?: number;
|
|
13
|
-
summary?: string;
|
|
14
|
-
error?: string;
|
|
15
|
-
/** MR head_sha at review start — baseline for incremental re-reviews (H6). */
|
|
16
|
-
headSha?: string;
|
|
17
|
-
}
|
|
18
|
-
export declare function historyPath(dshHome?: string): string;
|
|
19
|
-
/** Prepend a running entry; the oldest entries fall off past `HISTORY_CAP`. */
|
|
20
|
-
export declare function recordReviewStart(entry: Omit<ReviewHistoryEntry, 'status'>, dshHome?: string): Promise<void>;
|
|
21
|
-
/** Attach an outcome to the entry with this id; unknown ids are ignored. */
|
|
22
|
-
export declare function recordReviewFinish(id: string, patch: {
|
|
23
|
-
status: 'completed' | 'failed';
|
|
24
|
-
summary?: string;
|
|
25
|
-
error?: string;
|
|
26
|
-
}, dshHome?: string): Promise<void>;
|
|
27
|
-
/** Newest-first slice of the log. */
|
|
28
|
-
export declare function listReviews(limit?: number, dshHome?: string): Promise<ReviewHistoryEntry[]>;
|
|
29
|
-
/** Whether any review of this MR ever completed — gates push re-reviews. */
|
|
30
|
-
export declare function hasCompletedReview(projectId: number, mrIid: number, dshHome?: string): Promise<boolean>;
|
|
31
|
-
/** Newest completed entry for this MR — carries headSha for H6 incrementality. */
|
|
32
|
-
export declare function lastCompletedReview(projectId: number, mrIid: number, dshHome?: string): Promise<ReviewHistoryEntry | undefined>;
|
|
33
|
-
/**
|
|
34
|
-
* Drop history entries and failed-report files older than `retentionDays`.
|
|
35
|
-
* `0` disables pruning entirely. Maestro records only — DSH session
|
|
36
|
-
* transcripts are never touched. Entries still `running` are always kept:
|
|
37
|
-
* a prune must never delete a review that just started (see D3).
|
|
38
|
-
*/
|
|
39
|
-
export declare function pruneHistory(retentionDays: number, dshHome?: string): Promise<void>;
|
|
40
|
-
//# sourceMappingURL=review-history.d.ts.map
|
|
@@ -1 +0,0 @@
|
|
|
1
|
-
{"version":3,"file":"review-history.d.ts","sourceRoot":"","sources":["../src/host/review-history.ts"],"names":[],"mappings":"AAGA,OAAO,KAAK,EAAE,UAAU,EAAE,aAAa,EAAE,MAAM,aAAa,CAAA;AAE5D,MAAM,WAAW,kBAAkB;IACjC,EAAE,EAAE,MAAM,CAAA;IACV,SAAS,EAAE,MAAM,CAAA;IACjB,WAAW,EAAE,MAAM,CAAA;IACnB,KAAK,EAAE,MAAM,CAAA;IACb,IAAI,EAAE,UAAU,CAAA;IAChB,KAAK,EAAE,IAAI,GAAG,YAAY,CAAA;IAC1B,OAAO,EAAE,aAAa,CAAC,SAAS,CAAC,CAAA;IACjC,MAAM,EAAE,SAAS,GAAG,WAAW,GAAG,QAAQ,CAAA;IAC1C,SAAS,EAAE,MAAM,CAAA;IACjB,UAAU,CAAC,EAAE,MAAM,CAAA;IACnB,OAAO,CAAC,EAAE,MAAM,CAAA;IAChB,KAAK,CAAC,EAAE,MAAM,CAAA;IACd,8EAA8E;IAC9E,OAAO,CAAC,EAAE,MAAM,CAAA;CACjB;AAKD,wBAAgB,WAAW,CAAC,OAAO,CAAC,EAAE,MAAM,GAAG,MAAM,CAGpD;AAoCD,+EAA+E;AAC/E,wBAAsB,iBAAiB,CAAC,KAAK,EAAE,IAAI,CAAC,kBAAkB,EAAE,QAAQ,CAAC,EAAE,OAAO,CAAC,EAAE,MAAM,GAAG,OAAO,CAAC,IAAI,CAAC,CAOlH;AAED,4EAA4E;AAC5E,wBAAsB,kBAAkB,CACtC,EAAE,EAAE,MAAM,EACV,KAAK,EAAE;IAAE,MAAM,EAAE,WAAW,GAAG,QAAQ,CAAC;IAAC,OAAO,CAAC,EAAE,MAAM,CAAC;IAAC,KAAK,CAAC,EAAE,MAAM,CAAA;CAAE,EAC3E,OAAO,CAAC,EAAE,MAAM,GACf,OAAO,CAAC,IAAI,CAAC,CAQf;AAED,qCAAqC;AACrC,wBAAsB,WAAW,CAAC,KAAK,SAAK,EAAE,OAAO,CAAC,EAAE,MAAM,GAAG,OAAO,CAAC,kBAAkB,EAAE,CAAC,CAE7F;AAED,4EAA4E;AAC5E,wBAAsB,kBAAkB,CAAC,SAAS,EAAE,MAAM,EAAE,KAAK,EAAE,MAAM,EAAE,OAAO,CAAC,EAAE,MAAM,GAAG,OAAO,CAAC,OAAO,CAAC,CAG7G;AAED,kFAAkF;AAClF,wBAAsB,mBAAmB,CAAC,SAAS,EAAE,MAAM,EAAE,KAAK,EAAE,MAAM,EAAE,OAAO,CAAC,EAAE,MAAM,GAAG,OAAO,CAAC,kBAAkB,GAAG,SAAS,CAAC,CAGrI;AAED;;;;;GAKG;AACH,wBAAsB,YAAY,CAAC,aAAa,EAAE,MAAM,EAAE,OAAO,CAAC,EAAE,MAAM,GAAG,OAAO,CAAC,IAAI,CAAC,CAmCzF"}
|
package/lib/review-history.js
DELETED
|
@@ -1,136 +0,0 @@
|
|
|
1
|
-
import { chmod, mkdir, readFile, readdir, rm, writeFile } from 'node:fs/promises';
|
|
2
|
-
import { homedir } from 'node:os';
|
|
3
|
-
import { dirname, join } from 'node:path';
|
|
4
|
-
const HISTORY_CAP = 100;
|
|
5
|
-
const STALE_RUNNING_MS = 2 * 60 * 60_000; // 2h — host restart can leave running without finish
|
|
6
|
-
export function historyPath(dshHome) {
|
|
7
|
-
const home = dshHome ?? process.env.DSH_HOME ?? join(homedir(), '.dsh');
|
|
8
|
-
return join(home, 'dsh-maestro-review', 'reviews.json');
|
|
9
|
-
}
|
|
10
|
-
async function readAll(dshHome) {
|
|
11
|
-
try {
|
|
12
|
-
const parsed = JSON.parse(await readFile(historyPath(dshHome), 'utf-8'));
|
|
13
|
-
if (!Array.isArray(parsed))
|
|
14
|
-
return [];
|
|
15
|
-
return parsed.filter((entry) => typeof entry === 'object' && entry !== null && typeof entry.id === 'string');
|
|
16
|
-
}
|
|
17
|
-
catch {
|
|
18
|
-
// Missing or corrupt store: start from an empty log rather than failing reviews.
|
|
19
|
-
return [];
|
|
20
|
-
}
|
|
21
|
-
}
|
|
22
|
-
async function writeAll(entries, dshHome) {
|
|
23
|
-
const path = historyPath(dshHome);
|
|
24
|
-
await mkdir(dirname(path), { recursive: true, mode: 0o700 });
|
|
25
|
-
await writeFile(path, JSON.stringify(entries, null, 2), { encoding: 'utf-8', mode: 0o600 });
|
|
26
|
-
await chmod(path, 0o600);
|
|
27
|
-
}
|
|
28
|
-
function failStaleRunning(entries) {
|
|
29
|
-
let mutated = false;
|
|
30
|
-
const now = Date.now();
|
|
31
|
-
for (const e of entries) {
|
|
32
|
-
if (e.status === 'running' && now - e.startedAt > STALE_RUNNING_MS) {
|
|
33
|
-
e.status = 'failed';
|
|
34
|
-
e.error = e.error ?? 'auto-failed: stale running review (host restart or crash)';
|
|
35
|
-
e.finishedAt = e.finishedAt ?? now;
|
|
36
|
-
mutated = true;
|
|
37
|
-
}
|
|
38
|
-
}
|
|
39
|
-
return mutated;
|
|
40
|
-
}
|
|
41
|
-
/** Prepend a running entry; the oldest entries fall off past `HISTORY_CAP`. */
|
|
42
|
-
export async function recordReviewStart(entry, dshHome) {
|
|
43
|
-
return withHistoryLock(async () => {
|
|
44
|
-
const all = await readAll(dshHome);
|
|
45
|
-
if (failStaleRunning(all))
|
|
46
|
-
await writeAll(all, dshHome);
|
|
47
|
-
all.unshift({ ...entry, status: 'running' });
|
|
48
|
-
await writeAll(all.slice(0, HISTORY_CAP), dshHome);
|
|
49
|
-
});
|
|
50
|
-
}
|
|
51
|
-
/** Attach an outcome to the entry with this id; unknown ids are ignored. */
|
|
52
|
-
export async function recordReviewFinish(id, patch, dshHome) {
|
|
53
|
-
return withHistoryLock(async () => {
|
|
54
|
-
const all = await readAll(dshHome);
|
|
55
|
-
const entry = all.find((candidate) => candidate.id === id);
|
|
56
|
-
if (entry === undefined)
|
|
57
|
-
return;
|
|
58
|
-
Object.assign(entry, patch, { finishedAt: Date.now() });
|
|
59
|
-
await writeAll(all, dshHome);
|
|
60
|
-
});
|
|
61
|
-
}
|
|
62
|
-
/** Newest-first slice of the log. */
|
|
63
|
-
export async function listReviews(limit = 20, dshHome) {
|
|
64
|
-
return (await readAll(dshHome)).slice(0, limit);
|
|
65
|
-
}
|
|
66
|
-
/** Whether any review of this MR ever completed — gates push re-reviews. */
|
|
67
|
-
export async function hasCompletedReview(projectId, mrIid, dshHome) {
|
|
68
|
-
return (await readAll(dshHome)).some(entry => entry.projectId === projectId && entry.mrIid === mrIid && entry.status === 'completed');
|
|
69
|
-
}
|
|
70
|
-
/** Newest completed entry for this MR — carries headSha for H6 incrementality. */
|
|
71
|
-
export async function lastCompletedReview(projectId, mrIid, dshHome) {
|
|
72
|
-
return (await readAll(dshHome)).find(entry => entry.projectId === projectId && entry.mrIid === mrIid && entry.status === 'completed' && typeof entry.headSha === 'string');
|
|
73
|
-
}
|
|
74
|
-
/**
|
|
75
|
-
* Drop history entries and failed-report files older than `retentionDays`.
|
|
76
|
-
* `0` disables pruning entirely. Maestro records only — DSH session
|
|
77
|
-
* transcripts are never touched. Entries still `running` are always kept:
|
|
78
|
-
* a prune must never delete a review that just started (see D3).
|
|
79
|
-
*/
|
|
80
|
-
export async function pruneHistory(retentionDays, dshHome) {
|
|
81
|
-
if (!Number.isFinite(retentionDays) || retentionDays <= 0)
|
|
82
|
-
return;
|
|
83
|
-
return withHistoryLock(async () => {
|
|
84
|
-
const all = await readAll(dshHome);
|
|
85
|
-
failStaleRunning(all);
|
|
86
|
-
const cutoff = Date.now() - retentionDays * DAY_MS;
|
|
87
|
-
const kept = [];
|
|
88
|
-
for (const entry of all) {
|
|
89
|
-
if (entry.status === 'running') {
|
|
90
|
-
kept.push(entry);
|
|
91
|
-
continue;
|
|
92
|
-
}
|
|
93
|
-
if ((entry.finishedAt ?? entry.startedAt) < cutoff)
|
|
94
|
-
continue;
|
|
95
|
-
kept.push(entry);
|
|
96
|
-
}
|
|
97
|
-
await writeAll(kept, dshHome);
|
|
98
|
-
}).then(async () => {
|
|
99
|
-
const home = dshHome ?? process.env.DSH_HOME ?? join(homedir(), '.dsh');
|
|
100
|
-
const failedDir = join(home, 'maestro', 'failed-reports');
|
|
101
|
-
const cutoff = Date.now() - retentionDays * DAY_MS;
|
|
102
|
-
let names;
|
|
103
|
-
try {
|
|
104
|
-
names = await readdir(failedDir);
|
|
105
|
-
}
|
|
106
|
-
catch {
|
|
107
|
-
return;
|
|
108
|
-
}
|
|
109
|
-
await Promise.all(names.map(async (name) => {
|
|
110
|
-
// Failed reports are named `<mrIid>-<epoch-ms>.md`.
|
|
111
|
-
const match = /^-?\d+-(\d{13,})\.md$/.exec(name);
|
|
112
|
-
if (match === null)
|
|
113
|
-
return;
|
|
114
|
-
const stamp = Number(match[1]);
|
|
115
|
-
if (!Number.isFinite(stamp) || stamp >= cutoff)
|
|
116
|
-
return;
|
|
117
|
-
await rm(join(failedDir, name), { force: true }).catch(() => { });
|
|
118
|
-
}));
|
|
119
|
-
});
|
|
120
|
-
}
|
|
121
|
-
/**
|
|
122
|
-
* In-process promise-chain mutex serializing the read-modify-write cycles of
|
|
123
|
-
* `recordReviewStart` / `recordReviewFinish` / `pruneHistory`, so a
|
|
124
|
-
* fire-and-forget `void pruneHistory()` can no longer clobber an entry that
|
|
125
|
-
* started concurrently (last-writer-wins on a stale read). Two `dsh web`
|
|
126
|
-
* processes sharing one `DSH_HOME` is unsupported, so a cross-process file
|
|
127
|
-
* lock is deliberately out of scope.
|
|
128
|
-
*/
|
|
129
|
-
let historyMutex = Promise.resolve();
|
|
130
|
-
function withHistoryLock(work) {
|
|
131
|
-
const next = historyMutex.then(work, work);
|
|
132
|
-
historyMutex = next.then(() => undefined, () => undefined);
|
|
133
|
-
return next;
|
|
134
|
-
}
|
|
135
|
-
const DAY_MS = 24 * 60 * 60_000;
|
|
136
|
-
//# sourceMappingURL=review-history.js.map
|
|
@@ -1 +0,0 @@
|
|
|
1
|
-
{"version":3,"file":"review-history.js","sourceRoot":"","sources":["../src/host/review-history.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,KAAK,EAAE,KAAK,EAAE,QAAQ,EAAE,OAAO,EAAE,EAAE,EAAE,SAAS,EAAE,MAAM,kBAAkB,CAAA;AACjF,OAAO,EAAE,OAAO,EAAE,MAAM,SAAS,CAAA;AACjC,OAAO,EAAE,OAAO,EAAE,IAAI,EAAE,MAAM,WAAW,CAAA;AAoBzC,MAAM,WAAW,GAAG,GAAG,CAAA;AACvB,MAAM,gBAAgB,GAAG,CAAC,GAAG,EAAE,GAAG,MAAM,CAAA,CAAC,qDAAqD;AAE9F,MAAM,UAAU,WAAW,CAAC,OAAgB;IAC1C,MAAM,IAAI,GAAG,OAAO,IAAI,OAAO,CAAC,GAAG,CAAC,QAAQ,IAAI,IAAI,CAAC,OAAO,EAAE,EAAE,MAAM,CAAC,CAAA;IACvE,OAAO,IAAI,CAAC,IAAI,EAAE,oBAAoB,EAAE,cAAc,CAAC,CAAA;AACzD,CAAC;AAGD,KAAK,UAAU,OAAO,CAAC,OAAgB;IACrC,IAAI,CAAC;QACH,MAAM,MAAM,GAAY,IAAI,CAAC,KAAK,CAAC,MAAM,QAAQ,CAAC,WAAW,CAAC,OAAO,CAAC,EAAE,OAAO,CAAC,CAAC,CAAA;QACjF,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,MAAM,CAAC;YAAE,OAAO,EAAE,CAAA;QACrC,OAAO,MAAM,CAAC,MAAM,CAAC,CAAC,KAAK,EAA+B,EAAE,CAC1D,OAAO,KAAK,KAAK,QAAQ,IAAI,KAAK,KAAK,IAAI,IAAI,OAAQ,KAA4B,CAAC,EAAE,KAAK,QAAQ,CAAC,CAAA;IACxG,CAAC;IAAC,MAAM,CAAC;QACP,iFAAiF;QACjF,OAAO,EAAE,CAAA;IACX,CAAC;AACH,CAAC;AAED,KAAK,UAAU,QAAQ,CAAC,OAA6B,EAAE,OAAgB;IACrE,MAAM,IAAI,GAAG,WAAW,CAAC,OAAO,CAAC,CAAA;IACjC,MAAM,KAAK,CAAC,OAAO,CAAC,IAAI,CAAC,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,IAAI,EAAE,KAAK,EAAE,CAAC,CAAA;IAC5D,MAAM,SAAS,CAAC,IAAI,EAAE,IAAI,CAAC,SAAS,CAAC,OAAO,EAAE,IAAI,EAAE,CAAC,CAAC,EAAE,EAAE,QAAQ,EAAE,OAAO,EAAE,IAAI,EAAE,KAAK,EAAE,CAAC,CAAA;IAC3F,MAAM,KAAK,CAAC,IAAI,EAAE,KAAK,CAAC,CAAA;AAC1B,CAAC;AAED,SAAS,gBAAgB,CAAC,OAA6B;IACrD,IAAI,OAAO,GAAG,KAAK,CAAA;IACnB,MAAM,GAAG,GAAG,IAAI,CAAC,GAAG,EAAE,CAAA;IACtB,KAAK,MAAM,CAAC,IAAI,OAAO,EAAE,CAAC;QACxB,IAAI,CAAC,CAAC,MAAM,KAAK,SAAS,IAAI,GAAG,GAAG,CAAC,CAAC,SAAS,GAAG,gBAAgB,EAAE,CAAC;YACnE,CAAC,CAAC,MAAM,GAAG,QAAQ,CAAA;YACnB,CAAC,CAAC,KAAK,GAAG,CAAC,CAAC,KAAK,IAAI,2DAA2D,CAAA;YAChF,CAAC,CAAC,UAAU,GAAG,CAAC,CAAC,UAAU,IAAI,GAAG,CAAA;YAClC,OAAO,GAAG,IAAI,CAAA;QAChB,CAAC;IACH,CAAC;IACD,OAAO,OAAO,CAAA;AAChB,CAAC;AAED,+EAA+E;AAC/E,MAAM,CAAC,KAAK,UAAU,iBAAiB,CAAC,KAAyC,EAAE,OAAgB;IACjG,OAAO,eAAe,CAAC,KAAK,IAAI,EAAE;QAChC,MAAM,GAAG,GAAG,MAAM,OAAO,CAAC,OAAO,CAAC,CAAA;QAClC,IAAI,gBAAgB,CAAC,GAAG,CAAC;YAAE,MAAM,QAAQ,CAAC,GAAG,EAAE,OAAO,CAAC,CAAA;QACvD,GAAG,CAAC,OAAO,CAAC,EAAE,GAAG,KAAK,EAAE,MAAM,EAAE,SAAS,EAAE,CAAC,CAAA;QAC5C,MAAM,QAAQ,CAAC,GAAG,CAAC,KAAK,CAAC,CAAC,EAAE,WAAW,CAAC,EAAE,OAAO,CAAC,CAAA;IACpD,CAAC,CAAC,CAAA;AACJ,CAAC;AAED,4EAA4E;AAC5E,MAAM,CAAC,KAAK,UAAU,kBAAkB,CACtC,EAAU,EACV,KAA2E,EAC3E,OAAgB;IAEhB,OAAO,eAAe,CAAC,KAAK,IAAI,EAAE;QAChC,MAAM,GAAG,GAAG,MAAM,OAAO,CAAC,OAAO,CAAC,CAAA;QAClC,MAAM,KAAK,GAAG,GAAG,CAAC,IAAI,CAAC,CAAC,SAAS,EAAE,EAAE,CAAC,SAAS,CAAC,EAAE,KAAK,EAAE,CAAC,CAAA;QAC1D,IAAI,KAAK,KAAK,SAAS;YAAE,OAAM;QAC/B,MAAM,CAAC,MAAM,CAAC,KAAK,EAAE,KAAK,EAAE,EAAE,UAAU,EAAE,IAAI,CAAC,GAAG,EAAE,EAAE,CAAC,CAAA;QACvD,MAAM,QAAQ,CAAC,GAAG,EAAE,OAAO,CAAC,CAAA;IAC9B,CAAC,CAAC,CAAA;AACJ,CAAC;AAED,qCAAqC;AACrC,MAAM,CAAC,KAAK,UAAU,WAAW,CAAC,KAAK,GAAG,EAAE,EAAE,OAAgB;IAC5D,OAAO,CAAC,MAAM,OAAO,CAAC,OAAO,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC,EAAE,KAAK,CAAC,CAAA;AACjD,CAAC;AAED,4EAA4E;AAC5E,MAAM,CAAC,KAAK,UAAU,kBAAkB,CAAC,SAAiB,EAAE,KAAa,EAAE,OAAgB;IACzF,OAAO,CAAC,MAAM,OAAO,CAAC,OAAO,CAAC,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,EAAE,CAC3C,KAAK,CAAC,SAAS,KAAK,SAAS,IAAI,KAAK,CAAC,KAAK,KAAK,KAAK,IAAI,KAAK,CAAC,MAAM,KAAK,WAAW,CAAC,CAAA;AAC3F,CAAC;AAED,kFAAkF;AAClF,MAAM,CAAC,KAAK,UAAU,mBAAmB,CAAC,SAAiB,EAAE,KAAa,EAAE,OAAgB;IAC1F,OAAO,CAAC,MAAM,OAAO,CAAC,OAAO,CAAC,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,EAAE,CAC3C,KAAK,CAAC,SAAS,KAAK,SAAS,IAAI,KAAK,CAAC,KAAK,KAAK,KAAK,IAAI,KAAK,CAAC,MAAM,KAAK,WAAW,IAAI,OAAO,KAAK,CAAC,OAAO,KAAK,QAAQ,CAAC,CAAA;AAChI,CAAC;AAED;;;;;GAKG;AACH,MAAM,CAAC,KAAK,UAAU,YAAY,CAAC,aAAqB,EAAE,OAAgB;IACxE,IAAI,CAAC,MAAM,CAAC,QAAQ,CAAC,aAAa,CAAC,IAAI,aAAa,IAAI,CAAC;QAAE,OAAM;IACjE,OAAO,eAAe,CAAC,KAAK,IAAI,EAAE;QAChC,MAAM,GAAG,GAAG,MAAM,OAAO,CAAC,OAAO,CAAC,CAAA;QAClC,gBAAgB,CAAC,GAAG,CAAC,CAAA;QACrB,MAAM,MAAM,GAAG,IAAI,CAAC,GAAG,EAAE,GAAG,aAAa,GAAG,MAAM,CAAA;QAClD,MAAM,IAAI,GAAyB,EAAE,CAAA;QACrC,KAAK,MAAM,KAAK,IAAI,GAAG,EAAE,CAAC;YACxB,IAAI,KAAK,CAAC,MAAM,KAAK,SAAS,EAAE,CAAC;gBAC/B,IAAI,CAAC,IAAI,CAAC,KAAK,CAAC,CAAA;gBAChB,SAAQ;YACV,CAAC;YACD,IAAI,CAAC,KAAK,CAAC,UAAU,IAAI,KAAK,CAAC,SAAS,CAAC,GAAG,MAAM;gBAAE,SAAQ;YAC5D,IAAI,CAAC,IAAI,CAAC,KAAK,CAAC,CAAA;QAClB,CAAC;QACD,MAAM,QAAQ,CAAC,IAAI,EAAE,OAAO,CAAC,CAAA;IAC/B,CAAC,CAAC,CAAC,IAAI,CAAC,KAAK,IAAI,EAAE;QACjB,MAAM,IAAI,GAAG,OAAO,IAAI,OAAO,CAAC,GAAG,CAAC,QAAQ,IAAI,IAAI,CAAC,OAAO,EAAE,EAAE,MAAM,CAAC,CAAA;QACvE,MAAM,SAAS,GAAG,IAAI,CAAC,IAAI,EAAE,SAAS,EAAE,gBAAgB,CAAC,CAAA;QACzD,MAAM,MAAM,GAAG,IAAI,CAAC,GAAG,EAAE,GAAG,aAAa,GAAG,MAAM,CAAA;QAClD,IAAI,KAAe,CAAA;QACnB,IAAI,CAAC;YACH,KAAK,GAAG,MAAM,OAAO,CAAC,SAAS,CAAC,CAAA;QAClC,CAAC;QAAC,MAAM,CAAC;YACP,OAAM;QACR,CAAC;QACD,MAAM,OAAO,CAAC,GAAG,CAAC,KAAK,CAAC,GAAG,CAAC,KAAK,EAAE,IAAI,EAAE,EAAE;YACzC,oDAAoD;YACpD,MAAM,KAAK,GAAG,uBAAuB,CAAC,IAAI,CAAC,IAAI,CAAC,CAAA;YAChD,IAAI,KAAK,KAAK,IAAI;gBAAE,OAAM;YAC1B,MAAM,KAAK,GAAG,MAAM,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,CAAA;YAC9B,IAAI,CAAC,MAAM,CAAC,QAAQ,CAAC,KAAK,CAAC,IAAI,KAAK,IAAI,MAAM;gBAAE,OAAM;YACtD,MAAM,EAAE,CAAC,IAAI,CAAC,SAAS,EAAE,IAAI,CAAC,EAAE,EAAE,KAAK,EAAE,IAAI,EAAE,CAAC,CAAC,KAAK,CAAC,GAAG,EAAE,GAAE,CAAC,CAAC,CAAA;QAClE,CAAC,CAAC,CAAC,CAAA;IACL,CAAC,CAAC,CAAA;AACJ,CAAC;AAED;;;;;;;GAOG;AACH,IAAI,YAAY,GAAkB,OAAO,CAAC,OAAO,EAAE,CAAA;AACnD,SAAS,eAAe,CAAI,IAAsB;IAChD,MAAM,IAAI,GAAG,YAAY,CAAC,IAAI,CAAC,IAAI,EAAE,IAAI,CAAC,CAAA;IAC1C,YAAY,GAAG,IAAI,CAAC,IAAI,CACtB,GAAG,EAAE,CAAC,SAAS,EACf,GAAG,EAAE,CAAC,SAAS,CAChB,CAAA;IACD,OAAO,IAAI,CAAA;AACb,CAAC;AAED,MAAM,MAAM,GAAG,EAAE,GAAG,EAAE,GAAG,MAAM,CAAA"}
|
package/lib/review-marker.d.ts
DELETED
|
@@ -1,17 +0,0 @@
|
|
|
1
|
-
/**
|
|
2
|
-
* Machine-readable review comment identity (spec: coexistence §4-5).
|
|
3
|
-
*
|
|
4
|
-
* Every posted review comment (webhook + CI, quick + deep) ends with an
|
|
5
|
-
* invisible marker so the CI flow can detect "this head SHA already has a
|
|
6
|
-
* completed review" without access to the webhook's history store.
|
|
7
|
-
*/
|
|
8
|
-
export type ReviewFlow = 'ci-quick' | 'ci-deep' | 'webhook';
|
|
9
|
-
export declare function reviewMarker(sha: string, flow: ReviewFlow): string;
|
|
10
|
-
export declare function parseReviewMarker(body: string): {
|
|
11
|
-
sha: string;
|
|
12
|
-
flow: string;
|
|
13
|
-
status: string;
|
|
14
|
-
} | undefined;
|
|
15
|
-
/** CI detection is env-based (established pattern): the reviewer job always sets these. */
|
|
16
|
-
export declare function resolveFlow(mode: 'quick' | 'deep'): ReviewFlow;
|
|
17
|
-
//# sourceMappingURL=review-marker.d.ts.map
|
|
@@ -1 +0,0 @@
|
|
|
1
|
-
{"version":3,"file":"review-marker.d.ts","sourceRoot":"","sources":["../src/host/review-marker.ts"],"names":[],"mappings":"AAAA;;;;;;GAMG;AAEH,MAAM,MAAM,UAAU,GAAG,UAAU,GAAG,SAAS,GAAG,SAAS,CAAA;AAE3D,wBAAgB,YAAY,CAAC,GAAG,EAAE,MAAM,EAAE,IAAI,EAAE,UAAU,GAAG,MAAM,CAElE;AAED,wBAAgB,iBAAiB,CAAC,IAAI,EAAE,MAAM,GAAG;IAAE,GAAG,EAAE,MAAM,CAAC;IAAC,IAAI,EAAE,MAAM,CAAC;IAAC,MAAM,EAAE,MAAM,CAAA;CAAE,GAAG,SAAS,CAIzG;AAED,2FAA2F;AAC3F,wBAAgB,WAAW,CAAC,IAAI,EAAE,OAAO,GAAG,MAAM,GAAG,UAAU,CAG9D"}
|
package/lib/review-marker.js
DELETED
|
@@ -1,23 +0,0 @@
|
|
|
1
|
-
/**
|
|
2
|
-
* Machine-readable review comment identity (spec: coexistence §4-5).
|
|
3
|
-
*
|
|
4
|
-
* Every posted review comment (webhook + CI, quick + deep) ends with an
|
|
5
|
-
* invisible marker so the CI flow can detect "this head SHA already has a
|
|
6
|
-
* completed review" without access to the webhook's history store.
|
|
7
|
-
*/
|
|
8
|
-
export function reviewMarker(sha, flow) {
|
|
9
|
-
return `<!-- maestro-review sha=${sha} flow=${flow} status=completed -->`;
|
|
10
|
-
}
|
|
11
|
-
export function parseReviewMarker(body) {
|
|
12
|
-
const m = /<!-- maestro-review sha=([0-9a-fA-F]+) flow=([a-z-]+) status=([a-z]+) -->/.exec(body);
|
|
13
|
-
if (!m)
|
|
14
|
-
return undefined;
|
|
15
|
-
return { sha: m[1], flow: m[2], status: m[3] };
|
|
16
|
-
}
|
|
17
|
-
/** CI detection is env-based (established pattern): the reviewer job always sets these. */
|
|
18
|
-
export function resolveFlow(mode) {
|
|
19
|
-
if (process.env.SOURCE_PROJECT_ID === undefined)
|
|
20
|
-
return 'webhook';
|
|
21
|
-
return mode === 'deep' ? 'ci-deep' : 'ci-quick';
|
|
22
|
-
}
|
|
23
|
-
//# sourceMappingURL=review-marker.js.map
|
package/lib/review-marker.js.map
DELETED
|
@@ -1 +0,0 @@
|
|
|
1
|
-
{"version":3,"file":"review-marker.js","sourceRoot":"","sources":["../src/host/review-marker.ts"],"names":[],"mappings":"AAAA;;;;;;GAMG;AAIH,MAAM,UAAU,YAAY,CAAC,GAAW,EAAE,IAAgB;IACxD,OAAO,2BAA2B,GAAG,SAAS,IAAI,uBAAuB,CAAA;AAC3E,CAAC;AAED,MAAM,UAAU,iBAAiB,CAAC,IAAY;IAC5C,MAAM,CAAC,GAAG,2EAA2E,CAAC,IAAI,CAAC,IAAI,CAAC,CAAA;IAChG,IAAI,CAAC,CAAC;QAAE,OAAO,SAAS,CAAA;IACxB,OAAO,EAAE,GAAG,EAAE,CAAC,CAAC,CAAC,CAAC,EAAE,IAAI,EAAE,CAAC,CAAC,CAAC,CAAC,EAAE,MAAM,EAAE,CAAC,CAAC,CAAC,CAAC,EAAE,CAAA;AAChD,CAAC;AAED,2FAA2F;AAC3F,MAAM,UAAU,WAAW,CAAC,IAAsB;IAChD,IAAI,OAAO,CAAC,GAAG,CAAC,iBAAiB,KAAK,SAAS;QAAE,OAAO,SAAS,CAAA;IACjE,OAAO,IAAI,KAAK,MAAM,CAAC,CAAC,CAAC,SAAS,CAAC,CAAC,CAAC,UAAU,CAAA;AACjD,CAAC"}
|
package/lib/review-signals.d.ts
DELETED
|
@@ -1,17 +0,0 @@
|
|
|
1
|
-
/**
|
|
2
|
-
* MR award-emoji acknowledgements: the MR shows "eyes" while a review runs and
|
|
3
|
-
* a final marker when it completes or fails. Signalling is best-effort — any
|
|
4
|
-
* GitLab error is swallowed so it can never fail the review itself.
|
|
5
|
-
*/
|
|
6
|
-
export interface ReviewSignals {
|
|
7
|
-
start(): Promise<void>;
|
|
8
|
-
finish(outcome: 'completed' | 'failed'): Promise<void>;
|
|
9
|
-
}
|
|
10
|
-
export declare function createReviewSignals(options: {
|
|
11
|
-
baseUrl: string;
|
|
12
|
-
token: string;
|
|
13
|
-
projectId: number;
|
|
14
|
-
mrIid: number;
|
|
15
|
-
botUsername: string;
|
|
16
|
-
}): ReviewSignals;
|
|
17
|
-
//# sourceMappingURL=review-signals.d.ts.map
|
|
@@ -1 +0,0 @@
|
|
|
1
|
-
{"version":3,"file":"review-signals.d.ts","sourceRoot":"","sources":["../src/host/review-signals.ts"],"names":[],"mappings":"AAAA;;;;GAIG;AAKH,MAAM,WAAW,aAAa;IAC5B,KAAK,IAAI,OAAO,CAAC,IAAI,CAAC,CAAA;IACtB,MAAM,CAAC,OAAO,EAAE,WAAW,GAAG,QAAQ,GAAG,OAAO,CAAC,IAAI,CAAC,CAAA;CACvD;AA8CD,wBAAgB,mBAAmB,CAAC,OAAO,EAAE;IAAE,OAAO,EAAE,MAAM,CAAC;IAAC,KAAK,EAAE,MAAM,CAAC;IAAC,SAAS,EAAE,MAAM,CAAC;IAAC,KAAK,EAAE,MAAM,CAAC;IAAC,WAAW,EAAE,MAAM,CAAA;CAAE,GAAG,aAAa,CAwBrJ"}
|
package/lib/review-signals.js
DELETED
|
@@ -1,79 +0,0 @@
|
|
|
1
|
-
/**
|
|
2
|
-
* MR award-emoji acknowledgements: the MR shows "eyes" while a review runs and
|
|
3
|
-
* a final marker when it completes or fails. Signalling is best-effort — any
|
|
4
|
-
* GitLab error is swallowed so it can never fail the review itself.
|
|
5
|
-
*/
|
|
6
|
-
import { gitlabAuthHeaders } from './gitlab-auth.js';
|
|
7
|
-
import { fetchWithTimeout } from './gitlab-client.js';
|
|
8
|
-
async function award(baseUrl, token, projectId, mrIid, name) {
|
|
9
|
-
const response = await fetchWithTimeout(`${baseUrl}/api/v4/projects/${projectId}/merge_requests/${mrIid}/award_emoji`, {
|
|
10
|
-
method: 'POST',
|
|
11
|
-
headers: { ...gitlabAuthHeaders(token), 'Content-Type': 'application/json' },
|
|
12
|
-
body: JSON.stringify({ name }),
|
|
13
|
-
});
|
|
14
|
-
// fetchWithTimeout only throws on a network/abort failure; a non-2xx status
|
|
15
|
-
// (expired token, missing scope, rate-limited) resolves normally and must
|
|
16
|
-
// be checked explicitly, or the caller's failure logging never fires.
|
|
17
|
-
if (!response.ok)
|
|
18
|
-
throw new Error(`GitLab API error ${response.status} awarding "${name}": ${await response.text()}`);
|
|
19
|
-
}
|
|
20
|
-
/** Every marker name this bot ever awards — kept in one place so `unawardOwn` can always clear all of them, leaving at most one visible at a time. */
|
|
21
|
-
const MARKER_NAMES = ['eyes', 'white_check_mark', 'warning'];
|
|
22
|
-
/**
|
|
23
|
-
* Remove this bot's own markers among `names`; other users' awards stay untouched.
|
|
24
|
-
* Callers pass `MARKER_NAMES` (not just "eyes") so a stale terminal marker from a
|
|
25
|
-
* prior run (e.g. `white_check_mark`) is cleared before re-awarding the same name —
|
|
26
|
-
* GitLab rejects a duplicate award of the same name by the same user with a 404
|
|
27
|
-
* ("Award Emoji Name has already been taken"), which otherwise surfaces as a
|
|
28
|
-
* confusing failure on the second consecutive completed/failed review of one MR.
|
|
29
|
-
*/
|
|
30
|
-
async function unawardOwn(baseUrl, token, projectId, mrIid, botUsername, names) {
|
|
31
|
-
const response = await fetchWithTimeout(`${baseUrl}/api/v4/projects/${projectId}/merge_requests/${mrIid}/award_emoji`, {
|
|
32
|
-
headers: gitlabAuthHeaders(token),
|
|
33
|
-
});
|
|
34
|
-
if (!response.ok)
|
|
35
|
-
throw new Error(`GitLab API error ${response.status} listing award emoji: ${await response.text()}`);
|
|
36
|
-
const awards = (await response.json());
|
|
37
|
-
for (const awardItem of Array.isArray(awards) ? awards : []) {
|
|
38
|
-
if (awardItem.name === undefined || !names.includes(awardItem.name) || awardItem.user?.username !== botUsername || typeof awardItem.id !== 'number')
|
|
39
|
-
continue;
|
|
40
|
-
const deleteResponse = await fetchWithTimeout(`${baseUrl}/api/v4/projects/${projectId}/merge_requests/${mrIid}/award_emoji/${awardItem.id}`, {
|
|
41
|
-
method: 'DELETE',
|
|
42
|
-
headers: gitlabAuthHeaders(token),
|
|
43
|
-
}).catch((err) => {
|
|
44
|
-
console.error(`review-signals: failed to delete stale ${awardItem.name} marker ${awardItem.id} on MR !${mrIid}`, err);
|
|
45
|
-
return undefined;
|
|
46
|
-
});
|
|
47
|
-
if (deleteResponse !== undefined && !deleteResponse.ok) {
|
|
48
|
-
console.error(`review-signals: GitLab API error ${deleteResponse.status} deleting stale ${awardItem.name} marker ${awardItem.id} on MR !${mrIid}`);
|
|
49
|
-
}
|
|
50
|
-
}
|
|
51
|
-
}
|
|
52
|
-
export function createReviewSignals(options) {
|
|
53
|
-
const { baseUrl, token, projectId, mrIid, botUsername } = options;
|
|
54
|
-
return {
|
|
55
|
-
async start() {
|
|
56
|
-
try {
|
|
57
|
-
await unawardOwn(baseUrl, token, projectId, mrIid, botUsername, MARKER_NAMES);
|
|
58
|
-
await award(baseUrl, token, projectId, mrIid, 'eyes');
|
|
59
|
-
}
|
|
60
|
-
catch (err) {
|
|
61
|
-
// Signalling must never break the review, but a swallowed failure
|
|
62
|
-
// here is exactly what leaves a stale "eyes" marker stuck on the MR
|
|
63
|
-
// forever (blocking the push-gate's 👀-running check for both the
|
|
64
|
-
// webhook and CI flows) with zero trace of why — log it.
|
|
65
|
-
console.error(`review-signals: failed to set the running marker on MR !${mrIid}`, err);
|
|
66
|
-
}
|
|
67
|
-
},
|
|
68
|
-
async finish(outcome) {
|
|
69
|
-
try {
|
|
70
|
-
await unawardOwn(baseUrl, token, projectId, mrIid, botUsername, MARKER_NAMES);
|
|
71
|
-
await award(baseUrl, token, projectId, mrIid, outcome === 'completed' ? 'white_check_mark' : 'warning');
|
|
72
|
-
}
|
|
73
|
-
catch (err) {
|
|
74
|
-
console.error(`review-signals: failed to clear the running marker / award the final marker on MR !${mrIid}`, err);
|
|
75
|
-
}
|
|
76
|
-
},
|
|
77
|
-
};
|
|
78
|
-
}
|
|
79
|
-
//# sourceMappingURL=review-signals.js.map
|