@dashevo/wasm-dpp 0.24.0-dev.12 → 0.24.0-dev.14

package/test/unit/Metadata.spec.js

@@ -1,15 +1,25 @@
-const Metadata = require('@dashevo/dpp/lib/Metadata');
+const { default: loadWasmDpp } = require('../..');
+
+let Metadata;
 
 describe('Metadata', () => {
+  beforeEach(async () => {
+    ({ Metadata } = await loadWasmDpp());
+  });
+
   describe('#constructor', () => {
     it('should set height and core chain-locked height', () => {
       const result = new Metadata({
         blockHeight: 42,
         coreChainLockedHeight: 1,
+        timeMs: 100,
+        protocolVersion: 2,
       });
 
-      expect(result.blockHeight).to.equal(42);
-      expect(result.coreChainLockedHeight).to.equal(1);
+      expect(result.getBlockHeight()).to.equal(42);
+      expect(result.getCoreChainLockedHeight()).to.equal(1);
+      expect(result.getTimeMs()).to.equal(100);
+      expect(result.getProtocolVersion()).to.equal(2);
     });
   });
 
@@ -18,6 +28,8 @@ describe('Metadata', () => {
       const result = new Metadata({
         blockHeight: 42,
         coreChainLockedHeight: 1,
+        timeMs: 100,
+        protocolVersion: 2,
       });
 
       expect(result.getBlockHeight()).to.equal(42);
@@ -29,6 +41,8 @@ describe('Metadata', () => {
       const result = new Metadata({
         blockHeight: 1,
         coreChainLockedHeight: 42,
+        timeMs: 100,
+        protocolVersion: 2,
       });
 
       expect(result.getCoreChainLockedHeight()).to.equal(42);

package/test/unit/dataContract/DataContract.spec.js

@@ -198,7 +198,7 @@ describe('DataContract', () => {
         dataContract.getDocumentSchema('undefinedObject');
         expect.fail('Error was not thrown');
       } catch (e) {
-        expect(e.getDocType()).to.equal('undefinedObject');
+        expect(e.getType()).to.equal('undefinedObject');
       }
     });
 
@@ -215,7 +215,7 @@ describe('DataContract', () => {
         dataContract.getDocumentSchemaRef('undefinedObject');
         expect.fail('Error was not thrown');
       } catch (e) {
-        expect(e.getDocType()).to.equal('undefinedObject');
+        expect(e.getType()).to.equal('undefinedObject');
       }
     });
 
@@ -326,14 +326,19 @@ describe('DataContract', () => {
         dataContract.getBinaryProperties('unknown');
         expect.fail('Error was not thrown');
       } catch (e) {
-        expect(e.getDocType()).to.equal('unknown');
+        expect(e.getType()).to.equal('unknown');
       }
     });
   });
 
   describe('#setMetadata', () => {
     it('should set metadata', () => {
-      const otherMetadata = new Metadata(43, 1);
+      const otherMetadata = new Metadata({
+        blockHeight: 43,
+        coreChainLockedHeight: 1,
+        timeMs: 100,
+        protocolVersion: 2,
+      });
       const otherMetadataToObject = otherMetadata.toObject();
 
       dataContract.setMetadata(otherMetadata);

package/test/unit/dataContract/createDataContract.spec.js

@@ -16,7 +16,6 @@ describe('createDataContract', () => {
     rawDataContract = {
       $id: generateRandomIdentifier().toBuffer(),
       ownerId: generateRandomIdentifier().toBuffer(),
-      contractId: generateRandomIdentifier().toBuffer(),
       protocolVersion: 4,
       version: 20,
       $schema: 'http://test.com/schema',

package/test/unit/dataContract/stateTransition/DataContractCreateTransition/DataContractCreateTransition.spec.js

@@ -1,3 +1,4 @@
+const varint = require('varint');
 const getDataContractFixture = require('@dashevo/dpp/lib/test/fixtures/getDataContractFixture');
 const stateTransitionTypes = require('@dashevo/dpp/lib/stateTransition/stateTransitionTypes');
 
@@ -64,11 +65,10 @@ describe('DataContractCreateTransition', () => {
 
   describe('#toBuffer', () => {
     it('should return serialized State Transition', () => {
-      const protocolVersionUInt32 = Buffer.alloc(4);
-      protocolVersionUInt32.writeUInt32LE(stateTransition.getProtocolVersion(), 0);
+      const protocolVersionBytes = Buffer.from(varint.encode(stateTransition.getProtocolVersion()));
 
       const result = stateTransition.toBuffer();
-      expect(result.compare(protocolVersionUInt32, 0, 4, 0, 4)).equals(0);
+      expect(result.compare(protocolVersionBytes, 0, 1, 0, 1)).equals(0);
     });
   });
 

package/test/unit/dataContract/stateTransition/DataContractCreateTransition/applyDataContractCreateTransitionFactory.spec.js

@@ -37,7 +37,7 @@ describe('applyDataContractCreateTransitionFactory', () => {
     stateTransition.setExecutionContext(executionContext);
 
     const stateRepositoryLike = {
-      storeDataContract: () => {
+      storeDataContract: async () => {
         dataContractStored = true;
       },
     };

package/test/unit/dataContract/stateTransition/DataContractCreateTransition/validation/state/validateDataContractCreateTransitionStateFactory.spec.js

@@ -42,7 +42,7 @@ describe('validateDataContractCreateTransitionStateFactory', () => {
     dataContractFetched = false;
 
     const stateRepositoryLike = {
-      fetchDataContract: () => {
+      fetchDataContract: async () => {
         dataContractFetched = true;
       },
     };
@@ -57,7 +57,7 @@ describe('validateDataContractCreateTransitionStateFactory', () => {
     const wasmDataContract = await dataContractFactory.createFromBuffer(dataContract.toBuffer());
 
     const stateRepositoryLikeWithContract = {
-      fetchDataContract: () => wasmDataContract,
+      fetchDataContract: async () => wasmDataContract,
     };
 
     const result = await validateDataContractCreateTransitionState(

package/test/unit/dataContract/stateTransition/DataContractUpdateTransition/DataContractUpdateTransition.spec.js

@@ -1,3 +1,4 @@
+const varint = require('varint');
 const getDataContractFixture = require('@dashevo/dpp/lib/test/fixtures/getDataContractFixture');
 const stateTransitionTypes = require('@dashevo/dpp/lib/stateTransition/stateTransitionTypes');
 const protocolVersion = require('@dashevo/dpp/lib/version/protocolVersion');
@@ -62,11 +63,10 @@ describe('DataContractUpdateTransition', () => {
 
   describe('#toBuffer', () => {
     it('should return serialized State Transition that starts with protocol version', () => {
-      const protocolVersionUInt32 = Buffer.alloc(4);
-      protocolVersionUInt32.writeUInt32LE(stateTransition.getProtocolVersion(), 0);
+      const protocolVersionBytes = Buffer.from(varint.encode(stateTransition.getProtocolVersion()));
 
       const result = stateTransition.toBuffer();
-      expect(result.compare(protocolVersionUInt32, 0, 4, 0, 4)).equals(0);
+      expect(result.compare(protocolVersionBytes, 0, 1, 0, 1)).equals(0);
     });
   });
 

package/test/unit/dataContract/stateTransition/DataContractUpdateTransition/applyDataContractUpdateTransitionFactory.spec.js

@@ -34,7 +34,7 @@ describe('applyDataContractUpdateTransitionFactory', () => {
     stateTransition.setExecutionContext(executionContext);
 
     const stateRepositoryLike = {
-      storeDataContract: () => {
+      storeDataContract: async () => {
         dataContractStored = true;
       },
     };

package/test/unit/dataContract/stateTransition/DataContractUpdateTransition/validation/basic/validateIndicesAreBackwardCompatible.spec.js

@@ -23,31 +23,13 @@ describe('validateIndicesAreBackwardCompatible', () => {
     const oldDataContract = getDataContractFixture();
     const newDataContract = getDataContractFixture();
 
-    newDataContract.getDocumentSchema('indexedDocument').properties.otherName = {
-      type: 'string',
-    };
-
-    newDataContract.getDocumentSchema('indexedDocument').indices.push({
-      name: 'index42',
-      unique: false,
-      properties: [
-        { otherName: 'asc' },
-      ],
-    });
-
-    newDataContract.getDocumentSchema('indexedDocument').indices.push({
-      name: 'index42',
-      properties: [
-        { otherName: 'asc' },
-      ],
-    });
-
     oldDocumentsSchema = oldDataContract.getDocuments();
     newDocumentsSchema = newDataContract.getDocuments();
   });
 
   it('should return invalid result if some of unique indices have changed', async () => {
     newDocumentsSchema.indexedDocument.indices[0].properties[1].firstName = 'desc';
+
     const result = validateIndicesAreBackwardCompatible(oldDocumentsSchema, newDocumentsSchema);
 
     expect(result.isValid()).to.be.false();
@@ -58,7 +40,7 @@ describe('validateIndicesAreBackwardCompatible', () => {
     expect(error.getIndexName()).to.equal(newDocumentsSchema.indexedDocument.indices[0].name);
   });
 
-  it('should return invalid result if non-unique index update failed due to changed old properties', async () => {
+  it('should return invalid result if already defined properties are changed in existing index', async () => {
     newDocumentsSchema.indexedDocument.indices[2].properties[0].lastName = 'desc';
 
     const result = validateIndicesAreBackwardCompatible(oldDocumentsSchema, newDocumentsSchema);
@@ -71,24 +53,17 @@ describe('validateIndicesAreBackwardCompatible', () => {
     expect(error.getIndexName()).to.equal(newDocumentsSchema.indexedDocument.indices[2].name);
   });
 
-  it('should return invalid result if non-unique index update failed due old properties used', async () => {
-    newDocumentsSchema.indexedDocument.indices.push({
-      name: 'oldFieldIndex',
-      properties: [
-        {
-          otherProperty: 'asc',
-        },
-      ],
-    });
+  it('should return invalid result if already indexed properties are added to existing index', async () => {
+    newDocumentsSchema.indexedDocument.indices[2].properties.push({ firstName: 'asc' });
 
     const result = validateIndicesAreBackwardCompatible(oldDocumentsSchema, newDocumentsSchema);
 
     expect(result.isValid()).to.be.false();
 
-    const error = result.getErrors()[0];
+    const [error] = result.getErrors();
 
     expect(error).to.be.an.instanceOf(DataContractInvalidIndexDefinitionUpdateError);
-    expect(error.getIndexName()).to.equal('oldFieldIndex');
+    expect(error.getIndexName()).to.equal(newDocumentsSchema.indexedDocument.indices[2].name);
   });
 
   it('should return invalid result if one of new indices contains old properties in the wrong order', async () => {
@@ -130,6 +105,25 @@ describe('validateIndicesAreBackwardCompatible', () => {
     expect(error.getIndexName()).to.equal('index_other');
   });
 
+  it('should return invalid result if existing property was used in a new index', async () => {
+    newDocumentsSchema.indexedDocument.indices.push({
+      name: 'oldFieldIndex',
+      properties: [
+        {
+          otherProperty: 'asc',
+        },
+      ],
+    });
+
+    const result = validateIndicesAreBackwardCompatible(oldDocumentsSchema, newDocumentsSchema);
+
+    expect(result.isValid()).to.be.false();
+
+    const [error] = result.getErrors();
+    expect(error).to.be.an.instanceOf(DataContractInvalidIndexDefinitionUpdateError);
+    expect(error.getIndexName()).to.equal('oldFieldIndex');
+  });
+
   it('should return valid result if indices are not changed', async () => {
     const result = validateIndicesAreBackwardCompatible(oldDocumentsSchema, newDocumentsSchema);
 

package/test/unit/dataContract/stateTransition/DataContractUpdateTransition/validation/state/validateDataContractUpdateTransitionStateFactory.spec.js

@@ -51,7 +51,7 @@ describe('validateDataContractUpdateTransitionStateFactory', () => {
     const wasmDataContract = await dataContractFactory.createFromBuffer(dataContract.toBuffer());
 
     const stateRepositoryLike = {
-      fetchDataContract: () => wasmDataContract,
+      fetchDataContract: async () => wasmDataContract,
     };
 
     validateTransitionWithExistingContract = (t) => validateDataContractUpdateTransitionState(
@@ -62,7 +62,7 @@ describe('validateDataContractUpdateTransitionStateFactory', () => {
 
   it('should return invalid result if Data Contract with specified contractId was not found', async () => {
     const stateRepositoryLikeNoDataContract = {
-      fetchDataContract: () => undefined,
+      fetchDataContract: async () => undefined,
     };
 
     const validateTransitionWithNoContract = (t) => validateDataContractUpdateTransitionState(
@@ -108,7 +108,7 @@ describe('validateDataContractUpdateTransitionStateFactory', () => {
 
   it('should return valid result on dry run', async () => {
     const stateRepositoryLikeNoDataContract = {
-      fetchDataContract: () => undefined,
+      fetchDataContract: async () => undefined,
     };
 
     const validateTransitionWithNoContract = (t) => validateDataContractUpdateTransitionState(

package/test/unit/dataTrigger/rewardShareDataTriggers/createMasternodeRewardSharesDataTrigger.spec.js

@@ -33,6 +33,7 @@ describe('createMasternodeRewardSharesDataTrigger', () => {
           service: '192.168.65.2:20101',
           pubKeyOperator: '809519c5f6f3be1c08782ac42ae9a83b6c7205eba43f9a96a4f032ec7a73f1a7c25fa78cce0d6d9c135f7e2c28527179',
           votingAddress: 'yXmprXYP51uzfMyndtWwxz96MnkCKkFc9x',
+          nType: 0,
           isValid: true,
         }),
         new SimplifiedMNListEntry({
@@ -41,6 +42,7 @@ describe('createMasternodeRewardSharesDataTrigger', () => {
           service: '192.168.65.2:20201',
           pubKeyOperator: '987a4873caba62cd45a2f7d4aa6d94519ee6753e9bef777c927cb94ade768a542b0ff34a93231d3a92b4e75ffdaa366e',
           votingAddress: 'ycL7L4mhYoaZdm9TH85svvpfeKtdfo249u',
+          nType: 0,
           isValid: true,
         }),
       ]),

package/test/unit/decodeProtocolEntityFactory.spec.js

@@ -1,3 +1,4 @@
+const varint = require('varint');
 const decodeProtocolEntityFactory = require('@dashevo/dpp/lib/decodeProtocolEntityFactory');
 const ProtocolVersionParsingError = require('@dashevo/dpp/lib/errors/consensus/basic/decode/ProtocolVersionParsingError');
 const SerializedObjectParsingError = require('@dashevo/dpp/lib/errors/consensus/basic/decode/SerializedObjectParsingError');
@@ -16,8 +17,7 @@ describe('decodeProtocolEntityFactory', () => {
   beforeEach(() => {
     parsedProtocolVersion = 0;
 
-    protocolVersionBuffer = Buffer.alloc(4);
-    protocolVersionBuffer.writeUInt32LE(parsedProtocolVersion, 0);
+    protocolVersionBuffer = Buffer.from(varint.encode(parsedProtocolVersion));
 
     rawEntity = { test: 'successful' };
     entityBuffer = encode(rawEntity);