@dashevo/wasm-dpp 0.24.0-dev.12 → 0.24.0-dev.14

package/test/integration/identity/stateTransition/IdentityUpdateTransition/validation/basic/validateIdentityUpdateTransitionBasicFactory.spec.js

@@ -1,59 +1,69 @@
-const { getRE2Class } = require('@dashevo/wasm-re2');
 const { PrivateKey } = require('@dashevo/dashcore-lib');
-const validateIdentityUpdateTransitionBasicFactory = require(
-  '@dashevo/dpp/lib/identity/stateTransition/IdentityUpdateTransition/validation/basic/validateIdentityUpdateTransitionBasicFactory',
-);
-const JsonSchemaValidator = require('@dashevo/dpp/lib/validation/JsonSchemaValidator');
-const createAjv = require('@dashevo/dpp/lib/ajv/createAjv');
-const ValidationResult = require('@dashevo/dpp/lib/validation/ValidationResult');
-const IdentityPublicKey = require('@dashevo/dpp/lib/identity/IdentityPublicKey');
 const getIdentityUpdateTransitionFixture = require('@dashevo/dpp/lib/test/fixtures/getIdentityUpdateTransitionFixture');
-const { expectJsonSchemaError, expectValidationError } = require('@dashevo/dpp/lib/test/expect/expectError');
-const SomeConsensusError = require('@dashevo/dpp/lib/test/mocks/SomeConsensusError');
+
+const { expectJsonSchemaError, expectValidationError } = require('../../../../../../../lib/test/expect/expectError');
+const { default: loadWasmDpp } = require('../../../../../../../dist');
+const getBlsAdapterMock = require('../../../../../../../lib/test/mocks/getBlsAdapterMock');
 
 describe('validateIdentityUpdateTransitionBasicFactory', () => {
   let validateIdentityUpdateTransitionBasic;
-  let validateProtocolVersionMock;
-  let validatePublicKeysMock;
   let rawStateTransition;
   let stateTransition;
   let publicKeyToAdd;
-  let validatePublicKeySignaturesMock;
 
-  beforeEach(async function beforeEach() {
-    const RE2 = await getRE2Class();
-    const ajv = createAjv(RE2);
-    const jsonSchemaValidator = new JsonSchemaValidator(ajv);
+  let IdentityUpdateTransition;
+  let IdentityPublicKey;
+  let IdentityPublicKeyCreateTransition;
+  let UnsupportedProtocolVersionError;
+  let InvalidIdentityKeySignatureError;
+  let DuplicatedIdentityPublicKeyIdStateError;
+  let IdentityUpdateTransitionBasicValidator;
+
+  before(async () => {
+    ({
+      IdentityUpdateTransition,
+      UnsupportedProtocolVersionError,
+      InvalidIdentityKeySignatureError,
+      DuplicatedIdentityPublicKeyIdStateError,
+      IdentityPublicKey,
+      IdentityPublicKeyCreateTransition,
+      IdentityUpdateTransitionBasicValidator,
+    } = await loadWasmDpp());
+  });
 
-    validateProtocolVersionMock = this.sinonSandbox.stub().returns(new ValidationResult());
+  beforeEach(async () => {
+    const blsAdapter = await getBlsAdapterMock();
 
-    validatePublicKeysMock = this.sinonSandbox.stub()
-      .returns(new ValidationResult());
+    const validator = new IdentityUpdateTransitionBasicValidator(blsAdapter);
+    validateIdentityUpdateTransitionBasic = (st) => validator.validate(st);
 
-    validatePublicKeySignaturesMock = this.sinonSandbox.stub()
-      .returns(new ValidationResult());
+    const stateTransitionJS = getIdentityUpdateTransitionFixture();
+    stateTransition = new IdentityUpdateTransition(stateTransitionJS.toObject());
 
-    validateIdentityUpdateTransitionBasic = validateIdentityUpdateTransitionBasicFactory(
-      jsonSchemaValidator,
-      validateProtocolVersionMock,
-      validatePublicKeysMock,
-      validatePublicKeySignaturesMock,
-    );
+    const privateKey = new PrivateKey('9b67f852093bc61cea0eeca38599dbfba0de28574d2ed9b99d10d33dc1bde7b2');
+    const publicKey = privateKey.toPublicKey().toBuffer();
 
-    stateTransition = getIdentityUpdateTransitionFixture();
+    const identityPublicKey = new IdentityPublicKey({
+      id: 1,
+      type: IdentityPublicKey.TYPES.ECDSA_SECP256K1,
+      data: publicKey,
+      purpose: IdentityPublicKey.PURPOSES.AUTHENTICATION,
+      securityLevel: IdentityPublicKey.SECURITY_LEVELS.MASTER,
+      readOnly: false,
+    });
+
+    let identityPublicKeyCreateTransition = new IdentityPublicKeyCreateTransition({
+      ...identityPublicKey.toObject(),
+      signature: Buffer.alloc(0),
+    });
 
-    const privateKeyModel = new PrivateKey();
-    const privateKeyHex = privateKeyModel.toBuffer().toString('hex');
-    const publicKey = privateKeyModel.toPublicKey().toBuffer();
+    stateTransition.setPublicKeysToAdd([identityPublicKeyCreateTransition]);
 
-    const identityPublicKey = new IdentityPublicKey()
-      .setId(1)
-      .setType(IdentityPublicKey.TYPES.ECDSA_SECP256K1)
-      .setData(publicKey)
-      .setSecurityLevel(IdentityPublicKey.SECURITY_LEVELS.MASTER)
-      .setPurpose(IdentityPublicKey.PURPOSES.AUTHENTICATION);
+    await stateTransition.sign(identityPublicKey, privateKey.toBuffer());
 
-    await stateTransition.sign(identityPublicKey, privateKeyHex);
+    [identityPublicKeyCreateTransition] = stateTransition.getPublicKeysToAdd();
+    identityPublicKeyCreateTransition.setSignature(stateTransition.getSignature());
+    stateTransition.setPublicKeysToAdd([identityPublicKeyCreateTransition]);
 
     rawStateTransition = stateTransition.toObject();
 
@@ -64,6 +74,7 @@ describe('validateIdentityUpdateTransitionBasicFactory', () => {
       purpose: IdentityPublicKey.PURPOSES.AUTHENTICATION,
       securityLevel: IdentityPublicKey.SECURITY_LEVELS.MASTER,
       readOnly: false,
+      signature: Buffer.alloc(0),
     };
   });
 
@@ -73,7 +84,7 @@ describe('validateIdentityUpdateTransitionBasicFactory', () => {
 
       const result = await validateIdentityUpdateTransitionBasic(rawStateTransition);
 
-      expectJsonSchemaError(result);
+      await expectJsonSchemaError(result);
 
       const [error] = result.getErrors();
 
@@ -87,7 +98,7 @@ describe('validateIdentityUpdateTransitionBasicFactory', () => {
 
       const result = await validateIdentityUpdateTransitionBasic(rawStateTransition);
 
-      expectJsonSchemaError(result);
+      await expectJsonSchemaError(result);
 
       const [error] = result.getErrors();
 
@@ -96,25 +107,11 @@ describe('validateIdentityUpdateTransitionBasicFactory', () => {
     });
 
     it('should be valid', async () => {
-      rawStateTransition.protocolVersion = -1;
-      const protocolVersionError = new SomeConsensusError('test');
-      const protocolVersionResult = new ValidationResult([
-        protocolVersionError,
-      ]);
-
-      validateProtocolVersionMock.returns(protocolVersionResult);
+      rawStateTransition.protocolVersion = 100;
 
       const result = await validateIdentityUpdateTransitionBasic(rawStateTransition);
 
-      expectValidationError(result, SomeConsensusError);
-
-      const [error] = result.getErrors();
-
-      expect(error).to.equal(protocolVersionError);
-
-      expect(validateProtocolVersionMock).to.be.calledOnceWith(
-        rawStateTransition.protocolVersion,
-      );
+      await expectValidationError(result, UnsupportedProtocolVersionError);
     });
   });
 
@@ -124,7 +121,7 @@ describe('validateIdentityUpdateTransitionBasicFactory', () => {
 
       const result = await validateIdentityUpdateTransitionBasic(rawStateTransition);
 
-      expectJsonSchemaError(result);
+      await expectJsonSchemaError(result);
 
       const [error] = result.getErrors();
 
@@ -138,7 +135,7 @@ describe('validateIdentityUpdateTransitionBasicFactory', () => {
 
       const result = await validateIdentityUpdateTransitionBasic(rawStateTransition);
 
-      expectJsonSchemaError(result);
+      await expectJsonSchemaError(result);
 
       const [error] = result.getErrors();
 
@@ -156,7 +153,7 @@ describe('validateIdentityUpdateTransitionBasicFactory', () => {
         rawStateTransition,
       );
 
-      expectJsonSchemaError(result);
+      await expectJsonSchemaError(result);
 
       const [error] = result.getErrors();
 
@@ -172,14 +169,12 @@ describe('validateIdentityUpdateTransitionBasicFactory', () => {
         rawStateTransition,
       );
 
-      expectJsonSchemaError(result, 2);
+      await expectJsonSchemaError(result, 32);
 
-      const [error, byteArrayError] = result.getErrors();
+      const [error] = result.getErrors();
 
       expect(error.getInstancePath()).to.equal('/identityId/0');
       expect(error.getKeyword()).to.equal('type');
-
-      expect(byteArrayError.getKeyword()).to.equal('byteArray');
     });
 
     it('should be no less than 32 bytes', async () => {
@@ -189,11 +184,11 @@ describe('validateIdentityUpdateTransitionBasicFactory', () => {
         rawStateTransition,
       );
 
-      expectJsonSchemaError(result);
+      await expectJsonSchemaError(result);
 
       const [error] = result.getErrors();
 
-      expect(error.instancePath).to.equal('/identityId');
+      expect(error.getInstancePath()).to.equal('/identityId');
       expect(error.getKeyword()).to.equal('minItems');
     });
 
@@ -204,11 +199,11 @@ describe('validateIdentityUpdateTransitionBasicFactory', () => {
         rawStateTransition,
       );
 
-      expectJsonSchemaError(result);
+      await expectJsonSchemaError(result);
 
       const [error] = result.getErrors();
 
-      expect(error.instancePath).to.equal('/identityId');
+      expect(error.getInstancePath()).to.equal('/identityId');
       expect(error.getKeyword()).to.equal('maxItems');
     });
   });
@@ -219,11 +214,11 @@ describe('validateIdentityUpdateTransitionBasicFactory', () => {
 
       const result = await validateIdentityUpdateTransitionBasic(rawStateTransition);
 
-      expectJsonSchemaError(result);
+      await expectJsonSchemaError(result);
 
       const [error] = result.getErrors();
 
-      expect(error.instancePath).to.equal('');
+      expect(error.getInstancePath()).to.equal('');
       expect(error.getKeyword()).to.equal('required');
       expect(error.getParams().missingProperty).to.equal('signature');
     });
@@ -233,14 +228,12 @@ describe('validateIdentityUpdateTransitionBasicFactory', () => {
 
       const result = await validateIdentityUpdateTransitionBasic(rawStateTransition);
 
-      expectJsonSchemaError(result, 2);
+      await expectJsonSchemaError(result, 65);
 
-      const [error, byteArrayError] = result.getErrors();
+      const [error] = result.getErrors();
 
-      expect(error.instancePath).to.equal('/signature/0');
+      expect(error.getInstancePath()).to.equal('/signature/0');
       expect(error.getKeyword()).to.equal('type');
-
-      expect(byteArrayError.getKeyword()).to.equal('byteArray');
     });
 
     it('should be not shorter than 65 bytes', async () => {
@@ -248,11 +241,11 @@ describe('validateIdentityUpdateTransitionBasicFactory', () => {
 
       const result = await validateIdentityUpdateTransitionBasic(rawStateTransition);
 
-      expectJsonSchemaError(result);
+      await expectJsonSchemaError(result);
 
       const [error] = result.getErrors();
 
-      expect(error.instancePath).to.equal('/signature');
+      expect(error.getInstancePath()).to.equal('/signature');
       expect(error.getKeyword()).to.equal('minItems');
     });
 
@@ -261,11 +254,11 @@ describe('validateIdentityUpdateTransitionBasicFactory', () => {
 
       const result = await validateIdentityUpdateTransitionBasic(rawStateTransition);
 
-      expectJsonSchemaError(result);
+      await expectJsonSchemaError(result);
 
       const [error] = result.getErrors();
 
-      expect(error.instancePath).to.equal('/signature');
+      expect(error.getInstancePath()).to.equal('/signature');
       expect(error.getKeyword()).to.equal('maxItems');
     });
   });
@@ -276,7 +269,7 @@ describe('validateIdentityUpdateTransitionBasicFactory', () => {
 
       const result = await validateIdentityUpdateTransitionBasic(rawStateTransition);
 
-      expectJsonSchemaError(result);
+      await expectJsonSchemaError(result);
 
       const [error] = result.getErrors();
 
@@ -290,7 +283,7 @@ describe('validateIdentityUpdateTransitionBasicFactory', () => {
 
       const result = await validateIdentityUpdateTransitionBasic(rawStateTransition);
 
-      expectJsonSchemaError(result);
+      await expectJsonSchemaError(result);
 
       const [error] = result.getErrors();
 
@@ -303,7 +296,7 @@ describe('validateIdentityUpdateTransitionBasicFactory', () => {
 
       const result = await validateIdentityUpdateTransitionBasic(rawStateTransition);
 
-      expectJsonSchemaError(result);
+      await expectJsonSchemaError(result);
 
       const [error] = result.getErrors();
 
@@ -319,7 +312,23 @@ describe('validateIdentityUpdateTransitionBasicFactory', () => {
     });
 
     it('should return valid result', async () => {
-      rawStateTransition.addPublicKeys = [publicKeyToAdd];
+      const privateKey = new PrivateKey();
+      const publicKey = privateKey.toPublicKey();
+
+      const identityPublicKeyCreateTransition = new IdentityPublicKeyCreateTransition(
+        publicKeyToAdd,
+      );
+      identityPublicKeyCreateTransition.setData(publicKey.toBuffer());
+
+      stateTransition.setPublicKeysToAdd([identityPublicKeyCreateTransition]);
+      await stateTransition.signByPrivateKey(
+        privateKey.toBuffer(),
+        identityPublicKeyCreateTransition.type,
+      );
+      identityPublicKeyCreateTransition.setSignature(stateTransition.getSignature());
+      stateTransition.setPublicKeysToAdd([identityPublicKeyCreateTransition]);
+
+      rawStateTransition = stateTransition.toObject();
 
       const result = await validateIdentityUpdateTransitionBasic(
         rawStateTransition,
@@ -333,7 +342,7 @@ describe('validateIdentityUpdateTransitionBasicFactory', () => {
 
       const result = await validateIdentityUpdateTransitionBasic(rawStateTransition);
 
-      expectJsonSchemaError(result);
+      await expectJsonSchemaError(result);
 
       const [error] = result.getErrors();
       expect(error.getKeyword()).to.equal('minItems');
@@ -344,14 +353,14 @@ describe('validateIdentityUpdateTransitionBasicFactory', () => {
       rawStateTransition.addPublicKeys = [];
 
       for (let i = 0; i <= 10; i++) {
-        rawStateTransition.addPublicKeys.push(publicKeyToAdd);
+        rawStateTransition.addPublicKeys.push({ ...publicKeyToAdd, id: i + 1 });
       }
 
       const result = await validateIdentityUpdateTransitionBasic(
         rawStateTransition,
       );
 
-      expectJsonSchemaError(result);
+      await expectJsonSchemaError(result);
 
       const [error] = result.getErrors();
 
@@ -366,7 +375,7 @@ describe('validateIdentityUpdateTransitionBasicFactory', () => {
         rawStateTransition,
       );
 
-      expectJsonSchemaError(result);
+      await expectJsonSchemaError(result);
 
       const [error] = result.getErrors();
 
@@ -375,47 +384,32 @@ describe('validateIdentityUpdateTransitionBasicFactory', () => {
     });
 
     it('should be valid', async () => {
-      rawStateTransition.addPublicKeys = [publicKeyToAdd];
+      const keyWithDupeId = { ...publicKeyToAdd, data: Buffer.alloc(33) };
 
-      const publicKeysError = new SomeConsensusError('test');
-      const publicKeysResult = new ValidationResult([
-        publicKeysError,
+      stateTransition.setPublicKeysToAdd([
+        new IdentityPublicKeyCreateTransition(publicKeyToAdd),
+        new IdentityPublicKeyCreateTransition(keyWithDupeId),
       ]);
 
-      validatePublicKeysMock.returns(publicKeysResult);
+      rawStateTransition = stateTransition.toObject();
 
       const result = await validateIdentityUpdateTransitionBasic(
         rawStateTransition,
       );
 
-      expectValidationError(result);
-
-      const [error] = result.getErrors();
-
-      expect(error).to.equal(publicKeysError);
-
-      expect(validatePublicKeysMock).to.be.calledOnceWithExactly(
-        rawStateTransition.addPublicKeys,
-      );
+      await expectValidationError(result, DuplicatedIdentityPublicKeyIdStateError);
     });
 
     it('should have valid signatures', async () => {
-      const publicKeysError = new SomeConsensusError('test');
-      const publicKeysResult = new ValidationResult([
-        publicKeysError,
-      ]);
-
-      validatePublicKeySignaturesMock.resolves(publicKeysResult);
+      const invalidSignature = Buffer.alloc(65);
+      rawStateTransition.signature = invalidSignature;
+      rawStateTransition.addPublicKeys[0].signature = invalidSignature;
 
       const result = await validateIdentityUpdateTransitionBasic(
         rawStateTransition,
       );
 
-      expectValidationError(result);
-
-      const [error] = result.getErrors();
-
-      expect(error).to.equal(publicKeysError);
+      await expectValidationError(result, InvalidIdentityKeySignatureError);
     });
   });
 
@@ -431,11 +425,11 @@ describe('validateIdentityUpdateTransitionBasicFactory', () => {
         rawStateTransition,
       );
 
-      expectJsonSchemaError(result);
+      await expectJsonSchemaError(result);
 
       const [error] = result.getErrors();
-      expect(error.getKeyword()).to.equal('dependentRequired');
-      expect(error.params.missingProperty).to.equal('publicKeysDisabledAt');
+      expect(error.getKeyword()).to.equal('required');
+      expect(error.getParams().missingProperty).to.equal('publicKeysDisabledAt');
     });
 
     it('should be valid', async () => {
@@ -457,7 +451,7 @@ describe('validateIdentityUpdateTransitionBasicFactory', () => {
         rawStateTransition,
       );
 
-      expectJsonSchemaError(result);
+      await expectJsonSchemaError(result);
 
       const [error] = result.getErrors();
 
@@ -473,7 +467,7 @@ describe('validateIdentityUpdateTransitionBasicFactory', () => {
         rawStateTransition,
       );
 
-      expectJsonSchemaError(result);
+      await expectJsonSchemaError(result);
 
       const [error] = result.getErrors();
 
@@ -489,7 +483,7 @@ describe('validateIdentityUpdateTransitionBasicFactory', () => {
         rawStateTransition,
       );
 
-      expectJsonSchemaError(result);
+      await expectJsonSchemaError(result);
 
       const [error] = result.getErrors();
 
@@ -505,7 +499,7 @@ describe('validateIdentityUpdateTransitionBasicFactory', () => {
         rawStateTransition,
       );
 
-      expectJsonSchemaError(result);
+      await expectJsonSchemaError(result);
 
       const [error] = result.getErrors();
 
@@ -522,11 +516,11 @@ describe('validateIdentityUpdateTransitionBasicFactory', () => {
         rawStateTransition,
       );
 
-      expectJsonSchemaError(result);
+      await expectJsonSchemaError(result);
 
       const [error] = result.getErrors();
-      expect(error.getKeyword()).to.equal('dependentRequired');
-      expect(error.params.missingProperty).to.equal('disablePublicKeys');
+      expect(error.getKeyword()).to.equal('required');
+      expect(error.getParams().missingProperty).to.equal('disablePublicKeys');
     });
 
     it('should be integer', async () => {
@@ -537,7 +531,7 @@ describe('validateIdentityUpdateTransitionBasicFactory', () => {
         rawStateTransition,
       );
 
-      expectJsonSchemaError(result);
+      await expectJsonSchemaError(result);
 
       const [error] = result.getErrors();
 
@@ -553,7 +547,7 @@ describe('validateIdentityUpdateTransitionBasicFactory', () => {
         rawStateTransition,
       );
 
-      expectJsonSchemaError(result);
+      await expectJsonSchemaError(result);
 
       const [error] = result.getErrors();
 
@@ -566,11 +560,6 @@ describe('validateIdentityUpdateTransitionBasicFactory', () => {
     const result = await validateIdentityUpdateTransitionBasic(rawStateTransition);
 
     expect(result.isValid()).to.be.true();
-
-    expect(validatePublicKeysMock)
-      .to.be.calledOnceWithExactly(
-        rawStateTransition.addPublicKeys,
-      );
   });
 
   it('should have either addPublicKeys or disablePublicKeys', async () => {
@@ -580,16 +569,10 @@ describe('validateIdentityUpdateTransitionBasicFactory', () => {
 
     const result = await validateIdentityUpdateTransitionBasic(rawStateTransition);
 
-    expectJsonSchemaError(result, 3);
+    await expectJsonSchemaError(result, 1);
 
-    const [addPublicKeysError, disablePublicKeysError, error] = result.getErrors();
+    const [error] = result.getErrors();
 
     expect(error.getKeyword()).to.equal('anyOf');
-
-    expect(disablePublicKeysError.schemaPath).to.equal('#/anyOf/1/required');
-    expect(disablePublicKeysError.getKeyword()).to.equal('required');
-
-    expect(addPublicKeysError.schemaPath).to.equal('#/anyOf/0/required');
-    expect(addPublicKeysError.getKeyword()).to.equal('required');
   });
 });