@dalzoubi/dev-agents-sync 2.0.24 → 2.0.26

package/tests/rules-injector-runtime.test.mjs

@@ -1,313 +0,0 @@
-/**
- * tests/rules-injector-runtime.test.mjs
- *
- * Slice S2 — SessionStart rules-injector.sh hook (runtime behavior half).
- * Spec: docs/specs/260708-claude-rules-enforcement/
- *
- * Pins the runtime behavior of the shipped `.claude/hooks/rules-injector.sh`
- * script (mirrored from the canonical `.agents/hooks/rules-injector.sh`, which
- * does not exist yet — these tests are the RED anchor for that build step).
- * Follows the steering-injector.sh convention: the hook is invoked with the
- * consumer repo root as its cwd and looks for its inputs relative to that cwd,
- * so we exercise it against an isolated tmp fixture dir rather than depending
- * on this repo's real `.claude/rules/` contents (which may change).
- *
- * Behavior anchors:
- *
- *  T1. Executing the script against a fixture dir containing
- *      `.claude/rules/structured-choices.md` and `.claude/rules/tone.md`
- *      emits both rule BODIES to stdout, with the YAML frontmatter and the
- *      `<!-- managed-by: ... -->` marker line stripped.
- *  T2. The script exits 0 on that happy path.
- *  T3. When one rule file is absent, the script still exits 0 (fail-safe),
- *      emits at most a stderr note, and still surfaces the present rule's body.
- *  T4. When both rule files are absent (no .claude/rules/ dir at all), the
- *      script still exits 0.
- *
- * Test runner: `node --test packages/dev-agents-sync/tests/rules-injector-runtime.test.mjs`
- * No third-party dependencies. All tests use isolated tmp dirs; none of them
- * depend on this repo's actual `.claude/rules/*.md` content.
- */
-
-import { describe, it, beforeEach, afterEach } from 'node:test';
-import assert from 'node:assert/strict';
-import { spawnSync } from 'node:child_process';
-import { mkdtempSync, mkdirSync, writeFileSync, rmSync } from 'node:fs';
-import { tmpdir } from 'node:os';
-import path from 'node:path';
-import { fileURLToPath } from 'node:url';
-
-// ---------------------------------------------------------------------------
-// Paths
-// ---------------------------------------------------------------------------
-
-const __dirname = path.dirname(fileURLToPath(import.meta.url));
-// packages/dev-agents-sync/tests -> packages/dev-agents-sync -> packages -> repo root
-const REPO_ROOT = path.resolve(__dirname, '..', '..', '..');
-const SCRIPT_PATH = path.join(REPO_ROOT, '.claude', 'hooks', 'rules-injector.sh');
-
-// ---------------------------------------------------------------------------
-// Fixture content — self-contained, does NOT depend on this repo's actual
-// .claude/rules/*.md bodies so the test stays stable if those rules are edited.
-// ---------------------------------------------------------------------------
-
-const STRUCTURED_CHOICES_BODY_MARKER = 'FIXTURE_STRUCTURED_CHOICES_BODY_9f3a1';
-const TONE_BODY_MARKER = 'FIXTURE_TONE_BODY_7c22e';
-const FRONTMATTER_NAME_MARKER = 'name: "structured-choices"';
-const MARKDOWN_MANAGED_MARKER = '<!-- managed-by: dev-agents-sync v0.1.0 -->';
-
-function structuredChoicesFixture() {
-  return [
-    '---',
-    'name: "structured-choices"',
-    'description: "fixture rule for rules-injector runtime tests"',
-    '---',
-    MARKDOWN_MANAGED_MARKER,
-    '# Structured choices',
-    '',
-    STRUCTURED_CHOICES_BODY_MARKER,
-    '',
-  ].join('\n');
-}
-
-function toneFixture() {
-  return [
-    '---',
-    'name: "tone"',
-    'description: "fixture rule for rules-injector runtime tests"',
-    '---',
-    MARKDOWN_MANAGED_MARKER,
-    '# Tone',
-    '',
-    TONE_BODY_MARKER,
-    '',
-  ].join('\n');
-}
-
-function makeTmpDir() {
-  return mkdtempSync(path.join(tmpdir(), 'das-rules-injector-runtime-test-'));
-}
-
-/** Runs the shipped rules-injector.sh with `cwd` as its working directory. */
-function runScript(cwd) {
-  return spawnSync('sh', [SCRIPT_PATH], { cwd, encoding: 'utf8' });
-}
-
-let fixtureDir;
-
-// ---------------------------------------------------------------------------
-// T1/T2 — happy path: both rules present
-// ---------------------------------------------------------------------------
-
-describe('S2 T1/T2 — rules-injector.sh emits both rule bodies, exits 0', () => {
-  beforeEach(() => {
-    fixtureDir = makeTmpDir();
-    const rulesDir = path.join(fixtureDir, '.claude', 'rules');
-    mkdirSync(rulesDir, { recursive: true });
-    writeFileSync(path.join(rulesDir, 'structured-choices.md'), structuredChoicesFixture(), 'utf8');
-    writeFileSync(path.join(rulesDir, 'tone.md'), toneFixture(), 'utf8');
-  });
-
-  afterEach(() => {
-    rmSync(fixtureDir, { recursive: true, force: true });
-  });
-
-  it('T2: exits 0 when both rule files are present', () => {
-    const result = runScript(fixtureDir);
-    assert.equal(
-      result.status,
-      0,
-      `rules-injector.sh must exit 0 on the happy path; got status=${result.status}, stderr=${result.stderr}, error=${result.error}`,
-    );
-  });
-
-  it('T1a: stdout includes the structured-choices.md body', () => {
-    const result = runScript(fixtureDir);
-    assert.ok(
-      (result.stdout ?? '').includes(STRUCTURED_CHOICES_BODY_MARKER),
-      `stdout must include the structured-choices.md body; got stdout=${JSON.stringify(result.stdout)}`,
-    );
-  });
-
-  it('T1b: stdout includes the tone.md body', () => {
-    const result = runScript(fixtureDir);
-    assert.ok(
-      (result.stdout ?? '').includes(TONE_BODY_MARKER),
-      `stdout must include the tone.md body; got stdout=${JSON.stringify(result.stdout)}`,
-    );
-  });
-
-  it('T1c: stdout strips the YAML frontmatter (no "name:" front-matter key leaks through)', () => {
-    const result = runScript(fixtureDir);
-    const stdout = result.stdout ?? '';
-    // Anchored to the body actually being emitted — otherwise "frontmatter is
-    // absent" would pass vacuously against empty stdout (e.g. the script not
-    // existing yet) without proving anything about stripping behavior.
-    assert.ok(
-      stdout.includes(STRUCTURED_CHOICES_BODY_MARKER),
-      `precondition failed: stdout must carry the rule body before frontmatter-stripping can be checked; got stdout=${JSON.stringify(stdout)}`,
-    );
-    assert.ok(
-      !stdout.includes(FRONTMATTER_NAME_MARKER),
-      `stdout must not include raw frontmatter (${FRONTMATTER_NAME_MARKER}); got stdout=${JSON.stringify(stdout)}`,
-    );
-  });
-
-  it('T1d: stdout strips the managed-by marker line', () => {
-    const result = runScript(fixtureDir);
-    const stdout = result.stdout ?? '';
-    // Same anchoring as T1c: require the body to be present so this cannot
-    // pass vacuously against empty output.
-    assert.ok(
-      stdout.includes(TONE_BODY_MARKER),
-      `precondition failed: stdout must carry the rule body before marker-stripping can be checked; got stdout=${JSON.stringify(stdout)}`,
-    );
-    assert.ok(
-      !stdout.includes(MARKDOWN_MANAGED_MARKER),
-      `stdout must not include the raw managed-by marker line; got stdout=${JSON.stringify(stdout)}`,
-    );
-  });
-});
-
-// ---------------------------------------------------------------------------
-// T3 — fail-safe: one rule file absent
-// ---------------------------------------------------------------------------
-
-describe('S2 T3 — rules-injector.sh is fail-safe when one rule file is absent', () => {
-  beforeEach(() => {
-    fixtureDir = makeTmpDir();
-    const rulesDir = path.join(fixtureDir, '.claude', 'rules');
-    mkdirSync(rulesDir, { recursive: true });
-    // Only tone.md exists; structured-choices.md is missing.
-    writeFileSync(path.join(rulesDir, 'tone.md'), toneFixture(), 'utf8');
-  });
-
-  afterEach(() => {
-    rmSync(fixtureDir, { recursive: true, force: true });
-  });
-
-  it('T3a: still exits 0 when structured-choices.md is absent', () => {
-    const result = runScript(fixtureDir);
-    assert.equal(
-      result.status,
-      0,
-      `rules-injector.sh must exit 0 even when a rule file is absent (fail-safe); got status=${result.status}, stderr=${result.stderr}, error=${result.error}`,
-    );
-  });
-
-  it('T3b: still surfaces the present rule (tone.md) body on stdout', () => {
-    const result = runScript(fixtureDir);
-    assert.ok(
-      (result.stdout ?? '').includes(TONE_BODY_MARKER),
-      `stdout must still include the present tone.md body; got stdout=${JSON.stringify(result.stdout)}`,
-    );
-  });
-
-  it('T3c: emits at most a stderr note about the missing rule (does not crash silently on stdout)', () => {
-    const result = runScript(fixtureDir);
-    const stdout = result.stdout ?? '';
-    // Anchored to exit 0 + the present rule's body actually being emitted —
-    // otherwise "no fabricated content" would pass vacuously (e.g. against
-    // empty stdout from a script that doesn't exist yet or crashed outright)
-    // without proving the fail-safe skip behavior.
-    assert.equal(
-      result.status,
-      0,
-      `precondition failed: script must exit 0 before the fail-safe skip behavior can be checked; got status=${result.status}`,
-    );
-    assert.ok(
-      stdout.includes(TONE_BODY_MARKER),
-      `precondition failed: stdout must carry the present rule's body before checking the missing rule was skipped cleanly; got stdout=${JSON.stringify(stdout)}`,
-    );
-    // "at most a stderr note" — we don't require stderr, but if the script
-    // emits anything about the skip, it must go to stderr, not stdout, and
-    // must not fabricate content for the missing rule on stdout.
-    assert.ok(
-      !stdout.includes('structured-choices'),
-      `stdout must not fabricate content for the missing structured-choices.md; got stdout=${JSON.stringify(stdout)}`,
-    );
-  });
-});
-
-// ---------------------------------------------------------------------------
-// T5 — CRLF robustness: frontmatter fences with a trailing CR are still stripped
-// (regression anchor for M1 — the awk fence match must tolerate `---\r`, else
-// on a CRLF checkout the whole YAML frontmatter leaks into injected context).
-// ---------------------------------------------------------------------------
-
-describe('S2 T5 — rules-injector.sh strips frontmatter on a CRLF checkout', () => {
-  beforeEach(() => {
-    fixtureDir = makeTmpDir();
-    const rulesDir = path.join(fixtureDir, '.claude', 'rules');
-    mkdirSync(rulesDir, { recursive: true });
-    // Re-encode both fixtures with CRLF line endings, as a CRLF checkout would.
-    const toCRLF = (s) => s.replace(/\n/g, '\r\n');
-    writeFileSync(path.join(rulesDir, 'structured-choices.md'), toCRLF(structuredChoicesFixture()), 'utf8');
-    writeFileSync(path.join(rulesDir, 'tone.md'), toCRLF(toneFixture()), 'utf8');
-  });
-
-  afterEach(() => {
-    rmSync(fixtureDir, { recursive: true, force: true });
-  });
-
-  it('T5a: exits 0 and still emits the rule bodies on a CRLF checkout', () => {
-    const result = runScript(fixtureDir);
-    assert.equal(
-      result.status,
-      0,
-      `rules-injector.sh must exit 0 on a CRLF checkout; got status=${result.status}, stderr=${result.stderr}, error=${result.error}`,
-    );
-    assert.ok(
-      (result.stdout ?? '').includes(STRUCTURED_CHOICES_BODY_MARKER),
-      `stdout must still include the structured-choices.md body on a CRLF checkout; got stdout=${JSON.stringify(result.stdout)}`,
-    );
-  });
-
-  it('T5b: strips the CRLF frontmatter (no "name:" key and no bare "---" fence leaks)', () => {
-    const result = runScript(fixtureDir);
-    const stdout = result.stdout ?? '';
-    // Anchor to the body actually being emitted, so this cannot pass vacuously.
-    assert.ok(
-      stdout.includes(STRUCTURED_CHOICES_BODY_MARKER),
-      `precondition failed: stdout must carry the rule body before frontmatter-stripping can be checked; got stdout=${JSON.stringify(stdout)}`,
-    );
-    assert.ok(
-      !stdout.includes(FRONTMATTER_NAME_MARKER),
-      `stdout must not leak raw frontmatter (${FRONTMATTER_NAME_MARKER}) on a CRLF checkout; got stdout=${JSON.stringify(stdout)}`,
-    );
-    // No line should be a bare YAML fence (with or without a trailing CR).
-    assert.ok(
-      !/^---\r?$/m.test(stdout),
-      `stdout must not leak a bare "---" frontmatter fence on a CRLF checkout; got stdout=${JSON.stringify(stdout)}`,
-    );
-    // The managed-by marker must also be gone even with the trailing CR.
-    assert.ok(
-      !stdout.includes(MARKDOWN_MANAGED_MARKER),
-      `stdout must not leak the managed-by marker line on a CRLF checkout; got stdout=${JSON.stringify(stdout)}`,
-    );
-  });
-});
-
-// ---------------------------------------------------------------------------
-// T4 — fail-safe: no .claude/rules/ directory at all
-// ---------------------------------------------------------------------------
-
-describe('S2 T4 — rules-injector.sh is fail-safe when no rule files exist', () => {
-  beforeEach(() => {
-    fixtureDir = makeTmpDir();
-    // Deliberately do NOT create .claude/rules/ at all.
-  });
-
-  afterEach(() => {
-    rmSync(fixtureDir, { recursive: true, force: true });
-  });
-
-  it('T4: exits 0 when .claude/rules/ does not exist', () => {
-    const result = runScript(fixtureDir);
-    assert.equal(
-      result.status,
-      0,
-      `rules-injector.sh must exit 0 when .claude/rules/ is entirely absent; got status=${result.status}, stderr=${result.stderr}, error=${result.error}`,
-    );
-  });
-});