@dalzoubi/dev-agents-sync 2.0.24 → 2.0.26

package/tests/hooks-cli-install.test.mjs

@@ -1210,6 +1210,73 @@ describe('S4 H10 — malformed settings.json triggers ESETTINGS_PARSE (no write)
       'mergeHookSettings must leave malformed settings.json byte-identical (no partial write)',
     );
   });
+
+  // -------------------------------------------------------------------------
+  // S1 cycle 3, L6 (Group A — regression guard): before cycle 2, --dry-run
+  // never read settings.json at all; now update.mjs's dry-run branch computes
+  // the planned hook-registration prune (update.mjs:196-202), which means it
+  // calls mergeHookSettings -> readSettings on every dry run. A malformed file
+  // now turns `update --dry-run` from a clean exit 0 into a thrown
+  // ESETTINGS_PARSE — an unstated contract change (the better posture per §5:
+  // a dry run should predict the real failure) that only the H10a/H10b
+  // non-dry-run cases above pinned before this test.
+  // -------------------------------------------------------------------------
+
+  it('H10e: update --dry-run fails loud with ESETTINGS_PARSE when settings.json is invalid JSON', async () => {
+    setupInitializedRepo(consumerDir, { resolvedVersion: '1.0.0' });
+
+    const settingsPath = path.join(consumerDir, '.claude', 'settings.json');
+    mkdirSync(path.dirname(settingsPath), { recursive: true });
+    writeFileSync(settingsPath, '{not: valid JSON}}', 'utf8');
+
+    let thrownError = null;
+    try {
+      await runUpdate(consumerDir, {
+        dryRun: true,
+        fetcher: makeFixtureFetcher(),
+        availableTags: ['v1.0.0', 'v1.2.0'],
+      });
+    } catch (err) {
+      thrownError = err;
+    }
+
+    assert.ok(
+      thrownError !== null,
+      'update --dry-run must throw when settings.json is malformed JSON — a dry run that ' +
+        'returns cleanly while the real run would fail is a broken prediction (§5)',
+    );
+    assert.ok(
+      thrownError.code === 'ESETTINGS_PARSE' ||
+        (thrownError.message && /ESETTINGS_PARSE/i.test(thrownError.message)),
+      `error must carry code ESETTINGS_PARSE; got code=${thrownError?.code} message=${thrownError?.message}`,
+    );
+  });
+
+  it('H10f: update --dry-run leaves malformed settings.json byte-identical (no partial write)', async () => {
+    setupInitializedRepo(consumerDir, { resolvedVersion: '1.0.0' });
+
+    const settingsPath = path.join(consumerDir, '.claude', 'settings.json');
+    mkdirSync(path.dirname(settingsPath), { recursive: true });
+    const malformed = '{not: valid JSON}}';
+    writeFileSync(settingsPath, malformed, 'utf8');
+
+    try {
+      await runUpdate(consumerDir, {
+        dryRun: true,
+        fetcher: makeFixtureFetcher(),
+        availableTags: ['v1.0.0', 'v1.2.0'],
+      });
+    } catch {
+      // Expected — swallow the error for the preservation check.
+    }
+
+    const after = readFileSync(settingsPath, 'utf8');
+    assert.equal(
+      after,
+      malformed,
+      'malformed settings.json must remain unmodified after a failed --dry-run update (no partial write)',
+    );
+  });
 });
 
 // ---------------------------------------------------------------------------