@dainamite/cpq 0.6.0 → 0.7.0

package/src/modules/cpq/backend/cpq/pricing/[id]/page.tsx

@@ -66,7 +66,7 @@ export default function PricingTableDetailPage(props: { params?: { id?: string }
   const load = React.useCallback(async () => {
     if (isNew) return
     if (!id || !UUID_RE.test(id)) {
-      setError('Invalid pricing table ID')
+      setError(t('cpq.pricing.detail.errors.invalidId', 'Invalid pricing table ID'))
       setLoading(false)
       return
     }
@@ -74,7 +74,7 @@ export default function PricingTableDetailPage(props: { params?: { id?: string }
     try {
       const res = await fetch(`/api/cpq/pricing-tables?id=${encodeURIComponent(id)}`)
       if (!res.ok) {
-        setError('Pricing table not found')
+        setError(t('cpq.pricing.detail.errors.notFound', 'Pricing table not found'))
         return
       }
       const data = await res.json()
@@ -92,11 +92,11 @@ export default function PricingTableDetailPage(props: { params?: { id?: string }
       setEntries(data.entries ?? [])
     } catch (err) {
       console.error('Failed to load pricing table', err)
-      setError('Failed to load')
+      setError(t('cpq.pricing.detail.errors.loadFailed', 'Failed to load'))
     } finally {
       setLoading(false)
     }
-  }, [id, isNew])
+  }, [id, isNew, t])
 
   React.useEffect(() => {
     void load()
@@ -123,22 +123,46 @@ export default function PricingTableDetailPage(props: { params?: { id?: string }
   // Mirror V-PT-1 from validators.ts so the user gets feedback before the
   // server rejects the payload.
   const configValidationError = React.useMemo(() => {
-    if (!draft.code.trim()) return 'Code is required'
-    if (!draft.name.trim()) return 'Name is required'
-    if (draft.currencyCodeList.length === 0) return 'At least one currency is required'
-    const checkList = (items: Array<{ key: string; label: string }>, label: string): string | null => {
+    if (!draft.code.trim()) return t('cpq.pricing.validation.codeRequired', 'Code is required')
+    if (!draft.name.trim()) return t('cpq.pricing.validation.nameRequired', 'Name is required')
+    if (draft.currencyCodeList.length === 0) {
+      return t('cpq.pricing.validation.currencyRequired', 'At least one currency is required')
+    }
+    type ListMessages = {
+      keyRequired: (index: number) => string
+      labelRequired: (index: number) => string
+      duplicateKey: (key: string) => string
+    }
+    const checkList = (items: Array<{ key: string; label: string }>, messages: ListMessages): string | null => {
       const seen = new Set<string>()
       for (let i = 0; i < items.length; i++) {
         const item = items[i]
-        if (!item.key.trim()) return `${label} #${i + 1}: key is required`
-        if (!item.label.trim()) return `${label} #${i + 1}: label is required`
-        if (seen.has(item.key)) return `${label}: duplicate key "${item.key}"`
+        if (!item.key.trim()) return messages.keyRequired(i + 1)
+        if (!item.label.trim()) return messages.labelRequired(i + 1)
+        if (seen.has(item.key)) return messages.duplicateKey(item.key)
         seen.add(item.key)
       }
       return null
     }
-    return checkList(draft.dimensions, 'Dimension') ?? checkList(draft.priceColumns, 'Price Column')
-  }, [draft])
+    return (
+      checkList(draft.dimensions, {
+        keyRequired: (index) =>
+          t('cpq.pricing.validation.dimensionKeyRequired', 'Dimension #{index}: key is required', { index }),
+        labelRequired: (index) =>
+          t('cpq.pricing.validation.dimensionLabelRequired', 'Dimension #{index}: label is required', { index }),
+        duplicateKey: (key) =>
+          t('cpq.pricing.validation.dimensionDuplicateKey', 'Dimension: duplicate key "{key}"', { key }),
+      }) ??
+      checkList(draft.priceColumns, {
+        keyRequired: (index) =>
+          t('cpq.pricing.validation.priceColumnKeyRequired', 'Price Column #{index}: key is required', { index }),
+        labelRequired: (index) =>
+          t('cpq.pricing.validation.priceColumnLabelRequired', 'Price Column #{index}: label is required', { index }),
+        duplicateKey: (key) =>
+          t('cpq.pricing.validation.priceColumnDuplicateKey', 'Price Column: duplicate key "{key}"', { key }),
+      })
+    )
+  }, [draft, t])
 
   const saveConfig = async () => {
     if (configValidationError) {
@@ -163,7 +187,12 @@ export default function PricingTableDetailPage(props: { params?: { id?: string }
       })
       if (!res.ok) {
         const body = await res.json().catch(() => ({}))
-        setError(body.error ?? `Failed to ${isNew ? 'create' : 'save'} pricing table`)
+        setError(
+          body.error ??
+            (isNew
+              ? t('cpq.pricing.detail.errors.createFailed', 'Failed to create pricing table')
+              : t('cpq.pricing.detail.errors.saveFailed', 'Failed to save pricing table')),
+        )
         return
       }
       const saved = await res.json()
@@ -175,7 +204,7 @@ export default function PricingTableDetailPage(props: { params?: { id?: string }
       }
     } catch (err) {
       console.error('Failed to save', err)
-      setError('Failed to save')
+      setError(t('cpq.pricing.detail.errors.saveFailedGeneric', 'Failed to save'))
     } finally {
       setSaving(false)
     }
@@ -193,6 +222,7 @@ export default function PricingTableDetailPage(props: { params?: { id?: string }
         currencyCodeList: table.currencyCodeList,
       },
       entries,
+      t,
     )
     if (!r.ok) {
       setError(r.error)
@@ -206,7 +236,7 @@ export default function PricingTableDetailPage(props: { params?: { id?: string }
     setImportApplying(true)
     setError(null)
     try {
-      const r = await commitImportDiff(table.id, importDiff)
+      const r = await commitImportDiff(table.id, importDiff, t)
       if (!r.ok) {
         setError(r.error)
         return
@@ -235,17 +265,17 @@ export default function PricingTableDetailPage(props: { params?: { id?: string }
         router.push('/backend/cpq/pricing')
       } else {
         const body = await res.json().catch(() => ({}))
-        setError(body.error ?? 'Failed to delete')
+        setError(body.error ?? t('cpq.pricing.detail.errors.deleteFailed', 'Failed to delete'))
       }
     } catch {
-      setError('Failed to delete')
+      setError(t('cpq.pricing.detail.errors.deleteFailed', 'Failed to delete'))
     }
   }
 
   // ─── Render ────────────────────────────────────────────────
 
   if (loading) {
-    return <div className="text-sm text-muted-foreground">{t('common.loading', 'Loading...')}</div>
+    return <div className="text-sm text-muted-foreground">{t('cpq.common.loading', 'Loading...')}</div>
   }
 
   if (error && !isNew && !table.id) {
@@ -255,7 +285,7 @@ export default function PricingTableDetailPage(props: { params?: { id?: string }
           onClick={() => router.push('/backend/cpq/pricing')}
           className="text-sm text-muted-foreground hover:text-foreground"
         >
-          ← {t('common.back', 'Back')}
+          ← {t('cpq.common.back', 'Back')}
         </button>
         <Alert variant="destructive">{error}</Alert>
       </div>
@@ -274,14 +304,14 @@ export default function PricingTableDetailPage(props: { params?: { id?: string }
             onClick={() => router.push('/backend/cpq/pricing')}
             className="text-sm text-muted-foreground hover:text-foreground"
           >
-            ← {t('common.back', 'Back')}
+            ← {t('cpq.common.back', 'Back')}
           </button>
           <h1 className="text-2xl font-bold">
             {isNew ? t('cpq.pricing.new', 'New Pricing Table') : table.name}
           </h1>
           {!isNew && (
             <Tag variant={table.isActive ? 'success' : 'neutral'} dot>
-              {table.isActive ? t('common.active', 'Active') : t('common.inactive', 'Inactive')}
+              {table.isActive ? t('cpq.common.active', 'Active') : t('cpq.common.inactive', 'Inactive')}
             </Tag>
           )}
         </div>
@@ -318,9 +348,9 @@ export default function PricingTableDetailPage(props: { params?: { id?: string }
                 e.target.value = ''
               }}
             />
-            <Button type="button" onClick={startEdit}>{t('common.edit', 'Edit')}</Button>
+            <Button type="button" onClick={startEdit}>{t('cpq.common.edit', 'Edit')}</Button>
             <Button type="button" variant="destructive" onClick={deleteTable}>
-              {t('common.delete', 'Delete')}
+              {t('cpq.common.delete', 'Delete')}
             </Button>
           </div>
         )}
@@ -340,32 +370,32 @@ export default function PricingTableDetailPage(props: { params?: { id?: string }
 
       {/* Configuration section */}
       <div className="rounded-lg border bg-card p-6 space-y-4">
-        <h2 className="text-lg font-semibold">Configuration</h2>
+        <h2 className="text-lg font-semibold">{t('cpq.pricing.detail.configuration', 'Configuration')}</h2>
 
         <div className="grid grid-cols-1 md:grid-cols-2 gap-4">
-          <ConfigField label="Code" required>
+          <ConfigField label={t('cpq.pricing.code', 'Code')} required>
             {editing ? (
               <Input
                 value={view.code}
                 onChange={(e) => setDraft({ ...draft, code: e.target.value })}
-                placeholder="e.g. cloud-connect-pricing"
+                placeholder={t('cpq.pricing.detail.codePlaceholder', 'e.g. cloud-connect-pricing')}
               />
             ) : (
               <span className="font-mono text-sm">{view.code}</span>
             )}
           </ConfigField>
-          <ConfigField label="Name" required>
+          <ConfigField label={t('cpq.pricing.name', 'Name')} required>
             {editing ? (
               <Input
                 value={view.name}
                 onChange={(e) => setDraft({ ...draft, name: e.target.value })}
-                placeholder="Cloud Connect Pricing"
+                placeholder={t('cpq.pricing.detail.namePlaceholder', 'Cloud Connect Pricing')}
               />
             ) : (
               <span className="font-medium text-sm">{view.name}</span>
             )}
           </ConfigField>
-          <ConfigField label="Currencies (comma-separated)" required>
+          <ConfigField label={t('cpq.pricing.detail.currenciesCommaSeparated', 'Currencies (comma-separated)')} required>
             {editing ? (
               <Input
                 value={view.currencyCodeList.join(', ')}
@@ -378,13 +408,13 @@ export default function PricingTableDetailPage(props: { params?: { id?: string }
                       .filter(Boolean),
                   })
                 }
-                placeholder="USD, EUR"
+                placeholder={t('cpq.pricing.detail.currenciesPlaceholder', 'USD, EUR')}
               />
             ) : (
               <span className="text-sm">{view.currencyCodeList.join(', ') || '—'}</span>
             )}
           </ConfigField>
-          <ConfigField label="Active">
+          <ConfigField label={t('cpq.common.active', 'Active')}>
             {editing ? (
               <label className="flex items-center gap-2 text-sm">
                 <input
@@ -393,25 +423,33 @@ export default function PricingTableDetailPage(props: { params?: { id?: string }
                   onChange={(e) => setDraft({ ...draft, isActive: e.target.checked })}
                   className="rounded border"
                 />
-                {view.isActive ? 'Yes' : 'No'}
+                {view.isActive ? t('cpq.common.yes', 'Yes') : t('cpq.common.no', 'No')}
               </label>
             ) : (
-              <span className="text-sm">{view.isActive ? 'Yes' : 'No'}</span>
+              <span className="text-sm">{view.isActive ? t('cpq.common.yes', 'Yes') : t('cpq.common.no', 'No')}</span>
             )}
           </ConfigField>
         </div>
 
         <KeyLabelListEditor
-          title="Dimensions"
-          description="Lookup keys for matching entries (e.g. region, tier). Leave empty if you use tier ranges only."
+          title={t('cpq.pricing.detail.dimensions.title', 'Dimensions')}
+          description={t(
+            'cpq.pricing.detail.dimensions.description',
+            'Lookup keys for matching entries (e.g. region, tier). Leave empty if you use tier ranges only.',
+          )}
+          addLabel={t('cpq.pricing.detail.dimensions.add', '+ Add Dimension')}
           items={view.dimensions}
           editing={editing}
           onChange={(dimensions) => setDraft({ ...draft, dimensions })}
         />
 
         <KeyLabelListEditor
-          title="Price Columns"
-          description="Each price column becomes a numeric field on every entry. Charges reference one column by its key."
+          title={t('cpq.pricing.priceColumns', 'Price Columns')}
+          description={t(
+            'cpq.pricing.detail.priceColumns.description',
+            'Each price column becomes a numeric field on every entry. Charges reference one column by its key.',
+          )}
+          addLabel={t('cpq.pricing.detail.priceColumns.add', '+ Add Price Column')}
           items={view.priceColumns}
           editing={editing}
           onChange={(priceColumns) => setDraft({ ...draft, priceColumns })}
@@ -428,10 +466,14 @@ export default function PricingTableDetailPage(props: { params?: { id?: string }
                 onClick={saveConfig}
                 disabled={saving || configValidationError !== null}
               >
-                {saving ? 'Saving...' : (isNew ? 'Create Pricing Table' : 'Save')}
+                {saving
+                  ? t('cpq.common.saving', 'Saving...')
+                  : isNew
+                    ? t('cpq.pricing.detail.create', 'Create Pricing Table')
+                    : t('cpq.common.save', 'Save')}
               </Button>
               <Button type="button" variant="outline" onClick={cancelEdit} disabled={saving}>
-                Cancel
+                {t('cpq.common.cancel', 'Cancel')}
               </Button>
             </div>
           </>
@@ -484,16 +526,20 @@ function ConfigField({
 function KeyLabelListEditor({
   title,
   description,
+  addLabel,
   items,
   editing,
   onChange,
 }: {
   title: string
   description: string
+  /** Translated "+ Add …" button text, supplied by the caller. */
+  addLabel: string
   items: Array<{ key: string; label: string }>
   editing: boolean
   onChange: (next: Array<{ key: string; label: string }>) => void
 }) {
+  const t = useT()
   return (
     <div className="space-y-2">
       <div>
@@ -511,12 +557,14 @@ function KeyLabelListEditor({
             <thead>
               <tr className="border-b bg-muted/30 text-xs">
                 <th className="px-3 py-2 text-left font-medium">
-                  Key {editing && <span className="text-destructive">*</span>}
+                  {t('cpq.pricing.detail.keyLabelList.key', 'Key')}{' '}
+                  {editing && <span className="text-destructive">*</span>}
                 </th>
                 <th className="px-3 py-2 text-left font-medium">
-                  Label {editing && <span className="text-destructive">*</span>}
+                  {t('cpq.pricing.detail.keyLabelList.label', 'Label')}{' '}
+                  {editing && <span className="text-destructive">*</span>}
                 </th>
-                {editing && <th className="px-3 py-2 w-8" aria-label="Actions" />}
+                {editing && <th className="px-3 py-2 w-8" aria-label={t('cpq.pricing.detail.keyLabelList.actions', 'Actions')} />}
               </tr>
             </thead>
             <tbody>
@@ -531,7 +579,7 @@ function KeyLabelListEditor({
                           next[idx] = { ...item, key: e.target.value }
                           onChange(next)
                         }}
-                        placeholder="e.g. region"
+                        placeholder={t('cpq.pricing.detail.keyLabelList.keyPlaceholder', 'e.g. region')}
                         className="h-8"
                       />
                     ) : (
@@ -547,7 +595,7 @@ function KeyLabelListEditor({
                           next[idx] = { ...item, label: e.target.value }
                           onChange(next)
                         }}
-                        placeholder="Region"
+                        placeholder={t('cpq.pricing.detail.keyLabelList.labelPlaceholder', 'Region')}
                         className="h-8"
                       />
                     ) : (
@@ -560,7 +608,7 @@ function KeyLabelListEditor({
                         type="button"
                         onClick={() => onChange(items.filter((_, i) => i !== idx))}
                         className="text-destructive hover:bg-destructive/10 rounded p-1"
-                        aria-label="Remove"
+                        aria-label={t('cpq.pricing.detail.keyLabelList.remove', 'Remove')}
                       >
                         <Trash2 className="h-4 w-4" />
                       </button>
@@ -580,7 +628,7 @@ function KeyLabelListEditor({
           size="sm"
           onClick={() => onChange([...items, { key: '', label: '' }])}
         >
-          + Add {title.slice(0, -1)}
+          {addLabel}
         </Button>
       )}
     </div>

package/src/modules/cpq/backend/cpq/pricing/[id]/xlsxImport.ts

@@ -7,6 +7,7 @@
 // absent from the file are treated as DELETES.
 
 import * as XLSX from 'xlsx'
+import type { TranslateFn } from '@open-mercato/shared/lib/i18n/context'
 
 type Dimension = { key: string; label: string }
 type PriceColumn = { key: string; label: string }
@@ -54,17 +55,23 @@ export async function parsePricingTableXlsx(
   file: File,
   table: TableShape,
   existingEntries: ImportEntry[],
+  t: TranslateFn,
 ): Promise<ImportResult> {
   let workbook: XLSX.WorkBook
   try {
     const buffer = await file.arrayBuffer()
     workbook = XLSX.read(buffer, { type: 'array' })
   } catch (err) {
-    return { ok: false, error: err instanceof Error ? `Failed to read file: ${err.message}` : 'Failed to read file' }
+    return {
+      ok: false,
+      error: err instanceof Error
+        ? t('cpq.pricing.import.errors.readFailedWithReason', 'Failed to read file: {reason}', { reason: err.message })
+        : t('cpq.pricing.import.errors.readFailed', 'Failed to read file'),
+    }
   }
 
   const sheetName = workbook.SheetNames[0]
-  if (!sheetName) return { ok: false, error: 'Workbook has no sheets' }
+  if (!sheetName) return { ok: false, error: t('cpq.pricing.import.errors.noSheets', 'Workbook has no sheets') }
   const sheet = workbook.Sheets[sheetName]
 
   // Two-row header strategy: row 1 is human labels (from export), row 2+ is
@@ -78,7 +85,7 @@ export async function parsePricingTableXlsx(
   })
 
   if (rows.length === 0) {
-    return { ok: false, error: 'Sheet has no data rows' }
+    return { ok: false, error: t('cpq.pricing.import.errors.noDataRows', 'Sheet has no data rows') }
   }
 
   // Build label→key map for dimensions and price columns so we can match
@@ -131,20 +138,20 @@ export async function parsePricingTableXlsx(
     ...priceHeaders.map((p) => p.header),
   ].filter((h): h is string => h !== null))
   for (const h of headers) {
-    if (!knownHeaders.has(h)) warnings.push(`Ignored unknown column "${h}"`)
+    if (!knownHeaders.has(h)) warnings.push(t('cpq.pricing.import.warnings.unknownColumn', 'Ignored unknown column "{column}"', { column: h }))
   }
 
   // Missing required columns from the table → error.
   const missingDims = table.dimensions.filter((d) => !dimensionHeaders.some((h) => h.key === d.key))
   const missingPrices = table.priceColumns.filter((c) => !priceHeaders.some((h) => h.key === c.key))
   if (missingDims.length > 0) {
-    return { ok: false, error: `Missing dimension column(s): ${missingDims.map((d) => d.label).join(', ')}` }
+    return { ok: false, error: t('cpq.pricing.import.errors.missingDimensionColumns', 'Missing dimension column(s): {columns}', { columns: missingDims.map((d) => d.label).join(', ') }) }
   }
   if (missingPrices.length > 0) {
-    return { ok: false, error: `Missing price column(s): ${missingPrices.map((c) => c.label).join(', ')}` }
+    return { ok: false, error: t('cpq.pricing.import.errors.missingPriceColumns', 'Missing price column(s): {columns}', { columns: missingPrices.map((c) => c.label).join(', ') }) }
   }
   if (!currencyHeader) {
-    return { ok: false, error: 'Missing "currency_code" column' }
+    return { ok: false, error: t('cpq.pricing.import.errors.missingCurrencyColumn', 'Missing "currency_code" column') }
   }
 
   // ─── Parse rows ──────────────────────────────────────────────
@@ -161,15 +168,15 @@ export async function parsePricingTableXlsx(
     const currency = toStringOrNull(raw[currencyHeader]) ?? ''
 
     if (!currency) {
-      return { ok: false, error: `Row ${rowNumber}: missing currency_code` }
+      return { ok: false, error: t('cpq.pricing.import.errors.rowMissingCurrency', 'Row {row}: missing currency_code', { row: rowNumber }) }
     }
     if (!table.currencyCodeList.includes(currency.toUpperCase())) {
-      return { ok: false, error: `Row ${rowNumber}: currency "${currency}" is not in the table's currency list (${table.currencyCodeList.join(', ')})` }
+      return { ok: false, error: t('cpq.pricing.import.errors.rowCurrencyNotAllowed', 'Row {row}: currency "{currency}" is not in the table\'s currency list ({currencies})', { row: rowNumber, currency, currencies: table.currencyCodeList.join(', ') }) }
     }
 
     const tierNumber = tierStr ? Number(tierStr) : null
     if (tierNumber !== null && Number.isNaN(tierNumber)) {
-      return { ok: false, error: `Row ${rowNumber}: tier_number must be a number, got "${tierStr}"` }
+      return { ok: false, error: t('cpq.pricing.import.errors.rowTierNotNumber', 'Row {row}: tier_number must be a number, got "{value}"', { row: rowNumber, value: tierStr ?? '' }) }
     }
 
     const dimensionValues: Record<string, string> = {}
@@ -186,7 +193,7 @@ export async function parsePricingTableXlsx(
       }
       const num = Number(v)
       if (Number.isNaN(num)) {
-        return { ok: false, error: `Row ${rowNumber}: price column "${header}" must be a number, got "${String(v)}"` }
+        return { ok: false, error: t('cpq.pricing.import.errors.rowPriceNotNumber', 'Row {row}: price column "{column}" must be a number, got "{value}"', { row: rowNumber, column: header, value: String(v) }) }
       }
       prices[key] = num
     }
@@ -219,7 +226,7 @@ export async function parsePricingTableXlsx(
     }
     const existing = existingById.get(row.id)
     if (!existing) {
-      warnings.push(`Row ${row.rowNumber}: id "${row.id}" not found in current entries — will be inserted as new`)
+      warnings.push(t('cpq.pricing.import.warnings.idNotFound', 'Row {row}: id "{id}" not found in current entries — will be inserted as new', { row: row.rowNumber, id: row.id }))
       inserts.push({ ...row, id: null })
       continue
     }
@@ -243,6 +250,7 @@ export async function parsePricingTableXlsx(
 export async function commitImportDiff(
   pricingTableId: string,
   diff: ImportDiff,
+  t: TranslateFn,
 ): Promise<{ ok: true } | { ok: false; error: string }> {
   // INSERTS (batch — route accepts arrays)
   if (diff.inserts.length > 0) {
@@ -262,7 +270,7 @@ export async function commitImportDiff(
     })
     if (!res.ok) {
       const body = await res.json().catch(() => ({}))
-      return { ok: false, error: body.error ?? 'Failed to insert entries' }
+      return { ok: false, error: body.error ?? t('cpq.pricing.import.errors.insertFailed', 'Failed to insert entries') }
     }
   }
 
@@ -283,7 +291,7 @@ export async function commitImportDiff(
     })
     if (!res.ok) {
       const body = await res.json().catch(() => ({}))
-      return { ok: false, error: body.error ?? `Failed to update entry ${before.id}` }
+      return { ok: false, error: body.error ?? t('cpq.pricing.entries.errors.updateFailed', 'Failed to update entry {id}', { id: before.id }) }
     }
   }
 
@@ -296,7 +304,7 @@ export async function commitImportDiff(
     })
     if (!res.ok) {
       const body = await res.json().catch(() => ({}))
-      return { ok: false, error: body.error ?? `Failed to delete entry ${entry.id}` }
+      return { ok: false, error: body.error ?? t('cpq.pricing.entries.errors.deleteFailed', 'Failed to delete entry {id}', { id: entry.id }) }
     }
   }
 

package/src/modules/cpq/backend/cpq/pricing/page.tsx

@@ -73,7 +73,7 @@ export default function PricingTablesPage() {
         header: t('cpq.pricing.status', 'Status'),
         cell: ({ row }) => (
           <Tag variant={row.original.isActive ? 'success' : 'neutral'} dot>
-            {row.original.isActive ? t('common.active', 'Active') : t('common.inactive', 'Inactive')}
+            {row.original.isActive ? t('cpq.common.active', 'Active') : t('cpq.common.inactive', 'Inactive')}
           </Tag>
         ),
       },