@cyanautomation/kaseki-agent 1.4.1

package/tests/validation-missing-npm-scripts.test.sh

@@ -0,0 +1,93 @@
+#!/usr/bin/env bash
+set -euo pipefail
+
+ROOT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)"
+
+# Load only the npm validation helpers from kaseki-agent.sh.
+eval "$(awk '
+  /^npm_run_script_name\(\)/ { emit=1 }
+  /^missing_npm_script_for_validation_command\(\)/ { emit=1 }
+  /^record_skipped_validation_command\(\)/ { emit=1 }
+  /^compute_repo_memory_key\(\)/ { emit=0 }
+  emit { print }
+' "$ROOT_DIR/kaseki-agent.sh")"
+
+fail() { printf '✗ %s\n' "$1" >&2; exit 1; }
+pass() { printf '✓ %s\n' "$1"; }
+
+assert_equals() {
+  local label="$1"
+  local expected="$2"
+  local actual="$3"
+  [ "$actual" = "$expected" ] || fail "$label: expected '$expected', got '$actual'"
+  pass "$label"
+}
+
+assert_missing_script() {
+  local label="$1"
+  local command="$2"
+  local expected_script="$3"
+  local actual_script
+  if ! actual_script="$(missing_npm_script_for_validation_command "$command")"; then
+    fail "$label: expected missing npm script '$expected_script'"
+  fi
+  assert_equals "$label" "$expected_script" "$actual_script"
+}
+
+assert_not_missing_script() {
+  local label="$1"
+  local command="$2"
+  if missing_npm_script_for_validation_command "$command" >"$tmp_dir/missing-script-test.out" 2>/dev/null; then
+    fail "$label: command should not be treated as a missing npm script ($(cat "$tmp_dir/missing-script-test.out"))"
+  fi
+  pass "$label"
+}
+
+# Override record_skipped_validation_command to use temp directory instead of /results
+record_skipped_validation_command() {
+  local command="$1"
+  local script_name="$2"
+  local duration_seconds="$3"
+  {
+    printf '\n==> %s\n' "$command"
+    printf 'skipped: package.json does not define npm script "%s"\n' "$script_name"
+  } 2>&1 | tee -a "$tmp_dir/results/validation.log"
+  printf '%s\tskipped\t%s\tmissing_npm_script=%s\n' "$command" "$duration_seconds" "$script_name" >> "$VALIDATION_TIMINGS_FILE"
+}
+
+tmp_dir="$(mktemp -d)"
+trap 'rm -rf "$tmp_dir"' EXIT
+mkdir -p "$tmp_dir/results"
+cd "$tmp_dir"
+cat > package.json <<'JSON'
+{
+  "scripts": {
+    "test": "node -e 'process.exit(0)'",
+    "build": "node -e 'process.exit(0)'"
+  }
+}
+JSON
+
+VALIDATION_TIMINGS_FILE="$tmp_dir/results/validation-timings.tsv"
+: > "$tmp_dir/results/validation.log" || fail "Cannot write to validation.log"
+: > "$VALIDATION_TIMINGS_FILE" || fail "Cannot write to validation timings file"
+
+assert_equals "extracts npm run script names" "check" "$(npm_run_script_name 'npm run check')"
+assert_equals "extracts npm run script with trailing args" "test" "$(npm_run_script_name 'npm run test -- --runInBand')"
+
+# Missing npm scripts are now always skipped (non-fatal), regardless of KASEKI_SKIP_MISSING_NPM_SCRIPTS
+assert_missing_script "always skips missing check script" "npm run check" "check"
+assert_not_missing_script "does not skip defined test script" "npm run test"
+assert_not_missing_script "does not skip defined build script" "npm run build"
+
+record_skipped_validation_command "npm run check" "check" "0"
+
+if ! grep -Fq 'skipped: package.json does not define npm script "check"' "$tmp_dir/results/validation.log"; then
+  fail "validation.log should include a clear missing-script skip reason"
+fi
+pass "validation.log records missing-script skip reason"
+
+assert_equals "validation timing records skipped row" $'npm run check\tskipped\t0\tmissing_npm_script=check' "$(cat "$VALIDATION_TIMINGS_FILE")"
+
+echo ""
+echo "✅ Missing npm script validation tests passed!"

package/tests/validation-strict-mode.test.sh

@@ -0,0 +1,118 @@
+#!/usr/bin/env bash
+# Integration tests for strict validation mode
+# Tests KASEKI_SKIP_MISSING_NPM_SCRIPTS behavior and error messaging
+
+set -euo pipefail
+
+ROOT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)"
+TMP_DIR="$(mktemp -d)"
+trap 'rm -rf "$TMP_DIR"' EXIT
+
+# Load validation helpers
+eval "$(awk '
+  /^npm_run_script_name\(\)/ { emit=1 }
+  /^package_json_has_npm_script\(\)/ { emit=1 }
+  /^missing_npm_script_for_validation_command\(\)/ { emit=1 }
+  /^[a-z_]+\(\) \{/ && !/^npm_run_script_name|^package_json_has_npm_script|^missing_npm_script_for_validation_command/ { emit=0 }
+  emit { print }
+' "$ROOT_DIR/kaseki-agent.sh")"
+
+pass() { printf '✓ %s\n' "$1"; }
+fail() { printf '✗ %s\n' "$1" >&2; exit 1; }
+
+# Setup test environment
+mkdir -p "$TMP_DIR/results"
+cd "$TMP_DIR"
+: > "$TMP_DIR/results/validation.log" 2>/dev/null || true
+VALIDATION_TIMINGS_FILE="$TMP_DIR/results/validation-timings.tsv"
+touch "$VALIDATION_TIMINGS_FILE"
+
+# Test 1: Missing scripts are always skipped (non-fatal)
+echo "==> Test: Missing scripts are always skipped (non-fatal)"
+{
+  cat > package.json <<'JSON'
+{
+  "scripts": {
+    "test": "echo test"
+  }
+}
+JSON
+  
+  # Try to check for missing "build" script
+  if missing_script="$(missing_npm_script_for_validation_command 'npm run build' 2>/dev/null || true)"; then
+    if [ "$missing_script" = "build" ]; then
+      pass "Missing script detection: correctly identifies missing 'build' script"
+    else
+      fail "Missing script detection: expected 'build' but got '$missing_script'"
+    fi
+  else
+    fail "Missing script detection: function should return missing script name"
+  fi
+}
+
+# Test 2: Existing scripts are detected (not skipped)
+echo "==> Test: Existing scripts are detected"
+{
+  # Try to check for existing "test" script (should NOT be skipped)
+  if ! missing_npm_script_for_validation_command 'npm run test' 2>/dev/null >/dev/null; then
+    pass "Existing script detection: correctly identifies existing 'test' script"
+  else
+    fail "Existing script detection: should not return missing script for existing 'test' script"
+  fi
+}
+
+# Test 3: Script name extraction
+echo "==> Test: Script name extraction"
+{
+  test_cases=(
+    "npm run build"
+    "npm run test -- --watch"
+    "npm run lint:fix"
+  )
+  
+  expected=(
+    "build"
+    "test"
+    "lint:fix"
+  )
+  
+  for i in "${!test_cases[@]}"; do
+    cmd="${test_cases[$i]}"
+    exp="${expected[$i]}"
+    result="$(npm_run_script_name "$cmd")"
+    
+    if [ "$result" = "$exp" ]; then
+      pass "Script extraction: '$cmd' → '$result'"
+    else
+      fail "Script extraction: expected '$exp' from '$cmd', got '$result'"
+    fi
+  done
+}
+
+# Test 4: Validation timing recording
+echo "==> Test: Validation timing recording"
+{
+  cat > package.json <<'JSON'
+{
+  "scripts": {
+    "format": "prettier --check ."
+  }
+}
+JSON
+  
+  # Simulate recording a skipped validation command
+  : > "$VALIDATION_TIMINGS_FILE"
+  
+  # When a script is missing, record it in timings
+  if missing_script="$(missing_npm_script_for_validation_command 'npm run lint' 2>/dev/null || true)"; then
+    printf 'npm run lint\t1\t0\tmissing_npm_script=%s\n' "$missing_script" >> "$VALIDATION_TIMINGS_FILE"
+  fi
+  
+  if grep -q "missing_npm_script=lint" "$VALIDATION_TIMINGS_FILE"; then
+    pass "Timing recording: correctly logs missing npm script"
+  else
+    fail "Timing recording: should log missing script in timings"
+  fi
+}
+
+printf '\n✅ Core validation strict-mode tests passed\n'

package/tsconfig.changed.json

@@ -0,0 +1,7 @@
+{
+  "extends": "./tsconfig.json",
+  "include": [
+    "src/**/*.ts"
+  ],
+  "exclude": ["node_modules", "dist", "**/*.test.ts", "coverage"]
+}

package/tsconfig.json

@@ -0,0 +1,39 @@
+{
+  "compilerOptions": {
+    "target": "ES2024",
+    "module": "ESNext",
+    "lib": ["ES2024"],
+    "outDir": "./dist",
+    "rootDir": "./src",
+    "declaration": true,
+    "declarationMap": true,
+    "sourceMap": true,
+    "strict": true,
+    "esModuleInterop": true,
+    "skipLibCheck": true,
+    "forceConsistentCasingInFileNames": true,
+    "resolveJsonModule": true,
+    "moduleResolution": "bundler",
+    "noImplicitAny": true,
+    "strictNullChecks": true,
+    "strictFunctionTypes": true,
+    "strictBindCallApply": true,
+    "strictPropertyInitialization": true,
+    "noImplicitThis": true,
+    "alwaysStrict": true,
+    "noUnusedLocals": true,
+    "noUnusedParameters": true,
+    "noImplicitReturns": true,
+    "noFallthroughCasesInSwitch": true
+  },
+  "ts-node": {
+    "esm": true,
+    "experimentalEsm": true,
+    "compilerOptions": {
+      "module": "ESNext",
+      "moduleResolution": "bundler"
+    }
+  },
+  "include": ["src/**/*.ts"],
+  "exclude": ["node_modules", "dist", "src/**/*.test.ts", "coverage"]
+}