@cueloop/client 0.1.0-alpha.76 → 0.1.0-alpha.78

package/src/App.tsx

@@ -15,11 +15,15 @@ import {
   loadConfig,
   persistAuthorName,
   persistDiffView,
+  persistIdentity,
   persistPins,
   type AutoClose,
   type DiffViewMode,
+  type IdentityConfig,
   type QuickAction,
 } from "./config";
+import { resolveDisplayName } from "./attribution";
+import { resolveGithubIdentity } from "./github-identity";
 import { loadSkills, PaletteNamesContext, SlashSkillsContext } from "./skills";
 import { mergeSlashItems, slashItemsFrom, type SlashItem } from "./slash-palette";
 import {
@@ -38,6 +42,7 @@ import { KeyBindings, type CheatsheetSection } from "./key-bindings";
 import { useReadySignal } from "./ready-signal";
 import { ThemeProvider } from "./components/theme-context";
 import { Button } from "./components/primitives/Button";
+import { ShareChoiceDialog, SHARE_CHOICES } from "./components/ShareChoiceDialog";
 import { Toolbar } from "./components/primitives/Toolbar";
 import { groupInbox, projectName, threadTitle } from "./components/session-tree";
 import { ThreadTree } from "./components/ThreadTree";
@@ -52,6 +57,7 @@ import { useRememberLayout } from "./use-remember-layout";
 import type { LaunchLayout } from "./launch-layout";
 import { ThreadFooter } from "./components/ThreadFooter";
 import { ConfirmCard } from "./components/ConfirmCard";
+import { ManageAccessDialog } from "./components/ManageAccessDialog";
 import { THREAD_VIEW_CHEATSHEET, ThreadView } from "./components/ThreadView";
 import {
   diffChordEntries,
@@ -67,7 +73,7 @@ import {
 import { type DiffFoldControls } from "./components/DiffContentView";
 import { commentCountsByFile } from "./view-diff";
 import { annotationTarget } from "@cueloop/schema";
-import type { Artifact, DiffFileContents, Thread } from "@cueloop/schema";
+import type { Annotation, Artifact, DiffFileContents, Identity, Thread } from "@cueloop/schema";
 import { PrototypePixels } from "./prototype-pixels";
 import type { PrototypeElement } from "./prototype-browser";
 import {
@@ -139,6 +145,11 @@ function menuChromeOpen(menuDialog: "keybinds" | "settings" | null): boolean {
   return menuDialog !== null;
 }
 
+/** The private-share allowlist for a session, or an empty list for a public one. */
+function allowedGithubLogins(session: Thread | null): string[] {
+  return session?.access?.githubLogins ?? [];
+}
+
 /** The drop-up chrome or a floating popover menu (thread actions, editor split) holds the keyboard. */
 function keyboardHeldByMenu(
   menuDialog: "keybinds" | "settings" | null,
@@ -184,11 +195,89 @@ function keyboardOwnedElsewhere(menuOwnsKeyboard: boolean, overlay: KeyState["ov
   return menuOwnsKeyboard || overlay !== "none";
 }
 
+/** The highlighted share option, or the public default when the choice is closed. */
+function shareChoiceIndex(mode: Mode): number {
+  return mode.type === "shareChoice" ? mode.index : 0;
+}
+
+interface ShareChoiceActions {
+  setMode: (mode: Mode) => void;
+  isOwner: boolean;
+  publish: () => void;
+  openManageAccess: () => void;
+}
+
+/** Move the share-choice highlight by one row, clamped to the list. */
+function movedShareChoice(index: number, delta: number): Mode {
+  const next = Math.min(SHARE_CHOICES.length - 1, Math.max(0, index + delta));
+
+  return { type: "shareChoice", index: next };
+}
+
+/** Commit the highlighted share option: public publishes a link, private opens manage-access. */
+function commitShareChoice(index: number, actions: ShareChoiceActions): void {
+  const picked = SHARE_CHOICES[index]?.choice;
+
+  actions.setMode({ type: "normal" });
+
+  if (!actions.isOwner) return;
+
+  if (picked === "private") actions.openManageAccess();
+  else actions.publish();
+}
+
+/** Route one key to the open share choice: escape cancels, arrows move, enter commits. */
+function handleShareChoiceKey(
+  index: number,
+  key: { name: string },
+  actions: ShareChoiceActions,
+): void {
+  if (key.name === "escape") return actions.setMode({ type: "normal" });
+
+  if (key.name === "down" || key.name === "j") return actions.setMode(movedShareChoice(index, 1));
+
+  if (key.name === "up" || key.name === "k") return actions.setMode(movedShareChoice(index, -1));
+
+  if (key.name === "return" || key.name === "enter") commitShareChoice(index, actions);
+}
+
+/**
+ * An app-level dialog owns the keyboard while open: the manage-access dialog takes its own keys,
+ * and the share choice moves the highlight, commits on enter, and cancels on escape. Returns true
+ * when a dialog consumed the key so the caller stops the grammar.
+ */
+function appDialogOwnsKey(
+  accessDialogOpen: boolean,
+  mode: Mode,
+  key: { name: string },
+  actions: ShareChoiceActions,
+): boolean {
+  if (accessDialogOpen) return true;
+
+  if (mode.type !== "shareChoice") return false;
+
+  handleShareChoiceKey(mode.index, key, actions);
+
+  return true;
+}
+
 /** The footer submit fires only for the owner of an unresolved review, never an observer. */
 function canSubmitReview(isOwner: boolean, resolved: boolean, observer: boolean): boolean {
   return isOwner && !resolved && !observer;
 }
 
+/** The author display name for a comment's hover tooltip: the reviewer's own name for their notes, else the resolved collaborator name. */
+function authorLabelResolver(
+  ownName: string | undefined,
+  participants: Identity[] | undefined,
+  overrides: Record<string, string>,
+): (annotation: Annotation) => string | undefined {
+  return (annotation) =>
+    annotation.author === undefined
+      ? (ownName ?? "you")
+      : resolveDisplayName(annotation.author, participants, overrides);
+}
+
 /** The Project pane body: the resolved repo's changed files in changes mode, its full tree otherwise. */
 function ProjectPanelBody(props: {
   mode: ProjectPanelMode;
@@ -505,6 +594,7 @@ export function App({
   const [mode, setMode] = useState<Mode>({ type: "normal" });
   // the top-left settings gear drop-down and the centered dialog it opens
   const [menuDialog, setMenuDialog] = useState<"keybinds" | "settings" | null>(null);
+  const [accessDialogOpen, setAccessDialogOpen] = useState(false);
   const [autoClose, setAutoClose] = useState<AutoClose>("off");
   // unified or side-by-side diff; split only lays out when the Changes pane is zoomed
   const [diffView, setDiffView] = useState<DiffViewMode>("split");
@@ -526,6 +616,7 @@ export function App({
   const [themeName, setThemeName] = useState<ThemeName>(DEFAULT_THEME_NAME);
   const [themeOverrides, setThemeOverrides] = useState<Partial<Theme>>({});
   const [authorNames, setAuthorNames] = useState<Record<string, string>>({});
+  const [identity, setIdentity] = useState<IdentityConfig>({ provider: "typed" });
   const [quickActions, setQuickActions] = useState<QuickAction[]>(DEFAULT_QUICK_ACTIONS);
   const [skills, setSkills] = useState<SlashItem[]>([]);
   const paletteNames = useMemo(
@@ -545,6 +636,7 @@ export function App({
     setThemeName(config.ui.theme);
     setThemeOverrides(config.themeOverrides);
     setAuthorNames(config.authors);
+    setIdentity(config.identity);
     setQuickActions(config.actions);
     setSkills(loadSkills(config.skillsPath));
     setAutoClose(config.ui.autoClose);
@@ -578,6 +670,29 @@ export function App({
     if (!known) setMode({ type: "nameSelf", text: "" });
   }, [role, selfAuthor, session]);
 
+  // Bumped on every identity change so a slow GitHub sync that lands after a newer rename is discarded.
+  const identityGenerationRef = useRef(0);
+  const applyIdentity = (next: IdentityConfig): void => {
+    identityGenerationRef.current += 1;
+    setIdentity(next);
+    try {
+      persistIdentity(next);
+    } catch {
+      controller.setStatus("could not save identity to config");
+    }
+  };
+  const syncGithubIdentity = (): void => {
+    const generation = (identityGenerationRef.current += 1);
+    void resolveGithubIdentity().then((github) => {
+      if (identityGenerationRef.current !== generation) return;
+      if (!github) return controller.setStatus("GitHub not connected - run gh auth login");
+      const name = github.name?.trim() || github.login;
+
+      applyIdentity({ name, provider: "github" });
+      controller.setStatus(`identity synced from GitHub - ${name}`);
+    });
+  };
+
   // ── settings dialog: config-backed model, navigation, persistence ──
   const {
     settingsNav,
@@ -600,6 +715,13 @@ export function App({
     quickActions,
     setQuickActions,
     setMenuDialog,
+    identityName: identity.name,
+    identityProvider: identity.provider,
+    onSyncGithubIdentity: syncGithubIdentity,
+    onRenameDisplayName: () => {
+      setMenuDialog(null);
+      setMode({ type: "renameSelf", text: identity.name ?? "" });
+    },
   });
 
   // ── derived view model ──────────────────────
@@ -718,6 +840,9 @@ export function App({
       setAuthorNames((prev) => ({ ...prev, [id]: name }));
     },
     renameThread: (id: string, title: string) => controller.renameSession(id, title),
+    setLocalIdentityName: (name: string) => {
+      applyIdentity(name ? { name, provider: "typed" } : { provider: "typed" });
+    },
     liveInput,
     setCursor,
     setInboxCursor,
@@ -746,8 +871,8 @@ export function App({
 
   const menuControl = useMenuControlState();
   const menuOwnsKeyboard = keyboardHeldByMenu(menuDialog, menuControl.openMenuId);
-  // an overlay (submit, walk, prompt, confirm) or the menu takes the keyboard
-  // from the thread view; the view suspends its own grammar meanwhile
+  // an overlay (submit, walk, prompt, confirm, share choice) or the menu takes the
+  // keyboard from the thread view; the view suspends its own grammar meanwhile
   const threadViewSuspended = keyboardOwnedElsewhere(menuOwnsKeyboard, overlay);
 
   const leaderCombos = leaderCombosFor(keysRef.current.leader);
@@ -787,6 +912,16 @@ export function App({
 
   useKeyboard((key) => {
     if (quitKeyHandled(key, onExit)) return;
+    // an app-level dialog (manage-access, share choice) owns the keyboard while open
+    if (
+      appDialogOwnsKey(accessDialogOpen, mode, key, {
+        setMode,
+        isOwner,
+        publish: () => controller.share(),
+        openManageAccess: () => setAccessDialogOpen(true),
+      })
+    )
+      return;
     if (menuModalHandled(menuControl, key)) return;
     if (
       appLeaderHandled({ focusedPane, key, leaderCombos, pending: leaderPending, runLeaderCommand })
@@ -919,6 +1054,11 @@ export function App({
     );
 
   const activeSession = session;
+  const resolveAuthorLabel = authorLabelResolver(
+    identity.name,
+    activeSession.participants,
+    authorNames,
+  );
 
   if (isCompletionOverlayPhase(completion) && activeSession.verdict)
     return (
@@ -928,6 +1068,9 @@ export function App({
         verdict={activeSession.verdict.kind}
         completion={completion}
         status={status}
+        onClose={() => dispatch({ type: "finishReview" })}
+        onBackToPlan={() => dispatch({ type: "dismissCompletion" })}
+        onAlways={() => dispatch({ type: "optInAutoClose" })}
       />
     );
 
@@ -946,6 +1089,7 @@ export function App({
     session: activeSession,
     walkFileList,
     viewedPaths,
+    quickActions,
     liveInput,
     setMode,
     dispatch,
@@ -968,12 +1112,19 @@ export function App({
     runEditorHandOff();
   };
 
-  // clicking the header Share button: publish the plan, copy the ssh line
+  // the share choice's public option: publish the plan, copy the ssh line
   const onShareRequest = (): void => {
     if (!isOwner) return controller.setStatus("only the plan owner can share");
     controller.share();
   };
 
+  // the share choice's private option opens the manage-access allowlist surface
+  const onPrivateShareRequest = (): void => {
+    if (!isOwner) return controller.setStatus("only the plan owner can share");
+    setAccessDialogOpen(true);
+  };
+  const allowedLogins = allowedGithubLogins(session);
+
   // clicking the rail Submit button: same read-only answer as the submit key
   const onSubmitRequest = (): void => {
     if (observer) return controller.setStatus("observer - read-only");
@@ -1027,7 +1178,7 @@ export function App({
                     <Button onPress={onEditRequest} theme={theme}>
                       {" edit "}
                     </Button>
-                    <Button onPress={onShareRequest} theme={theme}>
+                    <Button onPress={() => dispatch({ type: "share" })} theme={theme}>
                       {" share "}
                     </Button>
                   </Toolbar>
@@ -1092,6 +1243,7 @@ export function App({
                           void controller.reply(rootAnnotationId, body)
                         }
                         onUpdateAnnotation={(id, body) => controller.updateAnnotation(id, body)}
+                        resolveAuthorLabel={resolveAuthorLabel}
                         onExit={() => onExit?.(0)}
                       />
                     )}
@@ -1160,6 +1312,7 @@ export function App({
                         onReply: (rootAnnotationId, body) =>
                           void controller.reply(rootAnnotationId, body),
                         onUpdateAnnotation: (id, body) => controller.updateAnnotation(id, body),
+                        resolveAuthorLabel,
                         leaderCombos,
                         onLeaderCommand: runLeaderCommand,
                         onExit: () => onExit?.(0),
@@ -1231,6 +1384,28 @@ export function App({
                   </box>
                 </box>
               ) : null}
+              <ManageAccessDialog
+                isOpen={accessDialogOpen}
+                logins={allowedLogins}
+                onAdd={(login) => controller.setShareAccess([...allowedLogins, login])}
+                onRemove={(login) =>
+                  controller.setShareAccess(allowedLogins.filter((entry) => entry !== login))
+                }
+                onCreateLink={() => {
+                  setAccessDialogOpen(false);
+                  controller.share();
+                }}
+                onClose={() => setAccessDialogOpen(false)}
+                theme={theme}
+              />
+              <ShareChoiceDialog
+                isOpen={mode.type === "shareChoice"}
+                selectedIndex={shareChoiceIndex(mode)}
+                onPublicShare={onShareRequest}
+                onPrivateShare={onPrivateShareRequest}
+                onClose={() => setMode({ type: "normal" })}
+                theme={theme}
+              />
               {menuChrome}
             </AppShell>
           </MenuControlProvider>

package/src/App.walk.test.tsx

@@ -162,7 +162,7 @@ describe("the guided walk", () => {
     expect(setup.captureCharFrame()).toContain("3/3 files viewed");
 
     // Act
-    await press(setup, "enter");
+    await pressKey(setup, "RETURN", { meta: true });
 
     // Assert
     await waitForState(setup, () => server.core.sessionGet(session.id).status === "resolved");
@@ -253,7 +253,7 @@ describe("the guided walk", () => {
     await pressKey(setup, "RETURN", { meta: true });
     // nothing pending despite the note, so the confirm card defaults to approve
     await waitForText(setup, "[Approve]");
-    await press(setup, "enter");
+    await pressKey(setup, "RETURN", { meta: true });
 
     // Assert
     await waitForState(setup, () => server.core.sessionGet(session.id).status === "resolved");

package/src/__snapshots__/view-plan.regression.test.ts.snap

@@ -1,4 +1,4 @@
-// Bun Snapshot v1, https://goo.gl/fbAQLP
+// Bun Snapshot v1, https://bun.sh/docs/test/snapshots
 
 exports[`view-plan regression harness (M0) blockRuns output is stable across the representative blocks 1`] = `
 [

package/src/ansi-screen.test.ts

@@ -0,0 +1,28 @@
+import { describe, expect, test } from "bun:test";
+import { ansiScreenToLines } from "./ansi-screen";
+
+describe("ansiScreenToLines", () => {
+  test("places text at the positioned cursor", () => {
+    const lines = ansiScreenToLines("\x1b[2;3Hhi", 10, 4);
+
+    expect(lines[0]).toBe("");
+    expect(lines[1]).toBe("  hi");
+    expect(lines[2]).toBe("");
+  });
+
+  test("clears the screen before repositioning", () => {
+    const lines = ansiScreenToLines("\x1b[1;1Hold\x1b[2J\x1b[1;1Hnew", 10, 2);
+
+    expect(lines[0]).toBe("new");
+  });
+
+  test("ignores colour, cursor-visibility, and clipboard sequences", () => {
+    const lines = ansiScreenToLines("\x1b[?25l\x1b[1;1H\x1b[32mgo\x1b]52;c;AA\x07", 10, 2);
+
+    expect(lines[0]).toBe("go");
+  });
+
+  test("clamps writes outside the grid instead of throwing", () => {
+    expect(() => ansiScreenToLines("\x1b[99;99Hx", 5, 3)).not.toThrow();
+  });
+});

package/src/ansi-screen.ts

@@ -0,0 +1,72 @@
+/** Interpret an absolute-positioned ANSI byte stream (cursor moves plus printed text) into a grid of rows. */
+
+const CSI = "\x1b[";
+
+export function ansiScreenToLines(ansi: string, cols: number, rows: number): string[] {
+  const grid: string[][] = Array.from({ length: rows }, () =>
+    Array.from({ length: cols }, () => " "),
+  );
+  let row = 0;
+  let column = 0;
+  let index = 0;
+
+  const put = (character: string): void => {
+    if (row >= 0 && row < rows && column >= 0 && column < cols) grid[row]![column] = character;
+    column += 1;
+  };
+
+  while (index < ansi.length) {
+    const character = ansi[index]!;
+
+    if (character === "\x1b") {
+      index = consumeEscape(ansi, index, (nextRow, nextColumn) => {
+        if (nextRow === "clear") {
+          for (const line of grid) line.fill(" ");
+          row = 0;
+          column = 0;
+        } else {
+          row = nextRow;
+          column = nextColumn;
+        }
+      });
+      continue;
+    }
+    if (character === "\n") {
+      row += 1;
+      column = 0;
+    } else if (character === "\r") {
+      column = 0;
+    } else {
+      put(character);
+    }
+    index += 1;
+  }
+
+  return grid.map((line) => line.join("").replace(/\s+$/, ""));
+}
+
+type EscapeEffect = (row: number | "clear", column: number) => void;
+
+function consumeEscape(ansi: string, start: number, apply: EscapeEffect): number {
+  if (ansi[start + 1] === "]") {
+    const bell = ansi.indexOf("\x07", start);
+
+    return bell === -1 ? ansi.length : bell + 1;
+  }
+  if (ansi.slice(start, start + CSI.length) !== CSI) return start + 1;
+  let index = start + CSI.length;
+
+  while (index < ansi.length && !/[A-Za-z]/.test(ansi[index]!)) index += 1;
+  const final = ansi[index];
+  const parameters = ansi.slice(start + CSI.length, index);
+
+  if (final === "H" || final === "f") {
+    const [rowParameter = "1", columnParameter = "1"] = parameters.split(";");
+
+    apply(Math.max(0, Number(rowParameter) - 1), Math.max(0, Number(columnParameter) - 1));
+  } else if (final === "J" && parameters === "2") {
+    apply("clear", 0);
+  }
+
+  return index + 1;
+}

package/src/app-screens.tsx

@@ -388,7 +388,6 @@ export function NoThreadShell(props: {
             <PromptDialog
               isOpen
               title=" rename thread "
-              label="new title for this thread:"
               value={mode.text}
               placeholder="a short title"
               onInput={(text) => setMode({ ...mode, text })}
@@ -412,8 +411,11 @@ export function CompletionScreen(props: {
   verdict: VerdictKind;
   completion: { phase: "prompt" } | { phase: "counting"; remaining: number };
   status: string;
+  onClose: () => void;
+  onBackToPlan: () => void;
+  onAlways: () => void;
 }): React.ReactNode {
-  const { theme, session, verdict, completion, status } = props;
+  const { theme, session, verdict, completion, status, onClose, onBackToPlan, onAlways } = props;
 
   return (
     <ThemeProvider theme={theme}>
@@ -421,6 +423,9 @@ export function CompletionScreen(props: {
         verdict={verdict}
         completion={completion}
         status={status}
+        onClose={onClose}
+        onBackToPlan={onBackToPlan}
+        onAlways={onAlways}
         returnsTo={
           returnPaneFor(session.artifact.meta.herdrPane)
             ? (session.artifact.meta.agent ?? "the agent")
@@ -510,7 +515,6 @@ export function TrailingOverlays(props: {
         <PromptDialog
           isOpen
           title=" rename thread "
-          label="new title for this thread:"
           value={mode.text}
           placeholder="a short title"
           onInput={(text) => setMode({ ...mode, text })}
@@ -532,6 +536,19 @@ export function TrailingOverlays(props: {
           theme={theme}
         />
       ) : null}
+      {mode.type === "renameSelf" ? (
+        <PromptDialog
+          isOpen
+          title=" Display name "
+          label="Your display name - it attributes the notes you leave:"
+          value={mode.text}
+          placeholder="your name"
+          onInput={(text) => setMode({ ...mode, text })}
+          onSave={() => dispatch({ type: "confirmDialog" })}
+          onCancel={() => setMode({ type: "normal" })}
+          theme={theme}
+        />
+      ) : null}
       {mode.type === "treePrompt" ? (
         <PromptDialog
           isOpen

package/src/app-view-model.ts

@@ -4,6 +4,7 @@ import type { Mode } from "./intent-dispatch";
 import type { Intent, KeyState } from "./keymap";
 import type { Completion } from "./thread-controller";
 import type { WalkFile } from "./walk";
+import type { QuickAction } from "./config";
 import { viewedCount } from "./walk";
 import type { ConfirmCardProps } from "./components/ConfirmCard";
 import type { BreadcrumbItem } from "./components/Breadcrumb";
@@ -57,6 +58,7 @@ export function resolveOverlay(
     mode.type === "treePrompt"
   )
     return "prompt";
+  if (mode.type === "shareChoice") return "shareChoice";
   if (mode.type === "spanActions") return "spanActions";
   if (completionPhase === "prompt") return "completion-prompt";
   if (completionPhase === "counting") return "completion-counting";
@@ -135,6 +137,7 @@ export function buildSubmitConfirmState(
     session: Thread;
     walkFileList: WalkFile[];
     viewedPaths: Set<string>;
+    quickActions: QuickAction[];
   },
 ): Omit<ConfirmCardProps, "theme"> | null {
   const { mode, isDiff, session, walkFileList, viewedPaths, liveInput, setMode, dispatch } = deps;
@@ -144,6 +147,7 @@ export function buildSubmitConfirmState(
   return {
     verdict: mode.verdict,
     summary: mode.summary,
+    quickActions: deps.quickActions,
     viewedSummary:
       isDiff && session.viewedPaths !== undefined
         ? `${viewedCount(walkFileList, viewedPaths)}/${walkFileList.length} files viewed`

package/src/components/AnnotatableFileView.tsx

@@ -1,10 +1,16 @@
 // A project file shown as its own annotatable surface: the file's lines render through the diff
 // sheet as context rows (one line-number gutter, no +/- sign), so selecting text leaves a comment
-// anchored to the file exactly as a plan or diff comment is. Used where a review session exists to
+// anchored to the file exactly as a plan or diff comment is. Used where a thread exists to
 // hold the notes; the bare-launch welcome shell uses the read-only FileContentsView instead.
 
 import React, { useEffect, useRef, useState } from "react";
-import { makeAnchor, annotationTarget, type Anchor, type Thread } from "@cueloop/schema";
+import {
+  makeAnchor,
+  annotationTarget,
+  type Anchor,
+  type Annotation,
+  type Thread,
+} from "@cueloop/schema";
 import type { Theme } from "../theme";
 import type { QuickAction } from "../config";
 import { useComponentTheme } from "./theme-context";
@@ -28,6 +34,7 @@ export interface AnnotatableFileViewProps {
   onAddComment: (anchor: Anchor, body: string) => void;
   onReply: (rootAnnotationId: string, body: string) => void;
   onUpdateAnnotation: (id: string, body: string) => void;
+  resolveAuthorLabel?: (annotation: Annotation) => string | undefined;
   onExit: () => void;
   theme?: Theme;
 }
@@ -119,6 +126,7 @@ export function AnnotatableFileView(props: AnnotatableFileViewProps): React.Reac
       }
       onReply={props.onReply}
       onUpdateAnnotation={props.onUpdateAnnotation}
+      resolveAuthorLabel={props.resolveAuthorLabel}
       onExit={props.onExit}
       theme={props.theme}
     />