@cueloop/client 0.1.0-alpha.76 → 0.1.0-alpha.78

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cueloop/client",
-  "version": "0.1.0-alpha.76",
+  "version": "0.1.0-alpha.78",
   "description": "The cueloop review UI: projection renderer, keyboard grammar, review rail",
   "homepage": "https://github.com/mmurakaru/cueloop#readme",
   "bugs": {
@@ -27,10 +27,10 @@
     "access": "public"
   },
   "dependencies": {
-    "@cueloop/daemon": "0.1.0-alpha.76",
-    "@cueloop/extension-api": "0.1.0-alpha.76",
-    "@cueloop/integration-obsidian": "0.1.0-alpha.76",
-    "@cueloop/schema": "0.1.0-alpha.76",
+    "@cueloop/daemon": "0.1.0-alpha.78",
+    "@cueloop/extension-api": "0.1.0-alpha.78",
+    "@cueloop/integration-obsidian": "0.1.0-alpha.78",
+    "@cueloop/schema": "0.1.0-alpha.78",
     "@opentui/core": "^0.5.8",
     "@opentui/keymap": "0.5.8",
     "@opentui/react": "^0.5.8",

package/src/App.autoclose.test.tsx

@@ -57,7 +57,7 @@ type Setup = Awaited<ReturnType<typeof renderApp>>;
 
 async function submitApprove(setup: Setup): Promise<void> {
   await pressKey(setup, "RETURN", { meta: true }); // open submit (approve default: no pending items)
-  await press(setup, "enter"); // confirm
+  await pressKey(setup, "RETURN", { meta: true }); // confirm
   await waitForText(setup, "review approved");
 }
 
@@ -74,8 +74,8 @@ describe("completion overlay", () => {
     const frame = await waitForText(setup, "closing in 5s");
 
     expect(frame).toContain("review approved");
-    expect(frame).toContain("close [return]");
-    expect(frame).toContain("return to plan [esc]");
+    expect(frame).toContain("close");
+    expect(frame).toContain("back to plan");
 
     // Act
     await press(setup, "enter");

package/src/App.diff.test.tsx

@@ -13,7 +13,6 @@ import {
   clickText,
   dragText,
   isolateUserConfig,
-  press,
   pressKey,
   renderReadyApp,
   typeText,
@@ -95,7 +94,7 @@ describe("diff review", () => {
 
     // Act - submit with the session chord (cmd+enter, no composer open), confirm request_changes
     await pressKey(setup, "RETURN", { meta: true });
-    await press(setup, "enter");
+    await pressKey(setup, "RETURN", { meta: true });
 
     // Assert
     await waitForText(setup, "feedback sent");
@@ -105,6 +104,19 @@ describe("diff review", () => {
     expect(resolved.verdict!.feedback).toContain("Map needs an eviction story.");
   });
 
+  test("pasting an image into a diff comment drops in an [Image #n] placeholder", async () => {
+    // Arrange - mark the added line and open the inline comment composer
+    const setup = await renderApp();
+    await dragText(setup, "new Map()", "new Map()", "new Map()".length);
+    await typeText(setup, "see ");
+
+    // Act - a burst of control bytes stands in for the binary an image paste delivers
+    await setup.mockInput.pasteBracketedText("
");
+
+    // Assert - the same placeholder the summary composer shows
+    await waitForText(setup, "see [Image #1]");
+  });
+
   test("a comment reopens with its mark painted on the code", async () => {
     // Arrange - a stored comment anchored to the added line's words
     server.core.sessionAnnotate(session.id, {

package/src/App.export.test.tsx

@@ -18,7 +18,6 @@ import type { Thread } from "@cueloop/schema";
 import { App } from "./App";
 import {
   isolateUserConfig,
-  press,
   waitForState,
   waitForText,
   pressKey,
@@ -81,7 +80,7 @@ describe("obsidian export on resolve", () => {
     await waitForText(setup, "[Approve]");
 
     // Act
-    await press(setup, "enter"); // submit
+    await pressKey(setup, "RETURN", { meta: true }); // submit
 
     // Assert
     // the export is an async round-trip after resolve; the status line lands

package/src/App.identity.test.tsx

@@ -0,0 +1,78 @@
+/** Reviewer identity surfaces: the Account settings tab and the author-name tooltip on a comment dot. */
+
+import { afterEach, beforeEach, expect, test } from "bun:test";
+import { mkdtempSync, rmSync } from "node:fs";
+import { tmpdir } from "node:os";
+import { join } from "node:path";
+import React from "react";
+import { DaemonServer } from "@cueloop/daemon";
+import { App } from "./App";
+import { isolateUserConfig, locateText, renderReadyApp, waitForText } from "./test-support";
+
+const PLAN = "# Migration Plan\n\nThe daemon persists sessions to disk atomically.\n";
+
+let home: string;
+let restoreUserConfig: () => void;
+let server: DaemonServer;
+let sessionId: string;
+
+beforeEach(() => {
+  home = mkdtempSync(join(tmpdir(), "cueloop-identity-"));
+  restoreUserConfig = isolateUserConfig(home);
+  server = new DaemonServer({ home, idleExitMs: 0 });
+  server.start();
+  const session = server.core.sessionCreate({
+    workspace: { repoRoot: "/repo", branch: "main" },
+    artifact: {
+      type: "plan",
+      content: PLAN,
+      meta: { title: "Migration Plan", planPath: "plan.md" },
+    },
+  });
+  sessionId = session.id;
+});
+afterEach(() => {
+  restoreUserConfig();
+  server.stop();
+  rmSync(home, { recursive: true, force: true });
+});
+
+async function renderApp() {
+  return renderReadyApp(<App home={home} sessionId={sessionId} />, { width: 120, height: 32 });
+}
+
+test("the Account settings tab shows the display name row and the GitHub sync action", async () => {
+  const setup = await renderApp();
+
+  await setup.mockMouse.click(1, 0);
+  await waitForText(setup, "Settings");
+  const menu = setup.captureCharFrame().split("\n");
+  const settingsRow = menu.findIndex((line) => line.includes("Settings"));
+
+  await setup.mockMouse.click(menu[settingsRow]!.indexOf("Settings") + 1, settingsRow);
+  await waitForText(setup, "Account");
+  const dialog = setup.captureCharFrame().split("\n");
+  const accountRow = dialog.findIndex((line) => line.includes("Account"));
+
+  await setup.mockMouse.click(dialog[accountRow]!.indexOf("Account") + 1, accountRow);
+  await waitForText(setup, "Display name");
+  expect(setup.captureCharFrame()).toContain("Sync from GitHub");
+});
+
+test("hovering an own comment's dot surfaces the author tooltip", async () => {
+  server.core.sessionAnnotate(sessionId, {
+    id: "a_own",
+    kind: "comment",
+    anchor: { quote: "atomically", prefix: "sessions to disk ", suffix: "." },
+    body: "My note.",
+  });
+  const setup = await renderApp();
+
+  await waitForText(setup, "● My note.");
+  // the tooltip is not painted until the pointer is over the dot
+  expect(setup.captureCharFrame()).not.toContain("you");
+  const dot = locateText(setup, "● My note.");
+
+  await setup.mockMouse.moveTo(dot.column, dot.row);
+  await waitForText(setup, "you");
+});

package/src/App.plan-review.test.tsx

@@ -228,6 +228,22 @@ describe("the mark stays painted while composing", () => {
     await waitForState(setup, () => server.core.sessionGet(session.id).annotations.length === 1);
     await waitForState(setup, () => backgroundsOf(setup, "The daemon").includes(THREAD_MARK));
   }, 60_000);
+
+  test("backspace on an empty draft dismisses the composer back to the mark", async () => {
+    // Arrange
+    const setup = await renderApp();
+
+    // Act: mark, type one character, then delete it and backspace again on the now-empty draft
+    await dragText(setup, "The daemon", "daemon persists", "daemon".length);
+    await type(setup, "x");
+    await waitForText(setup, "● x");
+    await press(setup, "backspace");
+    await press(setup, "backspace");
+
+    // Assert: the composer is gone and the mark stays, ready to re-type
+    await waitForTextGone(setup, "● x");
+    expect(backgroundsOf(setup, "The daemon")).toContain(THREAD_MARK);
+  }, 60_000);
 });
 
 describe("compose newline convention", () => {

package/src/App.share-choice.test.tsx

@@ -0,0 +1,105 @@
+/** The share shortcut opens an app-level public/private choice reachable from any view. */
+
+import { afterEach, beforeEach, describe, mock, test } from "bun:test";
+import { mkdtempSync, rmSync } from "node:fs";
+import { tmpdir } from "node:os";
+import { join } from "node:path";
+import React from "react";
+import { testRender } from "@opentui/react/test-utils";
+import { DaemonServer } from "@cueloop/daemon";
+import type { Thread } from "@cueloop/schema";
+import { App } from "./App";
+import type { ShareTransport } from "./thread-controller";
+import { isolateUserConfig, press, pressKey, waitForText, waitForTextGone } from "./test-support";
+
+const shareTransport: ShareTransport = {
+  publish: mock(async () => ({ line: "ssh p_share01@cueloop.dev", copied: true })),
+  pull: mock(async () => {
+    throw new Error("Unexpected share pull");
+  }),
+  push: mock(async () => {}),
+  watch: () => () => {},
+  parseShareId: (line) => line.match(/^ssh (\S+)@/)?.[1],
+  collaboratorAnnotations: () => [],
+  mergeFromShare: () => ({ annotations: [] }),
+};
+
+const PLAN = `# Migration Plan\n\n## Context\n\nThe daemon persists sessions to disk atomically.\n`;
+
+let home: string;
+let restoreUserConfig: () => void;
+let server: DaemonServer;
+let session: Thread;
+
+beforeEach(() => {
+  home = mkdtempSync(join(tmpdir(), "cueloop-share-choice-"));
+  restoreUserConfig = isolateUserConfig(home);
+  server = new DaemonServer({ home, idleExitMs: 0 });
+  server.start();
+  session = server.core.sessionCreate({
+    workspace: { repoRoot: "/repo", branch: "main" },
+    artifact: {
+      type: "plan",
+      content: PLAN,
+      meta: { title: "Migration Plan", planPath: "plan.md" },
+    },
+  });
+});
+afterEach(() => {
+  restoreUserConfig();
+  server.stop();
+  rmSync(home, { recursive: true, force: true });
+});
+
+describe("share choice", () => {
+  test("the shortcut opens the public/private choice", async () => {
+    // Arrange
+    const setup = await testRender(
+      <App home={home} sessionId={session.id} shareTransport={shareTransport} />,
+      { width: 120, height: 32 },
+    );
+    await waitForText(setup, "cueloop");
+
+    // Act
+    await pressKey(setup, "s", { ctrl: true });
+
+    // Assert
+    await waitForText(setup, "public link");
+    await waitForText(setup, "private link");
+  });
+
+  test("the private choice opens the manage-access surface", async () => {
+    // Arrange
+    const setup = await testRender(
+      <App home={home} sessionId={session.id} shareTransport={shareTransport} />,
+      { width: 120, height: 32 },
+    );
+    await waitForText(setup, "cueloop");
+
+    // Act: open the choice, move to private, select it
+    await pressKey(setup, "s", { ctrl: true });
+    await waitForText(setup, "private link");
+    await press(setup, "down");
+    await press(setup, "enter");
+
+    // Assert
+    await waitForText(setup, "Manage access");
+  });
+
+  test("escape cancels the choice without sharing", async () => {
+    // Arrange
+    const setup = await testRender(
+      <App home={home} sessionId={session.id} shareTransport={shareTransport} />,
+      { width: 120, height: 32 },
+    );
+    await waitForText(setup, "cueloop");
+
+    // Act
+    await pressKey(setup, "s", { ctrl: true });
+    await waitForText(setup, "public link");
+    await press(setup, "escape");
+
+    // Assert
+    await waitForTextGone(setup, "public link");
+  });
+});

package/src/App.submit-confirm.test.tsx

@@ -99,8 +99,8 @@ describe("send message confirm", () => {
     const frame = setup.captureCharFrame();
 
     expect(frame).toContain("[Approve]");
-    expect(frame).toContain(" send message ");
-    expect(frame).toContain(" Cancel ");
+    expect(frame).toContain(" send ");
+    expect(frame).toContain(" cancel ");
   });
 
   test("left/right cycles the verdict selector in the overlay", async () => {
@@ -146,7 +146,7 @@ describe("send message confirm", () => {
     // Assert - a bare ESC settles after the parser's escape-sequence window
     const frame = await waitForTextGone(setup, "[Approve]");
 
-    expect(frame).not.toContain(" Cancel ");
+    expect(frame).not.toContain(" cancel ");
   });
 
   test("enter in the overlay resolves the session through the controller", async () => {
@@ -162,7 +162,7 @@ describe("send message confirm", () => {
 
     // Act
     await setup.mockInput.typeText("Tighten the steps.");
-    await press(setup, "enter");
+    await pressKey(setup, "RETURN", { meta: true });
 
     // Assert - the completion flow after submit is unchanged
     await waitForText(setup, "feedback sent");
@@ -172,6 +172,35 @@ describe("send message confirm", () => {
     expect(stored.verdict!.kind).toBe("request_changes");
   });
 
+  test("typing / in the summary opens the skills/actions palette", async () => {
+    // Arrange
+    seedAnnotations(1);
+    const setup = await renderApp();
+    await pressKey(setup, "RETURN", { meta: true });
+    await waitForText(setup, "[Changes]");
+
+    // Act
+    await setup.mockInput.typeText("/restate");
+
+    // Assert - the same slash palette the inline composer shows
+    await waitForText(setup, "restate-simplified");
+  });
+
+  test("pasting an image into the summary drops in an [Image #n] placeholder", async () => {
+    // Arrange
+    const setup = await renderApp();
+    await pressKey(setup, "RETURN", { meta: true });
+    await waitForText(setup, "[Approve]");
+
+    // Act - a burst of control bytes stands in for the binary an image paste delivers
+    await setup.mockInput.typeText("look at this ");
+    await setup.mockInput.pasteBracketedText("
");
+
+    // Assert - the raw bytes never reach the draft; a numbered placeholder does
+    await waitForText(setup, "[Image #1]");
+    expect(setup.captureCharFrame()).toContain("look at this [Image #1]");
+  });
+
   test("read-only observers cannot open the confirm overlay", async () => {
     // Arrange
     seedAnnotations(1);
@@ -185,7 +214,7 @@ describe("send message confirm", () => {
     const frame = setup.captureCharFrame();
 
     expect(frame).not.toContain("[Changes]");
-    expect(frame).not.toContain(" Cancel ");
+    expect(frame).not.toContain(" cancel ");
     expect(server.core.sessionGet(session.id).status).toBe("pending");
   });
 });

package/src/App.test.tsx

@@ -207,7 +207,7 @@ describe("submit", () => {
 
     // Act
     await type(setup, "Expand the steps.");
-    await press(setup, "enter");
+    await pressKey(setup, "RETURN", { meta: true });
 
     // Assert
     await waitForText(setup, "feedback sent");
@@ -231,7 +231,7 @@ describe("submit", () => {
     await waitForText(setup, "[Approve]"); // no pending items → approve default
 
     // Act
-    await press(setup, "enter");
+    await pressKey(setup, "RETURN", { meta: true });
 
     // Assert
     await waitForState(setup, () => server.core.sessionGet(session.id).verdict !== undefined);

package/src/App.toast.test.tsx

@@ -73,8 +73,10 @@ describe("share toast", () => {
 
     await waitForText(setup, "cueloop");
 
-    // Act: share raises the toast, then open a composer under it by typing
+    // Act: share opens the choice, enter picks public and raises the toast, then a composer under it
     await pressKey(setup, "s", { ctrl: true });
+    await waitForText(setup, "public link");
+    await press(setup, "enter");
     await waitForText(setup, "share link copied");
     await clickText(setup, "daemon");
     await typeText(setup, "x");