@cueloop/client 0.1.0-alpha.65 → 0.1.0-alpha.66

package/src/App.test.tsx

@@ -71,7 +71,7 @@ async function renderApp(sessionId?: string) {
 }
 
 describe("plan rendering", () => {
-  test("renders the plan with headings, list markers, and the rail", async () => {
+  test("renders the plan with headings, list markers, and the footer", async () => {
     // Arrange
     const setup = await renderApp();
 
@@ -82,8 +82,22 @@ describe("plan rendering", () => {
     expect(frame).toContain("Context");
     expect(frame).toContain("persists sessions to disk atomically");
     expect(frame).toContain("· move the store");
-    expect(frame).toContain("Review");
-    expect(frame).toContain("Submit review");
+    expect(frame).toContain("send message");
+  });
+
+  test("a direct open still populates the Threads sidebar with other pending reviews", async () => {
+    // Arrange - a second pending review exists alongside the one opened directly
+    server.core.sessionCreate({
+      workspace: { repoRoot: "/repo", branch: "main" },
+      artifact: { type: "plan", content: "# Other Plan\n", meta: { title: "Other Plan" } },
+    });
+    const setup = await renderApp();
+
+    // Act - open the collapsed Threads sidebar (the mirrored panel toggle by the gear)
+    await setup.mockMouse.click(3, 1);
+
+    // Assert - the sidebar lists the other pending review, so you can jump to it
+    await waitForText(setup, "Other Plan");
   });
 });
 
@@ -113,7 +127,7 @@ describe("thread view grammar", () => {
     await pressKey(setup, "RETURN", { meta: true });
 
     // Assert
-    await waitForText(setup, "COMMENT");
+    await waitForState(setup, () => server.core.sessionGet(session.id).annotations.length === 1);
     const stored = server.core.sessionGet(session.id);
 
     expect(stored.annotations.length).toBe(1);
@@ -144,9 +158,11 @@ describe("thread view grammar", () => {
     // Act
     await pressKey(setup, "x", { meta: true });
 
-    // Assert - the rail shows the cut as a removal card titled CUT · me
-    await waitForText(setup, "CUT · me");
-    expect(server.core.sessionGet(session.id).workingCopy).not.toContain("move the store");
+    // Assert - the cut lands in the working copy
+    await waitForState(
+      setup,
+      () => !(server.core.sessionGet(session.id).workingCopy ?? "").includes("move the store"),
+    );
 
     // Act
     await pressKey(setup, "x", { meta: true });
@@ -228,25 +244,24 @@ describe("submit", () => {
 });
 
 describe("inbox", () => {
-  test("inbox mode wears the review chrome (header + menu bar) and opens a session", async () => {
+  test("inbox mode wears the review header and opens a session", async () => {
     // Arrange
     const setup = await testRender(<App home={home} />, { width: 120, height: 32 });
 
     await waitForText(setup, "cueloop");
 
-    // Assert - the same header/menu chrome as review, plus the session row
+    // Assert - the same header as review, plus the session row
     const frame = setup.captureCharFrame();
 
     expect(frame).toContain("cueloop · resume");
     expect(frame).toContain("Migration Plan");
-    expect(frame).toContain("menu"); // the shared MenuBar sits at the bottom
     expect(frame).not.toContain("inbox ("); // the old inline header is gone
 
     // Act
     await press(setup, "enter");
 
     // Assert
-    await waitForText(setup, "Submit review");
+    await waitForText(setup, "send message");
   });
 
   test("the menu opens from the inbox and escape is not a trap", async () => {
@@ -254,12 +269,9 @@ describe("inbox", () => {
     const setup = await testRender(<App home={home} />, { width: 120, height: 32 });
 
     await waitForText(setup, "cueloop · resume");
-    const lines = setup.captureCharFrame().split("\n");
-    const menuRow = lines.findIndex((line) => line.includes("menu"));
-    const menuColumn = lines[menuRow]!.indexOf("menu");
 
-    // Act - open the drop-up from the shared menu bar
-    await setup.mockMouse.click(menuColumn + 1, menuRow);
+    // Act - open the drop-down from the top-left settings gear (header content row)
+    await setup.mockMouse.click(1, 1);
 
     // Assert - the drop-up options appear
     await waitForText(setup, "Keybinds");
@@ -271,7 +283,7 @@ describe("inbox", () => {
     await press(setup, "enter");
 
     // Assert
-    await waitForText(setup, "Submit review");
+    await waitForText(setup, "send message");
   });
 });
 
@@ -281,12 +293,9 @@ describe("the thread view and the menu", () => {
     const setup = await renderApp();
 
     await waitForText(setup, "The daemon persists");
-    const lines = setup.captureCharFrame().split("\n");
-    const menuRow = lines.findIndex((line) => line.includes("menu"));
-    const menuColumn = lines[menuRow]!.indexOf("menu");
 
-    // Act - open the menu, then the keybinds dialog
-    await setup.mockMouse.click(menuColumn + 1, menuRow);
+    // Act - open the menu from the top-left settings gear, then the keybinds dialog
+    await setup.mockMouse.click(1, 1);
     await waitForText(setup, "Keybinds");
     const dropUp = setup.captureCharFrame().split("\n");
     const keybindsRow = dropUp.findIndex((line) => line.includes("Keybinds"));
@@ -298,7 +307,7 @@ describe("the thread view and the menu", () => {
     const dialog = setup.captureCharFrame();
 
     expect(dialog).toContain("⌘⌥m");
-    expect(dialog).toContain("dismiss an empty draft");
+    expect(dialog).toContain("place the caret");
     expect(dialog).not.toContain("grow/shrink");
 
     // Act - a printable behind the dialog must not open a comment; escape closes it
@@ -307,7 +316,44 @@ describe("the thread view and the menu", () => {
     await press(setup, "escape");
 
     // Assert
-    await waitForState(setup, () => !setup.captureCharFrame().includes("dismiss an empty draft"));
+    await waitForState(setup, () => !setup.captureCharFrame().includes("mark text, across blocks"));
     expect(setup.captureCharFrame()).not.toContain("● x");
   });
+
+  test("clicking the Settings nav group is inert and never corrupts the active category", async () => {
+    // Arrange - open the settings dialog from the gear
+    const setup = await renderApp();
+
+    await setup.mockMouse.click(1, 1);
+    await waitForText(setup, "Keybinds");
+
+    // the nav folder is the last "Settings" on screen (the first is the dialog title)
+    const lines = setup.captureCharFrame().split("\n");
+    let folderRow = -1;
+    let folderColumn = -1;
+
+    lines.forEach((line, row) => {
+      const column = line.indexOf("Settings");
+
+      if (column !== -1) {
+        folderColumn = column;
+        folderRow = row;
+      }
+    });
+
+    // Act - click the synthetic Settings group folder, then press a nav key. The
+    // key handler dereferences the active category, so a corrupt id would throw
+    // (the global key handler swallows the throw into console.error).
+    const keyHandlerErrors: string[] = [];
+    const originalConsoleError = console.error;
+
+    console.error = (...args: unknown[]) => keyHandlerErrors.push(args.map(String).join(" "));
+    await setup.mockMouse.click(folderColumn + 1, folderRow);
+    await pressKey(setup, "ARROW_DOWN");
+    console.error = originalConsoleError;
+
+    // Assert - no key-handler crash, and the dialog is still up
+    expect(keyHandlerErrors.filter((line) => line.includes("keypress handler"))).toEqual([]);
+    expect(setup.captureCharFrame()).toContain("Keybinds");
+  });
 });