@cueloop/client 0.1.0-alpha.65 → 0.1.0-alpha.66

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cueloop/client",
-  "version": "0.1.0-alpha.65",
+  "version": "0.1.0-alpha.66",
   "description": "The cueloop review UI: projection renderer, keyboard grammar, review rail",
   "homepage": "https://github.com/mmurakaru/cueloop#readme",
   "bugs": {
@@ -26,10 +26,10 @@
     "access": "public"
   },
   "dependencies": {
-    "@cueloop/daemon": "0.1.0-alpha.65",
-    "@cueloop/extension-api": "0.1.0-alpha.65",
-    "@cueloop/integration-obsidian": "0.1.0-alpha.65",
-    "@cueloop/schema": "0.1.0-alpha.65",
+    "@cueloop/daemon": "0.1.0-alpha.66",
+    "@cueloop/extension-api": "0.1.0-alpha.66",
+    "@cueloop/integration-obsidian": "0.1.0-alpha.66",
+    "@cueloop/schema": "0.1.0-alpha.66",
     "@opentui/core": "^0.5.8",
     "@opentui/keymap": "0.5.8",
     "@opentui/react": "^0.5.8",

package/src/App.diff.test.tsx

@@ -152,50 +152,9 @@ describe("diff review", () => {
     expect(stored.workingCopy).toBe("");
   });
 
-  test("a rejected change lists in the rail and undo (u) restores it", async () => {
-    // Arrange - a diff session that carries full file contents
-    const withFiles = server.core.sessionCreate({
-      workspace: { repoRoot: "/repo", branch: "main" },
-      artifact: {
-        type: "diff",
-        content: PATCH,
-        meta: { title: "working tree" },
-        files: [
-          {
-            path: "src/store.ts",
-            oldContents: "export class Store {\n  private items = [];\n}\n",
-            newContents: "export class Store {\n  private items = new Map();\n}\n",
-            status: "modified",
-          },
-        ],
-      },
-    });
-    const setup = await testRender(<App home={home} sessionId={withFiles.id} />, {
-      width: 120,
-      height: 30,
-    });
-
-    await waitForText(setup, "cueloop");
-
-    // Act - reject the change under the added line
-    // rows: file(0), hunk(1), ctx(2), del(3), add(4)
-    for (let i = 0; i < 4; i++) await press(setup, "j");
-    await press(setup, "x");
-
-    // Assert - the rail shows a removal card titled REJECT · me for the change
-    await waitForText(setup, "REJECT · me");
-    expect(server.core.sessionGet(withFiles.id).workingCopy).toBe("");
-
-    // Act - undo restores it (no selection, so the last item)
-    await press(setup, "u");
-
-    // Assert - the change returns to the curated diff (working copy cleared)
-    await waitForText(setup, "removal restored");
-    expect(server.core.sessionGet(withFiles.id).workingCopy).toBeUndefined();
-  });
-
-  test("a selected removal card shows an undo button that restores it on click", async () => {
-    // Arrange - a diff session that carries full file contents
+  test("a diff opens with the Changes column listing every changed file", async () => {
+    // Arrange - two changed files; config.ts is not in the patch text, so it can
+    // only appear here by way of the Changes column reading artifact.files
     const withFiles = server.core.sessionCreate({
       workspace: { repoRoot: "/repo", branch: "main" },
       artifact: {
@@ -203,12 +162,8 @@ describe("diff review", () => {
         content: PATCH,
         meta: { title: "working tree" },
         files: [
-          {
-            path: "src/store.ts",
-            oldContents: "export class Store {\n  private items = [];\n}\n",
-            newContents: "export class Store {\n  private items = new Map();\n}\n",
-            status: "modified",
-          },
+          { path: "src/store.ts", oldContents: "a", newContents: "b", status: "modified" },
+          { path: "src/config.ts", oldContents: "", newContents: "c", status: "added" },
         ],
       },
     });
@@ -219,28 +174,8 @@ describe("diff review", () => {
 
     await waitForText(setup, "cueloop");
 
-    // Act - reject the change; the removal card lands unselected (no undo button)
-    for (let i = 0; i < 4; i++) await press(setup, "j");
-    await press(setup, "x");
-    await waitForText(setup, "REJECT · me");
-    expect(setup.captureCharFrame()).not.toContain("undo");
-
-    // Act - click the card to select it; the undo button appears
-    const clickText = async (needle: string): Promise<void> => {
-      const lines = setup.captureCharFrame().split("\n");
-      const row = lines.findIndex((line) => line.includes(needle));
-
-      await setup.mockMouse.click(lines[row]!.indexOf(needle) + 1, row);
-    };
-
-    await clickText("REJECT · me");
-    await waitForText(setup, "undo");
-
-    // Act - click the undo button
-    await clickText("undo");
-
-    // Assert - the change returns to the curated diff (working copy cleared)
-    await waitForText(setup, "removal restored");
-    expect(server.core.sessionGet(withFiles.id).workingCopy).toBeUndefined();
+    // Assert - the context default opens the column for a diff, so both files show
+    await waitForText(setup, "config.ts");
+    expect(setup.captureCharFrame()).toContain("store.ts");
   });
 });

package/src/App.plan-review.test.tsx

@@ -10,7 +10,6 @@ import { DaemonServer } from "@cueloop/daemon";
 import type { ReviewSession } from "@cueloop/schema";
 import { App } from "./App";
 import { DEFAULT_QUICK_ACTIONS, quickActionBody } from "./config";
-import { DARK } from "./theme";
 import {
   clickText,
   dragText,
@@ -166,31 +165,6 @@ describe("edit affordance", () => {
   });
 });
 
-describe("attribution", () => {
-  test("a collaborator's note shows their name in the card border", async () => {
-    // Arrange - a pulled collaborator note carries an author fingerprint
-    const { makeAnchor, parseBlocks } = await import("@cueloop/schema");
-    const blocks = parseBlocks(PLAN);
-    const contextBlockIndex = blocks.findIndex((block) =>
-      block.text.startsWith("The daemon persists"),
-    );
-
-    server.core.sessionAnnotate(session.id, {
-      id: "collab-1",
-      kind: "comment",
-      anchor: makeAnchor(blocks, contextBlockIndex, 0, 10),
-      body: "who owns retries?",
-      author: "SHA256:1a2b3c4d5e6f",
-    });
-
-    // Act
-    const setup = await renderApp();
-
-    // Assert - the short author handle rides the card border
-    await waitForText(setup, "1a2b3c4d");
-  });
-});
-
 describe("marks feed the comment anchor", () => {
   test("a drag marks a character-precise span and typing anchors the comment to it", async () => {
     // Arrange
@@ -299,140 +273,6 @@ describe("compose newline convention", () => {
   });
 });
 
-describe("the document selects, the rail edits", () => {
-  test("option+e edits the focused card in place; enter saves through the controller", async () => {
-    // Arrange
-    const setup = await renderApp();
-
-    await clickText(setup, "daemon");
-    await type(setup, "Needs a citation.");
-    await pressKey(setup, "RETURN", { meta: true });
-    await waitForText(setup, "COMMENT · me");
-
-    // Act: focus the card, then turn its body into an input in place
-    await pressKey(setup, "n", { meta: true });
-    await pressKey(setup, "e", { meta: true });
-    await type(setup, " And a link.");
-    await press(setup, "enter");
-
-    // Assert
-    await waitForState(
-      setup,
-      () =>
-        server.core.sessionGet(session.id).annotations[0]!.body === "Needs a citation. And a link.",
-    );
-  });
-
-  test("activating a collaborator's card opens rename, not a body edit", async () => {
-    // Arrange - a pulled collaborator note carries an author fingerprint
-    const { makeAnchor, parseBlocks } = await import("@cueloop/schema");
-    const blocks = parseBlocks(PLAN);
-    const contextBlockIndex = blocks.findIndex((block) =>
-      block.text.startsWith("The daemon persists"),
-    );
-
-    server.core.sessionAnnotate(session.id, {
-      id: "collab-1",
-      kind: "comment",
-      anchor: makeAnchor(blocks, contextBlockIndex, 0, 10),
-      body: "who owns retries?",
-      author: "SHA256:1a2b3c4d5e6f",
-    });
-    const setup = await renderApp();
-
-    await waitForText(setup, "1a2b3c4d");
-
-    // Act - focus the collaborator card, then activate it
-    await pressKey(setup, "n", { meta: true });
-    await pressKey(setup, "e", { meta: true });
-
-    // Assert - the rename prompt opens; the body never becomes an editor
-    await waitForText(setup, "Rename author");
-  });
-
-  test("option+backspace deletes the focused card and un-paints the document mark", async () => {
-    // Arrange
-    const setup = await renderApp();
-
-    await dragText(setup, "daemon", "daemon persists", "daemon".length);
-    await type(setup, "Delete me.");
-    await pressKey(setup, "RETURN", { meta: true });
-    await waitForText(setup, "COMMENT · me");
-    expect(server.core.sessionGet(session.id).annotations.length).toBe(1);
-    await waitForState(setup, () => backgroundsOf(setup, "daemon").includes(THREAD_MARK));
-
-    // Act
-    await pressKey(setup, "n", { meta: true });
-    await pressKey(setup, "BACKSPACE", { meta: true });
-
-    // Assert
-    await waitForTextGone(setup, "COMMENT · me");
-    expect(server.core.sessionGet(session.id).annotations.length).toBe(0);
-    expect(backgroundsOf(setup, "daemon")).not.toContain(THREAD_MARK);
-  });
-});
-
-describe("plan cut removals", () => {
-  test("option+x cuts the caret's block into a rail removal card and option+u restores it", async () => {
-    // Arrange
-    const setup = await renderApp();
-
-    await clickText(setup, "daemon");
-
-    // Act - no card is focused, so the cut takes the block under the caret
-    await pressKey(setup, "x", { meta: true });
-
-    // Assert - the rail shows a removal card titled CUT · me for the cut block
-    await waitForText(setup, "CUT · me");
-    await waitForState(setup, () => server.core.sessionGet(session.id).workingCopy !== undefined);
-
-    // Act - undo restores it (no selection, so the last removal)
-    await pressKey(setup, "u", { meta: true });
-
-    // Assert - the block returns and the working copy is pristine again
-    await waitForText(setup, "removal restored");
-    await waitForState(setup, () => server.core.sessionGet(session.id).workingCopy === undefined);
-  });
-});
-
-describe("addressed annotations leave the open list", () => {
-  test("a revision that addresses one card hides it, un-paints it, and shows the count", async () => {
-    // Arrange: two annotations through the daemon, then a revision addressing one
-    const { makeAnchor, parseBlocks } = await import("@cueloop/schema");
-    const blocks = parseBlocks(PLAN);
-    const contextBlockIndex = blocks.findIndex((block) =>
-      block.text.startsWith("The daemon persists"),
-    );
-
-    server.core.sessionAnnotate(session.id, {
-      id: "a_settled",
-      kind: "comment",
-      anchor: makeAnchor(blocks, contextBlockIndex, 0, 10), // "The daemon"
-      body: "settled note",
-    });
-    server.core.sessionAnnotate(session.id, {
-      id: "a_open",
-      kind: "comment",
-      anchor: makeAnchor(blocks, contextBlockIndex, 11, 19), // "persists"
-      body: "still open note",
-    });
-    server.core.sessionSubmitRevision(session.id, PLAN, ["a_settled"]);
-
-    // Act
-    const setup = await renderApp();
-
-    await waitForText(setup, "still open note");
-
-    // Assert: the open card renders, the addressed one is gone behind the count
-    const frame = setup.captureCharFrame();
-
-    expect(frame).toContain("✓ 1 addressed by revision");
-    expect(frame).not.toContain("settled note");
-    expect(frame).toContain("still open note"); // the open card survives; the addressed one does not
-    expect(backgroundsOf(setup, "The daemon")).not.toContain(DARK.markCommentBackground); // no highlight paint
-  });
-});
-
 describe("sheet header", () => {
   test("shows the submitting agent, the revision, and the Edit and Share word-buttons", async () => {
     // Arrange
@@ -446,25 +286,6 @@ describe("sheet header", () => {
     expect(frame).toContain("Edit");
     expect(frame).toContain("Share");
   });
-
-  test("the Agent tab shows the text-only harness launcher buttons", async () => {
-    // Arrange
-    const setup = await renderApp();
-    const lines = setup.captureCharFrame().split("\n");
-    const tabRow = lines.findIndex((line) => line.includes("Review") && line.includes("Agent"));
-    const tabColumn = lines[tabRow]!.indexOf("Agent");
-
-    // Act
-    await setup.mockMouse.click(tabColumn + 1, tabRow);
-    await setup.renderOnce();
-
-    // Assert - the three launcher buttons, in order
-    await waitForText(setup, "Claude Code");
-    const frame = setup.captureCharFrame();
-
-    expect(frame).toContain("Pi");
-    expect(frame).toContain("OpenAI Codex");
-  });
 });
 
 describe("quick-actions settings editor", () => {
@@ -472,8 +293,8 @@ describe("quick-actions settings editor", () => {
     // Arrange
     const setup = await renderApp();
 
-    // Act - open Settings, enter Actions, expand the first action, type into its input
-    await clickText(setup, "menu");
+    // Act - open Settings from the top-left gear, enter Actions, expand the first action, type
+    await setup.mockMouse.click(1, 1);
     await clickText(setup, "Settings");
     await clickText(setup, "Actions");
     await clickText(setup, "Zoom out, research in depth");
@@ -502,15 +323,13 @@ describe("edit-exit reconciliation", () => {
       await clickText(setup, "daemon");
       await type(setup, "Anchor me to the doomed passage.");
       await pressKey(setup, "RETURN", { meta: true });
-      await waitForText(setup, "COMMENT · me");
+      await waitForState(setup, () => server.core.sessionGet(session.id).annotations.length === 1);
 
       // Act
       await pressKey(setup, "e", { ctrl: true });
 
-      // Assert
+      // Assert - the thread view banner reports the orphaned annotation
       await waitForText(setup, "1 annotation no longer match - the passage was removed.");
-      // the rail card flips to ORPHANED once the working-copy refresh lands
-      await waitForText(setup, "· ORPHANED");
       // the annotation is NOT deleted: the feedback serializer handles orphans
       expect(server.core.sessionGet(session.id).annotations.length).toBe(1);
     } finally {

package/src/App.prototype.test.tsx

@@ -105,7 +105,7 @@ async function clickText(setup: Setup, needle: string): Promise<void> {
 }
 
 describe("prototype review", () => {
-  test("click an element, comment on it, and it lands in the rail", async () => {
+  test("click an element, comment on it, and it saves to the daemon", async () => {
     // Arrange - wait until the fake browser produced its first screenshot, so
     // the sheet is interactive before the click
     const setup = await renderApp();
@@ -135,13 +135,6 @@ describe("prototype review", () => {
     expect(stored.kind).toBe("comment");
     expect(stored.body).toBe("tighten the padding");
     expect(stored.anchor.selector).toBe("main > div.card");
-
-    // and it renders in the rail
-    await settle(setup);
-    const frame = setup.captureCharFrame();
-
-    expect(frame).toContain("tighten the padding");
-    expect(frame).toContain("COMMENT");
   });
 
   test("escape cancels the compose, matching the plan composer", async () => {

package/src/App.readonly.test.tsx

@@ -9,7 +9,6 @@ import { testRender } from "@opentui/react/test-utils";
 import { DaemonServer } from "@cueloop/daemon";
 import { makeAnchor, parseBlocks, type ReviewSession } from "@cueloop/schema";
 import { App } from "./App";
-import { DARK } from "./theme";
 import {
   clickText,
   dragText,
@@ -17,7 +16,6 @@ import {
   isolateUserConfig,
   pressKey,
   typeText,
-  waitForState,
   waitForText,
 } from "./test-support";
 
@@ -83,15 +81,12 @@ function snapshot() {
 }
 
 describe("observer rendering", () => {
-  test("shows the observer badge and the bottom menu", async () => {
+  test("shows the observer badge in the header", async () => {
     // Arrange
     const setup = await renderObserver();
 
     // Assert
-    const frame = setup.captureCharFrame();
-
-    expect(frame).toContain("· observer");
-    expect(frame).toContain("menu");
+    expect(setup.captureCharFrame()).toContain("· observer");
   });
 });
 
@@ -199,29 +194,12 @@ describe("observer navigation still works", () => {
     });
     const setup = await renderObserver();
 
-    // Act
+    // Act - the observer navigates to the annotation without mutating anything
     await pressKey(setup, "n", { meta: true });
     await setup.renderOnce();
 
-    // Assert - focus shows as the card's blue border (transparent fill); a
-    // comment card is the only blue-bordered box in the frame
-    await waitForText(setup, "COMMENT · me");
-    await waitForState(setup, () => hasBorderColor(setup, DARK.blue));
+    // Assert - the observer reads the controller's comment inline in the thread
+    await waitForText(setup, "From the controller.");
+    expect(snapshot().annotations).toBe(1);
   });
 });
-
-/** Whether any border character (box-drawing) is painted in the given foreground hex. */
-function hasBorderColor(setup: Awaited<ReturnType<typeof renderObserver>>, hex: string): boolean {
-  for (const line of setup.captureSpans().lines) {
-    for (const span of line.spans) {
-      if (!/[╭╮╰╯│─┌┐└┘]/.test(span.text)) continue;
-      const [red, green, blue] = span.fg.toInts();
-      const rendered =
-        "#" + [red, green, blue].map((part) => part.toString(16).padStart(2, "0")).join("");
-
-      if (rendered === hex) return true;
-    }
-  }
-
-  return false;
-}

package/src/App.submit-confirm.test.tsx

@@ -1,4 +1,4 @@
-/** The rail submit confirm (tier 2): pressing submit expands the rail's Submit button into a bordered confirm card - counts, verdict selector, summary input, word-buttons. Char-frame assertions over the real App and an in-process daemon, like App.test.tsx. */
+/** The send-message confirm: cmd+enter opens a centered overlay with a verdict selector, summary input, and word-buttons. Char-frame assertions over the real App and an in-process daemon, like App.test.tsx. */
 
 import { afterEach, beforeEach, describe, expect, test } from "bun:test";
 import { mkdtempSync, rmSync } from "node:fs";
@@ -83,29 +83,27 @@ function seedAnnotations(count: number): void {
   }
 }
 
-describe("rail submit confirm", () => {
-  test("submit expands the Submit button into the confirm card", async () => {
+describe("send message confirm", () => {
+  test("cmd+enter opens the send-message confirm overlay", async () => {
     // Arrange
     const setup = await renderApp();
 
-    // Assert
-    expect(setup.captureCharFrame()).toContain("Submit review");
+    // Assert - the footer carries the send control before the overlay opens
+    expect(setup.captureCharFrame()).toContain("send message");
 
     // Act
     await pressKey(setup, "RETURN", { meta: true });
 
-    // Assert
-    await waitForText(setup, "submit review");
+    // Assert - the overlay: verdict selector and word-buttons
+    await waitForText(setup, "[Approve]"); // nothing pending: approve default
     const frame = setup.captureCharFrame();
 
-    // the card: title, verdict selector, word-buttons
-    expect(frame).toContain("submit review");
-    expect(frame).toContain("[Approve]"); // nothing pending: approve default
-    expect(frame).toContain(" Submit ");
+    expect(frame).toContain("[Approve]");
+    expect(frame).toContain(" send message ");
     expect(frame).toContain(" Cancel ");
   });
 
-  test("left/right cycles the verdict selector in the card", async () => {
+  test("left/right cycles the verdict selector in the overlay", async () => {
     // Arrange
     const setup = await renderApp();
 
@@ -133,7 +131,7 @@ describe("rail submit confirm", () => {
     await waitForText(setup, "[Changes]");
   });
 
-  test("esc cancels the card and restores the plain Submit button", async () => {
+  test("esc closes the overlay", async () => {
     // Arrange
     const setup = await renderApp();
 
@@ -145,15 +143,13 @@ describe("rail submit confirm", () => {
     // Act
     await press(setup, "escape");
 
-    // Assert
-    // a bare ESC settles after the parser's escape-sequence window
+    // Assert - a bare ESC settles after the parser's escape-sequence window
     const frame = await waitForTextGone(setup, "[Approve]");
 
-    expect(frame).not.toContain("submit review");
-    expect(frame).toContain("Submit review");
+    expect(frame).not.toContain(" Cancel ");
   });
 
-  test("enter in the card resolves the session through the controller", async () => {
+  test("enter in the overlay resolves the session through the controller", async () => {
     // Arrange
     seedAnnotations(1);
     const setup = await renderApp();
@@ -163,16 +159,12 @@ describe("rail submit confirm", () => {
 
     // Assert
     await waitForText(setup, "[Changes]"); // pending items: request changes default
-    const frame = setup.captureCharFrame();
-
-    expect(frame).toContain("submit review");
 
     // Act
     await setup.mockInput.typeText("Tighten the steps.");
     await press(setup, "enter");
 
-    // Assert
-    // the completion flow after submit is unchanged
+    // Assert - the completion flow after submit is unchanged
     await waitForText(setup, "feedback sent");
     const stored = server.core.sessionGet(session.id);
 
@@ -180,65 +172,20 @@ describe("rail submit confirm", () => {
     expect(stored.verdict!.kind).toBe("request_changes");
   });
 
-  /** The rail's columns of the frame, so document text never leaks into a rail assertion. */
-  function railText(frame: string): string {
-    const rows = frame.split("\n");
-    const railColumn = rows.find((row) => row.includes("Review  Tree  Agent"))!.indexOf("│");
-
-    return rows.map((row) => row.slice(railColumn)).join("\n");
-  }
-
-  test("the annotation stack stays scrollable while the card is open", async () => {
-    // Arrange
-    seedAnnotations(12);
-    const setup = await renderApp();
-
-    // Act
-    // walk card focus to the last one: the rail scrolls it into view
-    for (let index = 0; index < 12; index++) await pressKey(setup, "n", { meta: true });
-
-    // Assert
-    await waitForText(setup, "note 12");
-    expect(railText(setup.captureCharFrame())).not.toContain("note 01");
-
-    // Act
-    await pressKey(setup, "RETURN", { meta: true });
-
-    // Assert
-    await waitForText(setup, "[Changes]");
-    // the card is pinned outside the scrollbox; the stack stays scrolled off the top
-    expect(railText(setup.captureCharFrame())).not.toContain("note 01");
-
-    // Act
-    // the stack still scrolls with the card open: wheel over the rail
-    // brings the last card back into view while the confirm card stays put
-    for (let turn = 0; turn < 12; turn++) await setup.mockMouse.scroll(100, 10, "down");
-    await settle(setup);
-
-    // Assert
-    await waitForText(setup, "note 12");
-    const scrolledWithCard = railText(setup.captureCharFrame());
-
-    expect(scrolledWithCard).toContain("submit review");
-    expect(scrolledWithCard).not.toContain("note 01");
-  });
-
-  test("read-only observers never see the confirm card", async () => {
+  test("read-only observers cannot open the confirm overlay", async () => {
     // Arrange
     seedAnnotations(1);
     const setup = await renderApp({ readOnly: true });
 
     // Act
     await pressKey(setup, "RETURN", { meta: true });
+    await settle(setup);
 
-    // Assert
-    await waitForText(setup, "observer - read-only");
+    // Assert - no overlay, and the session stays pending
     const frame = setup.captureCharFrame();
 
-    expect(frame).toContain("observer - read-only");
-    expect(frame).not.toContain("1 annotations");
     expect(frame).not.toContain("[Changes]");
-    expect(setup.captureCharFrame()).not.toContain("verdict ←/→");
+    expect(frame).not.toContain(" Cancel ");
     expect(server.core.sessionGet(session.id).status).toBe("pending");
   });
 });