@croct/eslint-plugin 0.7.1 → 0.8.1

package/index.js

@@ -1,8 +1,30 @@
 "use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.rules = exports.configs = void 0;
 const rules_1 = require("./rules");
-const configs_1 = require("./configs");
-const configuration = {
+Object.defineProperty(exports, "rules", { enumerable: true, get: function () { return rules_1.rules; } });
+const javascript_1 = require("./configs/javascript");
+const typescript_1 = require("./configs/typescript");
+const react_1 = require("./configs/react");
+const cypress_1 = require("./configs/cypress");
+// Create the plugin with just the rules first
+const plugin = {
+    // Cast from TypeScript Rule Module to ESLint RuleDefinition.
+    // Due to variance, TS can't verify the type directly.
     rules: rules_1.rules,
-    configs: configs_1.configs,
+    configs: {},
 };
-module.exports = configuration;
+// Create configs with the plugin reference
+const javascriptConfig = (0, javascript_1.createJavaScriptConfig)(plugin);
+const typescriptConfig = (0, typescript_1.createTypescriptConfig)(plugin, javascriptConfig);
+const reactConfig = (0, react_1.createReactConfig)(plugin, javascriptConfig);
+const cypressConfig = (0, cypress_1.createCypressConfig)(plugin, javascriptConfig);
+exports.configs = {
+    javascript: javascriptConfig,
+    typescript: typescriptConfig,
+    react: reactConfig,
+    cypress: cypressConfig,
+};
+Object.assign(plugin.configs, exports.configs);
+// Export the plugin as default
+exports.default = plugin;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@croct/eslint-plugin",
-  "version": "0.7.1",
+  "version": "0.8.1",
   "description": "ESLint rules and presets applied to all Croct JavaScript projects.",
   "license": "MIT",
   "author": {
@@ -36,39 +36,38 @@
     "cypress"
   ],
   "dependencies": {
-    "@rushstack/eslint-patch": "^1.1",
-    "@typescript-eslint/eslint-plugin": "^6.4.0",
-    "@typescript-eslint/utils": "^6.4.0",
-    "eslint-config-airbnb": "^19.0",
-    "eslint-config-airbnb-base": "^15.0",
-    "eslint-plugin-cypress": "^2.12",
-    "eslint-plugin-eslint-comments": "^3.2.0",
-    "eslint-plugin-import": "^2.25",
-    "eslint-plugin-import-newlines": "^1.1",
-    "eslint-plugin-jest": "^27.0.0",
-    "eslint-plugin-jest-dom": "^5.0.0",
-    "eslint-plugin-jsx-a11y": "^6.5",
-    "eslint-plugin-newline-destructuring": "^1.0.1",
-    "eslint-plugin-no-smart-quotes": "^1.3",
-    "eslint-plugin-react": "^7.28",
-    "eslint-plugin-react-hooks": "^4.3",
-    "eslint-plugin-testing-library": "^6.0.0"
+    "@eslint-community/eslint-plugin-eslint-comments": "^4.5.0",
+    "@stylistic/eslint-plugin": "^5.7.0",
+    "@typescript-eslint/utils": "^8.53.0",
+    "eslint-plugin-cypress": "^5.2.1",
+    "eslint-plugin-import-newlines": "^1.4.0",
+    "eslint-plugin-import-x": "^4.16.1",
+    "eslint-plugin-jest": "^29.12.1",
+    "eslint-plugin-jest-dom": "^5.5.0",
+    "eslint-plugin-jsx-a11y": "^6.10.2",
+    "eslint-plugin-newline-destructuring": "^1.2.2",
+    "eslint-plugin-react": "^7.37.5",
+    "eslint-plugin-react-hooks": "^5.2.0",
+    "eslint-plugin-testing-library": "^7.15.4",
+    "globals": "^17.0.0",
+    "typescript-eslint": "^8.53.0"
   },
   "devDependencies": {
-    "@types/eslint": "^8.4",
-    "@types/jest": "^29.0.0",
-    "@types/semver": "^7.3.12",
-    "@typescript-eslint/parser": "^6.4.0",
-    "@typescript-eslint/types": "^6.4.0",
-    "eslint": "^8.8",
-    "eslint-plugin-eslint-plugin": "^5.0.0",
+    "@types/jest": "^29.5.14",
+    "@types/semver": "^7.5.8",
+    "@typescript-eslint/parser": "^8.53.0",
+    "@typescript-eslint/rule-tester": "^8.53.0",
+    "@typescript-eslint/types": "^8.53.0",
+    "@typescript-eslint/typescript-estree": "^8.53.0",
+    "eslint": "^9.28.0",
+    "eslint-plugin-eslint-plugin": "^6.4.0",
     "eslint-plugin-self": "^1.2.1",
-    "jest": "^29.0.0",
-    "ts-jest": "^29.0.0",
-    "typescript": "^5.0.0"
+    "jest": "^29.7.0",
+    "ts-jest": "^29.3.4",
+    "typescript": "~5.9.0"
   },
   "peerDependencies": {
-    "@typescript-eslint/parser": ">= 6",
-    "eslint": ">= 8"
+    "@typescript-eslint/parser": ">= 8",
+    "eslint": ">= 9"
   }
 }

package/rules/argument-spacing/index.js

@@ -1,6 +1,7 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.argumentSpacing = void 0;
+const utils_1 = require("@typescript-eslint/utils");
 const createRule_1 = require("../createRule");
 exports.argumentSpacing = (0, createRule_1.createRule)({
     name: 'argument-spacing',
@@ -9,7 +10,6 @@ exports.argumentSpacing = (0, createRule_1.createRule)({
         docs: {
             description: 'Enforces a surrounding line break before and after '
                 + 'the argument list in multiline functional calls.',
-            recommended: 'recommended',
         },
         fixable: 'whitespace',
         schema: [],
@@ -35,8 +35,8 @@ exports.argumentSpacing = (0, createRule_1.createRule)({
                 return;
             }
             const lastArgumentFirstToken = sourceCode.getFirstToken(lastArgument);
-            if ((lastArgument.type !== 'ArrowFunctionExpression'
-                || lastArgument.body.type === 'BlockStatement')
+            if ((lastArgument.type !== utils_1.TSESTree.AST_NODE_TYPES.ArrowFunctionExpression
+                || lastArgument.body.type === utils_1.TSESTree.AST_NODE_TYPES.BlockStatement)
                 && firstToken.loc.start.line === lastArgumentFirstToken.loc.start.line) {
                 return;
             }

package/rules/complex-expression-spacing/index.js

@@ -1,6 +1,7 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.complexExpressionSpacing = void 0;
+const utils_1 = require("@typescript-eslint/utils");
 const createRule_1 = require("../createRule");
 exports.complexExpressionSpacing = (0, createRule_1.createRule)({
     name: 'complex-expression-spacing',
@@ -8,7 +9,6 @@ exports.complexExpressionSpacing = (0, createRule_1.createRule)({
         type: 'suggestion',
         docs: {
             description: 'Enforces a surrounding line break in complex expression.',
-            recommended: 'recommended',
         },
         fixable: 'whitespace',
         schema: [],
@@ -21,10 +21,10 @@ exports.complexExpressionSpacing = (0, createRule_1.createRule)({
         const sourceCode = context.getSourceCode();
         function check(node) {
             const parentPreviousToken = sourceCode.getTokenBefore(node, {
-                filter: token => token.type === 'Punctuator',
+                filter: token => token.type === utils_1.TSESTree.AST_TOKEN_TYPES.Punctuator,
             });
             const parentNextToken = sourceCode.getTokenAfter(node, {
-                filter: token => token.type === 'Punctuator',
+                filter: token => token.type === utils_1.TSESTree.AST_TOKEN_TYPES.Punctuator,
             });
             if (parentPreviousToken.loc.end.line === parentNextToken.loc.start.line) {
                 return;
@@ -54,7 +54,7 @@ exports.complexExpressionSpacing = (0, createRule_1.createRule)({
         return {
             ArrowFunctionExpression: (node) => {
                 const { body } = node;
-                if (body.type === 'ConditionalExpression') {
+                if (body.type === utils_1.TSESTree.AST_NODE_TYPES.ConditionalExpression) {
                     check(body);
                 }
             },

package/rules/jsx-attribute-spacing/index.js

@@ -1,6 +1,7 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.jsxAttributeSpacing = void 0;
+const utils_1 = require("@typescript-eslint/utils");
 const createRule_1 = require("../createRule");
 exports.jsxAttributeSpacing = (0, createRule_1.createRule)({
     name: 'jsx-attribute-spacing',
@@ -8,7 +9,6 @@ exports.jsxAttributeSpacing = (0, createRule_1.createRule)({
         type: 'suggestion',
         docs: {
             description: 'Enforces a surrounding line break in multiline JSX attributes.',
-            recommended: 'recommended',
         },
         fixable: 'whitespace',
         schema: [],
@@ -21,12 +21,13 @@ exports.jsxAttributeSpacing = (0, createRule_1.createRule)({
         const sourceCode = context.getSourceCode();
         function check(node) {
             const { value } = node;
-            if (value === null || value.type !== 'JSXExpressionContainer') {
+            if (value?.type !== utils_1.TSESTree.AST_NODE_TYPES.JSXExpressionContainer) {
                 return;
             }
             const firstToken = sourceCode.getFirstToken(value.expression);
             const lastToken = sourceCode.getLastToken(value.expression);
-            if ((firstToken.type === 'Punctuator' && lastToken.type === 'Punctuator')
+            if ((firstToken.type === utils_1.TSESTree.AST_TOKEN_TYPES.Punctuator
+                && lastToken.type === utils_1.TSESTree.AST_TOKEN_TYPES.Punctuator)
                 || (firstToken.loc.start.line === lastToken.loc.end.line)) {
                 return;
             }

package/rules/min-chained-call-depth/index.js

@@ -10,7 +10,6 @@ exports.minChainedCallDepth = (0, createRule_1.createRule)({
         type: 'layout',
         docs: {
             description: 'Enforces a minimum depth for multiline chained calls.',
-            recommended: 'stylistic',
         },
         fixable: 'whitespace',
         schema: [
@@ -39,9 +38,7 @@ exports.minChainedCallDepth = (0, createRule_1.createRule)({
     defaultOptions: [
         {
             maxLineLength: 100,
-        },
-        {
-            ignoreChainDeeperThan: 3,
+            ignoreChainDeeperThan: 2,
         },
     ],
     create: context => {
@@ -90,10 +87,6 @@ exports.minChainedCallDepth = (0, createRule_1.createRule)({
             callee.type !== utils_1.AST_NODE_TYPES.MemberExpression
                 // If the callee is a computed member expression, like `foo[bar]()`, skip.
                 || callee.computed
-                /* eslint-disable-next-line @typescript-eslint/ban-ts-comment --
-                 * NewExpression is a possible callee object type
-                 */
-                // @ts-ignore
                 || callee.object.type === utils_1.AST_NODE_TYPES.NewExpression
                 // If the callee is already in the same line as it's object, skip.
                 || callee.object.loc.end.line === callee.property.loc.start.line) {

package/rules/newline-per-chained-call/index.js

@@ -1,6 +1,7 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.newlinePerChainedCall = void 0;
+const utils_1 = require("@typescript-eslint/utils");
 const createRule_1 = require("../createRule");
 const LINEBREAK_MATCHER = /\r\n|[\r\n\u2028\u2029]/u;
 exports.newlinePerChainedCall = (0, createRule_1.createRule)({
@@ -9,7 +10,6 @@ exports.newlinePerChainedCall = (0, createRule_1.createRule)({
         type: 'layout',
         docs: {
             description: 'Require a newline after each call in a method chain',
-            recommended: 'recommended',
         },
         fixable: 'whitespace',
         schema: [
@@ -48,30 +48,30 @@ exports.newlinePerChainedCall = (0, createRule_1.createRule)({
             return node.object.loc.end.line === node.property.loc.start.line;
         }
         function isNotClosingParenToken(token) {
-            return token.value !== ')' || token.type !== 'Punctuator';
+            return token.value !== ')' || token.type !== utils_1.TSESTree.AST_TOKEN_TYPES.Punctuator;
         }
         function validateCallExpressionIgnoreDepth(node) {
             let hasCallExpression = false;
-            if (node.type === 'CallExpression') {
+            if (node.type === utils_1.TSESTree.AST_NODE_TYPES.CallExpression) {
                 hasCallExpression = true;
             }
-            if ((node.parent !== undefined)
-                && node.parent.type !== 'CallExpression'
-                && node.parent.type !== 'MemberExpression') {
+            if (node.parent != null
+                && node.parent.type !== utils_1.TSESTree.AST_NODE_TYPES.CallExpression
+                && node.parent.type !== utils_1.TSESTree.AST_NODE_TYPES.MemberExpression) {
                 const memberExpressions = [];
-                let currentNode = (node.type === 'CallExpression'
+                let currentNode = ('callee' in node
                     ? node.callee
                     : node);
-                while (currentNode.type === 'CallExpression'
-                    || currentNode.type === 'MemberExpression') {
-                    if (currentNode.type === 'MemberExpression') {
-                        if (currentNode.property.type === 'Identifier'
+                while (currentNode.type === utils_1.TSESTree.AST_NODE_TYPES.CallExpression
+                    || currentNode.type === utils_1.TSESTree.AST_NODE_TYPES.MemberExpression) {
+                    if (currentNode.type === utils_1.TSESTree.AST_NODE_TYPES.MemberExpression) {
+                        if (currentNode.property.type === utils_1.TSESTree.AST_NODE_TYPES.Identifier
                             && !currentNode.computed) {
                             memberExpressions.push(currentNode);
                         }
                         currentNode = currentNode.object;
                     }
-                    else if (currentNode.type === 'CallExpression') {
+                    else if (currentNode.type === utils_1.TSESTree.AST_NODE_TYPES.CallExpression) {
                         currentNode = currentNode.callee;
                     }
                 }
@@ -81,11 +81,11 @@ exports.newlinePerChainedCall = (0, createRule_1.createRule)({
                     const expressionsOnSameLine = memberExpressions
                         .filter(hasObjectAndPropertyOnSameLine);
                     const rootNode = expressionsOnSameLine[expressionsOnSameLine.length - 1];
-                    if (rootNode.type === 'MemberExpression'
-                        && (rootNode.parent?.type === 'CallExpression'
-                            || rootNode.parent?.type === 'MemberExpression')
-                        && (rootNode.object.type === 'ThisExpression'
-                            || rootNode.object.type === 'Identifier')) {
+                    if (rootNode.type === utils_1.TSESTree.AST_NODE_TYPES.MemberExpression
+                        && (rootNode.parent != null && (rootNode.parent.type === utils_1.TSESTree.AST_NODE_TYPES.CallExpression
+                            || rootNode.parent.type === utils_1.TSESTree.AST_NODE_TYPES.MemberExpression))
+                        && (rootNode.object.type === utils_1.TSESTree.AST_NODE_TYPES.ThisExpression
+                            || rootNode.object.type === utils_1.TSESTree.AST_NODE_TYPES.Identifier)) {
                         expressionsOnSameLine.pop();
                     }
                     expressionsOnSameLine.forEach(memberExpression => {
@@ -107,7 +107,7 @@ exports.newlinePerChainedCall = (0, createRule_1.createRule)({
         }
         return {
             CallExpression: (node) => {
-                if (node.callee?.type === 'MemberExpression') {
+                if (node.callee?.type === utils_1.TSESTree.AST_NODE_TYPES.MemberExpression) {
                     validateCallExpressionIgnoreDepth(node);
                 }
             },

package/rules/parameter-destructuring/index.js

@@ -9,7 +9,6 @@ exports.parameterDestructuring = (0, createRule_1.createRule)({
         type: 'layout',
         docs: {
             description: 'Prevent noisy destructuring on parameters',
-            recommended: 'recommended',
         },
         hasSuggestions: true,
         schema: [],