@croct/eslint-plugin 0.7.1 → 0.8.1

package/configs/react.js

@@ -1,131 +1,355 @@
 "use strict";
+var __importDefault = (this && this.__importDefault) || function (mod) {
+    return (mod && mod.__esModule) ? mod : { "default": mod };
+};
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.react = void 0;
-exports.react = {
-    extends: [
-        'airbnb',
-        'plugin:react/recommended',
-        'plugin:testing-library/react',
-        'plugin:jest-dom/recommended',
-        'plugin:jsx-a11y/recommended',
-        'plugin:@croct/javascript',
+exports.createReactConfig = createReactConfig;
+const eslint_plugin_react_1 = __importDefault(require("eslint-plugin-react"));
+const eslint_plugin_react_hooks_1 = __importDefault(require("eslint-plugin-react-hooks"));
+const eslint_plugin_testing_library_1 = __importDefault(require("eslint-plugin-testing-library"));
+const eslint_plugin_jest_dom_1 = __importDefault(require("eslint-plugin-jest-dom"));
+// @ts-expect-error - no types available
+const eslint_plugin_jsx_a11y_1 = __importDefault(require("eslint-plugin-jsx-a11y"));
+// @ts-expect-error - no types available
+const eslint_plugin_1 = __importDefault(require("@stylistic/eslint-plugin"));
+const baseRules = {
+    // Custom rule
+    '@croct/jsx-attribute-spacing': 'error',
+    // React rules (from airbnb, with customizations)
+    'react/display-name': 'off',
+    'react/forbid-prop-types': ['error', {
+            forbid: ['any', 'array', 'object'],
+            checkContextTypes: true,
+            checkChildContextTypes: true,
+        }],
+    'react/forbid-dom-props': ['off', { forbid: [] }],
+    'react/jsx-boolean-value': ['error', 'never', { always: [] }],
+    'react/jsx-closing-bracket-location': ['error', 'line-aligned'],
+    'react/jsx-closing-tag-location': 'error',
+    'react/jsx-curly-spacing': ['error', 'never', { allowMultiline: true }],
+    'react/jsx-handler-names': ['off', {
+            eventHandlerPrefix: 'handle',
+            eventHandlerPropPrefix: 'on',
+        }],
+    'react/jsx-indent-props': 'off',
+    'react/jsx-key': 'off',
+    'react/jsx-max-props-per-line': ['error', { maximum: 1, when: 'multiline' }],
+    'react/jsx-no-bind': [
+        'error',
+        {
+            allowArrowFunctions: true,
+            allowBind: false,
+            allowFunctions: true,
+        },
     ],
-    plugins: [
-        'import',
-        'react',
-        'react-hooks',
-        'testing-library',
-        'jest-dom',
-        '@croct',
+    'react/jsx-no-duplicate-props': ['error', { ignoreCase: true }],
+    'react/jsx-no-literals': ['off', { noStrings: true }],
+    'react/jsx-no-undef': 'error',
+    'react/jsx-pascal-case': ['error', {
+            allowAllCaps: true,
+            ignore: [],
+        }],
+    'react/sort-prop-types': ['off', {
+            ignoreCase: true,
+            callbacksLast: false,
+            requiredFirst: false,
+            sortShapeProp: true,
+        }],
+    'react/jsx-sort-prop-types': 'off',
+    'react/jsx-sort-props': [
+        'error',
+        {
+            noSortAlphabetically: true,
+            multiline: 'last',
+        },
     ],
-    rules: {
-        '@croct/jsx-attribute-spacing': 'error',
-        'react/destructuring-assignment': 'off',
-        'react/jsx-wrap-multilines': 'error',
-        'react/display-name': 'off',
-        'react/jsx-sort-props': [
-            'error',
-            {
-                noSortAlphabetically: true,
-                multiline: 'last',
-            },
-        ],
-        'react/jsx-newline': [
-            'error',
-            {
-                prevent: true,
-            },
-        ],
-        'react/jsx-no-bind': [
-            'error',
-            {
-                allowArrowFunctions: true,
-                allowBind: false,
-                allowFunctions: true,
-            },
-        ],
-        'react/no-unstable-nested-components': [
-            'error',
-            {
-                allowAsProps: true,
+    'react/jsx-sort-default-props': ['off', {
+            ignoreCase: true,
+        }],
+    'react/jsx-uses-react': 'off',
+    'react/jsx-uses-vars': 'error',
+    'react/no-danger': 'warn',
+    'react/no-deprecated': ['error'],
+    'react/no-did-mount-set-state': 'off',
+    'react/no-did-update-set-state': 'error',
+    'react/no-will-update-set-state': 'error',
+    'react/no-direct-mutation-state': 'off',
+    'react/no-is-mounted': 'error',
+    'react/no-multi-comp': 'off',
+    'react/no-set-state': 'off',
+    'react/no-string-refs': 'error',
+    'react/no-unknown-property': 'error',
+    'react/prefer-es6-class': ['error', 'always'],
+    'react/prefer-stateless-function': ['error', { ignorePureComponents: true }],
+    'react/prop-types': 'off',
+    'react/react-in-jsx-scope': 'off',
+    'react/require-render-return': 'error',
+    'react/self-closing-comp': 'error',
+    'react/sort-comp': ['error', {
+            order: [
+                'static-variables',
+                'static-methods',
+                'instance-variables',
+                'lifecycle',
+                '/^handle.+$/',
+                '/^on.+$/',
+                'getters',
+                'setters',
+                '/^(get|set)(?!(InitialState$|DefaultProps$|ChildContext$)).+$/',
+                'instance-methods',
+                'everything-else',
+                'rendering',
+            ],
+            groups: {
+                lifecycle: [
+                    'displayName',
+                    'propTypes',
+                    'contextTypes',
+                    'childContextTypes',
+                    'mixins',
+                    'statics',
+                    'defaultProps',
+                    'constructor',
+                    'getDefaultProps',
+                    'getInitialState',
+                    'state',
+                    'getChildContext',
+                    'getDerivedStateFromProps',
+                    'componentWillMount',
+                    'UNSAFE_componentWillMount',
+                    'componentDidMount',
+                    'componentWillReceiveProps',
+                    'UNSAFE_componentWillReceiveProps',
+                    'shouldComponentUpdate',
+                    'componentWillUpdate',
+                    'UNSAFE_componentWillUpdate',
+                    'getSnapshotBeforeUpdate',
+                    'componentDidUpdate',
+                    'componentDidCatch',
+                    'componentWillUnmount',
+                ],
+                rendering: [
+                    '/^render.+$/',
+                    'render',
+                ],
             },
-        ],
-        'react/jsx-no-useless-fragment': [
-            'error',
+        }],
+    'react/jsx-wrap-multilines': 'error',
+    'react/jsx-first-prop-new-line': ['error', 'multiline-multiprop'],
+    'react/jsx-equals-spacing': ['error', 'never'],
+    'react/jsx-indent': ['error', 4],
+    'react/jsx-no-target-blank': ['error', { enforceDynamicLinks: 'always' }],
+    'react/jsx-filename-extension': [
+        1,
+        {
+            extensions: ['.tsx'],
+        },
+    ],
+    'react/jsx-no-comment-textnodes': 'error',
+    'react/no-render-return-value': 'error',
+    'react/require-optimization': ['off', { allowDecorators: [] }],
+    'react/no-find-dom-node': 'error',
+    'react/forbid-component-props': ['off', { forbid: [] }],
+    'react/forbid-elements': ['off', { forbid: [] }],
+    'react/no-danger-with-children': 'error',
+    'react/no-unused-prop-types': ['error', {
+            customValidators: [],
+            skipShapeProps: true,
+        }],
+    'react/style-prop-object': 'error',
+    'react/no-unescaped-entities': 'error',
+    'react/no-children-prop': 'error',
+    'react/jsx-tag-spacing': ['error', {
+            closingSlash: 'never',
+            beforeSelfClosing: 'always',
+            afterOpening: 'never',
+            beforeClosing: 'never',
+        }],
+    'react/jsx-space-before-closing': ['off', 'always'],
+    'react/no-array-index-key': 'error',
+    'react/require-default-props': 'off',
+    'react/forbid-foreign-prop-types': ['warn', { allowInPropTypes: true }],
+    'react/void-dom-elements-no-children': 'error',
+    'react/default-props-match-prop-types': ['error', { allowRequiredDefaults: false }],
+    'react/no-redundant-should-component-update': 'error',
+    'react/no-unused-state': 'error',
+    'react/boolean-prop-naming': ['off', {
+            propTypeNames: ['bool', 'mutuallyExclusiveTrueProps'],
+            rule: '^(is|has)[A-Z]([A-Za-z0-9]?)+',
+            message: '',
+        }],
+    'react/no-typos': 'error',
+    'react/jsx-curly-brace-presence': ['error', { props: 'never', children: 'never' }],
+    'react/jsx-one-expression-per-line': 'off',
+    'react/destructuring-assignment': 'off',
+    'react/no-access-state-in-setstate': 'error',
+    'react/button-has-type': ['error', {
+            button: true,
+            submit: true,
+            reset: false,
+        }],
+    'react/jsx-child-element-spacing': 'off',
+    'react/no-this-in-sfc': 'error',
+    'react/jsx-max-depth': 'off',
+    'react/jsx-props-no-multi-spaces': 'error',
+    'react/no-unsafe': 'off',
+    'react/jsx-fragments': ['error', 'element'],
+    'react/jsx-curly-newline': ['error', {
+            multiline: 'consistent',
+            singleline: 'consistent',
+        }],
+    'react/state-in-constructor': ['error', 'always'],
+    'react/static-property-placement': ['error', 'property assignment'],
+    'react/jsx-props-no-spreading': 'off',
+    'react/prefer-read-only-props': 'off',
+    'react/jsx-no-script-url': ['error', [
             {
-                allowExpressions: true,
+                name: 'Link',
+                props: ['to'],
             },
-        ],
-        'react/function-component-definition': 'off',
-        'testing-library/no-container': 'off',
-        'testing-library/no-node-access': 'off',
-        'testing-library/await-async-utils': 'off',
-        'jsx-a11y/aria-role': [
-            'error',
-            {
-                ignoreNonDOM: true,
+        ]],
+    'react/jsx-no-useless-fragment': [
+        'error',
+        {
+            allowExpressions: true,
+        },
+    ],
+    'react/no-adjacent-inline-elements': 'off',
+    'react/function-component-definition': 'off',
+    'react/jsx-newline': [
+        'error',
+        {
+            prevent: true,
+        },
+    ],
+    'react/jsx-no-constructed-context-values': 'error',
+    'react/no-unstable-nested-components': [
+        'error',
+        {
+            allowAsProps: true,
+        },
+    ],
+    'react/no-namespace': 'error',
+    'react/prefer-exact-props': 'error',
+    'react/no-arrow-function-lifecycle': 'error',
+    'react/no-invalid-html-attribute': 'error',
+    'react/no-unused-class-component-methods': 'error',
+    // React Hooks rules
+    'react-hooks/rules-of-hooks': 'error',
+    'react-hooks/exhaustive-deps': 'warn',
+    // Testing Library rules (overrides)
+    'testing-library/no-container': 'off',
+    'testing-library/no-node-access': 'off',
+    'testing-library/await-async-utils': 'off',
+    // JSX A11y rules (overrides)
+    'jsx-a11y/aria-role': [
+        'error',
+        {
+            ignoreNonDOM: true,
+        },
+    ],
+    // Underscore dangle override for Redux DevTools
+    'no-underscore-dangle': ['error', {
+            allow: ['__REDUX_DEVTOOLS_EXTENSION_COMPOSE__'],
+            allowAfterThis: false,
+            allowAfterSuper: false,
+            enforceInMethodNames: true,
+        }],
+    // Class methods use this override for React lifecycle methods
+    'class-methods-use-this': ['error', {
+            exceptMethods: [
+                'render',
+                'getInitialState',
+                'getDefaultProps',
+                'getChildContext',
+                'componentWillMount',
+                'UNSAFE_componentWillMount',
+                'componentDidMount',
+                'componentWillReceiveProps',
+                'UNSAFE_componentWillReceiveProps',
+                'shouldComponentUpdate',
+                'componentWillUpdate',
+                'UNSAFE_componentWillUpdate',
+                'componentDidUpdate',
+                'componentWillUnmount',
+                'componentDidCatch',
+                'getSnapshotBeforeUpdate',
+            ],
+        }],
+    // Import restrictions
+    'no-restricted-imports': [
+        'error',
+        {
+            name: 'react',
+            importNames: ['default'],
+            message: 'The React runtime is automatically imported, '
+                + 'you can simply omit the import declaration in this case.',
+        },
+    ],
+    // Import order for React (using import-x)
+    'import-x/order': [
+        'error',
+        {
+            groups: [
+                'builtin',
+                'external',
+                'internal',
+            ],
+            pathGroups: [
+                {
+                    pattern: 'react',
+                    group: 'external',
+                    position: 'before',
+                },
+            ],
+            pathGroupsExcludedImportTypes: ['react'],
+            'newlines-between': 'never',
+            alphabetize: {
+                order: 'asc',
+                caseInsensitive: true,
             },
-        ],
-        'react/jsx-uses-react': 'off',
-        'react/react-in-jsx-scope': 'off',
-        'react/jsx-one-expression-per-line': 'off',
-        'react/prop-types': 'off',
-        'react/require-default-props': 'off',
-        'react/jsx-fragments': [
-            'error',
-            'element',
-        ],
-        'react-hooks/rules-of-hooks': 'error',
-        'react-hooks/exhaustive-deps': 'warn',
-        'react/jsx-filename-extension': [
-            1,
-            {
-                extensions: [
-                    '.tsx',
-                ],
+        },
+    ],
+};
+// Factory function to create React config with the plugin reference
+function createReactConfig(plugin, javascriptConfig) {
+    return [
+        ...javascriptConfig,
+        eslint_plugin_react_1.default.configs.flat.recommended,
+        eslint_plugin_testing_library_1.default.configs['flat/react'],
+        eslint_plugin_jest_dom_1.default.configs['flat/recommended'],
+        eslint_plugin_jsx_a11y_1.default.flatConfigs.recommended,
+        {
+            name: '@croct/react',
+            plugins: {
+                'react-hooks': eslint_plugin_react_hooks_1.default,
+                '@stylistic': eslint_plugin_1.default,
+                '@croct': plugin,
             },
-        ],
-        'react/jsx-indent': [
-            'error',
-            4,
-        ],
-        'react/jsx-indent-props': 'off',
-        'react/jsx-props-no-spreading': 'off',
-        'no-restricted-imports': [
-            'error',
-            {
-                name: 'react',
-                importNames: [
-                    'default',
-                ],
-                message: 'The React runtime is automatically imported, '
-                    + 'you can simply omit the import declaration in this case.',
+            languageOptions: {
+                parserOptions: {
+                    ecmaFeatures: {
+                        jsx: true,
+                    },
+                },
             },
-        ],
-        'import/order': [
-            'error',
-            {
-                groups: [
-                    'builtin',
-                    'external',
-                    'internal',
-                ],
-                pathGroups: [
-                    {
-                        pattern: 'react',
-                        group: 'external',
-                        position: 'before',
+            settings: {
+                'import-x/resolver': {
+                    node: {
+                        extensions: ['.js', '.jsx', '.json'],
                     },
-                ],
-                pathGroupsExcludedImportTypes: [
-                    'react',
-                ],
-                'newlines-between': 'never',
-                alphabetize: {
-                    order: 'asc',
-                    caseInsensitive: true,
                 },
+                react: {
+                    pragma: 'React',
+                    version: 'detect',
+                },
+                propWrapperFunctions: [
+                    'forbidExtraProps',
+                    'exact',
+                    'Object.freeze',
+                ],
             },
-        ],
-    },
-};
+            rules: baseRules,
+        },
+    ];
+}

package/configs/typescript.js

@@ -1,99 +1,112 @@
 "use strict";
+var __importDefault = (this && this.__importDefault) || function (mod) {
+    return (mod && mod.__esModule) ? mod : { "default": mod };
+};
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.typescript = void 0;
-exports.typescript = {
-    extends: ['plugin:@croct/javascript'],
-    plugins: [
-        '@typescript-eslint',
-        '@croct',
+exports.createTypescriptConfig = createTypescriptConfig;
+const typescript_eslint_1 = __importDefault(require("typescript-eslint"));
+const parser_1 = __importDefault(require("@typescript-eslint/parser"));
+const eslint_plugin_jest_1 = __importDefault(require("eslint-plugin-jest"));
+// @ts-expect-error - no types available
+const eslint_plugin_1 = __importDefault(require("@stylistic/eslint-plugin"));
+const baseRules = {
+    'import-x/export': 'off',
+    '@typescript-eslint/array-type': ['error', {
+            default: 'array-simple',
+        }],
+    '@typescript-eslint/prefer-as-const': 'error',
+    '@typescript-eslint/adjacent-overload-signatures': 'error',
+    '@stylistic/type-annotation-spacing': 'error',
+    '@stylistic/semi': ['error', 'always'],
+    '@typescript-eslint/strict-boolean-expressions': ['error', {
+            allowString: false,
+            allowNumber: false,
+            allowNullableObject: false,
+        }],
+    '@typescript-eslint/prefer-optional-chain': 'error',
+    'no-shadow': 'off',
+    '@typescript-eslint/no-shadow': ['error', {
+            ignoreTypeValueShadow: true,
+            ignoreFunctionTypeParameterNameValueShadow: true,
+        }],
+    '@typescript-eslint/no-empty-interface': 'off',
+    '@typescript-eslint/explicit-member-accessibility': [
+        'error',
     ],
-    overrides: [
+    '@typescript-eslint/explicit-module-boundary-types': 'off',
+    '@typescript-eslint/explicit-function-return-type': ['error'],
+    '@typescript-eslint/no-explicit-any': 'off',
+    'no-use-before-define': 'off',
+    '@typescript-eslint/no-use-before-define': 'off',
+    'no-unused-expressions': 'off',
+    '@typescript-eslint/no-unused-expressions': 'error',
+    '@stylistic/indent': ['error', 4, {
+            SwitchCase: 1,
+        }],
+    '@typescript-eslint/no-unused-vars': [
+        'error',
         {
-            files: ['**/*.ts', '**/*.tsx'],
-            extends: ['plugin:@typescript-eslint/recommended'],
-            parser: '@typescript-eslint/parser',
-            rules: {
-                'import/export': 'off',
-                '@typescript-eslint/array-type': ['error', {
-                        default: 'array-simple',
-                    }],
-                '@typescript-eslint/prefer-as-const': 'error',
-                '@typescript-eslint/adjacent-overload-signatures': 'error',
-                '@typescript-eslint/type-annotation-spacing': 'error',
-                '@typescript-eslint/semi': ['error', 'always'],
-                '@typescript-eslint/strict-boolean-expressions': ['error', {
-                        allowString: false,
-                        allowNumber: false,
-                        allowNullableObject: false,
-                    }],
-                '@typescript-eslint/prefer-optional-chain': 'error',
-                'no-shadow': 'off',
-                '@typescript-eslint/no-shadow': ['error', {
-                        ignoreTypeValueShadow: true,
-                        ignoreFunctionTypeParameterNameValueShadow: true,
-                    }],
-                '@typescript-eslint/no-empty-interface': 'off',
-                '@typescript-eslint/explicit-member-accessibility': [
-                    'error',
-                ],
-                '@typescript-eslint/explicit-module-boundary-types': 'off',
-                '@typescript-eslint/explicit-function-return-type': ['error'],
-                '@typescript-eslint/no-explicit-any': 'off',
-                'no-use-before-define': 'off',
-                '@typescript-eslint/no-use-before-define': 'off',
-                'no-unused-expressions': 'off',
-                '@typescript-eslint/no-unused-expressions': 'error',
-                indent: ['error', 4, {
-                        SwitchCase: 1,
-                    }],
-                '@typescript-eslint/no-unused-vars': [
-                    'error',
-                    {
-                        args: 'after-used',
-                        ignoreRestSiblings: true,
+            args: 'after-used',
+            ignoreRestSiblings: true,
+        },
+    ],
+    'no-unused-vars': 'off',
+    '@typescript-eslint/no-non-null-assertion': 'off',
+    '@stylistic/object-curly-spacing': 'error',
+    '@stylistic/member-delimiter-style': ['error', {
+            multiline: {
+                delimiter: 'comma',
+                requireLast: true,
+            },
+            singleline: {
+                delimiter: 'comma',
+                requireLast: false,
+            },
+            overrides: {
+                interface: {
+                    singleline: {
+                        delimiter: 'semi',
+                    },
+                    multiline: {
+                        delimiter: 'semi',
                     },
-                ],
-                'no-unused-vars': 'off',
-                '@typescript-eslint/no-non-null-assertion': 'off',
-                'object-curly-spacing': 'off',
-                '@typescript-eslint/object-curly-spacing': 'error',
-                '@typescript-eslint/member-delimiter-style': ['error', {
-                        multiline: {
-                            delimiter: 'comma',
-                            requireLast: true,
-                        },
-                        singleline: {
-                            delimiter: 'comma',
-                            requireLast: false,
-                        },
-                        overrides: {
-                            interface: {
-                                singleline: {
-                                    delimiter: 'semi',
-                                },
-                                multiline: {
-                                    delimiter: 'semi',
-                                },
-                            },
-                        },
-                    }],
-                'no-undef': 'off',
-                '@typescript-eslint/no-namespace': 'off',
+                },
             },
+        }],
+    'no-undef': 'off',
+    '@typescript-eslint/no-namespace': 'off',
+};
+// Factory function to create TypeScript config with the plugin reference
+function createTypescriptConfig(plugin, javascriptConfig) {
+    return [
+        ...javascriptConfig,
+        ...typescript_eslint_1.default.configs.recommendedTypeChecked,
+        eslint_plugin_jest_1.default.configs['flat/recommended'],
+        {
+            name: '@croct/typescript',
+            files: ['**/*.ts', '**/*.tsx'],
+            plugins: {
+                '@stylistic': eslint_plugin_1.default,
+                '@croct': plugin,
+            },
+            languageOptions: {
+                parser: parser_1.default,
+                parserOptions: {
+                    // Enable type-aware linting
+                    projectService: true,
+                },
+            },
+            rules: baseRules,
         },
         {
+            name: '@croct/typescript/tests',
             files: [
                 'src/**/*.test.ts',
                 'test/**/*.ts',
             ],
-            extends: ['plugin:jest/recommended'],
-            plugins: ['jest'],
             rules: {
                 'no-new-object': 'off',
             },
-            env: {
-                jest: true,
-            },
         },
-    ],
-};
+    ];
+}