@critical-path/core 0.28.0 → 0.29.0

package/src/store/firebase.ts

@@ -104,6 +104,10 @@ export interface FirebaseStoreConfig {
   db: FirestoreDBInterface;
 }
 
+/**
+ * Removes `undefined` values, which Firestore rejects. Update methods write the complete merged
+ * record without `{ merge: true }`, so a field cleared with `undefined` is actually removed.
+ */
 export function sanitizeFirestoreData<T>(obj: T): T {
   if (obj === null || typeof obj !== 'object') {
     return obj;
@@ -162,7 +166,7 @@ export class FirebaseStore implements StorageAdapter {
       ...updates,
       updatedAt: new Date().toISOString()
     };
-    await this.db.collection('projects').doc(id).set(sanitizeFirestoreData(updated), { merge: true });
+    await this.db.collection('projects').doc(id).set(sanitizeFirestoreData(updated));
     return updated;
   }
 
@@ -202,7 +206,7 @@ export class FirebaseStore implements StorageAdapter {
       ...updates,
       updatedAt: new Date().toISOString()
     };
-    await this.db.collection('workflows').doc(id).set(sanitizeFirestoreData(updated), { merge: true });
+    await this.db.collection('workflows').doc(id).set(sanitizeFirestoreData(updated));
     return updated;
   }
 
@@ -238,7 +242,7 @@ export class FirebaseStore implements StorageAdapter {
     if (!existing) return null;
 
     const updated: Team = { ...existing, ...updates, updatedAt: new Date().toISOString() };
-    await this.db.collection('teams').doc(id).set(sanitizeFirestoreData(updated), { merge: true });
+    await this.db.collection('teams').doc(id).set(sanitizeFirestoreData(updated));
     return updated;
   }
 
@@ -274,7 +278,7 @@ export class FirebaseStore implements StorageAdapter {
     if (!existing) return null;
 
     const updated: TaskContainer = { ...existing, ...updates, updatedAt: new Date().toISOString() };
-    await this.db.collection('containers').doc(id).set(sanitizeFirestoreData(updated), { merge: true });
+    await this.db.collection('containers').doc(id).set(sanitizeFirestoreData(updated));
     return updated;
   }
 
@@ -318,7 +322,7 @@ export class FirebaseStore implements StorageAdapter {
     if (!existing) return null;
 
     const updated: Deliverable = { ...existing, ...updates, updatedAt: new Date().toISOString() };
-    await this.db.collection('deliverables').doc(id).set(sanitizeFirestoreData(updated), { merge: true });
+    await this.db.collection('deliverables').doc(id).set(sanitizeFirestoreData(updated));
     return updated;
   }
 
@@ -363,7 +367,7 @@ export class FirebaseStore implements StorageAdapter {
       ...updates,
       updatedAt: new Date().toISOString()
     };
-    await this.db.collection('tasks').doc(id).set(sanitizeFirestoreData(updated), { merge: true });
+    await this.db.collection('tasks').doc(id).set(sanitizeFirestoreData(updated));
     return updated;
   }
 
@@ -399,7 +403,7 @@ export class FirebaseStore implements StorageAdapter {
     if (!snap.exists) return null;
 
     const updated: Iteration = { ...snap.data(), id, ...updates };
-    await this.db.collection('iterations').doc(id).set(sanitizeFirestoreData(updated), { merge: true });
+    await this.db.collection('iterations').doc(id).set(sanitizeFirestoreData(updated));
     return updated;
   }
 
@@ -439,7 +443,7 @@ export class FirebaseStore implements StorageAdapter {
       ...updates,
       updatedAt: new Date().toISOString()
     };
-    await this.db.collection('comments').doc(id).set(sanitizeFirestoreData(updated), { merge: true });
+    await this.db.collection('comments').doc(id).set(sanitizeFirestoreData(updated));
     return updated;
   }
 
@@ -567,6 +571,27 @@ export class FirebaseStore implements StorageAdapter {
     return newDep;
   }
 
+  async getDependency(id: string): Promise<TaskDependency | null> {
+    const doc = await this.db.collection('dependencies').doc(id).get();
+    return doc.exists ? ({ ...doc.data(), id: doc.id } as TaskDependency) : null;
+  }
+
+  async removeDependency(id: string): Promise<boolean> {
+    return this.deleteDoc('dependencies', id);
+  }
+
+  async deleteTimeEntry(id: string): Promise<boolean> {
+    return this.deleteDoc('time_entries', id);
+  }
+
+  private async deleteDoc(collection: string, id: string): Promise<boolean> {
+    const ref = this.db.collection(collection).doc(id);
+    const doc = await ref.get();
+    if (!doc.exists) return false;
+    await ref.delete();
+    return true;
+  }
+
   // --- Webhooks ---
   async getWebhooks(): Promise<Webhook[]> {
     const snap = await this.db.collection('webhooks').get();

package/src/store/index.ts

@@ -92,11 +92,15 @@ export interface ActivityRepository {
 export interface TimeEntryRepository {
   getTimeEntries(taskId: string): Promise<TimeEntry[]>;
   logTime(entry: Omit<TimeEntry, 'id' | 'loggedAt'> & { loggedAt?: string }): Promise<TimeEntry>;
+  deleteTimeEntry(id: string): Promise<boolean>;
 }
 
 export interface DependencyRepository {
+  /** Dependencies where `taskId` is either the dependent or the upstream task. */
   getDependencies(taskId: string): Promise<TaskDependency[]>;
+  getDependency(id: string): Promise<TaskDependency | null>;
   addDependency(dep: Omit<TaskDependency, 'id'>): Promise<TaskDependency>;
+  removeDependency(id: string): Promise<boolean>;
 }
 
 export interface WebhookRepository {
@@ -522,6 +526,10 @@ export class InMemoryStore implements StorageAdapter {
     return newEntry;
   }
 
+  async deleteTimeEntry(id: string): Promise<boolean> {
+    return this.timeEntries.delete(id);
+  }
+
   // Dependencies
   async getDependencies(taskId: string): Promise<TaskDependency[]> {
     return Array.from(this.dependencies.values()).filter(
@@ -529,6 +537,10 @@ export class InMemoryStore implements StorageAdapter {
     );
   }
 
+  async getDependency(id: string): Promise<TaskDependency | null> {
+    return this.dependencies.get(id) ?? null;
+  }
+
   async addDependency(dep: Omit<TaskDependency, 'id'>): Promise<TaskDependency> {
     const id = `dep_${Math.random().toString(36).substring(2, 9)}`;
     const newDep: TaskDependency = { ...dep, id };
@@ -536,6 +548,10 @@ export class InMemoryStore implements StorageAdapter {
     return newDep;
   }
 
+  async removeDependency(id: string): Promise<boolean> {
+    return this.dependencies.delete(id);
+  }
+
   // Webhooks
   async getWebhooks(): Promise<Webhook[]> {
     return Array.from(this.webhooks.values());

package/src/store/sqlite.ts

@@ -18,6 +18,14 @@ import type {
 } from '../types/index.js';
 import { generateProjectKey } from '../utils/key.js';
 
+/**
+ * SQLite returns NULL columns as `null`, while domain objects leave unset optional fields out.
+ * Dropping nulls keeps SQLiteStore results identical to the other adapters.
+ */
+function dropNulls<T extends object>(row: T): T {
+  return Object.fromEntries(Object.entries(row).filter(([, value]) => value !== null)) as T;
+}
+
 export interface SQLiteStoreConfig {
   /**
    * Database file path (e.g., 'critical-path.db' or ':memory:').
@@ -516,13 +524,13 @@ export class SQLiteStore implements StorageAdapter {
   async getContainers(projectId: string): Promise<TaskContainer[]> {
     const stmt = this.db.prepare('SELECT * FROM containers WHERE projectId = ?');
     const rows = stmt.all(projectId) as any[];
-    return rows;
+    return rows.map(dropNulls);
   }
 
   async getContainer(id: string): Promise<TaskContainer | null> {
     const stmt = this.db.prepare('SELECT * FROM containers WHERE id = ?');
     const row = stmt.get(id) as any;
-    return row || null;
+    return row ? dropNulls(row) : null;
   }
 
   async createContainer(container: Omit<TaskContainer, 'id' | 'createdAt' | 'updatedAt'>): Promise<TaskContainer> {
@@ -821,13 +829,13 @@ export class SQLiteStore implements StorageAdapter {
   async getIterations(projectId: string): Promise<Iteration[]> {
     const stmt = this.db.prepare('SELECT * FROM iterations WHERE projectId = ?');
     const rows = stmt.all(projectId) as any[];
-    return rows;
+    return rows.map(dropNulls);
   }
 
   async getIteration(id: string): Promise<Iteration | null> {
     const stmt = this.db.prepare('SELECT * FROM iterations WHERE id = ?');
     const row = stmt.get(id) as any;
-    return row || null;
+    return row ? dropNulls(row) : null;
   }
 
   async createIteration(iteration: Omit<Iteration, 'id' | 'createdAt'>): Promise<Iteration> {
@@ -883,7 +891,7 @@ export class SQLiteStore implements StorageAdapter {
 
   // --- Comments ---
   private mapComment(row: any): Comment {
-    return {
+    return dropNulls({
       id: row.id,
       taskId: row.taskId,
       authorId: row.authorId,
@@ -895,7 +903,7 @@ export class SQLiteStore implements StorageAdapter {
       metadata: row.metadata ? JSON.parse(row.metadata) : undefined,
       createdAt: row.createdAt,
       updatedAt: row.updatedAt
-    };
+    });
   }
 
   async getComments(taskId: string): Promise<Comment[]> {
@@ -1028,22 +1036,24 @@ export class SQLiteStore implements StorageAdapter {
 
     const stmt = this.db.prepare(sql);
     const rows = stmt.all(...params) as any[];
-    return rows.map((r) => ({
-      ...r,
-      sizeBytes: Number(r.sizeBytes),
-      metadata: r.metadata ? JSON.parse(r.metadata) : undefined
-    }));
+    return rows.map((r) =>
+      dropNulls({
+        ...r,
+        sizeBytes: Number(r.sizeBytes),
+        metadata: r.metadata ? JSON.parse(r.metadata) : undefined
+      })
+    );
   }
 
   async getAttachment(id: string): Promise<Attachment | null> {
     const stmt = this.db.prepare('SELECT * FROM attachments WHERE id = ?');
     const row = stmt.get(id) as any;
     if (!row) return null;
-    return {
+    return dropNulls({
       ...row,
       sizeBytes: Number(row.sizeBytes),
       metadata: row.metadata ? JSON.parse(row.metadata) : undefined
-    };
+    });
   }
 
   async createAttachment(attachment: Omit<Attachment, 'id' | 'createdAt' | 'updatedAt'>): Promise<Attachment> {
@@ -1106,10 +1116,12 @@ export class SQLiteStore implements StorageAdapter {
 
     const stmt = this.db.prepare(sql);
     const rows = stmt.all(...params) as any[];
-    return rows.map((r) => ({
-      ...r,
-      details: r.details ? JSON.parse(r.details) : undefined
-    }));
+    return rows.map((r) =>
+      dropNulls({
+        ...r,
+        details: r.details ? JSON.parse(r.details) : undefined
+      })
+    );
   }
 
   async logActivity(activity: Omit<Activity, 'id' | 'createdAt'>): Promise<Activity> {
@@ -1137,7 +1149,7 @@ export class SQLiteStore implements StorageAdapter {
   async getTimeEntries(taskId: string): Promise<TimeEntry[]> {
     const stmt = this.db.prepare('SELECT * FROM time_entries WHERE taskId = ?');
     const rows = stmt.all(taskId) as any[];
-    return rows.map((r) => ({ ...r, isBillable: r.isBillable !== null ? Boolean(r.isBillable) : undefined }));
+    return rows.map((r) => dropNulls({ ...r, isBillable: r.isBillable !== null ? Boolean(r.isBillable) : undefined }));
   }
 
   async logTime(entry: Omit<TimeEntry, 'id' | 'loggedAt'> & { loggedAt?: string }): Promise<TimeEntry> {
@@ -1164,7 +1176,7 @@ export class SQLiteStore implements StorageAdapter {
   // --- Dependencies ---
   async getDependencies(taskId: string): Promise<TaskDependency[]> {
     const stmt = this.db.prepare('SELECT * FROM dependencies WHERE taskId = ? OR dependsOnTaskId = ?');
-    return stmt.all(taskId, taskId) as any[];
+    return (stmt.all(taskId, taskId) as any[]).map(dropNulls);
   }
 
   async addDependency(dep: Omit<TaskDependency, 'id'>): Promise<TaskDependency> {
@@ -1179,6 +1191,19 @@ export class SQLiteStore implements StorageAdapter {
     return newDep;
   }
 
+  async getDependency(id: string): Promise<TaskDependency | null> {
+    const row = this.db.prepare('SELECT * FROM dependencies WHERE id = ?').get(id) as any;
+    return row ? { id: row.id, taskId: row.taskId, dependsOnTaskId: row.dependsOnTaskId, type: row.type } : null;
+  }
+
+  async removeDependency(id: string): Promise<boolean> {
+    return Number(this.db.prepare('DELETE FROM dependencies WHERE id = ?').run(id).changes) > 0;
+  }
+
+  async deleteTimeEntry(id: string): Promise<boolean> {
+    return Number(this.db.prepare('DELETE FROM time_entries WHERE id = ?').run(id).changes) > 0;
+  }
+
   // --- Webhooks ---
   async getWebhooks(): Promise<Webhook[]> {
     const stmt = this.db.prepare('SELECT * FROM webhooks');
@@ -1215,7 +1240,7 @@ export class SQLiteStore implements StorageAdapter {
   }
 
   private mapWebhook(row: any): Webhook {
-    return {
+    return dropNulls({
       id: row.id,
       name: row.name ?? '',
       url: row.url,
@@ -1224,7 +1249,7 @@ export class SQLiteStore implements StorageAdapter {
       active: Boolean(row.active),
       tenantId: row.tenantId ?? undefined,
       createdAt: row.createdAt
-    };
+    });
   }
 
   async addWebhook(webhook: Omit<Webhook, 'id' | 'createdAt'>): Promise<Webhook> {
@@ -1251,7 +1276,7 @@ export class SQLiteStore implements StorageAdapter {
 
   // Helper mappers
   private mapProject(row: any): Project {
-    return {
+    return dropNulls({
       ...row,
       tenantId: row.tenantId ?? undefined,
       workflowId: row.workflowId || undefined,
@@ -1261,30 +1286,30 @@ export class SQLiteStore implements StorageAdapter {
       statusDefinitions: row.statusDefinitions ? JSON.parse(row.statusDefinitions) : [],
       priorityDefinitions: row.priorityDefinitions ? JSON.parse(row.priorityDefinitions) : [],
       customFieldDefinitions: row.customFieldDefinitions ? JSON.parse(row.customFieldDefinitions) : []
-    };
+    });
   }
 
   private mapWorkflow(row: any): Workflow {
-    return {
+    return dropNulls({
       ...row,
       tenantId: row.tenantId ?? undefined,
       statuses: row.statuses ? JSON.parse(row.statuses) : [],
       transitions: row.transitions ? JSON.parse(row.transitions) : [],
       taskTypes: row.taskTypes ? JSON.parse(row.taskTypes) : undefined,
       isDefault: row.isDefault !== null && row.isDefault !== undefined ? Boolean(row.isDefault) : undefined
-    };
+    });
   }
 
   private mapTeam(row: any): Team {
-    return {
+    return dropNulls({
       ...row,
       tenantId: row.tenantId ?? undefined,
       memberIds: row.memberIds ? JSON.parse(row.memberIds) : []
-    };
+    });
   }
 
   private mapTask(row: any): Task {
-    return {
+    return dropNulls({
       ...row,
       actualDurationSeconds: row.actualDurationSeconds ?? undefined,
       inProgressSince: row.inProgressSince || undefined,
@@ -1299,15 +1324,15 @@ export class SQLiteStore implements StorageAdapter {
       tags: row.tags ? JSON.parse(row.tags) : [],
       assignees: row.assignees ? JSON.parse(row.assignees) : undefined,
       customFields: row.customFields ? JSON.parse(row.customFields) : {}
-    };
+    });
   }
 
   private mapDeliverable(row: any): Deliverable {
-    return {
+    return dropNulls({
       ...row,
       specs: row.specs ? JSON.parse(row.specs) : undefined,
       outputUrls: row.outputUrls ? JSON.parse(row.outputUrls) : [],
       customFields: row.customFields ? JSON.parse(row.customFields) : {}
-    };
+    });
   }
 }

package/src/webhooks/webhooks.test.ts

@@ -78,7 +78,8 @@ describe('webhook delivery', () => {
     await engine.createTask({ projectId: project.id, title: 'T' });
     await engine.webhooks.idle();
 
-    expect(deliveries.map((d) => d.body.event)).toEqual(['project.created', 'task.created']);
+    // Deliveries are asynchronous, so arrival order is not guaranteed
+    expect(deliveries.map((d) => d.body.event).sort()).toEqual(['project.created', 'task.created']);
     expect(deliveries.every((d) => d.url.endsWith('/all'))).toBe(true);
   });
 

package/tsconfig.tsbuildinfo

@@ -1 +1 @@
-{"root":["./src/deliverables.test.ts","./src/index.test.ts","./src/index.ts","./src/status.test.ts","./src/task-state.test.ts","./src/use-case-validation.test.ts","./src/domain/authorization.ts","./src/domain/calendar.test.ts","./src/domain/calendar.ts","./src/domain/cpm.test.ts","./src/domain/cpm.ts","./src/domain/custom-fields.ts","./src/domain/ddd.test.ts","./src/domain/entities.ts","./src/domain/errors.ts","./src/domain/events.ts","./src/domain/graph.ts","./src/domain/index.ts","./src/domain/ladder.test.ts","./src/domain/ladder.ts","./src/domain/metrics.test.ts","./src/domain/metrics.ts","./src/domain/task-duration.test.ts","./src/domain/workload.test.ts","./src/domain/workload.ts","./src/engine/actor.test.ts","./src/engine/authorization.test.ts","./src/engine/index.ts","./src/plugins/index.ts","./src/plugins/plugins.test.ts","./src/schemas/index.ts","./src/schemas/schemas.test.ts","./src/storage/file-storage.ts","./src/storage/firebase-storage.ts","./src/storage/index.ts","./src/storage/s3.ts","./src/storage/storage.test.ts","./src/store/firebase.test.ts","./src/store/firebase.ts","./src/store/index.ts","./src/store/sqlite.test.ts","./src/store/sqlite.ts","./src/types/index.ts","./src/utils/fractional-index.test.ts","./src/utils/fractional-index.ts","./src/utils/index.ts","./src/utils/key.test.ts","./src/utils/key.ts","./src/utils/mentions.test.ts","./src/utils/mentions.ts","./src/utils/status.ts","./src/utils/workflow.ts","./src/webhooks/dispatcher.ts","./src/webhooks/index.ts","./src/webhooks/signature.ts","./src/webhooks/webhooks.test.ts"],"version":"5.9.3"}
+{"root":["./src/deliverables.test.ts","./src/index.test.ts","./src/index.ts","./src/status.test.ts","./src/task-state.test.ts","./src/use-case-validation.test.ts","./src/domain/authorization.ts","./src/domain/calendar.test.ts","./src/domain/calendar.ts","./src/domain/cpm.test.ts","./src/domain/cpm.ts","./src/domain/custom-fields.ts","./src/domain/ddd.test.ts","./src/domain/entities.ts","./src/domain/errors.ts","./src/domain/events.ts","./src/domain/graph.ts","./src/domain/index.ts","./src/domain/ladder.test.ts","./src/domain/ladder.ts","./src/domain/metrics.test.ts","./src/domain/metrics.ts","./src/domain/task-duration.test.ts","./src/domain/workload.test.ts","./src/domain/workload.ts","./src/engine/actor.test.ts","./src/engine/authorization.test.ts","./src/engine/cascade.test.ts","./src/engine/index.ts","./src/plugins/index.ts","./src/plugins/plugins.test.ts","./src/schemas/index.ts","./src/schemas/schemas.test.ts","./src/storage/file-storage.ts","./src/storage/firebase-storage.ts","./src/storage/index.ts","./src/storage/s3.ts","./src/storage/storage.test.ts","./src/store/firebase.test.ts","./src/store/firebase.ts","./src/store/index.ts","./src/store/sqlite.test.ts","./src/store/sqlite.ts","./src/types/index.ts","./src/utils/fractional-index.test.ts","./src/utils/fractional-index.ts","./src/utils/index.ts","./src/utils/key.test.ts","./src/utils/key.ts","./src/utils/mentions.test.ts","./src/utils/mentions.ts","./src/utils/status.ts","./src/utils/workflow.ts","./src/webhooks/dispatcher.ts","./src/webhooks/index.ts","./src/webhooks/signature.ts","./src/webhooks/webhooks.test.ts"],"version":"5.9.3"}