@cosmicdrift/kumiko-framework 0.386.0 → 0.388.0

package/src/scripts/codemod/testing-move.ts

@@ -172,7 +172,9 @@ function repointDeclaration(
 function isWholeModuleReference(declaration: NamedDeclaration): boolean {
   if (Node.isImportDeclaration(declaration)) {
     return (
-      declaration.getNamespaceImport() !== undefined || declaration.getDefaultImport() !== undefined
+      declaration.getNamespaceImport() !== undefined ||
+      declaration.getDefaultImport() !== undefined ||
+      declaration.getNamedImports().length === 0
     );
   }
   return declaration.isNamespaceExport() || declaration.getNamedExports().length === 0;
@@ -186,14 +188,34 @@ function usesSplitName(
   const namespaceName = Node.isImportDeclaration(declaration)
     ? declaration.getNamespaceImport()?.getText()
     : undefined;
+  if (
+    Node.isImportDeclaration(declaration) &&
+    declaration.getDefaultImport() === undefined &&
+    namespaceName === undefined
+  ) {
+    return false; // side-effect import: nothing is used, so any package of the old module serves
+  }
   if (namespaceName === undefined) return true;
   return sourceFile
-    .getDescendantsOfKind(SyntaxKind.PropertyAccessExpression)
-    .some(
-      (access) =>
-        access.getExpression().getText() === namespaceName &&
-        targetForName(old, access.getName()) !== mainTarget(old),
-    );
+    .getDescendantsOfKind(SyntaxKind.Identifier)
+    .some((identifier) => namespaceUseNeedsSplit(identifier, namespaceName, old));
+}
+
+// Conservative: any use other than `ns.name` / `ns.name` in a type position (destructuring,
+// passing the namespace on, typeof) cannot be attributed to one target package.
+function namespaceUseNeedsSplit(identifier: Node, namespaceName: string, old: OldModule): boolean {
+  if (identifier.getText() !== namespaceName) return false;
+  if (identifier.getFirstAncestorByKind(SyntaxKind.ImportDeclaration) !== undefined) return false;
+  const parent = identifier.getParent();
+  if (Node.isPropertyAccessExpression(parent)) {
+    if (parent.getNameNode() === identifier) return false;
+    return targetForName(old, parent.getName()) !== mainTarget(old);
+  }
+  if (Node.isQualifiedName(parent)) {
+    if (parent.getRight() === identifier) return false;
+    return targetForName(old, parent.getRight().getText()) !== mainTarget(old);
+  }
+  return true;
 }
 
 function repointWholeModule(

package/src/scripts/codemod/unprocessable-error-details-reason.ts

@@ -1,5 +1,5 @@
 #!/usr/bin/env bun
-// `UnprocessableOpts.details` was tightened (fw#2460) to `& { readonly reason?:
+// `UnprocessableOpts.details` was tightened to `& { readonly reason?:
 // never }` — `reason` is owned exclusively by the ctor's first positional
 // argument, which already folds it into `details` internally
 // (`{ ...opts?.details, reason }`). Any consumer that ALSO puts `reason`
@@ -26,7 +26,7 @@ const KUMIKO_MODULE_RE = /^@cosmicdrift\/kumiko-/;
 function findTargetFiles(rootDir: string): string[] {
   // Walk the tree and skip excluded dirs while descending — filtering the
   // absolute path after a full scan silently no-ops when the repo root
-  // itself contains "/build/" or "/node_modules/" (fw#2289).
+  // itself contains "/build/" or "/node_modules/."
   const files: string[] = [];
   const walk = (dir: string): void => {
     let entries: Dirent[];