@colyseus/schema 5.0.10 → 5.0.11

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@colyseus/schema",
-  "version": "5.0.10",
+  "version": "5.0.11",
   "description": "Binary state serializer with delta encoding for games",
   "type": "module",
   "bin": {

package/src/encoder/ChangeTree.ts

@@ -232,7 +232,6 @@ export class ChangeTree<T extends Ref = any> implements ChangeRecorder {
     // per-view WeakSet lookups with direct bitwise ops.
     // Lazy: undefined until the tree participates in any view.
     visibleViews?: number[];
-    invisibleViews?: number[];
 
     // Per-(view, tag) bitmap, indexed by tag. Custom tags only —
     // DEFAULT_VIEW_TAG visibility lives in `visibleViews`.
@@ -586,7 +585,6 @@ export class ChangeTree<T extends Ref = any> implements ChangeRecorder {
         // per-view visibility lives on the tree (NOT keyed by refId), so a
         // recycled tree must not inherit its previous life's view membership.
         this.visibleViews = undefined;
-        this.invisibleViews = undefined;
         this.tagViews = undefined;
         this.subscribedViews = undefined;
     }

package/src/encoder/Encoder.ts

@@ -119,16 +119,7 @@ function _fullSyncWalk(ctx: EncodeCtx, changeTree: ChangeTree): void {
     // Visibility gate: when a view is active, a non-visible tree contributes
     // nothing itself but we still recurse so descendants (possibly added to
     // the view explicitly) are reachable.
-    let visibleHere = true;
-    if (ctx.hasView) {
-        const view = ctx.view!;
-        if (!view.isChangeTreeVisible(changeTree)) {
-            view.markInvisible(changeTree);
-            visibleHere = false;
-        } else {
-            view.unmarkInvisible(changeTree);
-        }
-    }
+    const visibleHere = !ctx.hasView || ctx.view!.isChangeTreeVisible(changeTree);
 
     if (visibleHere) {
         const desc = changeTree.encDescriptor;
@@ -313,12 +304,8 @@ export class Encoder<T extends Schema = any> {
         while (current = current.next) {
             const changeTree = (current as ChangeTreeNode).changeTree;
 
-            if (hasView) {
-                if (!view.isChangeTreeVisible(changeTree)) {
-                    view.markInvisible(changeTree);
-                    continue;
-                }
-                view.unmarkInvisible(changeTree);
+            if (hasView && !view.isChangeTreeVisible(changeTree)) {
+                continue;
             }
 
             const recorder = unreliable ? changeTree.unreliableRecorder : changeTree;

package/src/encoder/StateView.ts

@@ -28,8 +28,6 @@ function _clearViewBitFromAllTrees(root: Root, slot: number, bit: number): void
         const tree = trees[refId];
         const v = tree.visibleViews;
         if (v !== undefined && slot < v.length) v[slot] &= clearMask;
-        const i = tree.invisibleViews;
-        if (i !== undefined && slot < i.length) i[slot] &= clearMask;
         const s = tree.subscribedViews;
         if (s !== undefined && slot < s.length) s[slot] &= clearMask;
         const t = tree.tagViews;
@@ -192,32 +190,6 @@ export class StateView {
         if (slot < arr.length) arr[slot] &= ~this._bit;
     }
 
-    /** True iff this view has previously marked `tree` as invisible. */
-    public isInvisible(tree: ChangeTree): boolean {
-        const arr = tree.invisibleViews;
-        const slot = this._slot;
-        return arr !== undefined && slot < arr.length && (arr[slot] & this._bit) !== 0;
-    }
-
-    /** Mark `tree` as invisible to this view (used by encode loop). */
-    public markInvisible(tree: ChangeTree): void {
-        const slot = this._slot;
-        let arr = tree.invisibleViews;
-        if (arr === undefined) {
-            arr = tree.invisibleViews = [];
-        }
-        while (arr.length <= slot) arr.push(0);
-        arr[slot] |= this._bit;
-    }
-
-    /** Clear invisible bit. */
-    public unmarkInvisible(tree: ChangeTree): void {
-        const arr = tree.invisibleViews;
-        if (arr === undefined) return;
-        const slot = this._slot;
-        if (slot < arr.length) arr[slot] &= ~this._bit;
-    }
-
     // ──────────────────────────────────────────────────────────────────
     // Per-tag, per-view bitmap. Replaces the legacy
     // `tags: WeakMap<ChangeTree, Set<number>>` storage. Hot read site is
@@ -371,13 +343,20 @@ export class StateView {
         // subclasses yield a real Metadata object.
         const metadata: Metadata = (obj.constructor as typeof Schema)[Symbol.metadata];
 
-        this.markVisible(changeTree);
-
-        // add to iterable list (only the explicitly added items)
-        if (this.iterable && checkIncludeParent) {
+        // Add to iterable list (only the explicitly added items), deduping
+        // re-adds of an already-visible instance. isVisible must be read
+        // BEFORE markVisible; indexOf runs only on the re-add path.
+        // NOTE: dedup applies to `items` only — a re-add still re-queues the
+        // full snapshot on purpose (shared-view bootstrap re-add: a
+        // late-attached client may not have consumed earlier drains).
+        // Callers wanting cheap idempotence can guard with `view.has(obj)`.
+        if (this.iterable && checkIncludeParent
+            && (!this.isVisible(changeTree) || this.items.indexOf(obj) === -1)) {
             this.items.push(obj);
         }
 
+        this.markVisible(changeTree);
+
         // add parent ChangeTree's
         // - if it was invisible to this view
         // - if it were previously filtered out
@@ -468,7 +447,6 @@ export class StateView {
 
         } else if (!changeTree.isNew || isChildAdded) {
             // new structures will be added as part of .encode() call, no need to force it to .encodeView()
-            const isInvisible = this.isInvisible(changeTree);
 
             // Full-sync snapshot: walk the live ref structurally instead of
             // iterating a cumulative recorder bucket. Every populated index
@@ -476,11 +454,14 @@ export class StateView {
             // at encode time). Per-field tags come from the descriptor's
             // precomputed `tags[]` array — direct index vs a metadata[i].tag
             // object hop.
+            //
+            // Non-matching custom-tagged fields are NEVER included here —
+            // `view.changes` is drained without a per-field tag re-check,
+            // so anything added leaks straight to the wire.
             const tags = changeTree.encDescriptor.tags;
             changeTree.forEachLive((index) => {
                 const tagAtIndex = tags[index];
                 if (
-                    isInvisible || // if "invisible", include all
                     tagAtIndex === undefined || // "all change" with no tag
                     tagAtIndex === DEFAULT_VIEW_TAG || // visible to all clients
                     (tag !== DEFAULT_VIEW_TAG && (tagAtIndex & tag) !== 0) // tag bits overlap
@@ -652,7 +633,7 @@ export class StateView {
 
         // ── Streamable-collection unsubscribe (the stream itself) ─────
         // Flush DELETE for every sent position and drop pending. After
-        // this, the stream is marked invisible to this view — any future
+        // this, the stream is no longer visible to this view — any future
         // `stream.add()` would still seed broadcast pending (if no views)
         // but would NOT re-seed per-view pending (user must re-subscribe).
         if (changeTree.isStreamCollection) {