@colyseus/schema 5.0.10 → 5.0.11

package/build/index.js

@@ -2598,7 +2598,6 @@
         // per-view WeakSet lookups with direct bitwise ops.
         // Lazy: undefined until the tree participates in any view.
         visibleViews;
-        invisibleViews;
         // Per-(view, tag) bitmap, indexed by tag. Custom tags only —
         // DEFAULT_VIEW_TAG visibility lives in `visibleViews`.
         tagViews;
@@ -2950,7 +2949,6 @@
             // per-view visibility lives on the tree (NOT keyed by refId), so a
             // recycled tree must not inherit its previous life's view membership.
             this.visibleViews = undefined;
-            this.invisibleViews = undefined;
             this.tagViews = undefined;
             this.subscribedViews = undefined;
         }
@@ -8010,17 +8008,7 @@
         // Visibility gate: when a view is active, a non-visible tree contributes
         // nothing itself but we still recurse so descendants (possibly added to
         // the view explicitly) are reachable.
-        let visibleHere = true;
-        if (ctx.hasView) {
-            const view = ctx.view;
-            if (!view.isChangeTreeVisible(changeTree)) {
-                view.markInvisible(changeTree);
-                visibleHere = false;
-            }
-            else {
-                view.unmarkInvisible(changeTree);
-            }
-        }
+        const visibleHere = !ctx.hasView || ctx.view.isChangeTreeVisible(changeTree);
         if (visibleHere) {
             const desc = changeTree.encDescriptor;
             ctx.changeTree = changeTree;
@@ -8169,12 +8157,8 @@
             let current = queue;
             while (current = current.next) {
                 const changeTree = current.changeTree;
-                if (hasView) {
-                    if (!view.isChangeTreeVisible(changeTree)) {
-                        view.markInvisible(changeTree);
-                        continue;
-                    }
-                    view.unmarkInvisible(changeTree);
+                if (hasView && !view.isChangeTreeVisible(changeTree)) {
+                    continue;
                 }
                 const recorder = unreliable ? changeTree.unreliableRecorder : changeTree;
                 if (!recorder || !recorder.has()) {
@@ -9866,9 +9850,6 @@
             const v = tree.visibleViews;
             if (v !== undefined && slot < v.length)
                 v[slot] &= clearMask;
-            const i = tree.invisibleViews;
-            if (i !== undefined && slot < i.length)
-                i[slot] &= clearMask;
             const s = tree.subscribedViews;
             if (s !== undefined && slot < s.length)
                 s[slot] &= clearMask;
@@ -10020,32 +10001,6 @@
             if (slot < arr.length)
                 arr[slot] &= ~this._bit;
         }
-        /** True iff this view has previously marked `tree` as invisible. */
-        isInvisible(tree) {
-            const arr = tree.invisibleViews;
-            const slot = this._slot;
-            return arr !== undefined && slot < arr.length && (arr[slot] & this._bit) !== 0;
-        }
-        /** Mark `tree` as invisible to this view (used by encode loop). */
-        markInvisible(tree) {
-            const slot = this._slot;
-            let arr = tree.invisibleViews;
-            if (arr === undefined) {
-                arr = tree.invisibleViews = [];
-            }
-            while (arr.length <= slot)
-                arr.push(0);
-            arr[slot] |= this._bit;
-        }
-        /** Clear invisible bit. */
-        unmarkInvisible(tree) {
-            const arr = tree.invisibleViews;
-            if (arr === undefined)
-                return;
-            const slot = this._slot;
-            if (slot < arr.length)
-                arr[slot] &= ~this._bit;
-        }
         // ──────────────────────────────────────────────────────────────────
         // Per-tag, per-view bitmap. Replaces the legacy
         // `tags: WeakMap<ChangeTree, Set<number>>` storage. Hot read site is
@@ -10189,11 +10144,18 @@
             // below use `metadata?.[...]` null-safe access. Only Schema
             // subclasses yield a real Metadata object.
             const metadata = obj.constructor[Symbol.metadata];
-            this.markVisible(changeTree);
-            // add to iterable list (only the explicitly added items)
-            if (this.iterable && checkIncludeParent) {
+            // Add to iterable list (only the explicitly added items), deduping
+            // re-adds of an already-visible instance. isVisible must be read
+            // BEFORE markVisible; indexOf runs only on the re-add path.
+            // NOTE: dedup applies to `items` only — a re-add still re-queues the
+            // full snapshot on purpose (shared-view bootstrap re-add: a
+            // late-attached client may not have consumed earlier drains).
+            // Callers wanting cheap idempotence can guard with `view.has(obj)`.
+            if (this.iterable && checkIncludeParent
+                && (!this.isVisible(changeTree) || this.items.indexOf(obj) === -1)) {
                 this.items.push(obj);
             }
+            this.markVisible(changeTree);
             // add parent ChangeTree's
             // - if it was invisible to this view
             // - if it were previously filtered out
@@ -10276,18 +10238,20 @@
             }
             else if (!changeTree.isNew || isChildAdded) {
                 // new structures will be added as part of .encode() call, no need to force it to .encodeView()
-                const isInvisible = this.isInvisible(changeTree);
                 // Full-sync snapshot: walk the live ref structurally instead of
                 // iterating a cumulative recorder bucket. Every populated index
                 // is emitted as ADD (matching the op-coercion previously done
                 // at encode time). Per-field tags come from the descriptor's
                 // precomputed `tags[]` array — direct index vs a metadata[i].tag
                 // object hop.
+                //
+                // Non-matching custom-tagged fields are NEVER included here —
+                // `view.changes` is drained without a per-field tag re-check,
+                // so anything added leaks straight to the wire.
                 const tags = changeTree.encDescriptor.tags;
                 changeTree.forEachLive((index) => {
                     const tagAtIndex = tags[index];
-                    if (isInvisible || // if "invisible", include all
-                        tagAtIndex === undefined || // "all change" with no tag
+                    if (tagAtIndex === undefined || // "all change" with no tag
                         tagAtIndex === DEFAULT_VIEW_TAG || // visible to all clients
                         (tag !== DEFAULT_VIEW_TAG && (tagAtIndex & tag) !== 0) // tag bits overlap
                     ) {
@@ -10439,7 +10403,7 @@
             }
             // ── Streamable-collection unsubscribe (the stream itself) ─────
             // Flush DELETE for every sent position and drop pending. After
-            // this, the stream is marked invisible to this view — any future
+            // this, the stream is no longer visible to this view — any future
             // `stream.add()` would still seed broadcast pending (if no views)
             // but would NOT re-seed per-view pending (user must re-subscribe).
             if (changeTree.isStreamCollection) {

package/build/index.mjs

@@ -2592,7 +2592,6 @@ class ChangeTree {
     // per-view WeakSet lookups with direct bitwise ops.
     // Lazy: undefined until the tree participates in any view.
     visibleViews;
-    invisibleViews;
     // Per-(view, tag) bitmap, indexed by tag. Custom tags only —
     // DEFAULT_VIEW_TAG visibility lives in `visibleViews`.
     tagViews;
@@ -2944,7 +2943,6 @@ class ChangeTree {
         // per-view visibility lives on the tree (NOT keyed by refId), so a
         // recycled tree must not inherit its previous life's view membership.
         this.visibleViews = undefined;
-        this.invisibleViews = undefined;
         this.tagViews = undefined;
         this.subscribedViews = undefined;
     }
@@ -8004,17 +8002,7 @@ function _fullSyncWalk(ctx, changeTree) {
     // Visibility gate: when a view is active, a non-visible tree contributes
     // nothing itself but we still recurse so descendants (possibly added to
     // the view explicitly) are reachable.
-    let visibleHere = true;
-    if (ctx.hasView) {
-        const view = ctx.view;
-        if (!view.isChangeTreeVisible(changeTree)) {
-            view.markInvisible(changeTree);
-            visibleHere = false;
-        }
-        else {
-            view.unmarkInvisible(changeTree);
-        }
-    }
+    const visibleHere = !ctx.hasView || ctx.view.isChangeTreeVisible(changeTree);
     if (visibleHere) {
         const desc = changeTree.encDescriptor;
         ctx.changeTree = changeTree;
@@ -8163,12 +8151,8 @@ class Encoder {
         let current = queue;
         while (current = current.next) {
             const changeTree = current.changeTree;
-            if (hasView) {
-                if (!view.isChangeTreeVisible(changeTree)) {
-                    view.markInvisible(changeTree);
-                    continue;
-                }
-                view.unmarkInvisible(changeTree);
+            if (hasView && !view.isChangeTreeVisible(changeTree)) {
+                continue;
             }
             const recorder = unreliable ? changeTree.unreliableRecorder : changeTree;
             if (!recorder || !recorder.has()) {
@@ -9860,9 +9844,6 @@ function _clearViewBitFromAllTrees(root, slot, bit) {
         const v = tree.visibleViews;
         if (v !== undefined && slot < v.length)
             v[slot] &= clearMask;
-        const i = tree.invisibleViews;
-        if (i !== undefined && slot < i.length)
-            i[slot] &= clearMask;
         const s = tree.subscribedViews;
         if (s !== undefined && slot < s.length)
             s[slot] &= clearMask;
@@ -10014,32 +9995,6 @@ class StateView {
         if (slot < arr.length)
             arr[slot] &= ~this._bit;
     }
-    /** True iff this view has previously marked `tree` as invisible. */
-    isInvisible(tree) {
-        const arr = tree.invisibleViews;
-        const slot = this._slot;
-        return arr !== undefined && slot < arr.length && (arr[slot] & this._bit) !== 0;
-    }
-    /** Mark `tree` as invisible to this view (used by encode loop). */
-    markInvisible(tree) {
-        const slot = this._slot;
-        let arr = tree.invisibleViews;
-        if (arr === undefined) {
-            arr = tree.invisibleViews = [];
-        }
-        while (arr.length <= slot)
-            arr.push(0);
-        arr[slot] |= this._bit;
-    }
-    /** Clear invisible bit. */
-    unmarkInvisible(tree) {
-        const arr = tree.invisibleViews;
-        if (arr === undefined)
-            return;
-        const slot = this._slot;
-        if (slot < arr.length)
-            arr[slot] &= ~this._bit;
-    }
     // ──────────────────────────────────────────────────────────────────
     // Per-tag, per-view bitmap. Replaces the legacy
     // `tags: WeakMap<ChangeTree, Set<number>>` storage. Hot read site is
@@ -10183,11 +10138,18 @@ class StateView {
         // below use `metadata?.[...]` null-safe access. Only Schema
         // subclasses yield a real Metadata object.
         const metadata = obj.constructor[Symbol.metadata];
-        this.markVisible(changeTree);
-        // add to iterable list (only the explicitly added items)
-        if (this.iterable && checkIncludeParent) {
+        // Add to iterable list (only the explicitly added items), deduping
+        // re-adds of an already-visible instance. isVisible must be read
+        // BEFORE markVisible; indexOf runs only on the re-add path.
+        // NOTE: dedup applies to `items` only — a re-add still re-queues the
+        // full snapshot on purpose (shared-view bootstrap re-add: a
+        // late-attached client may not have consumed earlier drains).
+        // Callers wanting cheap idempotence can guard with `view.has(obj)`.
+        if (this.iterable && checkIncludeParent
+            && (!this.isVisible(changeTree) || this.items.indexOf(obj) === -1)) {
             this.items.push(obj);
         }
+        this.markVisible(changeTree);
         // add parent ChangeTree's
         // - if it was invisible to this view
         // - if it were previously filtered out
@@ -10270,18 +10232,20 @@ class StateView {
         }
         else if (!changeTree.isNew || isChildAdded) {
             // new structures will be added as part of .encode() call, no need to force it to .encodeView()
-            const isInvisible = this.isInvisible(changeTree);
             // Full-sync snapshot: walk the live ref structurally instead of
             // iterating a cumulative recorder bucket. Every populated index
             // is emitted as ADD (matching the op-coercion previously done
             // at encode time). Per-field tags come from the descriptor's
             // precomputed `tags[]` array — direct index vs a metadata[i].tag
             // object hop.
+            //
+            // Non-matching custom-tagged fields are NEVER included here —
+            // `view.changes` is drained without a per-field tag re-check,
+            // so anything added leaks straight to the wire.
             const tags = changeTree.encDescriptor.tags;
             changeTree.forEachLive((index) => {
                 const tagAtIndex = tags[index];
-                if (isInvisible || // if "invisible", include all
-                    tagAtIndex === undefined || // "all change" with no tag
+                if (tagAtIndex === undefined || // "all change" with no tag
                     tagAtIndex === DEFAULT_VIEW_TAG || // visible to all clients
                     (tag !== DEFAULT_VIEW_TAG && (tagAtIndex & tag) !== 0) // tag bits overlap
                 ) {
@@ -10433,7 +10397,7 @@ class StateView {
         }
         // ── Streamable-collection unsubscribe (the stream itself) ─────
         // Flush DELETE for every sent position and drop pending. After
-        // this, the stream is marked invisible to this view — any future
+        // this, the stream is no longer visible to this view — any future
         // `stream.add()` would still seed broadcast pending (if no views)
         // but would NOT re-seed per-view pending (user must re-subscribe).
         if (changeTree.isStreamCollection) {