@codyswann/lisa 4.84.5 → 4.84.7

package/scripts/lib/host-name-target-cases.mjs

@@ -0,0 +1,298 @@
+/** Named real-wrapper cases; only synthetic identities are used. */
+export function hostNameTargetCases({
+  hostCwd,
+  lisaCwd,
+  unknownCwd,
+  body,
+  selectedLisa,
+  selectedHost,
+  relative,
+  quotedHost,
+  ambiguous,
+  fixtureName,
+  lisa,
+  host,
+}) {
+  return [
+    [
+      "host explicit --repo allowed",
+      hostCwd,
+      `gh pr create --repo ${host} --title t --body-file ${body}`,
+      0,
+    ],
+    [
+      "host explicit -R allowed",
+      hostCwd,
+      `gh issue create -R ${host} --title t --body-file ${body}`,
+      0,
+    ],
+    [
+      "host explicit --repo= allowed",
+      hostCwd,
+      `gh issue create --repo=${host} --title t --body-file ${body}`,
+      0,
+    ],
+    [
+      "host API endpoint allowed",
+      hostCwd,
+      `gh api repos/${host}/issues -X POST -f body=${fixtureName}`,
+      0,
+    ],
+    [
+      "host origin allowed",
+      hostCwd,
+      `gh issue create --title t --body-file ${body}`,
+      0,
+    ],
+    [
+      "protected explicit target blocked from host checkout",
+      hostCwd,
+      `gh issue create --repo ${lisa} --title t --body-file ${body}`,
+      2,
+    ],
+    [
+      "protected origin blocked",
+      lisaCwd,
+      `gh issue create --title t --body-file ${body}`,
+      2,
+    ],
+    [
+      "unknown target remains blocked",
+      unknownCwd,
+      `gh issue create --title t --body-file ${body}`,
+      2,
+    ],
+    [
+      "protected clean body allowed",
+      lisaCwd,
+      `gh pr create --repo ${lisa} --title t --body 'A clean report.'`,
+      0,
+    ],
+    [
+      "protected read-only request allowed",
+      lisaCwd,
+      `gh api repos/${lisa}/issues -X GET -F body=@${body}`,
+      0,
+    ],
+    [
+      "API explicit POST field-file control blocked",
+      hostCwd,
+      `gh api repos/${lisa}/issues -X POST -F body=@${body}`,
+      2,
+    ],
+    [
+      "review's See-repos body example remains blocked control",
+      lisaCwd,
+      `gh pr create --title t --body 'See repos/${host}/issues: ${fixtureName}'`,
+      2,
+    ],
+    [
+      "API-path-leading body cannot exempt protected write",
+      lisaCwd,
+      `gh pr create --title t --body 'repos/${host}/issues: ${fixtureName}'`,
+      2,
+    ],
+    [
+      "API unresolved placeholders retain protection",
+      lisaCwd,
+      `gh api 'repos/{owner}/{repo}/issues' -f body=${fixtureName}`,
+      2,
+    ],
+    [
+      "API -F default POST is inspected",
+      hostCwd,
+      `gh api repos/${lisa}/issues -F body=@${body}`,
+      2,
+    ],
+    [
+      "effective cd into protected checkout retains protection",
+      hostCwd,
+      `cd '${lisaCwd}' && gh issue create --title t --body '${fixtureName}'`,
+      2,
+    ],
+    [
+      "effective cd into host checkout permits host naming itself",
+      lisaCwd,
+      `cd '${hostCwd}' && gh issue create --title t --body '${fixtureName}'`,
+      0,
+    ],
+    [
+      "relative body file follows effective command cwd",
+      lisaCwd,
+      `cd '${relative}' && gh pr create --repo ${lisa} --title t --body-file body.md`,
+      2,
+    ],
+    [
+      "GH_REPO protected override outranks host origin",
+      hostCwd,
+      `gh issue create --title t --body-file ${body}`,
+      2,
+      { GH_REPO: lisa },
+    ],
+    [
+      "GH_REPO host override outranks protected origin",
+      lisaCwd,
+      `gh issue create --title t --body-file ${body}`,
+      0,
+      { GH_REPO: host },
+    ],
+    [
+      "selected protected default outranks host origin",
+      selectedLisa,
+      `gh issue create --title t --body-file ${body}`,
+      2,
+    ],
+    [
+      "selected host default outranks protected origin",
+      selectedHost,
+      `gh issue create --title t --body-file ${body}`,
+      0,
+    ],
+
+    [
+      "literal GH_REPO assignment protects Lisa",
+      hostCwd,
+      `GH_REPO=${lisa} gh issue create --title t --body-file ${body}`,
+      2,
+    ],
+    [
+      "literal assignment overrides inherited GH_REPO",
+      lisaCwd,
+      `GH_REPO=${host} gh issue create --title t --body-file ${body}`,
+      0,
+      { GH_REPO: lisa },
+    ],
+    [
+      "env GH_REPO assignment protects Lisa",
+      hostCwd,
+      `env GH_REPO=${lisa} gh issue create --title t --body-file ${body}`,
+      2,
+    ],
+    [
+      "env GH_REPO assignment permits host",
+      lisaCwd,
+      `env GH_REPO=${host} gh issue create --title t --body-file ${body}`,
+      0,
+    ],
+    [
+      "explicit host flag outranks GH_REPO",
+      lisaCwd,
+      `gh issue create --repo ${host} --title t --body-file ${body}`,
+      0,
+      { GH_REPO: lisa },
+    ],
+    [
+      "quoted directory separator stays literal",
+      lisaCwd,
+      `cd '${quotedHost}' && gh issue create --title t --body-file ${body}`,
+      0,
+    ],
+    [
+      "quoted body separators cannot redirect target",
+      lisaCwd,
+      `gh pr create --title t --body '${fixtureName}; cd ${hostCwd} && gh issue create'`,
+      2,
+    ],
+    [
+      "quoted repository-flag body stays prose",
+      lisaCwd,
+      `gh issue create --body '--repo=${host}'`,
+      2,
+    ],
+    [
+      "last repository alias selects protected target",
+      hostCwd,
+      `gh issue create --repo ${host} -R ${lisa} --body-file ${body}`,
+      2,
+    ],
+    [
+      "last repository alias selects host target",
+      lisaCwd,
+      `gh issue create --repo ${lisa} -R ${host} --body-file ${body}`,
+      0,
+    ],
+    [
+      "last method alias makes a POST",
+      hostCwd,
+      `gh api repos/${lisa}/issues -X GET --method POST -F body=@${body}`,
+      2,
+    ],
+    [
+      "last method alias keeps explicit GET read-only",
+      hostCwd,
+      `gh api repos/${lisa}/issues -X POST --method GET -F body=@${body}`,
+      0,
+    ],
+    [
+      "attached -F defaults to POST",
+      hostCwd,
+      `gh api repos/${lisa}/issues -Fbody=@${body}`,
+      2,
+    ],
+    [
+      "attached -R permits host target",
+      lisaCwd,
+      `gh issue create -R${host} --body-file ${body}`,
+      0,
+    ],
+    [
+      "unsupported cwd prefix retains protection",
+      hostCwd,
+      `pushd '${lisaCwd}' && gh issue create --body ${fixtureName}`,
+      2,
+    ],
+    [
+      "unresolved cwd retains protection",
+      hostCwd,
+      `cd "$UNKNOWN_DIRECTORY" && gh issue create --body ${fixtureName}`,
+      2,
+    ],
+    [
+      "ambiguous unselected remotes retain protection",
+      ambiguous,
+      `gh issue create --body-file ${body}`,
+      2,
+    ],
+    [
+      "host API placeholders resolve safely",
+      hostCwd,
+      `gh api 'repos/{owner}/{repo}/issues' -f body=${fixtureName}`,
+      0,
+    ],
+    [
+      "unresolved repository flag retains protection",
+      hostCwd,
+      `gh issue create --repo '$UNKNOWN_REPOSITORY' --body ${fixtureName}`,
+      2,
+    ],
+    [
+      "each command in a list retains protection",
+      hostCwd,
+      `gh issue create --repo ${host} --body ${fixtureName}; gh issue create --repo ${lisa} --body ${fixtureName}`,
+      2,
+    ],
+    [
+      "actual cwd is separate from detector root",
+      relative,
+      `gh issue create --repo ${lisa} --body-file body.md`,
+      2,
+      { CLAUDE_PROJECT_DIR: lisaCwd },
+    ],
+    [
+      "unknown cwd cannot silently inspect a relative body file elsewhere",
+      lisaCwd,
+      'cd "$UNKNOWN_DIRECTORY" && gh issue create --repo CodySwannGT/lisa --body-file body.md',
+      2,
+      {},
+      "BLOCKED: the working directory",
+    ],
+    [
+      "unknown cwd cannot silently inspect a relative API field elsewhere",
+      lisaCwd,
+      'cd "$UNKNOWN_DIRECTORY" && gh api repos/CodySwannGT/lisa/issues --field body=@body.md',
+      2,
+      {},
+      "BLOCKED: the working directory",
+    ],
+  ];
+}

package/scripts/two-channel-couplings.json

@@ -1,7 +1,8 @@
 {
   "ratified": {
     "quality.yml::scripts/check-learnings-budget.ts": "Lisa-source-only branch, and the else arm is the delivery. The step tests for BOTH scripts/check-learnings-budget.ts and src/core/learnings-budget-check.ts, which co-exist only in this repository; every consumer takes the else arm and runs the prover as `bunx @codyswann/lisa@<their own declared version>`, which is the PACKAGE channel and not a caller-tree read at all. A trailing `grep -qE \"learnings budget (passed|saturated)|no learnings file\"` then refuses a run that printed no verdict, so the arm cannot pass vacuously. Ratified because the caller-tree read is unreachable outside this repository, not because the gap is tolerated.",
-    "quality.yml::scripts/generate-nightly-e2e-guard-certificate.mjs": "Lisa-source-only branch. Both reusable jobs require `github.repository == 'CodySwannGT/lisa'` before the step can start, and the run body repeats that exact repository guard before checking this artifact path. Ordinary and private host callers therefore skip the step without reading or fetching from their own tree. The scoped branch fetches only the immutable refs needed to behavior-test Lisa's own retained certificate inputs. Ratified because the caller-tree read is unreachable outside this repository, not because an undelivered host dependency is tolerated."
+    "quality.yml::scripts/generate-nightly-e2e-guard-certificate.mjs": "Lisa-source-only branch. Both reusable jobs require `github.repository == 'CodySwannGT/lisa'` before the step can start, and the run body repeats that exact repository guard before checking this artifact path. Ordinary and private host callers therefore skip the step without reading or fetching from their own tree. The scoped branch fetches only the immutable refs needed to behavior-test Lisa's own retained certificate inputs. Ratified because the caller-tree read is unreachable outside this repository, not because an undelivered host dependency is tolerated.",
+    "quality.yml::scripts/verify-host-name-target-scope.mjs": "Lisa-source-only regression proof. The step requires `github.repository == 'CodySwannGT/lisa' && steps.gate_run.outcome == 'success'` before executing this driver. Every host caller skips the step without reading this path. Ratified because the caller-tree read is unreachable outside this repository; no host dependency is introduced."
   },
   "staleness": {
     "npm-updater.yml::scripts/lisa-npm-updater.mjs": {
@@ -99,30 +100,34 @@
     },
     "quality.yml::scripts/lisa-work-item.mjs": {
       "decision": "handshake"
+    },
+    "quality.yml::scripts/verify-host-name-target-scope.mjs": {
+      "decision": "not-needed",
+      "reason": "Unreachable outside this repository under the exact step-level repository guard ratified above. The driver and its cases run from the same Lisa checkout as the hooks under test. No consuming caller reads its installed or caller-tree copy through this workflow step, so no independently versioned consumer copy participates in this coupling."
     }
   },
   "inspected": {
     "workflows": 26,
-    "steps": 786,
-    "couplings": 36,
+    "steps": 787,
+    "couplings": 37,
     "inventory": 186
   },
   "counts": {
     "package-backed": 11,
     "apply-lagged": 23,
     "never-delivered": 0,
-    "undelivered": 2
+    "undelivered": 3
   },
   "detectionCounts": {
     "version-handshake": 4,
     "capability-probe": 0,
     "existence-only": 5,
     "no-probe": 14,
-    "unchecked": 2
+    "unchecked": 3
   },
   "decisionCounts": {
     "handshake": 4,
-    "not-needed": 11,
+    "not-needed": 12,
     "warranted": 10
   },
   "couplings": [
@@ -675,6 +680,24 @@
         "all/copy-overwrite"
       ],
       "detail": "`quality.yml` is delivered at `@main`, so this step is live in every consumer on their next run. It reads `scripts/lisa-work-item.mjs` from the CALLER's tree with no package-relative candidate, and Lisa delivers that path on the `lisa apply` channel (all/copy-overwrite). The two halves land in the wrong order: this step is live everywhere immediately, the file it needs is live only where somebody applied. The read sits behind an existence test, which is ALL this scan examined of the step's control flow: it did not read the test's other branch, any fallback, any explicit `exit`, or any verification of the step's output. Whether an absent path skips quietly, falls back, or fails loudly is therefore NOT MEASURED — read the step before concluding it proves nothing. The shape worth ruling out is the silent one, where a skip posts no context and an absent required context is not a red one. The step's text does carry `else-branch`, `exit-zero`, `exit-nonzero`, `error-annotation`, `notice-annotation` — located in the step, deliberately NOT related to this read, and enough to make \"it skips silently\" a claim to check rather than assume. STALENESS (a separate dimension from the delivery verdict above): `version-handshake`. The delivered artifact answers a contract version and the workflow asks for one, so a copy too old to speak the same contract is NAMED rather than silently run. Tokens found: `artifact-declares-version`, `artifact-answers-version`, `step-requests-version`, `workflow-requests-version`. `workflow-requests-version` is workflow-scoped — it does not say THIS step asks."
+    },
+    {
+      "key": "quality.yml::scripts/verify-host-name-target-scope.mjs",
+      "workflow": "quality.yml",
+      "path": "scripts/verify-host-name-target-scope.mjs",
+      "channel": "undelivered",
+      "verdict": "undelivered",
+      "remedy": "author-the-artifact",
+      "guarded": false,
+      "handling": [],
+      "detection": "unchecked",
+      "stalenessSignals": [
+        "workflow-requests-version"
+      ],
+      "decision": "not-needed",
+      "reason": "Unreachable outside this repository under the exact step-level repository guard ratified above. The driver and its cases run from the same Lisa checkout as the hooks under test. No consuming caller reads its installed or caller-tree copy through this workflow step, so no independently versioned consumer copy participates in this coupling.",
+      "lanes": [],
+      "detail": "`quality.yml` is delivered at `@main`, so this step is live in every consumer on their next run. It reads `scripts/verify-host-name-target-scope.mjs` from the CALLER's tree, and Lisa ships no such path in any delivery lane — no apply and no bump ever produces it. Either the consumer authors it, or whatever the step does where the path is missing runs instead — and that branch is the part this scan does not read. No existence test guards the read, which is ALL this scan examined of the step's control flow: it did not read anything that could absorb the failure. An absent path most likely fails the job loudly — the better of the two failures, because it is visible — but that is inferred from the missing guard, NOT MEASURED. The step's text carries none of the tokens this scan can see (`else-branch`, `exit-zero`, `exit-nonzero`, `error-annotation`, `notice-annotation`, `failure-suppression`), which is a statement about those names and not about the step's behaviour. STALENESS (a separate dimension from the delivery verdict above): `unchecked`. Lisa delivers nothing at this path, so there is no artifact to ask whether it could answer a version. The staleness half is UNKNOWN here — not current, and not probe-less. Tokens found: `workflow-requests-version`. `workflow-requests-version` is workflow-scoped — it does not say THIS step asks."
     }
   ]
 }