@codyswann/lisa 4.84.5 → 4.84.7

package/scripts/lib/host-name-expanded-command-cases.mjs

@@ -0,0 +1,286 @@
+/** Direct expanded command-name regressions; all identities are synthetic. */
+import assert from "node:assert/strict";
+import { boundedExecFileSync } from "./bounded-spawn.mjs";
+
+/** @param {object} context Isolated actual-wrapper fixtures. @returns {Array[]} Named cases. */
+export function hostNameExpandedCommandCases(context) {
+  const { lisaCwd, unknownCwd, hostCwd, lisa, host, fixtureName, body } =
+    context;
+  const cases = [];
+  for (const [target, cwd, repo] of [
+    ["protected", lisaCwd, ` --repo ${lisa}`],
+    ["unknown", unknownCwd, ""],
+  ]) {
+    for (const [name, noun] of [
+      ["unquoted", "$N"],
+      ["double quoted", '"$N"'],
+      ["braced", '"${N}"'],
+      ["concatenated", 'is"$SUFFIX"'],
+    ]) {
+      cases.push([
+        `expanded noun ${name} ${target} write`,
+        cwd,
+        `gh ${noun} create${repo} --body '${fixtureName}'`,
+        2,
+      ]);
+    }
+    for (const [name, verb] of [
+      ["unquoted", "$V"],
+      ["double quoted", '"$V"'],
+      ["braced", '"${V}"'],
+      ["concatenated", 'cre"$TAIL"'],
+    ]) {
+      cases.push([
+        `expanded verb ${name} ${target} write`,
+        cwd,
+        `gh issue ${verb}${repo} --body '${fixtureName}'`,
+        2,
+      ]);
+    }
+    for (const [name, prefix] of [
+      ["multiple-word noun", "gh $N"],
+      ["multiple-word verb", "gh issue $V"],
+      ["noun before read-looking word", "gh $N view"],
+      ["verb before read-looking word", "gh issue $V view"],
+    ]) {
+      cases.push([
+        `expanded ${name} ${target} write`,
+        cwd,
+        `${prefix}${repo} --body '${fixtureName}'`,
+        2,
+      ]);
+    }
+    for (const [name, args] of [
+      ["API field text", `-F body=${fixtureName}`],
+      ["API field file", `-F body=@${body}`],
+      ["API attached field file", `-Fbody=@${body}`],
+      ["API raw field", `-f body=${fixtureName}`],
+      ["API input file", `--input ${body}`],
+    ]) {
+      cases.push([
+        `expanded noun possible ${name} ${target} write`,
+        cwd,
+        `gh "$N" repos/${lisa}/issues ${args}`,
+        2,
+      ]);
+    }
+    cases.push(
+      [
+        `expanded noun issue body-file ${target} write`,
+        cwd,
+        `gh "$N" create${repo} -F ${body}`,
+        2,
+      ],
+      [
+        `expanded both command positions ${target} write`,
+        cwd,
+        `gh${repo} "$N" "$V" --body '${fixtureName}'`,
+        2,
+      ]
+    );
+  }
+  cases.push(
+    [
+      "expanded PR verb protected body-file write",
+      lisaCwd,
+      `gh pr "$V" --repo ${lisa} --body-file ${body}`,
+      2,
+    ],
+    [
+      "expanded PR verb unknown body-file write",
+      unknownCwd,
+      `gh pr "$V" --body-file ${body}`,
+      2,
+    ],
+    [
+      "expanded noun literal host flag cannot certify target",
+      hostCwd,
+      `gh "$N" create --repo ${host} --body '${fixtureName}'`,
+      2,
+    ],
+    [
+      "expanded-name API GET prose with dynamic filter control",
+      lisaCwd,
+      `gh api repos/${lisa}/issues -X GET -F body=${fixtureName} -q "$FILTER"`,
+      0,
+    ],
+    [
+      "expanded-name API GET input with dynamic filter control",
+      lisaCwd,
+      `gh api repos/${lisa}/issues -X GET --input ${body} -q "$FILTER"`,
+      0,
+    ],
+    [
+      "expanded-name literal host control",
+      hostCwd,
+      `gh issue create --repo ${host} --body '${fixtureName}'`,
+      0,
+    ],
+    [
+      "expanded-name literal protected control",
+      lisaCwd,
+      `gh issue create --repo ${lisa} --body '${fixtureName}'`,
+      2,
+    ],
+    [
+      "expanded-name literal unknown control",
+      unknownCwd,
+      `gh issue create --body '${fixtureName}'`,
+      2,
+    ],
+    [
+      "expanded-name dynamic read filter control",
+      lisaCwd,
+      `gh issue list --repo ${lisa} --json title --jq "$FILTER"`,
+      0,
+    ],
+    [
+      "expanded-name dynamic read selector control",
+      lisaCwd,
+      `gh issue view "$NUMBER" --repo ${lisa} --json title --jq '${fixtureName}'`,
+      0,
+    ],
+    [
+      "expanded-name API GET dynamic filter control",
+      lisaCwd,
+      `gh api repos/${lisa}/issues -X GET -q "$FILTER"`,
+      0,
+    ],
+    [
+      "expanded-name single-quoted noun control",
+      lisaCwd,
+      `gh '$N' create --repo ${lisa} --body '${fixtureName}'`,
+      0,
+    ],
+    [
+      "expanded-name single-quoted verb control",
+      lisaCwd,
+      `gh issue '$V' --repo ${lisa} --body '${fixtureName}'`,
+      0,
+    ],
+    [
+      "expanded-name escaped noun control",
+      lisaCwd,
+      `gh \\$N create --repo ${lisa} --body '${fixtureName}'`,
+      0,
+    ],
+    [
+      "expanded-name quoted non-command control",
+      lisaCwd,
+      `printf '%s' 'gh $N create --repo ${lisa} --body ${fixtureName}'`,
+      0,
+    ],
+    [
+      "expanded-name clean prose control",
+      lisaCwd,
+      `gh "$N" create --repo ${lisa} --body 'A clean report.'`,
+      0,
+    ],
+    [
+      "expanded-name options before noun preserve prose boundaries",
+      lisaCwd,
+      `gh --repo ${lisa} --title 'view list' "$N" create --body '${fixtureName}'`,
+      2,
+    ],
+    [
+      "expanded-name literal host API control",
+      hostCwd,
+      `gh api repos/${host}/issues -F body=${fixtureName}`,
+      0,
+    ]
+  );
+  return cases;
+}
+
+/**
+ * Establish expansion premises with a Bash function that only prints argv.
+ * @param {object} context Synthetic fixtures.
+ * @param {object} env Isolated child environment.
+ * @returns {void}
+ */
+export function verifyExpandedCommandArgv(context, env) {
+  const { lisaCwd, lisa, fixtureName, body } = context;
+  const suffix = ` --repo ${lisa} --body '${fixtureName}'`;
+  for (const [name, command, values, expected] of [
+    [
+      "unquoted noun",
+      `gh $N create${suffix}`,
+      { N: "issue" },
+      ["issue", "create", "--repo", lisa, "--body", fixtureName],
+    ],
+    [
+      "quoted braced noun",
+      `gh "${"${N}"}" create${suffix}`,
+      { N: "issue" },
+      ["issue", "create", "--repo", lisa, "--body", fixtureName],
+    ],
+    [
+      "concatenated noun",
+      `gh is"$SUFFIX" create${suffix}`,
+      { SUFFIX: "sue" },
+      ["issue", "create", "--repo", lisa, "--body", fixtureName],
+    ],
+    [
+      "concatenated verb",
+      `gh issue cre"$TAIL"${suffix}`,
+      { TAIL: "ate" },
+      ["issue", "create", "--repo", lisa, "--body", fixtureName],
+    ],
+    [
+      "multiword noun before read-looking word",
+      `gh $N view${suffix}`,
+      { N: "issue create --title" },
+      [
+        "issue",
+        "create",
+        "--title",
+        "view",
+        "--repo",
+        lisa,
+        "--body",
+        fixtureName,
+      ],
+    ],
+    [
+      "multiword verb before read-looking word",
+      `gh issue $V view${suffix}`,
+      { V: "create --title" },
+      [
+        "issue",
+        "create",
+        "--title",
+        "view",
+        "--repo",
+        lisa,
+        "--body",
+        fixtureName,
+      ],
+    ],
+    [
+      "possible API field file",
+      `gh "$N" repos/${lisa}/issues -F body=@${body}`,
+      { N: "api" },
+      ["api", `repos/${lisa}/issues`, "-F", `body=@${body}`],
+    ],
+  ]) {
+    const argv = boundedExecFileSync(
+      "/bin/bash",
+      ["-c", `gh() { printf '%s\\0' "$@"; }; ${command}`],
+      { cwd: lisaCwd, env: { ...env, ...values }, encoding: "utf8" }
+    )
+      .split("\0")
+      .slice(0, -1);
+    assert.deepEqual(argv, expected, name);
+    console.log(
+      JSON.stringify({
+        localExpandedArgvControl: {
+          name,
+          command,
+          argv,
+          inspectedTrackerWriteExecuted: false,
+          ghImplementation: "Bash argv-only printer",
+        },
+      })
+    );
+  }
+}

package/scripts/lib/host-name-field-occurrence-cases.mjs

@@ -0,0 +1,60 @@
+/** Repeated typed API fields must not hide an earlier unresolved prose file. */
+export function hostNameFieldOccurrenceCases({ lisaCwd, lisa, relative }) {
+  const prefix = 'cd "$D" && gh',
+    endpoint = `repos/${lisa}/issues`,
+    clean = `${lisaCwd}/body.md`,
+    refusal = "BLOCKED: the working directory";
+  const unknown = (name, command) => [name, lisaCwd, command, 2, {}, refusal];
+  return [
+    unknown(
+      "expanded repeated field retains earlier relative prose file",
+      `${prefix} "$N" ${endpoint} --field body=@body.md --field title=clean`
+    ),
+    unknown(
+      "literal API repeated field retains earlier relative prose file",
+      `${prefix} api ${endpoint} --field body=@body.md --field title=clean`
+    ),
+    unknown(
+      "literal API repeated F before absolute clean field retains relative file",
+      `${prefix} api ${endpoint} -F body=@body.md -F title=@${clean}`
+    ),
+    unknown(
+      "expanded repeated F union retains unresolved file control",
+      `${prefix} "$N" ${endpoint} -F body=@body.md -F title=@${clean}`
+    ),
+    unknown(
+      "expanded repeated field body-last control",
+      `${prefix} "$N" ${endpoint} --field title=clean --field body=@body.md`
+    ),
+    [
+      "literal API repeated fields known cwd reads original prose file",
+      lisaCwd,
+      `cd '${relative}' && gh api ${endpoint} --field body=@body.md --field title=clean`,
+      2,
+    ],
+    [
+      "literal API repeated fields GET remains read-only",
+      lisaCwd,
+      `${prefix} api ${endpoint} -X GET --field body=@body.md --field title=clean -q "$FILTER"`,
+      0,
+    ],
+    [
+      "nonadditive body-file last value remains authoritative",
+      lisaCwd,
+      `${prefix} issue create --repo ${lisa} --body-file missing.md --body-file ${clean}`,
+      0,
+    ],
+    unknown(
+      "expanded mixed field aliases retain earlier relative file control",
+      `${prefix} "$N" ${endpoint} --field body=@body.md -F title=@${clean}`
+    ),
+    unknown(
+      "expanded repeated equal field retains earlier relative file",
+      `${prefix} "$N" ${endpoint} --field=body=@body.md --field=title=clean`
+    ),
+    unknown(
+      "literal API repeated attached F retains earlier relative file",
+      `${prefix} api ${endpoint} -Fbody=@body.md -Ftitle=@${clean}`
+    ),
+  ];
+}

package/scripts/lib/host-name-review-cases.mjs

@@ -0,0 +1,354 @@
+/** Actual-wrapper regressions for independently reproduced target/context findings. */
+export function hostNameReviewCases({
+  hostCwd,
+  lisaCwd,
+  unknownCwd,
+  body,
+  cdStart,
+  cdSearch,
+  cdHost,
+  fixtureName,
+  lisa,
+  host,
+}) {
+  const continuation = "\\\n";
+  const cases = [
+    [
+      "continuation before the noun retains protected inspection",
+      hostCwd,
+      `gh ${continuation} issue create --repo ${lisa} --body ${fixtureName}`,
+      2,
+    ],
+    [
+      "continuation between noun and verb retains protected inspection",
+      hostCwd,
+      `gh issue ${continuation} create --repo ${lisa} --body ${fixtureName}`,
+      2,
+    ],
+    [
+      "continuation before body text retains protected inspection",
+      hostCwd,
+      `gh issue create --repo ${lisa} --body ${continuation} ${fixtureName}`,
+      2,
+    ],
+    [
+      "continuation before a host API endpoint preserves exemption",
+      lisaCwd,
+      `gh api ${continuation} repos/${host}/issues -f body=${fixtureName}`,
+      0,
+    ],
+    [
+      "continuation before a protected API endpoint retains inspection",
+      hostCwd,
+      `gh api ${continuation} repos/${lisa}/issues -f body=${fixtureName}`,
+      2,
+    ],
+    [
+      "continuation before explicit host repository preserves exemption",
+      lisaCwd,
+      `gh issue create --repo ${continuation} ${host} --body ${fixtureName}`,
+      0,
+    ],
+    [
+      "continuation before explicit protected repository retains inspection",
+      hostCwd,
+      `gh issue create --repo ${continuation} ${lisa} --body ${fixtureName}`,
+      2,
+    ],
+    [
+      "continuation between noun and verb keeps unknown target guarded",
+      unknownCwd,
+      `gh issue ${continuation} create --body ${fixtureName}`,
+      2,
+    ],
+    [
+      "continuation between noun and verb keeps known host allowed",
+      hostCwd,
+      `gh issue ${continuation} create --repo ${host} --body ${fixtureName}`,
+      0,
+    ],
+    [
+      "continuation before an API field value retains protected inspection",
+      hostCwd,
+      `gh api repos/${lisa}/issues -f ${continuation} body=${fixtureName}`,
+      2,
+    ],
+    [
+      "continuation within an existing verb preserves the word",
+      hostCwd,
+      `gh issue cre${continuation}ate --repo ${lisa} --body ${fixtureName}`,
+      2,
+    ],
+    [
+      "double quoted continuation preserves existing body text",
+      hostCwd,
+      `gh issue create --repo ${lisa} --body "${fixtureName.slice(0, 8)}${continuation}${fixtureName.slice(8)}"`,
+      2,
+    ],
+    [
+      "a real quoted empty verb stays distinct from continuation whitespace",
+      hostCwd,
+      `gh issue "" create --repo ${lisa} --body ${fixtureName}`,
+      0,
+    ],
+    [
+      "continuation after a quoted empty body preserves the empty value",
+      hostCwd,
+      `gh issue create --repo ${lisa} --body ""${continuation} ${fixtureName}`,
+      0,
+    ],
+    [
+      "continuation preserves nonliteral argument uncertainty",
+      hostCwd,
+      `gh issue create --repo ${host} --title "$TITLE${continuation}" --body ${fixtureName}`,
+      2,
+      { TITLE: "Unresolved title" },
+    ],
+    [
+      "CDPATH inherited lookup cannot certify a host target",
+      cdStart,
+      `cd target && gh issue create --body ${fixtureName}`,
+      2,
+      { CDPATH: cdSearch },
+    ],
+    [
+      "CDPATH export lookup cannot certify a host target",
+      cdStart,
+      `export CDPATH='${cdSearch}'; cd target && gh issue create --body ${fixtureName}`,
+      2,
+    ],
+    [
+      "CDPATH command assignment cannot certify a host target",
+      cdStart,
+      `CDPATH='${cdSearch}' cd target && gh issue create --body ${fixtureName}`,
+      2,
+    ],
+    [
+      "CDPATH standalone assignment cannot certify a host target",
+      cdStart,
+      `CDPATH='${cdSearch}'; cd target && gh issue create --body ${fixtureName}`,
+      2,
+    ],
+    [
+      "CDPATH relative body must not be read from the wrong directory",
+      cdStart,
+      `cd target && gh issue create --repo ${lisa} --body-file body.md`,
+      2,
+      { CDPATH: cdSearch },
+      "BLOCKED: the working directory",
+    ],
+    [
+      "uncertain CDPATH export cannot certify relative body location",
+      cdStart,
+      `export CDPATH="$SEARCH_PATH"; cd target && gh issue create --repo ${lisa} --body-file body.md`,
+      2,
+      { SEARCH_PATH: cdSearch },
+      "BLOCKED: the working directory",
+    ],
+    [
+      "dot relative cd bypasses CDPATH lookup",
+      cdStart,
+      `cd ./target && gh issue create --body ${fixtureName}`,
+      0,
+      { CDPATH: cdSearch },
+    ],
+    [
+      "parent relative cd bypasses CDPATH lookup",
+      cdHost,
+      `cd ../target && gh issue create --body ${fixtureName}`,
+      0,
+      { CDPATH: cdSearch },
+    ],
+    [
+      "absolute cd bypasses CDPATH lookup",
+      cdStart,
+      `cd '${cdHost}' && gh issue create --body ${fixtureName}`,
+      0,
+      { CDPATH: cdSearch },
+    ],
+    [
+      "empty CDPATH preserves literal relative cd",
+      cdStart,
+      `cd target && gh issue create --body ${fixtureName}`,
+      0,
+    ],
+    [
+      "unquoted argv expansion cannot add an unseen winning repo",
+      hostCwd,
+      `gh issue comment 1 --repo ${host} $ROUTING --body ${fixtureName}`,
+      2,
+      { ROUTING: `--repo ${lisa}` },
+    ],
+    [
+      "nonliteral consumed option value cannot earn target exemption",
+      hostCwd,
+      `gh issue create --repo ${host} --title "$TITLE" --body ${fixtureName}`,
+      2,
+      { TITLE: "Unresolved title" },
+    ],
+    [
+      "literal numeric selector keeps explicit host target",
+      lisaCwd,
+      `gh issue comment 1 --repo ${host} --body ${fixtureName}`,
+      0,
+    ],
+    [
+      "standalone unexported repository assignment cannot certify a target",
+      lisaCwd,
+      `GH_REPO=${host}; gh issue create --body ${fixtureName}`,
+      2,
+    ],
+    [
+      "API input alone defaults to inspected POST",
+      hostCwd,
+      `gh api repos/${lisa}/issues --input '${body}'`,
+      2,
+    ],
+    [
+      "API input explicit POST remains inspected",
+      hostCwd,
+      `gh api repos/${lisa}/issues --method POST --input '${body}'`,
+      2,
+    ],
+    [
+      "API input explicit GET remains read only",
+      hostCwd,
+      `gh api repos/${lisa}/issues --method GET --input '${body}'`,
+      0,
+    ],
+    [
+      "API input to verified host remains allowed",
+      lisaCwd,
+      `gh api repos/${host}/issues --input '${body}'`,
+      0,
+    ],
+    [
+      "mixed host and Lisa issue URLs retain protection",
+      hostCwd,
+      `gh issue edit https://github.com/${host}/issues/1 https://github.com/${lisa}/issues/2 --body ${fixtureName}`,
+      2,
+    ],
+    [
+      "host URL and numeric selectors select the common host",
+      hostCwd,
+      `gh issue edit https://github.com/${host}/issues/1 2 --body ${fixtureName}`,
+      0,
+    ],
+    [
+      "same-host URL selectors select the common host",
+      hostCwd,
+      `gh issue edit https://github.com/${host}/issues/1 https://github.com/${host}/issues/2 --body ${fixtureName}`,
+      0,
+    ],
+    [
+      "host URL batch outranks conflicting Lisa repo flag",
+      lisaCwd,
+      `gh issue edit https://github.com/${host}/issues/1 https://github.com/${host}/issues/2 --repo ${lisa} --body ${fixtureName}`,
+      0,
+    ],
+    [
+      "host URL with numeric selector outranks Lisa repo flag",
+      lisaCwd,
+      `gh issue edit https://github.com/${host}/issues/1 2 --repo ${lisa} --body ${fixtureName}`,
+      0,
+    ],
+    [
+      "numeric selector before host URL inherits the URL repository",
+      lisaCwd,
+      `gh issue edit 2 https://github.com/${host}/issues/1 --repo ${lisa} --body ${fixtureName}`,
+      0,
+    ],
+    [
+      "protected URL batch outranks conflicting host repo flag",
+      hostCwd,
+      `gh issue edit https://github.com/${lisa}/issues/1 https://github.com/${lisa}/issues/2 --repo ${host} --body ${fixtureName}`,
+      2,
+    ],
+    [
+      "protected URL with numeric selector outranks host repo flag",
+      hostCwd,
+      `gh issue edit https://github.com/${lisa}/issues/1 '#2' --repo ${host} --body ${fixtureName}`,
+      2,
+    ],
+    [
+      "numeric-only issue batch retains explicit host fallback",
+      lisaCwd,
+      `gh issue edit 1 2 --repo ${host} --body ${fixtureName}`,
+      0,
+    ],
+    [
+      "numeric-only issue batch retains protected fallback",
+      hostCwd,
+      `gh issue edit 1 2 --repo ${lisa} --body ${fixtureName}`,
+      2,
+    ],
+    [
+      "same owner and repository on different URL hosts stay unknown",
+      hostCwd,
+      `gh issue edit https://github.com/${host}/issues/1 https://other.example/${host}/issues/2 --body ${fixtureName}`,
+      2,
+    ],
+    [
+      "issue URL repository suffixes remain distinct batch identities",
+      hostCwd,
+      `gh issue edit https://github.com/${host}/issues/1 https://github.com/${host}.git/issues/2 --body ${fixtureName}`,
+      2,
+    ],
+    [
+      "invalid selector cannot inherit a host URL repository",
+      hostCwd,
+      `gh issue edit https://github.com/${host}/issues/1 not-an-issue --body ${fixtureName}`,
+      2,
+    ],
+    [
+      "nonliteral batch selector cannot inherit a host URL repository",
+      hostCwd,
+      `gh issue edit https://github.com/${host}/issues/1 $ISSUE_NUMBERS --body ${fixtureName}`,
+      2,
+      { ISSUE_NUMBERS: "2" },
+    ],
+    [
+      "issue comment retains single-selector boundary",
+      hostCwd,
+      `gh issue comment https://github.com/${host}/issues/1 https://github.com/${host}/issues/2 --body ${fixtureName}`,
+      2,
+    ],
+    [
+      "PR edit retains single-selector boundary",
+      hostCwd,
+      `gh pr edit https://github.com/${host}/pull/1 https://github.com/${host}/pull/2 --body ${fixtureName}`,
+      2,
+    ],
+    [
+      "unanimous host URL batch compares repository case insensitively",
+      lisaCwd,
+      `gh issue edit https://github.com/${host}/issues/1 https://github.com/${host.toUpperCase()}/issues/2 --repo ${lisa} --body ${fixtureName}`,
+      0,
+    ],
+  ];
+  for (const noun of ["issue", "pr"])
+    for (const verb of ["comment", "edit"]) {
+      const kind = noun === "issue" ? "issues" : "pull";
+      cases.push(
+        [
+          `${noun} ${verb} positional Lisa URL outranks host origin`,
+          hostCwd,
+          `gh ${noun} ${verb} https://github.com/${lisa}/${kind}/1 --body ${fixtureName}`,
+          2,
+        ],
+        [
+          `${noun} ${verb} positional Lisa URL outranks host repo flag`,
+          hostCwd,
+          `gh ${noun} ${verb} https://github.com/${lisa}/${kind}/1 --repo ${host} --body ${fixtureName}`,
+          2,
+        ],
+        [
+          `${noun} ${verb} positional host URL outranks Lisa repo flag`,
+          lisaCwd,
+          `gh ${noun} ${verb} https://github.com/${host}/${kind}/1 --repo ${lisa} --body ${fixtureName}`,
+          0,
+        ]
+      );
+    }
+  return cases;
+}