@codingame/monaco-vscode-api 26.2.2 → 28.0.0

package/vscode/src/vs/workbench/browser/parts/notifications/notificationsCenter.js

@@ -6,7 +6,7 @@ import * as notificationsActions from './media/notificationsActions.css';
 import { NOTIFICATIONS_CENTER_BORDER, NOTIFICATIONS_CENTER_HEADER_FOREGROUND, NOTIFICATIONS_CENTER_HEADER_BACKGROUND } from '../../../common/theme.js';
 import { Themable } from '../../../../platform/theme/common/themeService.js';
 import { IThemeService } from '../../../../platform/theme/common/themeService.service.js';
-import { NotificationChangeType, NotificationViewItemContentChangeKind } from '../../../common/notifications.js';
+import { NotificationsSettings, getNotificationsPosition, NotificationsPosition, NotificationChangeType, NotificationViewItemContentChangeKind } from '../../../common/notifications.js';
 import { Parts } from '../../../services/layout/browser/layoutService.js';
 import { IWorkbenchLayoutService } from '../../../services/layout/browser/layoutService.service.js';
 import { Emitter } from '../../../../base/common/event.js';
@@ -15,22 +15,14 @@ import { NotificationActionRunner } from './notificationsCommands.js';
 import { NotificationsList } from './notificationsList.js';
 import { IInstantiationService } from '../../../../platform/instantiation/common/instantiation.js';
 import { Dimension, $, isAncestorOfActiveElement } from '../../../../base/browser/dom.js';
-import '../../../../platform/theme/common/colorUtils.js';
-import '../../../../platform/theme/common/colors/baseColors.js';
-import '../../../../platform/theme/common/colors/chartsColors.js';
-import { widgetShadow } from '../../../../platform/theme/common/colors/editorColors.js';
-import '../../../../platform/theme/common/colors/inputColors.js';
-import '../../../../platform/theme/common/colors/listColors.js';
-import '../../../../platform/theme/common/colors/menuColors.js';
-import '../../../../platform/theme/common/colors/minimapColors.js';
-import '../../../../platform/theme/common/colors/miscColors.js';
-import '../../../../platform/theme/common/colors/quickpickColors.js';
-import '../../../../platform/theme/common/colors/searchColors.js';
 import { IEditorGroupsService } from '../../../services/editor/common/editorGroupsService.service.js';
 import { localize } from '../../../../nls.js';
 import { ActionBar } from '../../../../base/browser/ui/actionbar/actionbar.js';
-import { ConfigureDoNotDisturbAction, ToggleDoNotDisturbAction, ToggleDoNotDisturbBySourceAction, ClearAllNotificationsAction, HideNotificationsCenterAction } from './notificationsActions.js';
-import { toAction, Separator } from '../../../../base/common/actions.js';
+import { hideUpIcon, hideIcon, ConfigureNotificationsPositionAction, ConfigureDoNotDisturbAction, ToggleDoNotDisturbAction, ToggleDoNotDisturbBySourceAction, ClearAllNotificationsAction, HideNotificationsCenterAction } from './notificationsActions.js';
+import { Separator, toAction } from '../../../../base/common/actions.js';
+import { MenuId } from '../../../../platform/actions/common/actions.js';
+import { IMenuService } from '../../../../platform/actions/common/actions.service.js';
+import { createActionViewItem } from '../../../../platform/actions/browser/menuEntryActionViewItem.js';
 import { IKeybindingService } from '../../../../platform/keybinding/common/keybinding.service.js';
 import { assertReturnsDefined, assertReturnsAllDefined } from '../../../../base/common/types.js';
 import { NotificationsCenterVisibleContext } from '../../../common/contextkeys.js';
@@ -41,6 +33,9 @@ import { IContextMenuService } from '../../../../platform/contextview/browser/co
 import { DropdownMenuActionViewItem } from '../../../../base/browser/ui/dropdown/dropdownActionViewItem.js';
 import { AccessibilitySignal } from '../../../../platform/accessibilitySignal/browser/accessibilitySignalService.js';
 import { IAccessibilitySignalService } from '../../../../platform/accessibilitySignal/browser/accessibilitySignalService.service.js';
+import { IConfigurationService } from '../../../../platform/configuration/common/configuration.service.js';
+import { DEFAULT_CUSTOM_TITLEBAR_HEIGHT } from '../../../../platform/window/common/window.js';
+import { ThemeIcon } from '../../../../base/common/themables.js';
 
 var NotificationsCenter_1;
 registerCss(notificationsCenter);
@@ -66,18 +61,23 @@ let NotificationsCenter = class NotificationsCenter extends Themable {
         keybindingService,
         notificationService,
         accessibilitySignalService,
-        contextMenuService
+        contextMenuService,
+        configurationService,
+        menuService
     ) {
         super(themeService);
         this.container = container;
         this.model = model;
         this.instantiationService = instantiationService;
         this.layoutService = layoutService;
+        this.contextKeyService = contextKeyService;
         this.editorGroupService = editorGroupService;
         this.keybindingService = keybindingService;
         this.notificationService = notificationService;
         this.accessibilitySignalService = accessibilitySignalService;
         this.contextMenuService = contextMenuService;
+        this.configurationService = configurationService;
+        this.menuService = menuService;
         this._onDidChangeVisibility = this._register(( new Emitter()));
         this.onDidChangeVisibility = this._onDidChangeVisibility.event;
         this.notificationsCenterVisibleContextKey = NotificationsCenterVisibleContext.bindTo(contextKeyService);
@@ -89,6 +89,43 @@ let NotificationsCenter = class NotificationsCenter extends Themable {
             this.layoutService.onDidLayoutMainContainer(dimension => this.layout(Dimension.lift(dimension)))
         );
         this._register(this.notificationService.onDidChangeFilter(() => this.onDidChangeFilter()));
+        this._register(this.configurationService.onDidChangeConfiguration(e => {
+            if (e.affectsConfiguration(NotificationsSettings.NOTIFICATIONS_POSITION)) {
+                this.updatePositionClass();
+            }
+        }));
+    }
+    updatePositionClass() {
+        if (!this.notificationsCenterContainer) {
+            return;
+        }
+        const position = getNotificationsPosition(this.configurationService);
+        this.notificationsCenterContainer.classList.remove("bottom-right", "bottom-left", "top-right");
+        this.notificationsCenterContainer.classList.add(position);
+        this.updateHideActionIcon();
+        this.updateTopOffset();
+    }
+    updateHideActionIcon() {
+        if (!this.hideAction) {
+            return;
+        }
+        const position = getNotificationsPosition(this.configurationService);
+        this.hideAction.class = ThemeIcon.asClassName(position === NotificationsPosition.TOP_RIGHT ? hideUpIcon : hideIcon);
+    }
+    updateTopOffset() {
+        if (!this.notificationsCenterContainer) {
+            return;
+        }
+        const position = getNotificationsPosition(this.configurationService);
+        if (position === NotificationsPosition.TOP_RIGHT) {
+            let topOffset = 7;
+            if (this.layoutService.isVisible(Parts.TITLEBAR_PART, mainWindow)) {
+                topOffset += DEFAULT_CUSTOM_TITLEBAR_HEIGHT;
+            }
+            this.notificationsCenterContainer.style.top = `${topOffset}px`;
+        } else {
+            this.notificationsCenterContainer.style.top = "";
+        }
     }
     onDidChangeFilter() {
         if (this.notificationService.getFilter() === NotificationsFilter.ERROR) {
@@ -124,15 +161,16 @@ let NotificationsCenter = class NotificationsCenter extends Themable {
     updateTitle() {
         const [notificationsCenterTitle, clearAllAction] = assertReturnsAllDefined(this.notificationsCenterTitle, this.clearAllAction);
         if (this.model.notifications.length === 0) {
-            notificationsCenterTitle.textContent = ( localize(3550, "No new notifications"));
+            notificationsCenterTitle.textContent = ( localize(3614, "No new notifications"));
             clearAllAction.enabled = false;
         } else {
-            notificationsCenterTitle.textContent = ( localize(3551, "Notifications"));
+            notificationsCenterTitle.textContent = ( localize(3615, "Notifications"));
             clearAllAction.enabled = ( this.model.notifications.some(notification => !notification.hasProgress));
         }
     }
     create() {
         this.notificationsCenterContainer = $(".notifications-center");
+        this.updatePositionClass();
         this.notificationsCenterHeader = $(".notifications-center-header");
         this.notificationsCenterContainer.appendChild(this.notificationsCenterHeader);
         this.notificationsCenterTitle = $("span.notifications-center-header-title");
@@ -142,16 +180,28 @@ let NotificationsCenter = class NotificationsCenter extends Themable {
         const actionRunner = this._register(this.instantiationService.createInstance(NotificationActionRunner));
         const that = this;
         const notificationsToolBar = this._register(( new ActionBar(toolbarContainer, {
-            ariaLabel: ( localize(3552, "Notification Center Actions")),
+            ariaLabel: ( localize(3616, "Notification Center Actions")),
             actionRunner,
             actionViewItemProvider: (action, options) => {
+                if (action.id === ConfigureNotificationsPositionAction.ID) {
+                    return this._register(
+                        this.instantiationService.createInstance(DropdownMenuActionViewItem, action, {
+                            getActions: () => Separator.join(...( this.menuService.getMenuActions(MenuId.NotificationsCenterPositionMenu, this.contextKeyService).map(([, actions]) => actions)))
+                        }, this.contextMenuService, {
+                            ...options,
+                            actionRunner,
+                            classNames: action.class,
+                            keybindingProvider: action => this.keybindingService.lookupKeybinding(action.id)
+                        })
+                    );
+                }
                 if (action.id === ConfigureDoNotDisturbAction.ID) {
                     return this._register(
                         this.instantiationService.createInstance(DropdownMenuActionViewItem, action, {
                             getActions() {
                                 const actions = [toAction({
                                     id: ToggleDoNotDisturbAction.ID,
-                                    label: that.notificationService.getFilter() === NotificationsFilter.OFF ? ( localize(3553, "Enable Do Not Disturb Mode")) : ( localize(3554, "Disable Do Not Disturb Mode")),
+                                    label: that.notificationService.getFilter() === NotificationsFilter.OFF ? ( localize(3617, "Enable Do Not Disturb Mode")) : ( localize(3618, "Disable Do Not Disturb Mode")),
                                     run: () => that.notificationService.setFilter(
                                         that.notificationService.getFilter() === NotificationsFilter.OFF ? NotificationsFilter.ERROR : NotificationsFilter.OFF
                                     )
@@ -176,7 +226,7 @@ let NotificationsCenter = class NotificationsCenter extends Themable {
                                     actions.push(that._register(that.instantiationService.createInstance(
                                         ToggleDoNotDisturbBySourceAction,
                                         ToggleDoNotDisturbBySourceAction.ID,
-                                        ( localize(3555, "More…"))
+                                        ( localize(3619, "More…"))
                                     )));
                                 }
                                 return actions;
@@ -189,7 +239,7 @@ let NotificationsCenter = class NotificationsCenter extends Themable {
                         })
                     );
                 }
-                return undefined;
+                return createActionViewItem(this.instantiationService, action, options);
             }
         })));
         this.clearAllAction = this._register(this.instantiationService.createInstance(
@@ -211,18 +261,28 @@ let NotificationsCenter = class NotificationsCenter extends Themable {
             icon: true,
             label: false
         });
-        const hideAllAction = this._register(this.instantiationService.createInstance(
+        const configureNotificationsPositionAction = this._register(this.instantiationService.createInstance(
+            ConfigureNotificationsPositionAction,
+            ConfigureNotificationsPositionAction.ID,
+            ConfigureNotificationsPositionAction.LABEL
+        ));
+        notificationsToolBar.push(configureNotificationsPositionAction, {
+            icon: true,
+            label: false
+        });
+        this.hideAction = this._register(this.instantiationService.createInstance(
             HideNotificationsCenterAction,
             HideNotificationsCenterAction.ID,
             HideNotificationsCenterAction.LABEL
         ));
-        notificationsToolBar.push(hideAllAction, {
+        this.updateHideActionIcon();
+        notificationsToolBar.push(this.hideAction, {
             icon: true,
             label: false,
-            keybinding: this.getKeybindingLabel(hideAllAction)
+            keybinding: this.getKeybindingLabel(this.hideAction)
         });
         this.notificationsList = this.instantiationService.createInstance(NotificationsList, this.notificationsCenterContainer, {
-            widgetAriaLabel: ( localize(3556, "Notifications Center"))
+            widgetAriaLabel: ( localize(3620, "Notifications Center"))
         });
         this.container.appendChild(this.notificationsCenterContainer);
     }
@@ -287,8 +347,6 @@ let NotificationsCenter = class NotificationsCenter extends Themable {
     }
     updateStyles() {
         if (this.notificationsCenterContainer && this.notificationsCenterHeader) {
-            const widgetShadowColor = this.getColor(widgetShadow);
-            this.notificationsCenterContainer.style.boxShadow = widgetShadowColor ? `0 0 8px 2px ${widgetShadowColor}` : "";
             const borderColor = this.getColor(NOTIFICATIONS_CENTER_BORDER);
             this.notificationsCenterContainer.style.border = borderColor ? `1px solid ${borderColor}` : "";
             const headerForeground = this.getColor(NOTIFICATIONS_CENTER_HEADER_FOREGROUND);
@@ -316,6 +374,7 @@ let NotificationsCenter = class NotificationsCenter extends Themable {
                 }
                 availableHeight -= (2 * 12);
             }
+            this.updateTopOffset();
             const notificationsList = assertReturnsDefined(this.notificationsList);
             notificationsList.layout(Math.min(maxWidth, availableWidth), Math.min(maxHeight, availableHeight));
         }
@@ -330,6 +389,6 @@ let NotificationsCenter = class NotificationsCenter extends Themable {
         }
     }
 };
-NotificationsCenter = NotificationsCenter_1 = ( __decorate([( __param(2, IThemeService)), ( __param(3, IInstantiationService)), ( __param(4, IWorkbenchLayoutService)), ( __param(5, IContextKeyService)), ( __param(6, IEditorGroupsService)), ( __param(7, IKeybindingService)), ( __param(8, INotificationService)), ( __param(9, IAccessibilitySignalService)), ( __param(10, IContextMenuService))], NotificationsCenter));
+NotificationsCenter = NotificationsCenter_1 = ( __decorate([( __param(2, IThemeService)), ( __param(3, IInstantiationService)), ( __param(4, IWorkbenchLayoutService)), ( __param(5, IContextKeyService)), ( __param(6, IEditorGroupsService)), ( __param(7, IKeybindingService)), ( __param(8, INotificationService)), ( __param(9, IAccessibilitySignalService)), ( __param(10, IContextMenuService)), ( __param(11, IConfigurationService)), ( __param(12, IMenuService))], NotificationsCenter));
 
 export { NotificationsCenter };

package/vscode/src/vs/workbench/browser/parts/notifications/notificationsCommands.js

@@ -4,8 +4,8 @@ import { CommandsRegistry } from '../../../../platform/commands/common/commands.
 import { ContextKeyExpr } from '../../../../platform/contextkey/common/contextkey.js';
 import { KeybindingsRegistry, KeybindingWeight } from '../../../../platform/keybinding/common/keybindingsRegistry.js';
 import { KeyChord, KeyMod as KeyMod$1, KeyCode } from '../../../../base/common/keyCodes.js';
-import { isNotificationViewItem } from '../../../common/notifications.js';
-import { MenuRegistry, MenuId } from '../../../../platform/actions/common/actions.js';
+import { isNotificationViewItem, NotificationsSettings, NotificationsPosition } from '../../../common/notifications.js';
+import { MenuRegistry, MenuId, registerAction2, Action2 } from '../../../../platform/actions/common/actions.js';
 import { localize, localize2 } from '../../../../nls.js';
 import { WorkbenchList } from '../../../../platform/list/browser/listService.js';
 import { IListService } from '../../../../platform/list/browser/listService.service.js';
@@ -19,6 +19,8 @@ import { IQuickInputService } from '../../../../platform/quickinput/common/quick
 import { DisposableStore } from '../../../../base/common/lifecycle.js';
 import { AccessibilitySignal } from '../../../../platform/accessibilitySignal/browser/accessibilitySignalService.js';
 import { IAccessibilitySignalService } from '../../../../platform/accessibilitySignal/browser/accessibilitySignalService.service.js';
+import { Codicon } from '../../../../base/common/codicons.js';
+import { IConfigurationService } from '../../../../platform/configuration/common/configuration.service.js';
 
 const SHOW_NOTIFICATIONS_CENTER = "notifications.showList";
 const HIDE_NOTIFICATIONS_CENTER = "notifications.hideList";
@@ -225,7 +227,7 @@ function registerNotificationCommands(center, toasts, model) {
             filter: source.filter
         })));
         picker.canSelectMany = true;
-        picker.placeholder = ( localize(3557, "Select sources to enable all notifications from"));
+        picker.placeholder = ( localize(3621, "Select sources to enable all notifications from"));
         picker.selectedItems = picker.items.filter(item => item.filter === NotificationsFilter.OFF);
         picker.show();
         disposables.add(picker.onDidAccept(async () => {
@@ -240,18 +242,18 @@ function registerNotificationCommands(center, toasts, model) {
         }));
         disposables.add(picker.onDidHide(() => disposables.dispose()));
     });
-    const category = ( localize2(3558, "Notifications"));
+    const category = ( localize2(3622, "Notifications"));
     MenuRegistry.appendMenuItem(MenuId.CommandPalette, {
         command: {
             id: SHOW_NOTIFICATIONS_CENTER,
-            title: ( localize2(3559, "Show Notifications")),
+            title: ( localize2(3623, "Show Notifications")),
             category
         }
     });
     MenuRegistry.appendMenuItem(MenuId.CommandPalette, {
         command: {
             id: HIDE_NOTIFICATIONS_CENTER,
-            title: ( localize2(3560, "Hide Notifications")),
+            title: ( localize2(3624, "Hide Notifications")),
             category
         },
         when: NotificationsCenterVisibleContext
@@ -259,40 +261,119 @@ function registerNotificationCommands(center, toasts, model) {
     MenuRegistry.appendMenuItem(MenuId.CommandPalette, {
         command: {
             id: CLEAR_ALL_NOTIFICATIONS,
-            title: ( localize2(3561, "Clear All Notifications")),
+            title: ( localize2(3625, "Clear All Notifications")),
             category
         }
     });
     MenuRegistry.appendMenuItem(MenuId.CommandPalette, {
         command: {
             id: ACCEPT_PRIMARY_ACTION_NOTIFICATION,
-            title: ( localize2(3562, "Accept Notification Primary Action")),
+            title: ( localize2(3626, "Accept Notification Primary Action")),
             category
         }
     });
     MenuRegistry.appendMenuItem(MenuId.CommandPalette, {
         command: {
             id: TOGGLE_DO_NOT_DISTURB_MODE,
-            title: ( localize2(3563, "Toggle Do Not Disturb Mode")),
+            title: ( localize2(3627, "Toggle Do Not Disturb Mode")),
             category
         }
     });
     MenuRegistry.appendMenuItem(MenuId.CommandPalette, {
         command: {
             id: TOGGLE_DO_NOT_DISTURB_MODE_BY_SOURCE,
-            title: ( localize2(3564, "Toggle Do Not Disturb Mode By Source...")),
+            title: ( localize2(3628, "Toggle Do Not Disturb Mode By Source...")),
             category
         }
     });
     MenuRegistry.appendMenuItem(MenuId.CommandPalette, {
         command: {
             id: FOCUS_NOTIFICATION_TOAST,
-            title: ( localize2(3565, "Focus Notification Toast")),
+            title: ( localize2(3629, "Focus Notification Toast")),
             category
         },
         when: NotificationsToastsVisibleContext
     });
+    MenuRegistry.appendMenuItem(MenuId.TitleBar, {
+        command: {
+            id: TOGGLE_NOTIFICATIONS_CENTER,
+            title: ( localize(3630, "Toggle Notifications")),
+            icon: Codicon.bell
+        },
+        group: "navigation",
+        order: 10000,
+        when: ( ContextKeyExpr.and(( ContextKeyExpr.equals(
+            `config.${NotificationsSettings.NOTIFICATIONS_POSITION}`,
+            NotificationsPosition.TOP_RIGHT
+        )), ( ContextKeyExpr.equals(`config.${NotificationsSettings.NOTIFICATIONS_BUTTON}`, true))))
+    });
 }
+registerAction2(class SetNotificationsPositionBottomRight extends Action2 {
+    constructor() {
+        super({
+            id: "workbench.action.setNotificationsPosition.bottomRight",
+            title: ( localize2(3631, "Bottom Right")),
+            toggled: ( ContextKeyExpr.equals(
+                `config.${NotificationsSettings.NOTIFICATIONS_POSITION}`,
+                NotificationsPosition.BOTTOM_RIGHT
+            )),
+            menu: {
+                id: MenuId.NotificationsCenterPositionMenu,
+                order: 1
+            }
+        });
+    }
+    run(accessor) {
+        accessor.get(IConfigurationService).updateValue(
+            NotificationsSettings.NOTIFICATIONS_POSITION,
+            NotificationsPosition.BOTTOM_RIGHT
+        );
+    }
+});
+registerAction2(class SetNotificationsPositionBottomLeft extends Action2 {
+    constructor() {
+        super({
+            id: "workbench.action.setNotificationsPosition.bottomLeft",
+            title: ( localize2(3632, "Bottom Left")),
+            toggled: ( ContextKeyExpr.equals(
+                `config.${NotificationsSettings.NOTIFICATIONS_POSITION}`,
+                NotificationsPosition.BOTTOM_LEFT
+            )),
+            menu: {
+                id: MenuId.NotificationsCenterPositionMenu,
+                order: 2
+            }
+        });
+    }
+    run(accessor) {
+        accessor.get(IConfigurationService).updateValue(
+            NotificationsSettings.NOTIFICATIONS_POSITION,
+            NotificationsPosition.BOTTOM_LEFT
+        );
+    }
+});
+registerAction2(class SetNotificationsPositionTopRight extends Action2 {
+    constructor() {
+        super({
+            id: "workbench.action.setNotificationsPosition.topRight",
+            title: ( localize2(3633, "Top Right")),
+            toggled: ( ContextKeyExpr.equals(
+                `config.${NotificationsSettings.NOTIFICATIONS_POSITION}`,
+                NotificationsPosition.TOP_RIGHT
+            )),
+            menu: {
+                id: MenuId.NotificationsCenterPositionMenu,
+                order: 3
+            }
+        });
+    }
+    run(accessor) {
+        accessor.get(IConfigurationService).updateValue(
+            NotificationsSettings.NOTIFICATIONS_POSITION,
+            NotificationsPosition.TOP_RIGHT
+        );
+    }
+});
 let NotificationActionRunner = class NotificationActionRunner extends ActionRunner {
     constructor(telemetryService, notificationService) {
         super();

package/vscode/src/vs/workbench/browser/parts/notifications/notificationsList.js

@@ -180,29 +180,29 @@ let NotificationAccessibilityProvider = class NotificationAccessibilityProvider
         let accessibleViewHint;
         const keybinding = this._keybindingService.lookupKeybinding("editor.action.accessibleView")?.getAriaLabel();
         if (this._configurationService.getValue("accessibility.verbosity.notification")) {
-            accessibleViewHint = keybinding ? ( localize(3566, "Inspect the response in the accessible view with {0}", keybinding)) : ( localize(
-                3567,
+            accessibleViewHint = keybinding ? ( localize(3634, "Inspect the response in the accessible view with {0}", keybinding)) : ( localize(
+                3635,
                 "Inspect the response in the accessible view via the command Open Accessible View which is currently not triggerable via keybinding"
             ));
         }
         if (!element.source) {
-            return withSeverityPrefix(accessibleViewHint ? ( localize(3568, "{0}, notification, {1}", element.message.raw, accessibleViewHint)) : ( localize(3569, "{0}, notification", element.message.raw)), element.severity);
+            return withSeverityPrefix(accessibleViewHint ? ( localize(3636, "{0}, notification, {1}", element.message.raw, accessibleViewHint)) : ( localize(3637, "{0}, notification", element.message.raw)), element.severity);
         }
         return withSeverityPrefix(accessibleViewHint ? ( localize(
-            3570,
+            3638,
             "{0}, source: {1}, notification, {2}",
             element.message.raw,
             element.source,
             accessibleViewHint
         )) : ( localize(
-            3571,
+            3639,
             "{0}, source: {1}, notification",
             element.message.raw,
             element.source
         )), element.severity);
     }
     getWidgetAriaLabel() {
-        return this._options.widgetAriaLabel ?? ( localize(3572, "Notifications List"));
+        return this._options.widgetAriaLabel ?? ( localize(3640, "Notifications List"));
     }
     getRole() {
         return "dialog";

package/vscode/src/vs/workbench/browser/parts/notifications/notificationsStatus.d.ts

@@ -2,19 +2,23 @@ import { INotificationsModel } from "../../../common/notifications.js";
 import { IStatusbarService } from "../../../services/statusbar/browser/statusbar.service.js";
 import { Disposable } from "../../../../base/common/lifecycle.js";
 import { INotificationService } from "../../../../platform/notification/common/notification.service.js";
+import { IConfigurationService } from "../../../../platform/configuration/common/configuration.service.js";
 export declare class NotificationsStatus extends Disposable {
     private readonly model;
     private readonly statusbarService;
     private readonly notificationService;
+    private readonly configurationService;
     private notificationsCenterStatusItem;
     private newNotificationsCount;
     private currentStatusMessage;
     private isNotificationsCenterVisible;
     private isNotificationsToastsVisible;
-    constructor(model: INotificationsModel, statusbarService: IStatusbarService, notificationService: INotificationService);
+    private currentAlignment;
+    constructor(model: INotificationsModel, statusbarService: IStatusbarService, notificationService: INotificationService, configurationService: IConfigurationService);
     private registerListeners;
     private onDidChangeNotification;
     private updateNotificationsCenterStatusItem;
+    private getDesiredAlignment;
     private getTooltip;
     update(isCenterVisible: boolean, isToastsVisible: boolean): void;
     private onDidChangeStatusMessage;

package/vscode/src/vs/workbench/browser/parts/notifications/notificationsStatus.js

@@ -1,6 +1,6 @@
 
 import { __decorate, __param } from '../../../../../../../external/tslib/tslib.es6.js';
-import { NotificationChangeType, StatusMessageChangeType } from '../../../common/notifications.js';
+import { NotificationsSettings, NotificationChangeType, getNotificationsPosition, NotificationsPosition, StatusMessageChangeType } from '../../../common/notifications.js';
 import { StatusbarAlignment } from '../../../services/statusbar/browser/statusbar.js';
 import { IStatusbarService } from '../../../services/statusbar/browser/statusbar.service.js';
 import { Disposable, dispose } from '../../../../base/common/lifecycle.js';
@@ -8,13 +8,15 @@ import { HIDE_NOTIFICATIONS_CENTER, SHOW_NOTIFICATIONS_CENTER } from './notifica
 import { localize } from '../../../../nls.js';
 import { NotificationsFilter } from '../../../../platform/notification/common/notification.js';
 import { INotificationService } from '../../../../platform/notification/common/notification.service.js';
+import { IConfigurationService } from '../../../../platform/configuration/common/configuration.service.js';
 
 let NotificationsStatus = class NotificationsStatus extends Disposable {
-    constructor(model, statusbarService, notificationService) {
+    constructor(model, statusbarService, notificationService, configurationService) {
         super();
         this.model = model;
         this.statusbarService = statusbarService;
         this.notificationService = notificationService;
+        this.configurationService = configurationService;
         this.newNotificationsCount = 0;
         this.isNotificationsCenterVisible = false;
         this.isNotificationsToastsVisible = false;
@@ -30,6 +32,11 @@ let NotificationsStatus = class NotificationsStatus extends Disposable {
         this._register(
             this.notificationService.onDidChangeFilter(() => this.updateNotificationsCenterStatusItem())
         );
+        this._register(this.configurationService.onDidChangeConfiguration(e => {
+            if (e.affectsConfiguration(NotificationsSettings.NOTIFICATIONS_POSITION)) {
+                this.updateNotificationsCenterStatusItem();
+            }
+        }));
     }
     onDidChangeNotification(e) {
         if (!this.isNotificationsCenterVisible) {
@@ -51,9 +58,9 @@ let NotificationsStatus = class NotificationsStatus extends Disposable {
             }
         }
         let statusProperties = {
-            name: ( localize(3573, "Notifications")),
+            name: ( localize(3641, "Notifications")),
             text: `${notificationsInProgress > 0 || this.newNotificationsCount > 0 ? "$(bell-dot)" : "$(bell)"}`,
-            ariaLabel: ( localize(3573, "Notifications")),
+            ariaLabel: ( localize(3641, "Notifications")),
             command: this.isNotificationsCenterVisible ? HIDE_NOTIFICATIONS_CENTER : SHOW_NOTIFICATIONS_CENTER,
             tooltip: this.getTooltip(notificationsInProgress),
             showBeak: this.isNotificationsCenterVisible
@@ -62,45 +69,71 @@ let NotificationsStatus = class NotificationsStatus extends Disposable {
             statusProperties = {
                 ...statusProperties,
                 text: `${notificationsInProgress > 0 || this.newNotificationsCount > 0 ? "$(bell-slash-dot)" : "$(bell-slash)"}`,
-                ariaLabel: ( localize(3574, "Do Not Disturb")),
-                tooltip: ( localize(3575, "Do Not Disturb Mode is Enabled"))
+                ariaLabel: ( localize(3642, "Do Not Disturb")),
+                tooltip: ( localize(3643, "Do Not Disturb Mode is Enabled"))
             };
         }
-        if (!this.notificationsCenterStatusItem) {
-            this.notificationsCenterStatusItem = this.statusbarService.addEntry(
-                statusProperties,
-                "status.notifications",
-                StatusbarAlignment.RIGHT,
-                Number.NEGATIVE_INFINITY
-            );
-        } else {
-            this.notificationsCenterStatusItem.update(statusProperties);
+        const position = getNotificationsPosition(this.configurationService);
+        if (position === NotificationsPosition.TOP_RIGHT) {
+            this.notificationsCenterStatusItem?.dispose();
+            this.notificationsCenterStatusItem = undefined;
+            this.currentAlignment = undefined;
+        }
+        else {
+            const desiredAlignment = this.getDesiredAlignment();
+            if (this.currentAlignment !== desiredAlignment) {
+                this.notificationsCenterStatusItem?.dispose();
+                this.notificationsCenterStatusItem = undefined;
+                this.currentAlignment = desiredAlignment;
+            }
+            if (!this.notificationsCenterStatusItem) {
+                this.notificationsCenterStatusItem = this.statusbarService.addEntry(
+                    statusProperties,
+                    "status.notifications",
+                    this.currentAlignment,
+                    this.currentAlignment === StatusbarAlignment.LEFT ?
+                    Number.MAX_SAFE_INTEGER : Number.NEGATIVE_INFINITY
+                );
+            } else {
+                this.notificationsCenterStatusItem.update(statusProperties);
+            }
+        }
+    }
+    getDesiredAlignment() {
+        const position = getNotificationsPosition(this.configurationService);
+        switch (position) {
+        case NotificationsPosition.BOTTOM_LEFT:
+            return StatusbarAlignment.LEFT;
+        case NotificationsPosition.TOP_RIGHT:
+        case NotificationsPosition.BOTTOM_RIGHT:
+        default:
+            return StatusbarAlignment.RIGHT;
         }
     }
     getTooltip(notificationsInProgress) {
         if (this.isNotificationsCenterVisible) {
-            return localize(3576, "Hide Notifications");
+            return localize(3644, "Hide Notifications");
         }
         if (this.model.notifications.length === 0) {
-            return localize(3577, "No Notifications");
+            return localize(3645, "No Notifications");
         }
         if (notificationsInProgress === 0) {
             if (this.newNotificationsCount === 0) {
-                return localize(3578, "No New Notifications");
+                return localize(3646, "No New Notifications");
             }
             if (this.newNotificationsCount === 1) {
-                return localize(3579, "1 New Notification");
+                return localize(3647, "1 New Notification");
             }
-            return localize(3580, "{0} New Notifications", this.newNotificationsCount);
+            return localize(3648, "{0} New Notifications", this.newNotificationsCount);
         }
         if (this.newNotificationsCount === 0) {
-            return localize(3581, "No New Notifications ({0} in progress)", notificationsInProgress);
+            return localize(3649, "No New Notifications ({0} in progress)", notificationsInProgress);
         }
         if (this.newNotificationsCount === 1) {
-            return localize(3582, "1 New Notification ({0} in progress)", notificationsInProgress);
+            return localize(3650, "1 New Notification ({0} in progress)", notificationsInProgress);
         }
         return localize(
-            3583,
+            3651,
             "{0} New Notifications ({1} in progress)",
             this.newNotificationsCount,
             notificationsInProgress
@@ -145,7 +178,7 @@ let NotificationsStatus = class NotificationsStatus extends Disposable {
         let statusMessageEntry;
         let showHandle = setTimeout(() => {
             statusMessageEntry = this.statusbarService.addEntry({
-                name: ( localize(3584, "Status Message")),
+                name: ( localize(3652, "Status Message")),
                 text: message,
                 ariaLabel: message
             }, "status.message", StatusbarAlignment.LEFT, Number.NEGATIVE_INFINITY );
@@ -169,6 +202,6 @@ let NotificationsStatus = class NotificationsStatus extends Disposable {
         this.currentStatusMessage = [item, statusMessageDispose];
     }
 };
-NotificationsStatus = ( __decorate([( __param(1, IStatusbarService)), ( __param(2, INotificationService))], NotificationsStatus));
+NotificationsStatus = ( __decorate([( __param(1, IStatusbarService)), ( __param(2, INotificationService)), ( __param(3, IConfigurationService))], NotificationsStatus));
 
 export { NotificationsStatus };