@codingame/monaco-vscode-api 26.2.2 → 28.0.0

package/vscode/src/vs/workbench/contrib/mcp/common/mcpServer.js

@@ -5,7 +5,7 @@ import { CancellationToken, CancellationTokenSource } from '../../../../base/com
 import { Iterable } from '../../../../base/common/iterator.js';
 import { parseTree, findNodeAtOffset, getNodePath } from '../../../../base/common/json.js';
 import { normalizeDriveLetter } from '../../../../base/common/labels.js';
-import { Disposable, toDisposable, DisposableStore } from '../../../../base/common/lifecycle.js';
+import { Disposable, MutableDisposable, toDisposable, DisposableStore } from '../../../../base/common/lifecycle.js';
 import { LRUCache } from '../../../../base/common/map.js';
 import { Schemas } from '../../../../base/common/network.js';
 import { mapValues } from '../../../../base/common/objects.js';
@@ -16,6 +16,7 @@ import { createURITransformer } from '../../../../base/common/uriTransformer.js'
 import { generateUuid } from '../../../../base/common/uuid.js';
 import { localize } from '../../../../nls.js';
 import { ICommandService } from '../../../../platform/commands/common/commands.service.js';
+import { IDialogService } from '../../../../platform/dialogs/common/dialogs.service.js';
 import { IInstantiationService } from '../../../../platform/instantiation/common/instantiation.js';
 import { ILoggerService } from '../../../../platform/log/common/log.service.js';
 import '../../../../platform/notification/common/notification.js';
@@ -29,14 +30,16 @@ import { IEditorService } from '../../../services/editor/common/editorService.se
 import { IWorkbenchEnvironmentService } from '../../../services/environment/common/environmentService.service.js';
 import { IExtensionService } from '../../../services/extensions/common/extensions.service.js';
 import { IOutputService } from '../../../services/output/common/output.service.js';
+import { chatSessionResourceToId } from '../../chat/common/model/chatUri.js';
 import { mcpActivationEvent } from './mcpConfiguration.js';
 import { McpDevModeServerAttache } from './mcpDevMode.js';
 import { McpIcons, parseAndValidateMcpIcon } from './mcpIcons.js';
 import { IMcpRegistry } from './mcpRegistryTypes.service.js';
+import { IMcpSandboxService } from './mcpSandboxService.service.js';
 import { McpTaskManager } from './mcpTaskManager.js';
 import { McpConnectionState, McpConnectionFailedError, McpServerCacheState, McpServerStaticToolAvailability, extensionMcpCollectionPrefix, UserInteractionRequiredError, McpServerTransportType, McpToolVisibility, mcpPromptReplaceSpecialChars, McpCapability, McpToolName, MpcResponseError, ElicitationKind, McpResourceURI } from './mcpTypes.js';
 import { IMcpSamplingService, IMcpElicitationService } from './mcpTypes.service.js';
-import { MCP } from './modelContextProtocol.js';
+import { MCP } from '../../../../platform/mcp/common/modelContextProtocol.js';
 import { UriTemplate } from './uriTemplate.js';
 import Severity$1 from '../../../../base/common/severity.js';
 import { observableValue, disposableObservableValue } from '../../../../base/common/observableInternal/observables/observableValue.js';
@@ -171,7 +174,7 @@ let McpServer = McpServer_1 = class McpServer extends Disposable {
                         return;
                     }
                 }
-                resolve(fn(handler));
+                resolve(fn(handler, connection));
                 ranOnce = true;
             });
         }));
@@ -215,10 +218,12 @@ let McpServer = McpServer_1 = class McpServer extends Disposable {
         _telemetryService,
         _commandService,
         _instantiationService,
+        _dialogService,
         _notificationService,
         _openerService,
         _samplingService,
         _elicitationService,
+        _mcpSandboxService,
         environmentService
     ) {
         super();
@@ -232,10 +237,12 @@ let McpServer = McpServer_1 = class McpServer extends Disposable {
         this._telemetryService = _telemetryService;
         this._commandService = _commandService;
         this._instantiationService = _instantiationService;
+        this._dialogService = _dialogService;
         this._notificationService = _notificationService;
         this._openerService = _openerService;
         this._samplingService = _samplingService;
         this._elicitationService = _elicitationService;
+        this._mcpSandboxService = _mcpSandboxService;
         this._taskManager = this._register(( new McpTaskManager()));
         this._connectionSequencer = ( new Sequencer());
         this._connection = this._register(disposableObservableValue(this, undefined));
@@ -270,6 +277,10 @@ let McpServer = McpServer_1 = class McpServer extends Disposable {
             return fromServerResult.data?.nonce === currentNonce() ? McpServerCacheState.Live : McpServerCacheState.Outdated;
         });
         this._lastModeDebugged = false;
+        this._isQuietStart = false;
+        this._isSandboxSuggestionDialogVisible = false;
+        this._potentialSandboxBlocks = [];
+        this._potentialSandboxBlockListener = this._register(( new MutableDisposable()));
         this.runningToolCalls = ( new Set());
         this.collection = initialCollection;
         this._fullDefinitions = this._mcpRegistry.getServerDefinition(this.collection, this.definition);
@@ -319,6 +330,10 @@ let McpServer = McpServer_1 = class McpServer extends Disposable {
                 this.resetLiveData();
             }
         }));
+        this._register(autorun(reader => {
+            const cnx = this._connection.read(reader);
+            this._potentialSandboxBlockListener.value = cnx?.onPotentialSandboxBlock(block => this.recordPotentialSandboxBlock(block));
+        }));
         const staticMetadata = derived(reader => {
             const def = this._fullDefinitions.read(reader).server;
             return def && def.cacheNonce !== this._tools.fromCache?.nonce ? def.staticMetadata : undefined;
@@ -402,6 +417,7 @@ let McpServer = McpServer_1 = class McpServer extends Disposable {
                 }
             }
             let connection = this._connection.get();
+            this._isQuietStart = !!errorOnUserInteraction;
             if (connection && McpConnectionState.canBeStarted(connection.state.get().state)) {
                 connection.dispose();
                 connection = undefined;
@@ -445,6 +461,7 @@ let McpServer = McpServer_1 = class McpServer extends Disposable {
                     this.showOutput();
                 }
             }
+            this._potentialSandboxBlocks.length = 0;
             const start = Date.now();
             let state = await connection.start({
                 createMessageRequestHandler: (params, token) => this._samplingService.sample({
@@ -474,9 +491,6 @@ let McpServer = McpServer_1 = class McpServer extends Disposable {
                 state: McpConnectionState.toKindString(state.state),
                 time: Date.now() - start
             });
-            if (state.state === McpConnectionState.Kind.Error) {
-                this.showInteractiveError(connection, state, debug);
-            }
             if (errorOnUserInteraction && state.state === McpConnectionState.Kind.Running) {
                 let disposable;
                 state = await ( new Promise((resolve, reject) => {
@@ -495,6 +509,22 @@ let McpServer = McpServer_1 = class McpServer extends Disposable {
                     });
                 })).finally(() => disposable.dispose());
             }
+            if (state.state === McpConnectionState.Kind.Error) {
+                let disposable;
+                state = await ( new Promise((resolve, reject) => {
+                    disposable = autorun(reader => {
+                        const cnx = this._connection.read(reader);
+                        const state = cnx?.state.read(reader);
+                        if (cnx && state?.state === McpConnectionState.Kind.Error) {
+                            if (!this._isQuietStart) {
+                                this.showInteractiveError(cnx, state, this._lastModeDebugged);
+                            } else {
+                                reject(( new UserInteractionRequiredError("start")));
+                            }
+                        }
+                    });
+                })).finally(() => disposable.dispose());
+            }
             return state;
         }).finally(() => {
             interaction?.participants.set(this.definition.id, {
@@ -503,6 +533,17 @@ let McpServer = McpServer_1 = class McpServer extends Disposable {
         });
     }
     showInteractiveError(cnx, error, debug) {
+        if (cnx.definition.sandboxEnabled) {
+            if (!this.showSandboxConfigSuggestionFromPotentialBlocks(cnx, this._potentialSandboxBlocks)) {
+                this._notificationService.warn(( localize(
+                    10455,
+                    "The MCP server {0} could not be started: {1}",
+                    cnx.definition.label,
+                    error.message
+                )));
+            }
+            return;
+        }
         if (error.code === "ENOENT" && cnx.launchDefinition.type === McpServerTransportType.Stdio) {
             let docsLink;
             switch (cnx.launchDefinition.command) {
@@ -520,42 +561,129 @@ let McpServer = McpServer_1 = class McpServer extends Disposable {
                 break;
             }
             const options = [{
-                label: ( localize(9562, "Show Output")),
+                label: ( localize(10456, "Show Output")),
                 run: () => this.showOutput()
             }];
             if (cnx.definition.devMode?.debug?.type === "debugpy" && debug) {
                 this._notificationService.prompt(Severity$1.Error, ( localize(
-                    9563,
+                    10457,
                     "The command \"{0}\" was not found. You can specify the path to debugpy in the `dev.debug.debugpyPath` option.",
                     cnx.launchDefinition.command,
                     cnx.definition.label
                 )), [...options, {
-                    label: ( localize(9564, "View Docs")),
+                    label: ( localize(10458, "View Docs")),
                     run: () => this._openerService.open(( URI.parse("https://aka.ms/vscode-mcp-install/debugpy")))
                 }]);
                 return;
             }
             if (docsLink) {
                 options.push({
-                    label: ( localize(9565, "Install {0}", cnx.launchDefinition.command)),
+                    label: ( localize(10459, "Install {0}", cnx.launchDefinition.command)),
                     run: () => this._openerService.open(( URI.parse(docsLink)))
                 });
             }
             this._notificationService.prompt(Severity$1.Error, ( localize(
-                9566,
+                10460,
                 "The command \"{0}\" needed to run {1} was not found.",
                 cnx.launchDefinition.command,
                 cnx.definition.label
             )), options);
         } else {
             this._notificationService.warn(( localize(
-                9567,
+                10455,
                 "The MCP server {0} could not be started: {1}",
                 cnx.definition.label,
                 error.message
             )));
         }
     }
+    showSandboxConfigSuggestionFromPotentialBlocks(cnx, potentialBlocks) {
+        if (!cnx.definition.sandboxEnabled || !potentialBlocks.length || this._isSandboxSuggestionDialogVisible) {
+            return false;
+        }
+        if (this._isQuietStart) {
+            throw ( new UserInteractionRequiredError("sandbox-suggestion"));
+        }
+        const existingSandboxConfig = this._fullDefinitions.get().collection?.sandbox;
+        const suggestion = this._mcpSandboxService.getSandboxConfigSuggestionMessage(cnx.definition.label, potentialBlocks, existingSandboxConfig);
+        if (!suggestion) {
+            this._removePotentialSandboxBlocks(potentialBlocks);
+            return false;
+        }
+        this._confirmAndApplySandboxConfigSuggestion(cnx, potentialBlocks, suggestion);
+        return true;
+    }
+    _confirmAndApplySandboxConfigSuggestion(cnx, potentialBlocks, suggestion) {
+        const mcpResource = cnx.definition.presentation?.origin?.uri ?? this.collection.presentation?.origin;
+        const configTarget = this._fullDefinitions.get().collection?.configTarget;
+        this._isSandboxSuggestionDialogVisible = true;
+        void this._dialogService.confirm({
+            type: "warning",
+            message: ( localize(
+                10461,
+                "Update sandbox configuration in mcp.json for {0}?",
+                cnx.definition.label
+            )),
+            detail: suggestion.message,
+            primaryButton: ( localize(10462, "Yes")),
+            cancelButton: ( localize(10463, "No"))
+        }).then(async result => {
+            if (!result.confirmed) {
+                return;
+            }
+            if (!mcpResource || configTarget === undefined) {
+                this._notificationService.warn(( localize(
+                    10464,
+                    "Couldn't determine where to update sandbox configuration for {0}.",
+                    cnx.definition.label
+                )));
+                return;
+            }
+            try {
+                const updated = await this._mcpSandboxService.applySandboxConfigSuggestion(
+                    cnx.definition,
+                    mcpResource,
+                    configTarget,
+                    potentialBlocks,
+                    suggestion.sandboxConfig
+                );
+                if (updated) {
+                    this._removePotentialSandboxBlocks(potentialBlocks);
+                    this._notificationService.info(( localize(
+                        10465,
+                        "Updated sandbox configuration for {0} in mcp.json. Restart server.",
+                        cnx.definition.label
+                    )));
+                }
+            } catch (e) {
+                this._notificationService.error(( localize(
+                    10466,
+                    "Failed to update sandbox configuration for {0}: {1}",
+                    cnx.definition.label,
+                    e instanceof Error ? e.message : String(e)
+                )));
+            }
+        }).finally(() => {
+            this._isSandboxSuggestionDialogVisible = false;
+        });
+    }
+    recordPotentialSandboxBlock(block) {
+        this._potentialSandboxBlocks.push(block);
+        if (this._potentialSandboxBlocks.length > 200) {
+            this._potentialSandboxBlocks.splice(0, this._potentialSandboxBlocks.length - 200);
+        }
+        const connection = this._connection.get();
+        if (connection?.state.get().state === McpConnectionState.Kind.Running) {
+            this.showSandboxConfigSuggestionFromPotentialBlocks(connection, this._potentialSandboxBlocks);
+        }
+    }
+    _removePotentialSandboxBlocks(blocks) {
+        if (!blocks.length || !this._potentialSandboxBlocks.length) {
+            return;
+        }
+        const toRemove = ( new Set(blocks));
+        this._potentialSandboxBlocks = this._potentialSandboxBlocks.filter(block => !( toRemove.has(block)));
+    }
     stop() {
         return this._connection.get()?.stop() || Promise.resolve();
     }
@@ -607,6 +735,12 @@ let McpServer = McpServer_1 = class McpServer extends Disposable {
             );
             tool.name = tool.name.replace(toolInvalidCharRe, "_");
         }
+        if (tool.inputSchema && !tool.inputSchema.properties) {
+            tool.inputSchema = {
+                ...tool.inputSchema,
+                properties: {}
+            };
+        }
         let diagnostics = [];
         const toolJson = JSON.stringify(tool.inputSchema);
         try {
@@ -632,7 +766,7 @@ let McpServer = McpServer_1 = class McpServer extends Disposable {
         const validated = [];
         for (const [i, result] of validations.entries()) {
             if ("error" in result) {
-                error += ( localize(9568, "Tool `{0}` has invalid JSON parameters:", tools[i].name)) + "\n";
+                error += ( localize(10467, "Tool `{0}` has invalid JSON parameters:", tools[i].name)) + "\n";
                 for (const message of result.error) {
                     error += `\t- ${message}\n`;
                 }
@@ -762,7 +896,7 @@ let McpServer = McpServer_1 = class McpServer extends Disposable {
         });
     }
 };
-McpServer = McpServer_1 = ( __decorate([( __param(6, IMcpRegistry)), ( __param(7, IWorkspaceContextService)), ( __param(8, IExtensionService)), ( __param(9, ILoggerService)), ( __param(10, IOutputService)), ( __param(11, ITelemetryService)), ( __param(12, ICommandService)), ( __param(13, IInstantiationService)), ( __param(14, INotificationService)), ( __param(15, IOpenerService)), ( __param(16, IMcpSamplingService)), ( __param(17, IMcpElicitationService)), ( __param(18, IWorkbenchEnvironmentService))], McpServer));
+McpServer = McpServer_1 = ( __decorate([( __param(6, IMcpRegistry)), ( __param(7, IWorkspaceContextService)), ( __param(8, IExtensionService)), ( __param(9, ILoggerService)), ( __param(10, IOutputService)), ( __param(11, ITelemetryService)), ( __param(12, ICommandService)), ( __param(13, IInstantiationService)), ( __param(14, IDialogService)), ( __param(15, INotificationService)), ( __param(16, IOpenerService)), ( __param(17, IMcpSamplingService)), ( __param(18, IMcpElicitationService)), ( __param(19, IMcpSandboxService)), ( __param(20, IWorkbenchEnvironmentService))], McpServer));
 class McpPrompt {
     constructor(_server, _definition) {
         this._server = _server;
@@ -893,8 +1027,8 @@ let McpTool = class McpTool {
             const meta = {
                 progressToken
             };
-            if (context?.chatSessionId) {
-                meta["vscode.conversationId"] = context.chatSessionId;
+            if (context?.chatSessionResource) {
+                meta["vscode.conversationId"] = chatSessionResourceToId(context.chatSessionResource);
             }
             if (context?.chatRequestId) {
                 meta["vscode.requestId"] = context.chatRequestId;
@@ -908,7 +1042,9 @@ let McpTool = class McpTool {
                     arguments: params,
                     task: shouldUseTask ? {} : undefined,
                     _meta: meta
-                }, token);
+                }, token, progress ? message => progress.report({
+                    message
+                }) : undefined);
                 await this._server.awaitToolRefresh();
                 return result;
             } catch (err) {
@@ -957,7 +1093,7 @@ function warnInvalidTools(instaService, serverName, errorText) {
         notificationService.notify({
             severity: Severity$1.Warning,
             message: ( localize(
-                9569,
+                10468,
                 "MCP server `{0}` has tools with invalid parameters which will be omitted.",
                 serverName
             )),
@@ -967,7 +1103,7 @@ function warnInvalidTools(instaService, serverName, errorText) {
                     enabled: true,
                     id: "mcpBadSchema.show",
                     tooltip: "",
-                    label: ( localize(9570, "Show")),
+                    label: ( localize(10469, "Show")),
                     run: () => {
                         editorService.openEditor({
                             resource: undefined,

package/vscode/src/vs/workbench/contrib/mcp/common/mcpTaskManager.js

@@ -6,7 +6,7 @@ import { Emitter } from '../../../../base/common/event.js';
 import { Disposable, DisposableMap, DisposableStore, toDisposable } from '../../../../base/common/lifecycle.js';
 import { generateUuid } from '../../../../base/common/uuid.js';
 import { McpError } from './mcpTypes.js';
-import { MCP } from './modelContextProtocol.js';
+import { MCP } from '../../../../platform/mcp/common/modelContextProtocol.js';
 
 class McpTaskManager extends Disposable {
     constructor() {

package/vscode/src/vs/workbench/contrib/mcp/common/mcpTypes.d.ts

@@ -1,4 +1,5 @@
 import { CancellationToken } from "../../../../base/common/cancellation.js";
+import { Event } from "../../../../base/common/event.js";
 import { IMarkdownString } from "../../../../base/common/htmlContent.js";
 import { Disposable, IDisposable } from "../../../../base/common/lifecycle.js";
 import { IObservable, ObservableMap } from "../../../../base/common/observable.js";
@@ -10,10 +11,10 @@ import { RawContextKey } from "../../../../platform/contextkey/common/contextkey
 import { IEditorOptions } from "../../../../platform/editor/common/editor.js";
 import { ExtensionIdentifier } from "../../../../platform/extensions/common/extensions.js";
 import { IGalleryMcpServer, IInstallableMcpServer, IGalleryMcpServerConfiguration } from "../../../../platform/mcp/common/mcpManagement.js";
-import { IMcpDevModeConfig, IMcpServerConfiguration } from "../../../../platform/mcp/common/mcpPlatformTypes.js";
+import { IMcpDevModeConfig, IMcpSandboxConfiguration, IMcpServerConfiguration } from "../../../../platform/mcp/common/mcpPlatformTypes.js";
 import { StorageScope } from "../../../../platform/storage/common/storage.js";
 import { IWorkspaceFolder, IWorkspaceFolderData } from "../../../../platform/workspace/common/workspace.js";
-import { IWorkbenchLocalMcpServer } from "@codingame/monaco-vscode-mcp-service-override/vscode/vs/workbench/services/mcp/common/mcpWorkbenchManagementService";
+import { IWorkbenchLocalMcpServer } from "../../../services/mcp/common/mcpWorkbenchManagementService.js";
 import { ToolProgress } from "../../chat/common/tools/languageModelToolsService.js";
 import { McpServerRequestHandler } from "@codingame/monaco-vscode-mcp-service-override/vscode/vs/workbench/contrib/mcp/common/mcpServerRequestHandler";
 import { IMcpWorkbenchService } from "./mcpTypes.service.js";
@@ -43,6 +44,8 @@ export interface McpCollectionDefinition {
     readonly scope: StorageScope;
     /** Configuration target where configuration related to this server should be stored. */
     readonly configTarget: ConfigurationTarget;
+    /** Root-level sandbox settings from the mcp config file. */
+    readonly sandbox?: IMcpSandboxConfiguration;
     /** Resolves a server definition. If present, always called before a server starts. */
     resolveServerLanch?(definition: McpServerDefinition): Promise<McpServerLaunch | undefined>;
     /** For lazy-loaded collections only: */
@@ -67,6 +70,7 @@ export declare enum McpCollectionSortOrder {
     Workspace = 100,
     User = 200,
     Extension = 300,
+    Plugin = 350,
     Filesystem = 400,
     RemoteBoost = -50
 }
@@ -99,6 +103,8 @@ export interface McpServerDefinition {
     readonly devMode?: IMcpDevModeConfig;
     /** Static description of server tools/data, used to hydrate the cache. */
     readonly staticMetadata?: McpServerStaticMetadata;
+    /** Indicates if the sandbox is enabled for this server. */
+    readonly sandboxEnabled?: boolean;
     readonly presentation?: {
         /** Sort order of the definition. */
         readonly order?: number;
@@ -129,6 +135,7 @@ export declare namespace McpServerDefinition {
         readonly launch: McpServerLaunch.Serialized;
         readonly variableReplacement?: McpServerDefinitionVariableReplacement.Serialized;
         readonly staticMetadata?: McpServerStaticMetadata;
+        readonly sandboxEnabled?: boolean;
     }
     function toSerialized(def: McpServerDefinition): McpServerDefinition.Serialized;
     function fromSerialized(def: McpServerDefinition.Serialized): McpServerDefinition;
@@ -322,7 +329,7 @@ export declare const mcpPromptPrefix: (definition: McpDefinitionReference) => st
 export interface IMcpPromptMessage extends MCP.PromptMessage {
 }
 export interface IMcpToolCallContext {
-    chatSessionId?: string;
+    chatSessionResource: URI | undefined;
     chatRequestId?: string;
 }
 /**
@@ -385,6 +392,7 @@ export interface McpServerTransportStdio {
     readonly args: readonly string[];
     readonly env: Record<string, string | number | null>;
     readonly envFile: string | undefined;
+    readonly sandbox: IMcpSandboxConfiguration | undefined;
 }
 export interface McpServerTransportHTTPAuthentication {
     /**
@@ -427,6 +435,7 @@ export declare namespace McpServerLaunch {
         args: readonly string[];
         env: Record<string, string | number | null>;
         envFile: string | undefined;
+        sandbox: IMcpSandboxConfiguration | undefined;
     };
     function toSerialized(launch: McpServerLaunch): McpServerLaunch.Serialized;
     function fromSerialized(launch: McpServerLaunch.Serialized): McpServerLaunch;
@@ -437,10 +446,17 @@ export declare namespace McpServerLaunch {
  * stopped, and restarted. Once started and in a running state, it will
  * eventually build a {@link IMcpServerConnection.handler}.
  */
+export interface IMcpPotentialSandboxBlock {
+    readonly kind: "network" | "filesystem";
+    readonly message: string;
+    readonly host?: string;
+    readonly path?: string;
+}
 export interface IMcpServerConnection extends IDisposable {
     readonly definition: McpServerDefinition;
     readonly state: IObservable<McpConnectionState>;
     readonly handler: IObservable<McpServerRequestHandler | undefined>;
+    readonly onPotentialSandboxBlock: Event<IMcpPotentialSandboxBlock>;
     /**
      * Resolved launch definition. Might not match the `definition.launch` due to
      * resolution logic in extension-provided MCPs.

package/vscode/src/vs/workbench/contrib/mcp/common/mcpTypes.js

@@ -1,10 +1,10 @@
 
 import { __decorate, __param } from '../../../../../../../external/tslib/tslib.es6.js';
-import { equals } from '../../../../base/common/arrays.js';
+import { equals as equals$1 } from '../../../../base/common/arrays.js';
 import { assertNever } from '../../../../base/common/assert.js';
 import { encodeHex, VSBuffer, decodeHex } from '../../../../base/common/buffer.js';
 import { Disposable } from '../../../../base/common/lifecycle.js';
-import { equals as equals$1 } from '../../../../base/common/objects.js';
+import { equals } from '../../../../base/common/objects.js';
 import '../../../../base/common/observableInternal/index.js';
 import { URI } from '../../../../base/common/uri.js';
 import { localize } from '../../../../nls.js';
@@ -12,7 +12,7 @@ import { RawContextKey } from '../../../../platform/contextkey/common/contextkey
 import { ExtensionIdentifier } from '../../../../platform/extensions/common/extensions.js';
 import { McpGalleryManifestStatus } from '../../../../platform/mcp/common/mcpGalleryManifest.js';
 import { IMcpWorkbenchService } from './mcpTypes.service.js';
-import { MCP } from './modelContextProtocol.js';
+import { MCP } from '../../../../platform/mcp/common/modelContextProtocol.js';
 import { ObservableMap } from '../../../../base/common/observableInternal/map.js';
 
 const extensionMcpCollectionPrefix = "ext.";
@@ -25,15 +25,16 @@ var McpCollectionSortOrder;
     McpCollectionSortOrder[McpCollectionSortOrder["Workspace"] = 100] = "Workspace";
     McpCollectionSortOrder[McpCollectionSortOrder["User"] = 200] = "User";
     McpCollectionSortOrder[McpCollectionSortOrder["Extension"] = 300] = "Extension";
+    McpCollectionSortOrder[McpCollectionSortOrder["Plugin"] = 350] = "Plugin";
     McpCollectionSortOrder[McpCollectionSortOrder["Filesystem"] = 400] = "Filesystem";
     McpCollectionSortOrder[McpCollectionSortOrder["RemoteBoost"] = -50] = "RemoteBoost";
 })(McpCollectionSortOrder || (McpCollectionSortOrder = {}));
 var McpCollectionDefinition;
 (function(McpCollectionDefinition) {
-    function equals(a, b) {
-        return a.id === b.id && a.remoteAuthority === b.remoteAuthority && a.label === b.label && a.trustBehavior === b.trustBehavior;
+    function equals$1(a, b) {
+        return a.id === b.id && a.remoteAuthority === b.remoteAuthority && a.label === b.label && a.trustBehavior === b.trustBehavior && equals(a.sandbox, b.sandbox);
     }
-    McpCollectionDefinition.equals = equals;
+    McpCollectionDefinition.equals = equals$1;
 })(McpCollectionDefinition || (McpCollectionDefinition = {}));
 var McpServerStaticToolAvailability;
 (function(McpServerStaticToolAvailability) {
@@ -53,12 +54,13 @@ var McpServerDefinition;
             cacheNonce: def.cacheNonce,
             staticMetadata: def.staticMetadata,
             launch: McpServerLaunch.fromSerialized(def.launch),
+            sandboxEnabled: def.sandboxEnabled,
             variableReplacement: def.variableReplacement ? McpServerDefinitionVariableReplacement.fromSerialized(def.variableReplacement) : undefined
         };
     }
     McpServerDefinition.fromSerialized = fromSerialized;
     function equals$2(a, b) {
-        return a.id === b.id && a.label === b.label && a.cacheNonce === b.cacheNonce && equals(a.roots, b.roots, (a, b) => ( a.toString()) === ( b.toString())) && equals$1(a.launch, b.launch) && equals$1(a.presentation, b.presentation) && equals$1(a.variableReplacement, b.variableReplacement) && equals$1(a.devMode, b.devMode);
+        return a.id === b.id && a.label === b.label && a.cacheNonce === b.cacheNonce && equals$1(a.roots, b.roots, (a, b) => ( a.toString()) === ( b.toString())) && equals(a.launch, b.launch) && equals(a.presentation, b.presentation) && equals(a.variableReplacement, b.variableReplacement) && equals(a.devMode, b.devMode) && a.sandboxEnabled === b.sandboxEnabled;
     }
     McpServerDefinition.equals = equals$2;
 })(McpServerDefinition || (McpServerDefinition = {}));
@@ -156,7 +158,8 @@ var McpServerLaunch;
                 command: launch.command,
                 args: launch.args,
                 env: launch.env,
-                envFile: launch.envFile
+                envFile: launch.envFile,
+                sandbox: launch.sandbox
             };
         }
     }
@@ -179,13 +182,13 @@ var McpConnectionState;
     McpConnectionState.toString = s => {
         switch (s.state) {
         case Kind.Stopped:
-            return localize(9574, "Stopped");
+            return localize(10473, "Stopped");
         case Kind.Starting:
-            return localize(9575, "Starting");
+            return localize(10474, "Starting");
         case Kind.Running:
-            return localize(9576, "Running");
+            return localize(10475, "Running");
         case Kind.Error:
-            return localize(9577, "Error {0}", s.message);
+            return localize(10476, "Error {0}", s.message);
         default:
             assertNever();
         }

package/vscode/src/vs/workbench/contrib/mcp/common/mcpTypes.service.d.ts

@@ -5,7 +5,7 @@ import { IObservable } from "../../../../base/common/observable.js";
 import { IIterativePager } from "../../../../base/common/paging.js";
 import { URI } from "../../../../base/common/uri.js";
 import { IQueryOptions } from "../../../../platform/mcp/common/mcpManagement.js";
-import { IWorkbenchLocalMcpServer, IWorkbencMcpServerInstallOptions } from "@codingame/monaco-vscode-mcp-service-override/vscode/vs/workbench/services/mcp/common/mcpWorkbenchManagementService";
+import { IWorkbenchLocalMcpServer, IWorkbencMcpServerInstallOptions } from "../../../services/mcp/common/mcpWorkbenchManagementService.js";
 import { IMcpServerSamplingConfiguration } from "./mcpConfiguration.js";
 import { IMcpServer, LazyCollectionState, McpCollectionDefinition, IAutostartResult, type IMcpConfigPath, type IMcpServerEditorOptions, type IWorkbenchMcpServer, type ISamplingOptions, type ISamplingResult, type ElicitResult, type IMcpToolCallContext } from "./mcpTypes.js";
 import { MCP } from "./modelContextProtocol.js";

package/vscode/src/vs/workbench/contrib/mcp/common/mcpTypesUtils.js

@@ -53,6 +53,7 @@ async function startServerAndWaitForLiveTools(server, opts, token) {
             }
         }));
     }));
+    store.dispose();
     if (ok) {
         await timeout(0);
     }