@codeyam/codeyam-cli 0.1.0-staging.d0ad4ae → 0.1.0-staging.d3e886e

package/background/src/lib/virtualized/project/writeScenarioComponents.js

@@ -596,10 +596,38 @@ function addMockToContent(fileContent, importedExport, fileAnalyses, rootAnalysi
     }
     // Check if we have multiple calls with different variable names
     // This requires generating separate mock functions for each call site
-    const hasMultipleCallsWithVariables = importedExport.calls &&
-        importedExport.calls.length > 1 &&
+    //
+    // IMPORTANT: calls array may contain BOTH base hook calls (e.g., "useFetcher<Type>()")
+    // AND method chain usages (e.g., "useFetcher().functionCallReturnValue.submit(...)").
+    // We only want to count base hook calls for the length comparison with callVariableNames.
+    // A "base call" is one that ends with "()" possibly preceded by a type annotation,
+    // without any subsequent method chains like ".functionCallReturnValue" or ".submit(...)".
+    const baseHookCalls = importedExport.calls?.filter((call) => {
+        // Base hook calls match patterns like:
+        // - "useFetcher()"
+        // - "useFetcher<Type>()"
+        // - "useFetcher<{ complex: Type }>()"
+        // They end with "()" and don't have method chains after the call.
+        // Method chains contain ".functionCallReturnValue" or have property access after "()".
+        return (call.endsWith('()') &&
+            !call.includes('.functionCallReturnValue') &&
+            // Also exclude method chains like "hook().something" or "hook().method()"
+            !call.match(/\(\)\.[a-zA-Z]/));
+    });
+    // Determine if we can generate unique mock functions for multiple variables.
+    // We need:
+    // 1. Multiple variable names (callVariableNames.length > 1)
+    // 2. Base hook calls to match them (baseHookCalls.length > 0)
+    // Note: We use min(baseHookCalls.length, callVariableNames.length) for iteration
+    // to handle cases where data might be slightly out of sync (stale entries).
+    const hasMultipleCallsWithVariables = baseHookCalls &&
+        baseHookCalls.length > 1 &&
         importedExport.callVariableNames &&
-        importedExport.callVariableNames.length === importedExport.calls.length;
+        importedExport.callVariableNames.length > 1 &&
+        // Only proceed if we have at least as many base calls as variable names,
+        // OR they're close enough (within 1) to handle minor sync issues
+        Math.abs(baseHookCalls.length - importedExport.callVariableNames.length) <=
+            1;
     let mockCode;
     const variableMockCodes = [];
     if (hasMultipleCallsWithVariables) {
@@ -617,7 +645,10 @@ function addMockToContent(fileContent, importedExport, fileAnalyses, rootAnalysi
             : [];
         // Track variable name occurrences for unique function naming
         const variableNameCounts = {};
-        for (let i = 0; i < importedExport.calls.length; i++) {
+        // Use the minimum of both array lengths to handle slight mismatches
+        // (e.g., stale data from previous analysis runs)
+        const iterationLimit = Math.min(baseHookCalls.length, importedExport.callVariableNames.length);
+        for (let i = 0; i < iterationLimit; i++) {
             const variableName = importedExport.callVariableNames[i];
             if (!variableName)
                 continue;
@@ -632,9 +663,9 @@ function addMockToContent(fileContent, importedExport, fileAnalyses, rootAnalysi
             // Compute unique mock function name for call site replacement
             // e.g., useFetcher_entityDiffFetcher, useFetcher_reportFetcher
             const mockFunctionName = `${importedExport.name}_${safeFunctionName}`;
-            // Use the call signature from importedExport.calls[i] as the data key
+            // Use the call signature from baseHookCalls[i] as the data key
             // This matches what's stored in dataForMocks
-            const callSignature = importedExport.calls[i];
+            const callSignature = baseHookCalls[i];
             // Generate mock code using the call signature directly
             // This prevents "symbol already declared" errors when multiple calls exist
             // Check if this is a package import that won't have scenario copies
@@ -654,8 +685,17 @@ function addMockToContent(fileContent, importedExport, fileAnalyses, rootAnalysi
                 // e.g., useFetcher() -> useFetcher_reportFetcher()
                 // Escape special regex characters in the call signature
                 const escapedCallSignature = callSignature.replace(/[.*+?^${}()|[\]\\]/g, '\\$&');
-                // Create regex that matches the call (with optional whitespace variations)
-                const callRegex = new RegExp(escapedCallSignature.replace(/\s+/g, '\\s*'), 'g');
+                // Create regex that matches the call (with optional whitespace variations).
+                // TypeScript formatters commonly break type parameters across lines, e.g.:
+                //   useLoaderData<
+                //     typeof loader
+                //   >()
+                // So we allow optional whitespace around < and > delimiters, not just
+                // where whitespace already exists in the call signature string.
+                const callRegex = new RegExp(escapedCallSignature
+                    .replace(/\s+/g, '\\s*')
+                    .replace(/</g, '\\s*<\\s*')
+                    .replace(/>/g, '\\s*>\\s*'), 'gs');
                 fileContent = fileContent.replace(callRegex, `${mockFunctionName}()`);
             }
         }
@@ -673,15 +713,28 @@ function addMockToContent(fileContent, importedExport, fileAnalyses, rootAnalysi
             // For single variable assignments, use the call signature directly from dataForMocks
             const dataForMocks = rootAnalysis.metadata?.scenariosDataStructure?.dataForMocks;
             // Find matching call signature key in dataForMocks
+            // IMPORTANT: First try exact match with type parameters (e.g., "useLoaderData<LoaderData>()")
+            // to avoid picking the wrong variant (e.g., "useLoaderData<typeof loader>()" which may
+            // have different properties). Fall back to base name matching only if exact match fails.
             const hookBaseName = importedExport.name.split(/[<(]/)[0];
-            const callSignatureKey = dataForMocks
-                ? Object.keys(dataForMocks).find((key) => {
-                    // Split on ., <, or ( to get the true base name
-                    // This handles both "useFlags()" -> "useFlags" and "trpc.useUtils()" -> "trpc"
-                    const keyBaseName = key.split(/[.<(]/)[0];
-                    return keyBaseName === hookBaseName;
-                })
-                : undefined;
+            const expectedKey = importedExport.calls?.[0];
+            let callSignatureKey;
+            if (dataForMocks) {
+                const keys = Object.keys(dataForMocks);
+                // First try exact match with the expected call signature
+                if (expectedKey && keys.includes(expectedKey)) {
+                    callSignatureKey = expectedKey;
+                }
+                else {
+                    // Fall back to base name matching
+                    callSignatureKey = keys.find((key) => {
+                        // Split on ., <, or ( to get the true base name
+                        // This handles both "useFlags()" -> "useFlags" and "trpc.useUtils()" -> "trpc"
+                        const keyBaseName = key.split(/[.<(]/)[0];
+                        return keyBaseName === hookBaseName;
+                    });
+                }
+            }
             // Use the call signature if found, otherwise construct it
             const dataKey = callSignatureKey ??
                 importedExport.calls?.[0] ??
@@ -710,18 +763,34 @@ function addMockToContent(fileContent, importedExport, fileAnalyses, rootAnalysi
             // IMPORTANT: We inline scenarios().data() inside the function rather than
             // storing in a const - see comment in constructMockCode.ts for why.
             if (!mockCode) {
-                mockCode = `function ${importedExport.name}(...args) {
-  return scenarios().data()?.["${dataKey}"];
+                mockCode = `// PATCHED: memoize to return stable reference (prevents infinite useEffect re-triggers)
+const _${importedExport.name}Ref = {
+  current: null,
+};
+function ${importedExport.name}(...args) {
+  if (!_${importedExport.name}Ref.current) {
+    _${importedExport.name}Ref.current = scenarios().data()?.["${dataKey}"];
+  }
+  return _${importedExport.name}Ref.current;
 }`;
             }
         }
         else {
             // Helper to find matching call signature key from dataForMocks
+            // IMPORTANT: First try exact match with type parameters (e.g., "useLoaderData<LoaderData>()")
+            // to avoid picking the wrong variant. Fall back to base name matching only if needed.
             const hookBaseName = importedExport.name.split(/[<(]/)[0];
+            const expectedKey = importedExport.calls?.[0];
             const findMatchingKey = (dataForMocks) => {
                 if (!dataForMocks)
                     return undefined;
-                return Object.keys(dataForMocks).find((key) => {
+                const keys = Object.keys(dataForMocks);
+                // First try exact match with the expected call signature
+                if (expectedKey && keys.includes(expectedKey)) {
+                    return expectedKey;
+                }
+                // Fall back to base name matching
+                return keys.find((key) => {
                     // Split on ., <, or ( to get the true base name
                     // This handles both "useFlags()" -> "useFlags" and "trpc.useUtils()" -> "trpc"
                     const keyBaseName = key.split(/[.<(]/)[0];
@@ -765,8 +834,15 @@ function addMockToContent(fileContent, importedExport, fileAnalyses, rootAnalysi
             // IMPORTANT: We inline scenarios().data() inside the function rather than
             // storing in a const - see comment in constructMockCode.ts for why.
             if (!mockCode && dataKey) {
-                mockCode = `function ${importedExport.name}(...args) {
-  return scenarios().data()?.["${dataKey}"];
+                mockCode = `// PATCHED: memoize to return stable reference (prevents infinite useEffect re-triggers)
+const _${importedExport.name}Ref = {
+  current: null,
+};
+function ${importedExport.name}(...args) {
+  if (!_${importedExport.name}Ref.current) {
+    _${importedExport.name}Ref.current = scenarios().data()?.["${dataKey}"];
+  }
+  return _${importedExport.name}Ref.current;
 }`;
             }
         }
@@ -816,6 +892,14 @@ function addMockToContent(fileContent, importedExport, fileAnalyses, rootAnalysi
             else {
                 fileContent = fileContent.replace(importRegExp, '$1$2');
             }
+            // Also handle namespace imports (import * as foo from '...')
+            // These need to be renamed to foo__cyOriginal when the mock code spreads from the original.
+            // Note: We match any path (not just escapedImportPath) because the import path may have
+            // been rewritten by transitive import handling before this code runs.
+            if (shouldRenameToOriginal) {
+                const namespaceImportRegExp = new RegExp(`(import\\s+\\*\\s+as\\s+)${escapeRegExp(firstPart)}(\\s+from\\s+['"][^'"]*['"])`, 'm');
+                fileContent = fileContent.replace(namespaceImportRegExp, `$1${firstPart}__cyOriginal$2`);
+            }
             // Remove empty imports entirely to avoid partial commenting issues with multiline imports
             // This handles both single-line and multiline empty imports
             fileContent = fileContent.replace(/import\s*\{\s*\}\s*from\s+['"][^'"]*['"];?\s*\n?/g, '');
@@ -1174,9 +1258,12 @@ export default async function writeScenarioComponents({ project, file, entity, r
         fileContentLength: fileContent.length,
     });
     let importedExportIndex = 0;
+    const loopStartTime = Date.now();
+    console.log(`[WriteScenario] Starting import loop for ${entity.name}: ${sortedImportedExports.length} imports`);
     for (const importedExport of sortedImportedExports) {
         importedExportIndex++;
         if (importedExportIndex % 5 === 0 || importedExportIndex === 1) {
+            console.log(`[WriteScenario] ${entity.name} import ${importedExportIndex}/${sortedImportedExports.length}: ${importedExport.name} elapsed=${Date.now() - loopStartTime}ms`);
             debugLog(`Processing importedExport ${importedExportIndex}/${sortedImportedExports.length}`, {
                 name: importedExport.name,
                 filePath: importedExport.filePath,
@@ -1309,6 +1396,8 @@ export default async function writeScenarioComponents({ project, file, entity, r
                         // e.g., if file has `export default X` but parent does `import { X } from '...'`
                         const needsNamedReExport = importedExport.resolvedIsDefault === true &&
                             importedExport.isDefault === false;
+                        console.log(`[WriteScenario] RECURSE START: ${entity.name} -> ${importedExportEntity.name}`);
+                        const recurseStartTime = Date.now();
                         debugLog(`Recursing into writeScenarioComponents for ${importedExportEntity.name}`, {
                             entityName: importedExportEntity.name,
                             filePath: fileNotMocked.path,
@@ -1331,7 +1420,8 @@ export default async function writeScenarioComponents({ project, file, entity, r
                             exportAsNamed: needsNamedReExport
                                 ? importedExport.name
                                 : undefined,
-                        }), 60000);
+                        }), 180000);
+                        console.log(`[WriteScenario] RECURSE END: ${entity.name} -> ${importedExportEntity.name} took ${Date.now() - recurseStartTime}ms`);
                         debugLog(`Completed recursive writeScenarioComponents for ${importedExportEntity.name}`);
                         writtenScenarioComponents = updatedWrittenScenarioComponents;
                         scenarioComponentPaths.push(...newScenarioComponentPaths);
@@ -1593,6 +1683,9 @@ ${exportKeyword}const ${functionName} = new Proxy(() => scenarios().data()?.["${
             }
         }
     }
+    // Track post-import-loop timing
+    const postLoopStartTime = Date.now();
+    console.log(`[WriteScenario] POST-LOOP START: ${entity.name}`);
     // Collect universal mocks BEFORE processing nodeModuleImports
     // This is needed to check if a node module import is handled by a universal mock
     const universalMocks = project.metadata?.universalMocks ?? [];
@@ -1626,6 +1719,7 @@ ${exportKeyword}const ${functionName} = new Proxy(() => scenarios().data()?.["${
         const importRegex = new RegExp(`(import\\s+(?:\\{[^}]*\\}|\\*\\s+as\\s+\\w+|\\w+)\\s+from\\s+)['"]${originalPath.replace(/[.*+?^${}()|[\]\\]/g, '\\$&')}['"]`, 'g');
         fileContent = fileContent.replace(importRegex, `$1'${mockFileRelativePath}'`);
     }
+    console.log(`[WriteScenario] POST-LOOP ${entity.name}: node+universal mocks took ${Date.now() - postLoopStartTime}ms`);
     if (rootAnalysis.entitySha === entity.sha &&
         entity.metadata?.notExported &&
         entity.name !== 'default') {
@@ -1685,6 +1779,7 @@ ${exportKeyword}const ${functionName} = new Proxy(() => scenarios().data()?.["${
     debugLog('Starting rewriteRelativeModuleImports');
     fileContent = rewriteRelativeModuleImports(fileContent, `${PROJECT_RELATIVE_PATH}/${file.path}`, scenarioComponentPath);
     debugLog('Completed rewriteRelativeModuleImports');
+    console.log(`[WriteScenario] POST-LOOP ${entity.name}: transformations took ${Date.now() - postLoopStartTime}ms`);
     /**
      * Recursively process a file's imports to create transitive copies with server-only stripped.
      * This handles chains of arbitrary depth: A -> B -> C -> D where each needs server-only removed.
@@ -1698,12 +1793,14 @@ ${exportKeyword}const ${functionName} = new Proxy(() => scenarios().data()?.["${
      */
     async function processTransitiveImportsRecursively(content, sourceFilePath, targetFilePath, visitedPaths = new Set(), depth = 0, startTime = Date.now()) {
         // Global timeout for entire transitive processing
-        const GLOBAL_TIMEOUT_MS = 60000; // 1 minute max for all transitive processing
+        const GLOBAL_TIMEOUT_MS = 180000; // 3 minutes max for all transitive processing (complex components need more time)
         const elapsed = Date.now() - startTime;
         if (elapsed > GLOBAL_TIMEOUT_MS) {
             throw new Error(`processTransitiveImportsRecursively exceeded ${GLOBAL_TIMEOUT_MS}ms (elapsed: ${elapsed}ms) at depth=${depth} for ${sourceFilePath}`);
         }
         const importPaths = extractInternalImportPaths(content);
+        // Always log to help debug timeout issues
+        console.log(`[TransitiveImports] depth=${depth} file=${path.basename(sourceFilePath)} imports=${importPaths.length} visited=${visitedPaths.size} elapsed=${Date.now() - startTime}ms`);
         debugLog(`processTransitiveImportsRecursively depth=${depth}`, {
             sourceFilePath,
             importCount: importPaths.length,
@@ -1740,8 +1837,10 @@ ${exportKeyword}const ${functionName} = new Proxy(() => scenarios().data()?.["${
             const basePath = safeFolder(importFile.path.split('/').slice(0, -1).join('/'));
             const extension = importFile.name.split('.').pop();
             const isIndex = isIndexPath(importFile.path);
-            const pathHash = safeFileName(importFile.path);
-            const transitiveFilePath = `${PROJECT_RELATIVE_PATH}/${basePath}/${pathHash}_${isIndex ? 'index_' : ''}transitive_${safeFileName(scenario.name)}.${extension}`;
+            // Limit pathHash length to prevent ENAMETOOLONG errors on macOS (255 char limit)
+            const pathHash = safeFileName(importFile.path, { maxLength: 80 });
+            const scenarioSlug = safeFileName(scenario.name, { maxLength: 60 });
+            const transitiveFilePath = `${PROJECT_RELATIVE_PATH}/${basePath}/${pathHash}_${isIndex ? 'index_' : ''}transitive_${scenarioSlug}.${extension}`;
             // Check if this is a circular import (we're already processing this file)
             const isCircularImport = visitedPaths.has(resolvedPath);
             // Check if already processed
@@ -1819,6 +1918,7 @@ ${exportKeyword}const ${functionName} = new Proxy(() => scenarios().data()?.["${
         debugLog(`Returning from processTransitiveImportsRecursively depth=${depth}`);
         return modifiedContent;
     }
+    console.log(`[WriteScenario] POST-LOOP ${entity.name}: before remaining imports ${Date.now() - postLoopStartTime}ms`);
     // Process remaining internal imports that weren't in importedExports
     // This handles transitive dependencies: when the file content includes code (e.g., from
     // other functions in the same file) that imports from files with "server-only"
@@ -1838,6 +1938,16 @@ ${exportKeyword}const ${functionName} = new Proxy(() => scenarios().data()?.["${
     for (const importPath of remainingImportPaths) {
         remainingImportIndex++;
         debugLog(`[REMAINING LOOP] import ${remainingImportIndex}/${remainingImportPaths.length}: ${importPath}`);
+        // Skip imports that point to generated CodeYam files (same skip logic as
+        // rewriteRelativeModuleImports). Without this, MockData files from earlier
+        // captures that get discovered by the TypeScript compiler would be treated as
+        // regular imports, creating transitive copies with stale content.
+        const scenarioFilePattern = /[a-f0-9]{64}_\w+_[A-Z]\w*$/;
+        const mockDataPattern = /__codeyamMocks__\//;
+        if (scenarioFilePattern.test(importPath) ||
+            mockDataPattern.test(importPath)) {
+            continue;
+        }
         // Resolve the import path to a project file path
         const resolvedFilePath = resolveImportPath(importPath, file.path, project);
         if (!resolvedFilePath) {
@@ -1876,8 +1986,10 @@ ${exportKeyword}const ${functionName} = new Proxy(() => scenarios().data()?.["${
         const targetFileBasePath = safeFolder(targetFile.path.split('/').slice(0, -1).join('/'));
         const targetFileExtension = targetFile.name.split('.').pop();
         const targetFileIsIndex = isIndexPath(targetFile.path);
-        const filePathHash = safeFileName(targetFile.path);
-        const transformedFilePath = `${PROJECT_RELATIVE_PATH}/${targetFileBasePath}/${filePathHash}_${targetFileIsIndex ? 'index_' : ''}transitive_${safeFileName(scenario.name)}.${targetFileExtension}`;
+        // Limit path hash length to prevent ENAMETOOLONG errors
+        const filePathHash = safeFileName(targetFile.path, { maxLength: 80 });
+        const targetScenarioSlug = safeFileName(scenario.name, { maxLength: 60 });
+        const transformedFilePath = `${PROJECT_RELATIVE_PATH}/${targetFileBasePath}/${filePathHash}_${targetFileIsIndex ? 'index_' : ''}transitive_${targetScenarioSlug}.${targetFileExtension}`;
         // Check if we've already processed this file as a transitive copy
         // Note: __data_file_written__ is for entity-specific scenario files with different naming,
         // but we still need transitive copies for server-only stripping. Data entity files may
@@ -1916,8 +2028,12 @@ ${exportKeyword}const ${functionName} = new Proxy(() => scenarios().data()?.["${
                 const nestedBasePath = safeFolder(nestedFile.path.split('/').slice(0, -1).join('/'));
                 const nestedExtension = nestedFile.name.split('.').pop();
                 const nestedIsIndex = isIndexPath(nestedFile.path);
-                const nestedPathHash = safeFileName(nestedFile.path);
-                const nestedTransformedPath = `${PROJECT_RELATIVE_PATH}/${nestedBasePath}/${nestedPathHash}_${nestedIsIndex ? 'index_' : ''}transitive_${safeFileName(scenario.name)}.${nestedExtension}`;
+                // Limit path hash length to prevent ENAMETOOLONG errors
+                const nestedPathHash = safeFileName(nestedFile.path, { maxLength: 80 });
+                const nestedScenarioSlug = safeFileName(scenario.name, {
+                    maxLength: 60,
+                });
+                const nestedTransformedPath = `${PROJECT_RELATIVE_PATH}/${nestedBasePath}/${nestedPathHash}_${nestedIsIndex ? 'index_' : ''}transitive_${nestedScenarioSlug}.${nestedExtension}`;
                 // Check if already processed as a transitive file (we can rewrite to point to it)
                 // Note: __data_file_written__ is for entity-specific scenario files with different naming,
                 // but we still need transitive copies for server-only stripping in the import chain
@@ -1983,6 +2099,7 @@ ${exportKeyword}const ${functionName} = new Proxy(() => scenarios().data()?.["${
         const importRegex = new RegExp(`(from\\s*["'])${escapedImportPath}(["'])`, 'g');
         fileContent = fileContent.replace(importRegex, `$1${safeRelativePath}$2`);
     }
+    console.log(`[WriteScenario] POST-LOOP ${entity.name}: remaining imports loop took ${Date.now() - postLoopStartTime}ms`);
     const scenarioComponentComment = `// This file is auto-generated by CodeYam. Do not edit this file manually.
 // This file contains content for a scenario component:
 // Analyses being written: ${JSON.stringify(fileAnalyses?.map((a) => ({ id: a.id, entityName: a.entityName })))}
@@ -1993,6 +2110,23 @@ ${exportKeyword}const ${functionName} = new Proxy(() => scenarios().data()?.["${
 // Entity: ${rootAnalysis.entitySha} ${rootAnalysis.entityName}
 // Scenario: ${scenario.id} - ${scenario.name}
 `;
+    // Final pass: Rename any namespace imports (import * as X from '...') that have
+    // corresponding mock code using ...X__cyOriginal spread pattern.
+    // This handles cases where:
+    // 1. The import path was rewritten by transitive import handling
+    // 2. The import wasn't caught by the earlier renaming logic
+    // We scan for all __cyOriginal references in the mock code and ensure the imports are renamed.
+    const cyOriginalReferences = fileContent.match(/\.\.\.(\w+)__cyOriginal/g);
+    if (cyOriginalReferences) {
+        const uniqueNames = [
+            ...new Set(cyOriginalReferences.map((ref) => ref.replace('...', '').replace('__cyOriginal', ''))),
+        ];
+        for (const name of uniqueNames) {
+            // Match namespace imports for this name that haven't been renamed yet
+            const namespaceImportRegex = new RegExp(`(import\\s+\\*\\s+as\\s+)${escapeRegExp(name)}(\\s+from\\s+['"][^'"]*['"])`, 'g');
+            fileContent = fileContent.replace(namespaceImportRegex, `$1${name}__cyOriginal$2`);
+        }
+    }
     // Use the directive that was extracted at the beginning of processing
     // This ensures it stays at the very top even after imports are prepended
     // NOTE: We only preserve "use client" directives, NOT "use server" directives.
@@ -2013,6 +2147,7 @@ ${exportKeyword}const ${functionName} = new Proxy(() => scenarios().data()?.["${
     await writeFile(scenarioComponentPath, finalContent);
     debugLog('Successfully wrote scenario file');
     scenarioComponentPaths.push(scenarioComponentPath);
+    console.log(`[WriteScenario] POST-LOOP ${entity.name}: COMPLETE total=${Date.now() - postLoopStartTime}ms`);
     return { scenarioComponentPaths, writtenScenarioComponents };
 }
 //# sourceMappingURL=writeScenarioComponents.js.map