@codeyam/codeyam-cli 0.1.0-staging.d0ad4ae → 0.1.0-staging.d3e886e

package/analyzer-template/packages/ai/src/lib/generateChangesEntityKeyAttributes.ts

@@ -1,341 +0,0 @@
-import completionCall from './completionCall';
-import { saveLlmCall } from '~codeyam/aws/dynamodb';
-import type {
-  Analysis,
-  CompoundConditional,
-  ConditionalUsage,
-  Entity,
-  SourceLocation,
-} from '~codeyam/types';
-import generateEntityKeyAttributesGenerator from './promptGenerators/generateEntityKeyAttributesGenerator';
-import { awsLog } from '~codeyam/utils';
-import { AI, DEFAULT_LARGER_MODEL } from '~codeyam/ai';
-import isFrontend from './isFrontend';
-import { gatherAttributesMap } from './promptGenerators/gatherAttributesMap';
-import { formatConditionalUsagesForPrompt } from './getConditionalUsagesFromCode';
-
-interface GenerateChangesEntityKeyAttributesArgs {
-  entity: Entity;
-  existingKeyAttributes: Analysis['metadata']['keyAttributes'];
-  analysis: Analysis;
-  commitDiff: string;
-  model?: AI.Model;
-}
-
-export default async function generateChangesEntityKeyAttributes({
-  entity,
-  existingKeyAttributes,
-  analysis,
-  commitDiff,
-  model,
-}: GenerateChangesEntityKeyAttributesArgs) {
-  awsLog(`CodeYam: Generating entity key attributes`, {
-    filePath: entity.filePath,
-    entityName: entity.name,
-    analysisId: analysis.id,
-    existingKeyAttributes: existingKeyAttributes?.map((a) => a.externalPath),
-  });
-
-  const isolatedDataStructure = entity.metadata?.isolatedDataStructure;
-  const mergedDataStructure = analysis.metadata.mergedDataStructure;
-  const equivalentSignatureVariables =
-    isolatedDataStructure?.equivalentSignatureVariables ?? {};
-  const { attributesMap, associationMap, dataStructurePathMap } =
-    gatherAttributesMap(
-      isolatedDataStructure ?? mergedDataStructure,
-      mergedDataStructure,
-      equivalentSignatureVariables,
-      true,
-    );
-
-  // Use pre-computed conditional usages from metadata for static analysis context
-  const conditionalUsages: Record<string, ConditionalUsage[]> =
-    isolatedDataStructure?.conditionalUsages ?? {};
-  const compoundConditionals: CompoundConditional[] =
-    isolatedDataStructure?.compoundConditionals ?? [];
-  const staticAnalysisContext = formatConditionalUsagesForPrompt(
-    conditionalUsages,
-    compoundConditionals,
-  );
-
-  const prompt = generateEntityKeyAttributesGenerator({
-    code: entity.code,
-    attributesMap,
-    existingKeyAttributes,
-    commitDiff,
-    staticAnalysisContext,
-  });
-
-  const response = await completionCall({
-    type: `generateChangesEntityKeyAttributes`,
-    systemMessage: isFrontend(entity.filePath)
-      ? FRONTEND_SYSTEM_MESSAGE
-      : BACKEND_SYSTEM_MESSAGE,
-    prompt,
-    model: model ?? DEFAULT_LARGER_MODEL,
-  });
-
-  const llmCall = await saveLlmCall({
-    object_type: 'analysis',
-    object_id: analysis.id,
-    propsJson: {
-      entity: {
-        name: entity.name,
-        filePath: entity.filePath,
-        code: entity.code,
-      },
-      analysis: {
-        id: analysis.id,
-        metadata: {
-          isolatedDataStructure: entity.metadata.isolatedDataStructure,
-          keyAttributes: analysis.metadata?.keyAttributes ?? [],
-        },
-      },
-      commitDiff,
-      model,
-    },
-    ...response.stats,
-  });
-
-  const { completion: keyAttributesString } = response;
-  if (!keyAttributesString) {
-    console.log(
-      `CodeYam Error: Error Generating changes entity key attributes failed: No response from AI`,
-    );
-    return null;
-  }
-
-  awsLog(
-    `LLMCall ${llmCall ? llmCall.id : 'N/A'}: ${entity.filePath} ${entity.name} changes key attributes :>> `,
-    keyAttributesString,
-  );
-
-  const { addedKeyAttributes, removedKeyAttributes } =
-    JSON.parse(keyAttributesString);
-
-  const keyAttributes: Analysis['metadata']['keyAttributes'] = [
-    ...(existingKeyAttributes ?? []),
-  ];
-
-  for (const addedKeyAttribute of addedKeyAttributes ?? []) {
-    const internalPath = addedKeyAttribute.path;
-    const index = keyAttributes.findIndex(
-      (a) => a.internalPath === internalPath,
-    );
-    const fullKeyAttribute = {
-      internalPath,
-      externalPath: associationMap[internalPath],
-      dataStructurePath: dataStructurePathMap[internalPath] || internalPath,
-      description: addedKeyAttribute.description,
-      validValueOptions: addedKeyAttribute.validValueOptions,
-      errorValueOptions: addedKeyAttribute.errorValueOptions,
-      // Preserve new fields from LLM response
-      valueType: addedKeyAttribute.valueType,
-      dependencies: addedKeyAttribute.dependencies,
-    };
-    if (index !== -1) {
-      keyAttributes.splice(index, 1, fullKeyAttribute);
-    } else {
-      keyAttributes.push(fullKeyAttribute);
-    }
-  }
-
-  for (const removedKeyAttribute of removedKeyAttributes ?? []) {
-    const internalPath =
-      typeof removedKeyAttribute === 'string'
-        ? removedKeyAttribute
-        : removedKeyAttribute.path;
-    const index = keyAttributes.findIndex(
-      (a) => a.internalPath === internalPath,
-    );
-    if (index !== -1) {
-      keyAttributes.splice(index, 1);
-    }
-  }
-
-  const sortedUniqueKeyAttributes = keyAttributes
-    .filter(
-      (keyAttribute, index, self) =>
-        self.findIndex(
-          (ka) => ka.internalPath === keyAttribute.internalPath,
-        ) === index,
-    )
-    .filter((keyAttribute) => attributesMap[keyAttribute.internalPath]);
-
-  // Helper to extract source locations from conditional usages for a given path
-  const getSourceLocationsForPath = (path: string): SourceLocation[] => {
-    const usages = conditionalUsages[path] || [];
-    const locations: SourceLocation[] = [];
-
-    for (const usage of usages.slice(0, 5)) {
-      // Limit to 5 locations
-      if (usage.sourceLocation) {
-        locations.push({
-          entityName: entity.name,
-          filePath: entity.filePath,
-          lineNumber: usage.sourceLocation.lineNumber,
-          column: usage.sourceLocation.column,
-          codeSnippet: usage.sourceLocation.codeSnippet,
-          usageType: 'conditional',
-          description: `Used in ${usage.location} statement (${usage.conditionType} check)`,
-        });
-      }
-    }
-
-    return locations;
-  };
-
-  // Update sourceLocations for all key attributes based on current conditionalUsages
-  // This ensures new usages are picked up even for existing key attributes
-  const keyAttributesWithUpdatedSourceLocations = sortedUniqueKeyAttributes.map(
-    (keyAttribute) => {
-      // Skip sourceLocations update for dependent key attributes
-      // They should keep their original sourceLocations from the dependent entity's analysis
-      // Otherwise they'd get overwritten with the parent entity's conditional usages,
-      // causing them to incorrectly show up in "Key Attributes with New Usages"
-      if ((keyAttribute as any).dependentEntityName) {
-        return keyAttribute;
-      }
-
-      const sourceLocations = getSourceLocationsForPath(
-        keyAttribute.internalPath,
-      );
-
-      // If we found source locations from conditional usages, use them
-      // Otherwise keep the existing sourceLocations (e.g., from dependent entities)
-      if (sourceLocations.length > 0) {
-        return {
-          ...keyAttribute,
-          sourceLocations,
-        };
-      }
-
-      return keyAttribute;
-    },
-  );
-
-  return {
-    keyAttributes: keyAttributesWithUpdatedSourceLocations,
-    llmCall,
-  };
-}
-
-const FRONTEND_SYSTEM_MESSAGE = `You are updating the key attributes for a frontend component that was recently changed.
-
-This is an INCREMENTAL update. Existing key attributes should be preserved unless the code change clearly invalidates them. Removing and re-adding attributes across changes causes unnecessary churn.
-
-## Stability Rules
-
-- REMOVE only if the attribute is clearly no longer used (variable deleted, conditional removed, no longer referenced)
-- KEEP marginal attributes—if unsure, preserve rather than remove
-- ADD new attributes freely when warranted
-
-## What Makes a Key Attribute
-
-A key attribute is a data path from "Attributes and Value Types" that dramatically changes how the component renders:
-
-- Controls a conditional that shows/hides significant UI sections
-- Changes the component's primary visual state (not just minor text differences)
-- Determines which branch of rendering logic executes
-
-NOT key attributes:
-- Values that only affect non-visible behavior (hrefs, image srcs)
-- Fallback values that won't be used if primary values exist
-- Values that would cause errors if changed
-
-Note: A conditional that shows a different UI state (e.g., loading screen, redirect message) IS significant—include it. Only exclude guard clauses that render literally nothing.
-
-## Path Format
-
-Only return attributes from the "Attributes and Value Types" list—these are the only values we can control. Use the exact path provided. Use \`functionCallReturnValue\` for function return values. Use \`[]\` for array items (e.g., \`items[]\`).
-
-## Dependencies
-
-If this key attribute is only used if one or more other attributes have specific values, include those dependencies in a \`dependencies\` array.
-
-## Value Type
-
-Should reiterate the type of the attribute (e.g., "string", "object", "array", "boolean", etc.) based on the "Attributes and Value Types" list.
-
-## Response Format
-
-For \`validValueOptions\`, include boundary/extreme values that trigger different behavior—but NOT values that would cause errors.
-
-\`\`\`json
-{
-  "addedKeyAttributes": [
-    {
-      "path": "user",
-      "description": "Controls whether the main form or redirect screen displays",
-      "dependencies": [
-        { "projectId": "must be a valid project ID for 'user' to have effect" }
-      ],
-      "valueType": "object",
-      "validValueOptions": ["truthy user object", "null/undefined"]
-    }
-  ],
-  "removedKeyAttributes": ["oldAttribute.path"]
-}
-\`\`\`
-
-Return empty arrays if no changes needed.
-`;
-
-const BACKEND_SYSTEM_MESSAGE = `You are updating the key attributes for a backend function that was recently changed.
-
-This is an INCREMENTAL update. Existing key attributes should be preserved unless the code change clearly invalidates them. Removing and re-adding attributes across changes causes unnecessary churn.
-
-## Stability Rules
-
-- REMOVE only if the attribute is clearly no longer used (variable deleted, conditional removed, no longer referenced)
-- KEEP marginal attributes—if unsure, preserve rather than remove
-- ADD new attributes freely when warranted
-
-## What Makes a Key Attribute
-
-A key attribute is a data path from "Attributes and Value Types" that dramatically changes the function's behavior:
-
-- Controls a conditional that significantly alters execution flow or return value
-- Determines which branch of logic executes
-- For side-effect functions: changes how external systems are called (database, email, etc.)
-
-NOT key attributes:
-- Fallback values that won't be used if primary values exist
-- Values that would cause errors if changed
-- Guard clauses that return nothing/minimal data
-
-## Path Format
-
-Only return attributes from the "Attributes and Value Types" list—these are the only values we can control. Use the exact path provided. Use \`functionCallReturnValue\` for function return values. Use \`[]\` for array items (e.g., \`items[]\`).
-
-## Dependencies
-
-If this key attribute is only used if one or more other attributes have specific values, include those dependencies in a \`dependencies\` array.
-
-## Value Type
-
-Should reiterate the type of the attribute (e.g., "string", "object", "array", "boolean", etc.) based on the "Attributes and Value Types" list.
-
-## Response Format
-
-For \`validValueOptions\`, include boundary/extreme values that trigger different behavior—but NOT values that would cause errors.
-
-\`\`\`json
-{
-  "addedKeyAttributes": [
-    {
-      "path": "config.enabled",
-      "description": "Controls whether the main processing logic runs",
-      "dependencies": [
-        { "analysisMode": "must be 'full' for 'enabled' to have effect" }
-      ],
-      "valueType": "boolean",
-      "validValueOptions": ["true", "false"]
-    }
-  ],
-  "removedKeyAttributes": ["oldAttribute.path"]
-}
-\`\`\`
-
-Return empty arrays if no changes needed.
-`;