@codeyam/codeyam-cli 0.1.0-staging.b8a55ba → 0.1.0-staging.c90f8c9

package/packages/ai/src/lib/dataStructure/ScopeDataStructure.js

@@ -79,15 +79,27 @@
  * - `helpers/README.md` - Overview of the helper module architecture
  */
 import fillInSchemaGapsAndUnknowns from "./helpers/fillInSchemaGapsAndUnknowns.js";
+/**
+ * Patterns that indicate recursive type structures in schema paths.
+ * Used by hasExcessivePatternRepetition() to detect exponential path blowup.
+ */
+const RECURSIVE_PATH_PATTERNS = [
+    /\.attributes\.properties\[\]/g, // TypeScript AST JSX nodes
+    /\.children\[\]/g, // Tree structures
+    /\.elements\[\]/g, // Array-like structures
+    /\.members\[\]/g, // Class/interface members
+    /\.properties\[\]/g, // Object properties
+    /\.items\[\]/g, // Generic items arrays
+];
 import ensureSchemaConsistency from "./helpers/ensureSchemaConsistency.js";
 import cleanPath from "./helpers/cleanPath.js";
 import { PathManager } from "./helpers/PathManager.js";
-import { uniqueId, uniqueScopeVariables, uniqueScopeAndPaths, } from "./helpers/uniqueIdUtils.js";
+import { uniqueId, uniqueScopeAndPaths, uniqueScopeVariables, } from "./helpers/uniqueIdUtils.js";
 import selectBestValue from "./helpers/selectBestValue.js";
 import { VisitedTracker } from "./helpers/VisitedTracker.js";
 import { DebugTracer } from "./helpers/DebugTracer.js";
 import { BatchSchemaProcessor } from "./helpers/BatchSchemaProcessor.js";
-import { ScopeTreeManager, ROOT_SCOPE_NAME, } from "./helpers/ScopeTreeManager.js";
+import { ROOT_SCOPE_NAME, ScopeTreeManager, } from "./helpers/ScopeTreeManager.js";
 import cleanScopeNodeName from "./helpers/cleanScopeNodeName.js";
 import getFunctionCallRoot from "./helpers/getFunctionCallRoot.js";
 import cleanPathOfNonTransformingFunctions from "./helpers/cleanPathOfNonTransformingFunctions.js";
@@ -176,6 +188,26 @@ export class ScopeDataStructure {
          * Maps local variable path to array of usages.
          */
         this.rawConditionalUsages = {};
+        /**
+         * Conditional effects collected during AST analysis.
+         * Tracks what setter calls happen inside conditionals (if, switch, ternary).
+         */
+        this.rawConditionalEffects = [];
+        /**
+         * Compound conditionals collected during AST analysis.
+         * Groups conditions that must all be true together (e.g., a && b && c).
+         */
+        this.rawCompoundConditionals = [];
+        /**
+         * Gating conditions for child component boundaries.
+         * Maps child component name to the conditions that must be true for it to render.
+         */
+        this.rawChildBoundaryGatingConditions = {};
+        /**
+         * JSX rendering usages collected during AST analysis.
+         * Tracks arrays rendered via .map() and strings interpolated in JSX.
+         */
+        this.rawJsxRenderingUsages = [];
         this.lastAddToSchemaId = 0;
         this.lastEquivalencyId = 0;
         this.lastEquivalencyDatabaseId = 0;
@@ -599,7 +631,6 @@ export class ScopeDataStructure {
     }
     addEquivalency(path, equivalentPath, equivalentScopeName, scopeNode, equivalencyReason, equivalencyValueChain, traceId) {
         var _a;
-        // DEBUG: Detect infinite loops
         addEquivalencyCallCount++;
         if (addEquivalencyCallCount > 50000) {
             console.error('INFINITE LOOP DETECTED in addEquivalency', {
@@ -913,6 +944,17 @@ export class ScopeDataStructure {
                 const remainingKey = remainingSchemaPathParts.join('|');
                 const equivalentSchemaPath = equivalentSchemaPathMap.get(remainingKey);
                 if (equivalentSchemaPath) {
+                    // Skip propagation when there's a structural mismatch:
+                    // - schemaPath ends with [] (array element, represents an object)
+                    // - equivalentSchemaPath doesn't end with [] (non-array prop, usually a scalar)
+                    // This prevents incorrectly typing array elements as strings when they're
+                    // equivalent to scalar props like JSX keys (e.g., workouts[] ↔ Card().key)
+                    const schemaPathEndsWithArray = schemaPath.endsWith('[]');
+                    const equivalentEndsWithArray = equivalentSchemaPath.endsWith('[]');
+                    if (schemaPathEndsWithArray !== equivalentEndsWithArray) {
+                        // Don't propagate between array element paths and non-array paths
+                        continue;
+                    }
                     const value1 = scopeNode.schema[schemaPath];
                     const value2 = equivalentScopeNode.schema[equivalentSchemaPath];
                     const bestValue = selectBestValue(value1, value2);
@@ -983,6 +1025,51 @@ export class ScopeDataStructure {
     isValidPath(path) {
         return this.pathManager.isValidPath(path);
     }
+    /**
+     * Detects if a path contains excessive repetition of the same pattern.
+     *
+     * This prevents exponential blowup when analyzing recursive type structures.
+     * For example, TypeScript AST nodes have `.attributes.properties[]` where each
+     * property is also a node with `.attributes.properties[]`. Without this check,
+     * paths like `signature[0].attributes.properties[].attributes.properties[].attributes.properties[]...`
+     * would be generated exponentially.
+     *
+     * Two detection strategies:
+     * 1. Known patterns: Check RECURSIVE_PATH_PATTERNS for common recursive structures
+     * 2. Generic detection: For longer paths, detect any 2-3 part segment that repeats
+     *
+     * @param path - The schema path to check
+     * @param maxRepetitions - Maximum allowed repetitions of any pattern (default: 2)
+     * @returns true if the path has excessive repetition
+     */
+    hasExcessivePatternRepetition(path, maxRepetitions = 2) {
+        // Check known recursive patterns
+        for (const pattern of RECURSIVE_PATH_PATTERNS) {
+            const matches = path.match(pattern);
+            if (matches && matches.length > maxRepetitions) {
+                return true;
+            }
+        }
+        // For longer paths, detect any repeated multi-part segments we haven't explicitly listed
+        const pathParts = this.splitPath(path);
+        if (pathParts.length <= 6) {
+            return false;
+        }
+        // Check for repeated sequences of 2-3 consecutive parts
+        for (let segmentLength = 2; segmentLength <= 3; segmentLength++) {
+            const seen = new Map();
+            for (let i = 0; i <= pathParts.length - segmentLength; i++) {
+                const segment = pathParts.slice(i, i + segmentLength).join('.');
+                const normalizedSegment = segment.replace(/\[\d+\]/g, '[]');
+                const count = (seen.get(normalizedSegment) || 0) + 1;
+                seen.set(normalizedSegment, count);
+                if (count > maxRepetitions) {
+                    return true;
+                }
+            }
+        }
+        return false;
+    }
     addToTree(pathParts) {
         this.scopeTreeManager.addPath(pathParts);
     }
@@ -1023,22 +1110,10 @@ export class ScopeDataStructure {
         this.checkExternalFunctionCalls();
     }
     determineEquivalenciesAndBuildSchema(scopeNode) {
-        const { isolatedStructure, isolatedEquivalentVariables } = scopeNode.analysis;
-        // DEBUG: Log all equivalencies related to useFetcher
-        if (Object.keys(isolatedEquivalentVariables || {}).some((k) => k.includes('Fetcher') || k.includes('fetcher'))) {
-            console.log('CodeYam DEBUG determineEquivalenciesAndBuildSchema:', JSON.stringify({
-                scopeNodeName: scopeNode.name,
-                fetcherEquivalencies: Object.entries(isolatedEquivalentVariables || {})
-                    .filter(([k, v]) => k.includes('Fetcher') ||
-                    k.includes('fetcher') ||
-                    String(v).includes('Fetcher') ||
-                    String(v).includes('fetcher'))
-                    .reduce((acc, [k, v]) => {
-                    acc[k] = v;
-                    return acc;
-                }, {}),
-            }, null, 2));
+        if (!scopeNode.analysis) {
+            return;
         }
+        const { isolatedStructure, isolatedEquivalentVariables } = scopeNode.analysis;
         const allPaths = Array.from(new Set([
             ...Object.keys(isolatedStructure || {}),
             ...Object.keys(isolatedEquivalentVariables || {}),
@@ -1047,8 +1122,24 @@ export class ScopeDataStructure {
         for (let path in isolatedEquivalentVariables) {
             let equivalentValue = isolatedEquivalentVariables?.[path];
             if (equivalentValue && this.isValidPath(equivalentValue)) {
-                path = cleanPath(path.replace(/::cyDuplicateKey\d+::/g, ''), allPaths);
-                equivalentValue = cleanPath(equivalentValue.replace(/::cyDuplicateKey\d+::/g, ''), allPaths);
+                // IMPORTANT: DO NOT strip ::cyDuplicateKey:: markers from equivalencies.
+                // These markers are critical for distinguishing variable reassignments.
+                // For example, with:
+                //   let fetcher = useFetcher<ConfigData>();
+                //   const configData = fetcher.data?.data;
+                //   fetcher = useFetcher<SettingsData>();
+                //   const settingsData = fetcher.data?.data;
+                //
+                // mergeStatements creates:
+                //   fetcher → useFetcher<ConfigData>()...
+                //   fetcher::cyDuplicateKey1:: → useFetcher<SettingsData>()...
+                //   configData → fetcher.data.data
+                //   settingsData → fetcher::cyDuplicateKey1::.data.data
+                //
+                // If we strip ::cyDuplicateKey::, settingsData would incorrectly trace
+                // to useFetcher<ConfigData>() instead of useFetcher<SettingsData>().
+                path = cleanPath(path, allPaths);
+                equivalentValue = cleanPath(equivalentValue, allPaths);
                 this.addEquivalency(path, equivalentValue, scopeNode.name, scopeNode, 'original equivalency');
                 // Propagate equivalencies involving parent-scope variables to those parent scopes.
                 // This handles patterns like: collected.push({...entity}) where 'collected' is defined
@@ -1140,7 +1231,7 @@ export class ScopeDataStructure {
         // This eliminates deep call stacks and improves deduplication
         this.batchProcessor = new BatchSchemaProcessor();
         this.batchQueuedSet = new Set();
-        for (const key of Array.from(allPaths)) {
+        for (const key of allPaths) {
             let value = isolatedStructure[key] ?? 'unknown';
             if (['null', 'undefined'].includes(value)) {
                 value = 'unknown';
@@ -1174,7 +1265,14 @@ export class ScopeDataStructure {
     processBatchQueue() {
         if (!this.batchProcessor)
             return;
+        let iterations = 0;
         while (this.batchProcessor.hasWork()) {
+            iterations++;
+            // Safety: detect potential infinite loops
+            if (iterations > 100000) {
+                console.error(`[ScopeDataStructure] processBatchQueue exceeded 100k iterations, possible infinite loop!`);
+                break;
+            }
             const item = this.batchProcessor.getNextWork();
             if (!item)
                 break;
@@ -1221,18 +1319,6 @@ export class ScopeDataStructure {
         // Find the FunctionCallInfo that matches this call signature
         const searchKey = getFunctionCallRoot(callSignature);
         const functionCallInfo = this.getExternalFunctionCallsIndex().get(searchKey);
-        // DEBUG: Track useFetcher calls
-        if (searchKey === 'useFetcher' || callSignature.includes('useFetcher')) {
-            console.log('CodeYam DEBUG trackReceivingVariable:', JSON.stringify({
-                receivingVariable,
-                equivalentValue,
-                callSignature,
-                searchKey,
-                foundFunctionCallInfo: !!functionCallInfo,
-                existingRecvVars: functionCallInfo?.receivingVariableNames,
-                existingCallSigToVar: functionCallInfo?.callSignatureToVariable,
-            }, null, 2));
-        }
         if (!functionCallInfo) {
             return;
         }
@@ -1587,6 +1673,17 @@ export class ScopeDataStructure {
                 continue;
             }
             const newEquivalentPath = this.joinPathParts([schemaPath, remainingPath]);
+            // PERF: Detect repeated patterns in paths to prevent exponential blowup
+            // Paths like `signature[0].attributes.properties[].attributes.properties[]...`
+            // indicate recursive type structures that cause exponential schema explosion
+            if (this.hasExcessivePatternRepetition(newEquivalentPath)) {
+                if (traceId && debugLevel > 0) {
+                    console.info('Debug: skipping path with excessive pattern repetition', {
+                        path: newEquivalentPath,
+                    });
+                }
+                continue;
+            }
             if (!equivalentScopeNode) {
                 if (traceId) {
                     console.info('Debug Propagation: missing equivalent scope info', {
@@ -2233,9 +2330,22 @@ export class ScopeDataStructure {
                     }
                 }
             }
-            return mergedSchema;
+            return this.filterDuplicateKeys(mergedSchema);
         }
-        return schema;
+        return this.filterDuplicateKeys(schema);
+    }
+    /**
+     * Filter out ::cyDuplicateKey:: entries from a schema.
+     * These are internal markers for tracking variable reassignments
+     * and should not appear in output schemas or LLM prompts.
+     */
+    filterDuplicateKeys(schema) {
+        return Object.entries(schema).reduce((acc, [key, value]) => {
+            if (!key.includes('::cyDuplicateKey')) {
+                acc[key] = value;
+            }
+            return acc;
+        }, {});
     }
     getEquivalencies(scopeName) {
         const scopeNode = this.getScopeOrFunctionCallInfo(scopeName);
@@ -2301,26 +2411,63 @@ export class ScopeDataStructure {
             return acc;
         }, {});
         const equivalencies = this.getEquivalencies(functionName);
+        const scopeName = functionName ?? this.scopeTreeManager.getRootName();
         for (const equivalenceKey in equivalencies ?? {}) {
             for (const equivalenceValue of equivalencies[equivalenceKey]) {
                 const schemaPath = equivalenceValue.schemaPath;
                 if (schemaPath.startsWith('signature[') &&
-                    equivalenceValue.scopeNodeName === functionName &&
+                    equivalenceValue.scopeNodeName === scopeName &&
                     !signatureInSchema[schemaPath]) {
                     signatureInSchema[schemaPath] = 'unknown';
                 }
             }
         }
         const tempScopeNode = this.createTempScopeNode(functionName ?? this.scopeTreeManager.getRootName(), signatureInSchema, equivalencies);
-        // CRITICAL: Set onlyEquivalencies to true to prevent database modifications
-        // during this "getter" method. validateSchema triggers manager.finalize which
-        // can call addToSchema -> addToEquivalencyDatabase -> mergeEquivalencyDatabaseEntries,
-        // which would incorrectly remove entries from the database.
-        const wasOnlyEquivalencies = this.onlyEquivalencies;
-        this.onlyEquivalencies = true;
         this.validateSchema(tempScopeNode, true, fillInUnknowns);
-        this.onlyEquivalencies = wasOnlyEquivalencies;
-        return tempScopeNode.schema;
+        // After validateSchema has filled in types, propagate nested paths from
+        // variables to their signature equivalents.
+        // e.g., workouts[].activity_type -> signature[0].workouts[].activity_type
+        //
+        // Build a map of variable names that are equivalent to signature paths
+        // e.g., { 'workouts': 'signature[0].workouts' }
+        const variableToSignatureMap = {};
+        for (const equivalenceKey in equivalencies ?? {}) {
+            for (const equivalenceValue of equivalencies[equivalenceKey]) {
+                const schemaPath = equivalenceValue.schemaPath;
+                // Track which variables map to signature paths
+                // equivalenceKey is the variable name (e.g., 'workouts')
+                // schemaPath is where it comes from (e.g., 'signature[0].workouts')
+                if (schemaPath.startsWith('signature[') &&
+                    equivalenceValue.scopeNodeName === scopeName) {
+                    variableToSignatureMap[equivalenceKey] = schemaPath;
+                }
+            }
+        }
+        // Propagate nested paths from variables to their signature equivalents
+        // e.g., if workouts = signature[0].workouts, then workouts[].title becomes
+        // signature[0].workouts[].title
+        for (const schemaKey in schema) {
+            // Skip keys that already start with signature[
+            if (schemaKey.startsWith('signature['))
+                continue;
+            // Check if this key starts with a variable that maps to a signature path
+            for (const [variableName, signaturePath] of Object.entries(variableToSignatureMap)) {
+                // Check if schemaKey starts with variableName followed by a property accessor
+                // e.g., 'workouts[]' starts with 'workouts'
+                if (schemaKey === variableName ||
+                    schemaKey.startsWith(variableName + '.') ||
+                    schemaKey.startsWith(variableName + '[')) {
+                    // Transform the path: replace the variable prefix with the signature path
+                    const suffix = schemaKey.slice(variableName.length);
+                    const signatureKey = signaturePath + suffix;
+                    // Add to schema if not already present
+                    if (!tempScopeNode.schema[signatureKey]) {
+                        tempScopeNode.schema[signatureKey] = schema[schemaKey];
+                    }
+                }
+            }
+        }
+        return this.filterDuplicateKeys(tempScopeNode.schema);
     }
     getReturnValue({ functionName, fillInUnknowns, }) {
         // Trigger finalization on all managers to apply any pending updates
@@ -2363,14 +2510,27 @@ export class ScopeDataStructure {
             // Include function paths even if their return value wasn't captured
             // This ensures methods like onAuthStateChange are included in the schema
             // But exclude signature entries (they should only be included via functionCallReturnValue paths)
-            (schema[key] === 'function' && key.indexOf('signature[') === -1))
+            // Also exclude bare function call signatures - paths that are JUST a call like
+            // "useCustomSizes(projectSlug)" should not be included as return values.
+            // These represent "the function exists" not actual return data, and including
+            // them causes nested path bugs in dependencySchemas.
+            (schema[key] === 'function' &&
+                key.indexOf('signature[') === -1 &&
+                // Exclude bare call signatures: function calls with no dots OUTSIDE parentheses
+                // e.g., "useCustomSizes(projectSlug)" is bare (exclude)
+                // e.g., "loadProject({nested.property})" is bare - dots are inside args (exclude)
+                // e.g., "getSupabase().auth.method()" has dots outside - method chain (include)
+                !this.isBareCallSignature(key)))
             .reduce((acc, key) => {
             acc[key] = schema[key];
             const keyParts = this.splitPath(key);
             for (const path in schema) {
                 const pathParts = this.splitPath(path);
                 if (pathParts.every((p, i) => keyParts[i] === p)) {
-                    acc[path] = schema[path];
+                    // Also exclude bare call signatures from prefix paths
+                    if (!this.isBareCallSignature(path)) {
+                        acc[path] = schema[path];
+                    }
                 }
             }
             return acc;
@@ -2384,7 +2544,56 @@ export class ScopeDataStructure {
         this.onlyEquivalencies = true;
         this.validateSchema(tempScopeNode, true, fillInUnknowns);
         this.onlyEquivalencies = wasOnlyEquivalencies;
-        return tempScopeNode.schema;
+        // Remove bare call signatures from the return value schema.
+        // fillInSchemaGapsAndUnknowns may add parent paths like "useCustomSizes(projectSlug)"
+        // when it sees "useCustomSizes(projectSlug).functionCallReturnValue". These bare
+        // call signatures represent "the function exists" not actual return data, and
+        // including them causes nested path bugs in dependencySchemas.
+        const resultSchema = tempScopeNode.schema;
+        for (const key of Object.keys(resultSchema)) {
+            if (this.isBareCallSignature(key)) {
+                delete resultSchema[key];
+            }
+        }
+        return resultSchema;
+    }
+    /**
+     * Checks if a schema key is a "bare call signature" - a function call with no
+     * method chain before it and no path segments after it.
+     *
+     * A bare call signature represents "this function exists" rather than actual
+     * return data, and including them causes nested path bugs in dependencySchemas.
+     *
+     * Examples:
+     * - "useCustomSizes(projectSlug)" -> bare (true)
+     * - "loadProject({nested.property})" -> bare (dots are inside args, true)
+     * - "getSupabase().auth.method()" -> not bare (has dots outside parens, false)
+     * - "useProject().functionCallReturnValue" -> not bare (has path after, false)
+     */
+    isBareCallSignature(key) {
+        // Must end with ) and contain ( to be a call
+        if (!key.endsWith(')') || key.indexOf('(') === -1) {
+            return false;
+        }
+        // Check if there are any dots OUTSIDE of parentheses
+        // Strip out content inside balanced parentheses, then check for dots
+        let depth = 0;
+        let hasDotsOutsideParens = false;
+        for (let i = 0; i < key.length; i++) {
+            const char = key[i];
+            if (char === '(') {
+                depth++;
+            }
+            else if (char === ')') {
+                depth--;
+            }
+            else if (char === '.' && depth === 0) {
+                hasDotsOutsideParens = true;
+                break;
+            }
+        }
+        // It's a bare call signature if there are no dots outside parentheses
+        return !hasDotsOutsideParens;
     }
     /**
      * Replaces cyScope placeholder references (e.g., cyScope10()) in schema keys
@@ -2457,11 +2666,271 @@ export class ScopeDataStructure {
         const equivalentSignatureVariables = {};
         for (const [path, equivalentValues] of Object.entries(scopeNode.equivalencies)) {
             for (const equivalentValue of equivalentValues) {
+                // Case 1: Props/signature equivalencies (existing behavior)
+                // Maps local variable names to their signature paths
+                // e.g., "propValue" -> "signature[0].prop"
                 if (path.startsWith('signature[')) {
                     equivalentSignatureVariables[equivalentValue.schemaPath] = path;
                 }
+                // Case 2: Hook variable equivalencies (new behavior)
+                // The equivalencies are stored as: path = variable name, schemaPath = data source
+                // e.g., path = "debugFetcher", schemaPath = "useFetcher<...>().functionCallReturnValue"
+                // We need to map: "debugFetcher" -> "useFetcher<...>()"
+                // This enables resolving paths like "debugFetcher.state" to
+                // "useFetcher<...>().state" for execution flow validation
+                if (equivalentValue.schemaPath.endsWith('.functionCallReturnValue')) {
+                    // Extract the hook call path (everything before .functionCallReturnValue)
+                    let hookCallPath = equivalentValue.schemaPath.slice(0, -'.functionCallReturnValue'.length);
+                    // Only include if it looks like a hook call (contains parentheses)
+                    // and the variable name (path) is a simple identifier (no dots)
+                    if (hookCallPath.includes('(') && !path.includes('.')) {
+                        // Special case: If hookCallPath is a callback scope (cyScope pattern),
+                        // trace through it to find what the callback actually returns.
+                        // This handles useState(() => { return prop; }) patterns.
+                        const cyScopeMatch = hookCallPath.match(/^(cyScope\d+)\(\)$/);
+                        if (cyScopeMatch) {
+                            // Use the equivalency database to trace the callback's return value
+                            // to its actual source (e.g., viewModeFromUrl -> segments -> params -> useParams)
+                            const dbEntry = this.getEquivalenciesDatabaseEntry(scopeNode.name, // Component scope
+                            path);
+                            if (dbEntry?.sourceCandidates?.length > 0) {
+                                // Use the traced source instead of the callback scope
+                                hookCallPath = dbEntry.sourceCandidates[0].schemaPath;
+                            }
+                        }
+                        equivalentSignatureVariables[path] = hookCallPath;
+                    }
+                }
+                // Case 3: Destructured variables from local variables
+                // e.g., const { scenarios } = currentEntityAnalysis;
+                // This creates: path = "scenarios", schemaPath = "currentEntityAnalysis.scenarios"
+                // We need to map: "scenarios" -> "currentEntityAnalysis.scenarios"
+                // AND resolve transitively if currentEntityAnalysis is itself equivalent to a hook call
+                if (!path.includes('.') && // path is a simple identifier
+                    !equivalentValue.schemaPath.startsWith('signature[') && // not a signature path
+                    !equivalentValue.schemaPath.endsWith('.functionCallReturnValue') // not already handled above
+                ) {
+                    // Only add if we haven't already captured this variable in Case 1 or 2
+                    if (!(path in equivalentSignatureVariables)) {
+                        equivalentSignatureVariables[path] = equivalentValue.schemaPath;
+                    }
+                }
+                // Case 4: Child component prop mappings (Fix 22)
+                // When parent renders <ChildComponent prop={value} />, we get equivalencies like:
+                //   path = "ChildComponent().signature[0].prop"
+                //   schemaPath = "value" (the variable passed as the prop)
+                // We need to include these so translateChildPathToParent can work.
+                // Pattern: ComponentName().signature[N] or ComponentName().signature[N].propName
+                if (path.includes('().signature[') &&
+                    !equivalentValue.schemaPath.includes('()') // schemaPath is a simple variable, not a function call
+                ) {
+                    equivalentSignatureVariables[path] = equivalentValue.schemaPath;
+                }
+                // Case 5: Destructured function parameters (Fix 25)
+                // When a function has destructured props: function Comp({ propA, propB }: Props)
+                // We get equivalencies like:
+                //   path = "propA" (the destructured variable name)
+                //   schemaPath = "signature[0].propA" (the signature path)
+                // We need to map: "propA" -> "signature[0].propA"
+                // This enables translateChildPathToParent to resolve child variable paths
+                // to their signature paths when merging execution flows.
+                if (!path.includes('.') && // path is a simple identifier (destructured prop name)
+                    equivalentValue.schemaPath.startsWith('signature[') // schemaPath IS a signature path
+                ) {
+                    equivalentSignatureVariables[path] = equivalentValue.schemaPath;
+                }
+                // Case 7: Method calls on variables that result in .functionCallReturnValue (Fix 33)
+                // When we have patterns like:
+                //   path = "segments" (simple identifier)
+                //   schemaPath = "splat.split('/').functionCallReturnValue"
+                // This is a method call on a variable (not a hook call), but we still need to
+                // track it so transitive resolution can resolve `splat` to its actual source.
+                // E.g., if splat -> useParams().functionCallReturnValue['*'], then
+                // segments -> useParams().functionCallReturnValue['*'].split('/').functionCallReturnValue
+                if (!path.includes('.') && // path is a simple identifier
+                    equivalentValue.schemaPath.endsWith('.functionCallReturnValue') && // ends with function return
+                    equivalentValue.schemaPath.includes('.') && // has property access (method call)
+                    !(path in equivalentSignatureVariables) // not already captured
+                ) {
+                    // Check if this looks like a method call on a variable (not a hook call)
+                    // Hook calls look like: hookName() or hookName<T>()
+                    // Method calls look like: variable.method() or variable.method<T>()
+                    const hookCallPath = equivalentValue.schemaPath.slice(0, -'.functionCallReturnValue'.length);
+                    // If it's a method call (contains a dot before the parenthesis), include it
+                    const dotBeforeParen = hookCallPath.indexOf('.');
+                    const parenPos = hookCallPath.indexOf('(');
+                    if (dotBeforeParen !== -1 && dotBeforeParen < parenPos) {
+                        // This is a method call like "splat.split('/')", not a hook call
+                        equivalentSignatureVariables[path] = equivalentValue.schemaPath;
+                    }
+                }
             }
         }
+        // Case 6: Collect JSX child prop equivalencies from child scopes (Fix 26)
+        // When a parent component renders <ChildComponent prop={value} />, the JSX
+        // return statement may be in a child scope (e.g., cyScope2). The equivalencies
+        // like ChildComponent().signature[0].prop -> value get stored in that child scope.
+        // But translateChildPathToParent needs to find them from the parent scope's context.
+        // So we collect Case 4 patterns from ALL child scopes that belong to this root scope.
+        const rootName = this.scopeTreeManager.getRootName();
+        for (const [scopeName, childScopeNode] of Object.entries(this.scopeNodes)) {
+            // Skip the root scope (already processed above)
+            if (scopeName === rootName)
+                continue;
+            // Only include scopes that are children of the root (their tree includes root)
+            if (!childScopeNode.tree?.includes(rootName))
+                continue;
+            // Look for Case 4 patterns in the child scope
+            for (const [path, equivalentValues] of Object.entries(childScopeNode.equivalencies || {})) {
+                for (const equivalentValue of equivalentValues) {
+                    // Case 4 pattern: ChildComponent().signature[0].propName -> parentVariable
+                    if (path.includes('().signature[') &&
+                        !equivalentValue.schemaPath.includes('()') // schemaPath is a simple variable
+                    ) {
+                        // Only add if not already present from the root scope
+                        if (!(path in equivalentSignatureVariables)) {
+                            equivalentSignatureVariables[path] = equivalentValue.schemaPath;
+                        }
+                    }
+                }
+            }
+        }
+        // Transitive resolution: Resolve variable chains through multiple levels
+        // E.g., analysis → currentEntityAnalysis → useLoaderData().functionCallReturnValue.currentEntityAnalysis
+        // We need multiple passes because resolutions can depend on each other
+        const maxIterations = 5; // Prevent infinite loops
+        for (let iteration = 0; iteration < maxIterations; iteration++) {
+            let changed = false;
+            for (const [varName, sourcePath] of Object.entries(equivalentSignatureVariables)) {
+                // Skip if already fully resolved (contains function call syntax)
+                // BUT first check for computed value patterns that need resolution (Fix 28)
+                // AND method call patterns that need base variable resolution (Fix 33)
+                if (sourcePath.includes('()')) {
+                    // Fix 28: Handle computed value patterns with dependency arrays
+                    // Patterns like `functionName(arg, [dep1, dep2, ...])` are NOT controllable
+                    // data sources. We trace through the dependencies to find controllable sources.
+                    const bracketStart = sourcePath.indexOf('[');
+                    const bracketEnd = sourcePath.lastIndexOf(']');
+                    if (bracketStart !== -1 && bracketEnd > bracketStart) {
+                        const arrayContent = sourcePath.slice(bracketStart + 1, bracketEnd);
+                        const items = arrayContent.split(',').map((s) => s.trim());
+                        // Only process if this looks like a dependency array:
+                        // multiple items that are all simple identifiers (not numbers or expressions)
+                        const isIdentifier = (s) => /^\w+$/.test(s) && !/^\d+$/.test(s);
+                        if (items.length > 1 && items.every(isIdentifier)) {
+                            // Look for a dependency that's already resolved to a controllable source
+                            for (const dep of items) {
+                                if (dep in equivalentSignatureVariables) {
+                                    const resolvedDep = equivalentSignatureVariables[dep];
+                                    // Use if it's a controllable path (contains hook call)
+                                    // and is NOT another unresolved computed pattern (has comma-separated deps)
+                                    const hasCommaInBrackets = resolvedDep.includes('[') &&
+                                        resolvedDep.includes(',') &&
+                                        resolvedDep.indexOf(',') > resolvedDep.indexOf('[');
+                                    if (resolvedDep.includes('()') && !hasCommaInBrackets) {
+                                        // Computed value is typically an element from an array
+                                        equivalentSignatureVariables[varName] = resolvedDep + '[]';
+                                        changed = true;
+                                        break;
+                                    }
+                                }
+                            }
+                        }
+                    }
+                    // Fix 33: Handle method call patterns on variables
+                    // Patterns like: "splat.split('/').functionCallReturnValue"
+                    // We need to resolve the base variable (splat) to its actual source
+                    // Check if this is a method call on a variable (dot before first parenthesis)
+                    const dotIndex = sourcePath.indexOf('.');
+                    const parenIndex = sourcePath.indexOf('(');
+                    if (dotIndex !== -1 &&
+                        dotIndex < parenIndex &&
+                        !sourcePath.startsWith('use') // Not a hook call like useState()
+                    ) {
+                        // Extract the base variable (before the first dot)
+                        const baseVar = sourcePath.slice(0, dotIndex);
+                        const rest = sourcePath.slice(dotIndex); // includes ".method(...).functionCallReturnValue"
+                        // Check if the base variable can be resolved
+                        if (baseVar in equivalentSignatureVariables &&
+                            baseVar !== varName) {
+                            const baseResolved = equivalentSignatureVariables[baseVar];
+                            // Only resolve if the base resolved to something useful (contains () or .)
+                            if (baseResolved.includes('()') || baseResolved.includes('.')) {
+                                const newPath = baseResolved + rest;
+                                if (newPath !== equivalentSignatureVariables[varName]) {
+                                    equivalentSignatureVariables[varName] = newPath;
+                                    changed = true;
+                                }
+                            }
+                        }
+                    }
+                    // Fix 38: Handle cyScope lazy initializer return values
+                    // When we have viewMode -> cyScope20(), trace through to find what cyScope20 returns.
+                    // The lazy initializer's return value should be the controllable data source.
+                    // Pattern: cyScopeN() where N is a number
+                    const cyScopeMatch = sourcePath.match(/^(cyScope\d+)\(\)$/);
+                    if (cyScopeMatch) {
+                        const cyScopeName = cyScopeMatch[1];
+                        const cyScopeNode = this.scopeNodes[cyScopeName];
+                        if (cyScopeNode?.equivalencies) {
+                            // Look for returnValue equivalency in the cyScope
+                            const returnValueEquivs = cyScopeNode.equivalencies['returnValue'];
+                            if (returnValueEquivs && returnValueEquivs.length > 0) {
+                                // Get the first return value source
+                                const returnSource = returnValueEquivs[0].schemaPath;
+                                // If the return source is a simple variable (not a complex path),
+                                // resolve varName directly to that variable
+                                if (returnSource &&
+                                    !returnSource.includes('(') &&
+                                    !returnSource.includes('[')) {
+                                    // Update varName to point to the return source
+                                    if (equivalentSignatureVariables[varName] !== returnSource) {
+                                        equivalentSignatureVariables[varName] = returnSource;
+                                        changed = true;
+                                    }
+                                }
+                            }
+                        }
+                    }
+                    continue;
+                }
+                // Check if the source path starts with a variable that's also in the map
+                const dotIndex = sourcePath.indexOf('.');
+                let baseVar;
+                let rest;
+                if (dotIndex > 0) {
+                    // Path has a dot: "a.b.c" -> baseVar="a", rest=".b.c"
+                    baseVar = sourcePath.slice(0, dotIndex);
+                    rest = sourcePath.slice(dotIndex); // includes the leading dot
+                }
+                else {
+                    // Path is a simple identifier: "currentEntityAnalysis" -> baseVar="currentEntityAnalysis", rest=""
+                    baseVar = sourcePath;
+                    rest = '';
+                }
+                if (baseVar in equivalentSignatureVariables && baseVar !== varName) {
+                    const baseResolved = equivalentSignatureVariables[baseVar];
+                    // If the base resolves to a hook call, add .functionCallReturnValue
+                    if (baseResolved.endsWith('()')) {
+                        const newPath = baseResolved + '.functionCallReturnValue' + rest;
+                        if (newPath !== equivalentSignatureVariables[varName]) {
+                            equivalentSignatureVariables[varName] = newPath;
+                            changed = true;
+                        }
+                    }
+                    else if (baseResolved !== sourcePath) {
+                        const newPath = baseResolved + rest;
+                        if (newPath !== equivalentSignatureVariables[varName]) {
+                            equivalentSignatureVariables[varName] = newPath;
+                            changed = true;
+                        }
+                    }
+                }
+            }
+            // Stop if no changes were made in this iteration
+            if (!changed)
+                break;
+        }
         return equivalentSignatureVariables;
     }
     getVariableInfo(variableName, scopeName, final) {
@@ -2621,9 +3090,112 @@ export class ScopeDataStructure {
             }
         }
     }
+    /**
+     * Add conditional effects from AST analysis.
+     * Called during scope analysis to collect all setter calls inside conditionals.
+     */
+    addConditionalEffects(effects) {
+        // Add effects, avoiding duplicates based on effect stateVariable and condition paths
+        for (const effect of effects) {
+            const exists = this.rawConditionalEffects.some((existing) => {
+                // Same effect target (stateVariable + value)
+                const sameEffect = existing.effect.stateVariable === effect.effect.stateVariable &&
+                    existing.effect.value === effect.effect.value;
+                if (!sameEffect)
+                    return false;
+                // Same condition(s)
+                if (existing.condition && effect.condition) {
+                    return (existing.condition.path === effect.condition.path &&
+                        existing.condition.requiredValue === effect.condition.requiredValue);
+                }
+                if (existing.conditions && effect.conditions) {
+                    if (existing.conditions.length !== effect.conditions.length)
+                        return false;
+                    return existing.conditions.every((ec, i) => {
+                        const newCond = effect.conditions[i];
+                        return (ec.path === newCond.path &&
+                            ec.requiredValue === newCond.requiredValue);
+                    });
+                }
+                return false;
+            });
+            if (!exists) {
+                this.rawConditionalEffects.push(effect);
+            }
+        }
+    }
+    /**
+     * Get conditional effects collected during analysis.
+     */
+    getConditionalEffects() {
+        return this.rawConditionalEffects;
+    }
+    /**
+     * Add compound conditionals from AST analysis.
+     * Called during scope analysis to collect grouped conditions (e.g., a && b && c).
+     */
+    addCompoundConditionals(compounds) {
+        // Add compounds, avoiding duplicates based on chainId
+        for (const compound of compounds) {
+            const exists = this.rawCompoundConditionals.some((existing) => existing.chainId === compound.chainId);
+            if (!exists) {
+                this.rawCompoundConditionals.push(compound);
+            }
+        }
+    }
+    /**
+     * Get compound conditionals collected during analysis.
+     */
+    getCompoundConditionals() {
+        return this.rawCompoundConditionals;
+    }
+    /**
+     * Add child boundary gating conditions from AST analysis.
+     * These track which conditions must be true for a child component to render.
+     */
+    addChildBoundaryGatingConditions(conditions) {
+        for (const [childName, usages] of Object.entries(conditions)) {
+            if (!this.rawChildBoundaryGatingConditions[childName]) {
+                this.rawChildBoundaryGatingConditions[childName] = [];
+            }
+            // Add usages, avoiding duplicates
+            for (const usage of usages) {
+                const exists = this.rawChildBoundaryGatingConditions[childName].some((existing) => existing.path === usage.path &&
+                    existing.conditionType === usage.conditionType &&
+                    existing.isNegated === usage.isNegated);
+                if (!exists) {
+                    this.rawChildBoundaryGatingConditions[childName].push(usage);
+                }
+            }
+        }
+    }
+    /**
+     * Get enriched child boundary gating conditions with source tracing.
+     * Similar to getEnrichedConditionalUsages but for gating conditions.
+     */
+    getEnrichedChildBoundaryGatingConditions() {
+        const enriched = {};
+        const rootScopeName = this.scopeTreeManager.getTree().name;
+        for (const [childName, usages] of Object.entries(this.rawChildBoundaryGatingConditions)) {
+            enriched[childName] = usages.map((usage) => {
+                // Try to trace this path back to a data source
+                const explanation = this.explainPath(rootScopeName, usage.path);
+                let sourceDataPath;
+                if (explanation.source) {
+                    sourceDataPath = `${explanation.source.scope}.${explanation.source.path}`;
+                }
+                return {
+                    ...usage,
+                    sourceDataPath,
+                };
+            });
+        }
+        return enriched;
+    }
     /**
      * Get enriched conditional usages with source tracing.
      * Uses explainPath to trace each local variable back to its data source.
+     * Preserves all fields from the raw conditional usages including derivedFrom.
      */
     getEnrichedConditionalUsages() {
         const enriched = {};
@@ -2644,9 +3216,29 @@ export class ScopeDataStructure {
         }
         return enriched;
     }
+    /**
+     * Add JSX rendering usages from AST analysis.
+     * These track arrays rendered via .map() and strings interpolated in JSX.
+     */
+    addJsxRenderingUsages(usages) {
+        // Add usages, avoiding duplicates based on path and renderingType
+        for (const usage of usages) {
+            const exists = this.rawJsxRenderingUsages.some((existing) => existing.path === usage.path &&
+                existing.renderingType === usage.renderingType);
+            if (!exists) {
+                this.rawJsxRenderingUsages.push(usage);
+            }
+        }
+    }
+    /**
+     * Get JSX rendering usages collected during analysis.
+     */
+    getJsxRenderingUsages() {
+        return this.rawJsxRenderingUsages;
+    }
     toSerializable() {
-        // Helper to clean cyScope from a string
-        const cleanCyScope = (str) => this.replaceCyScopeInString(str);
+        // Helper to clean cyScope and cyDuplicateKey from a string for output
+        const cleanCyScope = (str) => this.replaceCyScopeInString(str).replace(/::cyDuplicateKey\d+::/g, '');
         // Helper to convert ScopeVariable to SerializableScopeVariable (with cyScope cleaned)
         const toSerializableVariable = (vars) => vars.map((v) => ({
             scopeNodeName: cleanCyScope(v.scopeNodeName),
@@ -2744,6 +3336,15 @@ export class ScopeDataStructure {
                     // Not all variables have schemas - fall back to rootSchema extraction
                     perVariableSchemas = undefined;
                 }
+                else {
+                    // Also check that at least one schema is non-empty
+                    // Bug fix: perCallSignatureSchemas may have entries but with empty schemas {}
+                    // In this case, we should fall through to Fallback which uses rootSchema
+                    const hasNonEmptySchema = Object.values(perVariableSchemas).some((schema) => Object.keys(schema).length > 0);
+                    if (!hasNonEmptySchema) {
+                        perVariableSchemas = undefined;
+                    }
+                }
             }
             // CASE 2: Single call signature with single variable - use perCallSignatureSchemas directly
             // This handles parameterized calls like useFetcher<ConfigData>() where each is a separate efc entry
@@ -2758,7 +3359,11 @@ export class ScopeDataStructure {
                     perVariableSchemas = { [varName]: { ...schema } };
                 }
             }
-            // CASE 3: Parameterized calls that create SEPARATE efc entries (no perCallSignatureSchemas)
+            // CASE 3: Extract from efc.schema when perCallSignatureSchemas is missing or empty
+            // This handles two scenarios:
+            // 1. Parameterized calls that create SEPARATE efc entries (no perCallSignatureSchemas)
+            // 2. Destructuring where perCallSignatureSchemas exists but has EMPTY schemas
+            //
             // When useFetcher<ConfigData>() and useFetcher<SettingsData>() are called, they create separate
             // efc entries because getFunctionCallRoot preserves type parameters. Each entry has its own
             // `schema` field, but due to variable reassignment, the schema may be contaminated with paths
@@ -2774,11 +3379,25 @@ export class ScopeDataStructure {
             //
             // We filter to only keep paths that should belong to THIS call by checking if the
             // receiving variable's equivalency points to this call's return value.
+            //
+            // BUG FIX: The old condition `!efc.perCallSignatureSchemas` was FALSE when the object
+            // existed (even with empty schemas), causing this case to be skipped. We now also check
+            // if all schemas in perCallSignatureSchemas are empty.
+            const hasNonEmptyPerCallSignatureSchemas = efc.perCallSignatureSchemas &&
+                Object.values(efc.perCallSignatureSchemas).some((schema) => Object.keys(schema).length > 0);
+            // Build the call signature prefix that paths should start with
+            const callSigPrefix = `${efc.callSignature}.functionCallReturnValue`;
+            // Check if efc.schema has variable-specific paths (indicating destructuring).
+            // Destructuring: const { entities, gitStatus } = useLoaderData()
+            // - efc.schema has paths like: useLoaderData().functionCallReturnValue.entities...
+            // Multiple calls: const x = useFetcher(); const y = useFetcher();
+            // - efc.schema has paths like: useFetcher().functionCallReturnValue.data...
+            // CASE 3 should only run for destructuring (variable-specific paths exist).
+            const hasVariableSpecificPaths = (efc.receivingVariableNames ?? []).some((varName) => Object.keys(efc.schema).some((path) => path.startsWith(`${callSigPrefix}.${varName}`)));
             if (!perVariableSchemas &&
-                !efc.perCallSignatureSchemas &&
-                numReceivingVars >= 1) {
-                // Build the call signature prefix that paths should start with
-                const callSigPrefix = `${efc.callSignature}.functionCallReturnValue`;
+                !hasNonEmptyPerCallSignatureSchemas &&
+                numReceivingVars >= 1 &&
+                hasVariableSpecificPaths) {
                 // Filter efc.schema to only include paths matching this call signature
                 const filteredSchema = {};
                 for (const [path, type] of Object.entries(efc.schema)) {
@@ -2787,16 +3406,17 @@ export class ScopeDataStructure {
                     }
                 }
                 // Build perVariableSchemas from the filtered schema
+                // For destructuring, filter paths by variable name
                 if (Object.keys(filteredSchema).length > 0) {
                     perVariableSchemas = {};
                     for (const varName of efc.receivingVariableNames ?? []) {
-                        // For each variable, extract paths and transform to functionCallReturnValue format
+                        // For destructuring, extract only paths specific to this variable
+                        const varSpecificPrefix = `${callSigPrefix}.${varName}`;
                         const varSchema = {};
                         for (const [path, type] of Object.entries(filteredSchema)) {
-                            if (path.startsWith(callSigPrefix)) {
-                                // Transform to generic functionCallReturnValue path
-                                // e.g., "useFetcher<ConfigData>().functionCallReturnValue.data.data.theme"
-                                //     -> "functionCallReturnValue.data.data.theme"
+                            if (path.startsWith(varSpecificPrefix)) {
+                                // Transform: useLoaderData().functionCallReturnValue.entities.sha
+                                //         -> functionCallReturnValue.entities.sha (keep the variable name)
                                 const suffix = path.slice(callSigPrefix.length);
                                 const returnValuePath = `functionCallReturnValue${suffix}`;
                                 varSchema[returnValuePath] = type;
@@ -2838,7 +3458,8 @@ export class ScopeDataStructure {
                         }
                     }
                     if (Object.keys(varSchema).length > 0) {
-                        perVariableSchemas[varName] = varSchema;
+                        // Clean the variable name when using as key in output
+                        perVariableSchemas[cleanCyScope(varName)] = varSchema;
                     }
                 }
                 // Only include if we have any entries
@@ -2859,8 +3480,13 @@ export class ScopeDataStructure {
                     }, {})
                     : undefined,
                 allCallSignatures: efc.allCallSignatures,
-                receivingVariableNames: efc.receivingVariableNames,
-                callSignatureToVariable: efc.callSignatureToVariable,
+                receivingVariableNames: efc.receivingVariableNames?.map(cleanCyScope),
+                callSignatureToVariable: efc.callSignatureToVariable
+                    ? Object.fromEntries(Object.entries(efc.callSignatureToVariable).map(([k, v]) => [
+                        k,
+                        cleanCyScope(v),
+                    ]))
+                    : undefined,
                 perVariableSchemas,
             };
         });
@@ -2962,6 +3588,12 @@ export class ScopeDataStructure {
         };
         // Apply deduplication
         const deduplicatedExternalFunctionCalls = deduplicateParameterizedEntries(externalFunctionCalls);
+        // IMPORTANT: Get equivalent signature variables BEFORE calling getFunctionResult
+        // because getFunctionResult calls validateSchema which may remove equivalencies
+        // during the finalize step (e.g., cleanNonObjectFunctions removes method call
+        // equivalencies like `segments -> splat.split('/').functionCallReturnValue`).
+        // Fix 33: Move this call before any schema validation to preserve method call chains.
+        const equivalentSignatureVariables = this.getEquivalentSignatureVariables();
         // Get root function result
         const rootFunction = getFunctionResult();
         // Get results for each external function (use cleaned calls for consistency)
@@ -2969,14 +3601,29 @@ export class ScopeDataStructure {
         for (const efc of cleanedExternalCalls) {
             functionResults[efc.name] = getFunctionResult(efc.name);
         }
-        // Get equivalent signature variables
-        const equivalentSignatureVariables = this.getEquivalentSignatureVariables();
         const environmentVariables = this.getEnvironmentVariables();
         // Get enriched conditional usages with source tracing
         const enrichedConditionalUsages = this.getEnrichedConditionalUsages();
         const conditionalUsages = Object.keys(enrichedConditionalUsages).length > 0
             ? enrichedConditionalUsages
             : undefined;
+        // Get conditional effects (setter calls inside conditionals)
+        const conditionalEffects = this.rawConditionalEffects.length > 0
+            ? this.rawConditionalEffects
+            : undefined;
+        // Get compound conditionals (grouped conditions that must all be true)
+        const compoundConditionals = this.rawCompoundConditionals.length > 0
+            ? this.rawCompoundConditionals
+            : undefined;
+        // Get child boundary gating conditions
+        const enrichedGatingConditions = this.getEnrichedChildBoundaryGatingConditions();
+        const childBoundaryGatingConditions = Object.keys(enrichedGatingConditions).length > 0
+            ? enrichedGatingConditions
+            : undefined;
+        // Get JSX rendering usages (arrays via .map(), strings via interpolation)
+        const jsxRenderingUsages = this.rawJsxRenderingUsages.length > 0
+            ? this.rawJsxRenderingUsages
+            : undefined;
         return {
             externalFunctionCalls: deduplicatedExternalFunctionCalls,
             rootFunction,
@@ -2984,6 +3631,10 @@ export class ScopeDataStructure {
             equivalentSignatureVariables,
             environmentVariables,
             conditionalUsages,
+            conditionalEffects,
+            compoundConditionals,
+            childBoundaryGatingConditions,
+            jsxRenderingUsages,
         };
     }
     // ═══════════════════════════════════════════════════════════════════════════