@codeyam/codeyam-cli 0.1.0-staging.b8a55ba → 0.1.0-staging.c90f8c9

package/analyzer-template/packages/ai/src/lib/promptGenerators/generateChangesEntityScenariosGenerator.ts

@@ -1,19 +1,11 @@
-import {
-  DataStructure,
-  Entity,
-  Scenario,
-  ReadonlyAnalysisMap,
-  Analysis,
-} from '~codeyam/types';
-import gatherRelevantDependentKeyAttributes from '../gatherRelevantDependentKeyAttributes';
+import { DataStructure, Entity, ExecutionFlow, Scenario } from '~codeyam/types';
 
 interface GenerateChangesEntityScenariosGeneratorArgs {
   entity: Pick<Entity, 'name' | 'code' | 'metadata'>;
   mergedDataStructure: Omit<DataStructure, 'equivalentSignatureVariables'>;
-  keyAttributes: Analysis['metadata']['keyAttributes'];
-  addedKeyAttributes: Analysis['metadata']['keyAttributes'];
-  removedKeyAttributes: Analysis['metadata']['keyAttributes'];
-  dependentAnalyses: ReadonlyAnalysisMap;
+  executionFlows?: ExecutionFlow[];
+  addedFlows?: ExecutionFlow[];
+  removedFlows?: ExecutionFlow[];
   existingScenarios: Scenario[];
   commitDiff: string;
   error: boolean;
@@ -22,80 +14,26 @@ interface GenerateChangesEntityScenariosGeneratorArgs {
 
 export default function generateChangesEntityScenariosGenerator({
   entity,
-  mergedDataStructure,
-  keyAttributes,
-  addedKeyAttributes,
-  removedKeyAttributes,
-  dependentAnalyses,
+  executionFlows,
+  addedFlows,
+  removedFlows,
   existingScenarios,
   commitDiff,
   error,
   changedDataStructureFields = [],
 }: GenerateChangesEntityScenariosGeneratorArgs) {
-  const relevantDependentKeyAttributesFlat =
-    gatherRelevantDependentKeyAttributes(
-      entity,
-      mergedDataStructure,
-      dependentAnalyses,
-    );
-
-  // Restructure flat array into nested format: { [filePath]: { [entityName]: KeyAttribute[] } }
-  const relevantDependentKeyAttributes: Record<
-    string,
-    Record<string, any[]>
-  > = {};
-  for (const attr of relevantDependentKeyAttributesFlat) {
-    const filePath = (attr as any).filePath;
-    const entityName = (attr as any).originalEntityName;
-
-    if (!filePath || !entityName) continue;
-
-    if (!relevantDependentKeyAttributes[filePath]) {
-      relevantDependentKeyAttributes[filePath] = {};
-    }
-    if (!relevantDependentKeyAttributes[filePath][entityName]) {
-      relevantDependentKeyAttributes[filePath][entityName] = [];
-    }
-    relevantDependentKeyAttributes[filePath][entityName].push(attr);
-  }
-
-  const formatKeyAttrs = (attrs: Analysis['metadata']['keyAttributes']) =>
-    attrs.map((ka) => ({
-      dataStructurePath: ka.dataStructurePath,
-      localVariable: ka.internalPath,
-      description: ka.description,
-      // Include indexed validValueOptions for structured references
-      validValueOptions: ka.validValueOptions.map((value, index) => ({
-        index,
-        value,
-      })),
-      ...(ka.errorValueOptions?.length && {
-        errorValueOptions: ka.errorValueOptions.map((value, index) => ({
-          index,
-          value,
-        })),
-      }),
-      // Include new fields when present
-      ...(ka.valueType && { valueType: ka.valueType }),
-      ...(ka.dependencies && { dependencies: ka.dependencies }),
-      // Include source locations showing where this attribute is used in conditionals
-      ...(ka.sourceLocations?.length && {
-        codeUsages: ka.sourceLocations.map((loc) => ({
-          line: loc.lineNumber,
-          code: loc.codeSnippet,
-          context: loc.description,
-        })),
-      }),
-    }));
-
   const addedSection =
-    addedKeyAttributes?.length > 0
-      ? JSON.stringify(formatKeyAttrs(addedKeyAttributes), null, 2)
+    addedFlows && addedFlows.length > 0
+      ? JSON.stringify(addedFlows, null, 2)
       : 'None';
 
   const removedSection =
-    removedKeyAttributes?.length > 0
-      ? JSON.stringify(removedKeyAttributes, null, 2)
+    removedFlows && removedFlows.length > 0
+      ? JSON.stringify(
+          removedFlows.map((f) => ({ id: f.id, name: f.name })),
+          null,
+          2,
+        )
       : 'None';
 
   const changedFieldsSection =
@@ -107,18 +45,18 @@ Fields that changed type, were added, or removed:
 ${JSON.stringify(changedDataStructureFields, null, 2)}
 \`\`\`
 
-**Update keyAttributeInstructions for affected scenarios** (e.g., if "stats.visualEntities" changed from array to number).
+**Update scenarios if their coveredFlows depend on these changed fields.**
 `
       : '';
 
   const existingScenariosJson = JSON.stringify(
     existingScenarios
-      .filter((s) => (error ? !!s.metadata.error : !s.metadata.error))
+      .filter((s) => (error ? !!s.metadata?.error : !s.metadata?.error))
       .map((s) => ({
         name: s.name,
         description: s.description,
-        keyAttributeInstructions: s.metadata.keyAttributeInstructions,
-        playwrightInstructions: s.metadata.playwrightInstructions,
+        coveredFlows: s.metadata?.coveredFlows || [],
+        playwrightInstructions: s.metadata?.playwrightInstructions,
       })),
     null,
     2,
@@ -132,77 +70,29 @@ ${commitDiff}
 \`\`\``
     : '';
 
-  const dependencySection =
-    !error &&
-    relevantDependentKeyAttributes &&
-    Object.keys(relevantDependentKeyAttributes).length > 0
-      ? `
-## Dependency Key Attributes
+  const executionFlowsSection =
+    executionFlows && executionFlows.length > 0
+      ? `## Current Execution Flows
+All distinct outcomes/behaviors this component can currently produce:
 \`\`\`json
-${JSON.stringify(
-  Object.keys(relevantDependentKeyAttributes).reduce((acc: any, path) => {
-    acc[path] = Object.keys(relevantDependentKeyAttributes[path]).reduce(
-      (entityAcc: any, entityName) => {
-        entityAcc[entityName] = relevantDependentKeyAttributes[path][
-          entityName
-        ].map((ka: any) => ({
-          dataStructurePath: ka.dataStructurePath,
-          localVariable: ka.path || ka.internalPath,
-          description: ka.description,
-          // Include indexed validValueOptions for structured references
-          validValueOptions: (ka.validValueOptions || []).map(
-            (value: string, index: number) => ({
-              index,
-              value,
-            }),
-          ),
-          ...(ka.errorValueOptions?.length && {
-            errorValueOptions: ka.errorValueOptions.map(
-              (value: string, index: number) => ({
-                index,
-                value,
-              }),
-            ),
-          }),
-          // Include new fields when present
-          ...(ka.valueType && { valueType: ka.valueType }),
-          ...(ka.dependencies && { dependencies: ka.dependencies }),
-          // Include source locations showing where this attribute is used in conditionals
-          ...(ka.sourceLocations?.length && {
-            codeUsages: ka.sourceLocations.map((loc: any) => ({
-              line: loc.lineNumber,
-              code: loc.codeSnippet,
-              context: loc.description,
-            })),
-          }),
-        }));
-        return entityAcc;
-      },
-      {},
-    );
-    return acc;
-  }, {}),
-  null,
-  2,
-)}
-\`\`\``
+${JSON.stringify(executionFlows, null, 2)}
+\`\`\`
+`
       : '';
 
-  return `## Added Key Attributes
+  return `## Added Execution Flows
+New flows that need scenario coverage:
 \`\`\`json
 ${addedSection}
 \`\`\`
 
-## Removed Key Attributes
+## Removed Execution Flows
+Flows that no longer exist (remove from scenarios):
 \`\`\`json
 ${removedSection}
 \`\`\`
 ${changedFieldsSection}
-## Current Key Attributes
-\`\`\`json
-${JSON.stringify(formatKeyAttrs(keyAttributes), null, 2)}
-\`\`\`
-
+${executionFlowsSection}
 ## Existing Scenarios
 \`\`\`json
 ${existingScenariosJson}
@@ -212,5 +102,5 @@ ${diffSection}
 ## Current Code
 \`\`\`typescript
 ${entity.code}
-\`\`\`${dependencySection}`;
+\`\`\``;
 }

package/analyzer-template/packages/ai/src/lib/promptGenerators/generateChunkPrompt.ts

@@ -0,0 +1,82 @@
+import {
+  ExecutionFlow,
+  Scenario,
+  ScenariosDataStructure,
+} from '~codeyam/types';
+import simplifyKeysForLLM from './simplifyKeysForLLM';
+import noErrorAttributes from './noErrorAttributes';
+import { JsonTypeDefinition } from '~codeyam/types';
+
+type RequiredValue = NonNullable<ExecutionFlow['requiredValues']>[number];
+
+interface GenerateChunkPromptArgs {
+  scenario: Scenario;
+  chunk: ScenariosDataStructure['dataForMocks'];
+  chunkIndex: number;
+  totalChunks: number;
+  relevantRequiredValues: RequiredValue[];
+}
+
+/**
+ * Generate a prompt for a focused LLM call to generate mock data for a single chunk.
+ *
+ * Large data structures overwhelm LLMs, causing them to make mistakes on some keys.
+ * By processing smaller chunks, each key gets more focused attention.
+ */
+export default function generateChunkPrompt({
+  scenario,
+  chunk,
+  chunkIndex,
+  totalChunks,
+  relevantRequiredValues,
+}: GenerateChunkPromptArgs): string {
+  // Clean up the schema for LLM consumption
+  const cleanedSchema = simplifyKeysForLLM(
+    noErrorAttributes(chunk) as JsonTypeDefinition,
+  );
+
+  const keysInChunk = Object.keys(chunk || {});
+
+  // Build requirements section if there are relevant requiredValues
+  const requirementsSection =
+    relevantRequiredValues.length > 0
+      ? `## Execution Flow Requirements for These Keys
+These specific values MUST be set to produce the correct scenario behavior:
+\`\`\`json
+${JSON.stringify(relevantRequiredValues, null, 2)}
+\`\`\`
+
+`
+      : '';
+
+  return `Generate mock data for chunk ${chunkIndex + 1} of ${totalChunks}.
+
+## Scenario
+\`\`\`json
+${JSON.stringify({ name: scenario.name, description: scenario.description }, null, 2)}
+\`\`\`
+
+${requirementsSection}## Keys in This Chunk (${keysInChunk.length} keys)
+Generate data for ONLY these keys:
+${keysInChunk.map((k) => `- \`${k}\``).join('\n')}
+
+## Schema for This Chunk
+\`\`\`json
+${JSON.stringify(cleanedSchema, null, 2)}
+\`\`\`
+
+## Instructions
+1. Match the EXACT structure shown in the schema
+2. Keys with special characters like \`*\` are LITERAL keys, not patterns
+3. If requiredValues are shown above, set values that satisfy them
+4. For paths like \`functionCall().functionCallReturnValue.property\`, the mock data key is just \`functionCall()\`
+
+Return ONLY a JSON object with this structure:
+\`\`\`json
+{
+  "mockData": {
+    // fill in ONLY the keys from this chunk
+  }
+}
+\`\`\``;
+}

package/analyzer-template/packages/ai/src/lib/promptGenerators/generateCriticalKeysPrompt.ts

@@ -0,0 +1,103 @@
+import {
+  ExecutionFlow,
+  Scenario,
+  ScenariosDataStructure,
+} from '~codeyam/types';
+import simplifyKeysForLLM from './simplifyKeysForLLM';
+import noErrorAttributes from './noErrorAttributes';
+import { JsonTypeDefinition } from '~codeyam/types';
+
+interface GenerateCriticalKeysPromptArgs {
+  scenario: Scenario;
+  executionFlows: ExecutionFlow[] | undefined;
+  criticalKeys: string[];
+  fullDataForMocks: ScenariosDataStructure['dataForMocks'];
+}
+
+/**
+ * Generate a prompt for a focused LLM call to generate only the critical mock data keys.
+ *
+ * When a scenario has covered flows with requiredValues, only a subset of the full
+ * dataForMocks schema is actually needed to satisfy those requirements. This prompt
+ * focuses the LLM on JUST those critical keys, avoiding confusion from large schemas.
+ *
+ * This is called BEFORE the main data generation to ensure critical keys are correctly
+ * generated with full attention from the LLM.
+ */
+export default function generateCriticalKeysPrompt({
+  scenario,
+  executionFlows,
+  criticalKeys,
+  fullDataForMocks,
+}: GenerateCriticalKeysPromptArgs): string {
+  // Build the subset schema with only critical keys
+  const criticalSchema: Record<string, any> = {};
+  if (fullDataForMocks && typeof fullDataForMocks === 'object') {
+    for (const key of criticalKeys) {
+      if (key in fullDataForMocks) {
+        criticalSchema[key] = (fullDataForMocks as Record<string, any>)[key];
+      }
+    }
+  }
+
+  // Clean up the schema for LLM consumption
+  const cleanedSchema = simplifyKeysForLLM(
+    noErrorAttributes(criticalSchema) as JsonTypeDefinition,
+  );
+
+  // Get the covered flows and their requirements
+  const coveredFlowIds = scenario.metadata?.coveredFlows || [];
+  const coveredFlowRequirements = coveredFlowIds
+    .map((flowId) => {
+      const flow = executionFlows?.find((f) => f.id === flowId);
+      if (!flow) return null;
+      return {
+        flowId: flow.id,
+        flowName: flow.name,
+        flowDescription: flow.description,
+        requiredValues: flow.requiredValues,
+      };
+    })
+    .filter(Boolean);
+
+  return `Generate mock data for these CRITICAL keys. Pay close attention to the requiredValues.
+
+## IMPORTANT: These keys are critical for satisfying the execution flow requirements
+The keys below directly control the scenario's behavior. Generate values that EXACTLY satisfy the requiredValues.
+
+## Scenario
+\`\`\`json
+${JSON.stringify({ name: scenario.name, description: scenario.description }, null, 2)}
+\`\`\`
+
+## Execution Flow Requirements
+These are the specific values that MUST be set:
+\`\`\`json
+${JSON.stringify(coveredFlowRequirements, null, 2)}
+\`\`\`
+
+## Critical Keys Schema (generate data for ONLY these keys)
+\`\`\`json
+${JSON.stringify(cleanedSchema, null, 2)}
+\`\`\`
+
+## Instructions
+1. Match the EXACT structure shown in the schema
+2. Keys with special characters like \`*\` are LITERAL keys, not patterns
+3. Set values that satisfy ALL the requiredValues above
+4. For paths like \`functionCall().functionCallReturnValue.property\`, the mock data key is just \`functionCall()\`
+
+Return ONLY a JSON object with this structure:
+\`\`\`json
+{
+  "scenarioData": {
+    "scenarioName": "${scenario.name}",
+    "data": {
+      "mockData": {
+        // fill in ONLY the critical keys above
+      }
+    }
+  }
+}
+\`\`\``;
+}

package/analyzer-template/packages/ai/src/lib/promptGenerators/generateEntityScenarioDataGenerator.ts

@@ -1,21 +1,84 @@
-import { ScenariosDataStructure, Scenario, ScenarioData } from '~codeyam/types';
+import {
+  ScenariosDataStructure,
+  Scenario,
+  ScenarioData,
+  JsonTypeDefinition,
+  ExecutionFlow,
+} from '~codeyam/types';
 import noErrorAttributes from './noErrorAttributes';
+import simplifyKeysForLLM from './simplifyKeysForLLM';
+
+/**
+ * Sort object keys by the size of their JSON-stringified values (smallest first).
+ * This ensures small keys appear before large keys in the LLM prompt, increasing
+ * the chance they get generated before the LLM loses focus on large schemas.
+ */
+function sortKeysBySize(obj: Record<string, any>): Record<string, any> {
+  const entries = Object.entries(obj);
+  entries.sort(([, a], [, b]) => {
+    const sizeA = JSON.stringify(a).length;
+    const sizeB = JSON.stringify(b).length;
+    return sizeA - sizeB;
+  });
+  return Object.fromEntries(entries);
+}
+
+interface GeneratePromptOptions {
+  /** When true, mockData has already been generated via chunks - skip it in main call */
+  mockDataAlreadyGenerated?: boolean;
+}
 
 export default function generateEntityScenarioDataGenerator(
   structure: ScenariosDataStructure,
   scenario: Scenario,
+  executionFlows: ExecutionFlow[] | undefined,
   defaultScenarioData?: ScenarioData,
   incompleteResponse?: string,
+  options?: GeneratePromptOptions,
 ) {
   if (incompleteResponse) {
     return incompleteResponse;
   }
 
+  // Get the covered flows for this scenario and look up their requiredValues
+  const coveredFlowIds = scenario.metadata?.coveredFlows || [];
+  const coveredFlowRequirements = coveredFlowIds
+    .map((flowId) => {
+      const flow = executionFlows?.find((f) => f.id === flowId);
+      if (!flow) return null;
+      return {
+        flowId: flow.id,
+        flowName: flow.name,
+        flowDescription: flow.description,
+        requiredValues: flow.requiredValues,
+      };
+    })
+    .filter(Boolean);
+
+  // Get blocking flows that are NOT covered by this scenario
+  // These should be explicitly avoided in the mock data
+  const blockingFlowsToAvoid = (executionFlows || [])
+    .filter(
+      (flow) =>
+        flow.blocksOtherFlows === true && !coveredFlowIds.includes(flow.id),
+    )
+    .map((flow) => ({
+      flowId: flow.id,
+      flowName: flow.name,
+      flowDescription: flow.description,
+      requiredValues: flow.requiredValues,
+    }));
+
   const scenarioJson = JSON.stringify(
     {
       name: scenario.name,
       description: scenario.description,
-      keyAttributeInstructions: scenario.metadata.keyAttributeInstructions,
+      // Include the flow requirements to guide data generation
+      coveredFlows: coveredFlowRequirements,
+      // Include blocking flows to avoid
+      ...(blockingFlowsToAvoid.length > 0 && {
+        blockingFlowsToAvoid,
+      }),
     },
     null,
     2,
@@ -30,12 +93,33 @@ ${JSON.stringify(defaultScenarioData.data, null, 2)}
 `
     : '';
 
-  const mockDataSection = structure.dataForMocks
-    ? `## mockData Structure
+  // Simplify verbose function call keys for LLM consumption, then sort by size.
+  // The static analysis generates keys like "useQuery({ id: Number(id), onSuccess: async (quote) => { ...30 lines... } })"
+  // which confuse the LLM. simplifyKeysForLLM reduces them to "useQuery({ id, onSuccess: () => <truncated> })"
+  // while the reconcileMockDataKeys function will still match the simplified response back to original keys.
+  // Then sort keys by size (smallest first) so small keys appear before large keys,
+  // increasing the chance the LLM generates all keys for large schemas.
+  const cleanedDataForMocks = structure.dataForMocks
+    ? simplifyKeysForLLM(
+        noErrorAttributes(structure.dataForMocks) as JsonTypeDefinition,
+      )
+    : null;
+  const sortedDataForMocks =
+    cleanedDataForMocks &&
+    typeof cleanedDataForMocks === 'object' &&
+    !Array.isArray(cleanedDataForMocks)
+      ? sortKeysBySize(cleanedDataForMocks as Record<string, any>)
+      : cleanedDataForMocks;
+
+  // When mockData has already been generated via chunks, skip it in the main call
+  const mockDataSection = options?.mockDataAlreadyGenerated
+    ? '## mockData Structure\nmockData has been pre-generated—return `{}` for mockData.'
+    : sortedDataForMocks
+      ? `## mockData Structure
 \`\`\`json
-${JSON.stringify(noErrorAttributes(structure.dataForMocks), null, 2)}
+${JSON.stringify(sortedDataForMocks, null, 2)}
 \`\`\``
-    : '## mockData Structure\nNone—return `{}` for mockData.';
+      : '## mockData Structure\nNone—return `{}` for mockData.';
 
   const argumentsSection = structure.arguments
     ? `## argumentsData Structure

package/analyzer-template/packages/ai/src/lib/promptGenerators/generateEntityScenariosGenerator.ts

@@ -1,105 +1,30 @@
-import { Analysis, Entity } from '~codeyam/types';
+import { Entity, ExecutionFlow } from '~codeyam/types';
 
 interface GenerateEntityScenariosGeneratorArgs {
   entity: Pick<Entity, 'code' | 'metadata' | 'filePath' | 'name'>;
-  keyAttributes: Analysis['metadata']['keyAttributes'];
+  executionFlows?: ExecutionFlow[];
   error: boolean;
 }
 
 export default function generateEntityScenariosGenerator({
   entity,
-  keyAttributes,
+  executionFlows,
   error,
 }: GenerateEntityScenariosGeneratorArgs) {
-  const thisEntityKeyAttributes = keyAttributes?.filter(
-    (ka) => !ka.dependentEntityName,
-  );
-
-  const relevantDependentKeyAttributes = keyAttributes?.filter(
-    (ka) => ka.dependentEntityName,
-  );
-
-  const keyAttrsJson = JSON.stringify(
-    thisEntityKeyAttributes.map((ka) => ({
-      dataStructurePath: ka.dataStructurePath,
-      localVariable: ka.internalPath,
-      description: ka.description,
-      // Include indexed validValueOptions for structured references
-      validValueOptions: ka.validValueOptions.map((value, index) => ({
-        index,
-        value,
-      })),
-      ...(ka.errorValueOptions?.length && {
-        errorValueOptions: ka.errorValueOptions.map((value, index) => ({
-          index,
-          value,
-        })),
-      }),
-      // Include new fields when present
-      ...(ka.valueType && { valueType: ka.valueType }),
-      ...(ka.dependencies && { dependencies: ka.dependencies }),
-      // Include source locations showing where this attribute is used in conditionals
-      ...(ka.sourceLocations?.length && {
-        codeUsages: ka.sourceLocations.map((loc) => ({
-          line: loc.lineNumber,
-          code: loc.codeSnippet,
-          context: loc.description,
-        })),
-      }),
-    })),
-    null,
-    2,
-  );
-
-  const dependencySection =
-    !error &&
-    relevantDependentKeyAttributes &&
-    relevantDependentKeyAttributes.length > 0
-      ? `
-## Dependency Key Attributes
-\`\`\`json
-${JSON.stringify(
-  relevantDependentKeyAttributes.map((ka) => ({
-    dataStructurePath: ka.dataStructurePath,
-    localVariable: ka.internalPath,
-    forDependency: ka.dependentEntityName,
-    description: ka.description,
-    // Include indexed validValueOptions for structured references
-    validValueOptions: ka.validValueOptions.map((value, index) => ({
-      index,
-      value,
-    })),
-    ...(ka.errorValueOptions?.length && {
-      errorValueOptions: ka.errorValueOptions.map((value, index) => ({
-        index,
-        value,
-      })),
-    }),
-    // Include new fields when present
-    ...(ka.valueType && { valueType: ka.valueType }),
-    ...(ka.dependencies && { dependencies: ka.dependencies }),
-    // Include source locations showing where this attribute is used in conditionals
-    ...(ka.sourceLocations?.length && {
-      codeUsages: ka.sourceLocations.map((loc) => ({
-        line: loc.lineNumber,
-        code: loc.codeSnippet,
-        context: loc.description,
-      })),
-    }),
-  })),
-  null,
-  2,
-)}
-\`\`\``
-      : '';
-
-  return `## Key Attributes
+  // Build execution flows section
+  const executionFlowsSection =
+    !error && executionFlows && executionFlows.length > 0
+      ? `## Execution Flows
+These are all the distinct outcomes/behaviors this component can produce. Create scenarios that maximize coverage of these flows.
 \`\`\`json
-${keyAttrsJson}
+${JSON.stringify(executionFlows, null, 2)}
 \`\`\`
 
-## Code
+`
+      : '';
+
+  return `${executionFlowsSection}## Code
 \`\`\`typescript
 ${entity.code}
-\`\`\`${dependencySection}`;
+\`\`\``;
 }